rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1152
+NTFK_Struct, // non-trivial C struct.
+NTFK_Array// array that has non-trivial elements.
+ };
ahatanak wrote:
> rjmccall wrote:
> > We don't actually distinguish arrays in
phosek added a comment.
ping?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D41103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv updated this revision to Diff 127828.
faisalv retitled this revision from "[Parser] Diagnose storage classes in
template parameter declarations" to "Diagnose invalid decl-specifiers in
non-type template parameter declarations (original author miyuki!)".
faisalv edited the summary of this
ahatanak added inline comments.
Comment at: include/clang/AST/Type.h:1152
+NTFK_Struct, // non-trivial C struct.
+NTFK_Array// array that has non-trivial elements.
+ };
rjmccall wrote:
> We don't actually distinguish arrays in DestructionKind. Is
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM. The array accesses here are just being represented as their scalar-access
types. In the future, we should update this to represent them as fields in
their parent structs, but this is
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D41452#961710, @rjmccall wrote:
> LGTM.
Me too.
Repository:
rL LLVM
https://reviews.llvm.org/D41452
___
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ created this revision.
NoQ added reviewers: dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun.
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1152
+NTFK_Struct, // non-trivial C struct.
+NTFK_Array// array that has non-trivial elements.
+ };
We don't actually distinguish arrays in DestructionKind. Is it important here?
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Driver.cpp:1508
+if (!SystemConfigDir.empty())
+ llvm::errs() << "System configuration file directory: "
+ <<
rjmccall added a comment.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D41452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
You can pass multiple -check-prefix arguments to FileCheck and it'll match all
of them. You can use that to make your test change simpler: make the existing
RUN check for both PATH and OLD-PATH and the new RUN check for both PATH and
NEW-PATH, then change all the
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, I think that's reasonable enough. LGTM.
https://reviews.llvm.org/D41311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ahatanak updated this revision to Diff 127818.
ahatanak added a comment.
- Improved IRGen for copying trivial fields in a non-trivial C struct. IRGen in
CGNonTrivialStruct.cpp now calls a single memcpy if there are consecutive
trivial fields in a struct (it does something similar to what
NoQ added a comment.
A slower explanation of the approach in '3.' in the previous message:
(1) Evaluate operator new() aka the allocator call as usual.
(2) Take the return value of (1) as usual.
(3) Take `CXXConstructExpr` which is the child of the `CXXNewExpr` that
triggered the allocator call
NoQ added a comment.
1. Devin suggested a fantastic idea: it may be great to have a new
`LocationContext` for whatever happens within the big-new-expression. This
would help immensely with CFG look-aheads and look-behinds and reduce parent
map usage - not only for operator new, but for other
On 12/20/2017 08:07 PM, Erich Keane via cfe-commits wrote:
Author: erichkeane
Date: Wed Dec 20 18:07:46 2017
New Revision: 321239
URL: http://llvm.org/viewvc/llvm-project?rev=321239=rev
Log:
Fix for PR32990
This fixes the bug in https://bugs.llvm.org/show_bug.cgi?id=32990.
Too late now, but
Author: erichkeane
Date: Wed Dec 20 18:07:46 2017
New Revision: 321239
URL: http://llvm.org/viewvc/llvm-project?rev=321239=rev
Log:
Fix for PR32990
This fixes the bug in https://bugs.llvm.org/show_bug.cgi?id=32990.
Patch By: zahiraam
Differential Revision: https://reviews.llvm.org/D39063
Author: aaronballman
Date: Wed Dec 20 17:34:46 2017
New Revision: 321237
URL: http://llvm.org/viewvc/llvm-project?rev=321237=rev
Log:
Reverting a file that snuck in with r321229 by accident.
Modified:
cfe/trunk/test/Misc/ast-dump-color.cpp
Modified: cfe/trunk/test/Misc/ast-dump-color.cpp
Hello everyone,
LLVM buildmaster will be updated and restarted after 8 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 127806.
juliehockett added a comment.
Updating matcher to include overloaded operators outside classes.
https://reviews.llvm.org/D41363
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
mcgrathr created this revision.
mcgrathr added a reviewer: phosek.
Herald added a subscriber: mgorny.
Enable assertions in both stages.
Release+Asserts is fast enough.
No need to let insanity through.
Repository:
rC Clang
https://reviews.llvm.org/D41471
Files:
juliehockett added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-overloaded-operator.rst:17
+
+See the features disallowed in Fuchsia at
https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.md
JonasToth wrote:
> Could you make the link
juliehockett updated this revision to Diff 127799.
juliehockett marked 7 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41363
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCRT321232: [ubsan] Diagnose noreturn functions which return
(compiler-rt) (authored by vedantk, committed by ).
Herald
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321232: [ubsan] Diagnose noreturn functions which return
(compiler-rt) (authored by vedantk, committed by ).
Changed
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321231: [ubsan] Diagnose noreturn functions which return
(authored by vedantk, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D40698
Files:
docs/UndefinedBehaviorSanitizer.rst
Author: vedantk
Date: Wed Dec 20 16:10:24 2017
New Revision: 321230
URL: http://llvm.org/viewvc/llvm-project?rev=321230=rev
Log:
[Driver] Ensure no overlap between trapping & recoverable sanitizers. NFC.
This is NFC because in EmitCheck(), -fsanitize-trap=X overrides
-fsanitize-recover=X.
Author: vedantk
Date: Wed Dec 20 16:10:25 2017
New Revision: 321231
URL: http://llvm.org/viewvc/llvm-project?rev=321231=rev
Log:
[ubsan] Diagnose noreturn functions which return
Diagnose 'unreachable' UB when a noreturn function returns.
1. Insert a check at the end of functions marked
Author: aaronballman
Date: Wed Dec 20 15:11:05 2017
New Revision: 321228
URL: http://llvm.org/viewvc/llvm-project?rev=321228=rev
Log:
Silence a -Wreorder warning from r321223.
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
Modified: cfe/trunk/lib/AST/ASTDumper.cpp
URL:
vsk added a comment.
I have some results from the development build of our kernel ('-O2 -g -flto').
According to dwarfdump -statistics, when compiled with -fextend-lifetimes, the
percentage of covered scope bytes increases from 62% to 69%. The number of
inlined scopes decreases by 4%, and (I
mclow.lists added a comment.
I've got an implementation for this, too - at
https://github.com/mclow/snippets/blob/master/to_chars.cpp
I'll compare them.
Repository:
rCXX libc++
https://reviews.llvm.org/D41458
___
cfe-commits mailing list
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: morehouse
Date: Wed Dec 20 14:29:23 2017
New Revision: 321226
URL: http://llvm.org/viewvc/llvm-project?rev=321226=rev
Log:
[clangd-fuzzer] Update ClangdLSPServer constructor call.
Build was broken by r321092.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
aaron.ballman closed this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Thanks, Hal! Committed in r321223.
Comment at: lib/AST/ASTDumper.cpp:218
+: ASTDumper(OS, Traits, SM, ShowColors, LangOptions()) {}
+
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D40448#961398, @aaron.ballman wrote:
> P-p-p-power ping! :-)
LGTM
Comment at: lib/AST/ASTDumper.cpp:218
+: ASTDumper(OS, Traits, SM,
ioeric added inline comments.
Comment at: clangd/index/Index.h:105
+ /// What to insert when completing this symbol (plain text version).
+ std::string CompletionPlainInsertText;
+ /// What to insert when completing this symbol (snippet version).
sammccall
ioeric updated this revision to Diff 127781.
ioeric marked an inline comment as done.
ioeric added a comment.
- Merged with origin/master
- Addressed some more comments.
- Add new fields to YAML.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41345
Files:
lebedev.ri updated this revision to Diff 127780.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
- Added C tests
- Cleaned-up spurious semicolons
- Docs are still not regenerated, somehow that script results in a huge diff
for me.
Repository:
rC Clang
aaron.ballman abandoned this revision.
aaron.ballman added a comment.
Closing this via "abandon" so that Richard doesn't have to accept it in order
for me to close it. It's already been committed.
https://reviews.llvm.org/D18768
___
cfe-commits
aaron.ballman added a comment.
P-p-p-power ping! :-)
https://reviews.llvm.org/D40448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai updated this revision to Diff 127779.
vsapsai added a comment.
- Address review comment, compare ArgI type with Arg type. Update tests to
account for coerced store when types don't match.
https://reviews.llvm.org/D41311
Files:
clang/lib/CodeGen/CGCall.cpp
This revision was automatically updated to reflect the committed changes.
arphaman marked 2 inline comments as done.
Closed by commit rC321222: Fix an assertion failure regression in
isDesignatorAtObjectEnd for (authored by arphaman, committed by ).
Changed prior to commit:
Author: arphaman
Date: Wed Dec 20 13:03:38 2017
New Revision: 321222
URL: http://llvm.org/viewvc/llvm-project?rev=321222=rev
Log:
Fix an assertion failure regression in isDesignatorAtObjectEnd for
__builtin_object_size with incomplete array type in struct
The commit r316245 introduced a
arphaman added a comment.
In https://reviews.llvm.org/D41405#960008, @george.burgess.iv wrote:
> LGTM assuming my nit gets addressed.
>
> Thank you!
>
> > Maybe someone who's more familiar with this builtin could point to the
> > cause of this discrepancy
>
> Yeah, the documentation for this
probinson added a project: debug-info.
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
With the GDB test results and LLDB able to handle it, this LGTM.
Carlos, do you have commit access?
https://reviews.llvm.org/D39239
emaste added a comment.
Ping?
https://reviews.llvm.org/D23934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:43
+ for (const auto *BindingName :
+ {"return", "continue", "break", "throw", "noreturn call"})
if (Result.Nodes.getNodeAs(BindingName))
You've spotted
aaron.ballman added a comment.
You regenerate the HTML by running `clang/docs/tools/dump_ast_matchers.py`.
Comment at: unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1775
+ EXPECT_TRUE(notMatches("void func();", functionDecl(isNoReturn(;
+
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:2321
+ !isa(ConvertType(Arg->getType())) &&
ArgI.getCoerceToType() == ConvertType(Ty) &&
ArgI.getDirectOffset() == 0) {
vsapsai wrote:
> rjmccall wrote:
> > I
vsk added reviewers: vsk, thakis.
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm. Could you wait a day or two before committing? IIRC Richard or
Nico have a -fsanitize=vptr Chromium bot, and they may have further comments.
george.burgess.iv added inline comments.
Comment at: test/Sema/builtin-object-size.c:105
+void rd36094951_IAS_builtin_object_size_assertion(IncompleteArrayStruct* p) {
+ __builtin___strlcpy_chk (p->session[0].string, "ab", 2,
__builtin_object_size(p->session[0].string, 1));
NoQ added a comment.
In https://reviews.llvm.org/D41406#960824, @xazax.hun wrote:
> Maybe `debug.AnalysisOrder` could be used to test the callback order
> explicitly. This way the test could also serve as a documentation for the
> callback order.
Yep, totally, will do.
NoQ added inline comments.
Comment at: test/Analysis/NewDelete-custom.cpp:7
-#if !LEAKS
+#if !(LEAKS && !ALLOCATOR_INLINING)
// expected-no-diagnostics
a.sidorin wrote:
> Double negation can be simplified a bit: `#if !LEAKS || ALLOCATOR_INLINING`
The rest of
lichray created this revision.
lichray added reviewers: mclow.lists, EricWF.
Herald added a subscriber: mgorny.
Progress: std::to_chars for integers
Missing: std::from_chars
References:
https://wg21.link/p0067r5
https://wg21.link/p0682r1
Repository:
rCXX libc++
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321203: [hwasan] Implement -fsanitize-recover=hwaddress.
(authored by eugenis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41417?vs=127642=127760#toc
Repository:
rC Clang
Author: eugenis
Date: Wed Dec 20 11:05:44 2017
New Revision: 321203
URL: http://llvm.org/viewvc/llvm-project?rev=321203=rev
Log:
[hwasan] Implement -fsanitize-recover=hwaddress.
Summary: Very similar to AddressSanitizer, with the exception of the error type
encoding.
Reviewers: kcc, alekseyshl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321201: Add support for ObjectFormat to TargetSpecificAttr
(authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41303?vs=127159=127757#toc
Repository:
rC Clang
Author: erichkeane
Date: Wed Dec 20 10:51:08 2017
New Revision: 321201
URL: http://llvm.org/viewvc/llvm-project?rev=321201=rev
Log:
Add support for ObjectFormat to TargetSpecificAttr
Looking through the code, I saw a FIXME on IFunc to switch it
to a target specific attribute. In looking through
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/OverloadedOperatorCheck.cpp:18
+
+AST_MATCHER(CXXMethodDecl, hasOverloadedOperator) {
+ if (Node.isCopyAssignmentOperator() || Node.isMoveAssignmentOperator())
JonasToth wrote:
> I think
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, LGTM. Thanks!
Comment at: include/clang/Basic/Attr.td:281
list CXXABIs;
+ // Specifies Object Formats for which the target
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
Another round of review
Comment at: clangd/ClangdUnit.cpp:113
+ CppFilePreambleCallbacks(IncludeReferenceMap )
+ : IRM(IRM) {}
lebedev.ri added a comment.
Depends on https://reviews.llvm.org/D41455.
I'm open to suggestions re diagnostic wording.
The current `'noreturn call'` seems lazy, and is basically a placeholder.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41456
lebedev.ri created this revision.
lebedev.ri added reviewers: aaron.ballman, alexfh, djasper, malcolm.parsons.
lebedev.ri added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
The readability-else-after-return check was not warning about an else after a
call to the function
faisalv added a comment.
Sounds good - if I don't get this done over the next seven days - would you
mind just pinging me!
Thanks!
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri created this revision.
lebedev.ri added a reviewer: aaron.ballman.
lebedev.ri added a project: clang.
Herald added a subscriber: klimek.
How to regenerate LibASTMatchersReference.html ?
Repository:
rC Clang
https://reviews.llvm.org/D41455
Files:
kosarev updated this revision to Diff 127742.
kosarev added a comment.
- Fixed the access size.
- Added the suggested tests.
https://reviews.llvm.org/D41399
Files:
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGen/tbaa-array.cpp
Index: test/CodeGen/tbaa-array.cpp
a.sidorin updated this revision to Diff 127748.
a.sidorin added a comment.
Test both with and without '-fdelayed-template-parsing' in C++ mode.
Repository:
rC Clang
https://reviews.llvm.org/D41444
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
sammccall added inline comments.
Comment at: clangd/index/Index.h:105
+ /// What to insert when completing this symbol (plain text version).
+ std::string CompletionPlainInsertText;
+ /// What to insert when completing this symbol (snippet version).
insert
This revision was automatically updated to reflect the committed changes.
ioeric marked 7 inline comments as done.
Closed by commit rCTE321193: [clangd] Pull CodeCompletionString handling logic
into its own file and add… (authored by ioeric, committed by ).
Changed prior to commit:
Author: ioeric
Date: Wed Dec 20 09:24:31 2017
New Revision: 321193
URL: http://llvm.org/viewvc/llvm-project?rev=321193=rev
Log:
[clangd] Pull CodeCompletionString handling logic into its own file and add
unit test.
Reviewers: sammccall
Subscribers: klimek, mgorny, ilya-biryukov, cfe-commits
Author: ioeric
Date: Wed Dec 20 09:22:56 2017
New Revision: 321192
URL: http://llvm.org/viewvc/llvm-project?rev=321192=rev
Log:
[clangd] Remove an unused lambda capture.
Modified:
clang-tools-extra/trunk/unittests/clangd/Annotations.cpp
Modified:
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny, klimek.
This adds checks that our diagnostics emit correct ranges in a bunch of cases,
as promised in https://reviews.llvm.org/D41118.
The diagnostics-preamble test is also
hfinkel added inline comments.
Comment at: test/CodeGen/tbaa-array.cpp:24
+// CHECK-DAG: [[TAG_A_i]] = !{[[TYPE_A:!.*]], [[TYPE_int:!.*]], i64 0, i64 4}
+// CHECK-DAG: [[TAG_C_i]] = !{[[TYPE_C:!.*]], [[TYPE_int:!.*]], i64 0, i64 16}
+// CHECK-DAG: [[TYPE_A]] =
xazax.hun closed this revision.
xazax.hun added a comment.
Committed in https://reviews.llvm.org/rL321190
https://reviews.llvm.org/D41451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: xazax
Date: Wed Dec 20 08:55:41 2017
New Revision: 321190
URL: http://llvm.org/viewvc/llvm-project?rev=321190=rev
Log:
Make DiagnosticIDs::getAllDiagnostics use std::vector. NFC.
The size of the result vector is currently around 4600 with
Flavor::WarningOrError, which makes std::vector a
Author: ibiryukov
Date: Wed Dec 20 08:48:56 2017
New Revision: 321189
URL: http://llvm.org/viewvc/llvm-project?rev=321189=rev
Log:
[clang] Add BeforeExecute method to PrecompiledPreamble
Summary: Adds BeforeExecute method to PrecompiledPreamble to be called
before Execute(). This method can be
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321189: [clang] Add BeforeExecute method to
PrecompiledPreamble (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41365?vs=127715=127740#toc
Repository:
rC
kosarev added inline comments.
Comment at: test/CodeGen/tbaa-array.cpp:24
+// CHECK-DAG: [[TAG_A_i]] = !{[[TYPE_A:!.*]], [[TYPE_int:!.*]], i64 0, i64 4}
+// CHECK-DAG: [[TAG_C_i]] = !{[[TYPE_C:!.*]], [[TYPE_int:!.*]], i64 0, i64 16}
+// CHECK-DAG: [[TYPE_A]] =
leanil updated this revision to Diff 127739.
leanil added a comment.
Move negative test next to the positive ones, because the necessary macros and
run-lines are already defined there.
https://reviews.llvm.org/D41384
Files:
lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:407
+ if (!NaiveCTU.hasValue()) {
+NaiveCTU = getBooleanOption("experimental-enable-naive-ctu-analysis",
+/*Default=*/false);
This
xazax.hun updated this revision to Diff 127525.
xazax.hun marked an inline comment as not done.
xazax.hun added a comment.
- Address some review comments
- Rebased on ToT
https://reviews.llvm.org/D30691
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
xazax.hun marked 6 inline comments as done.
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:372
+
+ cross_tu::CrossTranslationUnitContext =
+ Engine->getCrossTranslationUnitContext();
dcoughlin wrote:
> Can this logic be
leanil marked 2 inline comments as done.
leanil added a comment.
Does anyone have any more thoughts about this?
https://reviews.llvm.org/D38171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: marshall
Date: Wed Dec 20 08:31:40 2017
New Revision: 321188
URL: http://llvm.org/viewvc/llvm-project?rev=321188=rev
Log:
Fix the definitions of 'reference' and 'pointer' in string_view that no one
uses :-). Thanks to K-ballo for the catch.
Added:
leanil updated this revision to Diff 127736.
leanil added a comment.
Remove redundant empty lines.
Make list-clang-diagnostics test less strict.
Update getAllDiagnostics to use std::vector.
https://reviews.llvm.org/D38171
Files:
clang-tidy/ClangTidy.cpp
zturner added a comment.
Can you just have `getLangArgs` return a vector of vectors, and then in
`testImport` run it in a loop over all sets of args?
Repository:
rC Clang
https://reviews.llvm.org/D41444
___
cfe-commits mailing list
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CompletionString.cpp:51
+ std::string Result;
+ Result.reserve(Text.size()); // Assume '$', '}' and '\\' are rare.
+ for (const auto
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D41365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xazax.hun added a comment.
In https://reviews.llvm.org/D41444#960999, @a.sidorin wrote:
> Also, I still think we should rather not apply template-related patches until
> this testing is implemented. Gabor, Peter, do you agree?
Sure, I am fine with that.
Repository:
rC Clang
ioeric added a comment.
Thanks for the review!
Logic around CodeCompletionString is pulled into a separate file in
https://reviews.llvm.org/D41450.
I also propagate the new completion info to completion code. I am happy to
split it out if it adds too much noise for the review.
a.sidorin added a comment.
In case of `-fdelayed-template-parsing`, this code won't be even visible to the
Importer. In my opinion, we shouldn't care about code we're not going to
import. If we want to import it, we should make it visible and instantiate it.
In this case it will not compile.
kosarev added inline comments.
Comment at: test/CodeGen/tbaa-array.cpp:24
+// CHECK-DAG: [[TAG_A_i]] = !{[[TYPE_A:!.*]], [[TYPE_int:!.*]], i64 0, i64 4}
+// CHECK-DAG: [[TAG_C_i]] = !{[[TYPE_C:!.*]], [[TYPE_int:!.*]], i64 0, i64 16}
+// CHECK-DAG: [[TYPE_A]] =
ioeric updated this revision to Diff 127730.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Merge with origin/master
- Fixed an error in merge
- Make documentation etc optional in symbols
- Merge remote-tracking branch 'origin/master' into symbol
- Merge branch
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rL321184: [clangd] Switch xrefs and documenthighlight to
annotated-code unit tests. NFC (authored by sammccall, committed by ).
Changed prior to commit:
Author: sammccall
Date: Wed Dec 20 08:06:05 2017
New Revision: 321184
URL: http://llvm.org/viewvc/llvm-project?rev=321184=rev
Log:
[clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC
Summary:
The goal here is again to make it easier to read and write the tests.
I've
kosarev created this revision.
kosarev added reviewers: rjmccall, hfinkel.
kosarev added a project: clang.
The new format requires to specify both the type of the access and its size.
This patch fixes setting access sizes for TBAA tags that denote accesses to
structure members. This fix affects
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: unittests/clangd/Annotations.h:12
+//
+//Annotations Example(R"cpp(
+// int complete() { x.pri^ } // ^ indicates a point
ioeric wrote:
> Does this support
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D41451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
leanil created this revision.
leanil added reviewers: rsmith, xazax.hun.
Herald added a subscriber: rnkovacs.
The size of the result vector is currently around 4600 with
Flavor::WarningOrError, which makes std::vector a better candidate than
llvm::SmallVector.
https://reviews.llvm.org/D41451
1 - 100 of 139 matches
Mail list logo
