[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41516: emmintrin.h documentation fixes and updates

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41523: xmmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/xmmintrin.h:1706 /// -/// This intrinsic corresponds to the VMOVSS / MOVSS + shuffling +/// This intrinsic corresponds to the VBROADCASTSS / BROADCASTSS ///instruction. There is no BROADCASTSS

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:88 /// -/// This intrinsic corresponds to the VMOVQ / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// Shouldn't this be MOVQ? Comment

r321396 - [ODRHash] Disable hashing on methods.

Author: rtrieu Date: Fri Dec 22 17:35:32 2017 New Revision: 321396 URL: http://llvm.org/viewvc/llvm-project?rev=321396=rev Log: [ODRHash] Disable hashing on methods. Turn off hashing for class methods, but leave it on for other functions. This should get the buildbot to green for the time

r321395 - [ODRHash] Support ODR violation detection in functions.

Author: rtrieu Date: Fri Dec 22 16:41:01 2017 New Revision: 321395 URL: http://llvm.org/viewvc/llvm-project?rev=321395=rev Log: [ODRHash] Support ODR violation detection in functions. Extend the hashing to functions, which allows detection of function definition mismatches across modules. This

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: include/clang/AST/Type.h:1152 +NTFK_Struct, // non-trivial C struct. +NTFK_Array// array that has non-trivial elements. + }; rjmccall wrote: > ahatanak wrote: >

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

ahatanak updated this revision to Diff 128061. ahatanak added a comment. Rename functions. Check whether a non-trivial type passed to Sema::isValidVarArgType is a struct. https://reviews.llvm.org/D41228 Files: docs/LanguageExtensions.rst include/clang/AST/Decl.h include/clang/AST/Type.h

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett updated this revision to Diff 128060. juliehockett marked 3 inline comments as done. https://reviews.llvm.org/D41546 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/StaticallyConstructedObjectsCheck.cpp

r321392 - Add an explicit `LLVM_FALLTHROUGH` annotation to an intentional

Author: chandlerc Date: Fri Dec 22 15:29:49 2017 New Revision: 321392 URL: http://llvm.org/viewvc/llvm-project?rev=321392=rev Log: Add an explicit `LLVM_FALLTHROUGH` annotation to an intentional fallthrough. Fixes GCC and Clang warnings about this. Modified: cfe/trunk/lib/Sema/SemaType.cpp

r321386 - [OPENMP] Captured arguments of the capturable clauses by value.

Author: abataev Date: Fri Dec 22 13:01:52 2017 New Revision: 321386 URL: http://llvm.org/viewvc/llvm-project?rev=321386=rev Log: [OPENMP] Captured arguments of the capturable clauses by value. If the clause is applied to the combined construct and has captured expression, try to capture this

[PATCH] D41318: Start setting dso_local in clang

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, sorry for the holiday delay. https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:146 + + Warns if statically-stored objects are created, unless constructed with `constexpr`. + Please highlight constexpr with ``, not `. Comment at:

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall updated this revision to Diff 128049. sammccall marked an inline comment as done. sammccall added a comment. Address review comments, and update new GlobalSymbolBuilder tool for new API. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41506 Files:

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

sammccall marked 6 inline comments as done. sammccall added a comment. Thanks! Comment at: clangd/index/Index.cpp:39 + [](const Symbol , const SymbolID ) { + return S.ID == I; + });

[PATCH] D41547: [CodeGen] Fix TBAA info for accesses to members of base classes

kosarev created this revision. kosarev added reviewers: rjmccall, hfinkel. kosarev added a project: clang. Resolves: Bug 35724 - regression (r315984): fatal error: error in backend: Broken function found (Did not see access type in access path!) https://bugs.llvm.org/show_bug.cgi?id=35724

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if statically-stored objects are created, unless constructed

[clang-tools-extra] r321378 - Reformatting Fuchsia overloaded operator test

Author: juliehockett Date: Fri Dec 22 11:15:05 2017 New Revision: 321378 URL: http://llvm.org/viewvc/llvm-project?rev=321378=rev Log: Reformatting Fuchsia overloaded operator test Fixing parameters in clang-tidy fuchsia-overloaded-operator test case Modified:

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast created this revision. `cp -a` is neither part of POSIX nor the LSB; this patch uses `cp -RPp`, the nearest equivalent under POSIX. The tree being copied in each case currently contains only directories and regular files; so the `-P` is superfluous.

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

ilya-biryukov added a comment. IIUC, you want to pass an overlay so that clang-tidy will read the file opened in the IDE from a different directory? Could you provide add `-ivfsoverlay` option to your compile command instead? $ clang --help | grep vfs -ivfsoverlay Overlay the virtual

[PATCH] D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c

hubert.reinterpretcast created this revision. xargs supports escaping of newline characters with backslash. xargs -0 is neither part of POSIX nor the LSB. This patch removes the -0 option and adjusts the input to xargs accordingly; that is, the input is a text file not ending in an incomplete

Re: [clang-tools-extra] r321363 - [clang-tidy] Adding Fuchsia checker for overloaded operators

On Fri, Dec 22, 2017 at 11:52 AM, Julie Hockett via cfe-commits wrote: > Author: juliehockett > Date: Fri Dec 22 08:52:25 2017 > New Revision: 321363 > > URL: http://llvm.org/viewvc/llvm-project?rev=321363=rev > Log: > [clang-tidy] Adding Fuchsia checker for overloaded

[clang-tools-extra] r321363 - [clang-tidy] Adding Fuchsia checker for overloaded operators

Author: juliehockett Date: Fri Dec 22 08:52:25 2017 New Revision: 321363 URL: http://llvm.org/viewvc/llvm-project?rev=321363=rev Log: [clang-tidy] Adding Fuchsia checker for overloaded operators Adds a check to the Fuchsia module to warn if an operator is overloaded, except move and copy

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL321363: [clang-tidy] Adding Fuchsia checker for overloaded operators (authored by juliehockett, committed by ). Herald added a subscriber: klimek. Changed prior to commit:

Re: [PATCH] D41318: Start setting dso_local in clang

Ping. Is this direction OK? Should a put the time to update the existing tests to account for dso_local? I do volunteer to implement the rest of ELF, COFF and MachO once this is in. Cheers, Rafael Rafael Avila de Espindola writes: > Reid Kleckner via Phabricator

[PATCH] D41518: pmmintrin.h documentation fixes and updates

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41520: smmintrin.h documentation fixes and updates

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41433: Unit tests for TBAA metadata generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321360: Unit tests for TBAA metadata generation. (authored by sepavloff, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41433 Files: cfe/trunk/unittests/CodeGen/CMakeLists.txt

r321360 - Unit tests for TBAA metadata generation.

Author: sepavloff Date: Fri Dec 22 07:22:45 2017 New Revision: 321360 URL: http://llvm.org/viewvc/llvm-project?rev=321360=rev Log: Unit tests for TBAA metadata generation. Now tests for metadata created by clang involve compiling code snippets placed into c/c++ source files and matching

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL321358: [clangd] Add a tool to build YAML-format global symbols. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D41491?vs=128021=128022#toc Repository: rL

[clang-tools-extra] r321358 - [clangd] Add a tool to build YAML-format global symbols.

Author: hokein Date: Fri Dec 22 06:38:05 2017 New Revision: 321358 URL: http://llvm.org/viewvc/llvm-project?rev=321358=rev Log: [clangd] Add a tool to build YAML-format global symbols. Summary: The tools is used to generate global symbols for clangd (global code completion), The format is YAML,

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

aaron.ballman added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:21-22 #include "ClangTidyOptions.h" +#include "ClangTidy.h" +#include "ClangTidyModule.h" #include "clang/AST/ASTDiagnostic.h" Please keep the includes in sorted order.

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein updated this revision to Diff 128021. hokein marked an inline comment as done. hokein added a comment. Use GeneralCateogry. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41491 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

sammccall added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:45 +IndexOpts.SystemSymbolFilter = +index::IndexingOptions::SystemSymbolFilterKind::All; +IndexOpts.IndexFunctionLocals = false; hokein wrote: >

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein updated this revision to Diff 128020. hokein marked 4 inline comments as done. hokein added a comment. Address remaining review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41491 Files: clangd/CMakeLists.txt clangd/global-symbol-builder/CMakeLists.txt

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein added a comment. In https://reviews.llvm.org/D41491#963103, @sammccall wrote: > Thanks for the simplification! > How long does it take to run over LLVM on your machine? It took < 10 minutes (vs 20 minutes with python script) to run over LLVM. Comment at:

Re: r315984 - [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

Hello Alex, I'm working on it. Thanks, On 22/12/17 00:07, Alex L wrote: Hi, This commit has caused a new regression in LLVM 6. I filed the following PR: https://bugs.llvm.org/show_bug.cgi?id=35724 . Could you please take a look? Thanks, Alex On 17 October 2017 at 02:12, Ivan A. Kosarev

[PATCH] D41363: [clang-tidy] Adding Fuchsia checker for overloaded operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D41363#962727, @juliehockett wrote: > > Are the Fuchsia library headers intended to also comply with this rule? I > > notice there's mention of a

[PATCH] D41539: [CodeGen] Decorate aggregate accesses with TBAA tags

kosarev updated this revision to Diff 128017. kosarev added a comment. Reworked to not add another test file. https://reviews.llvm.org/D41539 Files: lib/CodeGen/CGExprAgg.cpp test/CodeGen/tbaa-struct.cpp Index: test/CodeGen/tbaa-struct.cpp

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the simplification! How long does it take to run over LLVM on your machine? Comment at: clangd/CMakeLists.txt:50 add_subdirectory(tool)

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

hokein added inline comments. Comment at: clangd/index/Index.cpp:76 +SymbolSlab SymbolSlab::Builder::build() && { + Symbols = {Symbols.begin(), Symbols.end()}; // Force shrink-to-fit. + // Sort symbols so the slab can binary search over them. use

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein added a comment. Thanks for the comments. Comment at: clangd/CMakeLists.txt:50 add_subdirectory(tool) +add_subdirectory(global-symbol-builder) sammccall wrote: > I think generally we run `check-clang-tools` before committing - I guess it's > OK not to

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

hokein updated this revision to Diff 128010. hokein marked 4 inline comments as done. hokein added a comment. Write all map-reduce logic into the global-symbol-builder binary, which makes the patch much simpler. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41491 Files:

[PATCH] D41506: [clangd] Use Builder for symbol slabs, and use sorted-vector for storage

ilya-biryukov added inline comments. Comment at: clangd/index/Index.cpp:39 + [](const Symbol , const SymbolID ) { + return S.ID == I; + }); Should this be `S.ID < I`?

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

xazax.hun added a comment. Herald added subscribers: a.sidorin, rnkovacs. In case you do not like this solution, I uploaded an alternative approach: https://reviews.llvm.org/D41538 https://reviews.llvm.org/D37437 ___ cfe-commits mailing list

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, george.karpenkov. Herald added subscribers: dkrupp, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Unfortunately, currently, the analyzer core sets the checker name after the constructor was already run.

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan created this revision. yvvan added reviewers: klimek, bkramer, arphaman, ilya-biryukov, erikjv. Currently getting such completions requires source correction, reparsing and calling completion again. And if it shows no results and rollback is required then it costs one more reparse. With

[PATCH] D41458: WIP: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 127996. lichray added a comment. Added std::from_chars Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa/itoa.h lib/CMakeLists.txt src/support/itoa/

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov updated this revision to Diff 127995. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Updated a comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41495 Files: clangd/ClangdUnit.cpp Index: clangd/ClangdUnit.cpp

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:536 + // so we set SkipFunctionBodies back to false after preamble is built. + assert(!CI->getFrontendOpts().SkipFunctionBodies); + CI->getFrontendOpts().SkipFunctionBodies = true;

[PATCH] D41399: [CodeGen] Represent array members in new-format TBAA type descriptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL321352: [CodeGen] Represent array members in new-format TBAA type descriptors (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41399?vs=127742=127994#toc

r321352 - [CodeGen] Represent array members in new-format TBAA type descriptors

Author: kosarev Date: Fri Dec 22 01:57:24 2017 New Revision: 321352 URL: http://llvm.org/viewvc/llvm-project?rev=321352=rev Log: [CodeGen] Represent array members in new-format TBAA type descriptors Now that in the new TBAA format we allow access types to be of any object types, including

r321351 - [CodeGen] Support generation of TBAA info in the new format

Author: kosarev Date: Fri Dec 22 01:54:23 2017 New Revision: 321351 URL: http://llvm.org/viewvc/llvm-project?rev=321351=rev Log: [CodeGen] Support generation of TBAA info in the new format Now that the MDBuilder helpers generating TBAA type and access descriptors in the new format are in place,

[PATCH] D41394: [CodeGen] Support generation of TBAA info in the new format

This revision was automatically updated to reflect the committed changes. Closed by commit rL321351: [CodeGen] Support generation of TBAA info in the new format (authored by kosarev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41394?vs=127838=127993#toc Repository: rL

[clang-tools-extra] r321350 - [clangd] Simplify GlobalCompilationDatabase, cache missing GCDs

Author: sammccall Date: Fri Dec 22 01:47:34 2017 New Revision: 321350 URL: http://llvm.org/viewvc/llvm-project?rev=321350=rev Log: [clangd] Simplify GlobalCompilationDatabase, cache missing GCDs Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp

Re: [clang-tools-extra] r321286 - [clangd] Fix use after free.

Thanks Ben! This was my r321272 - in hindsight I really should have run the tests with asan for that type of change. On Thu, Dec 21, 2017 at 6:51 PM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Thu Dec 21 09:51:35 2017 > New Revision: 321286 > >

[clang-tools-extra] r321348 - [clangd] Improve packing of Symbol struct. NFC

Author: sammccall Date: Fri Dec 22 00:12:39 2017 New Revision: 321348 URL: http://llvm.org/viewvc/llvm-project?rev=321348=rev Log: [clangd] Improve packing of Symbol struct. NFC Modified: clang-tools-extra/trunk/clangd/index/Index.h

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

sammccall added a comment. This looks like it does the right thing, ISTM it has a few too many moving parts. I might be missing why they're necessary, or we might not want to bother polishing this - maybe you can give me more context offline. Repository: rCTE Clang Tools Extra

[PATCH] D41491: [clangd] Add a tool to build YAML-format global symbols.

sammccall added inline comments. Comment at: clangd/CMakeLists.txt:50 add_subdirectory(tool) +add_subdirectory(global-symbol-builder) I think generally we run `check-clang-tools` before committing - I guess it's OK not to have tests for this experimental tool,