r321547 - Revert r321504 "[X86] Don't accidentally enable PKU on cannon lake and icelake or CLWB on cannonlake."

2017-12-28 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Dec 28 22:39:16 2017 New Revision: 321547 URL: http://llvm.org/viewvc/llvm-project?rev=321547=rev Log: Revert r321504 "[X86] Don't accidentally enable PKU on cannon lake and icelake or CLWB on cannonlake." I based that commit on what was in Intel's public documentation

r321546 - [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum.

2017-12-28 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Thu Dec 28 21:41:00 2017 New Revision: 321546 URL: http://llvm.org/viewvc/llvm-project?rev=321546=rev Log: [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum. Note, we don't do any bitwise manipulations when using them. Modified:

[PATCH] D41623: [cmake] Fix path problems when cross compiling.

2017-12-28 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: EricWF, compnerd, phosek, beanz. Herald added a subscriber: mgorny. When cross compiling, users can set CMAKE_FIND_ROOT_PATH to the sysroot of the TARGET system which adds the sysroot prefix to the paths used in the FIND_XXX commands.

[PATCH] D41622: [cmake] Fix path and flag problems when cross compiling.

2017-12-28 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: EricWF, compnerd, phosek, vkalintiris, beanz. Herald added a subscriber: mgorny. When cross compiling, users can set CMAKE_FIND_ROOT_PATH to the sysroot of the TARGET system which adds the sysroot prefix to the paths used in the FIND_XXX

[PATCH] D41621: [cmake] Fix path problems when cross compiling.

2017-12-28 Thread Don Hinton via Phabricator via cfe-commits
hintonda created this revision. hintonda added reviewers: EricWF, compnerd, phosek, beanz. Herald added a subscriber: mgorny. When cross compiling, users can set CMAKE_FIND_ROOT_PATH to the sysroot of the TARGET system which adds the sysroot prefix to the paths used in the FIND_XXX commands.

Buildbot numbers for the week of 12/10/2017 - 12/16/2017

2017-12-28 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 12/10/2017 - 12/16/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 12/17/2017 - 12/23/2017

2017-12-28 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 12/17/2017 - 12/23/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

LLVM buildmaster will be updated and restarted tonight

2017-12-28 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41566: [Modules TS] Diagnose exported internal linkage declarations

2017-12-28 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 128302. hamzasood added a comment. I've removed the `isExported` fix for namespaces as it's somewhat unrelated to this patch. I'll do a separate patch for fixing namespaces (which will include the stuff removed from here and a bit more)

[clang-tools-extra] r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended.

r321526 - Avoid int to string conversion in Twine or raw_ostream contexts.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 08:58:54 2017 New Revision: 321526 URL: http://llvm.org/viewvc/llvm-project?rev=321526=rev Log: Avoid int to string conversion in Twine or raw_ostream contexts. Some output changes from uppercase hex to lowercase hex, no other functionality change intended.

[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

2017-12-28 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood added inline comments. Comment at: lib/Basic/Module.cpp:349 + // Everything visible to the interface unit's global module fragment is + // visible to the interface unit. boris wrote: > This comment (not sure about the code) sounds wrong to me:

[clang-tools-extra] r321525 - [clangd] Get rid of unnecessary global variable. No functionality change.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 07:03:02 2017 New Revision: 321525 URL: http://llvm.org/viewvc/llvm-project?rev=321525=rev Log: [clangd] Get rid of unnecessary global variable. No functionality change. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp

[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

2017-12-28 Thread Boris Kolpackov via Phabricator via cfe-commits
boris added a comment. I don't think it will be wise for me to accept this revision since I can't claim to have good understanding of Clang's internal modules model. I think it will be wise to have Richard take a look. Comment at: lib/Basic/Module.cpp:349 + // Everything

[clang-tools-extra] r321523 - [clangd] Simplify code. No functionality change intended.

2017-12-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Dec 28 06:47:01 2017 New Revision: 321523 URL: http://llvm.org/viewvc/llvm-project?rev=321523=rev Log: [clangd] Simplify code. No functionality change intended. Modified: clang-tools-extra/trunk/clangd/index/FileIndex.cpp

Re: [libunwind] r321469 - There is no portable format string for printing `uintptr_t` values.

2017-12-28 Thread Shoaib Meenai via cfe-commits
Isn't PRIuPTR (from inttypes.h) the portable way to print a uintptr_t? On 12/27/17, 10:47 AM, "cfe-commits on behalf of Chandler Carruth via cfe-commits" wrote: Author: chandlerc Date: Tue Dec 26 21:46:53

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321521: [clangd] Skip function bodies when building the preamble (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41495 Files:

[clang-tools-extra] r321521 - [clangd] Skip function bodies when building the preamble

2017-12-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 28 05:10:15 2017 New Revision: 321521 URL: http://llvm.org/viewvc/llvm-project?rev=321521=rev Log: [clangd] Skip function bodies when building the preamble Summary: To make building preambles faster and keep them smaller. Reviewers: sammccall Reviewed By:

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321520: [Frontend] Correctly handle instantiating ctors with skipped bodies (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41492 Files:

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321520: [Frontend] Correctly handle instantiating ctors with skipped bodies (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41492?vs=127882=128290#toc

r321520 - [Frontend] Correctly handle instantiating ctors with skipped bodies

2017-12-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 28 05:05:46 2017 New Revision: 321520 URL: http://llvm.org/viewvc/llvm-project?rev=321520=rev Log: [Frontend] Correctly handle instantiating ctors with skipped bodies Summary: Previsouly clang tried instantiating member initializers even if ctor body was skipped,

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

2017-12-28 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg updated this revision to Diff 128289. sberg added a comment. made the recommended changes https://reviews.llvm.org/D40720 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

r321519 - -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid

2017-12-28 Thread Stephan Bergmann via cfe-commits
Author: sberg Date: Thu Dec 28 04:45:41 2017 New Revision: 321519 URL: http://llvm.org/viewvc/llvm-project?rev=321519=rev Log: -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid ...when such an operation is done on an object during con-/destruction. This is the cfe part of

[PATCH] D40295: -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid

2017-12-28 Thread Stephan Bergmann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321518: -fsanitize=vptr warnings on bad static types in dynamic_cast and typeid (authored by sberg, committed by ). Changed prior to commit: https://reviews.llvm.org/D40295?vs=127676=128288#toc

[PATCH] D40443: [Modules TS] Make imports from an interface unit visible to its implementation units

2017-12-28 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood updated this revision to Diff 128284. hamzasood added a comment. I've been investigating an issue regarding visibility during code synthesis, and I noticed that this patch half fixes it. I've added the rest of the fix since it's related to what's going on here, and I guess this is now

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: lib/Tooling/Tooling.cpp:287 + if (Files->getVirtualFileSystem() != VirtualFileSystem) { +Files = new FileManager(Invocation->getFileSystemOpts(), VirtualFileSystem); + } vladimir.plyashkun wrote: >

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D41535#963859, @vladimir.plyashkun wrote: > Unfortunately, `-ivfsoverlay` in the compile commands works for the compiler > invocation, but it doesn't work for tooling. This looks like a bug in tooling, but let's wait for responses on

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-28 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: lib/Tooling/Tooling.cpp:287 + if (Files->getVirtualFileSystem() != VirtualFileSystem) { +Files = new FileManager(Invocation->getFileSystemOpts(), VirtualFileSystem); + } ilya-biryukov wrote: > `Files`

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. I'm not sure if it's ok to ignore the shared `FileManager` here. @klimek, @bkramer, @alexfh, does tooling library rely on having the same `FileManager` for all invocations? Is it just a performance optimization or there's more to it? Comment

[PATCH] D41486: [OpenMP][Clang] Add missing argument to runtime functions.

2017-12-28 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. Not needed anymore, we decided on the order of arguments in https://reviews.llvm.org/D41012. Repository: rL LLVM https://reviews.llvm.org/D41486 ___ cfe-commits mailing list