[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 130557. elsteveogrande added a comment. remove unneeded changes Repository: rC Clang https://reviews.llvm.org/D42043 Files: include/clang-c/CXString.h tools/c-index-test/c-index-test.c tools/libclang/CXString.cpp Index:

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 130556. elsteveogrande marked an inline comment as done. elsteveogrande added a comment. Fixes, but first, a question for reviewers: Looking at the description of `clang_disposeString`: /** * \brief Free the given string. */ CINDEX_LINKAGE

[PATCH] D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL322922: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r322922 - [Fuchsia] Tests for the Fuzzer support in Fuchsia driver

Author: phosek Date: Thu Jan 18 20:08:06 2018 New Revision: 322922 URL: http://llvm.org/viewvc/llvm-project?rev=322922=rev Log: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver This adds driver tests for the Fuzzer support. Differential Revision: https://reviews.llvm.org/D42283

[PATCH] D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver

phosek created this revision. phosek added reviewers: jakehehrlich, mcgrathr, aarongreen. Herald added subscribers: cfe-commits, cryptoad. This adds driver tests for the Fuzzer support. Repository: rC Clang https://reviews.llvm.org/D42283 Files: test/Driver/fuchsia.c Index:

r322918 - [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

Author: ether Date: Thu Jan 18 19:07:00 2018 New Revision: 322918 URL: http://llvm.org/viewvc/llvm-project?rev=322918=rev Log: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC Differential revision: https://reviews.llvm.org/D42227 Modified:

[libcxx] r322920 - Wrote my own version of is_permutation; that was dominating the timings

Author: marshall Date: Thu Jan 18 19:17:45 2018 New Revision: 322920 URL: http://llvm.org/viewvc/llvm-project?rev=322920=rev Log: Wrote my own version of is_permutation; that was dominating the timings Modified: libcxx/trunk/fuzzing/fuzzing.cpp Modified: libcxx/trunk/fuzzing/fuzzing.cpp

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rC322918: [Refactor] Use enum instead of magic number in… (authored by ether, committed by ). Repository: rC Clang https://reviews.llvm.org/D42227 Files: lib/Sema/SemaDeclAttr.cpp Index:

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vsk added a comment. Mind rebasing this when you have a chance? Repository: rC Clang https://reviews.llvm.org/D42043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42259: c-index-test: small fix to CXString handling and disposal

vsk added a comment. LGTM, for the record Repository: rC Clang https://reviews.llvm.org/D42259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC322916: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D42275 Files:

r322916 - [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

Author: phosek Date: Thu Jan 18 17:58:26 2018 New Revision: 322916 URL: http://llvm.org/viewvc/llvm-project?rev=322916=rev Log: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia libFuzzer has been ported to Fuchsia so enable it in the driver. Differential Revision:

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson updated this revision to Diff 130530. Repository: rC Clang https://reviews.llvm.org/D42276 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/global-isel.c Index: test/Driver/global-isel.c

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson created this revision. aemerson added reviewers: qcolombet, echristo. Herald added subscribers: kristof.beyls, rovka. Add an -fexperimental-isel driver option to enable/disable GlobalISel. This is a more user friendly way of enabling GlobalISel instead of doing -mllvm -global-isel.

[PATCH] D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia

phosek created this revision. phosek added reviewers: aarongreen, mcgrathr, jakehehrlich, kcc. Herald added a subscriber: cfe-commits. libFuzzer has been ported to Fuchsia so enable it in the driver. Repository: rC Clang https://reviews.llvm.org/D42275 Files:

[PATCH] D42248: Always allow "#pragma region".

mattd updated this revision to Diff 130523. mattd retitled this revision from "[LangOpts] Add a LangOpt to represent "#pragma region" support." to "Always allow "#pragma region".". mattd edited the summary of this revision. mattd added a comment. I'm certainly fine with always allowing this

[PATCH] D42273: Add hasTrailingReturn AST matcher

juliehockett created this revision. juliehockett added a reviewer: aaron.ballman. Herald added a subscriber: klimek. Adds AST matcher for a FunctionDecl that has a trailing return type. https://reviews.llvm.org/D42273 Files: docs/LibASTMatchersReference.html

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

szepet added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:28-46 struct LoopState { private: enum Kind { Normal, Unrolled } K; - const Stmt *LoopStmt; - const LocationContext *LCtx; - unsigned maxStep; - LoopState(Kind InK, const Stmt *S, const

[PATCH] D41843: [libcxx] implement where expressions.

lichray added inline comments. Comment at: libcxx/include/experimental/simd:2330 + simd<_Tp, _Abi>& __v) noexcept { + return where_expression, simd<_Tp, _Abi>>(__m, __v); +} style: `return {__m, __v};`?

[PATCH] D41151: [analyzer] Adding LoopContext and improve loop modeling

szepet updated this revision to Diff 130516. szepet marked 2 inline comments as done. szepet added a comment. First, sorry for this delayed update, however, I was working on this and running this on real projects. I wanted to make sure that this update will be complete enough that this patch

[PATCH] D41844: [libcxx] implement mask reductions

lichray added inline comments. Comment at: libcxx/include/experimental/simd:1561 +template > +_Tp reduce(const simd<_Tp, _Abi>& __v, _BinaryOp __op = _BinaryOp()) { Specified in terms of the transparent `plus<>`. https://reviews.llvm.org/D41844

[PATCH] D42272: [X86] Add rdpid command line option and intrinsics.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, zvi, AndreiGrischenko. This patch adds -mrdpid/-mno-rdpid and the rdpid intrinsic. The corresponding LLVM commit has already been made. https://reviews.llvm.org/D42272 Files:

r322912 - [X86] Add missing check for RDSEED to ICL, CNL, SKX sections of test/Preprocessor/predefined-arch-macros.c

Author: ctopper Date: Thu Jan 18 16:28:42 2018 New Revision: 322912 URL: http://llvm.org/viewvc/llvm-project?rev=322912=rev Log: [X86] Add missing check for RDSEED to ICL, CNL, SKX sections of test/Preprocessor/predefined-arch-macros.c Modified:

[PATCH] D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer

szepet updated this revision to Diff 130505. szepet added a comment. > I essentially have one question at a glance - for loop counter variables, > don't we want LoopEntrance be before the initialization? I guess this would just make too much sense. Done that. Additionally, handle the cases

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet added inline comments. Comment at: test/Analysis/loopexit-cfg-output.cpp:912-914 +// CHECK: [B5] +// CHECK-NEXT: Succs (1): B8 + NoQ wrote: > P.S. This is not a regression introduced by your patch, but i'm really > curious what does this block

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet updated this revision to Diff 130503. szepet marked 2 inline comments as done. szepet added a comment. Added comments and removed indirect goto support from this patch. > This seems a bit scary because if there's no obvious one-to-once > correspondence between entrances and exits along

[PATCH] D42249: [CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

szepet created this revision. szepet added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: dkrupp, a.sidorin, rnkovacs, baloghadamsoftware, whisperity. The checker marks the locations where the analyzer creates sinks. However, it can happen that the sink was created because of a

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

Hi Roman, This commit has caused a regression in LLVM 6 which now triggers -Wsign-compare for typeof(enum) and typeof(enumConstant). I filed https://bugs.llvm.org/show_bug.cgi?id=36008. Could you please take a look at it? Thanks, Alex On 21 October 2017 at 09:44, Roman Lebedev via cfe-commits <

[PATCH] D42036: [clang-format] Keep comments aligned to macros

mzeren-vmw marked 2 inline comments as done. mzeren-vmw added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1756 + if (Alignment == CA_Preprocessor) +(*I)->LevelOffset = 1; } else { krasimir wrote: > This feels a bit awkward: we're

[PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

tmsriram updated this revision to Diff 130500. tmsriram added a comment. METADATA tag changed to "RtLibUseGOT". Also see: https://reviews.llvm.org/D42224/ https://reviews.llvm.org/D42217 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/noplt.c Index: test/CodeGen/noplt.c

[PATCH] D39050: Add index-while-building support to Clang

nathawes updated this revision to Diff 130496. nathawes marked 6 inline comments as done. nathawes added a comment. - Applied the various refactorings suggested by @ioeric - Extended c-index-test with a new option to print out the collected unit indexing data, and - Added tests for the unit

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

probinson added a comment. Well, my understanding is that the pragma is a complete no-op even for MSVC, and is used only as a marker for editors such as Visual Studio's. So, unconditionally ignoring it would seem to be fine. https://reviews.llvm.org/D42248

[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:45 + + If set, replaces the default list. (If you want to append to the default list, set AdditionalAcronyms instead.) + Please limit string length to 80

[PATCH] D39050: Add index-while-building support to Clang

nathawes planned changes to this revision. nathawes marked 32 inline comments as done. nathawes added a comment. @ioeric I should have an updated patch up shortly with your inline comments addressed + new tests. Thanks again for reviewing! Comment at:

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

etherzhhb added a comment. Thanks, I will commit tonight. If you want this patch before that, you could commit it for me. Repository: rC Clang https://reviews.llvm.org/D42227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130493. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Let me know if you need this committed. Repository: rC Clang https://reviews.llvm.org/D42227 ___ cfe-commits mailing list

r322901 - Remove TautologicalInRangeCompare from Extra and TautologicalCompare.

Author: nico Date: Thu Jan 18 13:40:27 2018 New Revision: 322901 URL: http://llvm.org/viewvc/llvm-project?rev=322901=rev Log: Remove TautologicalInRangeCompare from Extra and TautologicalCompare. This removes the following (already default-off) warnings from -Wextra:

[PATCH] D42249: [CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)

spatel updated this revision to Diff 130488. spatel added a comment. Patch updated: 1. Removed comment that didn't add value. 2. Added test with no sanitizing, reduced from PR35909. https://reviews.llvm.org/D42249 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/catch-undef-behavior.cpp

[PATCH] D42036: [clang-format] Keep comments aligned to macros

mzeren-vmw updated this revision to Diff 130487. mzeren-vmw added a comment. Documented CommentAlignment enumerators. Documenting them suggested better enumerator names. Added tests for multi-line comments, block comments and trailing comments. Repository: rC Clang

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130486. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:597 + // than or equal to the quarter of the maximum value of that type. + bool shouldAggressivelySimplifyRelationalComparison(); + High level comment: can

[libclc] r322897 - half_sin: Implement using sin

Author: jvesely Date: Thu Jan 18 13:12:01 2018 New Revision: 322897 URL: http://llvm.org/viewvc/llvm-project?rev=322897=rev Log: half_sin: Implement using sin Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322899 - half_divide: Implement using x/y

Author: jvesely Date: Thu Jan 18 13:12:06 2018 New Revision: 322899 URL: http://llvm.org/viewvc/llvm-project?rev=322899=rev Log: half_divide: Implement using x/y Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322898 - half_tan: Implement using tan

Author: jvesely Date: Thu Jan 18 13:12:04 2018 New Revision: 322898 URL: http://llvm.org/viewvc/llvm-project?rev=322898=rev Log: half_tan: Implement using tan v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322893 - half_log: Implement using log

Author: jvesely Date: Thu Jan 18 13:11:50 2018 New Revision: 322893 URL: http://llvm.org/viewvc/llvm-project?rev=322893=rev Log: half_log: Implement using log Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322896 - half_recip: Implement using 1/x

Author: jvesely Date: Thu Jan 18 13:11:58 2018 New Revision: 322896 URL: http://llvm.org/viewvc/llvm-project?rev=322896=rev Log: half_recip: Implement using 1/x Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322894 - half_log10: Implement using log10

Author: jvesely Date: Thu Jan 18 13:11:53 2018 New Revision: 322894 URL: http://llvm.org/viewvc/llvm-project?rev=322894=rev Log: half_log10: Implement using log10 Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322895 - half_log2: Implement using log2

Author: jvesely Date: Thu Jan 18 13:11:56 2018 New Revision: 322895 URL: http://llvm.org/viewvc/llvm-project?rev=322895=rev Log: half_log2: Implement using log2 Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322890 - half_exp: Implement using exp

Author: jvesely Date: Thu Jan 18 13:11:43 2018 New Revision: 322890 URL: http://llvm.org/viewvc/llvm-project?rev=322890=rev Log: half_exp: Implement using exp Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322892 - half_exp10: Implement using exp10

Author: jvesely Date: Thu Jan 18 13:11:48 2018 New Revision: 322892 URL: http://llvm.org/viewvc/llvm-project?rev=322892=rev Log: half_exp10: Implement using exp10 Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322889 - half_cos: Implement using cos

Author: jvesely Date: Thu Jan 18 13:11:40 2018 New Revision: 322889 URL: http://llvm.org/viewvc/llvm-project?rev=322889=rev Log: half_cos: Implement using cos Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322891 - half_exp2: Implement using exp2

Author: jvesely Date: Thu Jan 18 13:11:45 2018 New Revision: 322891 URL: http://llvm.org/viewvc/llvm-project?rev=322891=rev Log: half_exp2: Implement using exp2 Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322887 - half_rsqrt: Cleanup implementation

Author: jvesely Date: Thu Jan 18 13:11:35 2018 New Revision: 322887 URL: http://llvm.org/viewvc/llvm-project?rev=322887=rev Log: half_rsqrt: Cleanup implementation Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r322888 - half_sqrt: Cleanup implementation

Author: jvesely Date: Thu Jan 18 13:11:38 2018 New Revision: 322888 URL: http://llvm.org/viewvc/llvm-project?rev=322888=rev Log: half_sqrt: Cleanup implementation Passes CTS on carrizo v2: Use full precision implementation Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly marked an inline comment as done. ckennelly added a comment. I don't have commit access, so can this be committed to trunk? Repository: rCXX libc++ https://reviews.llvm.org/D41746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rL322886: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322886: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42253?vs=130478=130480#toc

[clang-tools-extra] r322886 - [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

Author: benhamilton Date: Thu Jan 18 12:51:24 2018 New Revision: 322886 URL: http://llvm.org/viewvc/llvm-project?rev=322886=rev Log: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms Summary: We were missing some pretty common acronyms in the camelCase property name check

[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein, klimek. Herald added a subscriber: cfe-commits. The existing option objc-property-declaration.Acronyms replaces the built-in set of acronyms. While this behavior is OK for clients that don't want the default

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

benhamilton updated this revision to Diff 130478. benhamilton added a comment. - Added comment about prefixes and suffixes. - Updated list of acronyms. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42253 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande marked 2 inline comments as done. elsteveogrande added inline comments. Comment at: tools/c-index-test/c-index-test.c:3268 - filename = clang_getFileName(file); - index_data->main_filename = clang_getCString(filename); - clang_disposeString(filename); +

[PATCH] D42259: c-index-test: small fix to CXString handling and disposal

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC322883: c-index-test: small fix to CXString handling and disposal (authored by steveo, committed by ). Changed prior to

[PATCH] D42259: c-index-test: small fix to CXString handling and disposal

elsteveogrande created this revision. elsteveogrande added reviewers: vsk, benlangmuir, akyrtzi. Herald added a subscriber: cfe-commits. (Separating some unrelated changes out of https://reviews.llvm.org/D42043) Repository: rC Clang https://reviews.llvm.org/D42259 Files:

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun added a comment. The checker reports 7 warnings on LLVM + Clang code bases, all on std::unique_ptr::release: lib/Bitcode/Reader/BitReader.cpp:114:3 - release() called on moved-from unique_ptr - no harm, just unnecessary lib/ExecutionEngine/ExecutionEngine.cpp:149:7 - release() called

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

Wizard added a comment. Can you update the doc btw since the acronyms are not only for prefix anymore? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vsk added a comment. Thanks for working on this :). Comment at: tools/libclang/CXString.cpp:213 + if (string.IsNullTerminated) { +CString = (const char *) string.Contents; + } else { elsteveogrande wrote: > vsk wrote: > > Basic question: If a non-owning

r322880 - Convert comment to C-style to prevent warning

Author: sbc Date: Thu Jan 18 11:31:33 2018 New Revision: 322880 URL: http://llvm.org/viewvc/llvm-project?rev=322880=rev Log: Convert comment to C-style to prevent warning Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL:

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun updated this revision to Diff 130461. khuttun added a comment. - Detect unused return values also inside other kinds of statements than compound statements - Ignore void functions in the checker - Check std::remove, std::remove_if and std::unique by default

[PATCH] D42249: [CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)

efriedma added inline comments. Comment at: lib/CodeGen/CGClass.cpp:410 + + // The GEP is to a derived object, so this GEP must be 'inbounds'. + Value = Builder.CreateInBoundsGEP(Value, Builder.CreateNeg(NonVirtualOffset), Not sure this comment really adds

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande added a comment. Thanks very much for looking at this @vsk ! I actually found an ASAN bug in my new code, mixing and matching `malloc/free` and `operator`s `new/delete`. Comment at: tools/c-index-test/c-index-test.c:3268 - filename =

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

lebedev.ri added a comment. Don't forget that you also need to regenerate the HTML docs: $ cd docs/tools # yes, cd $ ./dump_ast_matchers.py Repository: rC Clang https://reviews.llvm.org/D42213 ___ cfe-commits mailing list

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein, klimek. Herald added a subscriber: cfe-commits. We were missing some pretty common acronyms in the camelCase property name check objc-property-declaration. This expands the list and sorts it lexicographically, so we

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay updated this revision to Diff 130458. MaskRay added a comment. More Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

mattd added a comment. In https://reviews.llvm.org/D42248#980541, @majnemer wrote: > Why not always support the pragma regardless of the compiler mode? Our > "support" for it just ignores it anyway... Thanks for the reply @majnemer. I am not opposed to that idea. My change just operates

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

majnemer added a comment. Why not always support the pragma regardless of the compiler mode? Our "support" for it just ignores it anyway... https://reviews.llvm.org/D42248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

This revision was automatically updated to reflect the committed changes. Closed by commit rC322873: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style (authored by benhamilton, committed by ). Changed prior to commit:

r322873 - [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

Author: benhamilton Date: Thu Jan 18 10:37:16 2018 New Revision: 322873 URL: http://llvm.org/viewvc/llvm-project?rev=322873=rev Log: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style Summary: The Google style guide is neutral on whether there should be a space before

[libcxx] r322872 - Add memory tracking

Author: marshall Date: Thu Jan 18 10:37:11 2018 New Revision: 322872 URL: http://llvm.org/viewvc/llvm-project?rev=322872=rev Log: Add memory tracking Modified: libcxx/trunk/fuzzing/fuzz_test.cpp Modified: libcxx/trunk/fuzzing/fuzz_test.cpp URL:

[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/ContinuationIndenter.cpp:1336 + unsigned OldSuffixSize = 2 + OldDelimiter.size(); + std::string RawText = +

[PATCH] D42229: [cmake] [libcxxabi] Don't print warning when tests are disabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322870: [cmake] [libcxxabi] Dont print warning when tests are disabled. (authored by dhinton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[libcxxabi] r322870 - [cmake] [libcxxabi] Don't print warning when tests are disabled.

Author: dhinton Date: Thu Jan 18 10:29:36 2018 New Revision: 322870 URL: http://llvm.org/viewvc/llvm-project?rev=322870=rev Log: [cmake] [libcxxabi] Don't print warning when tests are disabled. Summary: Don't print, possibly erroneous, warning if LIBCXXABI_INCLUDE_TESTS is false. This patch

[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:270 + /// namespace scopes which are visible to the qualified-id completion token. + std::vector Scopes; +}; ilya-biryukov wrote: > sammccall wrote: > > Just to check, if the user types: > >

[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

sammccall updated this revision to Diff 130440. sammccall added a comment. Converted the big codeComplete function to a CodeCompleteFlow class Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42181 Files: clangd/CodeComplete.cpp clangd/FuzzyMatch.h

[PATCH] D42249: [CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)

spatel created this revision. spatel added reviewers: efriedma, hfinkel, rjmccall, rsmith. Herald added a subscriber: mcrosier. I'm not sure if the code comment is adequate or even correct, but hopefully the change itself is valid. Eli cited this section of the standard in PR35909 (

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

mattd created this revision. mattd added reviewers: rnk, rsmith. Both MS and PS4 targets are capable of recognizing the existence of: #pragma region, #pragma endregion. This patch adds a LangOpt and sets the value based on target information or MS compatibility. In the case of PS4 or MS we

[PATCH] D41727: [libcxx] Disable tautological-type-limit-compare warning

bcain updated this revision to Diff 130431. bcain added a comment. Herald added a subscriber: cfe-commits. Changed per review Repository: rCXX libc++ https://reviews.llvm.org/D41727 Files: libcxx/utils/libcxx/test/config.py Index: libcxx/utils/libcxx/test/config.py

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 130427. juliehockett added a comment. Rebasing from trunk https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/MultipleInheritanceCheck.cpp

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

ilya-biryukov added inline comments. Comment at: include/clang/Tooling/Tooling.h:299 /// clang modules. + /// \param BaseFS Base virtual filesystem used for OverlayFileSystem creation ClangTool(const CompilationDatabase , NIT: LLVM coding style requires

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

ilya-biryukov added a comment. With https://reviews.llvm.org/D41947 in place, do we still need this change? Or can it be "abandoned" now? Repository: rC Clang https://reviews.llvm.org/D41594 ___ cfe-commits mailing list

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov updated this revision to Diff 130428. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. Herald added a subscriber: ioeric. Addressing review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42173 Files:

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:35 +tooling::CompileCommand getCompileCommand(GlobalCompilationDatabase , + PathRef File, PathRef ResourceDir) { sammccall wrote: > This seems

[libcxx] r322864 - Use high_resolution_clock instead of steady_clock. Also now builds with gcc 7.2 (for comparison purposes)

Author: marshall Date: Thu Jan 18 09:01:34 2018 New Revision: 322864 URL: http://llvm.org/viewvc/llvm-project?rev=322864=rev Log: Use high_resolution_clock instead of steady_clock. Also now builds with gcc 7.2 (for comparison purposes) Modified: libcxx/trunk/fuzzing/fuzz_test.cpp Modified:

[libcxx] r322863 - A simple program for testing OSS-Fuzz test cases locally.

Author: marshall Date: Thu Jan 18 08:52:19 2018 New Revision: 322863 URL: http://llvm.org/viewvc/llvm-project?rev=322863=rev Log: A simple program for testing OSS-Fuzz test cases locally. Added: libcxx/trunk/fuzzing/fuzz_test.cpp Added: libcxx/trunk/fuzzing/fuzz_test.cpp URL:

[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

sammccall updated this revision to Diff 130417. sammccall marked 7 inline comments as done. sammccall added a comment. Addressed review comments, except for "refactor into class" which is still todo. Added explicit check of code completion context kind. Added tests (mostly updating existing

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. That makes sense. Is it not possible to implement the required functionality using a flag vs an attribute? In an earlier comment you mentioned adding the global to @llvm.used to prevent GlobalDCE from removing it. Can you not do that when using a flag?

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

ilya-biryukov added a comment. In https://reviews.llvm.org/D41947#980305, @vladimir.plyashkun wrote: > In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote: > > > Looks good. Do you have commit access or do you need someone to land this > > patch for you? > > > No, i don't have

[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:270 + /// namespace scopes which are visible to the qualified-id completion token. + std::vector Scopes; +}; sammccall wrote: > Just to check, if the user types: > "vec" --> None >

  1   2   >