[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

WeiChungChang added a comment. Here gives the comparison between GCC & LLVM's std c++ library. It is shown that libc++ soon suffers from rotate speed under limited allocated buffer and slower than GCC's corresponding version. Both LLVM & GCC run the same test program. F5782010: 0124.png

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-property-declarati

Please subscribe "rUNW libunwind" to cfe-commits.

Currently, herald doesn't subscribe libunwind to any group. Should it be added to cfe-commits? https://reviews.llvm.org/H268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r323306 - include to get uint32_t

Author: marshall Date: Tue Jan 23 21:38:51 2018 New Revision: 323306 URL: http://llvm.org/viewvc/llvm-project?rev=323306&view=rev Log: include to get uint32_t Modified: libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.cpp Modified: libcxx/trunk/test/std/utilities/meta/meta.t

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

hintonda created this revision. hintonda added reviewers: beanz, compnerd, phosek, EricWF. Herald added subscribers: cfe-commits, mgorny. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage across all projects. Repository: rCXXA libc++abi https://rev

[PATCH] D42459: [cmake] Call llvm_setup_rpath() when adding shared libraries.

hintonda created this revision. hintonda added reviewers: beanz, compnerd, phosek, EricWF. Herald added subscribers: cfe-commits, mgorny. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage across all projects. Repository: rCXX libc++ https://reviews

[libcxx] r323300 - libcxx: Allow auto-linking to be disabled with a macro.

Author: pcc Date: Tue Jan 23 20:30:19 2018 New Revision: 323300 URL: http://llvm.org/viewvc/llvm-project?rev=323300&view=rev Log: libcxx: Allow auto-linking to be disabled with a macro. Some users may have a custom build system which gives a different name to the libc++ archive (or does not creat

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

aemerson updated this revision to Diff 131191. aemerson added a comment. I've added two kinds of warnings, one for targets which have incomplete GISel support, and another for unsupported optimisation levels (for ARM64 -O{1,2,3,s,z}). Repository: rC Clang https://reviews.llvm.org/D42276 Fi

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:570 + struct EvalCallFlags { +bool IsConstructorWithImproperlyModeledTargetRegion : 1; Those are not really flags. Perhaps options? =

[PATCH] D42455: Don't create hidden dllimport global values

colden added a comment. Confirmed, this fixes my issue! Thanks! https://reviews.llvm.org/D42455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. - If we are unable to determine a good target region for a C++ constructor call, we come up with a temporary region and construct into that.

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

dyung added a comment. LGTM! https://reviews.llvm.org/D41888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35472: Implement P0463R1: "Endian just Endian"

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 323296 https://reviews.llvm.org/D35472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r323296 - Implement P0463R1: 'Endian just Endian'. Reviewed as https://reviews.llvm.org/D35472

Author: marshall Date: Tue Jan 23 17:53:24 2018 New Revision: 323296 URL: http://llvm.org/viewvc/llvm-project?rev=323296&view=rev Log: Implement P0463R1: 'Endian just Endian'. Reviewed as https://reviews.llvm.org/D35472 Added: libcxx/trunk/test/std/utilities/meta/meta.type.synop/endian.pass.

r323294 - Attempt to fix implicit-fallthrough warning after r323218.

Author: nico Date: Tue Jan 23 17:47:22 2018 New Revision: 323294 URL: http://llvm.org/viewvc/llvm-project?rev=323294&view=rev Log: Attempt to fix implicit-fallthrough warning after r323218. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLinePar

Re: r323218 - clang-format: Support formatting Java 8 interface default methods.

Does 323294 help? On Tue, Jan 23, 2018 at 4:58 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Nico, > > This commit broke one of our builders: > > http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4701 > . . . > FAILED: /usr/local/gcc-7.1/bin/g++-7.1

r323293 - Fix typo in comment.

Author: nico Date: Tue Jan 23 17:45:57 2018 New Revision: 323293 URL: http://llvm.org/viewvc/llvm-project?rev=323293&view=rev Log: Fix typo in comment. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp URL: http://llvm.org/viewvc/llvm-projec

Buildbot numbers for the week of 1/07/2018 - 1/13/2018

Hello everyone, Below are some buildbot numbers for the week of 1/07/2018 - 1/13/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the last week of 1/14/2018 - 1/20/2018

Hello everyone, Below are some buildbot numbers for the last week of 1/14/2018 - 1/20/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D42452: [CUDA] Disable PGO and coverage instrumentation in NVPTX.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. NVPTX does not have runtime support necessary for profiling to work and even call arc collection is prohibitively expensive. Furthermore, there's no easy way to collect the samples. NVPTX also does not supp

r323285 - Fix test Driver/solaris-ld.c for Windows.

Author: dyung Date: Tue Jan 23 16:05:01 2018 New Revision: 323285 URL: http://llvm.org/viewvc/llvm-project?rev=323285&view=rev Log: Fix test Driver/solaris-ld.c for Windows. - Test needs to be able to handle "clang.exe" on Windows - Test needs to be able to handle either '/' or '\\' used as the p

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D42154: Don't generate inline atomics for i386/i486

This revision was automatically updated to reflect the committed changes. Closed by commit rL323281: Adjust MaxAtomicInlineWidth for i386/i486 targets. (authored by wmi, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42154?vs=130076&i

r323281 - Adjust MaxAtomicInlineWidth for i386/i486 targets.

Author: wmi Date: Tue Jan 23 15:27:57 2018 New Revision: 323281 URL: http://llvm.org/viewvc/llvm-project?rev=323281&view=rev Log: Adjust MaxAtomicInlineWidth for i386/i486 targets. This is to fix the bug reported in https://bugs.llvm.org/show_bug.cgi?id=34347#c6. Currently, all MaxAtomicInlineW

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

WeiChungChang added a comment. Dear mclow: Thanks a lot for your kindly reply! I would like to briefly describe the purpose of this fix here. **`This patch is in a series of 3 aimed targets.`** I could explain them item-by-item in detail with experiment. **//However, I mainly focus on algorithm

r323267 - Fix test Driver/solaris-ld.c

Author: rtrieu Date: Tue Jan 23 13:58:56 2018 New Revision: 323267 URL: http://llvm.org/viewvc/llvm-project?rev=323267&view=rev Log: Fix test Driver/solaris-ld.c Allow test to accept calls to ld without full path. Modified: cfe/trunk/test/Driver/solaris-ld.c Modified: cfe/trunk/test/Driver/

Re: r323218 - clang-format: Support formatting Java 8 interface default methods.

Hello Nico, This commit broke one of our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4701 . . . FAILED: /usr/local/gcc-7.1/bin/g++-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Fo

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 131131. simark added a comment. Fix formatting, remove capability - Fix some formatting nits - Remove the entry in the capabilities object Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp clangd/Cla

r323257 - AST: correct mangling for SEL on MS ABI

Author: compnerd Date: Tue Jan 23 12:56:52 2018 New Revision: 323257 URL: http://llvm.org/viewvc/llvm-project?rev=323257&view=rev Log: AST: correct mangling for SEL on MS ABI We would previously treat `SEL` as a pointer-only type. This is not the case. It should be treated similarly to `id` and

[PATCH] D42396: [analyzer] Do not attempt to get the pointee of void* .

alexshap added a comment. Herald added a reviewer: george.karpenkov. switched to checking (*I)->getType() Repository: rL LLVM https://reviews.llvm.org/D42396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. Checked that suggested change also fixes another OSS-Fuzz bug https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4664 https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, Nebiroth wrote: > simark wrote: > > I find `config

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, simark wrote: > I find `configurationChangeProvi

r323253 - [WebAssembly] Factor out settings common to wasm32 and wasm64. NFC.

Author: djg Date: Tue Jan 23 12:22:12 2018 New Revision: 323253 URL: http://llvm.org/viewvc/llvm-project?rev=323253&view=rev Log: [WebAssembly] Factor out settings common to wasm32 and wasm64. NFC. MaxAtomicPromoteWidth and MaxAtomicInlineWidth are 64 on both wasm32 and wasm64, so they can be set

[PATCH] D42320: [analyzer] Mark lines as relevant even if they weren't executed but have a label attached

This revision was automatically updated to reflect the committed changes. Closed by commit rC323251: [analyzer] Mark lines as relevant even if they weren't executed but have a… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

r323251 - [analyzer] Mark lines as relevant even if they weren't executed but have a label attached

Author: george.karpenkov Date: Tue Jan 23 12:01:31 2018 New Revision: 323251 URL: http://llvm.org/viewvc/llvm-project?rev=323251&view=rev Log: [analyzer] Mark lines as relevant even if they weren't executed but have a label attached Differential Revision: https://reviews.llvm.org/D42320 Added:

r323247 - CodeGen: use `llvm.used` for ObjC protocols

Author: compnerd Date: Tue Jan 23 11:35:51 2018 New Revision: 323247 URL: http://llvm.org/viewvc/llvm-project?rev=323247&view=rev Log: CodeGen: use `llvm.used` for ObjC protocols These symbols are supposed to be preserved even by the linker. Use the `llvm.used` to ensure that the symbols are not

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

vsapsai added inline comments. Comment at: Parse/ParseTemplate.cpp:492 + // Is there just a typo in the input code? ('typedef' instead of 'typename') + if (Tok.is(tok::kw_typedef)) { +Diag(Tok.getLocation(), diag::err_expected_template_parameter); jkorous-a

r323245 - [analyzer] Show full analyzer invocation for reproducibility in HTML reports

Author: george.karpenkov Date: Tue Jan 23 11:28:52 2018 New Revision: 323245 URL: http://llvm.org/viewvc/llvm-project?rev=323245&view=rev Log: [analyzer] Show full analyzer invocation for reproducibility in HTML reports Analyzing problems which appear in scan-build results can be very difficult,

r323244 - [html] [NFC] Use raw strings to dump the style table.

Author: george.karpenkov Date: Tue Jan 23 11:28:43 2018 New Revision: 323244 URL: http://llvm.org/viewvc/llvm-project?rev=323244&view=rev Log: [html] [NFC] Use raw strings to dump the style table. Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

r323241 - AST: adjust ObjC MS mangling to work with typedefs

Author: compnerd Date: Tue Jan 23 11:17:25 2018 New Revision: 323241 URL: http://llvm.org/viewvc/llvm-project?rev=323241&view=rev Log: AST: adjust ObjC MS mangling to work with typedefs Rather than hardcode the pointerness of the `id` and `class` types, handle them generically. This allows for t

[PATCH] D42319: [CUDA] CUDA has no device-side library builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323239: [CUDA] CUDA has no device-side library builtins. (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42319?vs=130697&id=

r323239 - [CUDA] CUDA has no device-side library builtins.

Author: tra Date: Tue Jan 23 11:08:18 2018 New Revision: 323239 URL: http://llvm.org/viewvc/llvm-project?rev=323239&view=rev Log: [CUDA] CUDA has no device-side library builtins. We should (almost) never consider a device-side declaration to match a library builtin functio. Otherwise clang may i

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:164 +/// Handles running tasks for ClangdServer and managing the resources (e.g., +/// preambles and ASTs) for opened files. sammccall wrote: > This is a nice abstraction, so much better tha

[libcxx] r323237 - libcxx: Rename vasprintf function to __libcpp_vasprintf.

Author: pcc Date: Tue Jan 23 10:53:33 2018 New Revision: 323237 URL: http://llvm.org/viewvc/llvm-project?rev=323237&view=rev Log: libcxx: Rename vasprintf function to __libcpp_vasprintf. The language standard does not define a function with this name, so it is part of the user's namespace. This c

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4699 +else + CmdArgs.push_back("-global-isel=0"); + } aemerson wrote: > qcolombet wrote: > > qcolombet wrote: > > > I think that it would be useful to also set -global-isel-abo

r323236 - [OPENMP] Replace call of EmitLoadOfLValue() by EmitLoadOfScalar(), NFC.

Author: abataev Date: Tue Jan 23 10:44:14 2018 New Revision: 323236 URL: http://llvm.org/viewvc/llvm-project?rev=323236&view=rev Log: [OPENMP] Replace call of EmitLoadOfLValue() by EmitLoadOfScalar(), NFC. Replace calls of EmitLoadOfLValue() by EmitLoadOfScalar() functions if it is known that the

[PATCH] D42357: Under limitation of allocated buffer, inplace_merge() does NOT take usage of partial allocated buffer but applies native rotate directly.

mclow.lists added inline comments. Comment at: include/algorithm:2515 +{ +pointer __buff_end = __move(__first, __middle, __buff); +__move(__middle, __last, __first); mclow.lists wrote: > Probably a good idea to qualify these calls with `_VSTD

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:222 + } + // We currently do all the reads of the AST on a running thread to avoid + // inconsistent states coming from subsequent updates. sammccall wrote: > Having trouble with this one

r323235 - [Docs] Re-generate command line documentation.

Author: ctopper Date: Tue Jan 23 10:40:15 2018 New Revision: 323235 URL: http://llvm.org/viewvc/llvm-project?rev=323235&view=rev Log: [Docs] Re-generate command line documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst U

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

ilya-biryukov updated this revision to Diff 131105. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Renamed SimpleThreadPool to ThreadPool - Removed PCHs from Scheduler's constructor - Renamed waitFor(AST|Preamble)Action to blocking(AST|Preamble)Read - Updates - Re

r323231 - test/Driver: Add some --stdlib=platform, NFC.

Author: hahnfeld Date: Tue Jan 23 10:12:12 2018 New Revision: 323231 URL: http://llvm.org/viewvc/llvm-project?rev=323231&view=rev Log: test/Driver: Add some --stdlib=platform, NFC. This fixes the failing test when building with CLANG_DEFAULT_CXX_STDLIB. Modified: cfe/trunk/test/Driver/solari

r323232 - [OPENMP] Remove more empty SourceLocations() from the code.

Author: abataev Date: Tue Jan 23 10:12:38 2018 New Revision: 323232 URL: http://llvm.org/viewvc/llvm-project?rev=323232&view=rev Log: [OPENMP] Remove more empty SourceLocations() from the code. Removed more empty SourceLocations() from the OpenMP code and replaced with the correct locations for b

[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library

mclow.lists updated this revision to Diff 131102. mclow.lists added a comment. Find *all* the places that we are using `exception_class` and wrap them in helper routines. https://reviews.llvm.org/D42242 Files: src/cxa_default_handlers.cpp src/cxa_exception.cpp src/cxa_exception.hpp src

r323230 - test: simplify the matching logic a bit (NFC)

Author: compnerd Date: Tue Jan 23 09:57:04 2018 New Revision: 323230 URL: http://llvm.org/viewvc/llvm-project?rev=323230&view=rev Log: test: simplify the matching logic a bit (NFC) Use CHECK-SAME directives to simplify the test conditions a bit. This makes it easier to see what is being checked.

r323228 - Name two bool parameters. No behavior change.

Author: nico Date: Tue Jan 23 09:29:41 2018 New Revision: 323228 URL: http://llvm.org/viewvc/llvm-project?rev=323228&view=rev Log: Name two bool parameters. No behavior change. Modified: cfe/trunk/lib/Format/FormatToken.h Modified: cfe/trunk/lib/Format/FormatToken.h URL: http://llvm.org/vie

[PATCH] D42429: [clangd] Moved caching of compile commands to ClangdServer

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, klimek. It allows to get rid of CppFile::getLastCommand and simplify the code in the upcoming threading patch. Repository: rCTE Clang Tools Extra https://reviews.ll

[PATCH] D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323227: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if… (authored by malcolm.parsons, committed by ). Changed prior to commit: https://reviews.llvm.org/D42426?vs=131088&id

[clang-tools-extra] r323227 - [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a

Author: malcolm.parsons Date: Tue Jan 23 09:13:57 2018 New Revision: 323227 URL: http://llvm.org/viewvc/llvm-project?rev=323227&view=rev Log: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a Summary: C++2a allows bitfields to have default member initializers

r323226 - clang-format: Support macros in front of @interface / @protocol for ObjC code.

Author: nico Date: Tue Jan 23 09:10:25 2018 New Revision: 323226 URL: http://llvm.org/viewvc/llvm-project?rev=323226&view=rev Log: clang-format: Support macros in front of @interface / @protocol for ObjC code. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/lib/Format/Unw

r323225 - test: adjust the target for some Windows tests

Author: compnerd Date: Tue Jan 23 09:05:57 2018 New Revision: 323225 URL: http://llvm.org/viewvc/llvm-project?rev=323225&view=rev Log: test: adjust the target for some Windows tests The tests are targeting Windows but do not specify an environment. When executed on Linux, they would use an ELF o

r323224 - [WebAssembly] Add mem.* builtin functions.

Author: djg Date: Tue Jan 23 09:04:04 2018 New Revision: 323224 URL: http://llvm.org/viewvc/llvm-project?rev=323224&view=rev Log: [WebAssembly] Add mem.* builtin functions. This corresponds to r323222 in LLVM. The new names are not yet finalized, so use them at your own risk. Modified: cfe/t

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 131091. m.ostapenko added a comment. Herald added a subscriber: llvm-commits. Rebased and ping. Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/S

[PATCH] D42428: [CodeComplete] only respect LoadExternal hint at namespace/tu scope

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D42428 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteOptions.h lib/Sema/SemaLookup.cpp test/Index/complete-p

[PATCH] D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai, klimek. C++2a allows bitfields to have default member initializers. Add support for this to clang-tidy's cppcoreguidelines-pro-type-me

r323218 - clang-format: Support formatting Java 8 interface default methods.

Author: nico Date: Tue Jan 23 08:30:56 2018 New Revision: 323218 URL: http://llvm.org/viewvc/llvm-project?rev=323218&view=rev Log: clang-format: Support formatting Java 8 interface default methods. Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk/unittests/Format/FormatTes

[PATCH] D42416: [Driver] Add support for mips32 and scudo

cryptoad added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:850 + const bool IsMIPS = getTriple().getArch() == llvm::Triple::mips || +getTriple().getArch() == llvm::Triple::mipsel; const bool IsMIPS64 = getTriple().getArch() == llvm::Tr

[PATCH] D42416: [Driver] Add support for mips32 and scudo

cryptoad accepted this revision. cryptoad added a comment. Cool thanks! Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, I find `configurationChangeProvider` a bit weird.

r323157 - [ASTMatchers] [NFC] Fix code examples

Author: maskray Date: Mon Jan 22 14:34:15 2018 New Revision: 323157 URL: http://llvm.org/viewvc/llvm-project?rev=323157&view=rev Log: [ASTMatchers] [NFC] Fix code examples Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D42213 Modified: cfe/trunk/docs/LibAST

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande added a comment. Hi @vsk + @arphaman : I did find such problems with either MSAN (with poison-in-dtor) and ASAN, so we should be able to discover these instances pretty easily :) Repository: rC Clang https://reviews.llvm.org/D42043 _

[PATCH] D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rL323208: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using… (authored by malcolm.parsons, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://

[clang-tools-extra] r323208 - [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

Author: malcolm.parsons Date: Tue Jan 23 07:32:42 2018 New Revision: 323208 URL: http://llvm.org/viewvc/llvm-project?rev=323208&view=rev Log: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a Summary: C++2a allows bitfields to have default member initializers. Add

[PATCH] D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165 - Finder->addMatcher( - cxxConstructorDecl( - isDefaultConstructor(),

[PATCH] D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165 - Finder->addMatcher( - cxxConstructorDecl( - isDefaultConstructor(), unless(isInstantiated()), - forEachConstructorInitializer( - cxxC

[PATCH] D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

malcolm.parsons updated this revision to Diff 131069. malcolm.parsons added a comment. Use ternary operator. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42413 Files: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp test/clang-tidy/modernize-use-default-member-init-bitf

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray, CXXTypeidExpr importing.

xazax.hun updated this revision to Diff 131065. xazax.hun retitled this revision from "[ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing." to "[ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTem

[PATCH] D42173: [clangd] Simplify code handling compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL323204: [clangd] Simplify code handling compile commands (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42173 Files: c

[PATCH] D42173: [clangd] Simplify code handling compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323204: [clangd] Simplify code handling compile commands (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42173?vs=131062&id=131067#toc Repository: rL LLVM

[clang-tools-extra] r323204 - [clangd] Simplify code handling compile commands

Author: ibiryukov Date: Tue Jan 23 07:07:52 2018 New Revision: 323204 URL: http://llvm.org/viewvc/llvm-project?rev=323204&view=rev Log: [clangd] Simplify code handling compile commands Summary: CppFile can now change compilation arguments during rebuild. This allows simplifying code that manages

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.h:62 +/// Information required to run clang (e.g., to parse AST or do code +/// completion). +struct ParseInputs { sammccall wrote: > sammccall wrot

[PATCH] D42173: [clangd] Simplify code handling compile commands

ilya-biryukov updated this revision to Diff 131062. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Unwrap the comment - Remove ParseInputs constructor - Document the CppFile invariant Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42173 Files:

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing.

xazax.hun updated this revision to Diff 131059. xazax.hun added a comment. - Added import for CXXTypeidExpr. What is the best way to test this? header is required for using the typeid operator, but relying on the presence of an STL library in tests is usually considered as a bad practice. Sho

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:386 + if (!U) +llvm_unreachable( +"onDiagnosticsReady: Expect creating URI for file to always work."); not sure if this is the right thing to do. idea? Comment at

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. o Replace the existing clangd::URI with a wrapper of FileURI which also carries a resolved file path. o s/FileURI/URI/ Repository: rCTE Clang Tools Ext

[PATCH] D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:165 - Finder->addMatcher( - cxxConstructorDecl( - isDefaultConstructor(), unless(isInstantiated()), - forEachConstructorInitializer( - cxxCto

r323199 - Fix Driver/solaris-ld.c test on Windows

Author: fedor.sergeev Date: Tue Jan 23 05:59:11 2018 New Revision: 323199 URL: http://llvm.org/viewvc/llvm-project?rev=323199&view=rev Log: Fix Driver/solaris-ld.c test on Windows Fixing failure introduced with r323193. Modified: cfe/trunk/test/Driver/solaris-ld.c Modified: cfe/trunk/test/D

[PATCH] D42416: [Driver] Add support for mips32 and scudo

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 131051. simark added a comment. Herald added subscribers: ioeric, jkorous-apple. I just got familiar with the patch, I cleaned up the bits that I thought were unnecessary for this change. For example, we don't need a toJSON function for DidChangeConfigurationP

[PATCH] D42416: [Driver] Add support for mips32 and scudo

sdardis created this revision. sdardis added reviewers: cryptoad, atanasyan. Herald added a subscriber: arichardson. r317337 missed that scudo is supported on MIPS32, so permit that option for MIPS32. Repository: rC Clang https://reviews.llvm.org/D42416 Files: lib/Driver/ToolChains/Linux.c

[clang-tools-extra] r323196 - [clang-tidy] Add -vfsoverlay flag

Author: ibiryukov Date: Tue Jan 23 04:31:06 2018 New Revision: 323196 URL: http://llvm.org/viewvc/llvm-project?rev=323196&view=rev Log: [clang-tidy] Add -vfsoverlay flag Summary: It allows to remap and override files and directories on disk when running clang-tidy. The intended use case for the f

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323196: [clang-tidy] Add -vfsoverlay flag (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41535?vs=130891&id=131046#toc Repository: rCTE Clang Tools Extra

r323195 - [Tooling] Added a VFS parameter to ClangTool

Author: ibiryukov Date: Tue Jan 23 04:30:02 2018 New Revision: 323195 URL: http://llvm.org/viewvc/llvm-project?rev=323195&view=rev Log: [Tooling] Added a VFS parameter to ClangTool Summary: The parameter overrides the underlying vfs used by ClangTool for filesystem operations. Patch by Vladimir

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rC323195: [Tooling] Added a VFS parameter to ClangTool (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41947?vs=130573&id=131045#toc Repository: rC Clang htt

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

This revision was automatically updated to reflect the committed changes. Closed by commit rL323194: [Solaris] Make RHEL devtoolsets handling Linux-specific (authored by fedor.sergeev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

This revision was automatically updated to reflect the committed changes. Closed by commit rL323193: [Solaris] gcc toolchain handling revamp (authored by fedor.sergeev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D35755?vs=110194&id

r323193 - [Solaris] gcc toolchain handling revamp

Author: fedor.sergeev Date: Tue Jan 23 04:23:52 2018 New Revision: 323193 URL: http://llvm.org/viewvc/llvm-project?rev=323193&view=rev Log: [Solaris] gcc toolchain handling revamp Summary: General idea is to utilize generic (mostly Generic_GCC) code and get rid of Solaris-specific handling as muc

r323194 - [Solaris] Make RHEL devtoolsets handling Linux-specific

Author: fedor.sergeev Date: Tue Jan 23 04:24:01 2018 New Revision: 323194 URL: http://llvm.org/viewvc/llvm-project?rev=323194&view=rev Log: [Solaris] Make RHEL devtoolsets handling Linux-specific Summary: This patch is meant to address the last outstanding review comment on the already approved

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

jkorous-apple updated this revision to Diff 131041. jkorous-apple added a comment. Changes based on Volodymyr's comments. https://reviews.llvm.org/D42170 Files: FixIt/fixit-typedef-instead-of-typename-typo.cpp Parse/ParseTemplate.cpp clang/Basic/DiagnosticParseKinds.td Index: FixIt/fixi

  1   2   >