[libunwind] r323499 - Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

Author: mstorsjo Date: Thu Jan 25 22:50:07 2018 New Revision: 323499 URL: http://llvm.org/viewvc/llvm-project?rev=323499=rev Log: Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbols.

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rL323499: Dont enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

fcharlie added a comment. In https://reviews.llvm.org/D42354#988656, @mclow.lists wrote: > I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` > in *that* header file. > > Now I'm wondering if those values `__zero` and `__max` are actually used. Use > grep

[PATCH] D42461: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323496: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[libunwind] r323496 - [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 20:01:50 2018 New Revision: 323496 URL: http://llvm.org/viewvc/llvm-project?rev=323496=rev Log: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath

[PATCH] D42461: [cmake] [libunwind] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131537. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rUNW libunwind https://reviews.llvm.org/D42461 Files: src/CMakeLists.txt Index: src/CMakeLists.txt

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323495: Reland: (authored by dhinton, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42460 Files: libcxxabi/trunk/src/CMakeLists.txt Index: libcxxabi/trunk/src/CMakeLists.txt

[libcxxabi] r323495 - Reland:

Author: dhinton Date: Thu Jan 25 19:41:58 2018 New Revision: 323495 URL: http://llvm.org/viewvc/llvm-project?rev=323495=rev Log: Reland: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington added inline comments. Comment at: src/cxa_demangle.cpp:260-261 + +#if 0 + void dump() const { +char *Buffer = static_cast(std::malloc(1024)); dexonsmith wrote: > Why is this behind `#if 0`? Should you just use something like >

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington updated this revision to Diff 131535. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. In this new patch: - Make the cached values use a 3-way bool type, and default it to false. This simplifies all the Node ctors. - Remove some minor style

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

mclow.lists added a comment. I'm pretty sure I don't want to know what MSFT is doing putting `align_val_t` in *that* header file. Now I'm wondering if those values `__zero` and `__max` are actually used. Repository: rCXX libc++ https://reviews.llvm.org/D42354

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131528. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rCXXA libc++abi https://reviews.llvm.org/D42460 Files: src/CMakeLists.txt Index: src/CMakeLists.txt

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia accepted this revision. Anastasia added a comment. Oh I guess it can be used to exclude the code with long? LGTM! Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323492: Reland: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are tra wrote: > jlebar wrote: >

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are jlebar wrote: > tra wrote: > >

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia added a comment. I am just a bit unclear about the use of this extension in the kernel language. Could you please clarify? Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42220: libcxx: Use vcruntime declarations for typeinfo on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323491: libcxx: Use vcruntime declarations for typeinfo on Windows. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are tra wrote: > jlebar wrote: >

[libcxx] r323491 - libcxx: Use vcruntime declarations for typeinfo on Windows.

Author: pcc Date: Thu Jan 25 17:22:17 2018 New Revision: 323491 URL: http://llvm.org/viewvc/llvm-project?rev=323491=rev Log: libcxx: Use vcruntime declarations for typeinfo on Windows. We need to use the vcruntime declarations on Windows to avoid an ODR violation involving rtti.obj, which

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 17:09, Don Hinton wrote: > > > > On Thu, Jan 25, 2018 at 4:21 PM, Duncan P. N. Exon Smith > > wrote: > > >> On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits >>

[libcxx] r323490 - libcxx: Move #include_next out of header guard in wrapper header.

Author: pcc Date: Thu Jan 25 17:19:23 2018 New Revision: 323490 URL: http://llvm.org/viewvc/llvm-project?rev=323490=rev Log: libcxx: Move #include_next out of header guard in wrapper header. Code on Windows expects to be able to do: #define _USE_MATH_DEFINES #include and receive the

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

tra marked 2 inline comments as done. tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32 + +#define __DEVICE__ static __device__ __forceinline__ +// There are number of functions that became compiler builtins in CUDA-9 and are

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 4:21 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > On Jan 25, 2018, at 13:07, Don Hinton wrote: > > On Thu, Jan 25,

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Ugh, I really wish that we could simplify that wrapping conditional. https://reviews.llvm.org/D42555 ___ cfe-commits mailing list

[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

arphaman created this revision. arphaman added a reviewer: lebedev.ri. This patch looks through typeof type at the original expression when diagnosing -Wsign-compare to avoid an unfriendly diagnostic. Repository: rC Clang https://reviews.llvm.org/D42561 Files: lib/Sema/SemaChecking.cpp

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

This revision was automatically updated to reflect the committed changes. Closed by commit rC323485: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel. (authored by aemerson, committed by ). Repository: rC Clang https://reviews.llvm.org/D42276 Files:

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 16:18, Duncan P. N. Exon Smith via cfe-commits > wrote: > > > >> On Jan 25, 2018, at 13:07, Don Hinton > > wrote: >> >> On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman >

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

> On Jan 25, 2018, at 13:07, Don Hinton wrote: > > On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman > wrote: > Historically we have supported building libcxx without llvm-config available > on the system. > > In all likelihood

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

We have lots of duplicated functionality across the LLVM runtime libraries to continue supporting building them without LLVM sources or installations. Despite my history of being a strong advocate for the runtimes being used without LLVM, I don't really have a horse in this race anymore. Duncan

[PATCH] D42513: [CUDA] Added partial support for CUDA-9.1

jlebar added a comment. Gosh I think the chances we get through this without a copy-paste error are way too high. I'm not sure what to do about it, though. I don't have the focus to check this as carefully as it needs. Perhaps we need to test this in the test-suite (eventually)? We've seen

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

george.karpenkov added a comment. Looks good Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:392 + +auto InitTempSet = State->get(); +if (!InitTempSet.isEmpty()) { Actually I would put both of those into static functions:

[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. When viewing the `ExplodedGraph` through graphviz, make `ExprEngine`'s two private program state traits - namely C++ allocator values and

[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

ng added a comment. Ping https://reviews.llvm.org/D42344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r323479 - Mark 2903 as complete; we already do this

Author: marshall Date: Thu Jan 25 14:33:17 2018 New Revision: 323479 URL: http://llvm.org/viewvc/llvm-project?rev=323479=rev Log: Mark 2903 as complete; we already do this Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131511. Wizard marked 8 inline comments as done. Wizard added a comment. update some documents and comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:93 + [](const std::string ) { return llvm::Regex::escape(s); }); // Allow any of these names: // foo hokein wrote: > Does the comment still make sense?

r323473 - Don't let test write to the source dir after r323426.

Author: nico Date: Thu Jan 25 13:49:03 2018 New Revision: 323473 URL: http://llvm.org/viewvc/llvm-project?rev=323473=rev Log: Don't let test write to the source dir after r323426. Modified: cfe/trunk/test/Driver/cl-x86-flags.c Modified: cfe/trunk/test/Driver/cl-x86-flags.c URL:

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda updated this revision to Diff 131506. hintonda added a comment. Only call llvm_setup_rpath() if LLVM_FOUND is true. Repository: rCXX libc++ https://reviews.llvm.org/D42459 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt

[PATCH] D42552: [analyzer] dump() environment frame-by-frame.

NoQ added a comment. Also printing the location context pointer on every line is redundant, but putting it on the frame line would clamp up the crash dump with weird pointers and also make the frame lines in the state dump visually similar to the environment entry lines. Repository: rC

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 12:54 PM, Chris Bieneman wrote: > Historically we have supported building libcxx without llvm-config > available on the system. > > In all likelihood the bots didn't fail because the bots do have > llvm-config because we usually require an llvm build or

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

mstorsjo created this revision. mstorsjo added reviewers: compnerd, smeenai, phosek. Herald added subscribers: kristof.beyls, aemerson. Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbols. This didn't occur for the apple && arm case due to specifically

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Historically we have supported building libcxx without llvm-config available on the system. In all likelihood the bots didn't fail because the bots do have llvm-config because we usually require an llvm build or source checkout in order to build and run the tests since tests depend on lit and

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

On Thu, Jan 25, 2018 at 12:29 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > I don't really understand why, but our bots seemed to survive this: > http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/ > > Console output is here: >

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > ilya-biryukov wrote: > > > simark wrote: > > >

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

I don't really understand why, but our bots seemed to survive this: http://lab.llvm.org:8080/green/view/Libcxx/job/libcxx_master_cmake/2137/ Console output is here:

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda requested review of this revision. hintonda added a comment. I probably should have put this in the summary, but the reason for this patch isn't just to clean up the cmake files, it's to fix a cmake configuration failure when cross-compiling for Linux on Darwin: CMake Error at

[PATCH] D42552: [analyzer] dump() environment frame-by-frame.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Like this: Expressions by stack frame: #0 Calling bar at line 9 (0x7fbe2a60ea10,0x7fbe2b86ca30) x : 1 S32b #1 Calling foo

r323461 - AST: inline a single-use variable (NFC)

Author: compnerd Date: Thu Jan 25 11:54:31 2018 New Revision: 323461 URL: http://llvm.org/viewvc/llvm-project?rev=323461=rev Log: AST: inline a single-use variable (NFC) Inline the single use variable into the only use. NFC. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp Modified:

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Ah, I think that's the issue. local:/Users/dhinton/projects/llvm_project/libcxxabi $ cat .arcconfig { "repository.callsign" : "CXXA", "conduit_uri" : "https://reviews.llvm.org/; } So, it should set repository to CXXA, not LLVM. On Thu, Jan 25, 2018 at 11:25 AM, Ben Hamilton

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen after rollback. @smeenai pointed out LLVM may not be available in standalone builds Repository: rL LLVM https://reviews.llvm.org/D42460

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen after rollback. @smeenai pointed out LLVM may not be available in standalone builds Repository: rCXX libc++ https://reviews.llvm.org/D42459

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Yes, that's currently a submit time feature built in to Phabricator which i believe we'll have to fix upstream. Because both the top level LLVM SVN report and the sub repos see the same files, Phabricator automatically subscribes both lists to the commits. I wasn't able to find an easy way to

[libcxx] r323459 - Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 11:22:23 2018 New Revision: 323459 URL: http://llvm.org/viewvc/llvm-project?rev=323459=rev Log: Revert [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. Shoaib Meenai pointed out this will break standalone builds when

[libcxxabi] r323458 - Revert [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 11:18:51 2018 New Revision: 323458 URL: http://llvm.org/viewvc/llvm-project?rev=323458=rev Log: Revert [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries. Shoaib Meenai pointed out this will break standalone builds can

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added inline comments. Comment at: lib/AST/ExprClassification.cpp:652 +if (Ctx.getCanonicalType(ASE->getBase()->getType()).isConstQualified()) + return Cl::CM_ConstQualified; + Is there a reason why the places that compute the type of these

[PATCH] D42521: [CodeGen] Use the non-virtual alignment when emitting the base class subobject constructor

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D42521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Same concerns about building standalone as r323453. From: cfe-commits on behalf of Don Hinton via cfe-commits Reply-To: Don Hinton Date: Thursday, January 25, 2018 at 10:45 AM To: "cfe-commits@lists.llvm.org"

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This is going to break building libc++ standalone (i.e. without any LLVM repository or even its CMake modules), right? Some upstream users care a lot about that use case (CC beanz and Duncan). From: cfe-commits on behalf of Don Hinton via cfe-commits

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Btw, I'm seeing other inconsistencies, e.g., I just committed https://reviews.llvm.org/D42460 and herald ended up adding both cfe-commits and llvm-commits to subscribers. When I created it, I left subscribers blank, so herald added cfe-commits -- which seems to be correct. Then, when I committed

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

mattd created this revision. mattd added a reviewer: majnemer. This change avoids the overhead of storing, and later crawling, an initializer list of all zeros for arrays. When LLVM visits this (llvm/IR/Constants.cpp) ConstantArray::getImpl() it will scan the list looking for an array of all

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 131481. juliehockett added a comment. Herald added a subscriber: hintonda. Cleaning up a few unnecessary copyings https://reviews.llvm.org/D41102 Files: test/CMakeLists.txt test/Tooling/clang-doc-basic.cpp test/lit.cfg.py tools/CMakeLists.txt

[PATCH] D42460: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323455: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 10:43:18 2018 New Revision: 323455 URL: http://llvm.org/viewvc/llvm-project?rev=323455=rev Log: [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323453: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42459?vs=131195=131478#toc

[PATCH] D42248: Always allow "#pragma region".

mattd added a comment. Thanks @majnemer! Would you mind committing this on my behalf? I do not have commit access, thanks. https://reviews.llvm.org/D42248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton Date: Thu Jan 25 10:13:26 2018 New Revision: 323453 URL: http://llvm.org/viewvc/llvm-project?rev=323453=rev Log: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries. Clang and llvm already use llvm_setup_rpath(), so this change will help standarize rpath usage

[PATCH] D42508: AST: support protocol conformances on id/class/interfaces in MS ABI

compnerd updated this revision to Diff 131477. compnerd added a comment. Add additional test cases as discussed on IRC. These ensure that the back reference handling is correct. Repository: rC Clang https://reviews.llvm.org/D42508 Files: lib/AST/MicrosoftMangle.cpp

[PATCH] D42248: Always allow "#pragma region".

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Thanks Ben... On Thu, Jan 25, 2018 at 9:53 AM, Ben Hamilton wrote: > Ah, I see from http://bcain-llvm.readthedocs.io/projects/ > libunwind/en/latest/ that libunwind review discussion does take place on > cfe-commits. > > Added. Sorry about not doing that earlier! > > Ben

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. And sorry for confusion with https://reviews.llvm.org/D42524, if any. Comment at: clangd/Function.h:147 - ScopeExitGuard(Func F) : F(std::move(F)) {}

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Ah, I see from http://bcain-llvm.readthedocs.io/projects/libunwind/en/latest/ that libunwind review discussion does take place on cfe-commits. Added. Sorry about not doing that earlier! Ben On Thu, Jan 25, 2018 at 8:37 AM Ben Hamilton wrote: > Great question. Is there

[PATCH] D42248: Always allow "#pragma region".

Quuxplusone added a comment. FWIW, I would also like this patch, because it would mean that I could build with -Werror even when the project includes headers written by MSVC-using people. Given that we know what "#pragma region" does, it hardly deserves an "unknown pragma" diagnostic! So this

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton marked an inline comment as done. benhamilton added inline comments. Comment at: test/Format/lit.local.cfg:2-3 +# Suffixes supported by clang-format. +config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.proto', + '.protodevel',

[PATCH] D41454: [clangd] Add ClangdUnit diagnostics tests using annotated code.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323448: [clangd] Add ClangdUnit diagnostics tests using annotated code. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D41454?vs=127843=131471#toc

[clang-tools-extra] r323448 - [clangd] Add ClangdUnit diagnostics tests using annotated code.

Author: sammccall Date: Thu Jan 25 09:29:17 2018 New Revision: 323448 URL: http://llvm.org/viewvc/llvm-project?rev=323448=rev Log: [clangd] Add ClangdUnit diagnostics tests using annotated code. Summary: This adds checks that our diagnostics emit correct ranges in a bunch of cases, as promised

[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

benhamilton updated this revision to Diff 131470. benhamilton added a comment. - Add more extensions. Repository: rC Clang https://reviews.llvm.org/D42395 Files: test/Format/dump-config-cxx.h test/Format/dump-config-objc.h test/Format/lit.local.cfg tools/clang-format/ClangFormat.cpp

[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

sammccall added inline comments. Comment at: clangd/ClangdLSPServer.cpp:283 llvm::Optional Result = Server.switchSourceHeader(Params.uri.file); - std::string ResultUri; - reply(C, Result ? URI::fromFile(*Result).uri : ""); + std::string ResultUri = ""; + if (Result) {

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin added a comment. Thank you, Gabor. I'll change cast<> to cast_or_null<> to enable the assertion below. Repository: rC Clang https://reviews.llvm.org/D42301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42525: [clangd] Replace Optional in ScopeExitGuard (fix after r322838)

sammccall added a comment. r323443 removed ScopeExitGuard altogether. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r323443 - [clangd] Replace homegrown make_scope_exit with one from ADT

Author: sammccall Date: Thu Jan 25 09:01:39 2018 New Revision: 323443 URL: http://llvm.org/viewvc/llvm-project?rev=323443=rev Log: [clangd] Replace homegrown make_scope_exit with one from ADT Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray, CXXTypeidExpr importing.

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D42335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42248: Always allow "#pragma region".

mattd added a comment. Ping. https://reviews.llvm.org/D42248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

miyuki created this revision. miyuki added reviewers: faisalv, rsmith. According to [dcl.init.list]p7: A narrowing conversion is an implicit conversion - ... - from an integer type or unscoped enumeration type to a floating-point type, except where the source is a constant

Re: Please subscribe "rUNW libunwind" to cfe-commits.

Great question. Is there an existing separate list for libunwind? If libunwind discussion already happens on cfe-commits, then I'll make reviews for libunwind subscribe that list. On Tue, Jan 23, 2018, 21:40 Don Hinton wrote: > Currently, herald doesn't subscribe libunwind

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

sammccall updated this revision to Diff 131460. sammccall marked 4 inline comments as done. sammccall added a comment. Address review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42499 Files: clangd/ClangdUnit.cpp clangd/Context.h clangd/Function.h

[PATCH] D42174: [clangd] Refactored threading in ClangdServer

sammccall added a comment. Agreed we can defer lots of stuff in order to keep this patch compact. Generally the things I think we can get right before landing: - names and file organization for new things - documentation including where we want to get to Comment at:

r323435 - Unused diagnostics can occur in tblgen.

Author: d0k Date: Thu Jan 25 07:57:22 2018 New Revision: 323435 URL: http://llvm.org/viewvc/llvm-project?rev=323435=rev Log: Unused diagnostics can occur in tblgen. Modified: cfe/trunk/utils/find-unused-diagnostics.sh Modified: cfe/trunk/utils/find-unused-diagnostics.sh URL:

[PATCH] D42499: [clangd] Modify the Span API so that Spans propagate with contexts.

sammccall marked 5 inline comments as done. sammccall added a comment. In https://reviews.llvm.org/D42499#987583, @ilya-biryukov wrote: > I've tried experimenting with that and came up with an alternative that has > less changes to the API. Could you take a look, too? >

[PATCH] D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512

thakis closed this revision. thakis added a comment. r323433, thanks! https://reviews.llvm.org/D42538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r323433 - [clang-cl] Add support for /arch:AVX512F and /arch:AVX512

Author: nico Date: Thu Jan 25 07:24:43 2018 New Revision: 323433 URL: http://llvm.org/viewvc/llvm-project?rev=323433=rev Log: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512 For /arch:AVX512F: clang-cl and cl.exe both defines __AVX512F__ __AVX512CD__. clang-cl also defines __AVX512ER__

[PATCH] D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D42538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512

thakis created this revision. thakis added a reviewer: hans. thakis edited the summary of this revision. Also refactor the existing AVX / AVX2 code to not repeat itself in both the 32-bit and 64-bit cases. For /arch:AVX512F, we define `__AVX512F__` `__AVX512CD__` `__AVX512ER__` `__AVX512PF__`.

[clang-tools-extra] r323431 - Removed Unicode BOM.

Author: alexfh Date: Thu Jan 25 07:09:33 2018 New Revision: 323431 URL: http://llvm.org/viewvc/llvm-project?rev=323431=rev Log: Removed Unicode BOM. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp Modified:

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:78 {"documentHighlightProvider", true}, +{"configurationChangeProvider", true}, {"renameProvider", true}, simark wrote: > Nebiroth wrote: > > simark

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( ilya-biryukov wrote: > simark wrote: > > ilya-biryukov wrote: > > > Are you planning to

  1   2   >