[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans I'd like to have this in 6.0 as well, to allow building Qt for windows as DLLs. Repository: rL LLVM https://reviews.llvm.org/D42641 ___ cfe-commits mailing list

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. LGTM. Repository: rC Clang https://reviews.llvm.org/D42811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: test/clang-tidy/modernize-avoid-functional.cpp:30 + +// CHECK-MESSAGES: [[@LINE+1]]:25: warning: 'binary_function' is deprecated in C++11 and removed in C++17

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

massberg updated this revision to Diff 132538. massberg added a comment. Addressed comments of reviewers. https://reviews.llvm.org/D42730 Files: clang-tidy/modernize/AvoidFunctionalCheck.cpp clang-tidy/modernize/AvoidFunctionalCheck.h clang-tidy/modernize/CMakeLists.txt

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL324059: [MinGW] Emit typeinfo locally for dllimported classes without key functions (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r324059 - [MinGW] Emit typeinfo locally for dllimported classes without key functions

Author: mstorsjo Date: Thu Feb 1 22:22:35 2018 New Revision: 324059 URL: http://llvm.org/viewvc/llvm-project?rev=324059=rev Log: [MinGW] Emit typeinfo locally for dllimported classes without key functions This fixes building Qt as shared libraries with clang in MinGW mode; previously subclasses

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132532. NoQ marked an inline comment as done. NoQ added a comment. Cleanup construction contexts after they have been consumed. Add assertions to verify that our understanding of the context's lifespan is reasonable. I will run the new mode on a large codebase

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

stephanemoore added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1214 // FIXME: We likely want to do this for more combinations of brackets. // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket ==

[PATCH] D42800: Let CUDA toolchain support amdgpu target

gregrodgers added a comment. Sorry, all my great inline comments got lost somehow. I am a newbie to Phabricator. I will try to reconstruct my comments. https://reviews.llvm.org/D42800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd added a comment. @rnk thats not a bad idea. However, I had implemented it slightly differently. I mangled it as if it was a PMF: so you get `__Swift::__swift_cc::*` as the type. Repository: rC Clang https://reviews.llvm.org/D42768

[PATCH] D42800: Let CUDA toolchain support amdgpu target

gregrodgers requested changes to this revision. gregrodgers added a comment. This revision now requires changes to proceed. Thanks to everyone for the reviews. I hope I replied to all inline comments. Since I sent this to Sam to post, we discovered a major shortcoming. As tra points out,

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd updated this revision to Diff 132528. compnerd added a comment. Handle the non-top-level decl case Repository: rC Clang https://reviews.llvm.org/D42768 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-swiftcall-cc.cpp Index: test/CodeGenCXX/msabi-swiftcall-cc.cpp

[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rL324053: [analyzer] Fix transitions in check::PreStmtMemberExpr checker callback. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r324053 - [analyzer] Fix transitions in check::PreStmt checker callback.

Author: dergachev Date: Thu Feb 1 18:23:37 2018 New Revision: 324053 URL: http://llvm.org/viewvc/llvm-project?rev=324053=rev Log: [analyzer] Fix transitions in check::PreStmt checker callback. No in-tree checkers use this callback so far, hence no tests. But better fix this now than remember to

r324052 - [analyzer] Expose return statement from CallExit program point

Author: george.karpenkov Date: Thu Feb 1 18:19:43 2018 New Revision: 324052 URL: http://llvm.org/viewvc/llvm-project?rev=324052=rev Log: [analyzer] Expose return statement from CallExit program point If the return statement is stored, we might as well allow querying against it. Also fix the bug

r324050 - Remove the change which accidentally crept in into the cherry-pick

Author: george.karpenkov Date: Thu Feb 1 18:14:33 2018 New Revision: 324050 URL: http://llvm.org/viewvc/llvm-project?rev=324050=rev Log: Remove the change which accidentally crept in into the cherry-pick Modified: cfe/trunk/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp Modified:

[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

MTC added a comment. In https://reviews.llvm.org/D42785#995211, @NoQ wrote: > Ew. So it means that checker transitions are currently discarded. Great > catch. I guess we don't use this functionality yet, so we can't test it, but > the fix should definitely go in. You are right, that's why I

r324049 - [analyzer] Expose exploration strategy through analyzer options.

Author: george.karpenkov Date: Thu Feb 1 18:01:55 2018 New Revision: 324049 URL: http://llvm.org/viewvc/llvm-project?rev=324049=rev Log: [analyzer] Expose exploration strategy through analyzer options. Differential Revision: https://reviews.llvm.org/D42774 Modified:

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132520. NoQ added a comment. Add more targeted tests. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

[PATCH] D42777: [analyzer] Fix yet-another-crash in body-farming std::call_once

This revision was automatically updated to reflect the committed changes. Closed by commit rC324046: [analyzer] Fix yet-another-crash in body-farming std::call_once (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r324046 - [analyzer] Fix yet-another-crash in body-farming std::call_once

Author: george.karpenkov Date: Thu Feb 1 17:44:07 2018 New Revision: 324046 URL: http://llvm.org/viewvc/llvm-project?rev=324046=rev Log: [analyzer] Fix yet-another-crash in body-farming std::call_once Crash occurs when parameters to the callback and to std::call_once mismatch, and C++ is

[PATCH] D42606: [Coroutines] Use allocator overload when available

GorNishanov added inline comments. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to the coroutine frame allocation function. + auto *AllocateCall =

[PATCH] D42606: [Coroutines] Use allocator overload when available

GorNishanov requested changes to this revision. GorNishanov added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rnk added a comment. In https://reviews.llvm.org/D42768#994458, @rjmccall wrote: > No, I mean things like `void foo(__attribute__((swiftcall)) void > (*fnptr)());`. Yeah, this was the example I was going to bring up. There's no function parameter declaration to put the NNS on. So, here's an

[PATCH] D42829: Emit label names according to -discard-value-names.

EricWF created this revision. EricWF added reviewers: erichkeane, aaron.ballman, majnemer. Previously, Clang only emitted label names in assert builds. However there is a CC1 option -discard-value-names that should have been used to control emission instead. This patch removes the

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

kromanova added subscribers: kromanova, alexfh. kromanova added a comment. We have a request for this feature in clang-format in Sony. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22505: clang-format Access Modifier Use Normal Indent

mithro added a comment. Herald added subscribers: hintonda, mgorny. I was wondering what the status of this feature was? Looks like it was last touched back in Aug 2 2016 -- do you know if a different or replacement patch was landed? I have a project

r324037 - [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

Author: ericwf Date: Thu Feb 1 15:47:54 2018 New Revision: 324037 URL: http://llvm.org/viewvc/llvm-project?rev=324037=rev Log: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object. Summary: Fix NRVO for Gro variable. Previously, we only marked the GRO declaration as an NRVO

[PATCH] D42343: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

EricWF updated this revision to Diff 132495. EricWF added a comment. I had to revert due to failing tests when using a non-assert Clang build. This change fixes those tests to no longer depend on label names. https://reviews.llvm.org/D42343 Files: lib/Sema/SemaCoroutine.cpp

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

probinson added a comment. +1 for testcase. Repository: rC Clang https://reviews.llvm.org/D42351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r324033 - Disable test in C++<11 mode due to use of alignas.

Author: rsmith Date: Thu Feb 1 15:31:22 2018 New Revision: 324033 URL: http://llvm.org/viewvc/llvm-project?rev=324033=rev Log: Disable test in C++<11 mode due to use of alignas. Modified: libcxx/trunk/test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp Modified:

[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

vsapsai added a comment. In https://reviews.llvm.org/D42755#994775, @Hahnfeld wrote: > Can you please add a summary that describes which filesystem this problem can > be seen with? I think outside people can't access rdar tickets, so I can only > guess that it's related to APFS? Further

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:302 +// FIXME: This function needs to be properly tested. +void ClangdLSPServer::onChangeConfiguration( simark wrote: > ilya-biryukov wrote: > > simark wrote: > > > simark wrote: > > > >

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

I backported these to the release_50 branch in the following revisions: llvm r324007, r324009 cfe r324012 lld r324025, r324026 The regression test suites pass on my machine with the exception of two pre-existing failures. I also built my small retpoline execution test that does a variety of

[PATCH] D42819: [analyzer] [tests] [NFC] Remove dead code from CmpRuns

This revision was automatically updated to reflect the committed changes. Closed by commit rC324027: [analyzer] [tests] [NFC] Remove dead code from CmpRuns (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r324027 - [analyzer] [tests] [NFC] Remove dead code from CmpRuns

Author: george.karpenkov Date: Thu Feb 1 14:40:01 2018 New Revision: 324027 URL: http://llvm.org/viewvc/llvm-project?rev=324027=rev Log: [analyzer] [tests] [NFC] Remove dead code from CmpRuns Indeed, "CHANGE" is not a thing yet, and we should probably not carry around dead code which does not

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:3899 + if (auto *CE = const_cast(NE->getConstructExpr())) +CurrentConstructionContext = {/*Constructor=*/CE, /*Trigger=*/NE}; + dcoughlin wrote: > Is it possible that there is already a

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 132476. NoQ marked 5 inline comments as done. NoQ added a comment. Address comments. Most importantly, separate out sema and analyzer CFG tests. https://reviews.llvm.org/D42672 Files: include/clang/Analysis/AnalysisDeclContext.h

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX324020: Make std::get_temporary_buffer respect overaligned types when possible (authored by rsmith, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D41746 Files: include/memory

r324021 - [analyzer] [tests] Add an option to show the histogram of path differences between the analyzer runs

Author: george.karpenkov Date: Thu Feb 1 14:25:18 2018 New Revision: 324021 URL: http://llvm.org/viewvc/llvm-project?rev=324021=rev Log: [analyzer] [tests] Add an option to show the histogram of path differences between the analyzer runs Differential Revision: https://reviews.llvm.org/D42778

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324018: [analyzer] Dont communicate evaluation failures through memregion hierarchy. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r324018 - [analyzer] Don't communicate evaluation failures through memregion hierarchy.

Author: dergachev Date: Thu Feb 1 14:17:05 2018 New Revision: 324018 URL: http://llvm.org/viewvc/llvm-project?rev=324018=rev Log: [analyzer] Don't communicate evaluation failures through memregion hierarchy. We use CXXTempObjectRegion exclusively as a bailout value for construction targets when

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This is actually consistent with what Microsoft does for dllimport classes. They don't have key functions, but they do import vftables when a class is dllimport and the constructor is inline. They

Re: [PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

On Wed, Jan 31, 2018 at 7:23 PM, Paul Robinson via Phabricator < revi...@reviews.llvm.org> wrote: > probinson added a comment. > > In https://reviews.llvm.org/D42758#993936, @ruiu wrote: > > > > I also wonder which is better `#pragma comment(lib, "m")` or `#pragma > comment(lib, "m")`. > > > >

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd updated this revision to Diff 132464. mattd added a comment. Updating the diff, missed a few deltas that should have been in the original patch. https://reviews.llvm.org/D42813 Files: include/clang/Sema/Scope.h lib/Sema/SemaStmt.cpp test/CodeGenCXX/debug-for-range-scope-hints.cpp

[PATCH] D42813: [Debug] Annotate compiler generated range-for loop variables.

mattd created this revision. mattd added a reviewer: rsmith. mattd edited the summary of this revision. This change aims to simplify debugging by annotating the range-for loop artificial variables (range, begin, end) with the scope depth. https://reviews.llvm.org/D42813 Files: SemaStmt.cpp

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

erik.pilkington added a comment. Hi Akira, thanks for working on this! Comment at: lib/AST/ExprConstant.cpp:1165-1173 + auto LB = Temporaries.lower_bound(Key); + + // If an element with key Key is found, reset the value and return it. This + // can happen if Key is part of

[PATCH] D42549: [CodeGen] Use the zero initializer instead of storing an all zero representation.

mattd added a comment. Ping :) https://reviews.llvm.org/D42549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132459. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42812: [clang-tidy] ObjC ARC objects should not trigger performance-unnecessary-value-param

benhamilton created this revision. benhamilton added reviewers: alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun, klimek. The following Objective-C code currently incorrectly triggers clang-tidy's performance-unnecessary-value-param check: % cat

[PATCH] D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. When trying to track down a different bug, we discovered that calling `__builtin_va_arg` on a vec3f type caused the SROA pass to issue a warning that there was an illegal access. Further research showed that the

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

NoQ updated this revision to Diff 132450. NoQ added a comment. Switched to plain bools and in-class initializers. https://reviews.llvm.org/D42457 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D42673: [RISCV] Pick the correct RISCV linker instead of calling riscv-gcc to link

mgrang abandoned this revision. mgrang added a comment. For now, by setting the full triple (riscv-unknown-linux-gnu) we are able to invoke the correct gnu linker. So will abandon this patch. Repository: rC Clang https://reviews.llvm.org/D42673

[PATCH] D42645: New simple Checker for mmap calls

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:62 + + ExplodedNode *N = C.generateErrorNode(); + if (!N) You should also use `generateNonFatalErrorNode()` here so that not to prevent the analyzer from

r323998 - PR36157: When injecting an implicit function declaration in C89, find the right

Author: rsmith Date: Thu Feb 1 12:01:49 2018 New Revision: 323998 URL: http://llvm.org/viewvc/llvm-project?rev=323998=rev Log: PR36157: When injecting an implicit function declaration in C89, find the right DeclContext rather than injecting it wherever we happen to be. This avoids creating

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

ilya-biryukov added a comment. The following assertion from `DeclContext::removeDecl` was failing before: assert((D->NextInContextAndBits.getPointer() || D == LastDecl) && "decl is not in decls list"); Repository: rC Clang https://reviews.llvm.org/D42810

[PATCH] D42810: [Sema] Add implicit members even for invalid CXXRecordDecls

ilya-biryukov created this revision. ilya-biryukov added a reviewer: bkramer. It should be safe, since other code paths are already generating implicit members even in invalid CXXRecordDecls (e.g. lookup). If we don't generate implicit members on CXXRecordDecl's completion, they will be

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. I would not worry about cross platform here. You can patch just Linux and whoever have access (and issues) on other platforms can send a patch with similar changes. Mac should use libc++. I'd put the test outside of Posix, and mark failing platforms as "// XFAIL:",

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

rjmccall added a comment. That's still just const-propagation. The const qualifier on the pointee type of this should propagate to the l-value resulting from the member access, and the vector-specific projection logic should continue to propagate const to the type of the element l-value.

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

vitalybuka added a comment. Could you please reformat it? With git I usually use: git clang-format -f --style=file HEAD^ Repository: rCRT Compiler Runtime https://reviews.llvm.org/D42644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ew. So it means that checker transitions are currently discarded. Great catch. I guess we don't use this functionality yet, so we can't test it, but the fix should definitely go in. Then, again,

[PATCH] D42803: [clangd] Log dropped diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323992: [clangd] Log dropped diagnostics. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D42803?vs=132430=132432#toc Repository: rCTE Clang Tools Extra

Re: r323155 - Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target

+Hans Wennborg +tstel...@redhat.com So the retpoline patch series we should get back ported start with this revision and have two follow ups: r323155 r323288 r323915 +Reid Kleckner was going to look at doing the (likely more involved)

[PATCH] D42803: [clangd] Log dropped diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL323992: [clangd] Log dropped diagnostics. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42803 Files:

[PATCH] D42803: [clangd] Log dropped diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:182 + SmallString<64> Message; + D.FormatDiagnostic(Message); + sammccall wrote: > does Message include file:line? we probably want that in the log line. No, it didn't include the line

[clang-tools-extra] r323992 - [clangd] Log dropped diagnostics.

Author: ibiryukov Date: Thu Feb 1 11:06:45 2018 New Revision: 323992 URL: http://llvm.org/viewvc/llvm-project?rev=323992=rev Log: [clangd] Log dropped diagnostics. Summary: clangd drops diagnostics coming outside the main file, but it is still useful to see that something went wrong in the

[PATCH] D42803: [clangd] Log dropped diagnostics.

ilya-biryukov updated this revision to Diff 132430. ilya-biryukov added a comment. - Show location of dropped diagnostic. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42803 Files: clangd/ClangdUnit.cpp Index: clangd/ClangdUnit.cpp

[libcxx] r323989 - Put the exception classes for experimental::optional and experimental::any back in the dylib for binary compatibility

Author: marshall Date: Thu Feb 1 10:45:57 2018 New Revision: 323989 URL: http://llvm.org/viewvc/llvm-project?rev=323989=rev Log: Put the exception classes for experimental::optional and experimental::any back in the dylib for binary compatibility Modified: libcxx/trunk/src/any.cpp

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther added a comment. It seems to have been. I've been using a modified version of clang-format with this change applied (as well as http://reviews.llvm.org/D17922) since I submitted this. https://reviews.llvm.org/D17700 ___ cfe-commits

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

kubamracek added a comment. > This is our first patch so we're unfamiliar with the LLVM testing > infrastructure. Could you please tell us what kind of test you'd like? An > example would also be great. Thank you for your first contribution! I'm going to comment on the testing infrastructure

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

dcasadevall added a comment. Was this lost in the woods? I believe this is a valid change when working in Objective-C https://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42800: Let CUDA toolchain support amdgpu target

tra added a comment. I don't have enough knowledge about compute on AMD's GPU and would appreciate if you could share your thoughts on how you think CUDA on AMD should work. Is there a good document describing how compute currently works (how do I launch a kernel using rough equivalent of

[PATCH] D42803: [clangd] Log dropped diagnostics.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdUnit.cpp:182 + SmallString<64> Message; + D.FormatDiagnostic(Message); + does Message include file:line? we probably

r323986 - Mark fallthrough with LLVM_FALLTHROUGH

Author: adrian Date: Thu Feb 1 10:10:20 2018 New Revision: 323986 URL: http://llvm.org/viewvc/llvm-project?rev=323986=rev Log: Mark fallthrough with LLVM_FALLTHROUGH Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL:

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

dblaikie added inline comments. Comment at: test/CodeGen/debug-info-enum.cpp:2 +// RUN: %clang -target x86_64-linux -g -S -emit-llvm -o - %s | FileCheck %s +enum class E0 : signed char { + A0 = -128, Could you summarize the purpose of each of these tests

[PATCH] D42800: Let CUDA toolchain support amdgpu target

arsenm added inline comments. Comment at: lib/Basic/Targets/AMDGPU.cpp:437 + case CudaArch::UNKNOWN: +assert(false && "No GPU arch when compiling CUDA device code."); +return ""; llvm_unreachable Comment at:

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

chill updated this revision to Diff 132414. chill added a comment. Minor update, the parameter to `createEnumerator` is `IsUnsigned` now (instead of `IsSigned`), changed caller. https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-enum.cpp

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/AvoidFunctionalCheck.h:19 + +/// Check for several deprecated types and classes from header +/// alexfh wrote: > aaron.ballman wrote: > > alexfh wrote: > > > Quuxplusone wrote: > > > >

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

avt77 added a comment. In fact we have here another problem: it is not an attempt to assign to const variable but it is an attempt to use the field assingment inside const method: I'm working on it. https://reviews.llvm.org/D42530 ___

[PATCH] D42800: Let CUDA toolchain support amdgpu target

yaxunl added a comment. In https://reviews.llvm.org/D42800#994955, @Hahnfeld wrote: > Only commenting on parts that I'm a bit familiar with. In general, does it > make sense to split this patch, are there different "stages" of support? Like > 1) being able to compile an empty file, 2) generate

[PATCH] D16403: Add scope information to CFG

m.ostapenko updated this revision to Diff 132393. m.ostapenko added a comment. Fix scope ends order (as discussed above) and adjust a testcase. Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisDeclContext.h include/clang/Analysis/CFG.h

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Doh, nevermind - SuppressUnwrittenScopes is way simpler. Thanks @hokein for catching! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796

[PATCH] D42803: [clangd] Log dropped diagnostics.

ilya-biryukov created this revision. ilya-biryukov added reviewers: hokein, ioeric, sammccall. Herald added subscribers: jkorous-apple, klimek. clangd drops diagnostics coming outside the main file, but it is still useful to see that something went wrong in the logs. Repository: rCTE Clang

Re: [PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

(To be clear, the patch as-is is 100% fine with me.) On Thu, Feb 1, 2018 at 11:44 AM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Using runtime availability checking doesn't make sense for a system > Libc++, as you point out. If we add runtime checks they

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice catch, and nice fix! Might be worth adding a motivating example to the patch description. Comment at: clangd/index/SymbolCollector.cpp:68 +// For a symbol

[PATCH] D42800: Let CUDA toolchain support amdgpu target

Hahnfeld added a comment. Only commenting on parts that I'm a bit familiar with. In general, does it make sense to split this patch, are there different "stages" of support? Like 1) being able to compile an empty file, 2) generate optimized code, 3) allow using math functions?

Re: [PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

Using runtime availability checking doesn't make sense for a system Libc++, as you point out. If we add runtime checks they ought to be non-default, and hidden behind configuration flags. Also, do I remember correctly that __builtin_available requires linking against Foundation (and thus the

[clang-tools-extra] r323980 - [clang-tidy] misc-redundant-expression: fix a crash under ubsan

Author: alexfh Date: Thu Feb 1 08:39:12 2018 New Revision: 323980 URL: http://llvm.org/viewvc/llvm-project?rev=323980=rev Log: [clang-tidy] misc-redundant-expression: fix a crash under ubsan Modified: clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:69 +// qualifier. Inline namespaces and unscoped enums are skipped. +llvm::Expected getScope(const NamedDecl *ND) { + llvm::SmallVector Contexts; There is a

[PATCH] D42704: [clang-format] Do not break Objective-C string literals inside array literals

benhamilton added a comment. Ping! Any comments? Repository: rC Clang https://reviews.llvm.org/D42704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r323979 - Remove std::experimental::sample; use std::sample instead. See https://libcxx.llvm.org/TS_deprecation.html

Author: marshall Date: Thu Feb 1 08:36:08 2018 New Revision: 323979 URL: http://llvm.org/viewvc/llvm-project?rev=323979=rev Log: Remove std::experimental::sample; use std::sample instead. See https://libcxx.llvm.org/TS_deprecation.html Removed:

[PATCH] D42800: Let CUDA toolchain support amdgpu target

yaxunl created this revision. yaxunl added reviewers: gregrodgers, jlebar, b-sumner, t-tye, arsenm. Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl, jholewinski. Currently CUDA toolchain only supports nvptx. This patch will let CUDA toolchain support amdgpu target. It can also

[PATCH] D42742: [clangd] Use pthread instead of thread_local to support more runtimes.

jyknight added a comment. Is there some way to figure out what's going on in clang-x86_64-linux-selfhost-modules? I believe there should be no linux builders which are missing this function -- it was added to libgcc in 4.8, and we don't support older versions, so I think missing this function

[PATCH] D42796: [clangd] Skip inline namespace when collecting scopes for index symbols.

ioeric created this revision. ioeric added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42796 Files: clangd/index/SymbolCollector.cpp

[libcxx] r323975 - Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html

Author: marshall Date: Thu Feb 1 07:49:27 2018 New Revision: 323975 URL: http://llvm.org/viewvc/llvm-project?rev=323975=rev Log: Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html Removed: libcxx/trunk/test/std/experimental/numeric/ Modified:

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

mzeren-vmw updated this revision to Diff 132395. mzeren-vmw added a comment. - Reviewers: drop euhlmann, add djasper - Rebase - Ping Repository: rC Clang https://reviews.llvm.org/D42034 Files: unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[libcxx] r323972 - Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html

Author: marshall Date: Thu Feb 1 07:21:14 2018 New Revision: 323972 URL: http://llvm.org/viewvc/llvm-project?rev=323972=rev Log: Remove ; use instead. See https://libcxx.llvm.org/TS_deprecation.html Removed: libcxx/trunk/test/libcxx/experimental/any/

[PATCH] D42035: [clang-format] Fixup #include guard indents after parseFile()

mzeren-vmw updated this revision to Diff 132394. mzeren-vmw added a comment. - Add comments to IncludeGuardState. - Fix re-initialization of IncludeGuard in UnwrappedLineParser::reset. - Remove unnecessary block after if. - Rebase Repository: rC Clang https://reviews.llvm.org/D42035 Files:

r323956 - Reverting patch rL323952 due to build errors that I

Author: s.desmalen Date: Thu Feb 1 04:27:13 2018 New Revision: 323956 URL: http://llvm.org/viewvc/llvm-project?rev=323956=rev Log: Reverting patch rL323952 due to build errors that I haven't encountered in local builds. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp

  1   2   >