[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

rsmith added a comment. In https://reviews.llvm.org/D43153#1004464, @AntonBikineev wrote: > So is my impression wrong and names in declaration-specifiers/declarators of > partial-specialiations of variable-templates should be exempted from checks > as well? No, sorry, that's my error not your

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

AntonBikineev added a comment. @rsmith Thanks for pointing out this example. Now I see that I misunderstood the wording. Another question is that in the provided example you say that the following line template A::B x; // ok! should suppress the error of accessing private A::B. But in the wor

[PATCH] D43167: Fix incorrect indentation.

brucem created this revision. brucem added a reviewer: mclow.lists. Repository: rCXX libc++ https://reviews.llvm.org/D43167 Files: include/ios Index: include/ios === --- include/ios +++ include/ios @@ -670,7 +670,7 @@ voi

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 133778. brucem added a comment. More nullptr usage. Repository: rCXX libc++ https://reviews.llvm.org/D43159 Files: include/__locale include/__sso_allocator include/__string include/__threading_support include/algorithm include/bitset include

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Ping. Now this is a pure API extension to current implicit/direct roles. Is it possible to see this landed before clang+llvm 6 is released? Repository: rC Clang https://reviews.llvm.org/D42895 ___ cfe-commits mailing lis

r324828 - [X86] Change the signature of the AVX512 packed fp compare intrinsics to return vXi1 mask. Make bitcasts to scalar explicit in IR

Author: ctopper Date: Sat Feb 10 15:34:27 2018 New Revision: 324828 URL: http://llvm.org/viewvc/llvm-project?rev=324828&view=rev Log: [X86] Change the signature of the AVX512 packed fp compare intrinsics to return vXi1 mask. Make bitcasts to scalar explicit in IR Summary: This is the clang equiv

[PATCH] D43166: Add default C++ ABI libname and include paths for FreeBSD

dim created this revision. dim added reviewers: emaste, EricWF, mclow.lists. Herald added subscribers: krytarowski, mgorny. As noted in a discussion about testing the LLVM 6.0.0 release candidates (with libc++) for FreeBSD, many tests turned out to fail with "exception_ptr not yet implemented". T

[PATCH] D43164: Fix test clang-diff-json.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC324824: Fix test clang-diff-json.cpp (authored by asmith, committed by ). Repository: rC Clang https://reviews.llvm.or

Re: [PATCH] D43164: Fix test from failing when the python path has spaces

Lgtm On Sat, Feb 10, 2018 at 12:16 PM Aaron Smith via Phabricator < revi...@reviews.llvm.org> wrote: > asmith created this revision. > asmith added reviewers: zturner, llvm-commits. > Herald added subscribers: cfe-commits, klimek. > > This test would fail if the python path had spaces. Add a quote

[PATCH] D43164: Fix test from failing when the python path has spaces

asmith created this revision. asmith added reviewers: zturner, llvm-commits. Herald added subscribers: cfe-commits, klimek. This test would fail if the python path had spaces. Add a quote around the path to fix this problem and update some test values changed by the addition of quotes around the

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, rtrieu, aaron.ballman. lebedev.ri added a project: clang. Let's suppose the `-Weverything` is passed. Given code like void F() {} ; If the code is compiled with `-std=c++03`, it would diagnose that extra sema: :2:1: wa

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

compnerd closed this revision. compnerd added a comment. SVN r324701 Repository: rC Clang https://reviews.llvm.org/D42614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324818 - Add vector add/sub/mul/div by scalar tests (PR27085)

Author: rksimon Date: Sat Feb 10 09:55:23 2018 New Revision: 324818 URL: http://llvm.org/viewvc/llvm-project?rev=324818&view=rev Log: Add vector add/sub/mul/div by scalar tests (PR27085) Ensure the scalar is correctly splatted to all lanes Added: cfe/trunk/test/CodeGen/vector-scalar.c Added

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

martong added a comment. Just ignore my previous comments, the issue with explicit instantiations could be fixed in a separate independent patch. All is good. Repository: rC Clang https://reviews.llvm.org/D43012 ___ cfe-commits mailing list cfe-

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2858 + + // Templated declarations should never appear in the enclosing DeclContext. + if (!D->getDescribedVarTemplate()) In case of class templates, the explicit instantiation is the member of

[PATCH] D42530: Clang permits assignment to vector/extvector elements in a const method

RKSimon added a comment. @avt77 Close this now that https://reviews.llvm.org/rL324721 has landed? https://reviews.llvm.org/D42530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43159: Modernize: Use nullptr more.

brucem created this revision. brucem added reviewers: mclow.lists, EricWF. Repository: rCXX libc++ https://reviews.llvm.org/D43159 Files: include/__locale include/__string include/__threading_support include/algorithm include/bitset include/chrono include/fstream include/functi

r324809 - Make a build bot happy.

Author: xazax Date: Sat Feb 10 06:26:53 2018 New Revision: 324809 URL: http://llvm.org/viewvc/llvm-project?rev=324809&view=rev Log: Make a build bot happy. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/lib/FrontendTool/ExecuteCompilerInvocation.cpp Modified: cfe/trunk/li

r324808 - [Templight] Template Instantiation Observer

Author: xazax Date: Sat Feb 10 06:04:45 2018 New Revision: 324808 URL: http://llvm.org/viewvc/llvm-project?rev=324808&view=rev Log: [Templight] Template Instantiation Observer This patch adds a base-class called TemplateInstantiationObserver which gets notified whenever a template instantiation i

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

This revision was automatically updated to reflect the committed changes. Closed by commit rL324808: [Templight] Template Instantiation Observer (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5767?vs=133614&id=1337

[PATCH] Fix linker errors caused bv passing "-Og" to gold plugin

[Driver] Pass -O0 to gold plugin when -Og is specified on the command-line The gold plugin understands -O0..-O3, so when -Og is passed to it, the link fails with: > /bin/ld.gold: fatal error: Optimization level must be between 0 and 3 > > clang-5.0: error: linker command failed with exit code 1 (

[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

aguinet updated this revision to Diff 133745. aguinet added a comment. Herald added a subscriber: krytarowski. Test case added! https://reviews.llvm.org/D42351 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-cc.c Index: test/CodeGen/debug-info-cc.c ==