Author: gbiv
Date: Mon Mar 5 23:45:11 2018
New Revision: 326767
URL: http://llvm.org/viewvc/llvm-project?rev=326767&view=rev
Log:
Fix an unused variable warning; NFC
Modified:
cfe/trunk/lib/Analysis/CFG.cpp
Modified: cfe/trunk/lib/Analysis/CFG.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
Author: gbiv
Date: Mon Mar 5 23:42:36 2018
New Revision: 326766
URL: http://llvm.org/viewvc/llvm-project?rev=326766&view=rev
Log:
[ExprConstant] Look through ExprWithCleanups for `allocsize`
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test/CodeGenCXX/alloc-size.cpp
Modified:
MaskRay added a comment.
In https://reviews.llvm.org/D42983#1025179, @alexfh wrote:
> A late comment here: should this check start a new "portability" module? This
> seems to be the main focus of the check rather than making code more readable.
SG. Should I rename it?
Repository:
rCTE Clan
NoQ updated this revision to Diff 137120.
NoQ added a comment.
Rebase.
https://reviews.llvm.org/D44131
Files:
lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
test/Analysis/explain-svals.cpp
test/Analysis/temporaries.cpp
Index: test/Analysis/temporaries.cpp
===
NoQ updated this revision to Diff 137119.
NoQ added a comment.
Rebase.
https://reviews.llvm.org/D44129
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
Index: lib/StaticAnalyzer/Core/ExprE
NoQ updated this revision to Diff 137117.
NoQ added a comment.
Fix test comments and make them start from `0` :) Also rebase.
https://reviews.llvm.org/D44124
Files:
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/lifetime-extension.cpp
Index: test/Analysis/lifetime-extension.cpp
==
NoQ updated this revision to Diff 137116.
NoQ added a comment.
Agreed to rename into `CFGCXXRecordTypedCall`. Because, yeah, `int` is a value
as well.
https://reviews.llvm.org/D44120
Files:
include/clang/Analysis/CFG.h
lib/Analysis/CFG.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/Sta
Eugene.Zelenko added inline comments.
Comment at: clang-doc/BitcodeWriter.h:160
+class ClangDocBitcodeWriter {
+ public:
+ ClangDocBitcodeWriter(llvm::BitstreamWriter &Stream,
Looks like Clang-format was applied incorrectly, because this is Google, not
LLVM sty
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
baloghadamsoftware.
Herald added subscribers: cfe-commits, rnkovacs.
If a conservatively evaluated function returns a C++ object by value, it no
longer returns a conjured symbol. Instead it
tstellar added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D42608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar created this revision.
Repository:
rC Clang
https://reviews.llvm.org/D44130
Files:
lib/Driver/ToolChains/Gnu.cpp
Index: lib/Driver/ToolChains/Gnu.cpp
===
--- lib/Driver/ToolChains/Gnu.cpp
+++ lib/Driver/ToolChains/Gnu
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
NoQ added a dependency: D44124: [analyzer] Support destruction and
lifetime-extension of inlined function return values..
Because @george.kar
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:3631
+PassedIndirectly = true;
+ }
+
I feel like this flag should be set by Sema for C++ types that have to be
passed indirectly as well; it can then become the single point of truth for
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/Analysis/lifetime-extension.cpp:301
+ }
+ // 1. Construct the original temporary within make(),
+ // 2. Construct return value of make() (eli
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me. I'm not super happy with the name "CFGValueTypedCall"
since it doesn't make it obvious that is reflects "a function call that
returns a C++ object by value."
Is
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:618
+ StringRef Name = FD->getIdentifier()->getName();
+ int ArgIndex = llvm::StringSwitch(Name)
+ .Case("sprintf", 1)
koldaniel wrot
Author: eugenezelenko
Date: Mon Mar 5 16:47:41 2018
New Revision: 326757
URL: http://llvm.org/viewvc/llvm-project?rev=326757&view=rev
Log:
[StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/StaticAnal
phosek added inline comments.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:369
// Check that LTO is enabled if we need it.
if ((Kinds & NeedsLTO) && !D.isUsingLTO()) {
D.Diag(diag::err_drv_argument_only_allowed_with)
vitalybuka wrote:
> Is this chang
Author: george.karpenkov
Date: Mon Mar 5 16:18:21 2018
New Revision: 326755
URL: http://llvm.org/viewvc/llvm-project?rev=326755&view=rev
Log:
[analyzer] [quickfix] Prevent a crash in NamedDecl::getName()
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/GCDAsyncSemaphoreChecker.cpp
cfe/tru
vitalybuka added inline comments.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:369
// Check that LTO is enabled if we need it.
if ((Kinds & NeedsLTO) && !D.isUsingLTO()) {
D.Diag(diag::err_drv_argument_only_allowed_with)
Is this change needed to avoi
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:316
}
}
break;
george.karpenkov wrote:
> 5 closing braces is a lot. What about moving the entire block under
> `CK_Complete` into a static function?
I'm already on
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:316
}
}
break;
5 closing braces is a lot. What about moving the entire block under
`CK_Complete` into a static function?
Repository:
rC Clang
http
sqlbyme updated this revision to Diff 137104.
sqlbyme added a comment.
I copied what Eric did here:
https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e.
I have tested this on our bots and the fix works fine.
https://reviews.llvm.org/D44103
Files:
test/std/
EricWF added a comment.
I think the correct fix is something like this:
https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e
Repository:
rCXX libc++
https://reviews.llvm.org/D44103
___
cfe-commits mailing list
cf
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a project: clang.
Herald added a subscriber: sanjoy.
Previously, these methods were available for looking up comments:
1. getCommentForDecl: returns a FullComment attached to a decl, or any of its
redecls, or any of its bases.
2.
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
With https://reviews.llvm.org/D44120 we can find the `CXXBindTemporaryExpr` and
`MaterializeTemporaryExpr` that correspond to the temporary o
dlj created this revision.
dlj added a reviewer: rsmith.
dlj added a project: clang.
Herald added a subscriber: sanjoy.
This changes how RawComments are looked up, so that they can be added to the
cache or updated independently of parsing.
Loosely, the comment cache has two conceptually separate
benhamilton added a comment.
> Would it be enough to only add the block type case? With the macro false
> positive, there won't be an open paren after the closing paren, right?
Are you asking to remove the block variable cases? I was concerned those would
no longer be handled correctly if we do
benhamilton updated this revision to Diff 137095.
benhamilton marked 2 inline comments as done.
benhamilton added a comment.
- Fix comments from @djasper and @krasimir.
Repository:
rC Clang
https://reviews.llvm.org/D43906
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.c
NoQ created this revision.
NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin, george.karpenkov,
szepet.
Herald added subscribers: cfe-commits, rnkovacs.
https://reviews.llvm.org/D42672 has added extra context to construction calls
in the CFG so that the users, such as the analyzer, di
benhamilton added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:288
+if (MightBeObjCForRangeLoop) {
+ FormatToken *ForInToken = Left;
djasper wrote:
> There can be only one ObjCForIn token in any for loop, right? If that's the
> c
benhamilton updated this revision to Diff 137093.
benhamilton added a comment.
One more cleanup
Repository:
rC Clang
https://reviews.llvm.org/D43904
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
benhamilton updated this revision to Diff 137092.
benhamilton marked an inline comment as done.
benhamilton added a comment.
- Fix comments from @djasper and @krasimir.
Repository:
rC Clang
https://reviews.llvm.org/D43904
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.c
benhamilton added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:323
+ const FormatToken *parseCpp11Attribute(const FormatToken &Tok,
+ bool NamespaceAllowed) {
krasimir wrote:
> Please inline this into the o
benhamilton updated this revision to Diff 137089.
benhamilton marked 5 inline comments as done.
benhamilton added a comment.
- Fix comments from @krasimir and @djasper.
Repository:
rC Clang
https://reviews.llvm.org/D43902
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.
bsdjhb marked 2 inline comments as done.
bsdjhb added a comment.
This version follows the suggestion I made earlier of treating 32-bit floating
point registers as a "plain" register for O32 rather than a floating-point
register. It seems to work for me though for O32 I've only tested with 32-bi
bsdjhb updated this revision to Diff 137085.
bsdjhb added a comment.
- Add a comment about using a single FP layout for O32.
- Treat 32-bit floating point registers on O32 as plain registers.
Repository:
rUNW libunwind
https://reviews.llvm.org/D41968
Files:
include/__libunwind_config.h
i
vsapsai added a comment.
In https://reviews.llvm.org/D44103#1027664, @vsk wrote:
> Is the test expected to pass with clang-902? If not, then it'd be best to use
> "apple-clang-9" instead of "apple-clang-9.0".
That means that most likely it should be `apple-clang-8` instead of 8.0. But on
the
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326746: [analyzer] AST-matching checker to detect global
central dispatch performance… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https:
EricMarti added a comment.
I cannot commit this patch myself, as I do not have commit access.
https://reviews.llvm.org/D43731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Mon Mar 5 14:03:32 2018
New Revision: 326746
URL: http://llvm.org/viewvc/llvm-project?rev=326746&view=rev
Log:
[analyzer] AST-matching checker to detect global central dispatch performance
anti-pattern
rdar://37312818
NB: The checker does not care about the order
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the fix!
> I not familiar with Objective-C++, can you provide a appropriate test about
> Objective-C++ for me, thank you!
Now that the explicit check and the respective code pat
aaron.ballman added reviewers: echristo, rsmith.
aaron.ballman added a comment.
Adding some reviewers.
One thing that's missing from this patch are test cases that demonstrate both
the semantic checking (builtin accepts proper args, rejects improper ones, etc)
and output.
Co
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Making `CStringChecker` smaller is an accomplishment on its own :)
Repository:
rC Clang
https://reviews.llvm.org/D44075
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326744: [msvc] Allow MSVC toolchain driver to find the
aarch64 / arm64 cross-compiler. (authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D44087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: rnk
Date: Mon Mar 5 13:36:23 2018
New Revision: 326744
URL: http://llvm.org/viewvc/llvm-project?rev=326744&view=rev
Log:
[msvc] Allow MSVC toolchain driver to find the aarch64 / arm64 cross-compiler.
Starting with the Fall Creators Update, Windows 10 Desktop can run on
machines that are
Quuxplusone added a comment.
@rtrieu (and perhaps @rsmith) ping?
The action items I need help with are:
- Review and land the refactoring patch https://reviews.llvm.org/D43898 (I
don't have commit privs)
- Ideally, test compiling a bunch of (e.g. Google) code with
https://reviews.llvm.org/D433
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Thank you!
https://reviews.llvm.org/D43731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: rsmith
Date: Mon Mar 5 12:54:34 2018
New Revision: 326741
URL: http://llvm.org/viewvc/llvm-project?rev=326741&view=rev
Log:
Fix typo in comment.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/li
vsk added a comment.
Is the test expected to pass with clang-902? If not, then it'd be best to use
"apple-clang-9" instead of "apple-clang-9.0".
Repository:
rCXX libc++
https://reviews.llvm.org/D44103
___
cfe-commits mailing list
cfe-commits@lis
sqlbyme created this revision.
sqlbyme added reviewers: EricWF, dexonsmith.
Herald added a subscriber: cfe-commits.
I am in the process of upgrading the Green Dragon bots and this test fails
because we have not yet included apple-clang-9.0 in the UNSUPPORTED line of
this test. This patch addres
tbourvon added a comment.
@alexfh What is your opinion regarding adding this dependency?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Quuxplusone added inline comments.
Comment at: test/std/numerics/rand/rand.device/lit.local.cfg:1
+# Disable all of the random device tests if the correct feature is not
available.
+if 'libcpp-has-no-random-device' in config.available_features:
EricWF wrote:
> T
djasper added a comment.
Would it be enough to only add the block type case? With the macro false
positive, there won't be an open paren after the closing paren, right?
Comment at: lib/Format/TokenAnnotator.cpp:155
+ Next->startsSequence(tok::identifier, tok::l_squar
krasimir added inline comments.
Comment at: unittests/Format/FormatTest.cpp:12027
+TEST_F(FormatTest, GuessLanguageWithCaret) {
+ EXPECT_EQ(FormatStyle::LK_Cpp, guessLanguage("foo.h", "FOO(^);"));
Please also add formatting tests. This might require changes to
krasimir added inline comments.
Comment at: unittests/Format/FormatTest.cpp:12002
+TEST_F(FormatTest, GuessLanguageWithForIn) {
+ EXPECT_EQ(FormatStyle::LK_Cpp,
Please also add this instances as formatting tests.
Repository:
rC Clang
https://reviews.llvm.
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:288
+if (MightBeObjCForRangeLoop) {
+ FormatToken *ForInToken = Left;
There can be only one ObjCForIn token in any for loop, right? If that's the
case, can we just rememb
weimingz added a comment.
gentle ping?
https://reviews.llvm.org/D41316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:323
+ const FormatToken *parseCpp11Attribute(const FormatToken &Tok,
+ bool NamespaceAllowed) {
Please inline this into the other function: it's u
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:352
+ return false;
+if (!Tok.startsSequence(tok::l_square, tok::l_square))
+ return false;
Just join this if with the previous one.
Comment at: lib/Format/T
benhamilton added a comment.
I filed rdar://38143508 to track this.
The fix won't be easy; I think `__attribute__((format_arg(X)))` isn't enough to
capture how `-[NSBundle localizedStringForKey:value:table:]` works:
1. `__attribute__((format_arg(X)))` doesn't support multiple format arguments,
yaxunl added a comment.
ping
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin created this revision.
a.sidorin added reviewers: xazax.hun, szepet, jingham.
Herald added subscribers: martong, rnkovacs.
- There are multiple reasons why field structures can be imported in wrong way.
The simplest is the ability of field initializers and method bodies to refer
fields
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326725: [AMDGPU] Clean up old address space mapping and fix
constant address space value (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
Author: yaxunl
Date: Mon Mar 5 09:50:10 2018
New Revision: 326725
URL: http://llvm.org/viewvc/llvm-project?rev=326725&view=rev
Log:
[AMDGPU] Clean up old address space mapping and fix constant address space value
Differential Revision: https://reviews.llvm.org/D43911
Modified:
cfe/trunk/lib
Might be useful in the future to use a more specific commit message such as
"add missing override" (or "add missing override to address
-Wmissing-override warning"), etc.
On Wed, Feb 28, 2018 at 6:03 AM Gabor Horvath via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: xazax
> Date: Wed
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE326721: [clangd] Fix unintentionally loose fuzzy matching,
and the tests masking it. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44003?vs=136719&id=13702
Author: sammccall
Date: Mon Mar 5 09:34:33 2018
New Revision: 326721
URL: http://llvm.org/viewvc/llvm-project?rev=326721&view=rev
Log:
[clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.
Summary:
The intent was that [ar] doesn't match "FooBar"; the first character must m
yaxunl added a comment.
Will make recommended changes when committing.
https://reviews.llvm.org/D43911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326719: [clangd] Extract ClangdServer::Options struct.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44088
Files:
cla
Author: sammccall
Date: Mon Mar 5 09:28:54 2018
New Revision: 326719
URL: http://llvm.org/viewvc/llvm-project?rev=326719&view=rev
Log:
[clangd] Extract ClangdServer::Options struct.
Summary:
This subsumes most of the params to ClangdServer and ClangdLSPServer.
Adjacent changes:
- tests use a co
benhamilton added a comment.
> That does look like a bug in the SDK, to me.
OK. I'll file a Radar bug upstream; in the meantime, this means since this
diff landed in 2016, clang has been raising `-Wformat-extra-args` when
compiling any code which passes the result of `-[NSBundle
localizedStri
benhamilton added a comment.
Thanks very much for the code review. I fixed those issues.
Comment at: lib/Format/TokenAnnotator.cpp:323
+ const FormatToken *parseCpp11Attribute(const FormatToken *Tok,
+ bool NamespaceAllowed) {
benhamilton updated this revision to Diff 137015.
benhamilton marked 7 inline comments as done.
benhamilton added a comment.
Fixes from @jolesiak
Repository:
rC Clang
https://reviews.llvm.org/D43902
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTe
jolesiak requested changes to this revision.
jolesiak added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Format/TokenAnnotator.cpp:323
+ const FormatToken *parseCpp11Attribute(const FormatToken *Tok,
+
aaron.ballman added a comment.
In https://reviews.llvm.org/D25820#1027216, @benhamilton wrote:
> Actually, looking more deeply, it's possible this is a bug in the Apple SDK:
>
> @interface NSBundle
> - (NSString *)localizedStringForKey:(NSString *)key value:(nullable
> NSString *)value table
Hahnfeld added a comment.
In https://reviews.llvm.org/D43197#1027139, @gtbercea wrote:
> In https://reviews.llvm.org/D43197#1011256, @Hahnfeld wrote:
>
> > Looking more closely at the patch, this doesn't seem to look into the `lib`
> > / `lib64` next to the compiler. I'm not sure if `LIBRARY_PAT
ahatanak created this revision.
ahatanak added reviewers: rjmccall, doug.gregor, rsmith.
This patch makes changes that are needed to allow `__weak` fields in C structs
when ARC is enabled.
Repository:
rC Clang
https://reviews.llvm.org/D44095
Files:
include/clang/AST/Decl.h
include/clang
benhamilton added a comment.
Actually, looking more deeply, it's possible this is a bug in the Apple SDK:
@interface NSBundle
- (NSString *)localizedStringForKey:(NSString *)key value:(nullable NSString
*)value table:(nullable NSString *)tableName __attribute__((format_arg(1)));
@end
Sinc
niko marked an inline comment as done.
niko added inline comments.
Comment at: clang-tidy/absl/StringFindStartswithCheck.cpp:81
+ auto include_hint = include_inserter_->CreateIncludeInsertion(
+ source.getFileID(expr->getLocStart()),
"third_party/absl/strings/match.h",
+
niko updated this revision to Diff 137008.
niko marked 11 inline comments as done.
niko added a comment.
Addressed reviewer comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43847
Files:
clang-tidy/CMakeLists.txt
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/ab
benhamilton added a comment.
Herald added subscribers: llvm-commits, jkorous-apple.
This caused a regression where `__attribute__((format_arg(X))` no longer works
with ObjC message sends.
I filed https://bugs.llvm.org/show_bug.cgi?id=36599 and will write a fix.
Repository:
rL LLVM
https://r
martong added a comment.
Hi Aleksei,
I agree that there are some overlapping functionalities in the patches.
As far as I see both make it possible to write tests which import from multiple
contexts and I think that is the only redundant part. So, I agree, for now we
could use both approaches si
paulsemel created this revision.
paulsemel added a reviewer: aaron.ballman.
The purpose of this new builtin is to be able to pretty print any structure at
runtime.
This might be really useful when debugging is not an option or is fastidious
(like for kernel development).
Repository:
rC Clang
hokein added a comment.
In https://reviews.llvm.org/D43847#1025846, @Eugene.Zelenko wrote:
> In https://reviews.llvm.org/D43847#1025833, @niko wrote:
>
> > Thanks everyone for your comments! I renamed the namespace and filenames to
> > 'abseil'.
> >
> > @Eugene.Zelenko, definitely interested in
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326709: [analyzer] Improves the logic of GenericTaintChecker
identifying stdin. (authored by henrywong, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D39159
Files:
lib/StaticAnalyzer
Author: henrywong
Date: Mon Mar 5 07:41:15 2018
New Revision: 326709
URL: http://llvm.org/viewvc/llvm-project?rev=326709&view=rev
Log:
[analyzer] Improves the logic of GenericTaintChecker identifying stdin.
Summary:
GenericTaintChecker can't recognize stdin in some cases. The reason is that `if
gtbercea added a comment.
In https://reviews.llvm.org/D43197#1011256, @Hahnfeld wrote:
> Looking more closely at the patch, this doesn't seem to look into the `lib` /
> `lib64` next to the compiler. I'm not sure if `LIBRARY_PATH` is set for every
> installation, so I think we should add this on
Typz added a comment.
ping?
Repository:
rC Clang
https://reviews.llvm.org/D43290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall updated this revision to Diff 136991.
sammccall marked 3 inline comments as done.
sammccall added a comment.
address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44088
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServ
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:94
+ /// Returns a statically allocated instance. (Stateless, safe to share).
+ static RealFileSystemProvider *get();
+
Maybe return a reference instead of a pointer?
Comm
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (
koldaniel added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:618
+ StringRef Name = FD->getIdentifier()->getName();
+ int ArgIndex = llvm::StringSwitch(Name)
+ .Case("sprintf", 1)
george.karpenkov wrot
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.
This subsumes most of the params to ClangdServer and ClangdLSPServer.
Adjacent changes:
- tests use a consistent set of options, except when testing sp
alexfh added inline comments.
Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54
+ } else if (const auto *const Call =
+ Result.Nodes.getNodeAs("ptr_fun_call")) {
+diag(Call->getLocStart(), Message) << "'std::ptr_fun'";
+ } else if (const a
arm-chrjan01 created this revision.
arm-chrjan01 added reviewers: zturner, rnk.
Herald added subscribers: cfe-commits, kristof.beyls, rengolin.
arm-chrjan01 added a comment.
I don't have commit access. Please commit after approval.
Starting with the Fall Creators Update, Windows 10 Desktop can r
arm-chrjan01 added a comment.
I don't have commit access. Please commit after approval.
Repository:
rC Clang
https://reviews.llvm.org/D44087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
1 - 100 of 108 matches
Mail list logo
