[PATCH] D44189: [RISCV] Verify the input value of -march=

2018-03-06 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. This patch doing more check and verify the -march= string and will issue and error if it's a invalid

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In https://reviews.llvm.org/D43805#1029479, @pcc wrote: > > If the backend will be changed so that it will not depend on IR type names > > Are you referring to https://reviews.llvm.org/D43199? If so it seems to me > that this should be a cc1 flag that defaults to

r326873 - Remove a placeholder

2018-03-06 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Mar 6 21:02:27 2018 New Revision: 326873 URL: http://llvm.org/viewvc/llvm-project?rev=326873=rev Log: Remove a placeholder ...Running tests in the wrong directory will often make them seem to pass. Oops. :) Modified: cfe/trunk/test/CodeGenCXX/alloc-size.cpp

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. > If the backend will be changed so that it will not depend on IR type names Are you referring to https://reviews.llvm.org/D43199? If so it seems to me that this should be a cc1 flag that defaults to whether `-flto=thin` is passed. In any case it seems like a bad idea to

Re: r326766 - [ExprConstant] Look through ExprWithCleanups for `allocsize`

2018-03-06 Thread George Burgess IV via cfe-commits
Relanded in r326872. Thanks! On Tue, Mar 6, 2018 at 7:03 PM, Nico Weber wrote: > Apologies, I had to revert the change that touched alloc-size.cpp before > this change in r326862. After that revert, your new test here failed, and > since I didn't understand how to make it

r326872 - Reland r326766 (with a slightly modified test)

2018-03-06 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Mar 6 20:52:34 2018 New Revision: 326872 URL: http://llvm.org/viewvc/llvm-project?rev=326872=rev Log: Reland r326766 (with a slightly modified test) The original revert was done in r326869, since reverting r326602 broke the test added by this. The new test should be less

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

2018-03-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I'm sorry, I did a review of your patch on Phabricator but apparently never submitted it. Comment at: lib/CodeGen/CGCall.h:219 + RValue RV; + LValue LV; /// The l-value from which the argument is derived. +}; This could

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

2018-03-06 Thread Nico Weber via cfe-commits
Thanks for the quick fix! On Tue, Mar 6, 2018 at 11:32 PM, Erik Pilkington wrote: > No, that was a mistake, fixed in r326871. Thanks for pointing this out! > Erik > > > On 2018-03-06 11:10 PM, Nico Weber wrote: > > Hi Erik, > > before this change,

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: include/clang/Driver/Options.td:644 + HelpText<"Whether to use IR type names (option: auto, none, use)">, + Values<"auto,none,use">; + rsmith wrote: > Having "none" and "use" as values for the same option seems like

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

2018-03-06 Thread Erik Pilkington via cfe-commits
No, that was a mistake, fixed in r326871. Thanks for pointing this out! Erik On 2018-03-06 11:10 PM, Nico Weber wrote: Hi Erik, before this change, ___Z10blocksNRVOv_block_invoke demangled to 'invocation function for block in blocksNRVO()', now it's no longer demangled. Was that an

[libcxxabi] r326871 - [demangler] Fix a mistake in r326797.

2018-03-06 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Mar 6 20:29:33 2018 New Revision: 326871 URL: http://llvm.org/viewvc/llvm-project?rev=326871=rev Log: [demangler] Fix a mistake in r326797. Thanks to Nico Weber for pointing this out! Modified: libcxxabi/trunk/src/cxa_demangle.cpp

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked an inline comment as done. sepavloff added a comment. In https://reviews.llvm.org/D43805#1029455, @pcc wrote: > Why is this a driver flag? This seems like it ought to be a cc1-only flag to > me. Yous are right, this is more like development option. But having the driver flag

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/Driver/Options.td:644 + HelpText<"Whether to use IR type names (option: auto, none, use)">, + Values<"auto,none,use">; + Having "none" and "use" as values for the same option seems like a category error.

[PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Why is this a driver flag? This seems like it ought to be a cc1-only flag to me. Repository: rC Clang https://reviews.llvm.org/D43805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D43805: Optionally use nameless IR types

2018-03-06 Thread Serge Pavlov via cfe-commits
Any feedback? Thanks, --Serge 2018-02-28 0:02 GMT+07:00 Serge Pavlov via Phabricator < revi...@reviews.llvm.org>: > sepavloff marked an inline comment as done. > sepavloff added inline comments. > > > > Comment at: include/clang/Driver/Options.td:1735 > + HelpText<"Whether to

Re: [libcxxabi] r326797 - [demangler] Modernize the rest of the demangler.

2018-03-06 Thread Nico Weber via cfe-commits
Hi Erik, before this change, ___Z10blocksNRVOv_block_invoke demangled to 'invocation function for block in blocksNRVO()', now it's no longer demangled. Was that an intentional change? On Tue, Mar 6, 2018 at 9:21 AM, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author:

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton updated this revision to Diff 137320. benhamilton added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added a comment. > Right. So the difference is that for blocks, there is always a "(" after the > "(^.)". That should be easy to parse, no? Yep, I've updated this diff to implement that as you recommended. I just had to handle nested parens (I couldn't find an existing way to

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton updated this revision to Diff 137319. benhamilton added a comment. - Simplify logic and assume we have an ObjC block whenever we see rparen at the end of `(^...)(`. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp

Re: r326766 - [ExprConstant] Look through ExprWithCleanups for `allocsize`

2018-03-06 Thread Nico Weber via cfe-commits
Apologies, I had to revert the change that touched alloc-size.cpp before this change in r326862. After that revert, your new test here failed, and since I didn't understand how to make it passed, I reverted your change in 326869 too. It should hopefully be easy for you to reland it. On Tue, Mar

r326869 - Revert 326766 too, after r326862 the test fails and I don't know how to fix.

2018-03-06 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Mar 6 19:00:25 2018 New Revision: 326869 URL: http://llvm.org/viewvc/llvm-project?rev=326869=rev Log: Revert 326766 too, after r326862 the test fails and I don't know how to fix. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/test/CodeGenCXX/alloc-size.cpp

[PATCH] D44170: [analyzer] Update GCDAsyncSemaphoreChecker to match messages send to ObjC objects

2018-03-06 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326868: [analyzer] Fix the checker for the performance anti-pattern to accept messages (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r326868 - [analyzer] Fix the checker for the performance anti-pattern to accept messages

2018-03-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Mar 6 18:54:01 2018 New Revision: 326868 URL: http://llvm.org/viewvc/llvm-project?rev=326868=rev Log: [analyzer] Fix the checker for the performance anti-pattern to accept messages send to ObjC objects. Differential Revision: https://reviews.llvm.org/D44170

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

2018-03-06 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326867: [Driver] Enable SafeStack by default on Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44065?vs=137312=137314#toc Repository: rC Clang

r326867 - [Driver] Enable SafeStack by default on Fuchsia

2018-03-06 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Mar 6 18:49:58 2018 New Revision: 326867 URL: http://llvm.org/viewvc/llvm-project?rev=326867=rev Log: [Driver] Enable SafeStack by default on Fuchsia This is already used throughout the entire system, so make it a default. Differential Revision:

[PATCH] D44065: [Driver] Enable SafeStack by default on Fuchsia

2018-03-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 137312. Repository: rC Clang https://reviews.llvm.org/D44065 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Fuchsia.h clang/test/Driver/fuchsia.c Index: clang/test/Driver/fuchsia.c

[PATCH] D44169: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

2018-03-06 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326865: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44169: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

2018-03-06 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326865: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r326865 - [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr

2018-03-06 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Tue Mar 6 18:32:44 2018 New Revision: 326865 URL: http://llvm.org/viewvc/llvm-project?rev=326865=rev Log: [ASTMatcher] Extend hasAnyArgument to ObjCMessageExpr Currently hasArgument works with both ObjC messages and function calls, but not hasAnyArgument. This

Re: r326860 - [Driver] Automatically disable incompatible default sanitizers

2018-03-06 Thread Nico Weber via cfe-commits
Test? (Also below) On Tue, Mar 6, 2018 at 8:27 PM, Petr Hosek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: phosek > Date: Tue Mar 6 17:27:03 2018 > New Revision: 326860 > > URL: http://llvm.org/viewvc/llvm-project?rev=326860=rev > Log: > [Driver] Automatically disable

r326862 - Revert r326602, it caused PR36620.

2018-03-06 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Mar 6 18:22:41 2018 New Revision: 326862 URL: http://llvm.org/viewvc/llvm-project?rev=326862=rev Log: Revert r326602, it caused PR36620. Removed: cfe/trunk/test/Sema/attr-ownership.cpp Modified: cfe/trunk/include/clang/AST/Attr.h

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

2018-03-06 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44064: [Driver] Automatically disable incompatible default sanitizers

2018-03-06 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326860: [Driver] Automatically disable incompatible default sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44064?vs=136893=137301#toc Repository:

r326860 - [Driver] Automatically disable incompatible default sanitizers

2018-03-06 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Mar 6 17:27:03 2018 New Revision: 326860 URL: http://llvm.org/viewvc/llvm-project?rev=326860=rev Log: [Driver] Automatically disable incompatible default sanitizers When a sanitizer incompatible with one of the default sanitizers is explicitly enabled, automatically

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

2018-03-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1795 CXXRecordDecl *Canon = D->getCanonicalDecl(); - if (Canon->DefinitionData) { + if (Canon->DefinitionData && Canon->DefinitionData != DD) { MergeDefinitionData(Canon,

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

2018-03-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 137299. vsapsai added a comment. - Don't set to-be-deserialized definition data if there is another decl with definition data. https://reviews.llvm.org/D43494 Files: clang/lib/Serialization/ASTReaderDecl.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New module `portability` and new `portability-simd-intrinsics + `_ check Module and check from it

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137293. MaskRay marked 2 inline comments as done. MaskRay added a comment. Mention new module `portability` in docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

2018-03-06 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm provided the bots are happy. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Please mention new module in Release Notes. I think new modules should be before new checks there. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 ___ cfe-commits mailing list

r326856 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2018-03-06 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Tue Mar 6 16:17:48 2018 New Revision: 326856 URL: http://llvm.org/viewvc/llvm-project?rev=326856=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

2018-03-06 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: test/Driver/fsanitize.c:392 +// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 | FileCheck --check-prefix=CHECK_UBSAN-OPENBSD +// CHECK-UBSAN-OPENBSD: -fsanitize=undefined + vsk wrote: > Why does

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

2018-03-06 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 137284. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,12 @@ //

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

2018-03-06 Thread Vedant Kumar via Phabricator via cfe-commits
vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: test/Driver/fsanitize.c:392 +// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 | FileCheck --check-prefix=CHECK_UBSAN-OPENBSD +//

r326845 - Fix a typo from r326844; NFC

2018-03-06 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Mar 6 15:09:01 2018 New Revision: 326845 URL: http://llvm.org/viewvc/llvm-project?rev=326845=rev Log: Fix a typo from r326844; NFC Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c Modified: cfe/trunk/test/CodeGen/64bit-swiftcall.c URL:

r326844 - [CodeGen] Don't emit lifetime.end without lifetime.start

2018-03-06 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Mar 6 15:07:00 2018 New Revision: 326844 URL: http://llvm.org/viewvc/llvm-project?rev=326844=rev Log: [CodeGen] Don't emit lifetime.end without lifetime.start EmitLifetimeStart returns a non-null `size` pointer if it actually emits a lifetime.start. Later in this

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

2018-03-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 137279. yaxunl added a comment. Clean up CallArg::getRValue() so that it always return independent value. https://reviews.llvm.org/D34367 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGCall.h lib/CodeGen/CGClass.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternative, otherwise point it out it

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137275. MaskRay added a comment. std::string -> llvm::SmallString Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. I should have seen in during the initial review, but better now than never, right? :) Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

2018-03-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Ping again? Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43667: [clang-doc] Implement a YAML generator

2018-03-06 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 137272. juliehockett marked 6 inline comments as done. juliehockett added a comment. Updating based on parent changes https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Representation.h clang-doc/generators/CMakeLists.txt

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

2018-03-06 Thread Yan Zhang via Phabricator via cfe-commits
Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44174 Files: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp clang-tidy/objc/AvoidNSErrorInitCheck.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137262. MaskRay added a comment. . Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137260. MaskRay added a comment. comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137259. MaskRay added a comment. index.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Right. So the difference is that for blocks, there is always a "(" after the "(^.)". That should be easy to parse, no? Repository: rC Clang https://reviews.llvm.org/D43906 ___ cfe-commits mailing list

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

2018-03-06 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r326836 - [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

2018-03-06 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Tue Mar 6 13:26:28 2018 New Revision: 326836 URL: http://llvm.org/viewvc/llvm-project?rev=326836=rev Log: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C and CLANG_DEFAULT_STD_CXX -- that can be

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In https://reviews.llvm.org/D42983#1028241, @alexfh wrote: > In https://reviews.llvm.org/D42983#1028093, @MaskRay wrote: > > > In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > > > > > A late comment here: should this check start a new "portability" module? >

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2018-03-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Sorry, this patch is not ready yet. There are several regression tests that are failing because of the assert in setIsUnique. https://reviews.llvm.org/D39562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 137256. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2018-03-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/AST/Expr.h:875 + /// is set to true. + bool IsUnique = false; + rjmccall wrote: > Humor me and pack this in the bitfields in Stmt, please. :) Thanks! Comment at:

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

2018-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2018-03-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: lib/Sema/SemaPseudoObject.cpp:432 + if (capturedRHS->getType()->getAsCXXRecordDecl() && capturedRHS->isRValue()) +capturedRHS->setIsUnique(); + rjmccall wrote: > I think you can unconditionally set this here,

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

2018-03-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 137250. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D39562 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-06 Thread Niko Weh via Phabricator via cfe-commits
niko added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:15 + +#include + hokein wrote: > What is this header used for? Sorry, ended up in the wrong file, moved to StringFindStartswithCheck.cpp. Repository: rCTE Clang Tools Extra

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-06 Thread Niko Weh via Phabricator via cfe-commits
niko updated this revision to Diff 137249. niko marked 4 inline comments as done. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 Files: clang-tidy/CMakeLists.txt clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

2018-03-06 Thread Jeremy Demeule via Phabricator via cfe-commits
jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( alexfh wrote: > I wonder whether it's better to use lit for the tests that require formatting >

[PATCH] D41102: Setup clang-doc frontend framework

2018-03-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Nice! Some further notes based on the SHA1 nature. Comment at: clang-doc/BitcodeWriter.cpp:74 + AbbrevGen(Abbrev, +{// 0. Fixed-size integer (ref type) + llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::Fixed,

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

2018-03-06 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::SmallString<4> , + llvm::StringRef Blob) { lebedev.ri wrote: > I think all these `SmallString` can

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

2018-03-06 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 137245. juliehockett marked 8 inline comments as done. juliehockett added a comment. Adding in support for mapper tests and addressing comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h

[PATCH] D41102: Setup clang-doc frontend framework

2018-03-06 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 137244. juliehockett added a comment. Adding hashing to reduce the size of USRs and updating tests. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren)))

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

2018-03-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1795 CXXRecordDecl *Canon = D->getCanonicalDecl(); - if (Canon->DefinitionData) { + if (Canon->DefinitionData

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

2018-03-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Ping. https://reviews.llvm.org/D43494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

2018-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Yep, looks good. I'd leave renderscript alone. I think it's deprecated. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

2018-03-06 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:155 + Next->startsSequence(tok::identifier, tok::l_square, +tok::numeric_constant, tok::r_square, +tok::r_paren, tok::l_paren))) {

[PATCH] D44143: Create properly seeded random generator check

2018-03-06 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: docs/clang-tidy/checks/cert-properly-seeded-random-generator.rst:26 +std::random_device dev; +std::mt19937 engine3(dev()); // Good + } Seeding MT19937 with a single 32-bit integer is //not// "Good". It

r326827 - [OPENMP] Fix generation of the unique names for task reduction

2018-03-06 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Mar 6 10:59:43 2018 New Revision: 326827 URL: http://llvm.org/viewvc/llvm-project?rev=326827=rev Log: [OPENMP] Fix generation of the unique names for task reduction variables. If the task has reduction construct and this construct for some variable requires unique

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-03-06 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 137233. gtbercea added a comment. - Fix message and test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

r326822 - TableGen: Give up on exact fixits for diagnostic groups

2018-03-06 Thread Nicolai Haehnle via cfe-commits
Author: nha Date: Tue Mar 6 09:55:00 2018 New Revision: 326822 URL: http://llvm.org/viewvc/llvm-project?rev=326822=rev Log: TableGen: Give up on exact fixits for diagnostic groups With recent changes in the TableGen frontend, we no longer have usable location information for anonymous defs.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-03-06 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 137230. gtbercea added a comment. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

2018-03-06 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 137227. mgorny added a comment. @rnk, could you confirm the rebased patch? I'm not sure if I should override `InputKind::RenderScript` as well. https://reviews.llvm.org/D34365 Files: CMakeLists.txt include/clang/Config/config.h.cmake

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

2018-03-06 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Behavior looks good. I think we can do a bit better with (most) fixits - your call on whether it makes sense to do here. As discussed i'd simplify the diagnostic containers until we know there's a strong need. Comment at:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-03-06 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 137226. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

2018-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Let's do this. I thought we'd already have a higher C++ standard version by now, but apparently not. https://reviews.llvm.org/D34365 ___ cfe-commits

[PATCH] D41102: Setup clang-doc frontend framework

2018-03-06 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. In https://reviews.llvm.org/D41102#1028228, @Athosvk wrote: > This seems like quite a decent approach! That being said, I don't see the > pointer yet? I assume you mean that you will be adding this? Additionally, a > slight disadvantage of doing this generic

[libclc] r326821 - lgamma_r: Move code from .inc to .cl file

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:47 2018 New Revision: 326821 URL: http://llvm.org/viewvc/llvm-project?rev=326821=rev Log: lgamma_r: Move code from .inc to .cl file Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Modified:

[libclc] r326820 - frexp: Reuse types provided by gentype.inc

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:45 2018 New Revision: 326820 URL: http://llvm.org/viewvc/llvm-project?rev=326820=rev Log: frexp: Reuse types provided by gentype.inc v2: Use select instead of bitselect to consolidate scalar and vector versions Passes CTS on Carrizo Reviewed-by: Aaron

[libclc] r326819 - select: Add vector implementation

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:43 2018 New Revision: 326819 URL: http://llvm.org/viewvc/llvm-project?rev=326819=rev Log: select: Add vector implementation Passes CTS on Carrizo Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely Added:

[libclc] r326818 - minmag: Condition variable needs to be the same bitwidth as operands

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:40 2018 New Revision: 326818 URL: http://llvm.org/viewvc/llvm-project?rev=326818=rev Log: minmag: Condition variable needs to be the same bitwidth as operands No changes wrt CTS Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely

[libclc] r326817 - maxmag: Condition variable needs to be the same bitwidth as operands

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:38 2018 New Revision: 326817 URL: http://llvm.org/viewvc/llvm-project?rev=326817=rev Log: maxmag: Condition variable needs to be the same bitwidth as operands No changes wrt CTS Reviewed-by: Aaron Watry Signed-off-by: Jan Vesely

[libclc] r326816 - Move cl_khr_fp64 exntension enablement to gentype include lists

2018-03-06 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Mar 6 09:48:35 2018 New Revision: 326816 URL: http://llvm.org/viewvc/llvm-project?rev=326816=rev Log: Move cl_khr_fp64 exntension enablement to gentype include lists This will make adding cl_khr_fp16 support easier Reviewed-by: Aaron Watry

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-03-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:207-208 +def remark_drv_omp_offload_target_missingbcruntime : Warning< + "Expect degraded performance on the target device due to missing '%0' in LIBRARY_PATH.">, + InGroup; def

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

2018-03-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1065-1067 + llvm::Value *FuncPtr; + if (!CGM.getLangOpts().OpenCL) { bader wrote: > I think it would be more readable if we merge this if statement with the if > statement at the line #1103.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

2018-03-06 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 137219. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43904: [clang-format] Improve detection of ObjC for-in statements

2018-03-06 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326815: [clang-format] Improve detection of ObjC for-in statements (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r326815 - [clang-format] Improve detection of ObjC for-in statements

2018-03-06 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Tue Mar 6 09:21:42 2018 New Revision: 326815 URL: http://llvm.org/viewvc/llvm-project?rev=326815=rev Log: [clang-format] Improve detection of ObjC for-in statements Summary: Previously, clang-format would detect the following as an Objective-C for-in statement: for

Re: r326746 - [analyzer] AST-matching checker to detect global central dispatch performance anti-pattern

2018-03-06 Thread George Karpenkov via cfe-commits
Yep, sorry, bad typing skills. > On Mar 6, 2018, at 2:44 AM, Alexander Kornienko wrote: > > On Tue, Mar 6, 2018 at 11:03 AM Alexander Kornienko > wrote: > On Mon, Mar 5, 2018 at 11:05 PM George Karpenkov via cfe-commits >

  1   2   >