[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

rsmith added inline comments. Comment at: include/clang-c/Index.h:2133 * void abssort(float *x, unsigned N) { - * std::sort(x, x + N, + * llvm::sort(x, x + N, * [](float a, float b) { This shouldn't be changed. Comme

[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

mgrang created this revision. mgrang added reviewers: rsmith, rnk, chandlerc. mgrang added a project: clang. Herald added a subscriber: klimek. r327219 added wrappers to std::sort which randomly shuffle the container before sorting. This will help in uncovering non-determinism caused due to undef

r327229 - [CodeGen] Eagerly emit lifetime.end markers for calls

Author: gbiv Date: Sat Mar 10 15:06:31 2018 New Revision: 327229 URL: http://llvm.org/viewvc/llvm-project?rev=327229&view=rev Log: [CodeGen] Eagerly emit lifetime.end markers for calls In C, we'll wait until the end of the scope to clean up aggregate temporaries used for returns from calls. This

Re: [libcxxabi] r327226 - [demangler] Support for structured bindings.

On 2018-03-10 4:40 PM, Richard Smith wrote: On 10 Mar 2018 13:33, "Erik Pilkington via cfe-commits" mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Sat Mar 10 13:31:15 2018 New Revision: 327226 URL: http://llvm.org/viewvc/llvm-project?rev=327226&view=rev

[libcxxabi] r327228 - [demangler] Simplify printing of structured bindings.

Author: epilk Date: Sat Mar 10 14:33:49 2018 New Revision: 327228 URL: http://llvm.org/viewvc/llvm-project?rev=327228&view=rev Log: [demangler] Simplify printing of structured bindings. Thanks to Richard Smith for the post-commit review! Modified: libcxxabi/trunk/src/cxa_demangle.cpp lib

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

mstorsjo added a comment. This change broke building Qt for armv7, see PR36683 for details. https://reviews.llvm.org/D43650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r327226 - [demangler] Support for structured bindings.

On 10 Mar 2018 13:33, "Erik Pilkington via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: epilk Date: Sat Mar 10 13:31:15 2018 New Revision: 327226 URL: http://llvm.org/viewvc/llvm-project?rev=327226&view=rev Log: [demangler] Support for structured bindings. Modified: libcxxabi/tr

[libcxxabi] r327226 - [demangler] Support for structured bindings.

Author: epilk Date: Sat Mar 10 13:31:15 2018 New Revision: 327226 URL: http://llvm.org/viewvc/llvm-project?rev=327226&view=rev Log: [demangler] Support for structured bindings. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified: libcxxabi/

[libcxxabi] r327227 - [demangler] Support for sequence numbers on lifetime extended temporaries.

Author: epilk Date: Sat Mar 10 13:31:22 2018 New Revision: 327227 URL: http://llvm.org/viewvc/llvm-project?rev=327227&view=rev Log: [demangler] Support for sequence numbers on lifetime extended temporaries. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 137921. Quuxplusone added a comment. Rebased on https://reviews.llvm.org/D43898 after addressing @rtrieu's latest comments over there. Repository: rC Clang https://reviews.llvm.org/D43322 Files: include/clang/Basic/DiagnosticGroups.td include/cl

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

Quuxplusone updated this revision to Diff 137920. Quuxplusone marked an inline comment as done. Quuxplusone added a comment. Addressed @rtrieu's comments. @rtrieu, please take another look at this and https://reviews.llvm.org/D43322? Thanks! Repository: rC Clang https://reviews.llvm.org/D43

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

Quuxplusone marked 4 inline comments as done. Quuxplusone added inline comments. Comment at: lib/Sema/SemaStmt.cpp:2970 + FunctionDecl *FD = Step.Function.Function; + if (isa(FD)) { +// C++14 [class.copy]p32: rtrieu wrote: > Use early exit here:

[PATCH] D44143: Create properly seeded random generator check

boga95 updated this revision to Diff 137915. boga95 marked an inline comment as done. boga95 added a comment. Add capability to provide a user-configurable list of disallowed types which will trigger warning. Now it also detects C srand function. Rename check to cert-msc51-cpp. Add cert-msc32-c

Re: r326946 - CodeGen: Fix address space of indirect function argument

> On Mar 9, 2018, at 8:51 PM, Richard Smith wrote: > > Hi, > > This change increases the size of a CallArg, and thus that of a CallArgList, > dramatically (an LValue is *much* larger than an RValue, and unlike an > RValue, does not appear to be at all optimized for size). This results in > Ca

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

malcolm.parsons added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:125 + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's method, not parent's. Did you mean 'BF'? + // CHECK-FIXES: int virt_1() override { return BF:

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137911. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D40381: Parse concept definition

saar.raz added inline comments. Comment at: lib/Parse/ParseTemplate.cpp:383 + + if (!Tok.is(tok::identifier)) { +Diag(Tok.getLocation(), diag::err_expected) << tok::identifier; We could accept 'bool' here to be nice to people coming in from the old Concepts

[PATCH] D44352: [Concepts] Constrained template parameters

saar.raz created this revision. saar.raz added reviewers: nwilson, hubert.reinterpretcast, changyu, rsmith, faisalv, Quuxplusone. Herald added a subscriber: cfe-commits. Added support for constrained template parameters, both simple and with partial template arguments. Depends on https://reviews

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz updated this revision to Diff 137908. saar.raz added a comment. - Correct handling of non-substitutable concept specialization expressions. Repository: rC Clang https://reviews.llvm.org/D41910 Files: include/clang/AST/DeclTemplate.h include/clang/Sema/Sema.h lib/AST/DeclTempla

[PATCH] D41569: Summary:Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 137907. saar.raz added a comment. Fixed crash caused by substitution of pack expansion into non-pack parameters in constraint expressions. Updating D41569: Summary: = Constraint enforcement and diagnostics Repository: rC Clang

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 137906. saar.raz added a comment. - Fixed incorrect checking of atomic constraint types. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor

[PATCH] D40381: Parse concept definition

saar.raz added inline comments. Comment at: lib/Parse/ParseTemplate.cpp:161 // Parse the actual template declaration. - return ParseSingleDeclarationAfterTemplate(Context, - ParsedTemplateInfo(&ParamLists, -

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Hahnfeld added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:150 +/// bitcode library and add it to the LIBRARY_PATH. +// RUN: touch %T/libomptarget-nvptx-sm_60.bc +// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \

[PATCH] D40731: Integrate CHash into CLang

v.g.vassilev added a comment. I am not sure if this is the right time but maybe testing and comparing the behavior of this patch against something such as the ODRHash will help you, me (and probably others) to understand the current patch better. In https://reviews.llvm.org/D41416, I started wo

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev updated this revision to Diff 137902. v.g.vassilev added a comment. Add sanity check. We assert that the ODR hash of the template arguments should be the same as the one for from the actually found template specialization. This way we managed to catch a few collisions in the ODRHas