hubert.reinterpretcast added inline comments.
Comment at: lib/AST/ExprCXX.cpp:1478
+ {
+// We do not want error diagnostics escaping here.
+Sema::SFINAETrap Trap(S);
saar.raz wrote:
> faisalv wrote:
> > Hubert: This needs a TODO: the idea is not to drop
NoQ added inline comments.
Comment at: test/Analysis/cfg-rich-constructors.cpp:481-486
+// CXX11:[B1]
+// CXX11-NEXT: 1: [B4.4].~D() (Implicit destructor)
+// CXX11:[B2]
+// CXX11-NEXT: 1: ~temporary_object_expr_with_dtors::D() (Temporary object
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
In C++17 copy elision is mandatory for variable and return value constructors
(as long as it doesn't involve type conversion) which results
Hello everyone,
Below are some buildbot numbers for the last week of 3/04/2018 - 3/10/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Hello everyone,
Below are some buildbot numbers for the week of 2/25/2018 - 3/03/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-sizeof-expression.cpp:17
+enum E { E_VALUE = 0 };
+
Can you add a C++11 test case using `enum class` -- I am worried that the
`isInteger()` matcher will return false for that type.
Also, I
rjmccall added a comment.
I think we're correct not to warn here and that GCC/ICC are being noisy. The
existence of a temporary promotion to a wider type doesn't justify warning on
arithmetic between two operands that are the same size as the ultimate result.
It is totally fair for users to
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+} else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+}
+ }
+} else {
mstorsjo added a comment.
In https://reviews.llvm.org/D44582#1040643, @efriedma wrote:
> The backend has code to generate SRet returns, which is used when
> TargetLowering::CanLowerReturn returns false. Probably a tiny change to
> X86CallingConv.td to use that codepath on Windows.
Thanks, I
az added a comment.
Was not able to update this particular review with the new code, So I created a
new one in https://reviews.llvm.org/D44591
I manage to reuse the mulx scalar intrinsic work, not exactly calling the fp16
scalar intrinsic itself which is not available here but the same
vsapsai added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217
+} else {
+ FixIts.push_back(FixItHint::CreateInsertion(
+ SelectorLocs[I], SelectorSlotNames[I]));
+}
+ }
+} else {
+
aaron.ballman added a reviewer: rsmith.
aaron.ballman added inline comments.
Comment at: clang/include/clang/Sema/DelayedDiagnostic.h:198-199
+assert(Kind == Availability && "Not an availability diagnostic.");
+return MultiSourceLocation(ArrayRef(
+
pfultz2 marked an inline comment as done.
pfultz2 added a comment.
I have reworded the documentation. Hopefully it is clearer.
https://reviews.llvm.org/D44231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pfultz2 added a comment.
> As this patch can catch some mistakes, I'm fine with checking it in. I agree
> that it is reasonable to write normal code like sizeof(func_call()) (not
> false positive), maybe set the option to false by default?
I have disabled it by default. We can decide later if
pfultz2 updated this revision to Diff 138791.
https://reviews.llvm.org/D44231
Files:
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/clang-tidy/checks/misc-sizeof-expression.rst
test/clang-tidy/misc-sizeof-expression.cpp
Index:
az created this revision.
az added a reviewer: SjoerdMeijer.
Herald added subscribers: kristof.beyls, javed.absar, rengolin.
Add the two missing vmulxh_lane vector intrinsics that were originally left out.
https://reviews.llvm.org/D44591
Files:
clang/include/clang/Basic/arm_neon.td
rnk added a comment.
Should be fixed in https://reviews.llvm.org/rL327754.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Fri Mar 16 15:20:57 2018
New Revision: 327754
URL: http://llvm.org/viewvc/llvm-project?rev=327754=rev
Log:
[MS] Fix bug in r327732 with devirtualized complete destructor calls
Added:
cfe/trunk/test/CodeGenCXX/devirtualize-ms-dtor.cpp
Modified:
vsapsai created this revision.
vsapsai added reviewers: aaron.ballman, erik.pilkington.
Herald added a subscriber: jkorous-apple.
Deprecation replacement can be any text but if it looks like a name of
ObjC method and has the same number of arguments as original method,
replace all slot names so
gtbercea created this revision.
gtbercea added reviewers: ABataev, grokos, carlo.bertolli, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
The data sharing wrapper function needs to pass a valid global thread ID to the
parallel outlined function when the parallel is
efriedma added a comment.
The backend has code to generate SRet returns, which is used when
TargetLowering::CanLowerReturn returns false. Probably a tiny change to
X86CallingConv.td to use that codepath on Windows.
Repository:
rC Clang
https://reviews.llvm.org/D44582
rnk added a comment.
And, this appears to have broken clang's self-host:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/10799
Time to debug.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
Author: eugenezelenko
Date: Fri Mar 16 14:22:42 2018
New Revision: 327746
URL: http://llvm.org/viewvc/llvm-project?rev=327746=rev
Log:
[Analysis] Fix some Clang-tidy modernize and Include What You Use warnings;
other minor fixes (NFC).
Modified:
craig.topper added a comment.
icc seems to match gcc for those last 4 cases i sent. And MSVC is throwing an
odd signed/unsigned mismatch
https://godbolt.org/g/s5FUTv
Repository:
rC Clang
https://reviews.llvm.org/D44559
___
cfe-commits mailing
yaxunl updated this revision to Diff 138768.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Fix the comment.
https://reviews.llvm.org/D44533
Files:
lib/Basic/Targets/AMDGPU.h
lib/CodeGen/CGStmt.cpp
test/CodeGenOpenCL/inline-asm-amdgcn.cl
mstorsjo added a comment.
In https://reviews.llvm.org/D44582#1040578, @efriedma wrote:
> Can we just fix the bug in the backend, rather than trying to hack around it
> in clang?
That'd obviously be ideal - but I don't know how easy that'd be (not familiar
enough with that aspect of LLVM); if
rjmccall added a comment.
The purpose of this analysis is not to compute the theoretical information
content of the computation result. We are conservative about bounds precisely
so that we do not warn in situations like these.
Repository:
rC Clang
https://reviews.llvm.org/D44559
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D44582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
efriedma added a comment.
Can we just fix the bug in the backend, rather than trying to hack around it in
clang?
Repository:
rC Clang
https://reviews.llvm.org/D44582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rnk
Date: Fri Mar 16 13:53:13 2018
New Revision: 327741
URL: http://llvm.org/viewvc/llvm-project?rev=327741=rev
Log:
[MS] Fix tests after r327738 that only fail with a default Windows target
Modified:
cfe/trunk/test/CodeGenCXX/trap-fnattr.cpp
mstorsjo created this revision.
mstorsjo added reviewers: rnk, compnerd.
On x86_64 mingw, long doubles are passed as arguments and returned as if they
were a struct. For normal functions, this calling convention detail is handled
within clang when generating the IR. When a math function is
DHowett-MSFT updated this revision to Diff 138759.
DHowett-MSFT removed a subscriber: lebedev.ri.
DHowett-MSFT added a comment.
Moved files around slightly.
Repository:
rC Clang
https://reviews.llvm.org/D44580
Files:
lib/Sema/SemaExpr.cpp
test/SemaObjC/block-compare.mm
Index:
Author: rnk
Date: Fri Mar 16 13:37:59 2018
New Revision: 327739
URL: http://llvm.org/viewvc/llvm-project?rev=327739=rev
Log:
[MS] Commit some changes that were intended to be part of r327738
Modified:
cfe/trunk/test/CodeGenCXX/regcall.cpp
Modified: cfe/trunk/test/CodeGenCXX/regcall.cpp
URL:
asmith created this revision.
asmith added a reviewer: llvm-commits.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D44581
Files:
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
DHowett-MSFT added a subscriber: lebedev.ri.
DHowett-MSFT added a comment.
In https://reviews.llvm.org/D44580#1040540, @lebedev.ri wrote:
> Why not `test/SemaObjC/block_compare.mm` ?
I wasn't are that it existed. It may even be a good fit for
`test/SemaObjC/block-type-safety.m`, which already
lebedev.ri added a comment.
Why not `test/SemaObjC/block_compare.mm` ?
Repository:
rC Clang
https://reviews.llvm.org/D44580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DHowett-MSFT created this revision.
DHowett-MSFT added reviewers: theraven, rjmccall.
DHowett-MSFT added a project: clang.
Herald added a subscriber: cfe-commits.
This commit makes valid the following code:
// objective-c++
#define nil ((id)nullptr)
...
void (^f)() = ^{};
if (f == nil)
Author: jkorous
Date: Fri Mar 16 13:17:28 2018
New Revision: 327735
URL: http://llvm.org/viewvc/llvm-project?rev=327735=rev
Log:
[Parser] Remove hard-coded bracket depth limit
The diagnostics produced if assert fails are using proper limit from language
definition already.
Modified:
akyrtzi added a comment.
> That would be good. How would one go about asking Clang to generate this
> extra information? Would a Clang Plugin be suitable for this?
That's an interesting idea that we could explore, but I don't have much
experience with that mechanism to comment on.
> Only the
rnk added a comment.
Thanks! I'm sorry I wasn't able to express these ideas better in
https://reviews.llvm.org/D39063.
Repository:
rC Clang
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327732: [MS] Always use base dtors in place of
complete/vbase dtors when possible (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44505?vs=138485=138748#toc
Author: rnk
Date: Fri Mar 16 12:40:50 2018
New Revision: 327732
URL: http://llvm.org/viewvc/llvm-project?rev=327732=rev
Log:
[MS] Always use base dtors in place of complete/vbase dtors when possible
Summary:
Previously we tried too hard to uphold the fiction that destructor
variants work like
jkorous-apple created this revision.
jkorous-apple added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, ioeric, ilya-biryukov.
The current code is casting pointer to a misaligned type which is undefined
behavior.
Found by compiling with Undefined Behavior Sanitizer and
jkorous-apple created this revision.
jkorous-apple added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, ioeric, ilya-biryukov.
Since I was reading this code I decided I might just as well polish it a
little. It is just preliminary commit for a bug-fix.
Repository:
rCTE
aaron.ballman added a comment.
In https://reviews.llvm.org/D44559#1040435, @craig.topper wrote:
> Fair point, what is the default signedness of char?
It's decided by target architecture. ARM and PPC often use unsigned, x86 often
uses signed.
> FWIW, all these warn in gcc. So they seem to be
zahiraam added a comment.
LGTM 2. It fixes PR32990.
https://reviews.llvm.org/D44505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper added a comment.
Fair point, what is the default signedness of char?
FWIW, all these warn in gcc. So they seem to be just checking purely based on
the int promotion without any concern for the original size?
unsigned short foo(unsigned char a) {
return a * a;
}
simark updated this revision to Diff 138743.
simark marked 3 inline comments as done.
simark added a comment.
Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44226
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDispatcher.cpp
aaron.ballman added a comment.
In https://reviews.llvm.org/D44559#1040398, @craig.topper wrote:
> gcc also warns for this
>
> short foo(char a) {
>
> return a * a;
>
> }
>
> Despite the fact that the char would be promoted to int, the upper bits are
> just sign bits and the multiply result
aaron.ballman added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:935
+static llvm::Value *dumpRecord(CodeGenFunction , QualType RType,
+ Value*& RecordPtr, CharUnits Align,
+ Value *Func, int Lvl)
simark updated this revision to Diff 138741.
simark marked an inline comment as done.
simark added a comment.
Address review comments, rebase on latest master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44272
Files:
clangd/ClangdLSPServer.cpp
clangd/DraftStore.cpp
malaperle added a comment.
In https://reviews.llvm.org/D39050#1037796, @akyrtzi wrote:
> Hey Marc,
>
> > The fact that both clang and clangd have to agree on the format so that
> > index-while-building can be used seems to make it inherently not possible
> > to extend
>
> I don't think "not
craig.topper added a comment.
gcc also warns for this
short foo(char a) {
return a * a;
}
Despite the fact that the char would be promoted to int, the upper bits are
just sign bits and the multiply result still fits in a short.
Repository:
rC Clang
https://reviews.llvm.org/D44559
simark marked 3 inline comments as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:101
json::obj{
-{"textDocumentSync", 1},
+{"textDocumentSync", 2},
{"documentFormattingProvider", true},
lebedev.ri added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8541
+ switch (C.getTargetInfo().getTriple().getArch()) {
+ case llvm::Triple::x86:
+ case llvm::Triple::x86_64: {
I agree with @RKSimon, i don't see why this would be
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327727: [analyzer] Fix crashes in RetainCountChecker when
underlying region is not a var (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: george.karpenkov
Date: Fri Mar 16 11:16:47 2018
New Revision: 327727
URL: http://llvm.org/viewvc/llvm-project?rev=327727=rev
Log:
[analyzer] Fix crashes in RetainCountChecker when underlying region is not a var
For other regions, the error message contains a good indication of the
Author: lebedevri
Date: Fri Mar 16 11:01:07 2018
New Revision: 327725
URL: http://llvm.org/viewvc/llvm-project?rev=327725=rev
Log:
[docs] ReleaseNotes: document -Wextra-semi changes.
I should have done it in rL327558 / D43162, but forgot..
I'm not 100% sure about the text, but i don't think
it
arsenm added inline comments.
Comment at: lib/Basic/Targets/AMDGPU.h:288
+ // Constraint parm will be left pointing at the last character of
+ // the constraint. In practice, it won't be changed unless the
parm?
https://reviews.llvm.org/D44533
t.p.northover added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:365
+ /// \brief Determine whether _Float16 is supported on this target.
+ virtual bool hasFloat16Type() const { return HasFloat16; }
t.p.northover wrote:
> SjoerdMeijer wrote:
SjoerdMeijer updated this revision to Diff 138722.
SjoerdMeijer added a comment.
Addressed comments: simplified the logic in GetNeonType.
https://reviews.llvm.org/D44561
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets/AArch64.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327717: [clangd] Handle multiple callbacks from Semas
completion (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44567
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327717: [clangd] Handle multiple callbacks from
Semas completion (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44567?vs=138706=138713#toc
Repository:
Author: ibiryukov
Date: Fri Mar 16 08:23:44 2018
New Revision: 327717
URL: http://llvm.org/viewvc/llvm-project?rev=327717=rev
Log:
[clangd] Handle multiple callbacks from Sema's completion
Summary:
When parser backtracks, we might receive multiple code completion
callbacks.
Previously we had a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327716: [clang-format] Disallow breaks before ]
in text proto extensions (authored by krasimir, committed by ).
Herald
Author: krasimir
Date: Fri Mar 16 08:23:22 2018
New Revision: 327716
URL: http://llvm.org/viewvc/llvm-project?rev=327716=rev
Log:
[clang-format] Disallow breaks before ']' in text proto extensions
Summary: This disallows patterns like `[ext.name\n]` in text protos.
Subscribers: klimek,
dstenb added a comment.
A small caveat with this patch is that it does not fix the case where the input
file as also added as an extra dependency with -fdepfile-entry; however, I
reasoned that it shouldn't really be a problem in practice. I thought that it
was a good trade-off ignoring that
krasimir updated this revision to Diff 138710.
krasimir added a comment.
- Remove newlines
Repository:
rC Clang
https://reviews.llvm.org/D44569
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests/Format/FormatTestTextProto.cpp
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This disallows patterns like `[ext.name\n]` in text protos.
Repository:
rC Clang
https://reviews.llvm.org/D44569
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/TokenAnnotator.cpp
dstenb created this revision.
dstenb added reviewers: rsmith, pcc, krasin.
Herald added a subscriber: cfe-commits.
This commit fixes a bug where passing extra dependency entries
(using -fdepfile-entry) would result in -MP incorrectly emitting
a phony target for the input file, and no phony target
ilya-biryukov updated this revision to Diff 138706.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44567
Files:
clangd/CodeComplete.cpp
Author: simark
Date: Fri Mar 16 07:30:42 2018
New Revision: 327711
URL: http://llvm.org/viewvc/llvm-project?rev=327711=rev
Log:
Move DraftMgr from ClangdServer to ClangdLSPServer
Summary:
This patch moves the draft manager closer to the edge of Clangd, from
ClangdServer to ClangdLSPServer. This
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:454
+if (CCSema) {
+ log(llvm::formatv("ProcessCodeCompleteResults called multiple times."
+
t.p.northover added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:365
+ /// \brief Determine whether _Float16 is supported on this target.
+ virtual bool hasFloat16Type() const { return HasFloat16; }
SjoerdMeijer wrote:
> t.p.northover wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327711: Move DraftMgr from ClangdServer to ClangdLSPServer
(authored by simark, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44408
Files:
ilya-biryukov added a comment.
As a follow-up to an offline discussion: I opted for not excluding results from
'Recovery' contexts, because they are actually somewhat semantically relevant
(i.e. contain only local variables from the current function). One example
where this is useful are
SjoerdMeijer added a comment.
Thanks for the review. Please see a first comment inline.
Comment at: include/clang/Basic/TargetInfo.h:365
+ /// \brief Determine whether _Float16 is supported on this target.
+ virtual bool hasFloat16Type() const { return HasFloat16; }
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
When parser backtracks, we might receive multiple code completion
callbacks.
Previously we had a failing assertion there, now we take first results
and hope
t.p.northover added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:365
+ /// \brief Determine whether _Float16 is supported on this target.
+ virtual bool hasFloat16Type() const { return HasFloat16; }
`_Float16` doesn't seem to be supported
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327708: [clang-format] Fix raw string prefix penalty
(authored by krasimir, committed by ).
Changed prior to commit:
Author: krasimir
Date: Fri Mar 16 07:01:25 2018
New Revision: 327708
URL: http://llvm.org/viewvc/llvm-project?rev=327708=rev
Log:
[clang-format] Fix raw string prefix penalty
Summary: We weren't penalizing cases where the raw string prefix goes over the
column limit.
Subscribers: klimek,
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
We weren't penalizing cases where the raw string prefix goes over the column
limit.
Repository:
rC Clang
https://reviews.llvm.org/D44563
Files:
lib/Format/ContinuationIndenter.cpp
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D44541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: t.p.northover, samparker, olista01.
Herald added subscribers: kristof.beyls, javed.absar.
For generating NEON intrinsics, this determines the NEON data type, and
whether it should be a half type or an i16 type. I.e., we always pass
ioeric added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353
+const FileEntry *Entry = FileAndReplacements.first;
+ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry);
+for (const auto : FileAndReplacements.second)
Author: rsmith
Date: Fri Mar 16 06:36:56 2018
New Revision: 327705
URL: http://llvm.org/viewvc/llvm-project?rev=327705=rev
Log:
Implement C++ DR727, which permits explicit specializations at class scope.
More generally, this permits a template to be specialized in any scope in which
it could be
paulsemel updated this revision to Diff 138687.
paulsemel added a comment.
Added some tests (unit tests for almost every types) and some other tests with
tricky cases.
More tests are coming soon.
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128
+ diag(Member->getQualifierLoc().getSourceRange().getBegin(),
+ "'%0' is a grand-parent's method, not parent's. Did you mean %1?")
+ << CalleeName <<
jdemeule added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353
+const FileEntry *Entry = FileAndReplacements.first;
+ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry);
+for (const auto :
zinovy.nis added inline comments.
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:113
+ int virt_1() override { return A::virt_1(); }
+ // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: qualified function name
A::virt_1 refers to a function not from a direct base
aaron.ballman added inline comments.
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:113
+ int virt_1() override { return A::virt_1(); }
+ // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: qualified function name
A::virt_1 refers to a function not from a direct base
zinovy.nis added inline comments.
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:105
+
+// Test virtual method is diagnosted although not overridden in parent.
+class BI : public A {
aaron.ballman wrote:
> Typo: diagnosted -> diagnosed
oops,
aaron.ballman added inline comments.
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:105
+
+// Test virtual method is diagnosted although not overridden in parent.
+class BI : public A {
Typo: diagnosted -> diagnosed
Comment at:
aaron.ballman added a comment.
In https://reviews.llvm.org/D44231#1039888, @hokein wrote:
> As this patch can catch some mistakes, I'm fine with checking it in. I agree
> that it is reasonable to write normal code like `sizeof(func_call())` (not
> false positive), maybe set the option to
MTC created this revision.
MTC added reviewers: NoQ, george.karpenkov, xazax.hun.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.
When improving the modeling `evalMemset()`, some scenes need to emit report of
`NotNullTerm`. In this case,
there are three places in
ilya-biryukov added a comment.
Sorry for the delay, just a few more comments.
Comment at: clangd/ClangdLSPServer.cpp:412
+llvm::raw_string_ostream OS(Message);
+OS << "method not found (" << Method << ")";
+replyError(ErrorCode::MethodNotFound, OS.str());
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:101
json::obj{
-{"textDocumentSync", 1},
+{"textDocumentSync", 2},
{"documentFormattingProvider", true},
simark wrote:
> ilya-biryukov
SimeonEhrig added inline comments.
Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178
+
+// In CUDA incremental processing, a CUDA ctor or dtor will be generated for
+// every statement if a fatbinary file exists.
tra wrote:
> SimeonEhrig
hokein added a comment.
As this patch can catch some mistakes, I'm fine with checking it in. I agree
that it is reasonable to write normal code like `sizeof(func_call())` (not
false positive), maybe set the option to `false` by default?
https://reviews.llvm.org/D44231
lebedev.ri added a comment.
So what part is failing, specifically?
The SHA1 blobs of USR's differ in the llvm-bcanalyzer dumps?
The actual filenames `%t/docs/bc/` differ?
I guess both?
First one you should be able to handle by replacing the actual values with a
regex
(i'd guess ` op19=226
1 - 100 of 107 matches
Mail list logo
