mstorsjo abandoned this revision.
mstorsjo added a comment.
Fixed the issue via https://reviews.llvm.org/D44592 instead, thanks @efriedma
for the pointers!
Repository:
rC Clang
https://reviews.llvm.org/D44582
___
cfe-commits mailing list
cfe-com
MTC updated this revision to Diff 139075.
MTC added a comment.
Add the comments as suggested by @szepet .
Repository:
rC Clang
https://reviews.llvm.org/D44606
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/loop-widening.c
Index: test/Analysis/loop-widening.c
=
smeenai added a comment.
I would imagine there was a reason this configuration was unsupported on macOS
– perhaps something to do with libc++/libc++abi being the default system
libraries on that platform?
Comment at: libcxx/CMakeLists.txt:330
# Check that this option is no
simark created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov,
klimek.
simark added a reviewer: ilya-biryukov.
To implement incremental document syncing, we want to verify that the
ranges provided by the front-end are valid. Currently, positionToOffset
zinovy.nis added a comment.
Gentle ping)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
modocache created this revision.
modocache added reviewers: GorNishanov, vsk, eric_niebler, lewissbaker.
As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html,
the LLVM coroutines transforms are not yet able to move the
instructions for UBSan null checking past coroutine
phosek created this revision.
phosek added reviewers: EricWF, mclow.lists, compnerd, beanz.
Herald added subscribers: cfe-commits, christof, mgorny.
This seems to be working without any problems.
Repository:
rCXX libc++
https://reviews.llvm.org/D44671
Files:
libcxx/CMakeLists.txt
Index:
mclow.lists added a comment.
We don't usually do this in source files, because they don't get included in
people's builds - just the library build.
if you look in src/mutex.cpp, you'll see stuff like:
`void __call_once(volatile unsigned long& flag, void* arg, void(*func)(void*))`
On the other h
Author: gbiv
Date: Mon Mar 19 20:27:44 2018
New Revision: 327945
URL: http://llvm.org/viewvc/llvm-project?rev=327945&view=rev
Log:
Properly construct `inline` members without initializers
Digging through commit logs, it appears the checks in this block predate
`inline` class variables. With them,
steven_wu created this revision.
steven_wu added reviewers: rsmith, arphaman.
Under some conditions, LinkageComputer can get the visibility for
ClassTemplateSpecializationDecl wrong because it failed to find the Decl
that has the explicit visibility.
This fixes:
llvm.org/bugs/pr36810
rdar://probl
MTC added a comment.
In https://reviews.llvm.org/D44557#1042357, @NoQ wrote:
> Sorry, one moment, i'm seeing a few regressions after the previous
> refactoring but i didn't look at them closely yet to provide a reproducer.
> I'll get back to this.
Thank you for the code review, @NoQ !
The re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327939: [CodeGen] Ignore OpaqueValueExprs that are unique
references to their (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
Author: ahatanak
Date: Mon Mar 19 18:47:58 2018
New Revision: 327939
URL: http://llvm.org/viewvc/llvm-project?rev=327939&view=rev
Log:
[CodeGen] Ignore OpaqueValueExprs that are unique references to their
source expressions when iterating over a PseudoObjectExpr's semantic
subexpression list.
Pre
MTC added a comment.
> Just in case: we indeed do not guarantee that `SymbolConjured` corresponds to
> a statement; it is, however, not intended, but rather a bug.
Thank you for your explanation and the reasonable example, NoQ.
Repository:
rC Clang
https://reviews.llvm.org/D44606
___
MTC added a comment.
> One small nit for future debugging people: Could you insert a comment line in
> the test case where you explain what is this all about? E.g what you just
> have written in the description: "invalidateRegions() will construct the
> SymbolConjured with null Stmt" or somethi
Author: george.karpenkov
Date: Mon Mar 19 18:16:46 2018
New Revision: 327935
URL: http://llvm.org/viewvc/llvm-project?rev=327935&view=rev
Log:
[analyzer] Improve performance of NoStoreFuncVisitor
Compute modifying frames lazily on demand.
Differential Revision: https://reviews.llvm.org/D44503
M
eugenis accepted this revision.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D44655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327932: Allow builtins for Cross-DSO CFI on Android
(authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44655?vs=139062&id=139063#toc
Repository:
rC Clang
https:/
Author: phosek
Date: Mon Mar 19 17:56:08 2018
New Revision: 327932
URL: http://llvm.org/viewvc/llvm-project?rev=327932&view=rev
Log:
Allow builtins for Cross-DSO CFI on Android
This is needed to avoid the test failure in case when compiler-rt
is set as the default runtime library for Clang.
Diff
phosek updated this revision to Diff 139062.
phosek added a comment.
SGTM, I've made the test even more explicit.
https://reviews.llvm.org/D44655
Files:
clang/test/Driver/sanitizer-ld.c
Index: clang/test/Driver/sanitizer-ld.c
=
eugenis added a comment.
Since the test is about cfi, not builtins, I think it's better to check for the
cfi library explicitly.
Repository:
rC Clang
https://reviews.llvm.org/D44655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
- change the uses of abi_for_size to simd_abi::deduce.
- remove the const in const_where_expression's template.
https://reviews.llvm.org/D44663
File
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D44665
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.ac
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D44664
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.access/default.pass.cpp
libcxx/te
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
When vector extension (__attribute__((vector_size(... is available
use its operators, instead of generating loops of scalar operations.
https://r
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D44660
Files:
libcxx/include/experimental/simd
Index: libcxx/include/experimental/simd
==
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
Also change std::plus<_Tp> to std::plus<>/__simd_plus_op, so that the
optimization can transparently use the simd<> overloading.
https://reviews.llvm
phosek added a comment.
I was actually thinking about doing the same now, more specifically using
`-rtlib=platform` which is already used elsewhere in this test. Do you prefer
one or the other?
Repository:
rC Clang
https://reviews.llvm.org/D44655
_
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
This optimization is allowed by the semantics, as users shouldn't pass
in values that may cause undefined behavior even those values are masked.
http
eugenis added a comment.
Indeed!
https://reviews.llvm.org/D44645
Repository:
rC Clang
https://reviews.llvm.org/D44655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
Simply use __attribute__((align_value(...))).
https://reviews.llvm.org/D44658
Files:
libcxx/include/experimental/simd
Index: libcxx/include/exper
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, sanjoy.
Herald added a reviewer: EricWF.
Herald added a reviewer: EricWF.
In __simd_reference, the conversion between bool and mask integer is
in wrong place.
https://reviews.llvm.org/D44657
phosek added a comment.
That link seems to be pointing to this change?
Repository:
rC Clang
https://reviews.llvm.org/D44655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 139043.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41843
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.whereexpr/const_where_expression.pass.cpp
libcxx/test/std/exp
timshen updated this revision to Diff 139045.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41845
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.cons/load.pass.cpp
libcxx/test/std/experimental/simd/simd.mask
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added subscribers: christof, kristof.beyls, sanjoy.
Herald added a reviewer: EricWF.
Currently x86, PowerPC, and ARM are supported.
https://reviews.llvm.org/D44656
Files:
libcxx/include/experimental/__config
libcxx
timshen updated this revision to Diff 139044.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41844
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.horizontal/hmax.pass.cpp
libcxx/test/std/experimental/simd/sim
timshen updated this revision to Diff 139042.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41756
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.casts/to_compatible.pass.cpp
libcxx/test/std/experimental/simd
timshen updated this revision to Diff 139040.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41422
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.elementwise/clamp.pass.cpp
libcxx/test/std/experimental/simd/s
timshen updated this revision to Diff 139038.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41412
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.horizontal/concat.pass.cpp
libcxx/test/std/experimental/simd/s
timshen updated this revision to Diff 139041.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41747
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp
libcxx/test/std/experimental/si
timshen updated this revision to Diff 139039.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41415
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.casts/simd_cast.pass.cpp
libcxx/test/std/experimental/simd/sim
timshen updated this revision to Diff 139037.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41376
Files:
libcxx/include/__config
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/utility
libcxx/test/s
timshen updated this revision to Diff 139036.
timshen added a comment.
Herald added a subscriber: christof.
Rebase.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp
libcx
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
See my comment in https://reviews.llvm.org/D44655, but this change is also fine
with me.
Repository:
rC Clang
https://reviews.llvm.org/D44655
_
Author: george.karpenkov
Date: Mon Mar 19 17:20:58 2018
New Revision: 327926
URL: http://llvm.org/viewvc/llvm-project?rev=327926&view=rev
Log:
[analyzer] Fix the assertion failure when static globals are used in lambda by
reference
Also use the opportunity to clean up the code and remove unneces
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327926: [analyzer] Fix the assertion failure when static
globals are used in lambda by… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
ht
phosek created this revision.
phosek added a reviewer: eugenis.
Herald added subscribers: cfe-commits, srhines.
This is needed to avoid the test failure in case when compiler-rt
is set as the default runtime library for Clang.
Repository:
rC Clang
https://reviews.llvm.org/D44655
Files:
cla
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D44491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Yep, these are pretty much always local.
https://reviews.llvm.org/D44649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
benlangmuir created this revision.
benlangmuir added reviewers: bruno, vsapsai.
Herald added a subscriber: cfe-commits.
This make -ivfsoverlay behave more like other fatal errors (e.g. missing
-include file) by skipping the missing file instead of bailing out of
the whole compilation. This makes i
eugenis added inline comments.
Comment at: test/Driver/sanitizer-ld.c:517
// CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}"
// CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt.
mgorny wrote:
> (an alternative would be to replace this 'NOT' clause with more sp
rjmccall added a comment.
I think Richard is probably catching up from a week at the C++ committee.
To be clear, I am objecting to this; I think the destructor should clearly have
been created at this point. I'm just hoping Richard will have an idea for how
best to fix it.
Repository:
rC C
az updated this revision to Diff 139015.
az added a comment.
add LLVM codegen tests as suggested in the reviews.
https://reviews.llvm.org/D44591
Files:
clang/include/clang/Basic/arm_neon.td
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c
llvm/test/Code
dim added a comment.
@rsmith, any objections?
Repository:
rC Clang
https://reviews.llvm.org/D44536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DHowett-MSFT added a comment.
In https://reviews.llvm.org/D44646#1042347, @efriedma wrote:
> The compiler shouldn't inline functions which call va_start, whether or not
> they're marked always_inline. That should work correctly, I think, at least
> on trunk. (See https://reviews.llvm.org/D425
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great.
Comment at: lib/Sema/SemaExprCXX.cpp:3458
+ }
+ TheCall->getCallee()->setType(OperatorNewOrDelete->getType());
+
It would be nice
mgrang added a comment.
Ping for reviews please.
Repository:
rC Clang
https://reviews.llvm.org/D44362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This should be fixed by r327911.
Douglas Yung
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Galina Kistanova via cfe-commits
Sent: Monday, March 19, 2018 13:13
To: Alexander Kornienko
Cc: cfe-commits
Subject: Re: [clang-tools-extra] r327833 - [clang-tidy] New check
Author: dyung
Date: Mon Mar 19 14:22:58 2018
New Revision: 327911
URL: http://llvm.org/viewvc/llvm-project?rev=327911&view=rev
Log:
Fixup test to explicitly use -fexceptions since exceptions are disabled by
default on the PS4 target.
Modified:
clang-tools-extra/trunk/test/clang-tidy/bugprone
NoQ added a comment.
Sorry, one moment, i'm seeing a few regressions after the previous refactoring
but i didn't look at them closely yet to provide a reproducer. I'll get back to
this.
Repository:
rC Clang
https://reviews.llvm.org/D44557
___
c
compnerd added a comment.
What happens in the case that you have a variadic in C code marked with
`__forceinline`? Does that also cause a warning with MSVC?
Comment at: test/Sema/ms-forceinline-on-variadic.cpp:1
+// RUN: %clang_cc1 -emit-llvm -o - -triple i686-windows -verify
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Just in case: we indeed do not guarantee that `SymbolConjured` corresponds to a
statement; it is, however, not intended, but rather a bug. Consider:
1void clang_analyzer_eval(bool);
2
3
efriedma added a comment.
The compiler shouldn't inline functions which call va_start, whether or not
they're marked always_inline. That should work correctly, I think, at least on
trunk. (See https://reviews.llvm.org/D42556 .)
If you want to warn anyway, that's okay.
Repository:
rC Clang
espindola added a comment.
ping
https://reviews.llvm.org/D44491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
espindola created this revision.
espindola added reviewers: rnk, echristo.
https://reviews.llvm.org/D44649
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/microsoft-templ-uuidof.cpp
Index: test/CodeGenCXX/microsoft-templ-uuidof.cpp
==
Author: maskray
Date: Mon Mar 19 12:05:53 2018
New Revision: 327885
URL: http://llvm.org/viewvc/llvm-project?rev=327885&view=rev
Log:
[clang-move] Fix move-used-helper-decls.cpp test.
Modified:
clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp
Modified: clang-tools-extra/tru
Author: jkorous
Date: Mon Mar 19 13:26:18 2018
New Revision: 327902
URL: http://llvm.org/viewvc/llvm-project?rev=327902&view=rev
Log:
[clangd] Fix undefined behavior due to misaligned type cast
The current code was casting pointer to a misaligned type which is undefined
behavior.
Found by compil
Author: jkorous
Date: Mon Mar 19 13:26:15 2018
New Revision: 327901
URL: http://llvm.org/viewvc/llvm-project?rev=327901&view=rev
Log:
[clangd][nfc] Give name to a magic constant
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Modified: clang-tools-extra/trunk/clangd/index/Index.h
URL:
DHowett-MSFT updated this revision to Diff 138996.
DHowett-MSFT added a comment.
Ran `clang-format` over changed lines. Reuploaded diff with full context.
Repository:
rC Clang
https://reviews.llvm.org/D44580
Files:
lib/Sema/SemaExpr.cpp
test/SemaObjC/block-compare.mm
Index: test/SemaOb
DHowett-MSFT updated this revision to Diff 138995.
DHowett-MSFT added a comment.
Fixed formatting.
Repository:
rC Clang
https://reviews.llvm.org/D44646
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/ms-forceinline-on-variadic.cpp
Index: test/Sem
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Alright, LGTM.
https://reviews.llvm.org/D39562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
tra added inline comments.
Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178
+
+// In CUDA incremental processing, a CUDA ctor or dtor will be generated for
+// every statement if a fatbinary file exists.
SimeonEhrig wrote:
> tra wrote:
> > Sim
smeenai added a reviewer: compnerd.
smeenai added a comment.
@DHowett-MSFT the reviewers look fine to me. Reid is the code owner for clang's
MSVC compat support. David doesn't work on this stuff directly anymore, I
think, but he's still pretty active in code reviews for it. I'm adding Saleem,
w
Hello Alexander,
This commit broke at least two of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/26909
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
. . .
Failing Tests (1):
Clang Tools :: clang-tidy/bug
DHowett-MSFT added a comment.
Apologies if I've chosen the wrong set of reviewers.
Repository:
rC Clang
https://reviews.llvm.org/D44646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
DHowett-MSFT created this revision.
DHowett-MSFT added reviewers: rnk, majnemer.
DHowett-MSFT added a project: clang.
Herald added subscribers: cfe-commits, eraman.
The MSVC compiler rejects `__forceinline` on variadic functions with the
following warning (at /https://reviews.llvm.org/W4):
C47
mgorny added inline comments.
Comment at: test/Driver/sanitizer-ld.c:517
// CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}"
// CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt.
(an alternative would be to replace this 'NOT' clause with more specific
library n
mgorny created this revision.
mgorny added a reviewer: eugenis.
Herald added subscribers: dberris, srhines.
mgorny added inline comments.
Comment at: test/Driver/sanitizer-ld.c:517
// CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}"
// CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclan
vsapsai added a comment.
I think we have agreement on this change. If there are no objections, I plan to
commit it on Wednesday, March 21.
https://reviews.llvm.org/D43494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
thakis accepted this revision.
thakis added a comment.
Awesome, thanks! One nit below:
Comment at: include/clang/Basic/DiagnosticParseKinds.td:973
+def warn_pragma_optimize : Warning<
+ "'#pragma optimize' is not supported; use '#pragma clang optimize on|off'
instead">,
+ In
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327892: [CodeGen] Add funclet token to ARC marker (authored
by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44640?vs=138973&id=138983#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327892: [CodeGen] Add funclet token to ARC marker (authored
by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44640?vs=138973&id=138
marsupial created this revision.
marsupial added reviewers: eugene, boris.
marsupial added a project: clang.
marsupial updated this revision to Diff 138982.
Arguments passed to HeaderSearchOptions methods are stored as std::strings,
having them converted to a StringRef at the call site can result
marsupial updated this revision to Diff 138982.
https://reviews.llvm.org/D44643
Files:
include/clang/Lex/HeaderSearchOptions.h
Index: include/clang/Lex/HeaderSearchOptions.h
===
--- include/clang/Lex/HeaderSearchOptions.h
+++ inc
Author: smeenai
Date: Mon Mar 19 12:34:39 2018
New Revision: 327892
URL: http://llvm.org/viewvc/llvm-project?rev=327892&view=rev
Log:
[CodeGen] Add funclet token to ARC marker
The inline assembly generated for the ARC autorelease elision marker
must have a funclet token if it's emitted inside a f
mibintc added a comment.
I added some inline comments. You are using the Intel 18.0 compiler on Windows
- what version of Visual Studio is in the environment?
Comment at: include/llvm-c/Target.h:25
-#if defined(_MSC_VER) && !defined(inline)
+#if defined(_MSC_VER) && !defined
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
We should really just switch the reclaim to be marked with a bundle in the
first place, but that's not a reasonable thing to ask you to do.
Repository:
rC Clang
https://reviews.
Author: hokein
Date: Mon Mar 19 12:13:03 2018
New Revision: 327887
URL: http://llvm.org/viewvc/llvm-project?rev=327887&view=rev
Log:
[clang-move] Fix the failing test caused by changes in clang-format.
Modified:
clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp
Modified: cla
smeenai created this revision.
smeenai added reviewers: ahatanak, compnerd, majnemer, rjmccall, rnk.
The inline assembly generated for the ARC autorelease elision marker
must have a funclet token if it's emitted inside a funclet, otherwise
the inline assembly (and all subsequent code in the funcle
szepet added a comment.
Nice catch, it looks good to me! Thank you!
One small nit for future debugging people: Could you insert a comment line in
the test case where you explain what is this all about? E.g what you just have
written in the description: "invalidateRegions() will construct the
Sy
ahatanak added a comment.
ping
https://reviews.llvm.org/D36918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benhamilton created this revision.
benhamilton added reviewers: jolesiak, djasper, Wizard.
Herald added subscribers: cfe-commits, klimek.
Objective-C selectors can with arguments be in the form:
foo:
foo:bar:
foo:bar:baz:
These can be passed to a macro, like NS_SWIFT_NAME():
https://developer.a
Author: abataev
Date: Mon Mar 19 10:53:56 2018
New Revision: 327873
URL: http://llvm.org/viewvc/llvm-project?rev=327873&view=rev
Log:
[OPENMP, NVPTX] Reworked castToType() function, NFC.
Reworked function castToType to use more frontend functionality rather
than the backend.
Modified:
cfe/tr
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Code looks good, but we should make the test more robust and self-documenting.
Comment at: test/CodeGenCXX/inheriting-constructor-cleanup.cpp:22
+// CHECK-LABEL: define void @_Z1fv
ahatanak added a comment.
This was reverted in r327294 because it caused module-enabled builders to fail
after I moved CXXRecordDecl::CanPassInRegisters to RecordDecl. I'm recommitting
this patch with fixes to ASTDeclReader and ASTWriter.
Repository:
rC Clang
https://reviews.llvm.org/D44095
Author: ahatanak
Date: Mon Mar 19 10:38:40 2018
New Revision: 327870
URL: http://llvm.org/viewvc/llvm-project?rev=327870&view=rev
Log:
[ObjC] Allow declaring __weak pointer fields in C structs in ARC.
This patch uses the infrastructure added in r326307 for enabling
non-trivial fields to be declar
simark marked 3 inline comments as done.
simark added inline comments.
Comment at: clangd/DraftStore.cpp:61
+ const Position &Start = Change.range->start;
+ size_t StartIndex = positionToOffset(Contents, Start);
+ if (StartIndex > Contents.length()) {
-
Author: abataev
Date: Mon Mar 19 10:18:13 2018
New Revision: 327868
URL: http://llvm.org/viewvc/llvm-project?rev=327868&view=rev
Log:
[OPENMP] Fix build with MSVC, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
URL:
htt
benhamilton added a comment.
I wonder if this wouldn't be better as a clang-tidy check:
https://github.com/llvm-mirror/clang-tools-extra/tree/master/clang-tidy/objc
Repository:
rC Clang
https://reviews.llvm.org/D44539
___
cfe-commits mailing lis
1 - 100 of 166 matches
Mail list logo
