mstorsjo added inline comments.
Comment at: lib/Driver/ToolChains/MinGW.cpp:459
addSystemInclude(DriverArgs, CC1Args,
+ Base + Arch + llvm::sys::path::get_separator() +
+ "include" + llvm::sys::path::get_separator() +
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329780: [Analyzer] SValBuilder Comparison Rearrangement
(with Restrictions and Analyzer… (authored by baloghadamsoftware, committed by
).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: baloghadamsoftware
Date: Tue Apr 10 23:21:12 2018
New Revision: 329780
URL: http://llvm.org/viewvc/llvm-project?rev=329780&view=rev
Log:
[Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer
Option)
Since the range-based constraint manager (default) is weak in h
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329779: Adding fuzzer flags support to OpenBSD driver
(authored by dberris, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44878
Files:
lib/Driver/ToolChains/OpenBSD.cpp
Index: lib
Author: dberris
Date: Tue Apr 10 22:40:47 2018
New Revision: 329779
URL: http://llvm.org/viewvc/llvm-project?rev=329779&view=rev
Log:
Adding fuzzer flags support to OpenBSD driver
Summary: - Following-up the sanitizer's part commit
https://reviews.llvm.org/rCRT329631, we enable fuzzer flags.
Re
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: EricWF.
This is now set automatically in libc++ config header.
Repository:
rC Clang
https://reviews.llvm.org/D45511
Files:
cla
dberris added a comment.
ACK -- let me land now. :)
https://reviews.llvm.org/D44878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen added a comment.
Hope it s good enough now :-)
https://reviews.llvm.org/D44878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Tue Apr 10 22:17:14 2018
New Revision: 329777
URL: http://llvm.org/viewvc/llvm-project?rev=329777&view=rev
Log:
[X86] Fix typo in intrinsic header file __mask16->__mmask16 from r329775.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
Modified: cfe/trunk/lib/Headers/avx
Author: ctopper
Date: Tue Apr 10 21:55:10 2018
New Revision: 329775
URL: http://llvm.org/viewvc/llvm-project?rev=329775&view=rev
Log:
[X86] Replace 512-bit masked pmaddubsw and pmaddwd intrinsic with unmasked
intrinsic and a select.
This makes it consistent with the 128/256-bit functions.
Somed
Roman, I see you've fixed them. Thanks a lot!
I did not face with these errors on MSVS'201 so had no chance to fix early.
ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator <
revi...@reviews.llvm.org>:
> lebedev.ri added a comment.
>
> This change had two different problems.
> Please wat
zinovy.nis added a subscriber: angelgarcia.
zinovy.nis added a comment.
Roman, I see you've fixed them. Thanks a lot!
I did not face with these errors on MSVS'201 so had no chance to fix early.
ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator <
revi...@reviews.llvm.org>:
> lebedev.ri a
EricWF added inline comments.
Comment at: include/clang/AST/ComparisonCategories.h:155-158
+ const ComparisonCategoryInfo &getInfo(ComparisonCategoryKind Kind) const {
+assert(HasData && "comparison category information not yet built");
+return Data[static_cast(Kind)];
+
NoQ added a comment.
I mean, like, if we try to work with the existing AST then we're stuck with a
prvalue expression that represents an lvalue and will be assigned a `Loc`
value, which is pretty weird anyway. Getting rid of the ParentMap in favor of
providing enough context (eg. in the CFG or
BillyONeal accepted this revision.
BillyONeal added a comment.
This revision is now accepted and ready to land.
It actually looks like I accidentally committed this back in January so I'm
going to close this :)
https://reviews.llvm.org/D41748
___
c
Author: dberris
Date: Tue Apr 10 18:47:40 2018
New Revision: 329773
URL: http://llvm.org/viewvc/llvm-project?rev=329773&view=rev
Log:
[XRay][clang] Only enable test for supported platforms
This is a follow-up to D45474.
Modified:
cfe/trunk/test/Driver/XRay/xray-mode-flags.cpp
Modified: cfe/
Author: dberris
Date: Tue Apr 10 18:28:25 2018
New Revision: 329772
URL: http://llvm.org/viewvc/llvm-project?rev=329772&view=rev
Log:
[XRay][clang+compiler-rt] Support build-time mode selection
Summary:
This patch implements the `-fxray-modes=` flag which allows users
building with XRay instrumen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329772: [XRay][clang+compiler-rt] Support build-time mode
selection (authored by dberris, committed by ).
Herald added a subscriber: delcypher.
Changed prior to commit:
https://reviews.llvm.org/D45474?v
dberris updated this revision to Diff 141940.
dberris marked an inline comment as done.
dberris added a comment.
Revert unnecessary one-liner change.
https://reviews.llvm.org/D45474
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Driver/XRayArgs.h
clang/lib/Driver/ToolCha
echristo added inline comments.
Comment at: clang/include/clang/Frontend/CodeGenOptions.h:110
+ enum XRayInstrumentationPointBundle {
+XRay_All, // Always emit all the instrumentation points.
dberris wrote:
> pelikan wrote:
> > To me, this feel
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure.
Comment at: clang/lib/Driver/XRayArgs.cpp:168
- for (const auto&AttrFile : AttrListFiles) {
+ for (const auto &AttrFile : AttrListFiles) {
SmallString<64>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329770: [libcxx] Set ABI version 2 as default for Fuchsia
(authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45304?vs=141935
Author: phosek
Date: Tue Apr 10 18:06:28 2018
New Revision: 329770
URL: http://llvm.org/viewvc/llvm-project?rev=329770&view=rev
Log:
[libcxx] Set ABI version 2 as default for Fuchsia
This avoids the need for a custom generated config file which is desired
because the custom config files differs p
Eugene.Zelenko added a comment.
How about doing same for //objc-property-declaration//?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Wizard added a comment.
In https://reviews.llvm.org/D45392#1063164, @alexfh wrote:
> In https://reviews.llvm.org/D45392#1061960, @Wizard wrote:
>
> > In https://reviews.llvm.org/D45392#1061433, @alexfh wrote:
> >
> > > I wonder whether the readability-identifier-naming check could be
> > > exten
Wizard updated this revision to Diff 141938.
Wizard added a comment.
move check to readability-identifier-naming
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming-objc.m
phosek updated this revision to Diff 141935.
phosek marked an inline comment as done.
Repository:
rCXX libc++
https://reviews.llvm.org/D45304
Files:
libcxx/include/__config
Index: libcxx/include/__config
===
--- libcxx/include
echristo accepted this revision.
echristo added a comment.
Guessing that SM_60 (etc) are defines?
Anyhow LGTM. I'm not sure you can split up the satom part of the patch, but if
you can that'd be great.
-eric
https://reviews.llvm.org/D45061
___
cf
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: libcxx/include/__config:39
#ifndef _LIBCPP_ABI_VERSION
+#ifdef __Fuchsia__
+#define _LIBCPP_ABI_VERSION 2
Please indent these nested `#ifd
tra abandoned this revision.
tra marked an inline comment as done.
tra added a comment.
I've figured out a manageable way to enforce constraints without this change.
https://reviews.llvm.org/D45060
___
cfe-commits mailing list
cfe-commits@lists.llvm
tra updated this revision to Diff 141932.
tra added a comment.
@echristo convinced me that this functionality can be implemented without
growing a target-specific hook for custom interpretation of constraints used in
TARGET_BUILTIN. Instead, we can hide unwieldy feature lists behind a macro.
h
phosek updated this revision to Diff 141933.
phosek marked an inline comment as done.
Repository:
rCXX libc++
https://reviews.llvm.org/D45304
Files:
libcxx/include/__config
Index: libcxx/include/__config
===
--- libcxx/include
EricWF added inline comments.
Comment at: libcxx/CMakeLists.txt:100
"LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY;LIBCXX_INSTALL_LIBRARY" OFF)
-set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.")
+if (FUCHSIA)
+ set(ABI_VERSION_DEFAULT 2)
I don't thin
Author: eugenezelenko
Date: Tue Apr 10 15:54:42 2018
New Revision: 329766
URL: http://llvm.org/viewvc/llvm-project?rev=329766&view=rev
Log:
[AST] Fix some Clang-tidy modernize-use-auto and Include What You Use warnings;
other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
chh added a comment.
If we use the unit test case, call `__gcov_flush` from the main function,
and dump static variables in GCDAProfiling.c, we can see that `__gcov_flush`
is resolved to the same copy for func.shared, func2.shared, and main.
However, when `__gcov_flush` is called from main and fro
rnk added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:3889
+ if (Context.getTargetInfo().getCXXABI().isMicrosoft() &&
+ hasFunctionProto(D) && isFunctionOrMethodVariadic(D)) {
Why is this warning dependent on the ABI? GCC has a similar warning:
aaron.ballman added a comment.
In https://reviews.llvm.org/D44093#1063658, @paulsemel wrote:
> Sorry about it, I also have the warning on my machine, but not the error you
> get...
> Those test are actually working on my different linux machines, that's
> really weird.
> This one is actually
paulsemel updated this revision to Diff 141920.
paulsemel added a comment.
Added triple option to CodeGen test so that it matches with the correct
architecture
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Se
aaron.ballman closed this revision.
aaron.ballman added a comment.
I see we all found the solution at the same time. Yay teamwork! :-D
I've committed (with the test fixed up) in r329762.
Repository:
rC Clang
https://reviews.llvm.org/D44093
___
c
Author: aaronballman
Date: Tue Apr 10 14:58:13 2018
New Revision: 329762
URL: http://llvm.org/viewvc/llvm-project?rev=329762&view=rev
Log:
Introduce a new builtin, __builtin_dump_struct, that is useful for dumping
structure contents at runtime in circumstances where debuggers may not be
easily a
paulsemel added a comment.
Thanks a lot for your help, updating the patch !
Repository:
rC Clang
https://reviews.llvm.org/D44093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Driver/ToolChains/MinGW.cpp:459
addSystemInclude(DriverArgs, CC1Args,
+ Base + Arch + llvm::sys::path::get_separator() +
+
arichardson added a comment.
In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote:
> Ok, I found the problem. In fact the size of `long` is 4 bytes on your
> machine, but 8 bytes on mine.
> This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],`
> fail.
> Do you know
arichardson added a comment.
In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote:
> Ok, I found the problem. In fact the size of `long` is 4 bytes on your
> machine, but 8 bytes on mine.
> This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],`
> fail.
> Do you know
lebedev.ri added inline comments.
Comment at: test/CodeGen/dump-struct-builtin.c:1
+// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s
+
This should be
```
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -emit-llvm %s -o - | FileCheck %s
```
or something
Repo
paulsemel added a comment.
Ok, I found the problem. In fact the size of `long` is 4 bytes on your machine,
but 8 bytes on mine.
This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` fail.
Do you know a smart way to do it without dealing with type sizes ?
Repository:
rC Clan
Author: phosek
Date: Tue Apr 10 14:29:18 2018
New Revision: 329760
URL: http://llvm.org/viewvc/llvm-project?rev=329760&view=rev
Log:
Revert "Handle the default case"
This reverts commit r329758.
Modified:
cfe/trunk/lib/Driver/ToolChains/NaCl.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/NaC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329759: [clang-tidy] Add a
`android-comparison-in-temp-failure-retry` check (authored by gbiv, committed
by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.l
Author: gbiv
Date: Tue Apr 10 14:22:22 2018
New Revision: 329759
URL: http://llvm.org/viewvc/llvm-project?rev=329759&view=rev
Log:
[clang-tidy] Add a `android-comparison-in-temp-failure-retry` check
This check attempts to catch buggy uses of the `TEMP_FAILURE_RETRY`
macro, which is provided by bo
paulsemel updated this revision to Diff 141913.
paulsemel added a comment.
Fixed printf warning generated in tests/CodeGen.
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
test/CodeGen/du
Author: phosek
Date: Tue Apr 10 14:19:05 2018
New Revision: 329758
URL: http://llvm.org/viewvc/llvm-project?rev=329758&view=rev
Log:
Handle the default case
This was omitted in D45422 resulting in a warning.
Differential Revision: https://reviews.llvm.org/D45499
Modified:
cfe/trunk/lib/Driv
paulsemel added a comment.
Sorry about it, I also have the warning on my machine, but not the error you
get...
Those test are actually working on my different linux machines, that's really
weird.
This one is actually really weird, because I could find manually the missing
pattern in your output
lebedev.ri updated this revision to Diff 141912.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
- Update
- Ignore GNU Statement Expressions too.
- Slightly reword docs.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44602
Files:
clang-tidy/readabilit
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:31
+!(isa(VD) || isa(VD)) &&
+!VD->getLocation().isMacroID())
+ Info.Variables++;
aaron.ballman wrote:
> This isn't the restriction I was envisioning.
mstorsjo updated this revision to Diff 141909.
mstorsjo added a comment.
Fixed the hardcoded triplet suffix, previously I erroneously had a "-gcc"
suffix there.
https://reviews.llvm.org/D45504
Files:
lib/Driver/ToolChains/MinGW.cpp
lib/Driver/ToolChains/MinGW.h
Index: lib/Driver/ToolChai
lebedev.ri added a comment.
This change had two different problems.
Please watch the bots?
Repository:
rL LLVM
https://reviews.llvm.org/D45405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: lebedevri
Date: Tue Apr 10 13:59:27 2018
New Revision: 329756
URL: http://llvm.org/viewvc/llvm-project?rev=329756&view=rev
Log:
[clang-tidy] Unbreak run-clang-tidy.cpp test
(modernize-use-auto.MinTypeNameLength)
Again, refs. D45405, rL329730.
Modified:
clang-tools-extra/trunk/test/c
mstorsjo created this revision.
mstorsjo added reviewers: chandlerc, martell, ismail, rnk, compnerd, mati865,
yaron.keren.
Previously it would only accept a string as a GCC version if it had either two
components and no suffix, or three components with an optional suffix.
Debian and ubuntu prov
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:188
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
N
aaron.ballman added a comment.
Thank you for rebasing, but the patch does not pass tests locally for me. I get
the following results (testing on Windows x64 with MSVC 2017 in a Debug build):
63> TEST 'Clang :: CodeGen/dump-struct-builtin.c' FAILED
63>Scr
mstorsjo created this revision.
mstorsjo added reviewers: martell, rnk, compnerd, mati865, ismail, yaron.keren.
If found, prefer this over looking for a similar gcc later in the system path.
This implements what @martell suggested in https://reviews.llvm.org/D45152 in a
much neater way.
Tests s
GBuella updated this revision to Diff 141904.
GBuella added a comment.
Rebased the patch.
https://reviews.llvm.org/D43817
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
l
erichkeane updated this revision to Diff 141900.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Restrict overloads as well.
https://reviews.llvm.org/D45383
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKind
aaron.ballman added a comment.
Thank you for working on this!
Comment at: include/clang/AST/ComparisonCategories.h:78
+ const DeclRefExpr *getResultValue(ComparisonCategoryResult ValueKind) const {
+const auto *DR = getResultValueUnsafe(ValueKind);
+assert(DR &&
--
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329754: [Driver] Handle the default case missed in r329748.
(authored by mcrosier, committed by ).
Changed prior to commi
Author: mcrosier
Date: Tue Apr 10 13:30:16 2018
New Revision: 329754
URL: http://llvm.org/viewvc/llvm-project?rev=329754&view=rev
Log:
[Driver] Handle the default case missed in r329748.
Differential Revision: https://reviews.llvm.org/D45499
Modified:
cfe/trunk/lib/Driver/ToolChains/NaCl.cpp
davezarzycki added a comment.
Hi @efriedma – Sorry about that. I haven't directly used `svn` in years thanks
to the `git svn` bridge.
Repository:
rL LLVM
https://reviews.llvm.org/D43578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
mstorsjo created this revision.
mstorsjo added reviewers: martell, rnk, compnerd, mati865.
Herald added a reviewer: EricWF.
This makes it consistent with libstdc++ and the other default include
directories.
If these headers are found in both locations and one isn't a symlink to the
other, this
Author: abataev
Date: Tue Apr 10 13:10:53 2018
New Revision: 329751
URL: http://llvm.org/viewvc/llvm-project?rev=329751&view=rev
Log:
[OPENMP] Additional attributes for the pointer parameters.
Added attributes for better optimization of the OpenMP code.
Modified:
cfe/trunk/lib/CodeGen/CGOpen
Author: lebedevri
Date: Tue Apr 10 13:07:06 2018
New Revision: 329750
URL: http://llvm.org/viewvc/llvm-project?rev=329750&view=rev
Log:
[clang-tidy][modernize]: don't forget to actually link to Tooling.
Fixes build for me:
[1/5] Linking CXX shared library lib/libclangTidyModernizeModule.so.7svn
Author: lebedevri
Date: Tue Apr 10 13:07:02 2018
New Revision: 329749
URL: http://llvm.org/viewvc/llvm-project?rev=329749&view=rev
Log:
[clang-tidy][Fuchsia]: don't forget to actually link to Google Module.
Fixes build for me:
[1/7] Linking CXX shared library lib/libclangTidyFuchsiaModule.so.7sv
phosek created this revision.
phosek added reviewers: rnk, rsmith, dlj.
Herald added a subscriber: cfe-commits.
This was omitted in https://reviews.llvm.org/D45422 resulting in a warning.
Repository:
rC Clang
https://reviews.llvm.org/D45499
Files:
clang/lib/Driver/ToolChains/NaCl.cpp
Ind
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329748: [Driver] Allow drivers to add multiple libc++
include paths (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45422
Author: phosek
Date: Tue Apr 10 12:55:55 2018
New Revision: 329748
URL: http://llvm.org/viewvc/llvm-project?rev=329748&view=rev
Log:
[Driver] Allow drivers to add multiple libc++ include paths
This allows toolchain drivers to add multiple libc++ include paths akin
to libstdc++. This is useful in
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
In https://reviews.llvm.org/D45185, I added clang-format parser support for
Objective-C
generics. However, I didn't touch the whitespace logic, so they
got the same sp
Author: gbuella
Date: Tue Apr 10 11:58:26 2018
New Revision: 329741
URL: http://llvm.org/viewvc/llvm-project?rev=329741&view=rev
Log:
[X86] Split up -march=icelake to -client & -server
Reviewers: craig.topper, zvi, echristo
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.o
paulsemel updated this revision to Diff 141890.
paulsemel added a comment.
Patch rebased.
Minor fix for single quotes escaping.
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
test/CodeGe
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D45403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
avt77 added a comment.
In https://reviews.llvm.org/D43578#1063462, @thakis wrote:
> Reverted:
Many thanks for your help!
Repository:
rL LLVM
https://reviews.llvm.org/D43578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329741: [X86] Split up -march=icelake to -client &
-server (authored by GBuella, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45056?vs=1409
Author: zinovy.nis
Date: Tue Apr 10 11:56:29 2018
New Revision: 329740
URL: http://llvm.org/viewvc/llvm-project?rev=329740&view=rev
Log:
[clang-tidy] [modernize-use-auto] Fix members initialization order
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp
Modified: clang
Author: nico
Date: Tue Apr 10 11:53:28 2018
New Revision: 329739
URL: http://llvm.org/viewvc/llvm-project?rev=329739&view=rev
Log:
Revert r329684 (and follow-ups 329693, 329714). See discussion on
https://reviews.llvm.org/D43578.
Modified:
cfe/trunk/include/clang/Frontend/FrontendAction.h
thakis added a comment.
Reverted:
$ svn merge -c -329714 .
- Reverse-merging r329714 into '.':
Atest/Frontend/ftime-report-template-decl.cpp
- Recording mergeinfo for reverse merge of r329714 into '.': U .
$ svn merge -c -329693 .
- Reverse-merging r329693 into '.':
Utest/Frontend
aaron.ballman added a comment.
Can you rebase the patch? The patch did not apply cleanly for me against trunk
(the contents of the check function are appearing in
`CheckARMBuiltinExclusiveCall()`).
(Also, one tiny nit about escaped characters that can be fixed at the same
time.)
===
lebedev.ri added a comment.
Thank you for working on this check!
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.h:60
+
+ std::unordered_map ValueCanBeConst;
+ std::unordered_map HandleCanBeConst;
I'm guessing these should be `llvm::DenseMap`.
Repositor
Author: ctopper
Date: Tue Apr 10 11:43:44 2018
New Revision: 329738
URL: http://llvm.org/viewvc/llvm-project?rev=329738&view=rev
Log:
[X86] Add test case for llvm change r329734
This test ensures the popfd instruction in MS inline assembly can properly find
a clobber name for the dirflag registe
efriedma added a comment.
> while both git and svn have revert subcommands
This is kind of misleading; yes, both git and svn have subcommands named
"revert", but "svn revert" doesn't have the right meaning. You have to use
"svn merge" to revert a committed change.
Repository:
rL LLVM
http
Author: tra
Date: Tue Apr 10 11:38:22 2018
New Revision: 329737
URL: http://llvm.org/viewvc/llvm-project?rev=329737&view=rev
Log:
[CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.
Currently we always include PTX into the fatbin along
with the GPU code.It about doubles the size of the GPU bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329737: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all
option. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45495?vs=141882&id=141887#toc
Repository:
rC Clang
Thanks Nico!
On Tue, Apr 10, 2018 at 6:39 AM, Nico Weber via Phabricator
wrote:
> thakis added a comment.
>
> r329698, thanks!
>
>
> https://reviews.llvm.org/D45165
>
>
>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
___
cfe-commits mailing list
paulsemel added a comment.
In https://reviews.llvm.org/D44093#1063348, @aaron.ballman wrote:
> In https://reviews.llvm.org/D44093#1063340, @paulsemel wrote:
>
> > I don't really know what's the procedure right now.. What should I do once
> > you both accepted the patch ? :)
>
>
> You're good to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329735: [Parser] Fix assertion-on-invalid for unexpected
typename. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D9
Author: vsapsai
Date: Tue Apr 10 11:29:47 2018
New Revision: 329735
URL: http://llvm.org/viewvc/llvm-project?rev=329735&view=rev
Log:
[Parser] Fix assertion-on-invalid for unexpected typename.
In `ParseDeclarationSpecifiers` for the code
class A typename A;
we were able to annotate token `k
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1024-1027
+ // 'this' pointer is not an lvalue, we should not invalidate it.
+ if (CXXThisRegion::classof(baseR))
+return;
+
I don't think this run-time check belongs here. The f
avt77 added a comment.
In https://reviews.llvm.org/D43578#1063365, @davezarzycki wrote:
> A revert in practice just means undoing the changes. For example, while both
> `git` and `svn` have `revert` subcommands, you can also just take the
> original diff/patch, pipe it into `patch -R`, and if t
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D43750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping.
https://reviews.llvm.org/D44155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cpplearner updated this revision to Diff 141880.
cpplearner added a comment.
Removed `ExpectedForMaybeUnused` from AttributeList.h, and removed the entry
for `ExpectedForMaybeUnused` from the `warn_attribute_wrong_decl_type` table
definition.
https://reviews.llvm.org/D45403
Files:
include/c
jlebar added a comment.
lgtm!
https://reviews.llvm.org/D45495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
In https://reviews.llvm.org/D45495#1063370, @jlebar wrote:
> Where do we document the default values for these flags? Like, how is a user
> supposed to figure out whether the default is to include ptx or not?
I've updated docs/ClangCommandLineReference.rst.
https://revi
1 - 100 of 246 matches
Mail list logo
