[PATCH] D45610: [XRay][clang] Make -fxray-modes= additive

dberris created this revision. dberris added reviewers: eizan, kpw, pelikan. This allows us to do the following: clang -fxray-modes=none ... -fxray-modes=xray-basic It's important to be able to do this in cases where we'd like to specialise the configuration for the invocation of the

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:113 + auto KindVal = static_cast(Kind); + if (KindVal >= SymbolKindMin && KindVal <= SymbolKindMax) +SupportedSymbolKinds.set(KindVal);

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 142328. malaperle marked an inline comment as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1065632, @sammccall wrote: > In https://reviews.llvm.org/D44882#1065631, @malaperle wrote: > > > In https://reviews.llvm.org/D44882#1065622, @sammccall wrote: > > > > > Still LG, thanks! > > > I'll look into the testing issue. > > >

r329985 - [XRay][clang] Add flag to choose instrumentation bundles

Author: dberris Date: Thu Apr 12 19:31:58 2018 New Revision: 329985 URL: http://llvm.org/viewvc/llvm-project?rev=329985=rev Log: [XRay][clang] Add flag to choose instrumentation bundles Summary: This change addresses http://llvm.org/PR36926 by allowing users to pick which instrumentation bundles

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rC329985: [XRay][clang] Add flag to choose instrumentation bundles (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D44970?vs=142315=142317#toc Repository: rC

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 7 inline comments as done. EricWF added inline comments. Comment at: lib/AST/ExprConstant.cpp:6238-6263 +bool VisitBinCmp(const BinaryOperator *E) { + using CCR = ComparisonCategoryResult; + const ComparisonCategoryInfo = +

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 142315. dberris marked 5 inline comments as done. dberris added a comment. - fixup: Address comments https://reviews.llvm.org/D44970 Files: clang/include/clang/Basic/XRayInstr.h clang/include/clang/Driver/Options.td

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris added a comment. Thanks, Martin! Landing now, after suggested changes. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:471 bool CodeGenFunction::AlwaysEmitXRayCustomEvents() const { - return CGM.getCodeGenOpts().XRayAlwaysEmitCustomEvents; + return

[PATCH] D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL329984: [CMake][Fuchsia] Dont specify libc++ ABI version for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329984 - [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

Author: phosek Date: Thu Apr 12 19:02:13 2018 New Revision: 329984 URL: http://llvm.org/viewvc/llvm-project?rev=329984=rev Log: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia This is now set automatically in libc++ config header. Differential Revision:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL329983: [CMake] Set the default ABI version for Fuchsia in CMake as well (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[libcxx] r329983 - [CMake] Set the default ABI version for Fuchsia in CMake as well

Author: phosek Date: Thu Apr 12 18:59:15 2018 New Revision: 329983 URL: http://llvm.org/viewvc/llvm-project?rev=329983=rev Log: [CMake] Set the default ABI version for Fuchsia in CMake as well This is neeeded since the CMake value is used for the SOVERSION. Differential Revision:

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 5 inline comments as done. EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9377-9378 +def err_implied_comparison_category_type_not_found : Error< + "%0 type was not found; include before defining " + "or using

Buildbot numbers for the week of 4/1/2018 - 4/7/2018

Hello everyone, Below are some buildbot numbers for the last week of 4/1/2018 - 4/7/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 3/25/2018 - 3/31/2018

Hello everyone, Below are some buildbot numbers for the week of 3/25/2018 - 3/31/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Eric accepted on IRC. Repository: rCXX libc++ https://reviews.llvm.org/D45529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45601: Warn on bool* to bool conversion

Quuxplusone added inline comments. Comment at: test/CXX/expr/expr.unary/expr.unary.op/p6.cpp:18 // -- pointer, bool b6 = ! // expected-warning{{address of 'b4' will always evaluate to 'true'}} +// expected-warning@-1 {{comparing 'bool *' as a boolean}} This

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed with a follow-up to use the requested macro. https://reviews.llvm.org/D45595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r329979 - [libcxx] [test] Use TEST_IGNORE_NODISCARD.

Author: stl_msft Date: Thu Apr 12 17:07:48 2018 New Revision: 329979 URL: http://llvm.org/viewvc/llvm-project?rev=329979=rev Log: [libcxx] [test] Use TEST_IGNORE_NODISCARD. Fixes D45595. Modified:

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Approved by Eric. https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed, with a follow-up to use the C1XX macro. https://reviews.llvm.org/D45594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM (did not check the tests). Comment at: lib/Driver/ToolChains/Linux.cpp:25 #include "llvm/Support/Path.h" +#include "llvm/Support/ScopedPrinter.h" #include

[libcxx] r329975 - [libcxx] [test] Fix nodiscard warnings.

Author: stl_msft Date: Thu Apr 12 16:56:12 2018 New Revision: 329975 URL: http://llvm.org/viewvc/llvm-project?rev=329975=rev Log: [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. Fixes D45595. Modified:

[libcxx] r329976 - [libcxx] [test] Silence MSVC warning C4146.

Author: stl_msft Date: Thu Apr 12 16:56:14 2018 New Revision: 329976 URL: http://llvm.org/viewvc/llvm-project?rev=329976=rev Log: [libcxx] [test] Silence MSVC warning C4146. This test code triggers the MSVC warning: "unary minus operator applied to unsigned type, result still unsigned"

[libcxx] r329978 - [libcxx] [test] Fix whitespace, NFC.

Author: stl_msft Date: Thu Apr 12 16:56:22 2018 New Revision: 329978 URL: http://llvm.org/viewvc/llvm-project?rev=329978=rev Log: [libcxx] [test] Fix whitespace, NFC. test/std almost always uses spaces; now it is entirely tab-free. Modified:

[libcxx] r329973 - [libcxx] [test] Avoid MSVC truncation warnings.

Author: stl_msft Date: Thu Apr 12 16:56:07 2018 New Revision: 329973 URL: http://llvm.org/viewvc/llvm-project?rev=329973=rev Log: [libcxx] [test] Avoid MSVC truncation warnings. MSVC emits "warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data" when it sees

[libcxx] r329977 - [libcxx] [test] Use TEST_COMPILER_C1XX.

Author: stl_msft Date: Thu Apr 12 16:56:17 2018 New Revision: 329977 URL: http://llvm.org/viewvc/llvm-project?rev=329977=rev Log: [libcxx] [test] Use TEST_COMPILER_C1XX. Also TEST_COMPILER_CLANG in one place. (More could be changed.) Modified:

[libcxx] r329974 - [libcxx] [test] Avoid unary_function.

Author: stl_msft Date: Thu Apr 12 16:56:10 2018 New Revision: 329974 URL: http://llvm.org/viewvc/llvm-project?rev=329974=rev Log: [libcxx] [test] Avoid unary_function. Replace unary_function inheritance (which was never required, even in C++98) with argument_type and result_type typedefs. This

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai added a comment. To simplify reviewing additions to the test, here is the corresponding output # 23 "/Users/vsapsai/Projects/llvm/llvm-project/clang/test/Frontend/rewrite-includes.c" 2 #if 0 /* expanded by -frewrite-includes */ #include "rewrite-includes9.h" #endif /* expanded

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai created this revision. vsapsai added a reviewer: bkramer. Herald added a subscriber: jkorous-apple. `__has_include_next` requires correct DirectoryLookup for being evaluated correctly. We were using Preprocessor::GetCurDirLookup() but we were calling it after the preprocessor finished its

[PATCH] D45601: Warn on bool* to bool conversion

Eugene.Zelenko added a comment. There is Clang-tidy's readability-implicit-bool-conversion check. It may be reasonable to check pointers to integers too, since integers are often implicitly converted to

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya created this revision. hiraditya added reviewers: Eugene.Zelenko, rsmith. We found conversion from bool* to bool to be a common source of bug, so we have implemented this warning. Sample use case: int bar(bool b) { return b; } int baz() { bool *b; bar(b);

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/Expr.h:3097-3106 + bool isRelationalOp() const { +return isRelationalOp(getOpcode()) || + (getOpcode() == BO_Cmp && IsCmpOrdered); + } static bool

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:68 + /// \brief A map containing the comparison category values built from the + /// standard library. The key is a value of ComparisonCategoryValue. +

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar updated this revision to Diff 142294. tstellar added a comment. Replaced the if (Distro.isRedhat()) check with a string compare on the GCC installation lib. This narrows the scope of the fix and also makes it possible to write a test case. The code that detects distros ignores sysroot

[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma added a subscriber: pcc. efriedma added a comment. The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli Repository: rL LLVM https://reviews.llvm.org/D45109

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli On 4/12/2018 3:55 PM, George Karpenkov wrote: Hi Eli, The commit makes sense, but I’m not sure about your change to the

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: instead of changing the run lines to use -mllvm you have removed them. Was there a reason for the

[PATCH] D45109: Remove -cc1 option "-backend-option"

george.karpenkov added subscribers: efriedma, george.karpenkov. george.karpenkov added a comment. Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file:

r329968 - Fix test failure caused by r329965.

Author: efriedma Date: Thu Apr 12 15:50:50 2018 New Revision: 329968 URL: http://llvm.org/viewvc/llvm-project?rev=329968=rev Log: Fix test failure caused by r329965. "-mllvm" options get parsed slightly earlier, and -arm-restrict-it is only available if the ARM target is compiled in. Invoke

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This would have been fine for post-commit review. https://reviews.llvm.org/D45594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

danalbert created this revision. danalbert added a reviewer: srhines. Android targets should never use tools/libraries for non-Android targets or vice versa. Repository: rC Clang https://reviews.llvm.org/D45597 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/android-ndk-standalone.cpp

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. There's a macro for this in test_macros.h to make it easier to search for. please use that https://reviews.llvm.org/D45595 ___ cfe-commits

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 142279. apazos added a comment. Updated error messages and fixed getExtensionVersion https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index:

[PATCH] D45596: [libcxx] [test] Avoid unary_function.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think this would have been a good candidate for post-commit review. https://reviews.llvm.org/D45596 ___ cfe-commits mailing list

[PATCH] D45109: Remove -cc1 option "-backend-option"

This revision was automatically updated to reflect the committed changes. Closed by commit rL329965: Remove -cc1 option -backend-option. (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45109?vs=140484=142277#toc

r329965 - Remove -cc1 option "-backend-option".

Author: efriedma Date: Thu Apr 12 15:21:36 2018 New Revision: 329965 URL: http://llvm.org/viewvc/llvm-project?rev=329965=rev Log: Remove -cc1 option "-backend-option". It means the same thing as -mllvm; there isn't any reason to have two options which do the same thing. Differential Revision:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. In https://reviews.llvm.org/D45529#1066394, @EricWF wrote: > OK, so we need to bump the SO version -- However I don't want to generate a > __site_config header because of that if the __config header is sufficient. I > would like to see a solution that takes that into

[PATCH] D45596: [libcxx] [test] Avoid unary_function.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Avoid unary_function. Replace unary_function inheritance (which was never required, even in C++98) with argument_type and result_type typedefs. This increases portability, as unary_function was removed

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. https://reviews.llvm.org/D45595 Files:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

EricWF added a comment. OK, so we need to bump the SO version -- However I don't want to generate a __site_config header because of that if the __config header is sufficient. I would like to see a solution that takes that into account. Repository: rCXX libc++

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Silence MSVC warning C4146. This test code triggers the MSVC warning: "unary minus operator applied to unsigned type, result still unsigned" Although it would be possible to change the test code to

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added a comment. Just my 2 cents. Calculation of line/character for each occurrence may not take a lot of computation. cquery/ccls computes the Comment at: clangd/index/Index.h:39 // using half-open range, [StartOffset, EndOffset). + // FIXME(hokein): remove

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

flyingforyou updated this revision to Diff 142265. flyingforyou added a comment. Addressed SjoerdMeijer' new comments. Thanks. > Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included > in the next release of the ACLE. Could you check it, please? I saw several codes that

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added inline comments. Comment at: clangd/index/Index.h:32 +// Character offset on a line in a document (zero-based). +int Character = 0; + }; hokein wrote: > sammccall wrote: > > sammccall wrote: > > > Column? > > > > > > LSP calls this

[PATCH] D45217: [ThinLTO] Pass -save-temps to LTO backend for distributed ThinLTO builds

pcc added inline comments. Comment at: include/clang/Driver/Options.td:2255 HelpText<"Save intermediate compilation results.">; -def save_temps : Flag<["-", "--"], "save-temps">, Flags<[DriverOption]>, +def save_temps : Flag<["-", "--"], "save-temps">, Flags<[CC1Option,

[clang-tools-extra] r329958 - [clangd][nfc] Simplify readDelimitedMessage()

Author: jkorous Date: Thu Apr 12 14:33:24 2018 New Revision: 329958 URL: http://llvm.org/viewvc/llvm-project?rev=329958=rev Log: [clangd][nfc] Simplify readDelimitedMessage() istream::eof() is always false after successful getline() Modified:

[PATCH] D45068: [NVPTX, CUDA] Added support for m8n32k16 and m32n8k16 variants of wmma instructions.

tra updated this revision to Diff 142262. tra added a comment. Updated BuiltinsNVPTX.def and tests to deal with changes in the way we deal with required features in TARGET_BUILTIN. https://reviews.llvm.org/D45068 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek updated this revision to Diff 142261. phosek marked an inline comment as done. phosek added a comment. I had something similar in https://reviews.llvm.org/D45304 but Eric suggested removing it. What I haven't realized is that this value is also used to set the SOVERSION so it's indeed

[PATCH] D45591: Clean carriage returns from lib/ and include/. NFC.

Quuxplusone created this revision. Herald added subscribers: cfe-commits, krytarowski, emaste. Clean carriage returns from lib/ and include/. NFC. (I have to make this change locally in order for `git diff` to show sane output after I edit a file, so I might as well ask for it to be committed. I

r329952 - [NFC] Fix terrible formatting of CGRecordLower constructor.

Author: erichkeane Date: Thu Apr 12 13:46:31 2018 New Revision: 329952 URL: http://llvm.org/viewvc/llvm-project?rev=329952=rev Log: [NFC] Fix terrible formatting of CGRecordLower constructor. Modified: cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp Modified:

[libcxxabi] r329950 - [demangler] NFC: Some refactoring to support partial demangling.

Author: epilk Date: Thu Apr 12 13:41:06 2018 New Revision: 329950 URL: http://llvm.org/viewvc/llvm-project?rev=329950=rev Log: [demangler] NFC: Some refactoring to support partial demangling. I'm committing this to libcxxabi too so that the two demanglers remain as simular as possible.

[clang-tools-extra] r329949 - Revert "[clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself"

Author: zinovy.nis Date: Thu Apr 12 13:33:24 2018 New Revision: 329949 URL: http://llvm.org/viewvc/llvm-project?rev=329949=rev Log: Revert "[clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself" This reverts r329873 as getting only a single token length is wrong for

[PATCH] D45217: [ThinLTO] Pass -save-temps to LTO backend for distributed ThinLTO builds

tejohnson added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL329946: [MinGW] Look for libc++ headers in a triplet prefixed path as well (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

This revision was automatically updated to reflect the committed changes. Closed by commit rC329946: [MinGW] Look for libc++ headers in a triplet prefixed path as well (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D45500?vs=141894=142243#toc

r329946 - [MinGW] Look for libc++ headers in a triplet prefixed path as well

Author: mstorsjo Date: Thu Apr 12 13:07:38 2018 New Revision: 329946 URL: http://llvm.org/viewvc/llvm-project?rev=329946=rev Log: [MinGW] Look for libc++ headers in a triplet prefixed path as well This makes it consistent with libstdc++ and the other default include directories. If these

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

On Thu, Apr 12, 2018 at 10:47 PM, Zinovy Nis via cfe-commits wrote: > I composed a test and you are right - for multi-token type names new code > returns wrong result. So this new code was a premature optimization. Sorry. > I'll see how to fix it in a better way and

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

I composed a test and you are right - for multi-token type names new code returns wrong result. So this new code was a premature optimization. Sorry. I'll see how to fix it in a better way and create a review on it. Thanks for poiting. чт, 12 апр. 2018 г. в 20:01, Alexander Kornienko

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:443 return Sym->getType() == Ty && +APSIntType(Int) == BV.getAPSIntType(Sym->getType()) && (!BinaryOperator::isComparisonOp(Op) || 6. Therefore i conclude that this

r329942 - Fix doc typo

Author: vlad.tsyrklevich Date: Thu Apr 12 12:35:39 2018 New Revision: 329942 URL: http://llvm.org/viewvc/llvm-project?rev=329942=rev Log: Fix doc typo Modified: cfe/trunk/docs/ControlFlowIntegrity.rst Modified: cfe/trunk/docs/ControlFlowIntegrity.rst URL:

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

This revision was automatically updated to reflect the committed changes. Closed by commit rL329941: [RISCV] Fix logic to check if frame pointer should be used (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329941 - [RISCV] Fix logic to check if frame pointer should be used

Author: mgrang Date: Thu Apr 12 12:31:37 2018 New Revision: 329941 URL: http://llvm.org/viewvc/llvm-project?rev=329941=rev Log: [RISCV] Fix logic to check if frame pointer should be used Summary: The logic was broken for Linux triples as it returns true in the switch for Triple.isOSLinux().

Improve non-void no return warning

I changed the messages like "control may reach end of non-void function" to "non-void function may not return a value" I think this is a lot more understandable. better-nonvoid-no-return-message.patch Description: Binary data ___ cfe-commits mailing

r329937 - [X86] Introduce wbinvd intrinsic

Author: gbuella Date: Thu Apr 12 11:42:02 2018 New Revision: 329937 URL: http://llvm.org/viewvc/llvm-project?rev=329937=rev Log: [X86] Introduce wbinvd intrinsic A previously missing intrinsic for an old instruction. Reviewers: craig.topper, echristo Reviewed By: craig.topper Differential

r329932 - NFC - Indentation fixes in predefined-arch-macros.c

Author: gbuella Date: Thu Apr 12 11:15:39 2018 New Revision: 329932 URL: http://llvm.org/viewvc/llvm-project?rev=329932=rev Log: NFC - Indentation fixes in predefined-arch-macros.c Consistently separating tests with empty lines. Helps while navigating this file. Reviewers: craig.topper

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo added a comment. Ping, any comments on the change itself, or tips on how to create a test for it? https://reviews.llvm.org/D45504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45311: [X86] Introduce wbinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329937: [X86] Introduce wbinvd intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45311?vs=142142=142228#toc

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

a.sidorin updated this revision to Diff 142226. a.sidorin added a comment. Rewrite the GCCAsmStmt in the CFG. Repository: rC Clang https://reviews.llvm.org/D45416 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/asm.cpp

[PATCH] D45383: Limit types of builtins that can be redeclared.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1065999, @compnerd wrote: > I know that the Windows SDK definitely declares the `__va_start` function. > Did you try building something like swift against the Windows SDK with this > change? Are we sure it declares it, and not

[PATCH] D45383: Limit types of builtins that can be redeclared.

compnerd added a comment. I know that the Windows SDK definitely declares the `__va_start` function. Did you try building something like swift against the Windows SDK with this change? https://reviews.llvm.org/D45383 ___ cfe-commits mailing list

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC329932: NFC - Indentation fixes in predefined-arch-macros.c (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45561?vs=142138=142223#toc Repository: rC Clang

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:4 +// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ +// RUN: -- + alexfh wrote: > The `--` and the trailing backslash above can be

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1065827, @davezarzycki wrote: > It wasn't my suggestion. @thakis wrote: "We probably should have a separate > bool in clang and key this off that and make -ftime-report set both." Sorry, but it's done now. Any comments, suggestions,

[PATCH] D44155: Fix support for try_acquire_capability

aaron.ballman closed this revision. aaron.ballman added a comment. Committed the fix in r329930. https://reviews.llvm.org/D44155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44155: Fix support for try_acquire_capability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this code is ready to go in -- accepting my own revision so that I can close. If @delesley spots any issues, they can be address post commit.

r329930 - Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954.

Author: aaronballman Date: Thu Apr 12 10:53:21 2018 New Revision: 329930 URL: http://llvm.org/viewvc/llvm-project?rev=329930=rev Log: Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954. Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

ahatanak updated this revision to Diff 142218. ahatanak edited the summary of this revision. ahatanak added a comment. Fix an error in emitGlobalDtorWithCXAAtExit and make sure @dso_handle is hidden. Repository: rC Clang https://reviews.llvm.org/D45578 Files:

[PATCH] D45109: Remove -cc1 option "-backend-option"

mcrosier accepted this revision. mcrosier added a comment. SGTM! Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1065787, @hokein wrote: > @malaperle, what's your plan of this patch? Are you going to land it before > https://reviews.llvm.org/D45513? With the Line info in the index, this > patch could be simplified. I'll address the last

[clang-tools-extra] r329927 - [Documentation] Order of changes in existing checks in Release Notes.

Author: eugenezelenko Date: Thu Apr 12 10:19:09 2018 New Revision: 329927 URL: http://llvm.org/viewvc/llvm-project?rev=329927=rev Log: [Documentation] Order of changes in existing checks in Release Notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

ahatanak created this revision. ahatanak added reviewers: arphaman, steven_wu, rjmccall. The command line option makes IRGen register destructor functions annotated with __attribute__((destructor)) calling __cxa_atexit in a synthesized constructor function instead of emitting references to the

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:187 + + if (isCalledByConstructor(Context)) +return; xazax.hun wrote: > Szelethus wrote: > > whisperity wrote: > > > I think somewhere there should

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

On Thu, Apr 12, 2018 at 7:44 AM Zinovy Nis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zinovy.nis > Date: Wed Apr 11 22:41:24 2018 > New Revision: 329873 > > URL: http://llvm.org/viewvc/llvm-project?rev=329873=rev > Log: > [clang-tidy] [modernize-use-auto] Get only a length of

r329924 - Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR30595.

Author: aaronballman Date: Thu Apr 12 09:41:55 2018 New Revision: 329924 URL: http://llvm.org/viewvc/llvm-project?rev=329924=rev Log: Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes

r329923 - [Hexagon] Enable auto-vectorization only when -fvectorize was given

Author: kparzysz Date: Thu Apr 12 09:25:35 2018 New Revision: 329923 URL: http://llvm.org/viewvc/llvm-project?rev=329923=rev Log: [Hexagon] Enable auto-vectorization only when -fvectorize was given Added: cfe/trunk/test/Driver/hexagon-vectorize.c Modified:

[PATCH] D43578: -ftime-report switch support in Clang

davezarzycki added a comment. It wasn't my suggestion. @thakis wrote: "We probably should have a separate bool in clang and key this off that and make -ftime-report set both." https://reviews.llvm.org/D43578 ___ cfe-commits mailing list

[PATCH] D43578: -ftime-report switch support in Clang

avt77 updated this revision to Diff 142198. avt77 added a reviewer: davezarzycki. avt77 added a comment. Herald added a subscriber: mgorny. I removed the dependence on TimePassesIsEnabled (as @davezarzycki sugested) and fixed the issue with failed test (tnx to @russell.gallop). As result the

  1   2   >