[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.

craig.topper added a subscriber: eli.friedman. craig.topper added a comment. @eli.friedman is that test worth doing? Would we do it for every builtin? Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list

[libunwind] r331336 - Creating release candidate final from release_502 branch

Author: tstellar Date: Tue May 1 20:24:29 2018 New Revision: 331336 URL: http://llvm.org/viewvc/llvm-project?rev=331336=rev Log: Creating release candidate final from release_502 branch Added: libunwind/tags/RELEASE_502/final/ (props changed) - copied from r331335,

[libcxxabi] r331330 - Creating release candidate final from release_502 branch

Author: tstellar Date: Tue May 1 20:23:58 2018 New Revision: 331330 URL: http://llvm.org/viewvc/llvm-project?rev=331330=rev Log: Creating release candidate final from release_502 branch Added: libcxxabi/tags/RELEASE_502/final/ - copied from r331329, libcxxabi/branches/release_50/

[libcxx] r331329 - Creating release candidate final from release_502 branch

Author: tstellar Date: Tue May 1 20:23:55 2018 New Revision: 331329 URL: http://llvm.org/viewvc/llvm-project?rev=331329=rev Log: Creating release candidate final from release_502 branch Added: libcxx/tags/RELEASE_502/final/ (props changed) - copied from r331328,

r331322 - [Modules] Allow @import to reach submodules in private module maps

Author: bruno Date: Tue May 1 19:25:03 2018 New Revision: 331322 URL: http://llvm.org/viewvc/llvm-project?rev=331322=rev Log: [Modules] Allow @import to reach submodules in private module maps A @import targeting a top level module from a private module map file (@import Foo_Private), would

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

phosek updated this revision to Diff 144824. phosek marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D45997 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Missing Sema tests that the attribute only appertains to functions, accepts no arguments, etc. Comment at: include/clang/Basic/Attr.td:1494 +def

[PATCH] D46233: [ASTMatchers] Overload isConstexpr for ifStmts

aaron.ballman accepted this revision. aaron.ballman added a comment. Aside from the issue @alexfh raised, this LGTM. Repository: rC Clang https://reviews.llvm.org/D46233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.

efriedma added a comment. You could write a test like `static_assert(noexcept(__builtin_ia32_bzhi_di(0,0)), "");`. I don't think it has any other effect. Repository: rC Clang https://reviews.llvm.org/D46328 ___ cfe-commits mailing list

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

rsmith accepted this revision. rsmith added inline comments. Comment at: Sema/SemaDecl.cpp:4659-4661 + (isa(OwnerScope) || + (isa(OwnerScope) && +cast(OwnerScope)->getDeclName( { jkorous wrote: > rsmith wrote: > > vsapsai

[PATCH] D30881: Track skipped files in dependency scanning

This revision was automatically updated to reflect the committed changes. vsapsai marked an inline comment as done. Closed by commit rL331319: Track skipped files in dependency scanning. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331319 - Track skipped files in dependency scanning.

Author: vsapsai Date: Tue May 1 16:59:33 2018 New Revision: 331319 URL: http://llvm.org/viewvc/llvm-project?rev=331319=rev Log: Track skipped files in dependency scanning. It's possible for a header to be a symlink to another header. In this case both will be represented by clang::FileEntry

r331318 - This test fails if there is no integrated assembler, so change the -c option to -S as it is not important to the test and allows it to pass when there is no integrated assembler.

Author: dyung Date: Tue May 1 16:32:09 2018 New Revision: 331318 URL: http://llvm.org/viewvc/llvm-project?rev=331318=rev Log: This test fails if there is no integrated assembler, so change the -c option to -S as it is not important to the test and allows it to pass when there is no integrated

[PATCH] D46328: [X86] Mark all x86 specific builtins as nothrow.

spatel added a comment. Seems right, but I don't know much about nothrow. Does some other attribute on these intrinsics suppress the possibility of throwing an exception? Ie, is there some way to test this? I can't seem to produce catch/landingpad IR even after putting an intrinsic in a 'try'

[PATCH] D30881: Track skipped files in dependency scanning

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the detailed answers. LGTM https://reviews.llvm.org/D30881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai added a comment. In https://reviews.llvm.org/D45884#1084060, @jkorous wrote: > Volodymyr, could you please confirm that the non-anonymous vs non-inline > logic makes sense to you? Looks correct to me that we are checking non-anonymous namespaces. Inline namespaces are somewhat

[PATCH] D46281: [clang-doc] Attaching a name to reference data

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > juliehockett wrote: > > lebedev.ri

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30881: Track skipped files in dependency scanning

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:191 + const Token , + SrcMgr::CharacteristicKind FileType) override; + bruno wrote: > Is there any

[PATCH] D30881: Track skipped files in dependency scanning

vsapsai updated this revision to Diff 144802. vsapsai added a comment. - Fix FileSkipped adding system headers when it shouldn't. https://reviews.llvm.org/D30881 Files: clang/lib/Frontend/DependencyFile.cpp clang/test/Frontend/Inputs/SystemHeaderPrefix/with-header-guard.h

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. On the WebKit side this lgtm. Let's leave some time for clang-format folks to chime in. Repository: rC Clang https://reviews.llvm.org/D46024 ___

[PATCH] D46332: [X86] Only enable the __ud2 and __int2c builtins if intrin.h has been included.

craig.topper created this revision. craig.topper added a reviewer: rnk. Every other builtin that uses TARGET_HEADER_BUILTIN has an 'h' in their attribute string. Assume this is an oversight here. https://reviews.llvm.org/D46332 Files: include/clang/Basic/BuiltinsX86.def Index:

r331306 - [libclang] Fix the type of 'int (Foo);'

Author: smeenai Date: Tue May 1 13:45:25 2018 New Revision: 331306 URL: http://llvm.org/viewvc/llvm-project?rev=331306=rev Log: [libclang] Fix the type of 'int (Foo);' libclang exposes the type of 'int (Foo);' (a global variable of type int called Foo) as CXType_Unexposed. This is because Clang

[PATCH] D45713: [libclang] Fix the type of 'int (Foo);'

This revision was automatically updated to reflect the committed changes. Closed by commit rL331306: [libclang] Fix the type of int (Foo); (authored by smeenai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45713 Files:

r331305 - [ARM] Remove redundant #if in test. NFC

Author: smeenai Date: Tue May 1 13:38:05 2018 New Revision: 331305 URL: http://llvm.org/viewvc/llvm-project?rev=331305=rev Log: [ARM] Remove redundant #if in test. NFC Both sides of this #if #include the same file. Drop the #if, leaving only the #include. Patch by Matt Glazar. Differential

[PATCH] D45779: [ARM] Remove redundant #if in test

This revision was automatically updated to reflect the committed changes. Closed by commit rC331305: [ARM] Remove redundant #if in test. NFC (authored by smeenai, committed by ). Herald added a reviewer: javed.absar. Changed prior to commit: https://reviews.llvm.org/D45779?vs=142969=144775#toc

[PATCH] D45931: [ASTMatchers] Don't garble the profiling output when multiple TU's are processed

lebedev.ri added a comment. In https://reviews.llvm.org/D45931#1083192, @lebedev.ri wrote: > Thank you for looking at this. > > In https://reviews.llvm.org/D45931#1083184, @alexfh wrote: > > > From a user's perspective I'd probably prefer a different behavior of > > checks profiling with

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis added a comment. https://reviews.llvm.org/rCTE331297 https://reviews.llvm.org/D45932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis closed this revision. zinovy.nis added a comment. Fixed in git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@331297 91177308-0d34-0410-b5e6-96231b3b80d8 https://reviews.llvm.org/D45932 ___ cfe-commits mailing list

[PATCH] D45611: [analyzer] Fix filename in cross-file HTML report

george.karpenkov accepted this revision. george.karpenkov added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D45611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

efriedma added a comment. I'd like to see some tests for __attribute((packed)). Comment at: lib/CodeGen/TargetInfo.cpp:5787 + } else { + TyAlign = getContext().getTypeAlign(Ty) ; + } Whitespace. Repository: rC Clang https://reviews.llvm.org/D46013

[PATCH] D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alrght, LGTM. https://reviews.llvm.org/D46022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r331244 - Implement P0482R2, support for char8_t type.

On 1 May 2018 at 08:55, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 30, 2018 at 10:02 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Mon Apr 30 22:02:45 2018 >> New Revision: 331244 >> >> URL:

r331299 - Fix bogus MSVC char8_t mangling.

Author: rsmith Date: Tue May 1 11:50:15 2018 New Revision: 331299 URL: http://llvm.org/viewvc/llvm-project?rev=331299=rev Log: Fix bogus MSVC char8_t mangling. This appears to have been caused by a bad automatic svn merge with r330225 attaching the 'case' label to the wrong block of code. :(

[clang-tools-extra] r331297 - [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

Author: zinovy.nis Date: Tue May 1 11:46:32 2018 New Revision: 331297 URL: http://llvm.org/viewvc/llvm-project?rev=331297=rev Log: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals It's useless and not safe to replace UTF-8 encoded with escaped ASCII to raw

[PATCH] D45814: Fix an assertion when -print-prog-name=

compnerd closed this revision. compnerd added a comment. SVN r331296 Repository: rC Clang https://reviews.llvm.org/D45814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r331296 - Driver: fix an assertion with `-print-prog-name=`

Author: compnerd Date: Tue May 1 11:40:42 2018 New Revision: 331296 URL: http://llvm.org/viewvc/llvm-project?rev=331296=rev Log: Driver: fix an assertion with `-print-prog-name=` Fix an assertion when -print-prog-name= is invoked without parameter. Returns an empty string. Patch by Christian

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331295: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection. (authored by lebedevri, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

beanz added a reviewer: bruno. beanz added a subscriber: bruno. beanz added a comment. @dexonsmith is often super busy, so @bruno may be able to weigh in instead. Repository: rC Clang https://reviews.llvm.org/D45639 ___ cfe-commits mailing list

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:44 +char const *const MultibyteSnowman("\xE2\x98\x83"); +// CHECK-FIXES: {{^}}char const *const MultibyteSnowman("\xE2\x98\x83");{{$}}

r331292 - Update existed CodeGen TBAA tests

Author: danil Date: Tue May 1 11:14:36 2018 New Revision: 331292 URL: http://llvm.org/viewvc/llvm-project?rev=331292=rev Log: Update existed CodeGen TBAA tests Reviewers: hfinkel, kosarev, rjmccall Reviewed By: rjmccall Differential Revision: https://reviews.llvm.org/D44616 Modified:

Re: [PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

Hi, > After thinking about this a bit, and use cases like rename and > find-declaration that could be USR based, I think including some location > information is the right way to go, which I think is the current behavior. > > What do you man by location information? Only the filename or filename

[PATCH] D46325: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer. 2nd try.

zinovy.nis created this revision. zinovy.nis added reviewers: george.karpenkov, alexfh, hokein. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, a.sidorin, xazax.hun. This macro is widely used in many well-known projects, ex. Chromium. But it's not set for

[PATCH] D44616: Update existed CodeGen TBAA tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL331292: Update existed CodeGen TBAA tests (authored by Danil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44616?vs=138874=144758#toc

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

lebedev.ri added a comment. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85591 Repository: rL LLVM https://reviews.llvm.org/D46323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D46323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

lebedev.ri updated this revision to Diff 144749. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Update comment, too. Repository: rL LLVM https://reviews.llvm.org/D46323 Files: lib/builtins/cpu_model.c Index: lib/builtins/cpu_model.c

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

LegalizeAdulthood added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:111 + // Upper ASCII are disallowed too. + for (unsigned char C = 0xFFu; C >= 0x80u; --C) +DisallowedChars.set(C); zinovy.nis wrote: > LegalizeAdulthood

[PATCH] D46281: [clang-doc] Attaching a name to reference data

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. I can't really comment on the BC change since i don't think anything here makes use of that yet, but the code changes look ok to me. LGTM. Comment at:

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:111 + // Upper ASCII are disallowed too. + for (unsigned char C = 0xFFu; C >= 0x80u; --C) +DisallowedChars.set(C); LegalizeAdulthood wrote: > Why does this loop go

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

craig.topper added inline comments. Comment at: lib/builtins/cpu_model.c:421 *Subtype = AMDFAM15H_BDVER2; break; // "bdver2"; 10h-1Fh: Piledriver } Update the comment please. Repository: rCRT Compiler Runtime

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Other than a few minor nits, ship it. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:110 + + // Upper ASCII are disallowed too. + for

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/MapSubscriptOperatorLookupCheck.cpp:36 + if (const auto *Matched = Result.Nodes.getNodeAs("match")) { +diag(Matched->getLocStart(), "do not use operator[] for map lookup") +<<

[PATCH] D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl

bruno closed this revision. bruno marked an inline comment as done. bruno added a comment. Landed in r331232 & r331233. Repository: rC Clang https://reviews.llvm.org/D46165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); lebedev.ri wrote: > >>! In D46281#1083806, @lebedev.ri

[PATCH] D46281: [clang-doc] Attaching a name to reference data

juliehockett updated this revision to Diff 144747. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addressing a fixme and updating tests https://reviews.llvm.org/D46281 Files: clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/Representation.h

[PATCH] D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode

svenvh updated this revision to Diff 144745. svenvh edited the summary of this revision. svenvh added a comment. Dropped the `asm` and `goto` restrictions from this patch for now until we have clarification from Khronos. Applied the `thread_local` restrictions to OpenCL C too.

[PATCH] D46323: [compiler-rt][X86][AMD][Bulldozer] Fix Bulldozer Model 2 detection.

lebedev.ri created this revision. lebedev.ri added reviewers: craig.topper, asbirlea, rnk, GGanesh, andreadb. Herald added subscribers: Sanitizers, JDevlieghere, arichardson, aprantl, dberris, sdardis. The compiler-rt side of https://reviews.llvm.org/D46314 I have discovered an issue by

[PATCH] D45611: [analyzer] Fix filename in cross-file HTML report

malcolm.parsons updated this revision to Diff 144742. malcolm.parsons added a comment. Add test Repository: rC Clang https://reviews.llvm.org/D45611 Files: lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp test/Coverage/html-multifile-diagnostics.c Index:

[PATCH] D46300: [Clang] Implement function attribute no_stack_protector.

srhines added a comment. Looks fine. Please wait for a more experienced person to review this, however. Thanks for adding this feature. Repository: rC Clang https://reviews.llvm.org/D46300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46320: Remove \brief commands from doxygen comments.

aprantl created this revision. aprantl added a reviewer: rsmith. Herald added subscribers: kbarton, aheejin, eraman, jgravelle-google, sbc100, nhaehnle, nemanjai, dschuff, jfb, jholewinski, klimek. Note that I did the same thing for LLVM this morning (https://reviews.llvm.org/D46290). We've

Re: r331244 - Implement P0482R2, support for char8_t type.

On Mon, Apr 30, 2018 at 10:02 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Apr 30 22:02:45 2018 > New Revision: 331244 > > URL: http://llvm.org/viewvc/llvm-project?rev=331244=rev > Log: > Implement P0482R2, support for char8_t type. > > This

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/MapSubscriptOperatorLookupCheck.cpp:25 + hasName("operator[]"), + ofClass(hasAnyName("::std::map", "::std::unordered_map", + hasParent(implicitCastExpr( I

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun added a comment. This checker is inspired by Louis Brandy's excellent CppCon 2017 talk (https://www.youtube.com/watch?v=lkgszkPnV8g) where he describes the side-effects of std::map::operator[] as being one of the most common source of bugs in Facebook's C++ code. In the talk he

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis updated this revision to Diff 144727. zinovy.nis added a comment. - Applied Alexander's changes. https://reviews.llvm.org/D45927 Files: clang-tidy/checks/modernize-use-auto.rst clang-tidy/modernize-use-auto-min-type-name-length.cpp modernize/UseAutoCheck.cpp Index:

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

jkorous added inline comments. Comment at: Sema/SemaDecl.cpp:4651-4653 + + DeclContext *OwnerScope = Owner->getRedeclContext(); + vsapsai wrote: > I think the code style favours avoiding excessive vertical whitespace and I > don't feel like this statement

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

jkorous marked an inline comment as done. jkorous added a comment. Volodymyr, could you please confirm that the non-anonymous vs non-inline logic makes sense to you? Comment at: Sema/SemaDecl.cpp:4659-4661 + (isa(OwnerScope) || + (isa(OwnerScope) && +

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun created this revision. khuttun added a reviewer: alexfh. Herald added subscribers: xazax.hun, mgorny. Warns on std::map and std::unordered_map lookups done with operator[]. Inserting values with operator[] is still allowed. Repository: rCTE Clang Tools Extra

[PATCH] D46293: [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()-style APIs

This revision was automatically updated to reflect the committed changes. benhamilton marked an inline comment as done. Closed by commit rL331268: [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()… (authored by benhamilton, committed by ). Herald added a subscriber:

[PATCH] D46206: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL331267: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r331267 - [clang-tidy] Add Apple prefix acronyms to objc-property-declaration

Author: benhamilton Date: Tue May 1 07:48:51 2018 New Revision: 331267 URL: http://llvm.org/viewvc/llvm-project?rev=331267=rev Log: [clang-tidy] Add Apple prefix acronyms to objc-property-declaration Summary: This adds a few common Apple first-party API prefixes as acronyms to

[clang-tools-extra] r331268 - [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()-style APIs

Author: benhamilton Date: Tue May 1 07:48:54 2018 New Revision: 331268 URL: http://llvm.org/viewvc/llvm-project?rev=331268=rev Log: [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()-style APIs Summary: The `google-runtime-int` check currently fires on calls like:

[PATCH] D46293: [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()-style APIs

benhamilton updated this revision to Diff 144717. benhamilton added a comment. Add another test for printf without attribute Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46293 Files: clang-tidy/google/IntegerTypesCheck.cpp test/clang-tidy/google-runtime-int.cpp Index:

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis added a comment. Gentle ping. https://reviews.llvm.org/D45932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46293: [clang-tidy/google-runtime-int] Allow passing non-bitwidth types to printf()-style APIs

benhamilton marked 2 inline comments as done. benhamilton added a comment. Thanks for the review. Added another test. Comment at: test/clang-tidy/google-runtime-int.cpp:77 +__attribute__((__format__ (__printf__, 1, 2))) +void myprintf(const char* s, ...); +

[PATCH] D46131: Add Microsoft Mangling for OpenCL Half Type

This revision was automatically updated to reflect the committed changes. Closed by commit rC331263: Add Microsoft Mangling for OpenCL Half Type (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D46131 Files: lib/AST/MicrosoftMangle.cpp

[PATCH] D46131: Add Microsoft Mangling for OpenCL Half Type

This revision was automatically updated to reflect the committed changes. Closed by commit rL331263: Add Microsoft Mangling for OpenCL Half Type (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331263 - Add Microsoft Mangling for OpenCL Half Type

Author: erichkeane Date: Tue May 1 07:16:15 2018 New Revision: 331263 URL: http://llvm.org/viewvc/llvm-project?rev=331263=rev Log: Add Microsoft Mangling for OpenCL Half Type Half-type mangling is accomplished following the method introduced by Erich Keane for mangling _Float16. Updated the

r331261 - [OPENMP] Emit template instatiation|specialization functions for

Author: abataev Date: Tue May 1 07:09:46 2018 New Revision: 331261 URL: http://llvm.org/viewvc/llvm-project?rev=331261=rev Log: [OPENMP] Emit template instatiation|specialization functions for devices. If the function is an instantiation|specialization of the template and is used in the device

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

mikhail.ramalho added a comment. Hi, > After thinking about this a bit, and use cases like rename and > find-declaration that could be USR based, I think including some location > information is the right way to go, which I think is the current behavior. What do you man by location

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho marked an inline comment as done. mikhail.ramalho added a comment. Ping. https://reviews.llvm.org/D36610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxxabi] r331150 - Move _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS macro to build system

tzik, can you take a look what's up on those bots? On Tue, May 1, 2018, 5:48 AM Maxim Kuvyrkov wrote: > Hi Nico, > > This broke armv7 and aarch64 bots: > - > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/87 > - >

[PATCH] D46308: [PATCH 2/3] [RFC only] clang implementation of sizeless types

rsandifo-arm created this revision. Herald added subscribers: cfe-commits, kristof.beyls, rengolin. Herald added a reviewer: javed.absar. `[ Not intended for commit. I'm just posting it to back up an RFC on cfe-dev. ] This patch adds the concept of "sizeless" types to core C and C++. It's a

[PATCH] D46307: [PATCH 1/3] [RFC only] Hack to add some sizeless built-in types

rsandifo-arm created this revision. Herald added subscribers: cfe-commits, rengolin. [ Not intended for commit. I'm just posting it to back up an RFC on cfe-dev. ] This patch is a hack to add two new "sizeless builtin" types __SVInt8_t and __SVInt16_t. The real SVE implementation looks

Re: [libcxxabi] r331150 - Move _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS macro to build system

Hi Nico, This broke armv7 and aarch64 bots: - http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/87 - http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/1304 Would you please investigate? -- Maxim Kuvyrkov www.linaro.org > On Apr

[PATCH] D46281: [clang-doc] Attaching a name to reference data

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:382 + emitRecord(R.USR, REFERENCE_USR); + emitRecord(R.Name, REFERENCE_NAME); + emitRecord((unsigned)R.RefType, REFERENCE_TYPE); >>! In D46281#1083806, @lebedev.ri wrote: > Global

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL331249: [X86] directstore and movdir64b intrinsics (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r331249 - [X86] directstore and movdir64b intrinsics

Author: gbuella Date: Tue May 1 03:05:42 2018 New Revision: 331249 URL: http://llvm.org/viewvc/llvm-project?rev=331249=rev Log: [X86] directstore and movdir64b intrinsics Reviewers: spatel, craig.topper, RKSimon Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D45984

[PATCH] D46281: [clang-doc] Attaching a name to reference data

lebedev.ri added a comment. Global question: you are using `NamedDecl::getNameAsString()`, and passing it as `StringRef`. You have looked at this with ASAN, and it's ok? Also, have you considered using the `NamedDecl::getName()`, which already returns `StringRef`.? Comment

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

chill added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D46013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46052: GNUstep Objective-C ABI version 2

theraven added inline comments. Comment at: lib/CodeGen/CGObjCGNU.cpp:439 + ArrayRef IvarOffsets, + ArrayRef IvarAlign, + ArrayRef IvarOwnership); DHowett-MSFT wrote: > While

Re: r331244 - Implement P0482R2, support for char8_t type.

Thanks, looks good. On Mon, 30 Apr 2018, 23:52 Chandler Carruth via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > I adjusted the test case in r331245 - it was failing for me and most of > the build bots. Please check that I didn't miss anything. > > On Mon, Apr 30, 2018 at 10:06 PM Richard

Re: r331244 - Implement P0482R2, support for char8_t type.

I adjusted the test case in r331245 - it was failing for me and most of the build bots. Please check that I didn't miss anything. On Mon, Apr 30, 2018 at 10:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Apr 30 22:02:45 2018 > New Revision:

r331245 - Fix up r331244 - the emitted definition is weak_odr linkage. Should get

Author: chandlerc Date: Mon Apr 30 23:48:30 2018 New Revision: 331245 URL: http://llvm.org/viewvc/llvm-project?rev=331245=rev Log: Fix up r331244 - the emitted definition is weak_odr linkage. Should get the build bots to healthy again without a full revert. As the functionality added has nothing