[PATCH] D47103: Implement strip.invariant.group

2018-05-21 Thread Krzysztof Pszeniczny via Phabricator via cfe-commits
amharc added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:778 + bool mayBeDynamicClass() const { +return !isCompleteDefinition() || isDynamicClass(); xbolva00 wrote: > maybeDynamicClass? > >

[libcxx] r332931 - Missed the tests for the deduction guides for prority_queue

2018-05-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 21 19:19:38 2018 New Revision: 332931 URL: http://llvm.org/viewvc/llvm-project?rev=332931=rev Log: Missed the tests for the deduction guides for prority_queue Added:

r332929 - [X86] Prevent inclusion of __wmmintrin_aes.h and __wmmintrin_pclmul.h without including wmmintrin.h

2018-05-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 21 19:02:13 2018 New Revision: 332929 URL: http://llvm.org/viewvc/llvm-project?rev=332929=rev Log: [X86] Prevent inclusion of __wmmintrin_aes.h and __wmmintrin_pclmul.h without including wmmintrin.h Modified: cfe/trunk/lib/Headers/__wmmintrin_aes.h

[libcxx] r332927 - Deduction guides for the container adaptors - queue, stack, and priority_queue

2018-05-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 21 18:57:53 2018 New Revision: 332927 URL: http://llvm.org/viewvc/llvm-project?rev=332927=rev Log: Deduction guides for the container adaptors - queue, stack, and priority_queue Added:

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

2018-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Headers/immintrin.h:72 -/* The 256-bit versions of functions in f16cintrin.h. - Intel documents these as being in immintrin.h, and Interesting this to note here, the 256-bit f16c intrinsics were being

[PATCH] D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering

2018-05-21 Thread Katya Romanova via Phabricator via cfe-commits
kromanova created this revision. Herald added a subscriber: cfe-commits. Below are a few doxygen intrisics documentation changes requested by our documentation team: (1) I added some \see cross-references to a few select intrinsics that are related (and have the same or very similar

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

2018-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, DavidKreitzer. Intel documents the 128-bit versions as being in emmintrin.h and the 256-bit version as being in immintrin.h. This patch makes a new __emmtrin_f16c.h to hold the 128-bit versions to be

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

2018-05-21 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D46919#1107296, @rsmith wrote: > In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > > > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > > > The deprecated enumerator is also referenced by > > >

[PATCH] D47099: Disable casting of alloca for ActiveFlag

2018-05-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 147914. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D47099 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D46439#1106929, @probinson wrote: > This wouldn't be another layout/ABI breakage, would it? Yes, albeit for what I'd expect to be an extremely rare case. Repository: rC Clang https://reviews.llvm.org/D46439

[PATCH] D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147902. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46979 Files: include/clang/AST/OperationKinds.def lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp

[PATCH] D46485: Add python tool to dump and construct header maps

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 147901. bruno added a comment. Remove more outdated comments https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m test/Preprocessor/Inputs/headermap-rel/foo.hmap

[PATCH] D46485: Add python tool to dump and construct header maps

2018-05-21 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Removing the binary header map files is a clear win, but I'd like someone else to approve this. Comment at: test/Preprocessor/headermap-rel2.c:1-2 // This uses a headermap with this entry: // someheader.h -> Product/someheader.h

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-21 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. Also we should make sure that all recursive transformations on expressions represented as DAGs should be memoized. Repository: rC Clang https://reviews.llvm.org/D47155 ___ cfe-commits mailing list

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I've done some more investigation, and I now think this patch is merely working around deficiencies elsewhere. See https://reviews.llvm.org/D47166, which aims to fix those deficiencies more directly. Repository: rC Clang https://reviews.llvm.org/D46241

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. >>> The warning is off by default. >> >> We typically do not add off-by-default warnings because experience has shown >> the rarely get enabled in practice. Can you explain a bit more about why >> this one is off by default? > > Right. I believe this is going

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added reviewers: rjmccall, sepavloff. Clang has two different ways it emits array constants (from `InitListExpr`s and from `APValue`s), and both had some ability to emit `zeroinitializer`, but neither was able to catch all cases where we could use

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. > See also PR22165. Nice, seems related to this indeed. Are you aware of any development along those lines in clang-tidy? We would like this to be part of clang and be used as part of the normal compiler workflow, it can surely be as well part of any clang-tidy

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

2018-05-21 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. LGTM with a couple additions. Comment at: lib/CodeGen/CodeGenTypes.cpp:448 +case BuiltinType::ULongAccum: ResultType = llvm::IntegerType::get(getLLVMContext(), static_cast(Context.getTypeSize(T)));

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

2018-05-21 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:29 + +class DanglingStringPointerChecker : public Checker { + CallDescription CStrFn; george.karpenkov wrote: > "string" is a bit ambiguous, if this checker

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

2018-05-21 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

2018-05-21 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:29 + +class DanglingStringPointerChecker : public Checker { + CallDescription CStrFn; "string" is a bit ambiguous, if this checker is specifically

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

2018-05-21 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 147887. jdenny marked 2 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made a stab at the suggested changes. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h

[PATCH] D47164: Add missing include for cstdint to Visibility.h

2018-05-21 Thread Raphael Isemann via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332913: Add missing include for cstdint to Visibility.h (authored by teemperor, committed by ). Herald added a

r332913 - Add missing include for cstdint to Visibility.h

2018-05-21 Thread Raphael Isemann via cfe-commits
Author: teemperor Date: Mon May 21 15:27:22 2018 New Revision: 332913 URL: http://llvm.org/viewvc/llvm-project?rev=332913=rev Log: Add missing include for cstdint to Visibility.h Summary: We use uint8_t in this header, so we need to include cstdint. Subscribers: cfe-commits Differential

[PATCH] D47164: Add missing include for cstdint to Visibility.h

2018-05-21 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor created this revision. We use uint8_t in this header, so we need to include cstdint. Repository: rC Clang https://reviews.llvm.org/D47164 Files: include/clang/Basic/Visibility.h Index: include/clang/Basic/Visibility.h

[PATCH] D46791: Make -gsplit-dwarf generally available

2018-05-21 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In https://reviews.llvm.org/D46791#1107168, @pcc wrote: > There were a bunch of them but the last one was > https://reviews.llvm.org/D47093 which has already landed :) > > Probably all that needs to happen on this change is to replace the isLinux() > check with

[PATCH] D46791: Make -gsplit-dwarf generally available

2018-05-21 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. There were a bunch of them but the last one was https://reviews.llvm.org/D47093 which has already landed :) Probably all that needs to happen on this change is to replace the isLinux() check with isELF(). https://reviews.llvm.org/D46791

[PATCH] D46963: [Fixed Point Arithmetic] Test for All Builtin Operations

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147888. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46963 Files: lib/AST/ASTContext.cpp lib/CodeGen/CGExprScalar.cpp test/Frontend/fixed_point_all_builtin_operations.c Index:

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-21 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @NoQ I'm really wary of magic numbers. - We should expose it through an analyzer-config flag. We already do so for the budget. - We should probably have both positive and negative tests. What scenarios _stop_ working after the threshold is decreased? [point 1

[PATCH] D46791: Make -gsplit-dwarf generally available

2018-05-21 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. Yeah I haven't heard back from Lexan nor have I tried reproducing such a build myself and if we're that close to not relaying on this sort of hack I'd much rather wait on this than risk breaking someone for the sake of a stopgap for such a short period of time.

r332911 - Add missing x86-registered-target.

2018-05-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon May 21 15:14:02 2018 New Revision: 332911 URL: http://llvm.org/viewvc/llvm-project?rev=332911=rev Log: Add missing x86-registered-target. Modified: cfe/trunk/test/Misc/cc1as-split-dwarf.s Modified: cfe/trunk/test/Misc/cc1as-split-dwarf.s URL:

r332909 - [X86] Remove a builtin that should have been removed in r332882.

2018-05-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 21 15:10:02 2018 New Revision: 332909 URL: http://llvm.org/viewvc/llvm-project?rev=332909=rev Log: [X86] Remove a builtin that should have been removed in r332882. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/test/CodeGen/builtins-x86.c

[PATCH] D46960: [Fixed Point Arithmetic] Predefined Precision Macros

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147883. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46960 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPMacroExpansion.cpp test/Frontend/fixed_point_builtin_macros.c Index:

[PATCH] D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147882. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46927 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/CodeGen/CGExprScalar.cpp lib/Sema/SemaExpr.cpp test/Frontend/fixed_point_validation.c

[PATCH] D46926: [Fixed Point Arithmetic] Conversion between Fixed Point and Floating Point Numbers

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147881. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46926 Files: include/clang/AST/OperationKinds.def include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/AST/ExprConstant.cpp

r332906 - Fix another make_unique ambiguity.

2018-05-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon May 21 14:48:17 2018 New Revision: 332906 URL: http://llvm.org/viewvc/llvm-project?rev=332906=rev Log: Fix another make_unique ambiguity. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[PATCH] D46925: [Fixed Point Arithmetic] Remaining Binary Operations on Primary Fixed Point Types

2018-05-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 147880. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46925 Files: include/clang/AST/ASTContext.h include/clang/AST/OperationKinds.def include/clang/AST/Type.h lib/AST/ASTContext.cpp

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:2074 + if (DoStore) { + auto DL = ApplyDebugLocation::CreateArtificial(*this); + EmitStoreOfScalar(ArgVal, lv, /* isInitialization */ true); Ideally this would precede the calls to CreateMemTemp

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Anastasis via Phabricator via cfe-commits
gramanas updated this revision to Diff 147876. gramanas added a comment. Update diff Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index: test/CodeGen/debug-info-preserve-scope.c

[libcxx] r332901 - Implement deduction guides for vector

2018-05-21 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 21 14:30:12 2018 New Revision: 332901 URL: http://llvm.org/viewvc/llvm-project?rev=332901=rev Log: Implement deduction guides for vector Added: libcxx/trunk/test/std/containers/sequences/vector/vector.cons/deduct.fail.cpp

[PATCH] D47099: Disable casting of alloca for ActiveFlag

2018-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:80 auto Alloca = CreateTempAlloca(Ty, Name, ArraySize); Alloca->setAlignment(Align.getQuantity()); if (AllocaAddr) Could you change this to call CreateTempAllocaWithoutCast?

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1414-1415 +Expr::EvalResult Result; +if (Init->EvaluateAsRValue(Result, CE.CGM.getContext()) && +!Result.hasUnacceptableSideEffect(Expr::SE_NoSideEffects)) + return (Result.Val.isInt()

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > The warning is off by default. We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default? Repository: rC Clang

[PATCH] D47161: update

2018-05-21 Thread Anastasis via Phabricator via cfe-commits
gramanas created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D47161 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index: test/CodeGen/debug-info-preserve-scope.c

[PATCH] D47125: [X86] Remove masking from pternlog llvm intrinsics and use a select instruction instead.

2018-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332891: [X86] Remove masking from pternlog llvm intrinsics and use a select instruction… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D47108: Add -fforce-emit-vtables

2018-05-21 Thread Krzysztof Pszeniczny via Phabricator via cfe-commits
amharc added a comment. I think that `MarkVTableUsed` should be called somewhere in Sema (possibly `ActOnFinishCXXMemberDecls`?) if `ForceEmitVTables` is on. This probably requires making `ForceEmitVTables` a `LangOption` in addition to it being a `CodeGenOption`. This causes the above

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. See also PR22165. Repository: rC Clang https://reviews.llvm.org/D47157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332891 - [X86] Remove masking from pternlog llvm intrinsics and use a select instruction instead.

2018-05-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 21 13:58:23 2018 New Revision: 332891 URL: http://llvm.org/viewvc/llvm-project?rev=332891=rev Log: [X86] Remove masking from pternlog llvm intrinsics and use a select instruction instead. Because the intrinsics in the headers are implemented as macros, we can't

[PATCH] D47099: Disable casting of alloca for ActiveFlag

2018-05-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 147860. yaxunl added a comment. Add CreateMemTempWithoutCast and CreateTempAllocaWithoutCast by John's comments. https://reviews.llvm.org/D47099 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGExpr.cpp

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
Reverted in r332886; I added a testcase for the miscompile below to test/CodeGenCXX/reference-init.cpp On 21 May 2018 at 13:28, Richard Smith wrote: > On 21 May 2018 at 13:22, Richard Smith wrote: > >> On 21 May 2018 at 09:09, Serge Pavlov via

r332886 - Revert r332847; it caused us to miscompile certain forms of reference initialization.

2018-05-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 21 13:36:58 2018 New Revision: 332886 URL: http://llvm.org/viewvc/llvm-project?rev=332886=rev Log: Revert r332847; it caused us to miscompile certain forms of reference initialization. Added: cfe/trunk/test/SemaCXX/large-array-init.cpp - copied unchanged

[PATCH] D47093: CodeGen, Driver: Start using direct split dwarf emission in clang.

2018-05-21 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC332885: CodeGen, Driver: Start using direct split dwarf emission in clang. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D47093?vs=147609=147858#toc Repository:

r332885 - CodeGen, Driver: Start using direct split dwarf emission in clang.

2018-05-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon May 21 13:31:59 2018 New Revision: 332885 URL: http://llvm.org/viewvc/llvm-project?rev=332885=rev Log: CodeGen, Driver: Start using direct split dwarf emission in clang. Fixes PR37466. Differential Revision: https://reviews.llvm.org/D47093 Added:

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
On 21 May 2018 at 13:22, Richard Smith wrote: > On 21 May 2018 at 09:09, Serge Pavlov via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: sepavloff >> Date: Mon May 21 09:09:54 2018 >> New Revision: 332847 >> >> URL:

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Depends on https://reviews.llvm.org/D46485 Repository: rC Clang https://reviews.llvm.org/D47157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46863: [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics.

2018-05-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC332882: [X86] Use __builtin_convertvector to implement some of the packed integer to… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D46863?vs=146750=147853#toc

r332882 - [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics.

2018-05-21 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 21 13:19:17 2018 New Revision: 332882 URL: http://llvm.org/viewvc/llvm-project?rev=332882=rev Log: [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics. I believe this is safe assuming default default FP

Re: r332847 - [CodeGen] Recognize more cases of zero initialization

2018-05-21 Thread Richard Smith via cfe-commits
On 21 May 2018 at 09:09, Serge Pavlov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sepavloff > Date: Mon May 21 09:09:54 2018 > New Revision: 332847 > > URL: http://llvm.org/viewvc/llvm-project?rev=332847=rev > Log: > [CodeGen] Recognize more cases of zero initialization > > If

[PATCH] D47157: Warning for framework headers using double quote includes

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno created this revision. bruno added reviewers: dexonsmith, ributzka, steven_wu. Introduce -Wquoted-include-in-framework-header, which should fire a warning whenever a quote include appears in a framework header, example, for A.h added in the tests: ... A.framework/Headers/A.h:2:10: warning:

[PATCH] D47089: CodeGen: Add a dwo output file argument to addPassesToEmitFile and hook it up to dwo output.

2018-05-21 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC332881: CodeGen: Add a dwo output file argument to addPassesToEmitFile and hook it up… (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r332881 - CodeGen: Add a dwo output file argument to addPassesToEmitFile and hook it up to dwo output.

2018-05-21 Thread Peter Collingbourne via cfe-commits
Author: pcc Date: Mon May 21 13:16:41 2018 New Revision: 332881 URL: http://llvm.org/viewvc/llvm-project?rev=332881=rev Log: CodeGen: Add a dwo output file argument to addPassesToEmitFile and hook it up to dwo output. Part of PR37466. Differential Revision: https://reviews.llvm.org/D47089

r332879 - Revert r332028; see PR37545 for details.

2018-05-21 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 21 13:10:54 2018 New Revision: 332879 URL: http://llvm.org/viewvc/llvm-project?rev=332879=rev Log: Revert r332028; see PR37545 for details. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/trunk/test/CodeGenCXX/rtti-linkage.cpp Modified:

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

2018-05-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a subscriber: andrew.w.kaylor. efriedma added a comment. I don't see any reason to exactly match the constant specified by the user, as long as the result is semantically equivalent. Once we have llvm.experimental.constrained.fcmp, this code should be updated to emit it; that

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

2018-05-21 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. This wouldn't be another layout/ABI breakage, would it? Repository: rC Clang https://reviews.llvm.org/D46439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47097: [WIP][DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:2062 EmitStoreOfScalar(ArgVal, lv, /* isInitialization */ true); +ApplyDebugLocation::CreateArtificial(*this); + } There are two issues here: 1) ApplyDebugLocation is a RAII helper, which

[PATCH] D47097: [WIP][DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Anastasis via Phabricator via cfe-commits
gramanas updated this revision to Diff 147840. gramanas marked an inline comment as done. gramanas added a comment. Update according to the comments Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index:

[PATCH] D47097: [WIP][DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Anastasis via Phabricator via cfe-commits
gramanas updated this revision to Diff 147838. gramanas added a comment. - Apply debug location Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index: test/CodeGen/debug-info-preserve-scope.c

[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

2018-05-21 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis updated this revision to Diff 147836. zinovy.nis edited the summary of this revision. zinovy.nis added a comment. - More accurate place to fix. https://reviews.llvm.org/D47122 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a reviewer: mikhail.ramalho. NoQ added a subscriber: mikhail.ramalho. NoQ added a comment. @mikhail.ramalho Does it solve your problems with ffmpeg as well? :) Repository: rC Clang https://reviews.llvm.org/D47155 ___ cfe-commits

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

2018-05-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Reported by Mikael Holmén on http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180416/225349.html - a

[PATCH] D47154: Try to make builtin address space declarations not useless

2018-05-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl, rjmccall. Herald added subscribers: tpr, nhaehnle, wdng. The way address space declarations for builtins currently work is nearly useless. The code assumes the address spaces used for builtins is a confusingly named "target

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif rnk wrote: > GBuella wrote: > > GBuella wrote: > > > rnk wrote: > > > > craig.topper wrote: > > > > > @rnk, what's the right thing to

[PATCH] D46863: [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics.

2018-05-21 Thread David Kreitzer via Phabricator via cfe-commits
DavidKreitzer accepted this revision. DavidKreitzer added a comment. This revision is now accepted and ready to land. I had actually done that as part of my initial review, so LGTM. Repository: rC Clang https://reviews.llvm.org/D46863 ___

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

2018-05-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D44539#1106802, @rjmccall wrote: > In https://reviews.llvm.org/D44539#1106443, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D44539#1106152, @rjmccall wrote: > > > > > This was approved by the Objective-C language group as a

[PATCH] D46485: Add python tool to dump and construct header maps

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno updated this revision to Diff 147829. bruno added a comment. Update testcases (and fixed a missing one) after Duncan's review. https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

2018-05-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This looks great, i think we should make a single super simple mock test and commit this. @MTC, i really appreciate your help! Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:59 + QualType RegType = TypedR->getValueType(); + if

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

2018-05-21 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D44539#1106443, @aaron.ballman wrote: > In https://reviews.llvm.org/D44539#1106152, @rjmccall wrote: > > > This was approved by the Objective-C language group as a default-off > > warning. > > > We usually do not expose new default-off

r332854 - [Clang Tablegen] Add llvm_unreachable() to getModifierName()

2018-05-21 Thread Mark Searles via cfe-commits
Author: msearles Date: Mon May 21 10:29:08 2018 New Revision: 332854 URL: http://llvm.org/viewvc/llvm-project?rev=332854=rev Log: [Clang Tablegen] Add llvm_unreachable() to getModifierName() Fix internal build failure: ../../../ClangDiagnosticsEmitter.cpp -o ClangDiagnosticsEmitter.o

r332848 - [AMDGPU] fixes for lds f32 builtins

2018-05-21 Thread Daniil Fukalov via cfe-commits
Author: dfukalov Date: Mon May 21 09:18:07 2018 New Revision: 332848 URL: http://llvm.org/viewvc/llvm-project?rev=332848=rev Log: [AMDGPU] fixes for lds f32 builtins 1. added restrictions to memory scope, order and volatile parameters 2. added custom processing for these builtins - currently is

[PATCH] D46863: [X86] Use __builtin_convertvector to implement some of the packed integer to packed float conversion intrinsics.

2018-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. So I think we've covered the whether this is ok to do questions. If someone can double check signed/unsigned and vector element sizes are all correct and approve this that would be great. Repository: rC Clang https://reviews.llvm.org/D46863

[PATCH] D47118: [modules] Print input files when -module-file-info file switch is passed.

2018-05-21 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Thanks for improving this Vassil. Where does in the output it shows up? I wonder if we should have those at the end given the huge amount of headers some modules might have. Repository: rC Clang https://reviews.llvm.org/D47118

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

2018-05-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. I think you can pass StringRef(F).substr(1). That won't create a temporary string. It will just create a StringRef pointing into the middle of an existing std::string stored in the parsed attributes. https://reviews.llvm.org/D46541

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

2018-05-21 Thread Mark Searles via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName() (authored by msearles, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

2018-05-21 Thread Mark Searles via Phabricator via cfe-commits
msearles updated this revision to Diff 147809. msearles added a comment. Add comment per reviewer suggestion. https://reviews.llvm.org/D47150 Files: utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnosticsEmitter.cpp

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

2018-05-21 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:495 } + llvm_unreachable("invalid modifier type"); } Perhaps this should say "unhandled

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif GBuella wrote: > rnk wrote: > > craig.topper wrote: > > > @rnk, what's the right thing to do here? > > What problems does this

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif GBuella wrote: > GBuella wrote: > > rnk wrote: > > > craig.topper wrote: > > > > @rnk, what's the right thing to do here? > > > What

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif rnk wrote: > craig.topper wrote: > > @rnk, what's the right thing to do here? > What problems does this redeclaration cause? Now that I

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Gabor Buella via Phabricator via cfe-commits
GBuella added a comment. In https://reviews.llvm.org/D47142#1106664, @rnk wrote: > Why do we need a feature flag for this in the first place? The MSVC model for > most "instruction" intrinsics is that the exact instruction is emitted > regardless of the feature enabled. The target attribute

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

2018-05-21 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. Hmm... Thanks for these tips. I'll see what I can find. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

2018-05-21 Thread Mark Searles via Phabricator via cfe-commits
msearles updated this revision to Diff 147807. msearles retitled this revision from "[Clang Tablegen] Add default case to getModifierName()" to "[Clang Tablegen] Add llvm_unreachable() to getModifierName()". msearles added a comment. Ah, yes. Adding llvm_unreachable() is better. Done.

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

2018-05-21 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs added a comment. Adding a preliminary test file. F6259981: tests.cpp Repository: rC Clang https://reviews.llvm.org/D47135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47125: [X86] Remove masking from pternlog llvm intrinsics and use a select instruction instead.

2018-05-21 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - I'd love to see constexpr arguments someday in C/C++ to avoid all of these macro shenanigans... Repository: rC Clang https://reviews.llvm.org/D47125

[PATCH] D47150: [Clang Tablegen] Add default case to getModifierName()

2018-05-21 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Please instead add an `llvm_unreachable` outside the switch, so that we still get warnings on missing switch cases if an enumerator is added. https://reviews.llvm.org/D47150 ___ cfe-commits mailing list

[PATCH] D47142: [x86] invpcid intrinsic

2018-05-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Why do we need a feature flag for this in the first place? The MSVC model for most "instruction" intrinsics is that the exact instruction is emitted regardless of the feature enabled. The target attribute seems like it would get in the way of that.

[PATCH] D47150: [Clang Tablegen] Add default case to getModifierName()

2018-05-21 Thread Mark Searles via Phabricator via cfe-commits
msearles created this revision. msearles added reviewers: b-sumner, kzhuravl, EricWF, rjmccall. Herald added subscribers: ioeric, ilya-biryukov. Fix internal build failure: ../../../ClangDiagnosticsEmitter.cpp -o ClangDiagnosticsEmitter.o ../../../ClangDiagnosticsEmitter.cpp: In function

[PATCH] D47097: [WIP][DebugInfo] Preserve scope in auto generated StoreInst

2018-05-21 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. I think CodeGenFunction::EmitParmDecl is the right place to set up an ApplyDebugLocation instance. You can look at CodeGenFunction::EmitAutoVarInit for an example of how to use ApplyDebugLocation. Comment at: test/CodeGen/debug-info-preserve-scope.c:1

r332852 - [OPENMP-SIMD] Fix PR37536: Fix definition of _OPENMP macro.

2018-05-21 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon May 21 09:40:32 2018 New Revision: 332852 URL: http://llvm.org/viewvc/llvm-project?rev=332852=rev Log: [OPENMP-SIMD] Fix PR37536: Fix definition of _OPENMP macro. if `-fopenmp-simd` is specified alone, `_OPENMP` macro should not be defined. If `-fopenmp-simd` is

  1   2   >