[PATCH] D47643: Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

malaperle added a comment. In https://reviews.llvm.org/D47643#1120913, @ilya-biryukov wrote: > PS I've checked it on my Mac and lldb seems to attach just fine. Working fine in my setup too! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47643

[PATCH] D47694: [CUDA][HIP] Do not emit type info when compiling for device

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D47694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47759: [Format] Do not use a global static value for EOF within ScopedMacroState.

dlj created this revision. dlj added a reviewer: djasper. dlj added a project: clang. Herald added a subscriber: klimek. ScopedMacroState injects its own EOF token under certain conditions, and the returned token may be modified in several different locations. If multiple reformat operations are

r333980 - [X86] Mark all the builtins and intrinsics that require MMX and an SSE feature as requiring both mmx and the sse feature.

Author: ctopper Date: Mon Jun 4 20:12:14 2018 New Revision: 333980 URL: http://llvm.org/viewvc/llvm-project?rev=333980=rev Log: [X86] Mark all the builtins and intrinsics that require MMX and an SSE feature as requiring both mmx and the sse feature. Previously we only checked the sse feature,

[PATCH] D47758: [Fuchsia] Include install-distribution-stripped in bootstrap targets

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett. Herald added subscribers: cfe-commits, mgorny. This enables the use of install-distribution-stripped target in the 2-stage builds. Repository: rC Clang https://reviews.llvm.org/D47758 Files:

[PATCH] D47757: [Sema] Diagnose unavailable aligned deallocation functions called from deleting destructors.

ahatanak created this revision. ahatanak added reviewers: rsmith, vsapsai, EricWF, erik.pilkington. Deallocation functions are called from deleting destructors that are declared virtual. Issue an error if an aligned deallocation function is selected but is not available. Repository: rC

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

ahatanak added a comment. I see, thank you. clang front-end currently fails to issue a warning or error when an aligned allocation/deallocation functions are required but not available in a few cases (e.g., delete called from a deleting destructor, calls to operator or builtin operator

[PATCH] D47668: [Driver][Fuchsia] Pass LTO flags to linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL333979: [Driver][Fuchsia] Pass LTO flags to linker (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r333979 - [Driver][Fuchsia] Pass LTO flags to linker

Author: phosek Date: Mon Jun 4 18:50:59 2018 New Revision: 333979 URL: http://llvm.org/viewvc/llvm-project?rev=333979=rev Log: [Driver][Fuchsia] Pass LTO flags to linker Even though we use lld by default for Fuchsia, we use Gold plugin arguments like all other drivers as lld supports Gold

[PATCH] D47694: [CUDA][HIP] Do not emit type info when compiling for device

yaxunl updated this revision to Diff 149892. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D47694 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/device-vtable.cu Index: test/CodeGenCUDA/device-vtable.cu

r333978 - Reimplement the bittest intrinsic family as builtins with inline asm

Author: rnk Date: Mon Jun 4 18:33:40 2018 New Revision: 333978 URL: http://llvm.org/viewvc/llvm-project?rev=333978=rev Log: Reimplement the bittest intrinsic family as builtins with inline asm We need to implement _interlockedbittestandset as a builtin for windows.h, so we might as well do the

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

george.karpenkov added a comment. > I agree, though a number of these are limitations in CSA, and not > specifically the backend. Yeah, so for instance we always assume that for a given state we know whether it's feasible or not, and IMO for efficient SMT solver support we would need to

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

ddcc added a comment. > @ddcc To be completely honest, I see a few design issues with the current > implementation of Z3 backend, > the main one being that it checks satisfiability after every single exploded > node. > To the best of my knowledge, reasonable scalability would not be achieved

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

george.karpenkov added a subscriber: mikhail.ramalho. george.karpenkov added a comment. @ddcc To be completely honest, I see a few design issues with the current implementation of Z3 backend, the main one being that it checks satisfiability after every single exploded node. To the best of my

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

This revision was automatically updated to reflect the committed changes. Closed by commit rL333969: [clang-proto-fuzzer] Refactored LLVMFuzzerInitialize into its own file. (authored by morehouse, committed by ). Changed prior to commit: https://reviews.llvm.org/D47666?vs=149872=149876#toc

r333969 - [clang-proto-fuzzer] Refactored LLVMFuzzerInitialize into its own file.

Author: morehouse Date: Mon Jun 4 17:11:41 2018 New Revision: 333969 URL: http://llvm.org/viewvc/llvm-project?rev=333969=rev Log: [clang-proto-fuzzer] Refactored LLVMFuzzerInitialize into its own file. Copied and renamed some files in preparation for new loop-proto-fuzzer. Patch By:

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

jkorous accepted this revision. jkorous added a comment. LGTM. Thank you for the explanation! Repository: rC Clang https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse accepted this revision. morehouse added a comment. LGTM. Repository: rC Clang https://reviews.llvm.org/D47666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149872. emmettneyman added a comment. - Removed unecessary includes and renamed library. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1121581, @ahatanak wrote: > Could you elaborate on what kind of changes you are planning to make in > libc++ after committing this patch? Libc++ shouldn't actually need any changes if this current patch lands. Currently libc++ is in

[PATCH] D46042: Cap vector alignment at 16 for all Darwin platforms

rnk added a comment. By the way, I went ahead and reverted this in r333958. Repository: rC Clang https://reviews.llvm.org/D46042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse added inline comments. Comment at: tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:23 #include I think `cstring` is no longer used after this change. So we can probably remove this include. Comment at:

[PATCH] D46700: [ThinLTO] Add testing of new summary index format to a couple CFI tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL333966: [ThinLTO] Add testing of new summary index format to a couple CFI tests (authored by tejohnson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r333966 - [ThinLTO] Add testing of new summary index format to a couple CFI tests

Author: tejohnson Date: Mon Jun 4 16:05:24 2018 New Revision: 333966 URL: http://llvm.org/viewvc/llvm-project?rev=333966=rev Log: [ThinLTO] Add testing of new summary index format to a couple CFI tests Summary: Adds testing of combined index summary entries in disassembly format to CFI tests

[PATCH] D47554: [analyzer] Check for dead/impossible status checks

trixirt updated this revision to Diff 149868. trixirt added a comment. Herald added a subscriber: klimek. Convert to AST Visitor Remove Ctx parameter from shouldNullCheckAllocation Add a shouldNullCheckAllocation ASTMatcher Repository: rC Clang https://reviews.llvm.org/D47554 Files:

[PATCH] D46042: Cap vector alignment at 16 for all Darwin platforms

rnk added a comment. In https://reviews.llvm.org/D46042#1121674, @rjmccall wrote: > > I think we should revert this for now. Adding the alignment attribute to > > all Intel vector typedefs is a bigger change than it seems. > > Ugh. That is just an awful language rule. Would it be reasonable

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149867. emmettneyman added a comment. - Refactored FuzzerInitialize into library Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47694: [CUDA][HIP] Do not emit type info when compiling for device

rjmccall added a comment. Oh, I see, because you're worried that the host code might contain `dynamic_cast` or similar features which would complain if RTTI were disabled. `getLangOpts().CUDAIsDevice` implies `getLangOpts().CUDA`, so I think you can just check the former. Otherwise LGTM.

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, We can try this, then. Repository: rC Clang https://reviews.llvm.org/D47564 ___ cfe-commits mailing list

[PATCH] D46042: Cap vector alignment at 16 for all Darwin platforms

rjmccall added a comment. In https://reviews.llvm.org/D46042#1121648, @rnk wrote: > It's the typedef alignment changes that are causing problems for us, not the > MaxVectorAlign changes. That makes more sense. The new alignment attribute > breaks our implementation of `_mm256_loadu_ps`,

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

morehouse added inline comments. Comment at: tools/clang-fuzzer/CMakeLists.txt:48 ExampleClangProtoFuzzer.cpp +FuzzerInitialize.cpp ) Rather than compiling `FuzzerInitialize.cpp` into the binary, can we make it a library like `handle-cxx` or

[PATCH] D47291: Proposal to make rtti errors more generic.

wristow added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; Sunil_Srivastava wrote: >

r333958 - Revert r333791 "Cap "voluntary" vector alignment at 16 for all Darwin platforms."

Author: rnk Date: Mon Jun 4 14:39:20 2018 New Revision: 333958 URL: http://llvm.org/viewvc/llvm-project?rev=333958=rev Log: Revert r333791 "Cap "voluntary" vector alignment at 16 for all Darwin platforms." Adding __attribute__((aligned(32))) to __m256 breaks the implementation of

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman added a comment. In https://reviews.llvm.org/D47666#1121608, @emmettneyman wrote: > - Updated and added header comments to two new files. Deleted loop fuzzer > files. I will commit the loop fuzzer files in a future patch. Repository: rC Clang https://reviews.llvm.org/D47666

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 149856. juliehockett marked 4 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Generators.cpp clang-doc/Generators.h clang-doc/Representation.h

[PATCH] D46700: [ThinLTO] Add testing of new summary index format to a couple CFI tests

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149854. emmettneyman added a comment. - Another edit to the file header comments. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D46042: Cap vector alignment at 16 for all Darwin platforms

rnk added a comment. It's the typedef alignment changes that are causing problems for us, not the MaxVectorAlign changes. That makes more sense. The new alignment attribute breaks our implementation of `_mm256_loadu_ps`, because the packed struct ends up with a 32-byte alignment. Here's the

r333955 - Update for an LLVM header file move

Author: dblaikie Date: Mon Jun 4 14:23:29 2018 New Revision: 333955 URL: http://llvm.org/viewvc/llvm-project?rev=333955=rev Log: Update for an LLVM header file move Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; probinson wrote:

[PATCH] D46700: [ThinLTO] Add testing of new summary index format to a couple CFI tests

tejohnson added a comment. Herald added a subscriber: steven_wu. ping Repository: rC Clang https://reviews.llvm.org/D46700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46042: Cap vector alignment at 16 for all Darwin platforms

rnk added a comment. This change appears to have caused some blink vector math unit tests to fail on Windows. We are tracking it at https://crbug.com/849251. It has a pretty small reproducer: #include __m256 loadit(__m256 *p) { return _mm256_loadu_ps((const float *)p); } Compile for

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149851. emmettneyman added a comment. - Fixed file header comment Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149850. emmettneyman added a comment. - Updated and added header comments to two new files. Deleted loop fuzzer files. Repository: rC Clang https://reviews.llvm.org/D47666 Files: tools/clang-fuzzer/CMakeLists.txt

[PATCH] D47607: [libcxx] Almost fix some UB in and

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL333948: Fix a strict aliasing violation in map and unordered_map. (authored by epilk, committed by ). Herald added a

[libcxx] r333948 - Fix a strict aliasing violation in map and unordered_map.

Author: epilk Date: Mon Jun 4 13:38:23 2018 New Revision: 333948 URL: http://llvm.org/viewvc/llvm-project?rev=333948=rev Log: Fix a strict aliasing violation in map and unordered_map. These containers type-punned between pair and pair as an optimization. This commit instead provides access to

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

ahatanak added a comment. Could you elaborate on what kind of changes you are planning to make in libc++ after committing this patch? https://reviews.llvm.org/D45015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47671: [analyzer] Implement copy elision.

xazax.hun added a comment. So having an analyzer-config option would be useful for those codebases that are expected to be compiled with less advanced compilers that do not elide copies or not doing it aggressively enough. Maybe it is worth to ask on the mailing list of the community wants to

[PATCH] D47668: [Driver][Fuchsia] Pass LTO flags to linker

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D47668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44239: [analyzer] Re-enable constructor inlining when lifetime extension through fields occurs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333946: [analyzer] Re-enable constructors when lifetime extension through fields occurs. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44239 Files:

r333946 - [analyzer] Re-enable constructors when lifetime extension through fields occurs.

Author: dergachev Date: Mon Jun 4 13:18:37 2018 New Revision: 333946 URL: http://llvm.org/viewvc/llvm-project?rev=333946=rev Log: [analyzer] Re-enable constructors when lifetime extension through fields occurs. Temporary object constructor inlining was disabled in r326240 for code like

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: tools/clang-fuzzer/FuzzerInitialize.cpp:11 /// \file /// This file implements a function that runs Clang on a single /// input and uses

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

ddcc added a subscriber: dcoughlin. ddcc added a comment. In https://reviews.llvm.org/D47726#1121395, @george.karpenkov wrote: > - Do all tests for Z3 run when LLVM is configured to use Z3? I'm not sure if > that's the right thing: do all tests start to take 10x time to run once Z3 is >

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

smeenai added a comment. In https://reviews.llvm.org/D47564#1119925, @rjmccall wrote: > In https://reviews.llvm.org/D47564#1119874, @smeenai wrote: > > > In https://reviews.llvm.org/D47564#1118424, @rjmccall wrote: > > > > > No, it was just a general question. Have you gotten this to a point >

[PATCH] D47737: [clangd] Remove unused variables

malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, klimek. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47737 Files: clangd/ClangdServer.cpp Index: clangd/ClangdServer.cpp

r333944 - [X86] Avoid passing _mm_undefined* to builtin_shufflevector if we are able to pass the first input a second time.

Author: ctopper Date: Mon Jun 4 12:28:09 2018 New Revision: 333944 URL: http://llvm.org/viewvc/llvm-project?rev=333944=rev Log: [X86] Avoid passing _mm_undefined* to builtin_shufflevector if we are able to pass the first input a second time. This is more consistent with other usages of

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 149825. lichray added a comment. Refine coding style Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Seems to be good to merge regardless. Repository: rC Clang https://reviews.llvm.org/D47726 ___ cfe-commits mailing list

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

george.karpenkov added a comment. Impressive, really. So almost all tests still pass. However, a few questions should be resolved before we can merge: - Do all tests for Z3 run when LLVM is configured to use Z3? I'm not sure if that's the right thing: do all tests start to take 10x time to run

[PATCH] D47617: [Analyzer] Fix Z3ConstraintManager crash (PR37646)

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D47617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 149824. lichray added a comment. Preserve value category in narrowing test. Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp

r333941 - [CFG] Fix automatic destructors when a member is bound to a reference.

Author: dergachev Date: Mon Jun 4 11:56:25 2018 New Revision: 333941 URL: http://llvm.org/viewvc/llvm-project?rev=333941=rev Log: [CFG] Fix automatic destructors when a member is bound to a reference. In code like const int = A().x; automatic destructor for the object A()

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333941: [CFG] Fix automatic destructors when a member is bound to a reference. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44238 Files:

[PATCH] D47620: Remove llvm::Triple argument from get***Personality() functions. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333938: Remove llvm::Triple argument from get***Personality() functions. NFC. (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D47620?vs=149406=149814#toc

r333938 - Remove llvm::Triple argument from get***Personality() functions. NFC.

Author: aheejin Date: Mon Jun 4 11:23:00 2018 New Revision: 333938 URL: http://llvm.org/viewvc/llvm-project?rev=333938=rev Log: Remove llvm::Triple argument from get***Personality() functions. NFC. Summary: Because `llvm::Triple` can be derived from `TargetInfo`, it is simpler to take only

[PATCH] D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS

aheejin abandoned this revision. aheejin added a comment. Oh I see, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47733: [CUDA][HIP] Set kernel calling convention before arrange function

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Currently clang set kernel calling convention for CUDA/HIP after arranging function, which causes incorrect kernel function type since it depends on calling convention. This patch moves setting kernel convention before

[PATCH] D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS

juliehockett added a comment. Already fixed in https://reviews.llvm.org/rL333936, sorry! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r333936 - [clang-doc] Adding missing dependencies to fix linker error on bot

Author: juliehockett Date: Mon Jun 4 11:18:00 2018 New Revision: 333936 URL: http://llvm.org/viewvc/llvm-project?rev=333936=rev Log: [clang-doc] Adding missing dependencies to fix linker error on bot Modified: clang-tools-extra/trunk/clang-doc/CMakeLists.txt Modified:

[PATCH] D47732: [clang-doc] Add BitReader to LLVM_LINK_COMPONENTS

aheejin created this revision. aheejin added a reviewer: juliehockett. Herald added subscribers: cfe-commits, mgorny, klimek. Without this, build with `-DSHARED_LIB=ON` fails. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47732 Files: clang-doc/CMakeLists.txt Index:

[PATCH] D47532: [ASTImporter] Import the whole redecl chain of functions

a.sidorin added a comment. Hello Gabor, This patch is really cool. Unfortunately, right now I don't have enough time for reviewing large patches in a single review. Are you OK with incremental review? Comment at: lib/AST/ASTImporter.cpp:75 + template + llvm::SmallVector

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

(Cost as in "shared library buildsof clang are ~35% slower than regular clang" last we checked.) On Mon, Jun 4, 2018 at 2:14 PM, Nico Weber wrote: > Sure, the bots could do that, the more general point was that many > (probably most) people who want to enable asserts don't want to use shared >

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Sure, the bots could do that, the more general point was that many (probably most) people who want to enable asserts don't want to use shared libs. I believe that only a few people use that config, so turning things around why should everyone building with asserts have to pay the cost of

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

jfb added a comment. In https://reviews.llvm.org/D46024#1121242, @rkirsling wrote: > FWIW, please note that this space-before-brace style is not specific to > WebKit; CppCoreGuidelines exhibits it as well: > >

[PATCH] D47666: Refactored clang-fuzzer and added new (copy) files

emmettneyman updated this revision to Diff 149807. emmettneyman added a comment. - Changed CLArgs into getter and deleted commented code 1. Updating https://reviews.llvm.org/D47666: Refactored clang-fuzzer and added new (copy) files # 2. Enter a brief description of the changes included in this

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. FWIW, please note that this space-before-brace style is not specific to WebKit; CppCoreGuidelines exhibits it as well: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax Repository: rC Clang

[PATCH] D47628: Detect an incompatible VLA pointer assignment

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

This revision was automatically updated to reflect the committed changes. Closed by commit rL333932: [clang-doc] Implement reducer portion of the frontend framework (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r333932 - [clang-doc] Implement reducer portion of the frontend framework

Author: juliehockett Date: Mon Jun 4 10:22:20 2018 New Revision: 333932 URL: http://llvm.org/viewvc/llvm-project?rev=333932=rev Log: [clang-doc] Implement reducer portion of the frontend framework Implements a simple, in-memory reducer for the mapped output of the initial tool. This creates a

[PATCH] D47401: [X86] Rewrite the max and min reduction intrinsics to make better use of other functions and to reduce width to 256 and 128 bits were possible.

craig.topper added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D47401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

rnk added subscribers: craig.topper, chandlerc. rnk added a comment. I read up a little bit on TSX and HLE: https://software.intel.com/en-us/node/524022 https://en.wikipedia.org/wiki/Transactional_Synchronization_Extensions These HLE variants of the usual atomic exchange intrinsics add the

[PATCH] D47617: [Analyzer] Fix Z3ConstraintManager crash (PR37646)

vlad.tsyrklevich updated this revision to Diff 149796. vlad.tsyrklevich added a comment. - Merge test with apsint.c and move to z3/apsint.c Repository: rC Clang https://reviews.llvm.org/D47617 Files: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp test/Analysis/apsint.c

[PATCH] D47620: Remove llvm::Triple argument from get***Personality() functions. NFC.

aheejin added a comment. @sbc100 ping :) Repository: rC Clang https://reviews.llvm.org/D47620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

Hi Roman – I agree that people shouldn’t need to manually fix this every time it happens. Hi Nico – What is stopping the Chromium buildbots from setting BUILD_SHARED_LIBS to false? That way the default BUILD_SHARED_LIBS policy of llvm and/or clang doesn’t matter, right? Dave > On Jun 4,

Re: r333923 - This diff includes changes for supporting the following types.

Sorry. I did not notice this. I will be sure to add the title from the phabricator review as the first line next time. On Mon, Jun 4, 2018 at 9:44 AM Roman Lebedev wrote: > > Did you use `arc patch` to get the commit description? > Please make sure that the first line of the commit is reasonable.

Re: r333923 - This diff includes changes for supporting the following types.

Did you use `arc patch` to get the commit description? Please make sure that the first line of the commit is reasonable. In this case it is not reasonable. On Mon, Jun 4, 2018 at 7:07 PM, Leonard Chan via cfe-commits wrote: > Author: leonardchan > Date: Mon Jun 4 09:07:52 2018 > New Revision:

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: george.karpenkov, NoQ, ddcc. Herald added subscribers: cfe-commits, a.sidorin, zzheng, szepet, xazax.hun. Since Z3 tests have been not been running [1] some tests needed to be updated. I also added a regression test for

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

This is n-th time i do this kind of fix. Sure this does resolve the issue, but it would be much better to use proper means, and tell people to fix their code, in an automatic way :) On Mon, Jun 4, 2018 at 7:36 PM, Nico Weber wrote: > All chromium bots build with asserts on and we definitely

Re: r333874 - Reland "Move #include manipulation code to new lib/Tooling/Inclusions."

All chromium bots build with asserts on and we definitely don't want shared libs :-) Having the people who care about this build config make sure it keeps working seems like a good approach to me. On Mon, Jun 4, 2018 at 8:15 AM, David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote:

[PATCH] D47694: [CUDA][HIP] Do not emit type info when compiling for device

yaxunl added a comment. In https://reviews.llvm.org/D47694#1121037, @rjmccall wrote: > In https://reviews.llvm.org/D47694#1120375, @yaxunl wrote: > > > In https://reviews.llvm.org/D47694#1120367, @rjmccall wrote: > > > > > Why not just have the driver disable RTTI in the frontend invocation? > >

[PATCH] D47687: fix: [Bug 18971] - Missing -Wparentheses warning

rnk added a comment. I'm in favor of this direction. The `var || var && truth_constant` pattern match seems much more robust than the macro pattern match. It's also consistent with what we do outside of macros, so it's less special and surprising. https://reviews.llvm.org/D47687

r333923 - This diff includes changes for supporting the following types.

Author: leonardchan Date: Mon Jun 4 09:07:52 2018 New Revision: 333923 URL: http://llvm.org/viewvc/llvm-project?rev=333923=rev Log: This diff includes changes for supporting the following types. // Primary fixed point types signed short _Accum s_short_accum; signed _Accum s_accum; signed long

[PATCH] D47592: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. I think this looks ok now, just some nits inline. Can you please upload your diffs with more context next time? Comment at: utils/TableGen/NeonEmitter.cpp:2166

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl added a comment. In https://reviews.llvm.org/D46421#1119098, @xazax.hun wrote: > Sorry for the limited activity. Unfortunately, I have very little time > reviewing patches lately. Thanks for getting around to it! > I think we need to answer the following questions: > > - Does this

[PATCH] D47724: [X86] Add back _mask, _maskz, and _mask3 builtins for some 512-bit fmadd/fmsub/fmaddsub/fmsubadd builtins.

craig.topper created this revision. craig.topper added reviewers: tkrupa, RKSimon, spatel, GBuella. We recently switch to using a selects in the intrinsics header files for FMA instructions. But the 512-bit versions support flavors with rounding mode which must be an Integer Constant

[libcxxabi] r333916 - Creating release candidate rc2 from release_601 branch

Author: tstellar Date: Mon Jun 4 08:53:32 2018 New Revision: 333916 URL: http://llvm.org/viewvc/llvm-project?rev=333916=rev Log: Creating release candidate rc2 from release_601 branch Added: libcxxabi/tags/RELEASE_601/rc2/ - copied from r333915, libcxxabi/branches/release_60/

[libunwind] r333922 - Creating release candidate rc2 from release_601 branch

Author: tstellar Date: Mon Jun 4 08:54:00 2018 New Revision: 333922 URL: http://llvm.org/viewvc/llvm-project?rev=333922=rev Log: Creating release candidate rc2 from release_601 branch Added: libunwind/tags/RELEASE_601/rc2/ - copied from r333921, libunwind/branches/release_60/

[libcxx] r333915 - Creating release candidate rc2 from release_601 branch

Author: tstellar Date: Mon Jun 4 08:53:28 2018 New Revision: 333915 URL: http://llvm.org/viewvc/llvm-project?rev=333915=rev Log: Creating release candidate rc2 from release_601 branch Added: libcxx/tags/RELEASE_601/rc2/ (props changed) - copied from r333914,

[PATCH] D47720: [DebugInfo] Inline for without DebugLocation

aprantl added inline comments. Comment at: test/CodeGen/debug-info-inline-for.c:2 +// RUN: %clang_cc1 -debug-info-kind=limited -emit-llvm -o - %s | FileCheck %s + +int func(int n) { Please add a comment explaining what is being tested here. Repository: rC

[PATCH] D47617: [Analyzer] Fix Z3ConstraintManager crash (PR37646)

vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D47617#1119268, @NoQ wrote: > Also does this test need to be z3-specific? We would also not like to crash > here without z3. I originally did that so I could specify enabling and testing the z3 backend; however, looking at the

  1   2   >