mgorny added reviewers: dvyukov, eugenis.
mgorny added a comment.
Ping. This is necessary to resolve
https://github.com/google/sanitizers/issues/974 and fix tests on systems which
don't enable all the backwards compatibility cruft (Arch, Gentoo). See also
https://reviews.llvm.org/D47817 as nece
Author: phosek
Date: Tue Jun 26 22:50:43 2018
New Revision: 335708
URL: http://llvm.org/viewvc/llvm-project?rev=335708&view=rev
Log:
[CMake] Support passing FUCHSIA_SDK as the only variable
Now that the structure of Fuchsia SDK has been formalized, we no
longer need to pass all the different CFLA
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335708: [CMake] Support passing FUCHSIA_SDK as the only
variable (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48564?vs
mclow.lists updated this revision to Diff 153001.
mclow.lists added a comment.
Updated the `__is_allocator` type trait to work all the way back to C++03
Added a bunch of tests from issue2946.
I think this has all the pieces that it needs now.
https://reviews.llvm.org/D48616
Files:
include/me
malaperle planned changes to this revision.
malaperle added a comment.
I found some issues while testing, I will investigate before review.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
___
cfe-commits mailing list
cfe-commit
srhines added a comment.
In https://reviews.llvm.org/D48459#1143012, @smeenai wrote:
> Actually, I would imagine that if you're cross-compiling or using a custom
> sysroot, you should probably also specify CMAKE_FIND_ROOT_PATH and set
> CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY, to limit all th
Author: phosek
Date: Tue Jun 26 20:35:53 2018
New Revision: 335704
URL: http://llvm.org/viewvc/llvm-project?rev=335704&view=rev
Log:
[CMake] Provide direct support for building sanitized runtimes
This avoids having to rely on magic separators and special parsing.
Differential Revision: https://r
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D48564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D48563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
phosek added inline comments.
Comment at: CMakeLists.txt:191
+# are cross-compiling.
+if(NOT CMAKE_SYSROOT AND NOT CMAKE_CROSSCOMPILING AND NOT LLVM_USE_SANITIZER
MATCHES "Memory.*")
set (LIBXML2_FOUND 0)
This isn't going to cause a problem for us since we al
Author: zturner
Date: Tue Jun 26 19:49:22 2018
New Revision: 335702
URL: http://llvm.org/viewvc/llvm-project?rev=335702&view=rev
Log:
Fix warning about unhandled enumeration in switch.
Modified:
cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp
rtrieu added a comment.
Hey Vassil,
I have been giving this a little more thought and I have a solution I'd like
you to try out. If the type pointers aren't unique enough, then the indexing
scheme will not work for hashing. Can you try this idea in your build
environment and see if works for
Ah - thanks for fixing that. Surprised none of the bots hit it.
Teresa
On Tue, Jun 26, 2018 at 4:24 PM Shoaib Meenai wrote:
> Ah, my llvm-as was indeed out of date. I made check-clang depend on
> llvm-as in r335686 to avoid this issue in the future.
>
>
>
> *From: *Teresa Johnson
> *Date: *Tues
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335701: [analyzer] [NFC] A convenient getter for getting a
current stack frame (authored by george.karpenkov, committed by ).
Herald added subscribers: cfe-commits, mikhail.ramalho.
Changed prior to commi
Author: george.karpenkov
Date: Tue Jun 26 18:51:55 2018
New Revision: 335701
URL: http://llvm.org/viewvc/llvm-project?rev=335701&view=rev
Log:
[analyzer] [NFC] A convenient getter for getting a current stack frame
Differential Revision: https://reviews.llvm.org/D44756
Modified:
cfe/trunk/inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335700: [analyzer] [NFC] Add -verify to malloc checker test
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D4851
Author: george.karpenkov
Date: Tue Jun 26 18:51:36 2018
New Revision: 335700
URL: http://llvm.org/viewvc/llvm-project?rev=335700&view=rev
Log:
[analyzer] [NFC] Add -verify to malloc checker test
Differential Revision: https://reviews.llvm.org/D48514
Modified:
cfe/trunk/test/Analysis/malloc-p
Author: rsmith
Date: Tue Jun 26 18:32:04 2018
New Revision: 335699
URL: http://llvm.org/viewvc/llvm-project?rev=335699&view=rev
Log:
Diagnose missing 'template' keywords in contexts where a comma is not a
binary operator.
Factor out the checking for a comma within potential angle brackets and
als
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Analysis/CFG.cpp:2397
+ for (auto Arg: C->arguments())
+if (Arg->getType()->getAsCXXRecordDecl() && !Arg->isGLValue())
NoQ added a comment.
I think we need to finish our dialog on who's responsible for initialization
and why do we need to filter constructors at all, cause it's kinda hanging
(i.e. https://reviews.llvm.org/D45532#inline-422673).
https://reviews.llvm.org/D48436
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392
-if (T->isMemberPointerType()) {
- if (isMemberPointerUninit(FR, LocalChain))
+if (T->isPointerType() || T->isReferenceType()) {
+ if (isPointerOrReferenceUni
NoQ accepted this revision.
NoQ added a comment.
Looks good! One minor comment.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:488-491
// TODO: Dereferencing should be done according to the dynamic type.
while (Optional L = DerefdV.getAs()) {
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Requesting changes or clarification on uninitialized references.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:392
-
mclow.lists updated this revision to Diff 152995.
mclow.lists added a comment.
Remove a bunch of `noexcept`s that I missed the first time.
Put in an error message to be checked in one of the failing deduction cases
that was lacking it.
Address STL's comments.
https://reviews.llvm.org/D48616
F
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:674
+ const LocationContext *LC = Context.getLocationContext();
+
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Minor nits: would like some more comments.
Comment at: include/clang/Analysis/CFG.h:185
+assert(isa(E) || isa(E));
+return !E->isGLValue
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
@NoQ had some valid comments. I think this could be still useful without
dataflow if we negate matches containing escaping and assignments.
Though of course this c
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Looks like @NoQ had some valid comments as well.
https://reviews.llvm.org/D48291
___
cfe-commits mailing list
cfe-c
george.karpenkov added a comment.
Few more nits.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:691
+StringRef getVariableName(const FieldDecl *Field) {
+ // If \p Field is a captured lambda variable, Field->getName() will return
Is t
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:699
+for (const LambdaCapture &L : CXXParent->captures()) {
+ if (L.getLocation() == Field->getLocation())
+return L.getCapturedVar()->getName();
Uh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335691: [mips] Explicitly specify the linker emulation for
MIPS on FreeBSD. (authored by jhb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4850
Author: jhb
Date: Tue Jun 26 17:02:16 2018
New Revision: 335691
URL: http://llvm.org/viewvc/llvm-project?rev=335691&view=rev
Log:
[mips] Explicitly specify the linker emulation for MIPS on FreeBSD.
FreeBSD's mips64 builds O32 binaries for /usr/lib32 by default and
thus needs to be able to link O3
vsapsai updated this revision to Diff 152990.
vsapsai added a comment.
- Don't use memcpy specialization with custom allocators.
Not entirely satisfied with comparing allocator to non-const and const, don't
know if there is a more elegant way to do the same.
https://reviews.llvm.org/D48342
Fil
NoQ accepted this revision.
NoQ added a comment.
Looks great, thanks!
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:696
void ento::registerUninitializedObjectChecker(CheckerManager &Mgr) {
auto Chk = Mgr.registerChecker();
Chk->IsPedantic = Mgr.g
Author: rsmith
Date: Tue Jun 26 16:20:26 2018
New Revision: 335687
URL: http://llvm.org/viewvc/llvm-project?rev=335687&view=rev
Log:
Diagnose missing 'template' keywords in more cases.
We track when we see a name-shaped expression followed by a '<' token
and parse the '<' as a comparison. Then:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335687: Diagnose missing 'template' keywords in
more cases. (authored by rsmith, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48571
Files:
include/clang/Basic/BitmaskEnum.h
inclu
Ah, my llvm-as was indeed out of date. I made check-clang depend on llvm-as in
r335686 to avoid this issue in the future.
From: Teresa Johnson
Date: Tuesday, June 26, 2018 at 4:11 PM
To: Shoaib Meenai
Cc: "cfe-commits@lists.llvm.org"
Subject: Re: r335618 - [ThinLTO] Add testing of summary inde
Author: smeenai
Date: Tue Jun 26 16:18:59 2018
New Revision: 335686
URL: http://llvm.org/viewvc/llvm-project?rev=335686&view=rev
Log:
[clang] Add test dependency on llvm-as
r335618 added tests that invoke llvm-as, so we should also ensure that
running clang tests rebuilds llvm-as.
Modified:
Author: george.karpenkov
Date: Tue Jun 26 16:17:35 2018
New Revision: 335685
URL: http://llvm.org/viewvc/llvm-project?rev=335685&view=rev
Log:
[analyzer] [tests] Include statistics in tests.
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trunk/utils/analyzer/SATestBuild.py
U
Author: eugenis
Date: Tue Jun 26 16:10:48 2018
New Revision: 335684
URL: http://llvm.org/viewvc/llvm-project?rev=335684&view=rev
Log:
Revert "[MS] Use mangled names and comdats for string merging with ASan"
Depends on r334313, which has been reverted in r335681.
Modified:
cfe/trunk/lib/CodeG
Author: george.karpenkov
Date: Tue Jun 26 16:10:05 2018
New Revision: 335683
URL: http://llvm.org/viewvc/llvm-project?rev=335683&view=rev
Log:
[analyzer] Minor cleanups for BugReporter, expose a getter for AnalyzerOptions.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugR
I haven't seen any bot failures for the change. The failing check was there
before, so presumably llvm-dis on its own is producing the expected lines,
just not when it goes through llvm-as. Can you let me know whether llvm-as
has been updated and whether it gives an error. Note that there were a
nu
craig.topper created this revision.
craig.topper added reviewers: rsmith, chandlerc, echristo, rnk.
This is part of an ongoing attempt at making 512 bit vectors illegal in the X86
backend type legalizer due to CPU frequency penalties associated with wide
vectors on Skylake Server CPUs. We want t
STL_MSFT added inline comments.
Comment at:
test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp:26
+// The deduction guide shall not participate in overload resolution if
Allocator is
+// is a type that does not qualify as an allocator.
+
The check lines added here are failing for me on CentOS 7.
https://reviews.llvm.org/P8091 has the lit output and the actual output being
produced by one of the added RUN lines. My llvm and clang repositories are in
sync. Any idea what might be going on here?
From: cfe-commits on behalf of Tere
mclow.lists added a comment.
Ok, for some reason, the four tests that I *added* didn't get into the diff.
https://reviews.llvm.org/D48616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, ldionne, STL_MSFT.
A massive amount of doinking around in .
https://cplusplus.github.io/LWG/issue2946
https://cplusplus.github.io/LWG/issue3075
https://cplusplus.github.io/LWG/issue3076
This is not quite right yet, but
tra created this revision.
tra added a reviewer: Hahnfeld.
Herald added subscribers: bixia, jlebar, sanjoy.
That's where CUDA SDK binaries appear to put them on Mac.
https://reviews.llvm.org/D48615
Files:
clang/lib/CodeGen/CGCUDANV.cpp
Index: clang/lib/CodeGen/CGCUDANV.cpp
=
Author: paquette
Date: Tue Jun 26 15:09:48 2018
New Revision: 335672
URL: http://llvm.org/viewvc/llvm-project?rev=335672&view=rev
Log:
[MachineOutliner] Emit a warning when using -moutline on unsupported targets
Instead of just saying "flag unused", we should tell the user that the
outliner isn't
tra created this revision.
tra added a reviewer: jlebar.
Herald added subscribers: bixia, sanjoy.
This matches the way NVCC does it. Doing module cleanup at global
destructor phase used to work, but is, apparently, too late for
the CUDA runtime in CUDA-9.2, which ends up crashing with double-free.
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks pretty good to me - nice work!
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing list
cfe-commits@lists.ll
marco-c added a comment.
Yes, the behavior changed very recently, I would be surprised if
somebody came to depend on it. It's more likely that some clients are
depending on the old behavior.
- Marco.
Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto:
> srhines added a comment.
>
>
Yes, the behavior changed very recently, I would be surprised if
somebody came to depend on it. It's more likely that some clients are
depending on the old behavior.
- Marco.
Il 26/06/2018 22:43, Stephen Hines via Phabricator ha scritto:
> srhines added a comment.
>
> In https://reviews.llvm.org
srhines added a comment.
In https://reviews.llvm.org/D45454#1144099, @davidxl wrote:
> GCC's behavior is not documented and it also has changed over the years.
>
> Unless there is a bug, changing LLVM's gcov_flush visibility can potentially
> break clients that depend on this behavior.
I think
davidxl added a comment.
GCC's behavior is not documented and it also has changed over the years.
Unless there is a bug, changing LLVM's gcov_flush visibility can potentially
break clients that depend on this behavior.
https://reviews.llvm.org/D45454
rjmccall added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, george.karpenkov.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, rnkovacs,
szepet, baloghadamsoftware.
This patch extends https://reviews.llvm.org/D44120 to Objective-C messages that
can also sometimes retu
Author: george.karpenkov
Date: Tue Jun 26 14:12:08 2018
New Revision: 335666
URL: http://llvm.org/viewvc/llvm-project?rev=335666&view=rev
Log:
[analyzer] Do not run visitors until the fixpoint, run only once.
In the current implementation, we run visitors until the fixed point is
reached.
That is
Wouldn't it be better to keep compatibility with GCC and make
__gcov_flush have default visibility?
- Marco.
Il 26/06/2018 00:21, Xinliang David Li ha scritto:
> I don't have an objection having another interface which is just a
> simple wrapper to __gcov_flush but with default visibility. Also
malaperle updated this revision to Diff 152958.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48159
Files:
clangd/XRefs.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
unittests/clangd/XRefsTests.cpp
Index: unittests/clang
chh updated this revision to Diff 152957.
chh edited the summary of this revision.
https://reviews.llvm.org/D45454
Files:
lib/profile/GCDAProfiling.c
test/profile/Inputs/instrprof-dlopen-dlclose-main.c
Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c
==
rogfer01 added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
bsdjhb updated this revision to Diff 152955.
bsdjhb added a comment.
- Add N32EL.
Repository:
rC Clang
https://reviews.llvm.org/D48507
Files:
lib/Driver/ToolChains/FreeBSD.cpp
test/Driver/freebsd.c
Index: test/Driver/freebsd.c
===
malaperle updated this revision to Diff 152953.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47846
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/FindSymbols.cpp
c
Author: modocache
Date: Tue Jun 26 13:05:18 2018
New Revision: 335655
URL: http://llvm.org/viewvc/llvm-project?rev=335655&view=rev
Log:
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Modified:
cfe/trunk/include/clang/AST/ExternalASTSource.h
Modified: cfe/trunk/include/clang/AST/ExternalAST
rjmccall added inline comments.
Comment at: include/clang/AST/ASTContext.h:1954
+ llvm::APInt getFixedPointMin(QualType Ty) const;
+ llvm::APInt getFixedPointOne(QualType Ty) const;
ebevhan wrote:
> rjmccall wrote:
> > Are these opaque bit-patterns? I think
kparzysz added a comment.
Please take over, I commandeered to restore the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
kparzysz updated this revision to Diff 152946.
kparzysz added a comment.
Restored the original patch.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
Files:
include/clang/Basic/BitmaskEnum.h
include/clang/Parse/Parser.h
include/clang/Parse/RAIIObjectsForParser.h
include/clang/Sem
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335653: [mips] Use more conservative default CPUs for MIPS
on FreeBSD. (authored by jhb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48499?vs=152522&id=152944#toc
Repository:
r
Author: jhb
Date: Tue Jun 26 12:48:05 2018
New Revision: 335653
URL: http://llvm.org/viewvc/llvm-project?rev=335653&view=rev
Log:
[mips] Use more conservative default CPUs for MIPS on FreeBSD.
FreeBSD defaults to mips3 for all MIPS ABIs with GCC as that is the
minimum MIPS architecture FreeBSD su
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3500
+if (auto *PtrTy = dyn_cast(PTy)) {
+ if (PtrTy->getAddressSpace() !=
+ ArgValue->getType()->getPointerAddressSpace()) {
Anastasia wrote:
> arsenm wrote:
> > An
kparzysz reopened this revision.
kparzysz added a comment.
This needs to be restored to the original form. A mistake in a commit message
closed this review by accident.
Repository:
rL LLVM
https://reviews.llvm.org/D48571
___
cfe-commits mailing
zturner added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4043-4044
+if (CCGenDiagnostics && A) {
+ SmallString<128> CrashDirectory;
+ CrashDirectory = A->getValue();
+ llvm::sys::path::append(CrashDirectory, Split.first);
Maybe yo
Wawha marked 2 inline comments as done.
Wawha added a comment.
Hello,
after my last modification (require by previous comment), I do not see any
feedback or validation for this patch.
Is their something special to do in order to go forward on this patch?
Lambda are more an more used in modern
rjmccall added inline comments.
Comment at: include/clang/CodeGen/CGFunctionInfo.h:90
union {
-unsigned DirectOffset; // isDirect() || isExtend()
-unsigned IndirectAlign;// isIndirect()
-unsigned AllocaFieldIndex; // isInAlloca()
+llvm::StructType *Exte
dblaikie added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
aprantl wrote:
> JDevlieghere wrote:
> > dexonsmith wrote:
> > > Some comment for "p"
j10kay created this revision.
j10kay added reviewers: hans, inglorion, rnk.
Herald added subscribers: llvm-commits, hiraditya.
New flag causes crash reports to be written in the specified directory
rather than the temp directory.
Repository:
rL LLVM
https://reviews.llvm.org/D48601
Files:
c
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335641: [Hexagon] Add a "generic" cpu (authored by
bcahoon, committed by ).
Herald added a subscriber: llvm-commits.
Chan
vsapsai planned changes to this revision.
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
erik.pilkington wrote:
> Shouldn't this be true_type?
I see this is confusing and I'm still strugg
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
> My fear of using file IDs is that I don't know whether they are stable
IIRC they are currently stable, but that's relying on implementation details.
Still better than not
vsapsai added a comment.
Thanks for the review, Richard.
Repository:
rC Clang
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335638: [Sema] Fix infinite typo correction loop. (authored
by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47341?vs=148841&id=152924#toc
Repository:
rC Clang
https://
Author: vsapsai
Date: Tue Jun 26 10:56:48 2018
New Revision: 335638
URL: http://llvm.org/viewvc/llvm-project?rev=335638&view=rev
Log:
[Sema] Fix infinite typo correction loop.
NumTypos guard value ~0U doesn't prevent from creating new delayed typos. When
you create new delayed typos during typo c
Author: pcc
Date: Tue Jun 26 10:45:26 2018
New Revision: 335636
URL: http://llvm.org/viewvc/llvm-project?rev=335636&view=rev
Log:
Compile CodeGenModule.cpp with /bigobj.
Apparently we're now hitting an object file section limit on this
file with expensive checks enabled.
Modified:
cfe/trunk/
Author: aaronenyeshi
Date: Tue Jun 26 10:40:36 2018
New Revision: 335634
URL: http://llvm.org/viewvc/llvm-project?rev=335634&view=rev
Log:
[HIP] Remove hip/hc.amdgcn.bc from HIP Toolchains
Summary:
The hc.amdgcn.bc and hip.amdgcn.bc are removed in VDI build and no longer
needed.
Reviewers: yaxu
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
JDevlieghere wrote:
> dexonsmith wrote:
> > Some comment for "p" here.
> Fixed; I'll u
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335634: [HIP] Remove hip/hc.amdgcn.bc from HIP Toolchains
(authored by aaronenyeshi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48455?vs=
Author: abataev
Date: Tue Jun 26 10:24:03 2018
New Revision: 335632
URL: http://llvm.org/viewvc/llvm-project?rev=335632&view=rev
Log:
[OPENMP, NVPTX] Reduce the number of the globalized variables.
Patch tries to make better analysis of the variables that should be
globalized. From now, instead of
Author: aaronenyeshi
Date: Tue Jun 26 10:12:29 2018
New Revision: 335630
URL: http://llvm.org/viewvc/llvm-project?rev=335630&view=rev
Log:
[Test] Initial test commit access
Modified:
cfe/trunk/lib/Driver/ToolChains/HIP.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/HIP.cpp
URL:
http://llvm.o
Author: thegameg
Date: Tue Jun 26 10:05:01 2018
New Revision: 335628
URL: http://llvm.org/viewvc/llvm-project?rev=335628&view=rev
Log:
Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename."
This reverts commit r334550. Try to fix the stage2 build failing on
Green Dragon f
Author: rksimon
Date: Tue Jun 26 10:00:43 2018
New Revision: 335626
URL: http://llvm.org/viewvc/llvm-project?rev=335626&view=rev
Log:
Fix -Wdocumentation warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/Headers.h
Modified: clang-tools-extra/trunk/clangd/Headers.h
URL:
http://llvm.org
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:4239
+// Add methods to interface.
+for (auto p : ObjCMethodCache) {
+ if (p.second.empty())
dexonsmith wrote:
> Some comment for "p" here.
Fixed; I'll update the rest of the
JDevlieghere updated this revision to Diff 152910.
JDevlieghere marked 6 inline comments as done.
JDevlieghere added a comment.
- Feedback Adrian & Duncan
https://reviews.llvm.org/D48241
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenObjC/debug-info-category.m
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335624: [clangd] Simplify matches in FindSymbols tests
(authored by malaperle, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47847
Files:
cla
Author: malaperle
Date: Tue Jun 26 09:57:44 2018
New Revision: 335624
URL: http://llvm.org/viewvc/llvm-project?rev=335624&view=rev
Log:
[clangd] Simplify matches in FindSymbols tests
Summary:
Instead of checking symbol name and container (scope) separately, check the
qualified name instead. This
malaperle accepted this revision.
malaperle added a comment.
This revision is now accepted and ready to land.
Self-approving because this is pretty inconsequential.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47847
___
cfe-commit
dexonsmith added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3355
+ QualType QTy(ID->getTypeForDecl(), 0);
+ auto it = TypeCache.find(QTy.getAsOpaquePtr());
+ if (it != TypeCache.end()) {
LLVM style rules suggest UpperCamelCase or INIT
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1659
+ AccessSpecDecl *ToD;
+ std::tie(ToD, AlreadyImported) = CreateDecl(
+ D, Importer.getToContext(), D->getAccess(), DC, Loc, ColonLoc);
a.sidorin wrote:
> As I see, all usage samples r
Author: cryptoad
Date: Tue Jun 26 09:14:35 2018
New Revision: 335620
URL: http://llvm.org/viewvc/llvm-project?rev=335620&view=rev
Log:
[Driver] Do not add -lpthread & -lrt with -static-libsan on Android
Summary:
I am not sure anyone has tried to compile an application with sanitizers on
Android w
1 - 100 of 146 matches
Mail list logo
