phosek created this revision.
phosek added reviewers: mcgrathr, juliehockett, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
First stage build is only a minimal build where we don't need
a multiarch support.
Repository:
rC Clang
https://reviews.llvm.org/D48707
Files:
clang/cm
balazske added inline comments.
Comment at: lib/AST/ASTStructuralEquivalence.cpp:873
+
+ if (auto *Constructor1 = dyn_cast(Method1)) {
+if (auto *Constructor2 = dyn_cast(Method2)) {
a.sidorin wrote:
> ```if (Method1->getStmtKind() != Method2->getStmtKind())
EricWF added a comment.
LGTM, but I'm a bit confused. You seem to argue that no system places C++
headers on the default search paths, but also that it would be a problem if
such a system did.
Why wouldn't the conclusion be true? That is, although C++ includes aren't
normally found along the de
Hi,
I get the same compilation error when I compile with clang 3.6.0.
Revert?
Regards,
Mikael
On 06/28/2018 03:16 AM, via cfe-commits wrote:
Hi, this commit also broke our internal bot for a different reason:
FAILED: /usr/lib/ccache/clang++ -DGTEST_HAS_RTTI=0
-DGTEST_HAS_TR1_TUPLE=0 -DGT
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335812: [CMake] Use explicit targets for building Linux
runtimes (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48563?vs=152759&id=153259#toc
Repository:
rC C
Author: phosek
Date: Wed Jun 27 22:15:46 2018
New Revision: 335812
URL: http://llvm.org/viewvc/llvm-project?rev=335812&view=rev
Log:
[CMake] Use explicit targets for building Linux runtimes
Previously we were using default logic when building Linux runtimes
in Fuchsia toolchain, but that leads to
On Tue, Jun 12, 2018 at 8:04 PM, Ahmed Bougacha
wrote:
> Well, that was wrong. There are more install-cxx-headers targets that
> the cache distribution implicitly depends on.
>
> Is there a reason for your cxx-headers -> cxx_headers change? If
> there is, should the other cxx-headers targets cha
ab created this revision.
ab added a reviewer: phosek.
Herald added subscribers: ldionne, mgorny.
r334477 renamed the cxx-headers target to cxx_headers, but various pieces
sort-of expect the target names to match the component (e.g.,
LLVM_DISTRIBUTION_COMPONENTS in the various bootstrap caches,
rogfer01 added a comment.
Herald added subscribers: the_o, brucehoult, MartinMosbeck.
Ping?
https://reviews.llvm.org/D48357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ab created this revision.
ab added a reviewer: phosek.
Herald added subscribers: mgorny, dberris.
Since r334468, my understanding is, we no longer always copy the libcxx headers
by virtue of their presence when cmake runs.
This is an attempt to make some of the later stages (compiler-rt, and the
Author: phosek
Date: Wed Jun 27 20:54:08 2018
New Revision: 335810
URL: http://llvm.org/viewvc/llvm-project?rev=335810&view=rev
Log:
Handle both Linux and Windows path separator for the resource dir
The resource dir path used for the multiarch runtimes support is
constructed in a platform indepen
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
Author: phosek
Date: Wed Jun 27 20:11:52 2018
New Revision: 335809
URL: http://llvm.org/viewvc/llvm-project?rev=335809&view=rev
Log:
Support for multiarch runtimes layout
This change adds a support for multiarch style runtimes layout, so in
addition to the existing layout where runtimes get insta
george.karpenkov reopened this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
After thinking about this change a bit longer, I think it does not make sense.
Albeit poorly named, the previous design had a purpose:
`RangedConstraintManager` is a public
Author: dergachev
Date: Wed Jun 27 19:33:16 2018
New Revision: 335808
URL: http://llvm.org/viewvc/llvm-project?rev=335808&view=rev
Log:
[analyzer] Remove redundant ';'.
Fixes a compiler warning. No functionan change intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modifi
Author: rsmith
Date: Wed Jun 27 18:57:04 2018
New Revision: 335807
URL: http://llvm.org/viewvc/llvm-project?rev=335807&view=rev
Log:
[modules] Do not serialize / deserialize pending new/delete mismatch
checks across module boundaries. This was causing us to load constructor
definitions for all con
Hi, this commit also broke our internal bot for a different reason:
FAILED: /usr/lib/ccache/clang++ -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0
-DGTEST_LANG_CXX11=1 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-Itools/clang/unittests/StaticAnalyz
Author: rsmith
Date: Wed Jun 27 18:07:28 2018
New Revision: 335805
URL: http://llvm.org/viewvc/llvm-project?rev=335805&view=rev
Log:
[modules] Ensure that an in-class function definition is attached to the
declaration of the function that ends up in the primary definition of
the class.
... at lea
smeenai added a comment.
This doesn't map to any command line change; it's purely a CMake thing. It just
changes where libc++abi's build system looks for libc++ headers. Before this
patch, it would look for a file named "vector" in all the standard system
include directories (`/usr/local/includ
dexonsmith added a reviewer: ldionne.
dexonsmith added a comment.
What's the effective change on the command-line? Does this map to `-nostdinc`?
To `-nostdinc++`?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D48694
___
cfe-commits mail
Author: dergachev
Date: Wed Jun 27 17:42:11 2018
New Revision: 335803
URL: http://llvm.org/viewvc/llvm-project?rev=335803&view=rev
Log:
[analyzer] Use sufficiently large types for index bounds calculation.
The ProgramState::assumeInBound() API is used by checkers to make an assumption
that a cert
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335803: [analyzer] Use sufficiently large types for index
bounds calculation. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46944
Files:
lib/StaticAnalyzer/C
smeenai abandoned this revision.
smeenai added a comment.
https://reviews.llvm.org/D48694
Repository:
rL LLVM
https://reviews.llvm.org/D48675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
smeenai created this revision.
smeenai added reviewers: beanz, compnerd, dexonsmith, EricWF, mclow.lists.
Herald added subscribers: cfe-commits, ldionne, christof, mgorny.
Right now, when libc++abi is locating libc++ headers, it specifies
several search locations, but it also doesn't prevent CMake
dexonsmith added subscribers: beanz, EricWF.
dexonsmith added a comment.
Please close this and open a new one. Adding cfe-commits after the fact will
fail to send the patch/description to cfe-commits, and not everyone is on
llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48675
Please close this and open a new one. Adding cfe-commits after the fact will
fail to send the patch/description to cfe-commits, and not everyone is on
llvm-commits.
> On Jun. 27, 2018, at 14:29, Shoaib Meenai via Phabricator
> wrote:
>
> smeenai edited subscribers, added: cfe-commits; remove
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335800: [analyzer] Add support for pre-C++17 copy elision.
(authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47671
Files:
include/clang/StaticAnalyzer/Core/PathS
Author: dergachev
Date: Wed Jun 27 17:30:18 2018
New Revision: 335800
URL: http://llvm.org/viewvc/llvm-project?rev=335800&view=rev
Log:
[analyzer] Add support for pre-C++17 copy elision.
r335795 adds copy elision information to CFG. This commit allows static analyzer
to elide elidable copy constr
Author: dyung
Date: Wed Jun 27 17:19:12 2018
New Revision: 335799
URL: http://llvm.org/viewvc/llvm-project?rev=335799&view=rev
Log:
Fixup test to compile with -frtti when trying to use typeid() as the PS4 does
not have it on by default and it was failing on the PS4 linux bot because of
this.
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335798: [CFG] [analyzer] Simplify lifetime-extended
temporary construction contexts. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
Author: dergachev
Date: Wed Jun 27 17:18:52 2018
New Revision: 335798
URL: http://llvm.org/viewvc/llvm-project?rev=335798&view=rev
Log:
[CFG] [analyzer] Simplify lifetime-extended temporary construction contexts.
When a temporary object is materialized and through that obtain lifetime that
is lon
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335796: [analyzer] Re-enable lifetime extension for
temporaries without destructors. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335796: [analyzer] Re-enable lifetime extension for
temporaries without destructors. (authored by dergachev, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47658
Files:
lib/StaticAnal
Author: dergachev
Date: Wed Jun 27 17:11:42 2018
New Revision: 335796
URL: http://llvm.org/viewvc/llvm-project?rev=335796&view=rev
Log:
[analyzer] Re-enable lifetime extension for temporaries without destructors.
When an object's class provides no destructor, it's less important to
materialize th
Author: dergachev
Date: Wed Jun 27 17:04:54 2018
New Revision: 335795
URL: http://llvm.org/viewvc/llvm-project?rev=335795&view=rev
Log:
[CFG] [analyzer] Add construction contexts that explain pre-C++17 copy elision.
Before C++17 copy elision was optional, even if the elidable copy/move
constructo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335795: [CFG] [analyzer] Add construction contexts that
explain pre-C++17 copy elision. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
simark created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
When compile_commands.json contains some source files expressed as
relative paths, we can get duplicate responses to findDefinitions. The
responses only differ by the URI, which are diffe
NoQ accepted this revision.
NoQ edited reviewers, added: NoQ; removed: dergachev.a.
NoQ added a comment.
Yep, this definitely looks safe and sound in the current shape.
I'm also very sorry for the lack of attention.
https://reviews.llvm.org/D46944
bsdjhb added a comment.
FWIW, for FreeBSD I defined __CLANG_MAX_ALIGN_T and _GCC_MAX_ALIGN_T in
FreeBSD's when defining the typedef to handle this.
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lis
pcc added a comment.
This change ensures that __func receives public LTO visibilty:
https://clang.llvm.org/docs/LTOVisibility.html
if a translation unit is compiled with `-fvisibility=hidden` and without
`_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` defined (i.e. dynamically linking
against libc++).
bruno created this revision.
bruno added reviewers: rsmith, benlangmuir.
Consider:
1. Generate PCH with -fmodules and -fmodule-map-file
2. Use PCH with -fmodules and the same -fmodule-map-file
If we don't load -fmodule-map-file content before including PCHs, the modules
that are dependencies in
NoQ added inline comments.
Comment at: lib/Analysis/CFG.cpp:5011
print_initializer(OS, Helper, SICC->getCXXCtorInitializer());
-break;
+return;
}
For consistency.
Comment at: lib/Analysis/CFG.cpp:5074-5078
for (auto I: Stmts)
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
Replace stubs we had to discriminate between temporaries and function arguments
with actual constructio
mclow.lists added a comment.
Sorry - what problem is this solving?
Repository:
rCXX libc++
https://reviews.llvm.org/D48680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bsdjhb added a comment.
Ping. I'd like this to go in and get merged into FreeBSD's clang so we can
test this for a few months before 12.0 branches.
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
yunlian created this revision.
Herald added subscribers: cfe-commits, ldionne.
This adds missing visibility annotation for __base.
Repository:
rCXX libc++
https://reviews.llvm.org/D48680
Files:
include/functional
Index: include/functional
=
benhamilton created this revision.
benhamilton added reviewers: djasper, krasimir.
Herald added a subscriber: cfe-commits.
In https://reviews.llvm.org/D44638, I partially fixed
`NS_SWIFT_NAME(foo(bar:baz:))`-style
annotations on C functions, but didn't add a test for Objective-C
method declaratio
nathawes updated this revision to Diff 153190.
nathawes added a comment.
Updated to apply on top-of-tree.
https://reviews.llvm.org/D39050
Files:
include/clang/Basic/AllDiagnostics.h
include/clang/Basic/CMakeLists.txt
include/clang/Basic/Diagnostic.td
include/clang/Basic/DiagnosticGroups
Author: aheejin
Date: Wed Jun 27 15:05:09 2018
New Revision: 335791
URL: http://llvm.org/viewvc/llvm-project?rev=335791&view=rev
Log:
[analyzer] Add clangFrontend to target_link_libraries
Without this, builds with `-DSHARED_LIB=ON` fail.
Modified:
cfe/trunk/unittests/StaticAnalyzer/CMakeList
FYI,
This commit breaks clang tests. It appears that StaticAnalysisTests misses
dependency on clangFrontend.
--Artem
[60/134] Linking CXX executable
tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests
FAILED: tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests
: && /usr/local/google/ho
smeenai edited subscribers, added: cfe-commits; removed: llvm-commits.
smeenai added a comment.
Huh, this went to llvm-commits instead of cfe-commits automatically. I guess
the auto mailing list subscribing doesn't work great with the monorepo?
Repository:
rL LLVM
https://reviews.llvm.org/D4
mclow.lists updated this revision to Diff 153178.
mclow.lists marked 2 inline comments as done.
mclow.lists added a comment.
Update diff per Louis' suggestion.
Remove noexcepts from the synopsis.
https://reviews.llvm.org/D48616
Files:
include/memory
include/string
test/std/strings/basic.s
Rakete updated this revision to Diff 153149.
Rakete added a comment.
Added expression evaluation context to TreeTransform :)
https://reviews.llvm.org/D37442
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Parse/ParseDeclCXX
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
Thank you for reducing this test case for ODR hashing.
https://reviews.llvm.org/D48524
___
cfe-commits mailing list
cfe-commits@lists.llvm.
boga95 updated this revision to Diff 153172.
boga95 marked 3 inline comments as done.
https://reviews.llvm.org/D44143
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp
clang-tidy/cert/ProperlySeededRandomGenerat
boga95 updated this revision to Diff 153169.
boga95 marked 3 inline comments as done.
https://reviews.llvm.org/D44143
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp
clang-tidy/cert/ProperlySeededRandomGenerat
mclow.lists marked 5 inline comments as done.
mclow.lists added inline comments.
Comment at: include/memory:5647
+ typename __void_t::type,
+ typename
__void_t().allocate(size_t(0)))>::type
+ >
ldionne wrote:
> Sorry -- still not very fluent with
Author: rsmith
Date: Wed Jun 27 13:30:36 2018
New Revision: 335782
URL: http://llvm.org/viewvc/llvm-project?rev=335782&view=rev
Log:
[www] Update cxx_dr_status for recent DR fixes.
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.org/vie
NoQ updated this revision to Diff 153165.
NoQ added a comment.
Code re-use!
And the comment.
https://reviews.llvm.org/D48608
Files:
include/clang/Analysis/CFG.h
lib/Analysis/CFG.cpp
test/Analysis/cfg-rich-constructors.mm
test/Analysis/lifetime-extension.mm
Index: test/Analysis/lifetim
Author: rsmith
Date: Wed Jun 27 13:30:34 2018
New Revision: 335781
URL: http://llvm.org/viewvc/llvm-project?rev=335781&view=rev
Log:
DR1687: When overload resolution selects a built-in operator, implicit
conversions are only applied to operands of class type, and the second
standard conversion seq
NoQ marked 2 inline comments as done.
NoQ added inline comments.
Comment at: lib/Analysis/CFG.cpp:799
+ConstructionContextMap.lookup(ME)) {
+ cleanupConstructionContext(ME);
+ if (const auto *CC = ConstructionContext::createFromLayers(
--
Author: rsmith
Date: Wed Jun 27 13:29:32 2018
New Revision: 335779
URL: http://llvm.org/viewvc/llvm-project?rev=335779&view=rev
Log:
DR1213: Ignore implicit conversions when determining if an operand of an
array subscript expression is an array prvalue.
Also apply DR1213 to vector prvalues for co
Author: bruno
Date: Wed Jun 27 13:29:36 2018
New Revision: 335780
URL: http://llvm.org/viewvc/llvm-project?rev=335780&view=rev
Log:
[Modules][ObjC] Warn on the use of '@import' in framework headers
Using @import in framework headers inhibit the use of such headers
when not using modules, this is
smeenai added subscribers: smeenai, compnerd, zturner.
smeenai added a comment.
Adding some people who are interested in Windows cross-compilation.
Repository:
rC Clang
https://reviews.llvm.org/D48626
___
cfe-commits mailing list
cfe-commits@list
george.karpenkov added a comment.
@sylvestre.ledru Have you found any actual bugs using this checker?
@Szelethus Interesting, it seems that the pointer itself is initialized, but
not what it's pointing to.
I think we should just check the fields directly, and do not attempt to
traverse the point
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335774: [HIP] Fix ordering of device-libs linking (authored
by aaronenyeshi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48667?vs=153154&id=153158#toc
Repository:
rC Clang
htt
Author: aaronenyeshi
Date: Wed Jun 27 12:51:42 2018
New Revision: 335774
URL: http://llvm.org/viewvc/llvm-project?rev=335774&view=rev
Log:
[HIP] Fix ordering of device-libs linking
Summary:
HIP should link the bitcodes with caller functions before callee functions.
Also added lit test to check t
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mstorsjo added a comment.
FWIW, I'm also interested in this. I wasn't aware of the other ways of
achieving this used by chromium, but although neat, I'd prefer something that
doesn't require that kind of setup.
As for performance - although I haven't studied how the code works - wouldn't
it be
NoQ updated this revision to Diff 153157.
NoQ added a comment.
Actually, yeah, add the comment.
https://reviews.llvm.org/D48249
Files:
lib/Analysis/CFG.cpp
lib/Analysis/ConstructionContext.cpp
test/Analysis/cfg-rich-constructors.cpp
test/Analysis/cfg-rich-constructors.mm
test/Analysis
NoQ updated this revision to Diff 153155.
NoQ added a comment.
Code re-use!
https://reviews.llvm.org/D48249
Files:
lib/Analysis/CFG.cpp
lib/Analysis/ConstructionContext.cpp
test/Analysis/cfg-rich-constructors.cpp
test/Analysis/cfg-rich-constructors.mm
test/Analysis/temporaries.cpp
t
ashi1 updated this revision to Diff 153154.
ashi1 added a comment.
Updated diff with a lit test.
https://reviews.llvm.org/D48667
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index: test/Driver/hip-device-libs.hip
malaperle updated this revision to Diff 153153.
malaperle added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48159
Files:
clangd/XRefs.cpp
unittests/clangd/TestTU.cpp
unittests/clangd/TestTU.h
unittests/clangd/XRefsTests.cpp
Index: unitte
malaperle marked 4 inline comments as done.
malaperle added inline comments.
Comment at: clangd/XRefs.cpp:559
+ //- auto& i = 1;
+ bool VisitDeclaratorDecl(DeclaratorDecl *D) {
+if (!D->getTypeSourceInfo() ||
sammccall wrote:
> out of curiosity, why not imp
yaxunl added a comment.
Please add a lit test.
Repository:
rC Clang
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner added a comment.
Thanks, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D48667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335770: [clang-tidy/ObjC] Add hashing algorithm acronyms to
objc-property-declaration (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revi
Author: benhamilton
Date: Wed Jun 27 12:13:09 2018
New Revision: 335770
URL: http://llvm.org/viewvc/llvm-project?rev=335770&view=rev
Log:
[clang-tidy/ObjC] Add hashing algorithm acronyms to objc-property-declaration
Summary:
This PR adds a few acronyms related to hashing algorithms to the standar
ashi1 created this revision.
ashi1 added reviewers: yaxunl, b-sumner.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
Should link the bitcodes with caller functions before callee functions.
Repository:
rC Clang
https://reviews.llvm.org/D48667
Files:
lib/Driver/
ldionne added inline comments.
Comment at: include/string:842
+explicit basic_string(const _Tp& __t,
+ typename
enable_if<__can_be_converted_to_string_view<_CharT, _Traits, _Tp>::value,
void>::type* = 0);
+
mclow.lists wrote:
> ldion
NoQ added a comment.
I think this looks good. There's a problem with missing construction contexts,
but i guess that's not the checker's fault, so let's add a FIXME and commit.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:454-455
+ return;
+const auto O
sylvestre.ledru added a comment.
If you are interested, I executed this checker on Firefox code. Results can be
found here
http://sylvestre.ledru.info/reports/fx-scan-build/
Andi reported this bug https://bugs.llvm.org/show_bug.cgi?id=37965
Repository:
rC Clang
https://reviews.llvm.org/D455
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335765: [HIP] Support flush denormals bitcode (authored by
aaronenyeshi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48493?vs=153146&id=153147#toc
Repository:
rC Clang
https:/
Author: aaronenyeshi
Date: Wed Jun 27 11:58:55 2018
New Revision: 335765
URL: http://llvm.org/viewvc/llvm-project?rev=335765&view=rev
Log:
[HIP] Support flush denormals bitcode
Summary:
Use oclc_daz_opt_on.amdgcn.bc bitcode when option fcuda-flush-denormal-to-zero
is enabled, otherwise use oclc_
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D48493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mclow.lists added inline comments.
Comment at: include/string:842
+explicit basic_string(const _Tp& __t,
+ typename
enable_if<__can_be_converted_to_string_view<_CharT, _Traits, _Tp>::value,
void>::type* = 0);
+
ldionne wrote:
> Is th
ashi1 updated this revision to Diff 153146.
ashi1 added a comment.
Merged checks for flush denorm on and off into single test hip-device-libs.hip
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_dev_l
rjmccall added a comment.
In https://reviews.llvm.org/D48589#1144976, @rogfer01 wrote:
> @rjmccall because we do not want to impact the clients of `ABIArgInfo` I
> thought of two possible approaches
>
> 1. extend `CGFunctionInfo` with a third trailing array (now it has two), with
> as many elem
NoQ added a comment.
Aha, ok, yeah, we should have seen this coming. Whenever a checker tracks pairs
of objects, like containers and iterators, or strings objects and their
internal buffers (https://reviews.llvm.org/D48522), or return values and
out-parameters of the same function call (https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335763: [CUDA] Use atexit() to call module destructor.
(authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48613?vs=153138&id=153144#toc
Repository:
rC Clang
https:/
Author: tra
Date: Wed Jun 27 11:32:51 2018
New Revision: 335763
URL: http://llvm.org/viewvc/llvm-project?rev=335763&view=rev
Log:
[CUDA] Use atexit() to call module destructor.
This matches the way NVCC does it. Doing module cleanup at global
destructor phase used to work, but is, apparently, too
yaxunl added a comment.
better merge these two tests and rename it as hip-device-libs.hip. We can also
add other device lib tests to it later.
https://reviews.llvm.org/D48493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
vsapsai added inline comments.
Comment at: libcxx/include/memory:1479
+struct __has_construct_missing
+: false_type
+{
erik.pilkington wrote:
> vsapsai wrote:
> > erik.pilkington wrote:
> > > Shouldn't this be true_type?
> > I see this is confusing and I'm st
ashi1 updated this revision to Diff 153140.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc
test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc
test/Drive
Author: morehouse
Date: Wed Jun 27 11:24:46 2018
New Revision: 335762
URL: http://llvm.org/viewvc/llvm-project?rev=335762&view=rev
Log:
[UBSan] Add silence_unsigned_overflow flag.
Summary:
Setting UBSAN_OPTIONS=silence_unsigned_overflow=1 will silence all UIO
reports. This feature, combined with
tra updated this revision to Diff 153138.
tra added a comment.
Make destructor registration conditional -- we generate no destructor with
-fcuda-rdc.
Updated the test to reflect changes in destructor registration.
https://reviews.llvm.org/D48613
Files:
clang/lib/CodeGen/CGCUDANV.cpp
clang/
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:90
+ // by default.
+ bool SameFBits;
+
Sorry for the extremely late review, but this really needs to be renamed.
Please remember that other compiler maintainers are not experts in t
ashi1 updated this revision to Diff 153136.
ashi1 added a comment.
I've updated. Moved the bitcode files into hip_dev_lib and added test for both
on and off flush denorms to zero option.
https://reviews.llvm.org/D48493
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/Inputs/hip_dev_lib/iri
1 - 100 of 188 matches
Mail list logo
