[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

ahatanak added a comment. Note that in order to destruct C++ objects, I'm using pushDestroy which pushes a NormalCleanup when exception handling isn't enabled. This is different from PushDestructorCleanup which always pushes a NormalAndEHCleanup, but I think using pushDestroy is more correct

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

ahatanak created this revision. ahatanak added a reviewer: rjmccall. Herald added a subscriber: dexonsmith. Block copy/dispose helper functions currently aren’t exception-safe. When an exception is thrown in a copy function, the function exits without destroying or releasing C++ objects, ObjC

[libcxx] r337809 - fix nesting of namespace and standard-version check. Also include <__config>

Author: marshall Date: Mon Jul 23 20:56:38 2018 New Revision: 337809 URL: http://llvm.org/viewvc/llvm-project?rev=337809=rev Log: fix nesting of namespace and standard-version check. Also include <__config> Modified: libcxx/trunk/include/span Modified: libcxx/trunk/include/span URL:

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

ldionne added a comment. LGTM. FWIW, I'm really not a huge fan of all these different ways of building libc++. There should be one canonical way of doing it, and it should be simple. However, it seems like this patch is the right thing to do given the changes that have already been made to

[libcxx] r337808 - Disable 'suggest braces' warnings for std::array in tests

Author: marshall Date: Mon Jul 23 20:41:36 2018 New Revision: 337808 URL: http://llvm.org/viewvc/llvm-project?rev=337808=rev Log: Disable 'suggest braces' warnings for std::array in tests Modified: libcxx/trunk/test/std/containers/views/span.cons/deduct.pass.cpp

[PATCH] D49715: [analyzer] CallEvent: Add partially working methods for obtaining the callee stack frame.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. These methods allow reasoning about the stack frame that will be (or was) used when the function will

r337797 - Attempt to fix regression due to r337791

Author: yaxunl Date: Mon Jul 23 19:12:24 2018 New Revision: 337797 URL: http://llvm.org/viewvc/llvm-project?rev=337797=rev Log: Attempt to fix regression due to r337791 Modified: cfe/trunk/test/Driver/hip-toolchain.hip Modified: cfe/trunk/test/Driver/hip-toolchain.hip URL:

r337796 - Fix unused variable warnings; NFC

Author: gbiv Date: Mon Jul 23 19:10:53 2018 New Revision: 337796 URL: http://llvm.org/viewvc/llvm-project?rev=337796=rev Log: Fix unused variable warnings; NFC Looks like MTE was previously used for its SourceLoc, but we're now using a seperate SourceLocation here. Modified:

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek added a comment. I've tested this on macOS and everything seems to be working, Repository: rCXX libc++ https://reviews.llvm.org/D49711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r337788 - Borrow visibility from __fundamental_type_info for generated fundamental type infos

Author: thomasanderson Date: Mon Jul 23 17:43:47 2018 New Revision: 337788 URL: http://llvm.org/viewvc/llvm-project?rev=337788=rev Log: Borrow visibility from __fundamental_type_info for generated fundamental type infos This is necessary so the clang gives hidden visibility to fundamental types

[PATCH] D49643: [HIP] pass `-target-cpu` when running the device-mode compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rC337793: [HIP] pass -target-cpu when running the device-mode compiler (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D49643?vs=156699=156953#toc Repository: rC

r337793 - [HIP] pass -target-cpu when running the device-mode compiler

Author: yaxunl Date: Mon Jul 23 18:40:44 2018 New Revision: 337793 URL: http://llvm.org/viewvc/llvm-project?rev=337793=rev Log: [HIP] pass -target-cpu when running the device-mode compiler Differential Revision: https://reviews.llvm.org/D49643 Modified:

Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

Sorry, and thanks! On Mon, Jul 23, 2018 at 5:32 PM Alex L wrote: > The revert commit is r337782. > > On 23 July 2018 at 17:32, Alex L wrote: > >> Hi, >> >> I had to revert your commit as it caused a number of failures in our >> public and internal CI. >> When building compiler-rt on Darwin

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

aheejin added a comment. This fixes our local waterfall build failure. Thank you! Repository: rCXX libc++ https://reviews.llvm.org/D49711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- updated this revision to Diff 156950. 0x8000- added a comment. Ignore literals implicitly added by the compiler, such as when using a range-for loop over a constant array. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 Files:

[PATCH] D49711: [CMake] Fix the setting of LIBCXX_HEADER_DIR in standalone build

phosek created this revision. phosek added reviewers: EricWF, ldionne, aheejin, arphaman. Herald added subscribers: cfe-commits, christof, mgorny. This is an alternative approach to r337727 which broke the build because libc++ headers were copied into the location outside of directories used by

r337792 - Add missing testcase update for r337790.

Author: rsmith Date: Mon Jul 23 18:23:36 2018 New Revision: 337792 URL: http://llvm.org/viewvc/llvm-project?rev=337792=rev Log: Add missing testcase update for r337790. Modified: cfe/trunk/test/SemaCXX/constant-expression-cxx11.cpp Modified:

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207-208 + +for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) { + QualType ParamTy = FD->getParamDecl(I)->getType(); + if (!ParamTy->isReferenceType() ||

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207-208 + +for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) { + QualType ParamTy = FD->getParamDecl(I)->getType(); + if (!ParamTy->isReferenceType() ||

r337791 - Enable .hip files for test/Driver

Author: yaxunl Date: Mon Jul 23 18:03:44 2018 New Revision: 337791 URL: http://llvm.org/viewvc/llvm-project?rev=337791=rev Log: Enable .hip files for test/Driver Partially revert r334128 due to regressions. Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/test/Driver/lit.local.cfg

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

NoQ added inline comments. Comment at: test/Analysis/inner-pointer.cpp:41-42 +template< class T > +void func_ref(T& a); + Without a definition for this thing, we won't be able to test much. I suggest you to take a pointer to a function directly, i.e. define a

r337790 - Warn if a local variable's initializer retains a pointer/reference to a

Author: rsmith Date: Mon Jul 23 17:55:08 2018 New Revision: 337790 URL: http://llvm.org/viewvc/llvm-project?rev=337790=rev Log: Warn if a local variable's initializer retains a pointer/reference to a non-lifetime-extended temporary object. Added:

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaCast.cpp:94-101 +void updatePartOfExplicitCastFlags(CastExpr *CE) { + // Walk down from the CE to the OrigSrcExpr, and mark all

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

This revision was automatically updated to reflect the committed changes. Closed by commit rC337788: Borrow visibility from __fundamental_type_info for generated fundamental type… (authored by thomasanderson, committed by ). Repository: rC Clang https://reviews.llvm.org/D49109 Files:

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48886: VS 2017 clang integration

dtarditi abandoned this revision. dtarditi added a comment. This is not needed after https://reviews.llvm.org/D42762 was committed. The approach there of using a VSIX package is better than the script-based approach here. Repository: rL LLVM https://reviews.llvm.org/D48886

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

thomasanderson updated this revision to Diff 156943. thomasanderson added a comment. Added test. Also verified that all tests in llvm/tools/clang/test pass. https://reviews.llvm.org/D49109 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-fundamental.cpp Index:

Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

Hi, I had to revert your commit as it caused a number of failures in our public and internal CI. When building compiler-rt on Darwin (stage1), after this commit the build failed to build X-ray and libfuzzer because the libc++ headers were no longer found. The compiler-rt libraries were built

Re: [libcxx] r337727 - [CMake] Fix the setting of LIBCXX_HEADER_DIR

The revert commit is r337782. On 23 July 2018 at 17:32, Alex L wrote: > Hi, > > I had to revert your commit as it caused a number of failures in our > public and internal CI. > When building compiler-rt on Darwin (stage1), after this commit the build > failed to build X-ray and libfuzzer

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2934 +} else if (const auto *CallE = dyn_cast(S)) { + OS << CallE->getDirectCallee()->getNameAsString(); } rnkovacs wrote: > xazax.hun

r337783 - [WebAssembly] Change size_t to `unsigned long`.

Author: djg Date: Mon Jul 23 17:29:58 2018 New Revision: 337783 URL: http://llvm.org/viewvc/llvm-project?rev=337783=rev Log: [WebAssembly] Change size_t to `unsigned long`. Changing it to unsigned long (which is 32-bit on wasm32) makes it the same type as wasm64 (where unsigned long is 64-bit),

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

This revision was automatically updated to reflect the committed changes. Closed by commit rC337783: [WebAssembly] Change size_t to `unsigned long`. (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D40526 Files:

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

rnkovacs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:213 + if (const auto *FC = dyn_cast()) { +const FunctionDecl *FD = FC->getDecl(); +for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) { xazax.hun

[PATCH] D49656: [analyzer] Add support for more pointer invalidating functions in InnerPointerChecker

rnkovacs updated this revision to Diff 156938. rnkovacs marked 11 inline comments as done. rnkovacs added a comment. Addressed comments & added two test cases for function pointers. https://reviews.llvm.org/D49656 Files: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp

[PATCH] D49067: Stop wrapping __has_include in another macro

mclow.lists accepted this revision. mclow.lists added inline comments. This revision is now accepted and ready to land. Comment at: include/__config:153 +#ifndef __has_include +#define __has_include(...) 0 #endif rsmith wrote: > arichardson wrote: > > EricWF

[libcxx] r337782 - Revert r337727 as it caused Darwin bot failures

Author: arphaman Date: Mon Jul 23 17:27:31 2018 New Revision: 337782 URL: http://llvm.org/viewvc/llvm-project?rev=337782=rev Log: Revert r337727 as it caused Darwin bot failures Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[PATCH] D49067: Stop wrapping __has_include in another macro

rsmith added inline comments. Comment at: include/__config:153 +#ifndef __has_include +#define __has_include(...) 0 #endif arichardson wrote: > EricWF wrote: > > I do prefer not hijacking this name, but if it's needed to make things > > work, then it's OK with

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D49628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r337780 - NFC: Add the emacs c++ mode hint "-*- C++ -*-" to the headers that don't have it

Author: epilk Date: Mon Jul 23 17:07:49 2018 New Revision: 337780 URL: http://llvm.org/viewvc/llvm-project?rev=337780=rev Log: NFC: Add the emacs c++ mode hint "-*- C++ -*-" to the headers that don't have it https://llvm.org/docs/CodingStandards.html#file-headers Modified:

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

efriedma added inline comments. Comment at: lib/AST/ASTContext.cpp:2088 + default: +UnadjustedAlign = getTypeAlign(T); + } This "default" isn't right; there are a lot of non-canonical types which need to be handled here (which getTypeAlign handles, but

r337776 - [analyzer] Add a no-crash to a recently added test.

Author: dergachev Date: Mon Jul 23 16:48:13 2018 New Revision: 337776 URL: http://llvm.org/viewvc/llvm-project?rev=337776=rev Log: [analyzer] Add a no-crash to a recently added test. No functional change intended. Modified: cfe/trunk/test/Analysis/casts.c Modified:

[PATCH] D49338: Implement - P0122R7

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, with a suggestion for adding one test. Comment at: include/span:189 +struct __is_span_compatible_container<_Tp, _ElementType, +void_t< +// is not a

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

This revision was automatically updated to reflect the committed changes. Closed by commit rL337771: Fix typo in test/CodeGen/Mips/dins.ll (authored by thomasanderson, committed by ). Herald added subscribers: llvm-commits, jrtc27. Changed prior to commit:

[PATCH] D49703: [analyzer] pr38273: Admit that we can't handle the newly produced Loc<>NonLoc comparisons.

This revision was automatically updated to reflect the committed changes. Closed by commit rC337769: [analyzer] pr38273: Legalize LocNonLoc comparison symbols. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49703 Files:

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington updated this revision to Diff 156912. erik.pilkington added a comment. In this new patch: - Rebase on top of changes in https://reviews.llvm.org/D46845 - Move in some forward decls that I accidentally left in https://reviews.llvm.org/D46845 - Add some missing visibility

r337769 - [analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols.

Author: dergachev Date: Mon Jul 23 16:09:44 2018 New Revision: 337769 URL: http://llvm.org/viewvc/llvm-project?rev=337769=rev Log: [analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols. Remove an assertion in RangeConstraintManager that expects such symbols to never appear, while admitting

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

vsapsai updated this revision to Diff 156911. vsapsai added a comment. - Tweak the comment according to review comments. Undiscussed changes: we don't stop preprocessing entirely, only in included files; not using better-sounding "skip" deliberately as it might be confused with `FileSkipped`

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

Sorry for the repeated emails. I did more digging and we were indeed handling DT_UNKNOWN incorrectly. I've fixed that in r337768. /Eric On Mon, Jul 23, 2018 at 4:43 PM Eric Fiselier wrote: > Hi Jonas, > > I believe I fixed the issue, and I've recommitted the change as r337765. > Please let me

[libcxx] r337768 - Handle DT_UNKNOWN correctly during directory iteration.

Author: ericwf Date: Mon Jul 23 15:58:46 2018 New Revision: 337768 URL: http://llvm.org/viewvc/llvm-project?rev=337768=rev Log: Handle DT_UNKNOWN correctly during directory iteration. Unlike stat and lstat, where unknown really means we know it's something weird, during directory iteration

r337767 - Support lifetime-extension of conditional temporaries.

Author: rsmith Date: Mon Jul 23 15:56:45 2018 New Revision: 337767 URL: http://llvm.org/viewvc/llvm-project?rev=337767=rev Log: Support lifetime-extension of conditional temporaries. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/CodeGen/CGCleanup.cpp

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson added a comment. pcc ptal I've been granted commit-after-approval, and this is my test CL. https://reviews.llvm.org/D49704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson created this revision. thomasanderson added a reviewer: pcc. Herald added subscribers: atanasyan, arichardson, sdardis. https://reviews.llvm.org/D49704 Files: test/CodeGen/Mips/dins.ll Index: test/CodeGen/Mips/dins.ll

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

This revision was automatically updated to reflect the committed changes. Closed by commit rC337766: [Sema] Fix crash on BlockExprs in a default member initializers (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D49688?vs=156848=156906#toc Repository:

r337766 - [Sema] Fix crash on BlockExprs in a default member initializers

Author: epilk Date: Mon Jul 23 15:47:37 2018 New Revision: 337766 URL: http://llvm.org/viewvc/llvm-project?rev=337766=rev Log: [Sema] Fix crash on BlockExprs in a default member initializers Clang would crash when instantiating a BlockDecl that appeared in a default-member-initializer of a class

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

Hi Jonas, I believe I fixed the issue, and I've recommitted the change as r337765. Please let me know if you still see the failures. I think there might be a lingering issues with how we handle DT_UNKNOWN. /Eric On Mon, Jul 23, 2018 at 3:53 PM Eric Fiselier wrote: > I think I've found the

[PATCH] D49703: [analyzer] pr38273: Admit that we can't handle the newly produced Loc<>NonLoc comparisons.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, mikhail.ramalho. Herald added subscribers: cfe-commits, baloghadamsoftware. This patch fixes the crash caused by https://reviews.llvm.org/D48650 and reported as

[libcxx] r337765 - Recommit "Use possibly cached directory entry values when performing recursive directory iteration."

Author: ericwf Date: Mon Jul 23 15:40:41 2018 New Revision: 337765 URL: http://llvm.org/viewvc/llvm-project?rev=337765=rev Log: Recommit "Use possibly cached directory entry values when performing recursive directory iteration." The initial patch didn't correctly handle systems when the dirent

[libcxx] r337764 - Fix accidentally removed test.

Author: ericwf Date: Mon Jul 23 15:39:56 2018 New Revision: 337764 URL: http://llvm.org/viewvc/llvm-project?rev=337764=rev Log: Fix accidentally removed test. When adding the new tests for the filesystem_error::what method, I incorrectly removed a test case and replaced it with something else.

[PATCH] D48786: [Preprocessor] Stop entering included files after hitting a fatal error.

vsapsai added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1875 + // Stop further preprocessing if a fatal error has occurred. Any diagnostics + // we might have raised will not be visible. + if (ShouldEnter && Diags->hasFatalErrorOccurred())

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. In https://reviews.llvm.org/D49067#1172500, @EricWF wrote: > Where are the special lexing rules specified? In https://bugs.llvm.org/show_bug.cgi?id=37990#c1 @rsmith wrote: > The C++ standard appears to be missing a rule that says that a __has_include > token

[PATCH] D49615: [ASTMatchers] Add an isMain() matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rC337761: [ASTMatchers] Add an isMain() matcher (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r337761 - [ASTMatchers] Add an isMain() matcher

Author: george.karpenkov Date: Mon Jul 23 15:29:35 2018 New Revision: 337761 URL: http://llvm.org/viewvc/llvm-project?rev=337761=rev Log: [ASTMatchers] Add an isMain() matcher Differential Revision: https://reviews.llvm.org/D49615 Modified: cfe/trunk/docs/LibASTMatchersReference.html

r337760 - [ASTMatchers] [NFC] Regenerate HTML docs.

Author: george.karpenkov Date: Mon Jul 23 15:29:10 2018 New Revision: 337760 URL: http://llvm.org/viewvc/llvm-project?rev=337760=rev Log: [ASTMatchers] [NFC] Regenerate HTML docs. Modified: cfe/trunk/docs/LibASTMatchersReference.html Modified: cfe/trunk/docs/LibASTMatchersReference.html

[libcxxabi] r337759 - [demangler] call terminate() if allocation failed

Author: epilk Date: Mon Jul 23 15:23:04 2018 New Revision: 337759 URL: http://llvm.org/viewvc/llvm-project?rev=337759=rev Log: [demangler] call terminate() if allocation failed We really should set *status to memory_alloc_failure, but we need to refactor the demangler a bit to properly propagate

[PATCH] D49638: [libcxxabi] Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0

This revision was automatically updated to reflect the committed changes. Closed by commit rL337754: Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0 (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[libcxxabi] r337754 - Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0

Author: mstorsjo Date: Mon Jul 23 15:09:23 2018 New Revision: 337754 URL: http://llvm.org/viewvc/llvm-project?rev=337754=rev Log: Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0 This allows handling SEH based exceptions, with unwind functions provided by libgcc.

[PATCH] D49067: Stop wrapping __has_include in another macro

EricWF added a reviewer: mclow.lists. EricWF added a subscriber: mclow.lists. EricWF added a comment. Where are the special lexing rules specified? Comment at: include/__config:153 +#ifndef __has_include +#define __has_include(...) 0 #endif I do prefer not

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu added a comment. my general theory is that it's better to have tests that test everything at once if possible, but I guess it's unlikely enough that the debug info path will be correct in the IR and then not correct in the generated file and that that won't be caught by LLVM tests.

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. Ping? Repository: rCXX libc++ https://reviews.llvm.org/D49067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r337736 - [CodeGen] Record if a C++ record is a trivial type

Author: asmith Date: Mon Jul 23 13:49:07 2018 New Revision: 337736 URL: http://llvm.org/viewvc/llvm-project?rev=337736=rev Log: [CodeGen] Record if a C++ record is a trivial type Summary: This has a dependence on D45122 Reviewers: rnk, zturner, llvm-commits, aleksandr.urakov Reviewed By: rnk

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Ah, so you mean you need it for libc++abi because you want to build them but not install them (so they're linked into libc++)? Then LGTM as-is. I'd like to see what Eric has to say though.

Re: [libcxx] r337669 - Use possibly cached directory entry values when performing recursive directory iteration.

I think I've found the bug, but I need to spend some more time on it. I've reverted in for now in r337749. /Eric On Mon, Jul 23, 2018 at 1:25 PM Eric Fiselier wrote: > Thanks. I'm looking into this. > > /Eric > > On Mon, Jul 23, 2018 at 12:58 PM Jonas Hahnfeld wrote: > >> Hi Eric, >> >> this

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. It makes sense that the BlockDecl's parent DC is the class, although I think it would be even better if we took a page from Swift and make a special DC for initializer expressions. I

[libcxx] r337749 - Revert "Use possibly cached directory entry values when performing recursive directory iteration."

Author: ericwf Date: Mon Jul 23 14:52:29 2018 New Revision: 337749 URL: http://llvm.org/viewvc/llvm-project?rev=337749=rev Log: Revert "Use possibly cached directory entry values when performing recursive directory iteration." This reverts commit 04ce4aef00d3ee508327f6cf7bf1b1d200ab6238.

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

erik.pilkington added a comment. In https://reviews.llvm.org/D49688#1172269, @rjmccall wrote: > I honestly don't know why the `BlockDecl` is in the members list in the first > place; that seems wrong, for the same reason that we wouldn't (I assume?) > consider a lambda's implicit record to be

[PATCH] D49338: Implement - P0122R7

ldionne added inline comments. Comment at: include/span:217 +using pointer= _Tp *; +using const_pointer = const _Tp *; // not in standard +using reference = _Tp &; mclow.lists wrote: > ldionne wrote: > > Why are

r337746 - [clang-cl] Expose -fblocks and -fno-builtin as driver flags

Author: rnk Date: Mon Jul 23 14:29:43 2018 New Revision: 337746 URL: http://llvm.org/viewvc/llvm-project?rev=337746=rev Log: [clang-cl] Expose -fblocks and -fno-builtin as driver flags Users have requested them. Helps with PR36427. Modified: cfe/trunk/include/clang/Driver/Options.td

[PATCH] D49338: Implement - P0122R7

mclow.lists marked an inline comment as done. mclow.lists added a comment. > I missed the container constructors being `noexcept` Never mind; they're not `noexcept` (and they should not be) https://reviews.llvm.org/D49338 ___ cfe-commits mailing

r337743 - Fold -Wreturn-stack-address into general initialization lifetime

Author: rsmith Date: Mon Jul 23 14:21:22 2018 New Revision: 337743 URL: http://llvm.org/viewvc/llvm-project?rev=337743=rev Log: Fold -Wreturn-stack-address into general initialization lifetime checking. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r337744 - Do not try to perform lifetime-extension through conditional

Author: rsmith Date: Mon Jul 23 14:21:24 2018 New Revision: 337744 URL: http://llvm.org/viewvc/llvm-project?rev=337744=rev Log: Do not try to perform lifetime-extension through conditional expressions. CodeGen can't cope with that yet. Instead, produce a "not supported" warning for now and don't

Re: r337627 - Fold dangling-field warning into general initialization lifetime checks.

Thanks, fixed and re-committed in r337726. On Sun, 22 Jul 2018 at 23:33, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reverted in r337671 > > On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov > wrote: > >> Hi Richard, >> >> this commit seems to cause invalid warning in the

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 13 inline comments as done. mclow.lists added a comment. I missed the container constructors being `noexcept`, and the asserts on `operator[]` and `operator()` are half done (stupid signed indicies). I'll wait for other feedback before doing those bits.

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. You're right that we don't need these flags for libc++, we only need them for libc++abi and libunwind for the cases when one of these is linked into libc++ or libc++abi respectively. I added them for consistency, but I'm fine dropping them from libc++, would that be

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

probinson added a comment. In https://reviews.llvm.org/D49652#1172352, @alxu wrote: > I was just going to run llvm-dwarfdump. Well, that's one of those quirks I mentioned. This is a Clang change, and Clang tests should exercise as little of LLVM as possible. That means you don't generate

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

alxu added a comment. FYI, gcc uses the stupid and bad string prefix matching approach. if clang supports the same option, it should have the same behavior. you could decide that it's a bad idea, but then the option should be called something else, otherwise people will have to go back to

r337738 - Update to -r337585, allow scoped enum inits in -pedantic

Author: erichkeane Date: Mon Jul 23 14:08:13 2018 New Revision: 337738 URL: http://llvm.org/viewvc/llvm-project?rev=337738=rev Log: Update to -r337585, allow scoped enum inits in -pedantic Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/Type.cpp

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

rjmccall added a comment. Are you sure you shouldn't do it based on some sort of actual annotation based on the frontend's knowledge of types instead of adding semantics for LLVM IR types that were never intended? https://reviews.llvm.org/D49403

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

alxu added a comment. I was just going to run llvm-dwarfdump. Repository: rC Clang https://reviews.llvm.org/D49652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

Test? On Mon, Jul 23, 2018 at 11:49 PM, Aaron Smith via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type > (authored by asmith, committed by ). > >

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

olga.chupina added a comment. Yes, correct. https://reviews.llvm.org/D49403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type

This revision was automatically updated to reflect the committed changes. Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type (authored by asmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index:

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 156862. emmettneyman added a comment. Made fixes to patch, rebased CMake file Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 5 inline comments as done. mclow.lists added a comment. I think I've answered all of Louis' questions that don't require code changes. New patch will be coming soon. Comment at: include/span:217 +using pointer= _Tp *; +using

[PATCH] D49652: Apply -fdebug-prefix-map in reverse of command line order

probinson added a comment. Re. SmallVector versus std::vector, they are functionally similar but have different memory-allocation behaviors. SmallVector includes a vector of N elements (where N is the template parameter) so does no dynamic allocation until you have more than N elements; but

[PATCH] D49688: [Sema] Fix a crash when a BlockExpr appears in a default-member-initializer of a class template

rjmccall added a comment. I honestly don't know why the `BlockDecl` is in the members list in the first place; that seems wrong, for the same reason that we wouldn't (I assume?) consider a lambda's implicit record to be a member. Repository: rC Clang https://reviews.llvm.org/D49688

Re: r337433 - [clang]: Add support for "-fno-delete-null-pointer-checks"

Agree, will try to add separate testcase soon. Thanks, Manoj On Mon, Jul 23, 2018 at 12:39 PM Richard Smith wrote: > Hi Manoj, > > Please can you add better test coverage that we don't emit 'nonnull' > annotations for reference parameters / return values? At the moment, the > only such test

[PATCH] D49403: More aggressively complete RecordTypes with Function Pointers

rjmccall added a comment. Sorry, I'm not following you. Are you doing some sort of type-based security analysis based on LLVM IR types? https://reviews.llvm.org/D49403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49597: [ms] Fix mangling of vector types in QMM_Result contexts.

thakis closed this revision. thakis added a comment. r337732, thanks! https://reviews.llvm.org/D49597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >