[PATCH] D48523: [clang-tidy] Update run-clang-tidy.py with vfsoverlay arg

jdemeule added a comment. Kindly ping reviewers. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. Ping! it would be awesome to get some help getting this merged since I do not have merge rights Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D50552: [ASTImporter] Added test case for CXXConversionDecl importing

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50552 Files: test/Import/conversion-decl/Inputs/F.cpp test/Import/conversion-decl/test.cpp Index: test/Import/conversion-decl/test.cpp =

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. https://reviews.llvm.org/D50551 Files: test/std/containers/associative/map/map.access/at.pass.cpp test/std/containers/unord/unord.map/unord.map.elem/at.pass.cpp Index: test/std/containers/unord/unord.map/unor

[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

rjmccall accepted this revision. rjmccall added a comment. LGTM. Comment at: lib/CodeGen/CGObjCGNU.cpp:915 +return name; + } /// The GCC ABI superclass message lookup function. Takes a pointer to a theraven wrote: > rjmccall wrote: > > theraven wrote:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D50152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

EricWF added a comment. We should add some TSAN folks to this review, since I think these are also TSAN false negatives; perhaps correctly, perhaps not. https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D50550: [ASTImporter] Added test case for opaque enums

teemperor updated this revision to Diff 160057. teemperor added a comment. - Removed broken FileCheck directive https://reviews.llvm.org/D50550 Files: test/Import/enum/Inputs/S.cpp test/Import/enum/test.cpp Index: test/Import/enum/test.cpp =

[PATCH] D50550: [ASTImporter] Added test case for opaque enums

teemperor created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D50550 Files: test/Import/enum/Inputs/S.cpp test/Import/enum/test.cpp Index: test/Import/enum/test.cpp ==

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. Herald added a subscriber: jfb. - Repair thread-unsafe modifications of n_alive in F.pass.cpp In this example, the ctor of G runs in the main thread in the expression G(), and also in the copy ctor of G() in the D

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 160053. ahatanak marked an inline comment as done. ahatanak added a comment. Replace the two flags, EHOnly and DisposeCannotThrow, passed to pushCaptureCleanup with a single flag ForCopyHelper. Repository: rC Clang https://reviews.llvm.org/D50152 Files

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1725 BlockFieldFlags Flags, bool EHOnly, + bool DisposeCannotThrow, VarDecl *Var, CodeGenFunction &CGF) { ---

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak updated this revision to Diff 160046. ahatanak marked 2 inline comments as done. ahatanak added a comment. Call MarkFunctionReferenced to mark the function `__builtin_operator_new` or `__builtin_operator_delete` will call as referenced. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek created this revision. phosek added reviewers: rnk, echristo, chandlerc, beanz. Herald added subscribers: cfe-commits, JDevlieghere, mgorny. Previously we used target triple as provided which matches the GCC behavior, but it also means that all clients have to be consistent in their spellin

r339409 - Fix size calculation from r339380

Author: rtrieu Date: Thu Aug 9 18:30:10 2018 New Revision: 339409 URL: http://llvm.org/viewvc/llvm-project?rev=339409&view=rev Log: Fix size calculation from r339380 r339380 changed the trailing types of ParsedAttr to use llvm::TrailingObjects. However, it did not copy over one of the size attri

[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.

lichray added a comment. LGTM. @ldionne 's job to confirm. https://reviews.llvm.org/D50543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1725 BlockFieldFlags Flags, bool EHOnly, + bool DisposeCannotThrow, VarDecl *Var, CodeGenFunction &CGF) { ---

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 160040. ahatanak marked an inline comment as done. ahatanak added a comment. Define functions inline in the header file. Repository: rC Clang https://reviews.llvm.org/D50152 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/CodeGen/

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. @rsmith any more feedback on this current version? If it still looks incorrect to use the record this way, I don't mind simplifying it to work on lvalue to rvalue conversions without checking for a leading address space operation. Repository: rC Clang https://re

[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.

vsapsai created this revision. vsapsai added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: dexonsmith, christof. was added in r338479. Previous libcxx versions don't have this functionality and corresponding tests should be failing. https://reviews.

[PATCH] D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro

IdrissRio updated this revision to Diff 160039. IdrissRio added a comment. Yes it works also for the non macro. It is actually more general. This update have passed all the tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49800 Files: clang-tidy/modernize/RedundantVoidAr

[PATCH] D50527: [Parser] Support alternative operator token keyword args in Objective-C++

erik.pilkington added a comment. In https://reviews.llvm.org/D50527#1194660, @rjmccall wrote: > Assuming you've done enough source-compatibility testing to say with > reasonable confidence that this won't break anything, I think this is fine. > It's a core goal of Objective-C/C++ to allow the

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

leonardchan accepted this revision. leonardchan added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-doc/MDGenerator.cpp:79 + +void writeHeader(const Twine &Text, int Num, raw_ostream &OS) { + OS << std::string(Num, '#') + "

[PATCH] D50534: [libc++] Fix handling of negated character classes in regex

timshen added a comment. I'm not fully equipped with the context right now, but something doesn't add up. if `__neg_chars_.empty()` check is removed, the `(__neg_mask_ == 0)` above should be removed too. They have to be consistent. However, there is more weirdness in it. The comment above descr

[PATCH] D50527: [Parser] Support alternative operator token keyword args in Objective-C++

rjmccall added a comment. Assuming you've done enough source-compatibility testing to say with reasonable confidence that this won't break anything, I think this is fine. It's a core goal of Objective-C/C++ to allow the base language as a complete subset if at all possible. https://reviews.l

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added inline comments. Comment at: include/clang/AST/ASTContext.h:161 +Expr *getCopyExpr() const; +bool canThrow() const; +llvm::PointerIntPair ExprAndFlag; These should all just be defined inline. Comment at: lib/CodeGen/C

[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

vsapsai added a comment. Known issues: - No support for 'fallthrough' in crash reproducer. - Current way of working with modules in VFS "root" is clunky and error-prone. Also I don't like that VFSFromYamlDirIterImpl is similar to overlay iterator but doesn't share code. At the moment I think it

[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

vsapsai created this revision. vsapsai added reviewers: bruno, benlangmuir. Herald added a subscriber: dexonsmith. Default property value 'true' preserves current behavior. Value 'false' can be used to create VFS "root", file system that gives better control over which files compiler can use durin

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D36892#1187959, @JonasToth wrote: > @lebedev.ri and @alexfh i would change the tests in > https://reviews.llvm.org/D48714 to use CHECK-NOTES. Is it ok, to commit th

[PATCH] D50409: Remove obsolete set call

This revision was automatically updated to reflect the committed changes. Closed by commit rL339402: Remove obsolete set call (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50409 Files: cfe/trunk/lib/Sema/SemaDec

r339402 - Remove obsolete set call

Author: steveire Date: Thu Aug 9 15:44:03 2018 New Revision: 339402 URL: http://llvm.org/viewvc/llvm-project?rev=339402&view=rev Log: Remove obsolete set call Summary: Case case of the switch statement here makes the same call, but it is already done at the start of the function. Reviewers: rsm

[PATCH] D50409: Remove obsolete set call

This revision was automatically updated to reflect the committed changes. Closed by commit rC339402: Remove obsolete set call (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D50409?vs=159602&id=160026#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D50355: Port getLocEnd -> getEndLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339401: Port getLocEnd -> getEndLoc (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Chang

[clang-tools-extra] r339401 - Port getLocEnd -> getEndLoc

Author: steveire Date: Thu Aug 9 15:43:02 2018 New Revision: 339401 URL: http://llvm.org/viewvc/llvm-project?rev=339401&view=rev Log: Port getLocEnd -> getEndLoc Subscribers: nemanjai, ioeric, kbarton, cfe-commits Differential Revision: https://reviews.llvm.org/D50355 Modified: clang-tools

[PATCH] D50354: Port getLocStart -> getBeginLoc

steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50354 ___ cfe-commit

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D49851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D50447: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro

alexfh added inline comments. Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:246-247 + Lambda->getLambdaClass()->getLambdaTypeInfo()->getTypeLoc(); + End = SM->getSpellingLoc(TypeLoc.getLocEnd()); + Begin = SM->getSpellingLoc(TypeLoc.getLocStart());

[PATCH] D50389: [clang-tidy] new check for Abseil

alexfh added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-division.rst:8 +division of two ``absl::Duration`` objects returns an ``int64`` with any fractional +component truncated toward 0. See `this link

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

rsmith added inline comments. Comment at: test/SemaCUDA/call-host-fn-from-device.cu:88 __host__ __device__ void class_specific_delete(T *t, U *u) { - delete t; // ok, call sized device delete even though host has preferable non-sized version + delete t; // expected-error {{re

[PATCH] D50493: AMDGPU: Add another missing builtin

arsenm closed this revision. arsenm added a comment. r339395 https://reviews.llvm.org/D50493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r339395 - AMDGPU: Add another missing builtin

Author: arsenm Date: Thu Aug 9 15:18:37 2018 New Revision: 339395 URL: http://llvm.org/viewvc/llvm-project?rev=339395&view=rev Log: AMDGPU: Add another missing builtin Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-ci.cl cfe/tr

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:3463 + DiagnoseUseOfDecl(OperatorNewOrDelete, TheCall->getExprLoc()); + Are we also missing a `MarkFunctionReferenced` call here? (I don't think it matters much for the predefined new/delete,

[PATCH] D50530: Added LLVM metadata to generated IR to increase vectorization width

This revision was automatically updated to reflect the committed changes. Closed by commit rL339392: Added LLVM metadata to generated IR to increase vectorization width (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50530?vs=160016&id=160017#toc R

r339392 - Added LLVM metadata to generated IR to increase vectorization width

Author: emmettneyman Date: Thu Aug 9 14:59:01 2018 New Revision: 339392 URL: http://llvm.org/viewvc/llvm-project?rev=339392&view=rev Log: Added LLVM metadata to generated IR to increase vectorization width Summary: Edited `loop_proto_to_llvm` to emit metadata at the end of the generated IR. Thi

[PATCH] D50530: Added LLVM metadata to generated IR to increase vectorization width

emmettneyman updated this revision to Diff 160016. emmettneyman added a comment. Rebased and ready to land Repository: rC Clang https://reviews.llvm.org/D50530 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

NoQ added a comment. Hmm, this might make a good `optin.*` checker. Also i see that this is a pure AST-based checker; did you consider putting this into `clang-tidy`? Like, you shouldn't if you're not using `clang-tidy` yourself (it's a bit messy) but this is an option. Also we're actively usin

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia marked 9 inline comments as done. deannagarcia added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:32 + hasImplicitDestinationType(qualType(unless(isInteger(, + unless(hasParent(cxxStaticCastExpr(, + this); --

[PATCH] D50389: [clang-tidy] new check for Abseil

deannagarcia updated this revision to Diff 160013. Herald added a subscriber: mgorny. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett marked 2 inline comments as done. juliehockett added a comment. In https://reviews.llvm.org/D48909#1194501, @leonardchan wrote: > Should there be any tests associated with these changes? There are, this is just supposed to be a NFC so the tests don't need to change. They all pass

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

juliehockett marked 2 inline comments as done. juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:308 - llvm::errs() << "Invalid type for info.\n"; - exit(1); } leonardchan wrote: > Probably not important or it's just

[PATCH] D48909: [clang-doc] Update BitcodeReader to use llvm::Error

leonardchan added a comment. Should there be any tests associated with these changes? Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:308 - llvm::errs() << "Invalid type for info.\n"; - exit(1); } Probably not important or it's just me being picky/

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans added a comment. I probably don't need a unit test AND a lit test, but I'm unsure which one is best here. Any suggestion? Comment at: lib/Format/UnwrappedLineFormatter.cpp:1045-1047 +if (TheLine.First->Next && TheLine.First->Next->Tok.isObjCAtKeyword(tok::objc_en

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans abandoned this revision. acoomans added a comment. Changed approach based on feedback. New changeset: https://reviews.llvm.org/D50535 https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

arphaman updated this revision to Diff 160007. arphaman marked an inline comment as done. arphaman added a comment. remove parameter. https://reviews.llvm.org/D50415 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Diagnostics.h clangd/Protocol.cpp clangd/Protocol.h

[PATCH] D50535: Fix selective formatting of ObjC scope

acoomans created this revision. acoomans added a reviewer: cfe-commits. ObjC scopes gets formatted beyond the `@end` directive, when formatting specific lines (`clang-format -lines=x:x`). This changeset fixes formatting of `@end` the same way that `r_braces` are. Repository: rC Clang https:

r339389 - Fix and recommit r339382 based on solution from RSmith:

Author: erichkeane Date: Thu Aug 9 14:18:13 2018 New Revision: 339389 URL: http://llvm.org/viewvc/llvm-project?rev=339389&view=rev Log: Fix and recommit r339382 based on solution from RSmith: As sent on cfe-commits: "You need to use "friend TrailingObjects;" here, not "friend class TrailingOb

RE: r339387 - Revert -r339382, which apparently breaks the Windows build.

AH! Thanks! I was just messing around on Godbolt to try to figure out what was going on. From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Thursday, August 9, 2018 2:16 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r339387 - Revert -r339382, which apparently breaks the Windows build

Re: r339387 - Revert -r339382, which apparently breaks the Windows build.

On Thu, 9 Aug 2018 at 14:14, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Thu Aug 9 14:13:46 2018 > New Revision: 339387 > > URL: http://llvm.org/viewvc/llvm-project?rev=339387&view=rev > Log: > Revert -r339382, which apparently breaks the Windows

[PATCH] D50534: [libc++] Fix handling of negated character classes in regex

ldionne added a comment. The changeset that introduced this regression was reviewed as https://reviews.llvm.org/D37955. @timshen, I'm curious to understand why you or'ed with `__neg_chars_.empty()` when initializing `__in_neg_chars`. The logic's not clear to me, and my tests seem to show that t

r339387 - Revert -r339382, which apparently breaks the Windows build.

Author: erichkeane Date: Thu Aug 9 14:13:46 2018 New Revision: 339387 URL: http://llvm.org/viewvc/llvm-project?rev=339387&view=rev Log: Revert -r339382, which apparently breaks the Windows build. Modified: cfe/trunk/include/clang/Sema/ParsedAttr.h Modified: cfe/trunk/include/clang/Sema/Pars

[PATCH] D50513: clang-cl: Support /guard:cf,nochecks

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! There is some additional work to do to put .gfids$y sections into appropriate comdat sections, but that's future work. https://reviews.llvm.org/D50513

[PATCH] D50534: [libc++] Fix handling of negated character classes in regex

ldionne created this revision. ldionne added reviewers: mclow.lists, timshen. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. This commit fixes a regression introduced in r316095, where we don't match inverted character classes when there's no negated

[PATCH] D50350: Port getLocStart -> getBeginLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339385: Port getLocStart -> getBeginLoc (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. C

[PATCH] D50350: Port getLocStart -> getBeginLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC339385: Port getLocStart -> getBeginLoc (authored by steveire, committed by ). Changed prior to commit: https://reviews

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

tra added inline comments. Comment at: test/SemaCUDA/call-host-fn-from-device.cu:88 __host__ __device__ void class_specific_delete(T *t, U *u) { - delete t; // ok, call sized device delete even though host has preferable non-sized version + delete t; // expected-error {{refer

[PATCH] D50349: Port getStartLoc -> getBeginLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC339384: Port getStartLoc -> getBeginLoc (authored by steveire, committed by ). Changed prior to commit: https://reviews

r339384 - Port getStartLoc -> getBeginLoc

Author: steveire Date: Thu Aug 9 14:05:56 2018 New Revision: 339384 URL: http://llvm.org/viewvc/llvm-project?rev=339384&view=rev Log: Port getStartLoc -> getBeginLoc Reviewers: teemperor! Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50349 Modified: cfe/trunk/i

r339383 - [NFC] Complete the rule-of-5 for ParsedAttr

Author: erichkeane Date: Thu Aug 9 14:04:34 2018 New Revision: 339383 URL: http://llvm.org/viewvc/llvm-project?rev=339383&view=rev Log: [NFC] Complete the rule-of-5 for ParsedAttr Add move assign/construct as 'deleted' to ParsedAttr to complete the rule-of-5. Modified: cfe/trunk/include/cla

r339382 - [NFC] Simplify 'friend' declaration in ParsedAttr

Author: erichkeane Date: Thu Aug 9 14:03:39 2018 New Revision: 339382 URL: http://llvm.org/viewvc/llvm-project?rev=339382&view=rev Log: [NFC] Simplify 'friend' declaration in ParsedAttr As suggested in the post-commit review for D50531, change from the templatized TrailingObjects friend declarat

[PATCH] D50531: [NFC] Convert ParsedAttr to use llvm::TrailingObjects

riccibruno added a comment. Some inline comments. Since you already committed it I don't think it is worth bothering with them. Comment at: cfe/trunk/include/clang/Sema/ParsedAttr.h:124 + detail::TypeTagForDatatypeData, ParsedType, detail::PropertyData>; + + size_t numTra

[PATCH] D50527: [Parser] Support alternative operator token keyword args in Objective-C++

erik.pilkington updated this revision to Diff 159995. erik.pilkington added a comment. Remove `isBinaryCXXAlternativeOperatorToken`, this check can be done using `OpToken.getAsIdentifierInfo()`. Thanks! FWIW, I can't imagine this being anything but an oversight, we go out of our way to support

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

jlebar added a comment. +tra in the hopes that perhaps he's comfortable reviewing this (sorry that I'm not). Repository: rC Clang https://reviews.llvm.org/D47757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

RE: r339307 - [CMake] Use normalized Windows target triples

Hi Petr, Various Windows bots have been failing with ~270 test failures, and this commit seems like the most probable culprit. For example: http://lab.llvm.org:8011/builders/clang-x86-ninja-win7/builds/12460 Could you please investigate? Thanks, --paulr > -Original Message- > From: cfe-c

[PATCH] D50530: Added LLVM metadata to generated IR to increase vectorization width

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. Code LGTM, but let's make sure this actually helps before landing. Repository: rC Clang https://reviews.llvm.org/D50530 ___ cfe-commits

[PATCH] D50351: Port getLocEnd -> getEndLoc

steveire accepted this revision. steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rC Clang https://reviews.llvm.org/D50351 ___

[PATCH] D50350: Port getLocStart -> getBeginLoc

steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rC Clang https://reviews.llvm.org/D50350 ___ cfe-commits mailing list

[PATCH] D50349: Port getStartLoc -> getBeginLoc

steveire accepted this revision. steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rC Clang https://reviews.llvm.org/D50349 ___

[PATCH] D50348: :Add getEndLoc API to replace getLocEnd

steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rL LLVM https://reviews.llvm.org/D50348 ___ cfe-commits mailing list

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rC Clang https://reviews.llvm.org/D50347 ___ cfe-commits mailing list

[PATCH] D50346: Add getBeginLoc API to replace getLocStart

steveire added a comment. Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html Repository: rC Clang https://reviews.llvm.org/D50346 ___ cfe-commits mailing list

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

efriedma added a comment. Somewhere around CompilerInvocation::CreateFromArgs is probably appropriate. Repository: rL LLVM https://reviews.llvm.org/D45619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D50507: [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed

efriedma added a comment. Do we need to check for homogeneous aggregates of half vectors somewhere? https://reviews.llvm.org/D50507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r339380 - [NFC] Convert ParsedAttr to use llvm::TrailingObjects

Author: erichkeane Date: Thu Aug 9 13:25:12 2018 New Revision: 339380 URL: http://llvm.org/viewvc/llvm-project?rev=339380&view=rev Log: [NFC] Convert ParsedAttr to use llvm::TrailingObjects ParsedAttr is using a hand-rolled trailing-objects implementation that gets cleaned up quite a bit by just

[PATCH] D50531: [NFC] Convert ParsedAttr to use llvm::TrailingObjects

This revision was automatically updated to reflect the committed changes. Closed by commit rL339380: [NFC] Convert ParsedAttr to use llvm::TrailingObjects (authored by erichkeane, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50531?v

r339379 - Fix build

Author: steveire Date: Thu Aug 9 13:21:09 2018 New Revision: 339379 URL: http://llvm.org/viewvc/llvm-project?rev=339379&view=rev Log: Fix build Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL: http://llvm.org/viewvc/llvm-project/c

[PATCH] D50530: Added LLVM metadata to generated IR to increase vectorization width

emmettneyman updated this revision to Diff 159993. emmettneyman added a comment. Switched the include statement to the cpp file Repository: rC Clang https://reviews.llvm.org/D50530 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzzer/proto-

[PATCH] D50530: Added LLVM metadata to generated IR to increase vectorization width

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:141 +<< "!1 = !{!\"llvm.loop.vectorize.enable\", i1 true}\n" +<< "!2 = !{!\"llvm.loop.vectorize.width\", i32 " << kArraySize +<< "}\n"

[PATCH] D50179: [AArch64][ARM] Context sensitive meaning of option "crypto"

SjoerdMeijer updated this revision to Diff 159991. https://reviews.llvm.org/D50179 Files: lib/Driver/ToolChains/Arch/AArch64.cpp lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/arm-features.c test/Preprocessor/aarch64-target-features.c Index: test/Preprocessor/aarch64-target-features.c ==

[PATCH] D50418: [Sema] Support for P0961R1: Relaxing the structured bindings customization point finding rules

This revision was automatically updated to reflect the committed changes. Closed by commit rL339375: [Sema] P0961R1: Relaxing the structured bindings customization point finding… (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

r339375 - [Sema] P0961R1: Relaxing the structured bindings customization point finding rules

Author: epilk Date: Thu Aug 9 13:11:13 2018 New Revision: 339375 URL: http://llvm.org/viewvc/llvm-project?rev=339375&view=rev Log: [Sema] P0961R1: Relaxing the structured bindings customization point finding rules Differential revision: https://reviews.llvm.org/D50418 Modified: cfe/trunk/l

[PATCH] D50532: Fix a wrong type bug in ParsedAttr::TypeTagForDatatypeData

riccibruno created this revision. riccibruno added a reviewer: erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a wrong type bug inside `ParsedAttr::TypeTagForDatatypeData`. The details to the best of my knowledge are as follow. The incredible

[PATCH] D50531: [NFC] Convert ParsedAttr to use llvm::TrailingObjects

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks. (I'm not sure why `PropertyData` needs special handling rather than being treated as two `IdentifierLoc` arguments, but that's not made any worse here, just perhaps a bit m

[PATCH] D50348: :Add getEndLoc API to replace getLocEnd

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339374: Add getEndLoc API to replace getLocEnd (authored by steveire, committed by ). Herald added a subscriber: llvm-comm

[PATCH] D50531: [NFC] Convert ParsedAttr to use llvm::TrailingObjects

erichkeane added inline comments. Comment at: include/clang/Sema/ParsedAttr.h:80 +struct TypeTagForDatatypeData { + ParsedType *MatchingCType; Because all of these became part of the TYPE of ParsedAttr now, they need to be defined outside of ParsedAttr. Addi

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339373: Add getBeginLoc API to replace getStartLoc (authored by steveire, committed by ). Herald added a subscriber: llvm-

r339374 - Add getEndLoc API to replace getLocEnd

Author: steveire Date: Thu Aug 9 13:05:47 2018 New Revision: 339374 URL: http://llvm.org/viewvc/llvm-project?rev=339374&view=rev Log: Add getEndLoc API to replace getLocEnd Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D50348 Modified: cfe/trunk/include/clang/AST

[PATCH] D50346: Add getBeginLoc API to replace getLocStart

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC339372: Add getBeginLoc API to replace getLocStart (authored by steveire, committed by ). Changed prior to commit: http

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC339373: Add getBeginLoc API to replace getStartLoc (authored by steveire, committed by ). Changed prior to commit: http

[PATCH] D50346: Add getBeginLoc API to replace getLocStart

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339372: Add getBeginLoc API to replace getLocStart (authored by steveire, committed by ). Herald added a subscriber: llvm-

  1   2   >