[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang https://reviews.llvm.org/D50451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r340386 - [AST] correct the behavior of -fvisibility-inlines-hidden option (don't make static local variables hidden)

Author: inouehrs Date: Tue Aug 21 22:43:27 2018 New Revision: 340386 URL: http://llvm.org/viewvc/llvm-project?rev=340386&view=rev Log: [AST] correct the behavior of -fvisibility-inlines-hidden option (don't make static local variables hidden) The command line option -fvisibility-inlines-hidden m

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb created this revision. jfb added a reviewer: rjmccall. Herald added subscribers: cfe-commits, dexonsmith. _Atomic and __sync_* operations are implicitly sequentially-consistent. Some codebases want to force explicit usage of memory order instead. This warning allows them to know where implicit

[libcxx] r340385 - Fix Bug 38644: multimap::clear() missing exception specifier. Add noexcept tests for all the containers that have clear().

Author: marshall Date: Tue Aug 21 21:28:43 2018 New Revision: 340385 URL: http://llvm.org/viewvc/llvm-project?rev=340385&view=rev Log: Fix Bug 38644: multimap::clear() missing exception specifier. Add noexcept tests for all the containers that have clear(). Added: libcxx/trunk/test/std/cont

[PATCH] D50564: Add support for SEH unwinding on Windows.

kristina added a comment. In https://reviews.llvm.org/D50564#1208169, @cdavis5x wrote: > OK, I've removed some of the dependencies on Windows-specific types. The code > in `Unwind-seh.cpp` is very Windows-specific, though, so I left it alone. Much appreciated, thank you for your work. LGTM in

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

owenpan added inline comments. Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:128-133 + // Detect "(inline|export)? namespace" in the beginning of a line. + if (NamespaceTok->is(tok::kw_inline) || NamespaceTok->is(tok::kw_export)) NamespaceTok = NamespaceTok->getNext

[PATCH] D51072: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL340378: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D51072: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC340378: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews

r340377 - [analyzer] [NFC] Extract a method for creating RefVal from RetEffect in RetainCountChecker

Author: george.karpenkov Date: Tue Aug 21 18:16:49 2018 New Revision: 340377 URL: http://llvm.org/viewvc/llvm-project?rev=340377&view=rev Log: [analyzer] [NFC] Extract a method for creating RefVal from RetEffect in RetainCountChecker Differential Revision: https://reviews.llvm.org/D51071 Modifi

r340378 - [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker

Author: george.karpenkov Date: Tue Aug 21 18:17:09 2018 New Revision: 340378 URL: http://llvm.org/viewvc/llvm-project?rev=340378&view=rev Log: [analyzer] [NFC] Fix minor formatting issues in RetainCountChecker Differential Revision: https://reviews.llvm.org/D51072 Modified: cfe/trunk/lib/St

[PATCH] D51079: Update the docs for using LLVM toolset in Visual Studio

This revision was automatically updated to reflect the committed changes. Closed by commit rL340376: Update the docs for using LLVM toolset in Visual Studio (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51079?v

r340376 - Update the docs for using LLVM toolset in Visual Studio

Author: steveire Date: Tue Aug 21 18:11:18 2018 New Revision: 340376 URL: http://llvm.org/viewvc/llvm-project?rev=340376&view=rev Log: Update the docs for using LLVM toolset in Visual Studio Reviewers: hans Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D51079 Modifie

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 161866. Quuxplusone added a comment. Update to match the wording in D1144R0 draft revision 13. There's no longer any need to fail when we see a mutable member; on the other hand, we *always* need to perform the special member lookup to find out if our cl

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

joaotavora added a comment. In https://reviews.llvm.org/D50571#1206020, @arphaman wrote: > In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote: > > > > LGTM. Let's watch out for possible breakages in any of the clients, > > > though. I've checked VSCode and it seems to be fine with t

[PATCH] D51079: Update the docs for using LLVM toolset in Visual Studio

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D51079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D51069: Notify pending API removal in the release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL340375: Notify pending API removal in the release notes (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51069 Files: cfe/bra

[PATCH] D51069: Notify pending API removal in the release notes

hans added a comment. In https://reviews.llvm.org/D51069#1208591, @steveire wrote: > @hans Could you commit this on my behalf? I was not able to do it myself for > some reason. > > $ svn commit > svn: E175002: Commit failed (details follow): > svn: E175002: Unexpected HTTP status 400 'Bad Req

[PATCH] D51079: Update the docs for using LLVM toolset in Visual Studio

steveire added a comment. @hans Consider backporting this. Repository: rC Clang https://reviews.llvm.org/D51079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51069: Notify pending API removal in the release notes

steveire added a comment. @hans Could you commit this on my behalf? I was not able to do it myself for some reason. $ svn commit svn: E175002: Commit failed (details follow): svn: E175002: Unexpected HTTP status 400 'Bad Request' on '/svn/llvm-project/!svn/act/2ca88059-6dd7-44fe-aa3e-9fc9f021f

[PATCH] D51079: Update the docs for using LLVM toolset in Visual Studio

steveire created this revision. steveire added a reviewer: hans. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51079 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

rsmith added inline comments. Comment at: lib/Parse/ParseExpr.cpp:1126 + +Actions.StartCheckingNoDeref(); + leonardchan wrote: > rsmith wrote: > > This parser-driven start/stop mechanism will not work in C++ templates. > > Instead, can you remove the "start"

[PATCH] D51077: [clangd] send diagnostic categories only when 'categorySupport' capability was given by the client

arphaman created this revision. arphaman added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, dexonsmith, jkorous, MaskRay, ioeric. After https://reviews.llvm.org/D50571 Clangd started sending categories with each diagnostic, but that broke the eglot client. This patch puts the c

[PATCH] D51068: [Android] Default to -fno-math-errno

srhines accepted this revision. srhines added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} pirama wrote: > I tried to be defens

[PATCH] D51069: Notify pending API removal in the release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rC Clang https://reviews.llvm.org/D51069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D50814: [clangd] transfer the fixits with the notes instead of adding them to the main diagnostic if request by the client

arphaman added a comment. In https://reviews.llvm.org/D50814#1207219, @ilya-biryukov wrote: > Just to make sure I fully understand the use-case: could you elaborate a > little more? Do you need to get exactly the same set of notes that clang > provides? Yep. We are replacing libclang in a cli

[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

arphaman added inline comments. Comment at: lib/Basic/SourceManager.cpp:1705 // If we haven't found what we want yet, try again, but this time stat() // each of the files in case the files have changed since we originally ioeric wrote: > Do we also need t

[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

arphaman updated this revision to Diff 161847. arphaman marked an inline comment as done. arphaman added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D50926 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp unittests/Basic/Source

[PATCH] D51069: Notify pending API removal in the release notes

steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51069 Files: ReleaseNotes.rst Index: ReleaseNotes.rst === --- ReleaseNotes.rst +++ ReleaseNotes.rst @@ -265

r340357 - Add space to TemplateArgument dump

Author: rtrieu Date: Tue Aug 21 15:55:26 2018 New Revision: 340357 URL: http://llvm.org/viewvc/llvm-project?rev=340357&view=rev Log: Add space to TemplateArgument dump Add a missing space when dumping a template argument which is a template expansion. Found during debugging so no test. Modified

Re: r340181 - [OPENMP][BLOCKS]Fix PR38923: reference to a global variable is captured

Merged to 7.0 in r340352. On Mon, Aug 20, 2018 at 9:00 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Mon Aug 20 09:00:22 2018 > New Revision: 340181 > > URL: http://llvm.org/viewvc/llvm-project?rev=340181&view=rev > Log: > [OPENMP][BLOCKS]Fix PR38923: reference to a global va

Re: r340191 - [OPENMP] Fix crash on the emission of the weak function declaration.

Merged to 7.0 in r340351. On Mon, Aug 20, 2018 at 11:03 AM, Alexey Bataev via cfe-commits wrote: > Author: abataev > Date: Mon Aug 20 11:03:40 2018 > New Revision: 340191 > > URL: http://llvm.org/viewvc/llvm-project?rev=340191&view=rev > Log: > [OPENMP] Fix crash on the emission of the weak funct

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:913 +return false; + return Generic_ELF::IsMathErrnoDefault(); +} I tried to be defensive here in case the default changes in the future. I can simplify to just return true here if t

[PATCH] D51068: [Android] Default to -fno-math-errno

pirama created this revision. pirama added reviewers: srhines, enh. Android's libm does not set errno. Repository: rC Clang https://reviews.llvm.org/D51068 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/fast-math.c Index: test/Driver/fast-math.c

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

juliehockett reopened this revision. juliehockett added a comment. This revision is now accepted and ready to land. Herald added a subscriber: kadircet. Reopening because it was reverted and I haven't had time to look into it yet Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

arphaman added inline comments. Comment at: clangd/Threading.cpp:76 + + if (::pthread_attr_setstacksize(&Attr, 8 * 1024 * 1024) != 0) +return; please use clang::DesiredStackSize instead. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50993

[PATCH] D50979: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

thakis closed this revision. thakis added a comment. r340348, thanks! https://reviews.llvm.org/D50979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340348 - Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

Author: nico Date: Tue Aug 21 15:19:55 2018 New Revision: 340348 URL: http://llvm.org/viewvc/llvm-project?rev=340348&view=rev Log: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr(). EmitX86BuiltinExpr() emits all args into Ops at the beginning, so don't do that work ag

[PATCH] D51011: [Preprocessor] raise gcc compatibility macros.

nickdesaulniers added a comment. Thanks Eli. I wholeheartedly prefer feature detection to explicit version checks. One thing that makes this hard is the lack of __has_attribute in gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66970. Repository: rC Clang https://reviews.llvm.org/D51011

[PATCH] D51011: [Preprocessor] raise gcc compatibility macros.

efriedma added a comment. I'd suggest something like this, if you really need to detect the compiler: #if defined(__clang__) // clang #elif defined(__INTEL_COMPILER) // icc #elif defined(__GNUC__) // gcc #else #error "Unknown compiler" #endif > Regarding the glibc headers, do

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

shuaiwang added a comment. In https://reviews.llvm.org/D50619#1207785, @JonasToth wrote: > @shuaiwang Unfortunatly the analysis does not pass and fails on an assertion > > → ~/opt/llvm/build/bin/clang-tidy > -checks=-*,cppcoreguidelines-const-correctness ItaniumDemangle.cpp -- > clang-tidy:

[PATCH] D50617: [ASTMatchers] Let hasObjectExpression also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

shuaiwang updated this revision to Diff 161830. shuaiwang added a comment. Fix issue with implicit access. Repository: rC Clang https://reviews.llvm.org/D50617 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTes

[PATCH] D50979: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D50979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New :doc:`abseil-no-namespace + ` check. Please sort new checks list alphabetically. Comment at: docs/ReleaseNotes.rst:79 +>>> .r340314 Improvements to incl

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

deannagarcia updated this revision to Diff 161827. deannagarcia marked 11 inline comments as done. https://reviews.llvm.org/D50580 Files: clang-tidy/abseil/AbseilMatcher.h clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoNamespaceCheck.cpp clan

[PATCH] D50979: Eliminate instances of `EmitScalarExpr(E->getArg(n))` in EmitX86BuiltinExpr().

thakis updated this revision to Diff 161824. thakis edited the summary of this revision. thakis added a comment. Add tests. https://reviews.llvm.org/D50979 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/ms-intrinsics.c clang/test/CodeGen/ms-x86-intrinsics.c Index: clang/test/C

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:372 - const Driver &D = getDriver(); - SmallString<128> P(D.ResourceDir); - llvm::sys::path::append(P, D.getTargetTriple(), "lib"); - if (getVFS().exists(P)) { + for (const auto &LibPath : getLibraryP

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161821. Herald added a reviewer: javed.absar. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchs

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek added a comment. I also need to create the following empty files for tests to pass (somehow those are not displayed by Phabricator): clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/aarch64-fuchsia/lib/libclang_rt.asan-preinit.a clang/test/Driver/Inputs/resource_dir_with

[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

phosek updated this revision to Diff 161818. Repository: rC Clang https://reviews.llvm.org/D50547 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp Index: clang/lib/Driver/ToolChain.cpp === --- cla

[PATCH] D51011: [Preprocessor] raise gcc compatibility macros.

nickdesaulniers added a comment. Richard, Thanks for the review, context, and suggestions. I appreciate it. > Can you instead change the kernel to require GCC >= 4.6 or some suitable > version of Clang? Can you help me create an accurate C preprocessor check that the compiler in use is actual

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

On Tue, 21 Aug 2018 at 07:41, Anastasia Stulova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If there are no objections I would like to revert this old commit that > coverts error about implicit function declaration into a warning. > > > We have decided to generate an error for this > ht

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

chandlerc added a comment. (To be clear, this continues to not be related to this patch, but happy to discuss...) Comment at: include/stddef.h:55 // Re-use the compiler's max_align_t where possible. #if !defined(__CLANG_MAX_ALIGN_T_DEFINED) && !defined(_GCC_MAX_ALIGN_T) &

[PATCH] D51026: [CodeGen] Implicitly set stackrealign on the main function, if custom stack alignment is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL340334: [CodeGen] Implicitly set stackrealign on the main function, if custom stack… (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r340334 - [CodeGen] Implicitly set stackrealign on the main function, if custom stack alignment is used

Author: mstorsjo Date: Tue Aug 21 13:41:17 2018 New Revision: 340334 URL: http://llvm.org/viewvc/llvm-project?rev=340334&view=rev Log: [CodeGen] Implicitly set stackrealign on the main function, if custom stack alignment is used If using a custom stack alignment, one is expected to make sure tha

Re: [PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

Yes. But in practice nothing really changed though, right? It's just going forward that things might break: "This is a change in contract but not a change in behavior, since the current implementation still allows linking TUs built with different libc++ versions together." On Fri, Aug 17, 2018 at

[PATCH] D51025: [CodeGen] Fix handling of variables captured by a block that is nested inside a lambda

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D51025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:187-191 // If FR is a pointer pointing to a non-primitive type. if (Optional RecordV = DerefdV.getAs()) { const TypedValueRegion *R = RecordV->

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. OK, I've removed some of the dependencies on Windows-specific types. The code in `Unwind-seh.cpp` is very Windows-specific, though, so I left it alone. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x updated this revision to Diff 161807. cdavis5x added a comment. - Make a bit more friendly to non-Windows. - Fix bits that depend on https://reviews.llvm.org/D50413. Repository: rUNW libunwind https://reviews.llvm.org/D50564 Files: include/__libunwind_config.h include/unwind.h

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

NoQ added a comment. Yup, this looks great and that's exactly how i imagined it. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:261-265 +inline bool isLocType(const QualType &T) { + return T->isAnyPointerType() || T->isReferenceType() || +

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

owenpan added inline comments. Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:129-130 + // Detect "(inline|export)? namespace" in the beginning of a line. + if (NamespaceTok->is(tok::kw_inline) || NamespaceTok->is(tok::kw_export)) NamespaceTok = NamespaceTok->getNext

[PATCH] D48896: [libcxx][c++17] P0083R5: Splicing Maps and Sets Part 2: merge

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D48896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51008: Enable -fsanitize=fuzzer and -fsanitize=fuzzer-no-link on Windows.

metzman abandoned this revision. metzman added a comment. Abandoning this revision since I think the libFuzzer on Windows changes would be easier to understand as part of one commit instead of three. New revision here Repository: rC Clang https://reviews.llv

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

Szelethus added a comment. @NoQ, is this how you imagined derefercing to work? I'm still a little uncertain that I implemented this in a way that addresses all your concerns. Repository: rC Clang https://reviews.llvm.org/D51057 ___ cfe-commits m

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:187-191 // If FR is a pointer pointing to a non-primitive type. if (Optional RecordV = DerefdV.getAs()) { const TypedValueRegion *R = Rec

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. This patch aims to fix derefencing, which has been debated for months now. Instead of working with `SVal`

[PATCH] D51056: [ASTImporter] Add test for SwitchStmt

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51056 Files: test/Import/switch-stmt/Inputs/F.cpp test/Import/switch-stmt/test.cpp Index: test/Import/switch-stmt/test.cpp =

[PATCH] D51026: [CodeGen] Implicitly set stackrealign on the main function, if custom stack alignment is used

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CodeGenFunction.cpp:989 +CGM.getCodeGenOpts().StackAlignment) + Fn->addFnAttr("stackrealign"); + mstorsjo wrote: > erichk

[PATCH] D51049: Driver: Enable address-significance tables by default when targeting COFF.

rnk added a comment. Remind me what the approximate size overhead of this is? I expect it is negligible, as most symbols are not address taken. Repository: rL LLVM https://reviews.llvm.org/D51049 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL340322: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D51021 Files: test-suite/trunk/ABI-Testsuite/t

[PATCH] D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL340320: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++ (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D51020 Files: test-suite/tr

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. In https://reviews.llvm.org/D49511#1206267, @rsmith wrote: > In https://reviews.llvm.org/D49511#1206265, @rsmith wrote: > > > In https://reviews.llvm.org/D49511#1194716, @leonardchan wrote: > > > > > @rsmith any more feedback on this current version? If it still looks

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added inline comments. Comment at: lib/Parse/ParseExpr.cpp:1126 + +Actions.StartCheckingNoDeref(); + rsmith wrote: > This parser-driven start/stop mechanism will not work in C++ templates. > Instead, can you remove the "start" part and check the

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 161785. leonardchan marked 6 inline comments as done and an inline comment as not done. Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticGroups.t

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. In https://reviews.llvm.org/D50564#1207493, @kristina wrote: > In https://reviews.llvm.org/D50564#1206393, @mstorsjo wrote: > > > In https://reviews.llvm.org/D50564#1206370, @cdavis5x wrote: > > > > > In https://reviews.llvm.org/D50564#1206302, @kristina wrote: > > > > >

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D44539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. By the way, I didn't review the test cases. Comment at: lib/Format/FormatToken.h:524-525 +// Detect "(inline|export)? namespace" in the beginning of a line. +

[PATCH] D49811: [analyzer] Obtain a ReturnStmt from a CFGAutomaticObjDtor

NoQ added a comment. Herald added a subscriber: Szelethus. In https://reviews.llvm.org/D49811#1175927, @NoQ wrote: > Devin has recently pointed out that we might have as well reordered CFG > elements to have return statement kick in after automatic destructors, so > that callbacks were called i

[PATCH] D50855: [analyzer] pr37578: Fix lvalue/rvalue problem in field-of-temporary adjustments.

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. looks good apart from minor nits Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:744 + const Expr *InitWithAdjustm

[PATCH] D50994: Add a new flag and attributes to control static destructor registration

erik.pilkington added a comment. Sure, done in 340311! Repository: rC Clang https://reviews.llvm.org/D50994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340311 - Address Aaron Ballman's post-commit review comments from r340306, NFC

Author: epilk Date: Tue Aug 21 10:50:10 2018 New Revision: 340311 URL: http://llvm.org/viewvc/llvm-project?rev=340311&view=rev Log: Address Aaron Ballman's post-commit review comments from r340306, NFC Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/test/SemaCXX/no_destroy.cpp Mo

[PATCH] D51049: Driver: Enable address-significance tables by default when targeting COFF.

pcc created this revision. pcc added a reviewer: rnk. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51049 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/addrsig.c Index: clang/test/Driver/addrsig.c =

[PATCH] D50994: Add a new flag and attributes to control static destructor registration

aaron.ballman added a comment. Some minor nits that can be handled post-commit. Comment at: lib/Sema/SemaDeclAttr.cpp:5921 +static void handleDestroyAttr(Sema &S, Decl *D, const ParsedAttr &A) { + if (!isa(D) || !cast(D)->hasGlobalStorage()) { +S.Diag(D->getLocation(), dia

[PATCH] D50994: Add a new flag and attributes to control static destructor registration

This revision was automatically updated to reflect the committed changes. Closed by commit rC340306: Add a new flag and attributes to control static destructor registration (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50994?vs=161594&id=161757#toc Repo

[PATCH] D50994: Add a new flag and attributes to control static destructor registration

This revision was automatically updated to reflect the committed changes. Closed by commit rL340306: Add a new flag and attributes to control static destructor registration (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r340306 - Add a new flag and attributes to control static destructor registration

Author: epilk Date: Tue Aug 21 10:24:06 2018 New Revision: 340306 URL: http://llvm.org/viewvc/llvm-project?rev=340306&view=rev Log: Add a new flag and attributes to control static destructor registration This commit adds the flag -fno-c++-static-destructors and the attributes [[clang::no_destroy]

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC340304: [ASTImporter] Add test for CXXNoexceptExpr (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D50737 Files: test/Import/cxx-noexcept-expr/Inputs/F.cpp te

r340304 - [ASTImporter] Add test for CXXNoexceptExpr

Author: teemperor Date: Tue Aug 21 10:15:57 2018 New Revision: 340304 URL: http://llvm.org/viewvc/llvm-project?rev=340304&view=rev Log: [ASTImporter] Add test for CXXNoexceptExpr Reviewers: a.sidorin, a_sidorin Reviewed By: a_sidorin Subscribers: a_sidorin, hiraditya, martong, cfe-commits Diff

[PATCH] D50737: [ASTImporter] Add test for CXXNoexceptExpr

teemperor added inline comments. Comment at: test/Import/cxx-noexcept-expr/test.cpp:1 +// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s | FileCheck %s + hiraditya wrote: > Can we add a line/comment to explain what this test does? Same f

[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Eugene.Zelenko added a comment. Please rebase from trunk. Comment at: docs/ReleaseNotes.rst:63 + + Checks to ensure code does not open `namespace absl` as that + violates Abseil's compatibility guidelines. Just Ensures. Please use `` for language constructs.

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

JonasToth added a comment. @shuaiwang Unfortunatly the analysis does not pass and fails on an assertion → ~/opt/llvm/build/bin/clang-tidy -checks=-*,cppcoreguidelines-const-correctness ItaniumDemangle.cpp -- clang-tidy: ../tools/clang/include/clang/AST/ExprCXX.h:3581: clang::Expr* clang::CX

[PATCH] D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp

Sunil_Srivastava accepted this revision. Sunil_Srivastava added a comment. This revision is now accepted and ready to land. LGTM Repository: rT test-suite https://reviews.llvm.org/D51021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D50970: [clangd] Implement BOOST iterator

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:92 + /// function, the parameter is needed to propagate through the tree. + virtual unsigned boost(DocID ID) const = 0; Maybe add a note to the comment on why an `I

[PATCH] D50527: [Parser] Support alternative operator token keyword args in Objective-C++

This revision was automatically updated to reflect the committed changes. Closed by commit rC340301: [Parser] Support alternative operator token keyword args in Objective-C++ (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D50527?vs=159995&id=161748#toc Re

r340301 - [Parser] Support alternative operator token keyword args in Objective-C++

Author: epilk Date: Tue Aug 21 09:47:04 2018 New Revision: 340301 URL: http://llvm.org/viewvc/llvm-project?rev=340301&view=rev Log: [Parser] Support alternative operator token keyword args in Objective-C++ rdar://30741878 Differential revision: https://reviews.llvm.org/D50527 Added: cfe/tru

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

jfb added a comment. Isn't this duplicating code in lib/Support/Unix/Threading.inc with a different implementation? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D51001: [ASTImporter] Add test for CXXForRangeStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC340297: [ASTImporter] Add test for CXXForRangeStmt (authored by teemperor, committed by ). Repository: rC Clang https://reviews.llvm.org/D51001 Files: test/Import/cxx-for-range/Inputs/F.cpp test/I

r340297 - [ASTImporter] Add test for CXXForRangeStmt

Author: teemperor Date: Tue Aug 21 09:36:49 2018 New Revision: 340297 URL: http://llvm.org/viewvc/llvm-project?rev=340297&view=rev Log: [ASTImporter] Add test for CXXForRangeStmt Reviewers: a.sidorin, martong Reviewed By: martong Subscribers: rnkovacs, martong, cfe-commits Differential Revisio

[PATCH] D50984: AMDGPU: Move target code into TargetParser

arsenm closed this revision. arsenm added a comment. r340292 https://reviews.llvm.org/D50984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340292 - AMDGPU: Move target code into TargetParser

Author: arsenm Date: Tue Aug 21 09:13:29 2018 New Revision: 340292 URL: http://llvm.org/viewvc/llvm-project?rev=340292&view=rev Log: AMDGPU: Move target code into TargetParser Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/trunk/lib/Basic/Targets/AMDGPU.h Modified: cfe/trunk/lib/Ba

  1   2   >