elsteveogrande created this revision.
elsteveogrande added reviewers: rsmith, dblaikie.
Herald added a subscriber: cfe-commits.
(PR38627)
After deserializing, the `PendingExceptionSpecUpdates` table is iterated over
to apply exception specs to functions. There may be `EST_None`-type in this
sammccall updated this revision to Diff 163751.
sammccall added a comment.
Remove RefsSlab::find()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51605
Files:
clangd/ClangdServer.cpp
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/Index.cpp
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous,
MaskRay, ilya-biryukov.
A few things that I noticed while merging the SwapIndex patch:
- SymbolOccurrences and particularly SymbolOccurrenceSlab are
phosek added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4187
SmallString<128> R(ResourceDir);
llvm::sys::path::append(R, Name);
mcgrathr wrote:
> You could fold these cases into the lambda too by having it take a bool
> UseSysRoot and
Author: sammccall
Date: Mon Sep 3 13:26:26 2018
New Revision: 341337
URL: http://llvm.org/viewvc/llvm-project?rev=341337=rev
Log:
[clangd] Fix index-twice regression from r341242
Modified:
clang-tools-extra/trunk/clangd/index/FileIndex.cpp
Modified:
sammccall updated this revision to Diff 163744.
sammccall added a comment.
Fix comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51585
Files:
clangd/CMakeLists.txt
clangd/RIFF.cpp
clangd/RIFF.h
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
sammccall updated this revision to Diff 163743.
sammccall added a comment.
Fix subtle macro expansion bug!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51585
Files:
clangd/CMakeLists.txt
clangd/RIFF.cpp
clangd/RIFF.h
modocache added a comment.
Excellent, I think pushing this along with https://reviews.llvm.org/D50410
revealed the true error, as an MSAN buildbot tells use there's a use of an
uninitialized value:
usaxena95 added a comment.
Applied the changes suggested.
Comment at: lib/Basic/VirtualFileSystem.cpp:677
+if (HardLinkTarget)
+ Child.reset(new detail::InMemoryHardLink(P.str(), *HardLinkTarget));
+else {
ilya-biryukov wrote:
> NIT:
usaxena95 updated this revision to Diff 163739.
usaxena95 marked 14 inline comments as done.
usaxena95 added a comment.
- applied changes
Repository:
rC Clang
https://reviews.llvm.org/D51359
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341329: Re-push [Option] Fix PR37006 prefix choice in
findNearest (authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
baloghadamsoftware updated this revision to Diff 163736.
baloghadamsoftware added a comment.
Herald added subscribers: Szelethus, mikhail.ramalho.
Checking of constructor parameters moved to `PreCall` check.
https://reviews.llvm.org/D32860
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341327: Removing -debug-info-macros from option suggestions
test (authored by modocache, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: modocache
Date: Mon Sep 3 09:55:02 2018
New Revision: 341327
URL: http://llvm.org/viewvc/llvm-project?rev=341327=rev
Log:
Removing -debug-info-macros from option suggestions test
Summary:
https://reviews.llvm.org/D46776 added better support for prefixes for the
"did you mean ...?"
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341325: [clangd] Some nitpicking around the new split
(preamble/main) dynamic index (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: sammccall
Date: Mon Sep 3 09:37:59 2018
New Revision: 341325
URL: http://llvm.org/viewvc/llvm-project?rev=341325=rev
Log:
[clangd] Some nitpicking around the new split (preamble/main) dynamic index
Summary:
- DynamicIndex doesn't implement ParsingCallbacks, to make its role clearer.
sammccall updated this revision to Diff 163730.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51221
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
sammccall added inline comments.
Comment at: clangd/ClangdServer.cpp:152
WorkScheduler(Opts.AsyncThreadsCount, Opts.StorePreamblesInMemory,
-DynamicIdx ? *DynamicIdx : noopParsingCallbacks(),
+DynamicIdx ?
Author: akirtzidis
Date: Mon Sep 3 09:26:36 2018
New Revision: 341324
URL: http://llvm.org/viewvc/llvm-project?rev=341324=rev
Log:
Add header guards to some headers that are missing them
Modified:
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/lib/CodeGen/MacroPPCallbacks.h
modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.
Thanks! I'll land https://reviews.llvm.org/D50410, then this, and monitor the
buildbots to see what happens. If they fail again I may revert this once again.
Thanks again for looking
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks again for fixing this.
Still a few places I feel the code could be simpler, but will let you decide
how to deal with them.
I would greatly appreciate removing the parameterized
ilya-biryukov added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:478
+public:
+ InMemoryNode(const std::string& FileName, InMemoryNodeKind Kind)
+ : Kind(Kind), FileName(llvm::sys::path::filename(FileName.data())) {}
NIT: accept a parameter
dmgreen updated this revision to Diff 163727.
dmgreen retitled this revision from "[RTTI] Align rtti type string to prevent
over-alignment" to "[RTTI] Align rtti types to prevent over-alignment".
dmgreen edited the summary of this revision.
dmgreen added a comment.
I've become less sure about
baloghadamsoftware updated this revision to Diff 163725.
baloghadamsoftware added a comment.
) added.
https://reviews.llvm.org/D32859
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/mismatched-iterator.cpp
Index: test/Analysis/mismatched-iterator.cpp
baloghadamsoftware updated this revision to Diff 163724.
baloghadamsoftware added a comment.
Comments added, functions renamed.
https://reviews.llvm.org/D32859
Files:
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
test/Analysis/mismatched-iterator.cpp
Index:
sammccall added a comment.
Looking forward to using this!
Unless you object, I'd like to address the remaining comments (and get a
review), so you can make the most of your leave!
Comment at: clangd/XRefs.cpp:333
+
+DeclOccurrences[D].emplace_back(FileLoc, Roles);
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341322: [clangd] Avoid crashes in override completions
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51598
Files:
Author: ibiryukov
Date: Mon Sep 3 08:25:27 2018
New Revision: 341322
URL: http://llvm.org/viewvc/llvm-project?rev=341322=rev
Log:
[clangd] Avoid crashes in override completions
Summary: NamedDecl::getName cannot be called on non-identifier names.
Reviewers: kadircet, ioeric, hokein, sammccall
Author: sammccall
Date: Mon Sep 3 08:23:01 2018
New Revision: 341321
URL: http://llvm.org/viewvc/llvm-project?rev=341321=rev
Log:
[clangd] Fix ambiguous make_unique with c++17. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/IndexTests.cpp
Modified:
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
ioeric wrote:
> ilya-biryukov wrote:
> > Was wondering if testing for crashes
ioeric added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
ilya-biryukov wrote:
> Was wondering if testing for crashes LG this way, or adding
sammccall updated this revision to Diff 163722.
sammccall added a comment.
Rebase with occurrences changes (but don't serialize occurrences yet).
Also incorporate multiple-include-header change, which is tricky as it makes
Symbol variable-length. Current hack is to preserve only the most-popular
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1770
+ // Check the completions call does not crash.
+ completions(R"cpp(
+struct Base {
Was wondering if testing for crashes LG this way, or adding more assertions
ilya-biryukov created this revision.
ilya-biryukov added reviewers: kadircet, ioeric, hokein, sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay.
NamedDecl::getName cannot be called on non-identifier names.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51598
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:3763
+INSTANTIATE_TEST_CASE_P(ParameterizedTests, ImportImplicitMethods,
+DefaultTestValuesForRunOptions, );
This hunk has nothing to do with this change, but
usaxena95 updated this revision to Diff 163720.
usaxena95 added a comment.
- Moved helper function into anonymous namespace
Repository:
rC Clang
https://reviews.llvm.org/D51359
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
martong created this revision.
martong added reviewers: a_sidorin, xazax.hun, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: a.sidorin.
The init expression of a VarDecl is overwritten in the "To" context if we
import
Author: ibiryukov
Date: Mon Sep 3 07:39:34 2018
New Revision: 341319
URL: http://llvm.org/viewvc/llvm-project?rev=341319=rev
Log:
[clangd] Handle errors before checking for cancelltion
To avoid hitting assertions in llvm::Expected destructor.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341318: [clangd] Factor out the data-swapping functionality
from MemIndex/DexIndex. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: sammccall
Date: Mon Sep 3 07:37:43 2018
New Revision: 341318
URL: http://llvm.org/viewvc/llvm-project?rev=341318=rev
Log:
[clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.
Summary:
This is now handled by a wrapper class SwapIndex, so MemIndex/DexIndex can be
ioeric accepted this revision.
ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:47
+ // The shared_ptr keeps the symbols alive.
+ std::shared_ptr buildMemIndex();
kbobyrev wrote:
> sammccall wrote:
> > ioeric wrote:
> > > Maybe avoid
sammccall added a comment.
OK, I think this is good to go again.
(A couple of seemingly-unrelated fixes to SymbolOccurrenceKind that I ran into
in tests)
Comment at: clangd/index/FileIndex.h:47
+ // The shared_ptr keeps the symbols alive.
+ std::shared_ptr buildMemIndex();
sammccall updated this revision to Diff 163715.
sammccall added a comment.
Remove some more shared_ptr occurrences that aren't needed anymore
Update comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51422
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
sammccall updated this revision to Diff 163714.
sammccall added a comment.
Instead of returning shared_ptr, our implementations that have
backing data gain the ability to own that data (without coupling to its form).
Based on offline discussion with @ioeric.
Rebase to pick up SymbolOccurrence
usaxena95 updated this revision to Diff 163713.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
- applied suggested changes
Repository:
rC Clang
https://reviews.llvm.org/D51359
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
usaxena95 marked 16 inline comments as done.
usaxena95 added a comment.
Applied suggested changes.
Comment at: lib/Basic/VirtualFileSystem.cpp:653
+ // Cannot create HardLink from a directory.
+ if (HardLinkTarget && (!isa(HardLinkTarget) || Buffer))
+return false;
This revision was automatically updated to reflect the committed changes.
martong marked an inline comment as done.
Closed by commit rL341316: [ASTImporter] Merge ExprBits (authored by martong,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:3241
+ auto *ToD = Import(FromD, Lang_CXX11);
+ ASSERT_TRUE(ToD);
+ auto *ToInitExpr = cast(ToD)->getAnyInitializer();
a_sidorin wrote:
> EXPECT_TRUE (same below).
Thanks, changed
Author: martong
Date: Mon Sep 3 06:10:53 2018
New Revision: 341316
URL: http://llvm.org/viewvc/llvm-project?rev=341316=rev
Log:
[ASTImporter] Merge ExprBits
Summary:
Some `Expr` classes set up default values for the `ExprBits` of `Stmt`. These
default values are then overwritten by the parser
Author: AlexeySotkin
Date: Mon Sep 3 05:43:26 2018
New Revision: 341314
URL: http://llvm.org/viewvc/llvm-project?rev=341314=rev
Log:
[Index] Update tests allowing double4 type to be "invalid"
Fixes test failure after r341309
Modified:
cfe/trunk/test/Index/opencl-types.cl
Modified:
Author: AlexeySotkin
Date: Mon Sep 3 04:43:22 2018
New Revision: 341309
URL: http://llvm.org/viewvc/llvm-project?rev=341309=rev
Log:
[OpenCL] Traverse vector types for ocl extensions support
Summary:
Given the following kernel:
__kernel void foo() {
double d;
double4 dd;
}
and cl_khr_fp64
Author: psmith
Date: Mon Sep 3 05:36:32 2018
New Revision: 341312
URL: http://llvm.org/viewvc/llvm-project?rev=341312=rev
Log:
[Aarch64] Fix linker emulation for Aarch64 big endian
This patch fixes target linker emulation for aarch64 big endian.
aarch64_be_linux is not recognized by gnu ld. The
ioeric added inline comments.
Comment at: clang-tools-extra/;:1
+//===--- Token.cpp - Symbol Search primitive *- C++
-*-===//
+// The LLVM Compiler Infrastructure
Unintended change?
Comment at:
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Other than a hard-coded `buildMemIndex()` in `FileIndex`, I don't have any
concerns. That's just a tiny piece, if @ioeric doesn't have any concerns about
that too, I think it's good to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341309: [OpenCL] Traverse vector types for ocl extensions
support (authored by AlexeySotkin, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
sammccall added a comment.
This still needs to be synced to head to account for Symbol changes
(multi-includes) but those changes are pretty obvious/mechanical.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51585
___
cfe-commits
sammccall updated this revision to Diff 163688.
sammccall added a comment.
Revert unused changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51585
Files:
clangd/CMakeLists.txt
clangd/RIFF.cpp
clangd/RIFF.h
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous,
MaskRay, ilya-biryukov, mgorny.
This is intended to replace the current YAML format for general use.
It's ~10x more compact than YAML, and ~40% more
devnexen added a comment.
ping
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 163680.
kbobyrev marked 17 inline comments as done.
kbobyrev added a comment.
Address a round of comments, refactor code.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/;
clang-tools-extra/clangd/CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341304: [clangd] Support multiple #include headers in one
symbol. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51291
Author: ioeric
Date: Mon Sep 3 03:18:21 2018
New Revision: 341304
URL: http://llvm.org/viewvc/llvm-project?rev=341304=rev
Log:
[clangd] Support multiple #include headers in one symbol.
Summary:
Currently, a symbol can have only one #include header attached, which
might not work well if the
ioeric updated this revision to Diff 163678.
ioeric added a comment.
- Document limitation for overload bundling.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/Index.h
ioeric updated this revision to Diff 163677.
ioeric added a comment.
- Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51291
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/Merge.cpp
miyuki added a comment.
ping
https://reviews.llvm.org/D50507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
Thanks, the interface and implementation look good!
Last drop of nits and suggestions for code simplification.
Comment at: include/clang/Basic/VirtualFileSystem.h:359
+ public:
+ /// Add a HardLink to a File.
+ /// The To path must be an
baloghadamsoftware marked 3 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317
+def MismatchedIteratorChecker : Checker<"MismatchedIterator">,
+ HelpText<"Check for use of iterators of different
baloghadamsoftware updated this revision to Diff 163671.
baloghadamsoftware added a comment.
Minor changes.
https://reviews.llvm.org/D32845
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/IteratorChecker.cpp
kbobyrev updated this revision to Diff 163667.
kbobyrev marked 2 inline comments as done.
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Rebase on top of `master`, s/Path/PathURI/g to be more explicit about the token
contents and origin.
https://reviews.llvm.org/D51481
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:36
+Result.push_back(PathToken);
+ }
return Result;
nit: no need for braces. [llvm-style]
Comment at:
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1307
+ (Style.BraceWrapping.BeforeLambdaBody && Current.Next != nullptr &&
+Current.Next->is(TT_LambdaLSquare)));
State.Stack.back().IsInsideObjCArrayLiteral =
Wawha
stephanemoore marked an inline comment as done.
stephanemoore added inline comments.
Comment at: clang-tidy/google/FunctionNamingCheck.cpp:57
+ functionDecl(
+ isDefinition(),
+ unless(anyOf(isMain(), matchesName(validFunctionNameRegex(true)),
stephanemoore updated this revision to Diff 163656.
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
Updated with changes:
- Removed unit tests as other tests have been indicated to provide adequate
coverage.
- Added a comment explaining why only function
hokein added a comment.
Nice! looks mostly good to me.
Comment at: clang-tidy/google/FunctionNamingCheck.cpp:57
+ functionDecl(
+ isDefinition(),
+ unless(anyOf(isMain(), matchesName(validFunctionNameRegex(true)),
any reason why we
hokein updated this revision to Diff 163654.
hokein edited the summary of this revision.
hokein added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50958
Files:
clangd/XRefs.cpp
clangd/XRefs.h
unittests/clangd/XRefsTests.cpp
Index:
75 matches
Mail list logo
