[PATCH] D52259: [CUDA] Fix two failed test cases using --cuda-path-ignore-env

gaijiading updated this revision to Diff 166811. gaijiading retitled this revision from "[CUDA] Rearrange search path ordering to fix two test case failures" to "[CUDA] Fix two failed test cases using --cuda-path-ignore-env". gaijiading edited the summary of this revision. gaijiading added a

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

compnerd closed this revision. compnerd added a comment. SVN r342929 (with tests) Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925

MaskRay updated this revision to Diff 166805. MaskRay added a comment. Depends on https://reviews.llvm.org/D52451 (adding LLVM_ATTRIBUTE_REINITIALIZES) Repository: rC Clang https://reviews.llvm.org/D52446 Files: include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h

[PATCH] D52446: Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925

MaskRay updated this revision to Diff 166806. MaskRay retitled this revision from "Remove Found.clear() to silent bugprone-use-after-move after rC342925" to "Annotate LookupResult::clear() as LLVM_ATTRIBUTE_REINITIALIZES to silence bugprone-use-after-move after rC342925". MaskRay removed a

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:119 +/// Collect and cache all file status from the underlying file system. +class CollectStatCacheVFS : public vfs::FileSystem { ioeric wrote: > Would it make sense to add a

Re: [clang-tools-extra] r342730 - [clangd] Remember to serialize symbol origin in YAML.

Why would we want to serialize the origin? We only serialize and deserialize for the static index, it does not seem to be useful to serialize origin in that scenario. Am I missing something? On Fri, Sep 21, 2018 at 3:06 PM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author:

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso added a comment. The results are accessible trough the `index.html` in each folder: F7303310: results.rar @aaron.ballman a friendly reminder. https://reviews.llvm.org/D45050 ___ cfe-commits mailing list

[PATCH] D52401: Remove redundant null pointer check in operator delete

ldionne added a comment. You did not get a thumbs up from any of the code owners for libc++. Reverted in r342938. Repository: rL LLVM https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52446: Remove Found.clear() to silent bugprone-use-after-move after rC342925

rsmith added a comment. I think the check is wrong here. We need this `clear` call to reinitialize the object after moving from it. Maybe that function should be annotated as reinitializing the object instead? Repository: rC Clang https://reviews.llvm.org/D52446

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 166802. Charusso marked 28 inline comments as done. Charusso added a comment. - Refactor and better English thanks for @whisperity! - Removed `InjectUL` option so the checker handles the special case if the capacity of a buffer is `int.Max()`

[PATCH] D52401: Remove redundant null pointer check in operator delete

This revision was automatically updated to reflect the committed changes. Closed by commit rL342936: Remove redundant null pointer check in operator delete (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52401

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. In https://reviews.llvm.org/D51340#1243453, @hans wrote: > In https://reviews.llvm.org/D51340#1243331, @takuto.ikuta wrote: > > > Ping? > > > > This patch reduced obj size largely, and I expect this makes distributed > > build (like goma) faster by reducing data

[PATCH] D52401: Remove redundant null pointer check in operator delete

hotpxl accepted this revision. hotpxl added a comment. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52401: Remove redundant null pointer check in operator delete

khng300 accepted this revision. khng300 added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52448: [clang-format] Break before next parameter after a formatted multiline raw string parameter

krasimir created this revision. Herald added a subscriber: cfe-commits. TODO: in progress Repository: rC Clang https://reviews.llvm.org/D52448 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h unittests/Format/FormatTestRawStrings.cpp Index:

[PATCH] D50147: clang-format: support external styles

krasimir added a comment. I don't understand the use-case this patch is realizing. Suppose I have a bunch of projects that have to share a format style. Then I can checkout them under a common root directory and put an appropriate .clang-format file there. Repository: rC Clang

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaronpuchert added a comment. While most people probably just use ordinary mutexes, hence won't be affected, those that use read/write locks need to know when to use a shared and when to use an exclusive lock. What makes things hard in C++ is that through passing by non-const reference, an

[PATCH] D52446: Remove Found.clear() to silent bugprone-use-after-move after rC342925

MaskRay created this revision. MaskRay added a reviewer: rsmith. Herald added a subscriber: cfe-commits. MaskRay added a reviewer: clang. Repository: rC Clang https://reviews.llvm.org/D52446 Files: lib/Sema/SemaStmt.cpp Index: lib/Sema/SemaStmt.cpp

r342929 - Driver: render arguments for the embedded bitcode correctly

Author: compnerd Date: Mon Sep 24 16:50:02 2018 New Revision: 342929 URL: http://llvm.org/viewvc/llvm-project?rev=342929=rev Log: Driver: render arguments for the embedded bitcode correctly When embedding bitcode, only a subset of the arguments should be recorded into the bitcode compilation

[PATCH] D52401: Remove redundant null pointer check in operator delete

MaskRay added a comment. Ping :) Repository: rCXX libc++ https://reviews.llvm.org/D52401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342927 - [www] Change 'Clang 7' items from yellow to green now Clang 7 is

Author: rsmith Date: Mon Sep 24 16:21:09 2018 New Revision: 342927 URL: http://llvm.org/viewvc/llvm-project?rev=342927=rev Log: [www] Change 'Clang 7' items from yellow to green now Clang 7 is released. Modified: cfe/trunk/www/cxx_dr_status.html cfe/trunk/www/cxx_status.html

[PATCH] D52445: [Index] Use locations to uniquify function-scope BindingDecl USR

MaskRay created this revision. MaskRay added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. This makes BindingDecl's of the same name have different USRs, so that references can be correctly attributed. int a[1] = {}; { auto [x] = a; x; } { auto [x] = a; x; }

r342926 - [www] Update cxx_status to mark P0962R1 as done.

Author: rsmith Date: Mon Sep 24 16:19:11 2018 New Revision: 342926 URL: http://llvm.org/viewvc/llvm-project?rev=342926=rev Log: [www] Update cxx_status to mark P0962R1 as done. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

r342925 - P0962R1: only use the member form of 'begin' and 'end' in a range-based

Author: rsmith Date: Mon Sep 24 16:17:44 2018 New Revision: 342925 URL: http://llvm.org/viewvc/llvm-project?rev=342925=rev Log: P0962R1: only use the member form of 'begin' and 'end' in a range-based for loop if both members exist. This resolves a DR whereby an errant 'begin' or 'end' member in

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaron.ballman added a comment. In https://reviews.llvm.org/D52398#1244074, @aaronpuchert wrote: > No problem. Thanks for reviewing! I'm terribly sorry to be bombarding the two > of you with so many review requests lately, and I hope it'll soon be over. No apologies necessary -- I love and

r342924 - [CUDA] Added basic support for compiling with CUDA-10.0

Author: tra Date: Mon Sep 24 16:10:44 2018 New Revision: 342924 URL: http://llvm.org/viewvc/llvm-project?rev=342924=rev Log: [CUDA] Added basic support for compiling with CUDA-10.0 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cuda.cpp

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaronpuchert added a comment. There is a (technical) merge conflict between this change and https://reviews.llvm.org/D52395, but that shouldn't be of any concern for the review. The issues are rather independent. (I think.) Repository: rC Clang https://reviews.llvm.org/D52443

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaronpuchert added a comment. No problem. Thanks for reviewing! I'm terribly sorry to be bombarding the two of you with so many review requests lately, and I hope it'll soon be over. Repository: rC Clang https://reviews.llvm.org/D52398 ___

[PATCH] D52443: Thread safety analysis: Examine constructor arguments

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a subscriber: cfe-commits. Instead of only examining call arguments, we also examine constructor arguments applying the same rules. That was an oppurtunity for refactoring the examination

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaron.ballman added a comment. > Unlike checking const qualifiers on member functions, there are probably not > many false positives here: if a function takes a non-const reference, it will > in almost all cases modify the object that we passed it. I'm not certain I agree with the predicate

[PATCH] D52440: Emit lifetime markers for temporary function parameter aggregates

itessier created this revision. itessier added a reviewer: rjmccall. Herald added a subscriber: cfe-commits. Clang is not emitting lifetime markers for temporary function parameters, so more stack space is potentially being allocated than necessary. A new parameter is added to the CreateAggTemp

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

fwyzard added a comment. Thanks, indeed I missed some of the changes related to SM 7.5. Repository: rC Clang https://reviews.llvm.org/D52437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

tra added a comment. Great to see someone beating me to add support for a new CUDA version. :-) I've posted my patch in https://reviews.llvm.org/D52438. It's very similar to yours with a couple of other necessary changes. Repository: rC Clang https://reviews.llvm.org/D52437

[PATCH] D52438: [CUDA] Add basic support for CUDA-10.0

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, hiraditya, sanjoy, jholewinski. https://reviews.llvm.org/D52438 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan added a comment. Of the intrinsics we plan to implement, it seems that the ordering of legalization affects specifically the fixed point mul/div intrinsics since if they get expanded into other nodes, we will need to check again for legal types since performing scaled mul/div

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan updated this revision to Diff 166756. leonardchan added a reviewer: rjmccall. leonardchan changed the repository for this revision from rC Clang to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D52286 Files: include/llvm/CodeGen/ISDOpcodes.h

r342920 - [analyzer] Prevent crashes in FindLastStoreBRVisitor

Author: george.karpenkov Date: Mon Sep 24 14:20:30 2018 New Revision: 342920 URL: http://llvm.org/viewvc/llvm-project?rev=342920=rev Log: [analyzer] Prevent crashes in FindLastStoreBRVisitor This patch is a band-aid. A proper solution would be too change trackNullOrUndefValue to only try to

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

fwyzard created this revision. fwyzard added reviewers: tra, Hahnfeld. Herald added a subscriber: cfe-commits. Add the definitions for CUDA 10.0 and CUDA architecture 7.5 (Turing), and define CUDA 10.0 as the highest supported version. Starting with CUDA 10.0, the include files include/crt/*

[PATCH] D52264: Deduplicate replacements from diagnostics.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should give @delesley a chance to weigh in before you commit. Repository: rC Clang https://reviews.llvm.org/D52398

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:70 + if (MFunctor && MFunctor->isTypeDependent()) { +const auto *Paren = static_cast(MFunctor->getCallee()); +const auto *BinOp = JonasToth wrote: >

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added a comment. This now matches GCC AFAICT. My only question is: Should GCC instead warn for the typedef case for -std=c89 (non pedantic), according to C90 6.5.3? Repository: rC Clang https://reviews.llvm.org/D52248 ___

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan updated this revision to Diff 166746. leonardchan added a comment. Herald added a subscriber: cfe-commits. - Removed passes since ssaturate can be expanded in the DAG Repository: rC Clang https://reviews.llvm.org/D52286 Files: include/llvm/CodeGen/ISDOpcodes.h

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the local `const` qualification stuff and some minor wordsmithing of the documentation, this LGTM. Comment at:

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166743. nickdesaulniers added a comment. - adjust wording in comment Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166742. nickdesaulniers added a comment. - fix typo s/CNU/GNU/g and update NOTEs Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D52434: [OpenMP] Make default schedules for NVPTX target regions in SPMD mode achieve coalescing

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. For the OpenMP NVPTX toolchain choose default schedules which ensure coalescing on the GPU when in SPMD mode. This significantly increases the performance of

[PATCH] D52390: [analyzer] StackSizeChecker

Szelethus added a comment. One important thing I forgot, that you cant rely on `ProgramState` due to tidy's constraints. Btw, how do you plan to make this into a tidy checker? To me it seems like it would amplify the already existing false positive issues (if I understand your currect way of

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/Sema/gnu89-const.c:41-46 +CHECK-CNU99-NOT: 27:1: warning: duplicate 'const' declaration specifier +CHECK-CNU99-PEDANTIC-NOT: 27:1: warning: duplicate 'const' declaration specifier +CHECK-CNU11-NOT: 27:1: warning: duplicate

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

mstorsjo added inline comments. Comment at: src/CMakeLists.txt:60 + append_if(libraries LIBUNWIND_HAS_GCC_S_LIB gcc_s) + list(APPEND libraries gcc) +endif() I'm a little suspicious of this line, of forcibly linking against libgcc here, even if we might not

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166740. nickdesaulniers added a comment. - condense CHECK-prefixes into CHECK for const const Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, sorry for the delay. Repository: rUNW libunwind https://reviews.llvm.org/D51657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166736. nickdesaulniers added a comment. - add ISO C tests, handle typedef case new tests found Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166737. nickdesaulniers added a comment. - remove debug statments Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D52390: [analyzer] StackSizeChecker

Szelethus added a comment. > Thanks for all your detailed and helpful input, I will make sure to go over > all the comments and answer them, but it will take some time. Cheers! I can't emphasize enough however that I might be wrong on what I've said, or say in this comment. > It was my

[PATCH] D52399: [AArch64] Support adding X[8-15, 18] registers as CSRs.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for this patch, Tri! Repository: rC Clang https://reviews.llvm.org/D52399 ___ cfe-commits mailing list

[PATCH] D52273: [clangd] Initial implementation of expected types

sammccall added a comment. Happy to speculate about what might work here, but I strongly believe the path forward here is to build the simplest version of this feature, without conversions, and try to avoid complicated conversion logic if we can get most of the benefit in simpler ways. In

[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

kristina reopened this revision. kristina added a comment. This revision is now accepted and ready to land. Cascade of build failures stemming from `GV->setSection(".rodata");`, reverted the commit, it seems that `CFString.c` is causing all those issues despite passing when ran locally.

r342912 - [CodeGen] Revert commit https://reviews.llvm.org/rL342717

Author: calixte Date: Mon Sep 24 11:24:18 2018 New Revision: 342912 URL: http://llvm.org/viewvc/llvm-project?rev=342912=rev Log: [CodeGen] Revert commit https://reviews.llvm.org/rL342717 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

[PATCH] D52399: [AArch64] Support adding X[8-15, 18] registers as CSRs.

trong updated this revision to Diff 166722. trong added a comment. - Added test case for using -fcall-saved-x18 and -ffixed-x18 together. Repository: rC Clang https://reviews.llvm.org/D52399 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td

[PATCH] D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins (authored by stefanp, committed by ). Herald added subscribers: cfe-commits, jsji, kristina. Changed prior to commit:

r342911 - [Power9] [CLANG] Add __float128 exponent GET and SET builtins

Author: stefanp Date: Mon Sep 24 11:14:50 2018 New Revision: 342911 URL: http://llvm.org/viewvc/llvm-project?rev=342911=rev Log: [Power9] [CLANG] Add __float128 exponent GET and SET builtins Added __builtin_vsx_scalar_extract_expq __builtin_vsx_scalar_insert_exp_qp Builtins should behave the

r342909 - Fix the type of 1<<31 integer constants.

Author: d0k Date: Mon Sep 24 10:51:15 2018 New Revision: 342909 URL: http://llvm.org/viewvc/llvm-project?rev=342909=rev Log: Fix the type of 1<<31 integer constants. Shifting into the sign bit is technically undefined behavior. No known compiler exploits it though. Modified:

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

NoQ added a comment. Maybe just move `StdCLibraryFunctionsChecker` to `core`? (`.apiModeling`?) We officially don't support disabling `core`, so i guess it kinda solves the issue. Also all of our languages are C-based, these functions are present on all platforms (if any of those aren't, we

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

Szelethus added inline comments. Comment at: test/Analysis/conversion.c:158 extern int dostuff (void); int falsePositive2() { int c, n; And this one Repository: rC Clang https://reviews.llvm.org/D52423 ___

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12380-12382 } + if (LangOpts.CPlusPlus && II) { lebedev.ri wrote: > I think you could move it into the `if()` above? You are correct, I'll hoist it. https://reviews.llvm.org/D52421

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman updated this revision to Diff 166716. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. https://reviews.llvm.org/D52421 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

george.karpenkov added a comment. The concept makes sense. @NoQ any comments? I don't recall seeing that pattern before. Comment at: test/Analysis/conversion.c:144 int isascii(int c); void falsePositive1() { char kb2[5]; Also the function name should be

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

lebedev.ri added a comment. Thanks! Comment at: lib/Sema/SemaDecl.cpp:12380-12382 } + if (LangOpts.CPlusPlus && II) { I think you could move it into the `if()` above? https://reviews.llvm.org/D52421 ___

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1241928, @probinson wrote: > Do we generate the .dwo file directly these days? If not, I can imagine > wanting to avoid the overhead of the objcopy hack; as long as the linker is > smart enough not to bother with the .debug_*.dwo

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1241928, @probinson wrote: > Do we generate the .dwo file directly these days? If not, I can imagine > wanting to avoid the overhead of the objcopy hack; as long as the linker is > smart enough not to bother with the .debug_*.dwo

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added inline comments. Comment at: clangd/ExpectedTypes.h:68 + +/// Represents a type of partially applied conversion. Should be treated as an +/// opaque value and can only be used to check whether the types are converible sammccall wrote: > this

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

steven_wu added a comment. Thanks for doing this! Can you add some test cases just to be complete? Other than that, LGTM! Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 166710. shuaiwang added a comment. Added test case place holder for cases that should be supported in later patches. Repository: rC Clang https://reviews.llvm.org/D52219 Files: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h

[PATCH] D46443: Add missing cstdalign header

ldionne added a subscriber: mclow.lists. ldionne added a comment. I believe this header has been deprecated. According to http://eel.is/c++draft/diff.cpp17.library, the effect of this header is nothing. @mclow.lists can you chime in? Repository: rCXX libc++ https://reviews.llvm.org/D46443

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. > This seems very clever, but extremely complicated - you've implemented much > of C++'s conversion logic, it's not clear to me which parts are actually > necessary to completion quality. Clearly the model that supports C++ conversions is something that **will**

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

andrewjcg updated this revision to Diff 166709. andrewjcg added a comment. Dropping the module directory entirely and fully resolving paths on serialization broke some things during deserialization, specifically when the deserializer wanted to update paths to use an alternate module directory.

[clang-tools-extra] r342903 - [clangd] Fix uninit bool in r342888

Author: sammccall Date: Mon Sep 24 09:52:48 2018 New Revision: 342903 URL: http://llvm.org/viewvc/llvm-project?rev=342903=rev Log: [clangd] Fix uninit bool in r342888 Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified:

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

Anastasia added a comment. In https://reviews.llvm.org/D43783#1235126, @yaxunl wrote: > In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote: > > > Ping! Do you still plan to do this? :) > > > Sorry I caught up in something else. Since there are some subsequent commits, > it may take

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/Sema/gnu89.c:1-2 -// RUN: %clang_cc1 %s -std=gnu89 -pedantic -fsyntax-only -verify +// RUN: %clang_cc1 %s -std=gnu89 -pedantic -fsyntax-only 2>&1 | FileCheck -check-prefix=CHECK-PEDANTIC %s +// RUN: %clang_cc1 %s

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:1699 + if (Opts.EnableSnippets) { +log("Suffix: {0}", SnippetSuffix); LSP.textEdit->newText += SnippetSuffix; Sorry, leftover from debug printing. Will remove Repository: rCTE

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:483 + // Destroy ClangdServer to ensure all worker threads finish. + Server.reset(); ioeric wrote: > This woudn't work if `run()` is called multiple times. Maybe create a > `Server`

[libunwind] r342901 - Reverting r342895

Author: lukecheeseman Date: Mon Sep 24 09:36:33 2018 New Revision: 342901 URL: http://llvm.org/viewvc/llvm-project?rev=342901=rev Log: Reverting r342895 - The used builtins do not compile for pre arm v8.3a targets with gcc Modified: libunwind/trunk/include/libunwind.h

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50171: [python] [tests] Update test_code_completion

This revision was automatically updated to reflect the committed changes. Closed by commit rL342897: [python] [tests] Update test_code_completion (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r342897 - [python] [tests] Update test_code_completion

Author: mgorny Date: Mon Sep 24 09:10:25 2018 New Revision: 342897 URL: http://llvm.org/viewvc/llvm-project?rev=342897=rev Log: [python] [tests] Update test_code_completion Update expected completions to match output generated by clang-7.0. Differential Revision: https://reviews.llvm.org/D50171

[PATCH] D50171: [python] [tests] Update test_code_completion

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D50171#1236792, @mgorny wrote: > @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do > you think my patch would be good

[libunwind] r342895 - [AArch64] Unwinding support for return address signing

Author: lukecheeseman Date: Mon Sep 24 08:55:35 2018 New Revision: 342895 URL: http://llvm.org/viewvc/llvm-project?rev=342895=rev Log: [AArch64] Unwinding support for return address signing - When return address signing is enabled, the LR may be signed on function entry - When an exception is

[PATCH] D51432: [AArch64] Unwinding support for return address signing

This revision was automatically updated to reflect the committed changes. Closed by commit rL342895: [AArch64] Unwinding support for return address signing (authored by LukeCheeseman, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

Szelethus edited reviewers, added: NoQ; removed: dergachev.a. Szelethus added a comment. Cool! Comment at: test/Analysis/conversion.c:141 -// false positives.. +// old false positives.. I think this comment is no longer relevant ^-^ Repository: rC

r342893 - Revert "rL342883: [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`."

Author: kristina Date: Mon Sep 24 08:26:08 2018 New Revision: 342893 URL: http://llvm.org/viewvc/llvm-project?rev=342893=rev Log: Revert "rL342883: [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`." Seems to be causing buildbot failures, need to look into it.

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:483 + // Destroy ClangdServer to ensure all worker threads finish. + Server.reset(); This woudn't work if `run()` is called multiple times. Maybe create a `Server` in each `run()`?

[PATCH] D52423: Make ConversionChecker load StdCLibraryFunctionsChecker

donat.nagy created this revision. donat.nagy added a reviewer: dergachev.a. Herald added a subscriber: cfe-commits. ConversionChecker produces false positives when it encounters the idiomatic usage of certain well-known functions (e.g. getc() and the character classification functions like

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, ioeric, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52422 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp

r342890 - [CFString][ELF] Fix a missed test causing buildbot failures from 342883.

Author: kristina Date: Mon Sep 24 07:52:48 2018 New Revision: 342890 URL: http://llvm.org/viewvc/llvm-project?rev=342890=rev Log: [CFString][ELF] Fix a missed test causing buildbot failures from 342883. Accidetanlly forgot to update it, big sorry. Modified:

r342889 - [VFS] Use llvm::StringMap instead of std::map. NFC

Author: ioeric Date: Mon Sep 24 07:52:11 2018 New Revision: 342889 URL: http://llvm.org/viewvc/llvm-project?rev=342889=rev Log: [VFS] Use llvm::StringMap instead of std::map. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL:

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman created this revision. aaron.ballman added reviewers: lebedev.ri, rsmith, dblaikie. This patch diagnoses parameter names that shadow the names of inherited fields under -Wshadow-field. It addresses PR34120. Note, unlike GCC, we take into account the accessibility of the field when

[clang-tools-extra] r342888 - [clangd] Do bounds checks while reading data, otherwise var-length records are too painful. NFC

Author: sammccall Date: Mon Sep 24 07:51:15 2018 New Revision: 342888 URL: http://llvm.org/viewvc/llvm-project?rev=342888=rev Log: [clangd] Do bounds checks while reading data, otherwise var-length records are too painful. NFC Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

JonasToth added inline comments. Comment at: test/clang-tidy/misc-unused-using-decls-cxx17.cpp:1 +// RUN: %check_clang_tidy %s misc-unused-using-decls %t -- -- -fno-delayed-template-parsing -std=gnu++17 + why gnu++17 and not standard? Repository: rCTE Clang

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric added inline comments. Comment at: clangd/ClangdUnit.cpp:119 +/// Collect and cache all file status from the underlying file system. +class CollectStatCacheVFS : public vfs::FileSystem { Would it make sense to add a `clang::vfs::ProxyFS` that proxies

  1   2   >