r344833 - [CodeGen] Use the mangle context owned by CodeGenModule to correctly

Author: ahatanak Date: Fri Oct 19 22:45:01 2018 New Revision: 344833 URL: http://llvm.org/viewvc/llvm-project?rev=344833=rev Log: [CodeGen] Use the mangle context owned by CodeGenModule to correctly mangle types of lambda objects captured by a block instead of creating a new mangle context

[PATCH] D53456: [Sema] Do not show unused parameter warnings when body is skipped

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Haha, fun! Repository: rC Clang https://reviews.llvm.org/D53456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r344832 - [X86] Add support for more than 32 features for __builtin_cpu_is

Author: ctopper Date: Fri Oct 19 20:51:52 2018 New Revision: 344832 URL: http://llvm.org/viewvc/llvm-project?rev=344832=rev Log: [X86] Add support for more than 32 features for __builtin_cpu_is libgcc supports more than 32 features by adding a new 32-bit variable __cpu_features2. This adds the

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal closed this revision. BillyONeal added a comment. Thank you! :D Committed r344829 https://reviews.llvm.org/D53466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Looks fine to me https://reviews.llvm.org/D53466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

hwright added a comment. Ping. What are the next steps here? https://reviews.llvm.org/D53339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53468: [libcxx] [test] Don't silence MSVC STL deprecation warnings when testing _LIBCPP_ENABLE_DEPRECATION_WARNINGS

BillyONeal abandoned this revision. BillyONeal added a comment. Actually this doesn't work -- because we /FI this thing, this file is included before the test gets to say _LIBCPP_ENABLE_DEPRECATION_WARNINGS. https://reviews.llvm.org/D53468 ___

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); wuzish wrote: >

r344828 - Make -Wfor-loop-analysis work with C++17

Author: rtrieu Date: Fri Oct 19 19:15:58 2018 New Revision: 344828 URL: http://llvm.org/viewvc/llvm-project?rev=344828=rev Log: Make -Wfor-loop-analysis work with C++17 For now, disable the "variable in loop condition not modified" warning to not be emitted when there is a structured binding

[clang-tools-extra] r344827 - Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx

Author: ahatanak Date: Fri Oct 19 19:11:45 2018 New Revision: 344827 URL: http://llvm.org/viewvc/llvm-project?rev=344827=rev Log: Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx earlier than 10.13. rdar://problem/45310173 Modified:

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); hubert.reinterpretcast wrote: >

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaOverload.cpp:3920 + + // Prefer a compatible vector conversion to lax vector conversion + //

[PATCH] D53468: [libcxx] [test] Don't silence MSVC STL deprecation warnings when testing _LIBCPP_ENABLE_DEPRECATION_WARNINGS

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. https://reviews.llvm.org/D53468 Files: test/support/msvc_stdlib_force_include.hpp Index: test/support/msvc_stdlib_force_include.hpp === ---

[PATCH] D53296: [analyzer] New flag to print all -analyzer-config options

NoQ accepted this revision. NoQ added a comment. I'll use this. And i think it's unfair to give users -analyzer-config and not give them a list of options. Users should be able to discover either both or none of the two. If a user goes far enough to start digging into non-driver options, such

[PATCH] D53280: [analyzer] Emit a warning for unknown -analyzer-config options

NoQ added a comment. Herald added a subscriber: dkrupp. I guess we should consider the idea in http://lists.llvm.org/pipermail/cfe-dev/2018-October/059864.html Comment at: lib/Frontend/CompilerInvocation.cpp:343 } + // Check whether this really is a valid

[PATCH] D53277: [analyzer][NFC] Collect all -analyzer-config options in a .def file

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this is awesome o_o Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:70-71 + +/// Controls the high-level analyzer mode, which influences the default +///

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal updated this revision to Diff 170294. BillyONeal added a comment. Also fixed cstdlib tests. https://reviews.llvm.org/D53466 Files: test/std/depr/depr.c.headers/stdlib_h.pass.cpp test/std/language.support/support.runtime/cstdlib.pass.cpp Index:

[PATCH] D53460: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

This revision was automatically updated to reflect the committed changes. Closed by commit rL344824: [X86] When checking the bits in cpu_features for function multiversioning… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D53466: [libcxx] [test] Don't detect Windows' UCRT with TEST_COMPILER_C1XX

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. The test is trying to avoid saying aligned_alloc on Windows' UCRT, which does not (and can not) implement aligned_alloc. However, it's testing for c1xx, meaning clang on Windows will fail this test when using the

r344824 - [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

Author: ctopper Date: Fri Oct 19 18:30:00 2018 New Revision: 344824 URL: http://llvm.org/viewvc/llvm-project?rev=344824=rev Log: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

[PATCH] D53274: [analyzer][NFC] Fix inconsistencies in AnalyzerOptions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dkrupp. Thanks! Let's commit. https://reviews.llvm.org/D53274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53276: [analyzer][NFC] Fix some incorrect uses of -analyzer-config options

NoQ added a reviewer: dcoughlin. NoQ added inline comments. Herald added a subscriber: dkrupp. Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402 checker->IsAggressive = - mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false); +

[PATCH] D53463: [Driver] allow Android triples to alias for non Android targets

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Please remove the reference to b/X in the commit message. LLVM doesn't allow internal bug numbers, and you described the issue well enough without it. Repository: rC Clang

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

NoQ accepted this revision. NoQ added a comment. I guess maybe let's skip stuff without examples and leave Objective-C descriptions waiting on us? Comment at: www/analyzer/available_checks.html:483 + +LLVM Checkers Wow, i never noticed this one. It seems to

[PATCH] D52906: [analyzer] allow plugins built as shared libraries to receive events

NoQ closed this revision. NoQ added a comment. Herald added subscribers: dkrupp, donat.nagy. I committed both patches as https://reviews.llvm.org/rC344823 but it seems that Phabricator doesn't pick up closing multiple revisions with the same commit, so closing manually. Also thanks!~

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static locals into .cpp files. (authored by dergachev, committed by ). Herald added subscribers: llvm-commits, dkrupp, donat.nagy. Changed prior to

r344823 - [analyzer] Be more plugin-friendly by moving static locals into .cpp files.

Author: dergachev Date: Fri Oct 19 17:29:24 2018 New Revision: 344823 URL: http://llvm.org/viewvc/llvm-project?rev=344823=rev Log: [analyzer] Be more plugin-friendly by moving static locals into .cpp files. The GDMIndex functions return a pointer that's used as a key for looking up data, but

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ added a comment. Hmm, i guess i sent this out too early. As per our long-lasting tradition, i forgot the point about the web page :\ Bullets about RUN-lines, Checkers.td descriptions and CMakeLists are also great for everyday use :) https://reviews.llvm.org/D52984

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); aprantl wrote: > vsk

[PATCH] D53463: [Driver] allow Android triples to alias for non Android targets

nickdesaulniers created this revision. nickdesaulniers added reviewers: srhines, pirama, danalbert. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Partial revert of r330873 ('[Driver] Reland "Android triples are not aliases for other triples."') While we don't want `-target

[PATCH] D52984: [analyzer] Checker reviewer's checklist

NoQ added a comment. My take on the out-of-alpha checklist: - The checker should be evaluated on a large codebase in order to discover crashes and false positives specific to the checker. It should demonstrate the expected reasonably good results on it, with the stress on having as little

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); vsk wrote: > Why

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

vsk added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2871 + auto *DI = CGF.getDebugInfo(); + SourceLocation Loc = DI ? DI->getLocation() : SourceLocation(); + auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc); Why shouldn't this always

[PATCH] D53329: Generate DIFile with main program if source is not available

dblaikie added a comment. @aprantl - yeah, not sure I have any big feels about this (nor do I fully understand it) @yonghong-song - could you explain this maybe in a bit more detail. What behavior does this fix provide? (compared to behavior of existing working cases that don't hit this bug,

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

bobsayshilol updated this revision to Diff 170277. bobsayshilol retitled this revision from "[CodeGen] Fix places where the return type of a FunctionDecl was being used in place of the function type" to "Fix places where the return type of a FunctionDecl was being used in place of the function

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

BillyONeal closed this revision. BillyONeal added a comment. Committed r344821 https://reviews.llvm.org/D50551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal closed this revision. BillyONeal added a comment. Committed r344820 https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53460: [X86] When checking the bits in cpu_features for function multiversioning dispatcher in the resolver, make sure all the required bits are set. Not just one of them

craig.topper created this revision. craig.topper added reviewers: erichkeane, echristo. The multiversioning code repurposed the code from __builtin_cpu_supports for checking if a single feature is enabled. That code essentially performed (_cpu_features & (1 << C)) != 0. But with the

[PATCH] D53459: Ensure sanitizer check function calls have a !dbg location

aprantl created this revision. aprantl added a reviewer: vsk. Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to construct inline information and are rejected by the verifier. This patch ensures that sanitizer check function calls have a !dbg

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

hans added a comment. I haven't started looking at the code yet. I'm not completely convinced that we want this. So far we've used the strategy of promoting clang options that are also useful in clang-cl to core options, and if someone wants to use more clang than that, maybe clang-cl isn't

[PATCH] D53347: [clangd] Simplify auto hover

ilya-biryukov added a comment. In https://reviews.llvm.org/D53347#1267216, @kadircet wrote: > LGTM, it bugs me that some part in the documentation says it doesn't go > through decltype(`This looks through declarators like pointer types, but not > through decltype or typedefs`) but since tests

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

rsmith added inline comments. Comment at: lib/AST/DeclBase.cpp:1704-1705 + + // In C, the redeclaration context for enumerators is the translation unit, + // so we skip through transparent contexts as well as struct/union contexts. + bool SkipRecords = getDeclKind() ==

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. (Looks fine with a suitably-adjusted comment.) https://reviews.llvm.org/D52384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via llvm-commits wrote: > aprantl added a comment. > > I have a vague recollection that this column info hack was added to > disambiguate two types defined on the same line (which is something that > happened more often than one would

[PATCH] D53347: [clangd] Simplify auto hover

ilya-biryukov updated this revision to Diff 170273. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53347 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. RTTI? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. Oh wait, this patch is just for dumping the ASTs? Can you elaborate why this makes it into a binary then? Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

aprantl added a comment. I have a vague recollection that this column info hack was added to disambiguate two types defined on the same line (which is something that happened more often than one would think because of macro expansion). Did you do the git archeology to ensure that the original

[PATCH] D52939: ExprConstant: Propagate correct return values from constant evaluation.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:711 + + /// Evaluate as a constant expression, as per C++11-and-later constexpr + /// rules. Stop if we find that the expression is not a constant jyknight wrote: > rsmith wrote:

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

neerajksingh created this revision. neerajksingh added reviewers: rnk, hans. The clang-cl driver disables access to command line options outside of the "Core" and "CLOption" sets of command line arguments. This filtering makes it impossible to pass arguments that are interpreted by the clang

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170270. oleg.smolsky added a comment. Generalized the patch so that it deals with lambda args irrespective of bin packing. Added additional tests and patched existing ones. Repository: rC Clang https://reviews.llvm.org/D52676 Files:

[PATCH] D53456: [Sema] Do not show unused parameter warnings when body is skipped

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added a subscriber: arphaman. Without the function body, we cannot determine is parameter was used. Repository: rC Clang https://reviews.llvm.org/D53456 Files: lib/Sema/SemaDecl.cpp

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added a comment. In https://reviews.llvm.org/D52676#1268806, @djasper wrote: > In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote: > > > In https://reviews.llvm.org/D52676#1268706, @djasper wrote: > > > > > Ok, I think I agree with both of you to a certain extent, but I

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

echristo added a reviewer: aprantl. echristo added a comment. I think Adrian has looked at this more recently than I have. Adding him here. Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163 + +switch (FloatingSize) { + case 64: Continuing the float semantics discussion on the new revision - Did you consider `llvm::APFloat`?

[PATCH] D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get

vmiklos added a comment. In practice cppunit's `CPPUNIT_TEST_SUITE_END` macro triggers this problem. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get

vmiklos created this revision. vmiklos added reviewers: alexfh, sbenza. Herald added subscribers: cfe-commits, xazax.hun. And also enable it by default to be consistent with e.g. modernize-use-using. This helps e.g. when running this check on client code where the macro is provided by

[PATCH] D53406: [clangd] Provide excuses for bad code completions, based on diagnostics. C++ API only.

ilya-biryukov added a comment. Since we're showing the diagnostics in the editors anyway, how crucial do we think it is to actually add that to the procotol? Having more concrete reasons for misbehaving completions sounds more useful, though, e.g. "cannot complete members of the incomplete

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:515 + continue; +const auto *FirstAccess = Accesses[0].getNodeAs("access"); + I feel that it's a good practice to

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); `__v4sc` is suspicious.

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Code looks good to me, but I'd wait for @george.karpenkov because it was his idea. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea updated this revision to Diff 170241. gtbercea added a comment. Rebase. Repository: rC Clang https://reviews.llvm.org/D53448 Files: include/clang/AST/StmtOpenMP.h include/clang/Basic/OpenMPKinds.h lib/AST/StmtOpenMP.cpp lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D53448: [OpenMP][NVPTX] Use single loops when generating code for distribute parallel for

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch adds a new code generation path for bound sharing directives containing distribute parallel for. The new code generation scheme applies to chunked

r344806 - Revert "[Driver] Reland: Default Android toolchains to libc++."

Author: danalbert Date: Fri Oct 19 12:23:01 2018 New Revision: 344806 URL: http://llvm.org/viewvc/llvm-project?rev=344806=rev Log: Revert "[Driver] Reland: Default Android toolchains to libc++." This reverts commit 84677d5009d613232d360fda27e6e41fb5cb6700. Modified:

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170238. gtbercea added a comment. Refactor. Repository: rOMP OpenMP https://reviews.llvm.org/D53141 Files: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu libomptarget/deviceRTLs/nvptx/src/interface.h

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea updated this revision to Diff 170237. gtbercea added a comment. Refactor. Repository: rC Clang https://reviews.llvm.org/D53443 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp

[PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

gtbercea updated this revision to Diff 170236. gtbercea added a comment. Herald added subscribers: cfe-commits, jholewinski. Refactor. Repository: rC Clang https://reviews.llvm.org/D53141 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp

r344801 - PR24164, PR39336: init-captures are not distinct full-expressions.

Author: rsmith Date: Fri Oct 19 12:01:34 2018 New Revision: 344801 URL: http://llvm.org/viewvc/llvm-project?rev=344801=rev Log: PR24164, PR39336: init-captures are not distinct full-expressions. Rather, they are subexpressions of the enclosing lambda-expression, and any temporaries in them are

r344800 - Add basic test that we perform lifetime extension in the expected

Author: rsmith Date: Fri Oct 19 12:01:31 2018 New Revision: 344800 URL: http://llvm.org/viewvc/llvm-project?rev=344800=rev Log: Add basic test that we perform lifetime extension in the expected situations. Added: cfe/trunk/test/CXX/special/class.temporary/p6.cpp Added:

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16197 +#ifdef cl_intel_device_side_avc_motion_estimation +#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable + Anastasia wrote: > Should we be using: > #pragma OPENCL

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

rsmith added a comment. In https://reviews.llvm.org/D52301#1267163, @kadircet wrote: > So in the middle of the patch we were just trying to figure out whether we > are going to break a big assumption that lots of different components relied > on but just didn't had any tests for. Maybe @rsmith

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:350 void getDefaultScheduleAndChunk(CodeGenFunction , - const OMPLoopDirective , OpenMPScheduleClauseKind , + const OMPLoopDirective , OpenMPScheduleTy , llvm::Value *) const

[PATCH] D53334: [Frontend] Show diagnostics on prebuilt module configuration mismatch too

dblaikie added a comment. Don't know enough about the code to have an opinion on the fix - but in any case this would need a test case, if possible Repository: rC Clang https://reviews.llvm.org/D53334 ___ cfe-commits mailing list

[PATCH] D51402: [OpenCL] Adding cl_intel_planar_yuv extension

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D51402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

dblaikie added a comment. @echristo > As far as the standard text here, IMO it was just there in case people didn't > have an objcopy around or don't want to split it. I'm not sure why we would > want the ability. I think others have mentioned - but with distributed build it might be easier

r344795 - [Driver] Reland: Default Android toolchains to libc++.

Author: danalbert Date: Fri Oct 19 11:06:02 2018 New Revision: 344795 URL: http://llvm.org/viewvc/llvm-project?rev=344795=rev Log: [Driver] Reland: Default Android toolchains to libc++. The sanitizer builder that was broken by this should now be fixed. Original review was

[PATCH] D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: test/Headers/opencl-pragma-extension-begin.cl:1 +// RUN: rm -rf %t +// RUN: mkdir -p %t I think the tests in this folder are for

[PATCH] D53443: [OpenMP][NVPTX] Enable default scheduling for parallel for in non-SPMD cases.

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch enables the choosing of the default schedule for parallel for loops even in non-SPMD cases. Repository: rC Clang

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D52654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet updated this revision to Diff 170215. kadircet added a comment. - Keep only relavant changes and rebase Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Sema/Sema.h lib/AST/TypePrinter.cpp

[PATCH] D53369: [CodeComplete] Fix accessibility of protected members when accessing members implicitly.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM, thanks! Would be super-nice if didn't have to rewrite this in code completion Repository: rC Clang https://reviews.llvm.org/D53369 ___ cfe-commits mailing list

[PATCH] D53441: [ms] Prevent explicit constructor name lookup if scope is missing

lantictac created this revision. lantictac added a reviewer: rsmith. lantictac added a project: clang. MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor name unless the name has explicit scope. This avoids a compile-time crash due to confusing a member access for a

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

ilya-biryukov added a comment. A few more comments, mostly marking places of unintentional changes that we need to revert. Hope it's not going past the point where the number of comments are not useful. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8616 "use of

[PATCH] D53434: Java annotation declaration being handled correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL344789: Java annotation declaration being handled correctly (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r344789 - Java annotation declaration being handled correctly

Author: hans Date: Fri Oct 19 09:19:52 2018 New Revision: 344789 URL: http://llvm.org/viewvc/llvm-project?rev=344789=rev Log: Java annotation declaration being handled correctly Previously, Java annotation declarations (@interface AnnotationName) were being handled as ObjC interfaces. This

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

sammccall added a comment. Nice savings! My initial thought is that it seems weird to only do it for this one string - the readers look different, the serialization code has different logic etc for the different flavors of strings. The struct certainly looks nicer to my eyes. This may be the

[PATCH] D53439: [clangd] Remove caching of compilation database commands.

sammccall created this revision. sammccall added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. The CDB implementations used in open-source code are fast, and our private slow CDB will soon do the relevant caching itself.

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh updated this revision to Diff 170205. twoh added a comment. Remove conflict line. Repository: rC Clang https://reviews.llvm.org/D34796 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. @joerg Sorry but I'm not sure if I understand your question. This doesn't pretend to honor source code order, but makes linker to place "hot" functions under .text.hot section (There's no guarantee of ordering between functions inside .hot.text section) while "cold"

[PATCH] D53434: Java annotation declaration being handled correctly

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you happen to know what had regressed this? Repository: rC Clang https://reviews.llvm.org/D53434 ___ cfe-commits

[clang-tools-extra] r344787 - [clangd] Set workspace root when initializing ClangdServer, disallow mutation.

Author: sammccall Date: Fri Oct 19 08:42:23 2018 New Revision: 344787 URL: http://llvm.org/viewvc/llvm-project?rev=344787=rev Log: [clangd] Set workspace root when initializing ClangdServer, disallow mutation. Summary: Rename instance variable to WorkspaceRoot to match what we call it

[PATCH] D53404: [clangd] Set workspace root when initializing ClangdServer, disallow mutation.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344787: [clangd] Set workspace root when initializing ClangdServer, disallow mutation. (authored by sammccall, committed by ). Changed prior to commit:

r344786 - [Hexagon] Remove support for V4

Author: kparzysz Date: Fri Oct 19 08:36:45 2018 New Revision: 344786 URL: http://llvm.org/viewvc/llvm-project?rev=344786=rev Log: [Hexagon] Remove support for V4 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/include/clang/Driver/Options.td

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344785: [clang-tidy] Resolve readability-else-after-return false positive for constexpr… (authored by mkurdej, committed by ). Changed prior to commit:

[clang-tools-extra] r344785 - [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

Author: mkurdej Date: Fri Oct 19 08:26:17 2018 New Revision: 344785 URL: http://llvm.org/viewvc/llvm-project?rev=344785=rev Log: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if. Summary: It fixes the false positive when using constexpr if and where else cannot

[PATCH] D53433: [clangd] *Prototype* auto-index stores symbols per-file instead of per-TU.

sammccall added inline comments. Comment at: clangd/index/FileIndex.cpp:167 +} +// FIXME: aggregate symbol reference count based on references. +for (const auto : FileSyms.getValue()->Refs) { This is a good FIXME to carry over to

r344784 - [ASTImporter] Removed uneeded default case label.

Author: balazske Date: Fri Oct 19 08:16:51 2018 New Revision: 344784 URL: http://llvm.org/viewvc/llvm-project?rev=344784=rev Log: [ASTImporter] Removed uneeded default case label. Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL:

[PATCH] D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53372 ___ cfe-commits mailing list

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3908 + QualType ToType) { +assert(FromType->isVectorType() && "FromType should be a vector type"); +assert(ToType->isVectorType()

[PATCH] D53434: Java annotation declaration being handled correctly

SamMaier created this revision. Herald added a subscriber: cfe-commits. Previously, Java annotation declarations (`@interface AnnotationName`) were being handled as ObjC interfaces. This caused the brace formatting to mess up, so that when you had a class with an interface defined in it, it

  1   2   >