Re: r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

Procedurally, we shouldn't be making other changes at the same time as a backport, but I'd sure like to see "stdlibc++" replaced with the correct "libstdc++" (on trunk and branch). On Sat, 17 Nov 2018, 19:00 Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org wrote: > Peanut gallery

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul marked 5 inline comments as done. sthibaul added a comment. I believe this version handles all the comments. I could run this with check-all on a linux-amd64 box. Repository: rC Clang https://reviews.llvm.org/D54379 ___ cfe-commits

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 174526. sthibaul edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp

Re: r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

Peanut gallery says: I think the one remaining instance of `-std=libc++` in the tests should be fixed at the same time. –Arthur On Sat, Nov 17, 2018 at 9:52 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Good idea, this LG for a patch release. > > On Sat, 17 Nov 2018,

Re: r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

Good idea, this LG for a patch release. On Sat, 17 Nov 2018, 18:48 Shoaib Meenai via cfe-commits < cfe-commits@lists.llvm.org wrote: > Could we merge this into 7.0.1? It's a trivial typo fix, and the error > message could otherwise be confusing to users (someone brought this up in > IRC a few

Re: r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

Could we merge this into 7.0.1? It's a trivial typo fix, and the error message could otherwise be confusing to users (someone brought this up in IRC a few hours ago). From: cfe-commits on behalf of Alex Lorenz via cfe-commits Reply-To: Alex Lorenz Date: Friday, September 7, 2018 at 12:01 PM

[PATCH] D54672: clang-include-fixer.el: support remote files

phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. Support remote files (e.g., Tramp) in the Emacs integration for clang-include-fixer Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54672 Files:

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. In https://reviews.llvm.org/D53157#1301992, @hfinkel wrote: > > Just because FENV_ACCESS can be toggled on that granularity doesn't mean we > > have to represent it that way. We've previously agreed (I think) that if > > FENV_ACCESS is enabled anywhere in a

[PATCH] D54097: Save memory in ASTReader by using DenseMap instead of vector

v.g.vassilev added a comment. Ping... https://reviews.llvm.org/D54097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 174513. Quuxplusone added a comment. Implement `[[clang::maybe_trivially_relocatable]]` along the lines suggested by @rjmccall. The idea is that there are two levels of "opt-in-ness." The first level, `[[clang::maybe_trivially_relocatable]]`, means "I

[PATCH] D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

This revision was automatically updated to reflect the committed changes. Closed by commit rC347144: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to… (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D54600?vs=174281=174512#toc

r347144 - [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

Author: calixte Date: Sat Nov 17 11:41:39 2018 New Revision: 347144 URL: http://llvm.org/viewvc/llvm-project?rev=347144=rev Log: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. > In general when structuring your code, the performance penalty for other > targets when the conditions that can be easily tested are not met should > pretty much be close to nonexistent. I would suggest keeping that in mind > when submitting revisions. I know, as

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul marked 9 inline comments as done. sthibaul added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:283 +Builder.defineMacro("__GLIBC__"); +Builder.defineMacro("__ELF__"); +if (Opts.POSIXThreads) kristina wrote: > `__MACH__` and

r347141 - Sink BuryPointer from Clang into LLVM for reuse there

Author: dblaikie Date: Sat Nov 17 10:04:13 2018 New Revision: 347141 URL: http://llvm.org/viewvc/llvm-project?rev=347141=rev Log: Sink BuryPointer from Clang into LLVM for reuse there Modified: cfe/trunk/include/clang/Frontend/CompilerInstance.h cfe/trunk/include/clang/Frontend/Utils.h

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3811 case ParsedAttr::AT_CXX11NoReturn: + case ParsedAttr::AT_TriviallyRelocatable: return true; erichkeane wrote: > A note for future reviewers, after the C++11 spelling is

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman added a comment. In https://reviews.llvm.org/D54246#1301940, @hwright wrote: > @aaron.ballman I don't actually have the commit bit, can you commit this, or > are we waiting for further review? No further review required. I'm happy to commit for you. I'll do it later today or

[PATCH] D54657: [clang] Add -MJJ for appending to compilation databases.

joerg added a comment. I don't understand the point here. Why would you want to include pre-processing-only commands in the compilation database? Repository: rC Clang https://reviews.llvm.org/D54657 ___ cfe-commits mailing list

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 updated this revision to Diff 174505. xbolva00 added a comment. Addressed comments, fixed tests https://reviews.llvm.org/D52835 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp

r347138 - [AST][NFC] Pack CXXDefaultInitExpr

Author: brunoricci Date: Sat Nov 17 05:02:47 2018 New Revision: 347138 URL: http://llvm.org/viewvc/llvm-project?rev=347138=rev Log: [AST][NFC] Pack CXXDefaultInitExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per CXXDefaultInitExpr. Modified:

r347137 - [AST][NFC] Pack CXXDefaultArgExpr

Author: brunoricci Date: Sat Nov 17 04:56:30 2018 New Revision: 347137 URL: http://llvm.org/viewvc/llvm-project?rev=347137=rev Log: [AST][NFC] Pack CXXDefaultArgExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per CXXDefaultArgExpr. Modified:

r347136 - [AST][NFC] Pack CXXThrowExpr

Author: brunoricci Date: Sat Nov 17 04:53:56 2018 New Revision: 347136 URL: http://llvm.org/viewvc/llvm-project?rev=347136=rev Log: [AST][NFC] Pack CXXThrowExpr Use the newly available space in the bit-fields of Stmt. This saves 8 bytes per CXXThrowExpr. Modified:

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

xazax.hun added a comment. In https://reviews.llvm.org/D54557#1300654, @NoQ wrote: > In https://reviews.llvm.org/D54557#1299736, @xazax.hun wrote: > > > It would be great to have a way to extend the list of (possibly non-stl) > > types to check. But I do understand that the analyzer does not