[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. Okay. I was wrong, and you were right. `MallocChecker` seriously suffers from overcrowding. Especially with the addition of `InnerPointerChecker`, it should be split up, but doing that is very much avoidable for the purposes of this effort while still achieving every

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

joerg added a comment. Can you split off the pure modernisation changes like new exception or print ? Those are completely non-contentious changes after all. I generally do not like the range and list related changes as many instances are clear regressions for the 2.x case. filter to list

[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

malaperle added a comment. Hi Ilya. Does this apply to compile_commands.json too? I've seen that problem for that file as well. If not, I understand it can be another patch, just curious. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55139/new/

[PATCH] D55069: Extend the CommentVisitor with parameter types

This revision was automatically updated to reflect the committed changes. Closed by commit rL348100: Extend the CommentVisitor with parameter types (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D55070: Replace FullComment member being visited with parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL348101: Replace FullComment member being visited with parameter (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r348100 - Extend the CommentVisitor with parameter types

Author: steveire Date: Sun Dec 2 09:30:34 2018 New Revision: 348100 URL: http://llvm.org/viewvc/llvm-project?rev=348100=rev Log: Extend the CommentVisitor with parameter types Summary: This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling in

r348101 - Replace FullComment member being visited with parameter

Author: steveire Date: Sun Dec 2 09:30:40 2018 New Revision: 348101 URL: http://llvm.org/viewvc/llvm-project?rev=348101=rev Log: Replace FullComment member being visited with parameter Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55070

r348099 - Remove unecessary methods

Author: steveire Date: Sun Dec 2 09:30:26 2018 New Revision: 348099 URL: http://llvm.org/viewvc/llvm-project?rev=348099=rev Log: Remove unecessary methods The base class calls VisitExpr Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r348094 - Fix whitespace

Author: steveire Date: Sun Dec 2 08:42:34 2018 New Revision: 348094 URL: http://llvm.org/viewvc/llvm-project?rev=348094=rev Log: Fix whitespace Modified: cfe/trunk/test/AST/ast-dump-array.cpp Modified: cfe/trunk/test/AST/ast-dump-array.cpp URL:

r348093 - Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr

Author: steveire Date: Sun Dec 2 08:36:23 2018 New Revision: 348093 URL: http://llvm.org/viewvc/llvm-project?rev=348093=rev Log: Add dump tests for ArrayInitLoopExpr and ArrayInitIndexExpr Added: cfe/trunk/test/AST/ast-dump-array.cpp Added: cfe/trunk/test/AST/ast-dump-array.cpp URL:

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire added a comment. Aaron, you added tests for the existing behavior which pass after this patch. Is there anything holding it up? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55068/new/ https://reviews.llvm.org/D55068

[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Marking both of these as "changes requested" to highlight the similarity of issues in them. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Marking both of these as "changes requested" to highlight the similarity of issues in them. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

Szelethus added a comment. Yup, I agree with everything that was said. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

JonasToth added a comment. In D55044#1312438 , @lebedev.ri wrote: > Thanks for working on this. > Semi-duplicate of D50852 Please see > discussion there. > It should not be an abseil-specific check, the prefix

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added a comment. In D54737#1314946 , @hwright wrote: > Oh, and thanks for taking the time to review this. :) No problem! I will commit on Monday evening (Europe evening) if there are no further comments from other reviewers. Thank you for the

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

JonasToth added a comment. > Wiring out the lexical comparison and AST based comparison sounds like an > interesting idea, however IMHO such a setting is too coarse-grained on the > file level. My guess would be that it depends from expression (fragment) to > expression fragment how you want

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

evgeny777 added a comment. > don't think so. It's just symbol interposition. Every module in the process > gets the same definition. If I have two weak symbols in lib1.a and lib2.a and doesn't define strong one, which one will be chosen at link time? CHANGES SINCE LAST ACTION