[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

yvvan added a comment. Good point :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54996/new/ https://reviews.llvm.org/D54996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54996: [libclang] Fix clang_Cursor_isAnonymous

nik requested changes to this revision. nik added inline comments. This revision now requires changes to proceed. Comment at: test/Index/print-type.cpp:202 // CHECK: CallExpr=Bar:17:3 [type=outer::inner::Bar] [typekind=Elaborated] [canonicaltype=outer::inner::Bar] [canonicaltyp

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. This patch still doesn't make any sense. You don't need to do any special validation when passing a function as a template argument. When Sema instantiates the template definition, it'll rebuild the expressions that refer to the template parameter, which will trigger

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sounds good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://reviews.llvm.org/D55662 ___ cf

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

ahatanak marked an inline comment as done. ahatanak added a comment. In D55662#1349329 , @rjmccall wrote: > Oh, and please update the commit message to primarily talk about the changes > to placeholder checking. You can discuss the impact on the > repea

[PATCH] D55662: [Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an auto variable is being deduced, use the rewritten expression when performing initialization of the

ahatanak updated this revision to Diff 180993. ahatanak retitled this revision from "[Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context." to "[Sema] If CheckPlaceholderExpr rewrites a placeholder expression when the type of an

[clang-tools-extra] r350797 - Remove unnecessary include.

Author: rtrieu Date: Wed Jan 9 20:53:10 2019 New Revision: 350797 URL: http://llvm.org/viewvc/llvm-project?rev=350797&view=rev Log: Remove unnecessary include. QuerySession.h does not need anything from Query.h, so it does not need to include it. Modified: clang-tools-extra/trunk/clang-quer

r350794 - [AMDGPU] Separate feature dot-insts

Author: rampitec Date: Wed Jan 9 19:25:47 2019 New Revision: 350794 URL: http://llvm.org/viewvc/llvm-project?rev=350794&view=rev Log: [AMDGPU] Separate feature dot-insts Differential Revision: https://reviews.llvm.org/D56525 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe

[PATCH] D47819: [compiler-rt] [test] Support using libtirpc on Linux

mgorny planned changes to this revision. mgorny added a comment. Need to update this for the new idea of not using libtirpc at all. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 ___ cfe-commits mai

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

This revision was automatically updated to reflect the committed changes. Closed by commit rL350794: [AMDGPU] Separate feature dot-insts (authored by rampitec, committed by ). Changed prior to commit: https://reviews.llvm.org/D56525?vs=180969&id=180991#toc Repository: rL LLVM CHANGES SINCE

r350792 - Refactor declarations of ASTContext allocate functions into its own header.

Author: rtrieu Date: Wed Jan 9 19:23:25 2019 New Revision: 350792 URL: http://llvm.org/viewvc/llvm-project?rev=350792&view=rev Log: Refactor declarations of ASTContext allocate functions into its own header. Forward declarations of the allocate functions combine with the forward declaration of t

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively updated this revision to Diff 180989. tlively marked 3 inline comments as done. tlively added a comment. - Fix formatting, fix and test macro name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/c

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:89 +// features control availability of builtins +setSIMDLevel(Features, SIMDLevel); +if (HasNontrappingFPToInt) aheejin wrote: > Minor thing, but should we extract this as a

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright created this revision. hwright added reviewers: hokein, aaron.ballman. hwright added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This suggests simplifying expressions which are casting conversion functions, such as `static_cast(absl::ToDoubleSec

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 180984. tlively added a comment. - Match the new naming scheme from rL350791 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: include/clang/Basic/BuiltinsX86.def:988 TARGET_BUILTIN(__builtin_ia32_gathersiv8df, "V8dV8dvC*V8iUcIi", "nV:512:", "avx512f") -TARGET_BUILTIN(__builtin_ia32_gathersiv16sf, "V16fV16fvC

[PATCH] D56529: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper abandoned this revision. craig.topper added a comment. Abandoning because i sent it to llvm-commits instead of cfe-commits. Will redo to get the right mailing list CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56529/new/ https://reviews.llvm.org/D56529 _

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

craig.topper created this revision. craig.topper added reviewers: spatel, RKSimon. This is the clang equivalent of D56527 https://reviews.llvm.org/D56530 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512f-builtins.c

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56525/new/ https://reviews.llvm.org/D56525 ___ cfe-commit

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added a comment. I am satisfied with the proposed feature set for now. I will try to run the check on LLVM itself in the next days as a final test. Are there anymore feature requests or changes from your sides? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ h

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; Eugene.Zelenko wrote: > MyDeve

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 180973. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - Removed detailed diagnostic messages why FixIts could not be generated - Excluded functions returning member pointers for now - All tests run now CHANGES SIN

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: include/clang/Basic/Attr.td:1204 + VariadicUnsignedArgument<"PayloadIndices">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented];

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 180971. jdoerfert added a comment. Allow to use names in the callback metadata Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang/AST/ASTContext.h include/clan

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked an inline comment as done. bernhardmgruber added a comment. I spent some time now to get member pointers as return values working and I am afraid but it seems there is a problem with the clang AST. Given the following code in my check (where `F` is a `FunctionDecl`): co

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticGroups.td:364 def InitializerOverrides : DiagGroup<"initializer-overrides">; +// -Woverride-init = -Winitializer-overrides +def

[libunwind] r350787 - Revert "[Sparc] Add Sparc V8 support"

Author: jgorbe Date: Wed Jan 9 17:08:31 2019 New Revision: 350787 URL: http://llvm.org/viewvc/llvm-project?rev=350787&view=rev Log: Revert "[Sparc] Add Sparc V8 support" This reverts commit r350705. Modified: libunwind/trunk/include/__libunwind_config.h libunwind/trunk/include/libunwind

[PATCH] D50106: [libc++] Fix tuple assignment from type derived from a tuple-like

ldionne added a comment. Herald added subscribers: libcxx-commits, jkorous. Ping! It would be nice to land this in LLVM 8 Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50106/new/ https://reviews.llvm.org/D50106 __

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

rampitec created this revision. rampitec added reviewers: b-sumner, kzhuravl, msearles. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely. clang part Repository: rC Clang https://reviews.llvm.org/D56525 Files: include/clang/Basic/BuiltinsAMDGPU.

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1351824 , @rjmccall wrote: > But why? Why do you want to limit this to just template arguments instead of > all sorts of similar contexts? I updated the patch to disable the check for unevaluated expr context and const

[PATCH] D56523: Improve a -Wunguarded-availability note

erik.pilkington created this revision. erik.pilkington added a reviewer: arphaman. Herald added subscribers: dexonsmith, jkorous. Mention the deployment target, and don't say "partial" which doesn't really mean anything to users. rdar://problem/33601513 Repository: rC Clang https://reviews.

r350785 - [X86] Really make the pointer arguments to avx512 gather/scatter intrinsics 'void*' to match gcc and Intel's documentation.

Author: ctopper Date: Wed Jan 9 16:47:25 2019 New Revision: 350785 URL: http://llvm.org/viewvc/llvm-project?rev=350785&view=rev Log: [X86] Really make the pointer arguments to avx512 gather/scatter intrinsics 'void*' to match gcc and Intel's documentation. The avx2 gather intrinsics are documen

[PATCH] D56522: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a subscriber: cfe-commits. https://bugs.llvm.org/show_bug.cgi?id=40251 https://github.com/ClangBuiltLinux/linux/issues/307 Repository: rC Clang https://reviews.llvm.org/D56522 Files: docs/Diagnost

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl updated this revision to Diff 180960. yaxunl added a comment. disable the check for more general cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451 + case BO_Comma: +llvm_unreachable("Found unimplemented fixed point binary operation"); } Please create a separate case for the non-arithmetic operators (pointer-to-membe

r350779 - In nothrow new-expressions, null-check the result if we're going to

Author: rsmith Date: Wed Jan 9 16:03:29 2019 New Revision: 350779 URL: http://llvm.org/viewvc/llvm-project?rev=350779&view=rev Log: In nothrow new-expressions, null-check the result if we're going to apply sanitizers to it. This avoids a sanitizer false positive that we are initializing a null p

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

rjmccall added a comment. Don't worry, that's a familiar mistake. :) LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54188/new/ https://reviews.llvm.org/D54188 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

Author: nickdesaulniers Date: Wed Jan 9 15:54:55 2019 New Revision: 350776 URL: http://llvm.org/viewvc/llvm-project?rev=350776&view=rev Log: [Sema] Mark target of __attribute__((alias("target"))) used for C Summary: Prevents -Wunneeded-internal-delcaration warnings when the target has no other r

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

This revision was automatically updated to reflect the committed changes. nickdesaulniers marked an inline comment as done. Closed by commit rL350776: [Sema] Mark target of __attribute__((alias("target"))) used for C (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-co

[PATCH] D56518: Change the symbol for the default Swift CFString class.

millenomi created this revision. Herald added a subscriber: cfe-commits. Required for the work in https://github.com/apple/swift-corelibs-foundation/pull/1799 Repository: rC Clang https://reviews.llvm.org/D56518 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp =

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 180947. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h l

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire marked an inline comment as done. steveire added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:3726 +functionContent = SS.str(); +if (SS.tell()) { + OS << " void Visit" << R.getName() << "Attr(const " << R.getName() aaron

[PATCH] D55492: Implement Attr dumping in terms of visitors

steveire updated this revision to Diff 180943. steveire added a comment. Updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55492/new/ https://reviews.llvm.org/D55492 Files: include/clang/AST/AttrVisitor.h include/clang/AST/CMakeLists.txt include/clang/

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 180935. steveire added a comment. Nits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp test/AST/ast-dump-stmt.cp

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

This revision was automatically updated to reflect the committed changes. Closed by commit rC350768: [ObjC] Allow the use of implemented unavailable methods from within (authored by arphaman, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/

r350768 - [ObjC] Allow the use of implemented unavailable methods from within

Author: arphaman Date: Wed Jan 9 14:31:37 2019 New Revision: 350768 URL: http://llvm.org/viewvc/llvm-project?rev=350768&view=rev Log: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context In Objective-C, it's common for some frameworks to mark some metho

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: test/Sema/alias-unused.c:3 +// expected-no-diagnostics +int f() { return 42; } +int g() __attribute__((alias("f"))); rjmccall wrote: > nickdesaulniers wrote: > >

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

nickdesaulniers updated this revision to Diff 180932. nickdesaulniers added a comment. - add static keyword to test case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54188/new/ https://reviews.llvm.org/D54188 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/alias

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + Anastasia wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > rjmccall wr

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

rjmccall added inline comments. Comment at: test/Sema/alias-unused.c:3 +// expected-no-diagnostics +int f() { return 42; } +int g() __attribute__((alias("f"))); nickdesaulniers wrote: > rjmccall wrote: > > Is this meant to be `static`? > It doesn't make a differe

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. But why? Why do you want to limit this to just template arguments instead of all sorts of similar contexts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411 ___ cfe-commits

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively updated this revision to Diff 180921. tlively added a comment. - Decouple sign-ext from simd128 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/clang/Basic/BuiltinsWebAssembly.def include/clang/

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: test/Sema/alias-unused.c:3 +// expected-no-diagnostics +int f() { return 42; } +int g() __attribute__((alias("f"))); rjmccall wrote: > Is this meant to be `static

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan updated this revision to Diff 180920. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55844/new/ https://reviews.llvm.org/D55844 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_s

[clang-tools-extra] r350765 - [clang-tidy] another take at fixing doc

Author: jonastoth Date: Wed Jan 9 13:27:59 2019 New Revision: 350765 URL: http://llvm.org/viewvc/llvm-project?rev=350765&view=rev Log: [clang-tidy] another take at fixing doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst Modified: clang-tools-extra/tr

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

eugenis added a comment. In D56109#1341967 , @mgorny wrote: > We've been discussing this, and I think we're doing this the wrong way. Could > you help me a little understand this? > > In particular, what is the purpose of unpoisoning file? Is it in order

[clang-tools-extra] r350763 - [clang-tidy] tryfix documentation build

Author: jonastoth Date: Wed Jan 9 13:19:44 2019 New Revision: 350763 URL: http://llvm.org/viewvc/llvm-project?rev=350763&view=rev Log: [clang-tidy] tryfix documentation build Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-nodiscard.rst Modified: clang-tools-extra/tr

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Looks like no activity by @ygribov after September LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

Romain-Geissler-1A added subscribers: michaelplatings, serge-sans-paille. Romain-Geissler-1A added a comment. Herald added a reviewer: serge-sans-paille. Hi @serge-sans-paille @michaelplatings, I saw you recently merged some Python 3 related stuff. Here is an older review from November still nev

[clang-tools-extra] r350761 - [clang-tidy] fix-up failing tests

Author: jonastoth Date: Wed Jan 9 13:03:54 2019 New Revision: 350761 URL: http://llvm.org/viewvc/llvm-project?rev=350761&view=rev Log: [clang-tidy] fix-up failing tests Removed: clang-tools-extra/trunk/test/clang-tidy/modernize-use-nodiscard.h Modified: clang-tools-extra/trunk/test/clang

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL350760: [clang-tidy] Adding a new modernize use nodiscard checker (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5543

[clang-tools-extra] r350760 - [clang-tidy] Adding a new modernize use nodiscard checker

Author: jonastoth Date: Wed Jan 9 12:50:50 2019 New Revision: 350760 URL: http://llvm.org/viewvc/llvm-project?rev=350760&view=rev Log: [clang-tidy] Adding a new modernize use nodiscard checker Summary: Adds a checker to clang-tidy to warn when a non void const member function, taking only param

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. @sammccall I (hopefully) fixed the type-issue in my test-cases. They nevertheless fail both on me, on latest llvm+clang+your patch. Clang-tidy still the same, so maybe there is a difference in our builds? Do you build with assertions on? I work on linux, ubuntu 18.04,

r350759 - [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

Author: gbercea Date: Wed Jan 9 12:45:26 2019 New Revision: 350759 URL: http://llvm.org/viewvc/llvm-project?rev=350759&view=rev Log: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest. Summary: Change the strategy for computing loop index variables after collaps

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350759: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop… (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. > I do not have commit rights. I'm not sure what constitutes someone who can > commit, but let me contribute a little more before taking that step, I have > another idea for a checker I'd like to try after this one, I just wanted to > get one under my belt first. Se

r350758 - [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

Author: gbercea Date: Wed Jan 9 12:38:35 2019 New Revision: 350758 URL: http://llvm.org/viewvc/llvm-project?rev=350758&view=rev Log: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter Summary: Introduce a compiler flag for cases when the user knows that the

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

This revision was automatically updated to reflect the committed changes. Closed by commit rC350758: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D55928?vs=179078&id=18090

r350757 - [OPENMP][DOCS]Release notes/OpenMP support updates, NFC.

Author: abataev Date: Wed Jan 9 12:32:56 2019 New Revision: 350757 URL: http://llvm.org/viewvc/llvm-project?rev=350757&view=rev Log: [OPENMP][DOCS]Release notes/OpenMP support updates, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/do

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache updated this revision to Diff 180905. modocache added a comment. Remove obsoleted code I accidentally included. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56243/new/ https://reviews.llvm.org/D56243 Files: include/clang/AST/ASTContext.h include/c

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/ https://reviews.llvm.org/D56469 ___

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache updated this revision to Diff 180903. modocache added a comment. Thanks for the offline review @GorNishanov! This revision allows constexpr usages of __builtin_coro_frame_max_size. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56243/new/ https://review

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman updated this revision to Diff 180901. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56469/new/ https://reviews.llvm.org/D56469 Files: lib/Sema/SemaDeclAttr.c

r350756 - Removing an include that was not necessary; NFC.

Author: aaronballman Date: Wed Jan 9 12:15:10 2019 New Revision: 350756 URL: http://llvm.org/viewvc/llvm-project?rev=350756&view=rev Log: Removing an include that was not necessary; NFC. The include also had a using namespace llvm in it, so this adds qualifiers where needed as well. Modified:

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

efriedma added a comment. It's currently possible to write, in clang: void f() { __try { } __except(({__try{}__finally{}; 3;})) { } } And the following currently crashes if you try to build it with clang: struct A { ~A(); }; int f(const A&); void g() { __try {

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: docs/OpenMPSupport.rst:120 +compile your program with the `-fopenmp-optimistic-collapse`. + + hfinkel wrote: > Can you please clarify here what happens when the loop induction

[PATCH] D56466: [CodeGen] Clarify comment about COFF common symbol alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rC350754: [CodeGen] Clarify comment about COFF common symbol alignment (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D56466?vs=180771&id=180897#toc Repository:

r350754 - [CodeGen] Clarify comment about COFF common symbol alignment

Author: smeenai Date: Wed Jan 9 12:05:16 2019 New Revision: 350754 URL: http://llvm.org/viewvc/llvm-project?rev=350754&view=rev Log: [CodeGen] Clarify comment about COFF common symbol alignment After a discussion on the commit thread, it seems the 32 byte alignment limitation is an MSVC toolchai

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

rjmccall added a comment. I really dislike this particular idiom. This is probably the most reasonable short-term solution to this problem. I do wonder if we should just shift to making Sema track a symbol-to-GD map, though, and maybe make Sema entirely responsible for pushing entities to IRGe

[PATCH] D56509: [AST] Remove ASTContext from getThisType (NFC)

modocache created this revision. modocache added reviewers: akyrtzi, mikael. Herald added subscribers: dexonsmith, mehdi_amini. https://reviews.llvm.org/D54862 removed the usages of `ASTContext&` from within the `CXXMethodDecl::getThisType` method. Remove the parameter altogether, as well as all u

[PATCH] D54188: [Sema] Mark target of __attribute__((alias("target"))) used for C

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I don't like having a solution that doesn't work for C++ and can't reasonably be extended to a solution for C++ (we really don't want to be demangling the alias target here and trying to match

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1349342 , @rjmccall wrote: > Sema won't necessarily have resolved a template decl when parsing a template > argument list, so trying to propagate that decl down to indicate that we're > resolving a template argument is n

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl updated this revision to Diff 180888. yaxunl added a comment. Passing template decl by ExpressionEvaluationContextRecord. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sem

[PATCH] D55781: Make CC mangling conditional on the ABI version

rjmccall added a comment. Okay. In my opinion, then, we should just do this unconditionally. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55781/new/ https://reviews.llvm.org/D55781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180886. mgorny added a comment. Adjusted to make paths sysroot-relative. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files: ELF/Config.h ELF/Driver.cpp ELF/Driver.h Index: ELF/Driver.h ===

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7292 + if (const auto *MD = dyn_cast(OffendingDecl)) { +if (const auto *Impl = dyn_cast(Ctx)) { + if (MD->getClassInterface() == Impl->getClassIn

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht updated this revision to Diff 180882. rupprecht added a comment. Move TableGen language check to where SpacesInContainerLiterals is checked Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 Files: lib/Format/Tok

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. Right, but `getGoogleStyle()` has the inferred language passed in (i.e. `getGoogleStyle(FormatStyle::LanguageKind Language)`. Whereas `getLLVMStyle()` takes no args and assumes C++. Would it be worthwhile to refactor getLLVMStyle to take in an optional language arg?

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

djasper added a comment. Look at getGoogleStyle(). It has a bunch of language-specific configs at the bottom. You can do the same for TableGen in getLLVMStyle(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on D56501 . Also adds a macro define __wasm_unimplemented_simd128__ for feature detection of unimp

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7290 + // when it's actually defined and is referenced from within the + // @implementation itself. + if (const auto *MD = dyn_cast(OffendingDecl)) { Maybe add a sentence:

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > ebevhan wrote: > > rjmccall wrot

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. In D55964#1351348 , @djasper wrote: > This seem to conceptually be a list of things rather than an array subscript, > though, right? Could we alternatively set SpacesInContainerLiterals to false > for LK_TableGen? That seems

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

djasper added a comment. This seem to conceptually be a list of things rather than an array subscript, though, right? Could we alternatively set SpacesInContainerLiterals to false for LK_TableGen? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; ilya-biryukov wrote: > kadircet wrote:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 180859. kadircet marked 12 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/URI.cpp

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. Post-holiday ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added a comment. I wholeheartedly support an openat(2) based VFS, as the current one falls short of the expectations you have of it and is pretty broken right now. As for your assumption #2, I think that depends on what does one want to get out of the VFS. I can certainly see a use for h

  1   2   >