[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

rjmccall added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9839 +return Success(Result, E); + } + Can most of this reasonably be a method on `APFixedPoint`? (And likewise for `CK_IntegralToFixedPoint`.) If nothing else, I suspect you are

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182456. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic/FixedPoint.h clang/lib/AST/Expr.cpp

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan created this revision. leonardchan added reviewers: rjmccall, ebevhan, bjope. leonardchan added a project: clang. This patch includes the necessary code for converting between a fixed point type and integer. This also includes constant expression evaluation for conversions with

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, szepet. This is a slow quick fix for https://bugs.llvm.org/show_bug.cgi?id=37688

[PATCH] D56891: [analyzer] Introduce proper diagnostic for freeing unowned object

This revision was automatically updated to reflect the committed changes. Closed by commit rC351514: [analyzer] Introduce proper diagnostic for freeing unowned object (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D56885: [analyzer] const-ify reference to bug type used in BugReporter

This revision was automatically updated to reflect the committed changes. Closed by commit rC351511: [analyzer] const-ify reference to bug type used in BugReporter (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rC351510: [analyzer] Extend BugType constructor to accept SuppressOnSink as a parameter (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D56896: Update property prefix regex to allow numbers.

Wizard created this revision. Herald added subscribers: cfe-commits, jfb. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56896 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration.m

[PATCH] D56820: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is used

This revision was automatically updated to reflect the committed changes. Closed by commit rC351509: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r351514 - [analyzer] Introduce proper diagnostic for freeing unowned object

Author: george.karpenkov Date: Thu Jan 17 19:13:53 2019 New Revision: 351514 URL: http://llvm.org/viewvc/llvm-project?rev=351514=rev Log: [analyzer] Introduce proper diagnostic for freeing unowned object Insert a note when the object becomes not (exclusively) owned. Differential Revision:

r351513 - [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd

Author: george.karpenkov Date: Thu Jan 17 19:13:40 2019 New Revision: 351513 URL: http://llvm.org/viewvc/llvm-project?rev=351513=rev Log: [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd Differential Revision: https://reviews.llvm.org/D56890 Modified:

r351511 - [analyzer] const-ify reference to bug type used in BugReporter

Author: george.karpenkov Date: Thu Jan 17 19:13:14 2019 New Revision: 351511 URL: http://llvm.org/viewvc/llvm-project?rev=351511=rev Log: [analyzer] const-ify reference to bug type used in BugReporter Differential Revision: https://reviews.llvm.org/D56885 Modified:

r351512 - [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker

Author: george.karpenkov Date: Thu Jan 17 19:13:27 2019 New Revision: 351512 URL: http://llvm.org/viewvc/llvm-project?rev=351512=rev Log: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker https://reviews.llvm.org/D56887 Modified:

r351509 - [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is used

Author: george.karpenkov Date: Thu Jan 17 19:12:48 2019 New Revision: 351509 URL: http://llvm.org/viewvc/llvm-project?rev=351509=rev Log: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is used Differential Revision: https://reviews.llvm.org/D56820 Modified:

r351510 - [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter

Author: george.karpenkov Date: Thu Jan 17 19:13:01 2019 New Revision: 351510 URL: http://llvm.org/viewvc/llvm-project?rev=351510=rev Log: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter Differential Revision: https://reviews.llvm.org/D56884 Modified:

r351508 - [analyzer] [RetainCountChecker] Smart pointer support.

Author: george.karpenkov Date: Thu Jan 17 19:12:35 2019 New Revision: 351508 URL: http://llvm.org/viewvc/llvm-project?rev=351508=rev Log: [analyzer] [RetainCountChecker] Smart pointer support. rdar://47323216 Differential Revision: https://reviews.llvm.org/D56817 Added:

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman updated this revision to Diff 182432. arphaman added a comment. Reverse the priority numbering direction as suggested by @dexonsmith . Now the lower priority is the most important, and the less important priorities have a higher numerical value. Repository: rC Clang CHANGES SINCE

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. We have an issue when using `#pragma clang attribute` with availability attributes: - The explicit attribute that's specified next to the declaration is not

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6170 + } +} + } Anastasia wrote: > rjmccall wrote: > > Does this not need to diagnose redundant qualifiers? Why is this path > > required in addition to the path in

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56735/new/ https://reviews.llvm.org/D56735 ___ cfe-commits mailing list

r351505 - [analyzer] A speculative fix for buildbot failures in the new SymbolReaperTest.

Author: dergachev Date: Thu Jan 17 17:37:14 2019 New Revision: 351505 URL: http://llvm.org/viewvc/llvm-project?rev=351505=rev Log: [analyzer] A speculative fix for buildbot failures in the new SymbolReaperTest. I expect an xvalue to be easier to convert. Modified:

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I requested merge of updated documentation into 8.0 branch in PR40369. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing

[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351500: [analyzer] MoveChecker: Add one more common resetting method, append. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r351500 - [analyzer] MoveChecker: Add one more common resetting method, "append".

Author: dergachev Date: Thu Jan 17 16:16:25 2019 New Revision: 351500 URL: http://llvm.org/viewvc/llvm-project?rev=351500=rev Log: [analyzer] MoveChecker: Add one more common resetting method, "append". This is especially crucial for reports related to use-after-move of standard library objects.

r351499 - [analyzer] Make sure base-region and its sub-regions are either all alive or all dead.

Author: dergachev Date: Thu Jan 17 16:08:56 2019 New Revision: 351499 URL: http://llvm.org/viewvc/llvm-project?rev=351499=rev Log: [analyzer] Make sure base-region and its sub-regions are either all alive or all dead. SymbolReaper now realizes that our liveness analysis isn't sharp enough to

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351499: [analyzer] Make sure base-region and its sub-regions are either all alive or… (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ added a comment. In D56632#1359215 , @NoQ wrote: > In D56632#1356163 , > @baloghadamsoftware wrote: > > > Did you measure decrease in the false-positive rate or an increase in the > > true-positive rate on

r351495 - Make integral-o-pointer conversions in SFINAE illegal.

Author: erichkeane Date: Thu Jan 17 15:11:15 2019 New Revision: 351495 URL: http://llvm.org/viewvc/llvm-project?rev=351495=rev Log: Make integral-o-pointer conversions in SFINAE illegal. As reported in PR40362, allowing the conversion from an integral to a pointer type (despite being illegal in

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Also of note: glib, a super popular library used across many Linux distro's will benefit from the implementation of asm goto (I will send them a patch to fix their version detection once we land in Clang):

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman, arphaman. Herald added subscribers: dexonsmith, jkorous. As of r343360, we support fixed-enums in C. This lead to some warnings in project headers where a fixed enum is forward declared then later

[PATCH] D56868: Add -fset-visibility-for-decls for -cc1

rjmccall added inline comments. Comment at: include/clang/Driver/CC1Options.td:707 +def fset_visibility_for_decls : Flag<["-"], "fset-visibility-for-decls">, + HelpText<"Apply global symbol visibility to declarations without an explicit visibility">; def ftemplate_depth :

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. In D56836#1361528 , @abeserminji wrote: > I am not sure if -static option passed as --cflag to lnt runtest enters the > LDFLAGS. I guess it doesn't. > But if there is a way to check which options are passed as --cflags, we >

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

vstefanovic created this revision. vstefanovic added a reviewer: atanasyan. Herald added subscribers: jrtc27, arichardson, sdardis. These two options enable/disable emission of R_{MICRO}MIPS_JALR fixups along with PIC calls. The linker may then try to turn PIC calls into direct jumps. By default,

r351487 - Fix cleanup registration for lambda captures.

Author: rsmith Date: Thu Jan 17 14:05:50 2019 New Revision: 351487 URL: http://llvm.org/viewvc/llvm-project?rev=351487=rev Log: Fix cleanup registration for lambda captures. Lambda captures should be destroyed if an exception is thrown only if the construction of the complete lambda-expression

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder updated this revision to Diff 182394. scott.linder added a comment. Add missing flag to tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/TargetInfo.cpp

[PATCH] D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351484: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined… (authored by EricWF, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r351484 - Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides.

Author: ericwf Date: Thu Jan 17 13:44:24 2019 New Revision: 351484 URL: http://llvm.org/viewvc/llvm-project?rev=351484=rev Log: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides. Summary: Some style guides want to allow using CTAD only on types that

[PATCH] D56868: Add -fset-visibility-for-decls for -cc1

scott.linder updated this revision to Diff 182390. scott.linder retitled this revision from "Add -f[no-]set-visibility-for-decls" to "Add -fset-visibility-for-decls for -cc1". scott.linder added a comment. Remove driver options CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56868/new/

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added inline comments. Comment at: docs/OpenMPSupport.rst:62 + +- Simplified code generation for distribute and parallel in SPMD mode. + Simplified SPMD code generation for `distribute parallel for` when the new default schedules are applicable.

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added a comment. Thank you @JonasToth for providing more feedback! I will add a few more tests with templates. Maybe I should even try to run the check on Boost and see what happens. In the meantime I might need some help: I tried running the check on LLVM last weekend using

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. That sounds reasonable to me. I had already posted a patch with the Driver options, but I will update it to only include the -cc1 version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/ https://reviews.llvm.org/D53153

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 182385. bernhardmgruber marked 19 inline comments as done. bernhardmgruber added a comment. Addressed most of the new review comments (mainly uppercasing start of comments). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. I don't want this to be a driver option because I don't want to design a general-purpose feature for this right now, nor do I want to gradually accrete a general-purpose feature around a random collection of needs accumulated from other features. Let's just leave it

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added a comment. In D56733#1362182 , @kkwli0 wrote: > In D56733#1360221 , @gtbercea wrote: > > > Could we add the changes in D56790 to > > this diff? > > > Sure, I will

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 182384. kkwli0 added a reviewer: gtbercea. kkwli0 added a comment. Add changes in D56790 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 added a comment. In D56733#1360221 , @gtbercea wrote: > Could we add the changes in D56790 to this > diff? Sure, I will do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/

Re: r351478 - Fix -Wsign-compare in new tests

On Thu, Jan 17, 2019 at 3:56 PM Reid Kleckner via cfe-commits wrote: > > Author: rnk > Date: Thu Jan 17 12:52:46 2019 > New Revision: 351478 > > URL: http://llvm.org/viewvc/llvm-project?rev=351478=rev > Log: > Fix -Wsign-compare in new tests Thank you for the warning fix -- I wasn't seeing the

r351478 - Fix -Wsign-compare in new tests

Author: rnk Date: Thu Jan 17 12:52:46 2019 New Revision: 351478 URL: http://llvm.org/viewvc/llvm-project?rev=351478=rev Log: Fix -Wsign-compare in new tests Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp URL:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi @vit9696, thanks for that, it was a straightforward fix. I'll post an update shortly for D54583 , if arcanist cooperates. The short of it is I need two indices for arguments, since one is for logical arguments the other is for

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

NoQ added a comment. Yeah, i'll be testing this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56823/new/ https://reviews.llvm.org/D56823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

This revision was automatically updated to reflect the committed changes. Closed by commit rL351473: [clang-tidy] Add abseil-duration-conversion-cast check (authored by hwright, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r351473 - [clang-tidy] Add abseil-duration-conversion-cast check

Author: hwright Date: Thu Jan 17 12:37:35 2019 New Revision: 351473 URL: http://llvm.org/viewvc/llvm-project?rev=351473=rev Log: [clang-tidy] Add abseil-duration-conversion-cast check Differential Revision: https://reviews.llvm.org/D56532 Added:

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

george.karpenkov added a comment. LG, but it sounds like something which can skew results a lot (?) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56823/new/ https://reviews.llvm.org/D56823 ___ cfe-commits mailing

Re: r351209 - Revert "Correct the source range returned from preprocessor callbacks."

On Tue, Jan 15, 2019 at 12:23 PM Benjamin Kramer via cfe-commits wrote: > > Author: d0k > Date: Tue Jan 15 09:20:05 2019 > New Revision: 351209 > > URL: http://llvm.org/viewvc/llvm-project?rev=351209=rev > Log: > Revert "Correct the source range returned from preprocessor callbacks." > > This

[clang-tools-extra] r351471 - Revert r351208 (which was a revert of r350892).

Author: aaronballman Date: Thu Jan 17 12:21:44 2019 New Revision: 351471 URL: http://llvm.org/viewvc/llvm-project?rev=351471=rev Log: Revert r351208 (which was a revert of r350892). This corresponds to the fix to Clang in r351470. Modified:

r351470 - Revert r351209 (which was a revert of r350891) with a fix.

Author: aaronballman Date: Thu Jan 17 12:21:34 2019 New Revision: 351470 URL: http://llvm.org/viewvc/llvm-project?rev=351470=rev Log: Revert r351209 (which was a revert of r350891) with a fix. The test case had a parse error that was causing the condition string to be misreported. We now have

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I fixed links. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. By the word, I noticed that HTTP was used and replaced it with HTTPS in Contributing.rst. Will be good idea to do the same in other documentation. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/

Re: [PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Please also note that "safe" functions are C11 Annex K, and it is Optional. I believe glibc does not implement it, and has no intention of implementing it. By memory, i'm not sure any library other than Microsoft's does provide it. On Thu, Jan 17, 2019 at 9:17 PM Kristóf Umann via Phabricator

[clang-tools-extra] r351468 - [Documentation] Fix another link in docs/clang-tidy/Contributing.rst.

Author: eugenezelenko Date: Thu Jan 17 12:00:23 2019 New Revision: 351468 URL: http://llvm.org/viewvc/llvm-project?rev=351468=rev Log: [Documentation] Fix another link in docs/clang-tidy/Contributing.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/Contributing.rst Modified:

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

efriedma added a comment. While you're here, can you also fix `__builtin_arm_rbit64`, `__builtin_arm_rsr64`, and `__builtin_arm_wsr64`? Comment at: include/clang/Basic/BuiltinsAArch64.def:54 +BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc") +BUILTIN(__builtin_arm_crc32cd,

[clang-tools-extra] r351467 - [Documentation] Another attempt to fix link in docs/clang-tidy/Contributing.rst. Use HTTPS for links.

Author: eugenezelenko Date: Thu Jan 17 11:47:44 2019 New Revision: 351467 URL: http://llvm.org/viewvc/llvm-project?rev=351467=rev Log: [Documentation] Another attempt to fix link in docs/clang-tidy/Contributing.rst. Use HTTPS for links. Modified:

[PATCH] D52891: [AMDGPU] Add -fvisibility-amdgpu-non-kernel-functions

scott.linder abandoned this revision. scott.linder added a comment. Will be superseded by either https://reviews.llvm.org/D53153 or https://reviews.llvm.org/D56871 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52891/new/ https://reviews.llvm.org/D52891

[clang-tools-extra] r351466 - [Documentation] Fix link in docs/clang-tidy/Contributing.rst.

Author: eugenezelenko Date: Thu Jan 17 11:35:39 2019 New Revision: 351466 URL: http://llvm.org/viewvc/llvm-project?rev=351466=rev Log: [Documentation] Fix link in docs/clang-tidy/Contributing.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/Contributing.rst Modified:

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder created this revision. scott.linder added reviewers: b-sumner, arsenm, kzhuravl, t-tye, yaxunl. Herald added subscribers: cfe-commits, tpr, dstuttard, wdng. This allows the global visibility controls to be restrictive while still populating the dynamic symbol table where required.

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:54 +BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc") +BUILTIN(__builtin_arm_crc32cd, "UiUiLLUi", "nc") If we can't change the signature on Linux (I don't see any reason why couldn't,

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

JonasToth updated this revision to Diff 182359. JonasToth added a comment. Herald added a reviewer: serge-sans-paille. - make the script more useable in my buildbot context - reduce the test-files - fix unicode issues I encountered while using Repository: rCTE Clang Tools Extra CHANGES SINCE

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

rsmith accepted this revision. rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-defined

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 182356. JonasToth added a comment. - avoid bitrot Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 182355. JonasToth added a comment. - accidentally wrong patch uploaded Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 182354. JonasToth added a comment. avoid bitrot Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth updated this revision to Diff 182353. JonasToth added a comment. - avoid bitrot Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40854/new/ https://reviews.llvm.org/D40854 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 182345. JonasToth added a comment. - generalize to DeclSpec::TQ - add dependent type-tests with `typename` Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files:

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 ___ cfe-commits mailing

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait a bit to see if @rsmith would like to weigh in. If you don't hear back by mid-next week, go ahead and commit. Repository: rC Clang CHANGES

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. clang-tools-sphinx-docs bot is failing because of: Warning, treated as error: /home/buildbot/llvm-build-dir/clang-tools-sphinx-docs/llvm/src/tools/clang/tools/extra/docs/clang-tidy/Contributing.rst:61: ERROR: Unknown target name: "how to setup tooling for llvm".

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

This revision was automatically updated to reflect the committed changes. Closed by commit rL351463: [Documentation] Add a chapter about Clang-tidy integrations. (authored by eugenezelenko, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r351463 - [Documentation] Add a chapter about Clang-tidy integrations.

Author: eugenezelenko Date: Thu Jan 17 10:31:34 2019 New Revision: 351463 URL: http://llvm.org/viewvc/llvm-project?rev=351463=rev Log: [Documentation] Add a chapter about Clang-tidy integrations. Patch by Marina Kalashina. Differential Revision: https://reviews.llvm.org/D54945 Added:

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. You are right, had to modify it like this to get the crash with FreeBSD triple: void f1(long double v, void *a) { } void f2(void* v, __builtin_va_list arg) { f1(__builtin_va_arg(arg, long double), 0); } Repository: rC Clang CHANGES SINCE LAST

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC351461: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56802?vs=182214=182336#toc

r351461 - [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible

Author: epilk Date: Thu Jan 17 10:18:53 2019 New Revision: 351461 URL: http://llvm.org/viewvc/llvm-project?rev=351461=rev Log: [CodeGenObjC] Use a constant value for non-fragile ivar offsets when possible If a class inherits from NSObject and has an implementation, then we can assume that ivar

Re: r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

Hi Hans, Could you please cherry-pick this change into the release branch? Cheers, Alex On Thu, 17 Jan 2019 at 10:16, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Jan 17 10:12:45 2019 > New Revision: 351459 > > URL:

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. In D35068#811436 , @NoQ wrote: > I wonder how noisy this check is - did you test it on large codebases? > Because these functions are

r351459 - [ObjC] Follow-up r350768 and allow the use of unavailable methods that are

Author: arphaman Date: Thu Jan 17 10:12:45 2019 New Revision: 351459 URL: http://llvm.org/viewvc/llvm-project?rev=351459=rev Log: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context This commit extends

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

This revision was automatically updated to reflect the committed changes. Closed by commit rC351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D56816?vs=182191=182334#toc

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi @vit9696 it does crash with the linux target (powerpc-gnu-linux), but is fine with powerpc-gnu-freebsd. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Actually I am not sure about Linux, since this is bare metal, and I just used what fited. However, it does not look like 128-bit or 64-bit long doubles are related. I retried to compile the test case with powerpc-gnu-freebsd target (and even made a compile-time

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added inline comments. Comment at: test/Analysis/security-syntax-checks.m:253 + FILE *file; + sprintf(buf, "a"); // expected-warning{{Call to function 'sprintf' is insecure as it does not provide security checks introduced in the C11 standard. Replace with

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus accepted this revision. Szelethus added a comment. Overall I think this looks great, thanks! I left some inlines that would be nice to fix before commiting, but all of them are minor nits. Would it be possible for you to commit the clang-formatting and the actual logic separately?

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi @vit9696 , This looks to be caused by using 128-bit long double on the platform. Does linux really use 128-bit long doubles on ppc32? FreeBSD uses 64-bit long double, so compiling that with '-target powerpc-gnu-freebsd' works fine. I'm not sure how to handle

[PATCH] D56818: TLS: Respect visibility for thread_local variables on Darwin (PR40327)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351457: TLS: Respect visibility for thread_local variables on Darwin (PR40327) (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r351457 - TLS: Respect visibility for thread_local variables on Darwin (PR40327)

Author: vlad.tsyrklevich Date: Thu Jan 17 09:53:45 2019 New Revision: 351457 URL: http://llvm.org/viewvc/llvm-project?rev=351457=rev Log: TLS: Respect visibility for thread_local variables on Darwin (PR40327) Summary: Teach clang to mark thread wrappers for thread_local variables with hidden

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. I think we need the option to be in the driver, not just -cc1. We are moving towards the clang driver being the authority on how we do offline compilation for AMDGPU, and hiding this in cc1 doesn't help us. I also don't think this is unreasonable to expose in

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added a comment. This should be ready for another round of review. Let me know if I missed any of the older comments. There are two more things that I'd like to do before this lands: - go through the docs again and update/simplify them to make sure they're in sync with the new

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Please, in the future, make sure you post full-context patches. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53928/new/

[PATCH] D56856: [tooling] Add a new argument adjuster for deleting plugin related command line args

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM after the nits are fixed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56856/new/ https://reviews.llvm.org/D56856

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:346 + {ExecuteCommandParams::CLANGD_APPLY_FIX_COMMAND, + ExecuteCommandParams::CLANGD_APPLY_CODE_ACTION}}, }}, sammccall wrote: > Seems a

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182321. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182320. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/SourceCode.cpp

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182322. ilya-biryukov added a comment. - Remove the header file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp clangd/AST.h

  1   2   >