[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. -DNDEBUG is no longer needed now that we don't enable assertions, modules should improve build times for the second stage. Repository: rC Clang

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a subscriber: cfe-commits. We use the existing diag::note_locked_here to tell the user where we saw the first locking. Repository: rC Clang https://reviews.llvm.org/D56967 Files:

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

craig.topper added a comment. It uses current rounding mode for inexact conversions. cvtsi642ss should do the same. As does (u)dq2ps and (u)qq2pd. I think we use sitofp/uitofp for some lengths of those already. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

RKSimon added a comment. Just to confirm, this isn't driven by RC in any way? cvtsi642ps isn't so I don't expect it to be, but just to be sure.. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56965/new/ https://reviews.llvm.org/D56965

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Some nits. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21 AST_MATCHER(CXXRecordDecl, hasMethods) { + for (const auto :

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

JonasToth added inline comments. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:22 AST_MATCHER(CXXRecordDecl, hasMethods) { - return std::distance(Node.method_begin(), Node.method_end()) != 0; + for (const auto : Node.methods()) { +if

r351665 - [FIX] Generalize the expected results for callback clang tests

Author: jdoerfert Date: Sat Jan 19 12:46:10 2019 New Revision: 351665 URL: http://llvm.org/viewvc/llvm-project?rev=351665=rev Log: [FIX] Generalize the expected results for callback clang tests Modified: cfe/trunk/test/CodeGen/callback_annotated.c

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. Herald added a subscriber: kristina. Repository: rC Clang https://reviews.llvm.org/D56965 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512vldqintrin.h test/CodeGen/avx512vldq-builtins.c

[PATCH] D56927: Disable PIC/PIE for MSP430 target

grimar added a comment. Can it be tested with a test case? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56925: Do not use frame pointer by default for MSP430

grimar added a comment. Testcase? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5020 Stmt **SubExprs; unsigned NumAssocs, ResultIndex; SourceLocation GenericLoc, DefaultLoc, RParenLoc; I know that this is not part of this patch, but these arrays are begging to

[PATCH] D56961: NFC: Move GenericSelectionExpr dump to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56961 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. As a type, this can be visited upon. This is similar in spirit to the BlockDecl::Capture type. Repository: rC Clang https://reviews.llvm.org/D56959 Files:

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56960 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

r351651 - Update the license mentioned in this documentation.

Author: chandlerc Date: Sat Jan 19 03:48:15 2019 New Revision: 351651 URL: http://llvm.org/viewvc/llvm-project?rev=351651=rev Log: Update the license mentioned in this documentation. Modified: cfe/trunk/tools/scan-build-py/README.md Modified: cfe/trunk/tools/scan-build-py/README.md URL:

[libunwind] r351648 - Update more file headers across all of the LLVM projects in the monorepo

Author: chandlerc Date: Sat Jan 19 02:56:40 2019 New Revision: 351648 URL: http://llvm.org/viewvc/llvm-project?rev=351648=rev Log: Update more file headers across all of the LLVM projects in the monorepo to reflect the new license. These used slightly different spellings that defeated my regular

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56926/new/ https://reviews.llvm.org/D56926 ___ cfe-commits mailing list

r351642 - [NFC] Generalize expected output for callback test

Author: jdoerfert Date: Sat Jan 19 01:40:08 2019 New Revision: 351642 URL: http://llvm.org/viewvc/llvm-project?rev=351642=rev Log: [NFC] Generalize expected output for callback test Modified: cfe/trunk/test/CodeGen/callback_pthread_create.c Modified:

r351643 - [FIX] Restrict callback pthreads_create test to linux only

Author: jdoerfert Date: Sat Jan 19 01:40:10 2019 New Revision: 351643 URL: http://llvm.org/viewvc/llvm-project?rev=351643=rev Log: [FIX] Restrict callback pthreads_create test to linux only Modified: cfe/trunk/test/CodeGen/callback_pthread_create.c Modified:

r351629 - Emit !callback metadata and introduce the callback attribute

Author: jdoerfert Date: Fri Jan 18 21:36:54 2019 New Revision: 351629 URL: http://llvm.org/viewvc/llvm-project?rev=351629=rev Log: Emit !callback metadata and introduce the callback attribute With commit r351627, LLVM gained the ability to apply (existing) IPO optimizations on indirections

r351647 - [ASTDump] NFC: Convert iterative loops to cxx_range_for

Author: steveire Date: Sat Jan 19 01:57:59 2019 New Revision: 351647 URL: http://llvm.org/viewvc/llvm-project?rev=351647=rev Log: [ASTDump] NFC: Convert iterative loops to cxx_range_for This is coming up a lot in reviews. Better just to change them all at once. Modified:

r351646 - [ASTDump] NFC: Use `const auto` in cxx_range_for loops

Author: steveire Date: Sat Jan 19 01:57:51 2019 New Revision: 351646 URL: http://llvm.org/viewvc/llvm-project?rev=351646=rev Log: [ASTDump] NFC: Use `const auto` in cxx_range_for loops This is coming up a lot in reviews. Better just to do them all at once. Modified:

r351640 - Update the license header in this man-page file.

Author: chandlerc Date: Sat Jan 19 01:24:38 2019 New Revision: 351640 URL: http://llvm.org/viewvc/llvm-project?rev=351640=rev Log: Update the license header in this man-page file. It contains an `$Id$` expansion and so can only be updated from a true Subversion client. See the details of this

[PATCH] D56829: Move decl context dumping to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351637: Move decl context dumping to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56829?vs=182607=182669#toc Repository: rC Clang CHANGES

r351637 - Move decl context dumping to TextNodeDumper

Author: steveire Date: Sat Jan 19 01:05:55 2019 New Revision: 351637 URL: http://llvm.org/viewvc/llvm-project?rev=351637=rev Log: Move decl context dumping to TextNodeDumper Summary: Only an obscure case is moved. Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

[libclc] r351636 - Update the file headers across all of the LLVM projects in the monorepo

Author: chandlerc Date: Sat Jan 19 00:50:56 2019 New Revision: 351636 URL: http://llvm.org/viewvc/llvm-project?rev=351636=rev Log: Update the file headers across all of the LLVM projects in the monorepo to reflect the new license. We understand that people may be surprised that we're moving the