[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 183043. domdom added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086 Files: clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sema/statements.c Index: clang/te

Re: r351701 - Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>

This got fixed in r351820. Thanks, Serge! Axel. On 1/23/19 5:56 AM, Hubert Tong wrote: > I am also hitting this. GCC 4.8 is still the minimum at this time. > > -- HT > > On Tue, Jan 22, 2019 at 8:10 AM Axel Naumann via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > Hi, > >

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom created this revision. domdom added reviewers: lattner, rsmith. Herald added a subscriber: cfe-commits. Ignore trailing NullStmts in compound expressions when determining the result type and value. This is to match the GCC behavior which ignores semicolons at the end of compound expressio

[clang-tools-extra] r351925 - [doc] Fix svn property for bugprone-parent-virtual-call.rst

Author: zinovy.nis Date: Tue Jan 22 22:46:27 2019 New Revision: 351925 URL: http://llvm.org/viewvc/llvm-project?rev=351925&view=rev Log: [doc] Fix svn property for bugprone-parent-virtual-call.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-parent-virtual-call.rst (p

Re: r351701 - Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>

I am also hitting this. GCC 4.8 is still the minimum at this time. -- HT On Tue, Jan 22, 2019 at 8:10 AM Axel Naumann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > This broke our clang builds with > > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36) > > on CentOS Li

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:76 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration ` In https://reviews.llvm.org/D56945, I

[PATCH] D57080: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. stephanemoore edited the summary of this revision. The Acronyms and IncludeDefaultAcronyms options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by running the clang-t

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` Eugene.Zelenko wrote: > Please rebase f

r351924 - [ubsan] Check the correct size when sanitizing array new.

Author: rsmith Date: Tue Jan 22 19:37:29 2019 New Revision: 351924 URL: http://llvm.org/viewvc/llvm-project?rev=351924&view=rev Log: [ubsan] Check the correct size when sanitizing array new. We previously forgot to multiply the element size by the array bound. Modified: cfe/trunk/lib/CodeGen

Re: r347205 - [FileManager] getFile(open=true) after getFile(open=false) should open the file.

I don't have a reduced test case yet, but this seems to cause clang to sometimes claim that an included file isn't found even if it's there, at least on macOS: https://bugs.chromium.org/p/chromium/issues/detail?id=924225 On Mon, Nov 19, 2018 at 8:40 AM Sam McCall via cfe-commits < cfe-commits@list

[clang-tools-extra] r351922 - Revert rCTE351921 to fix documentation geneeration.

Author: stephanemoore Date: Tue Jan 22 18:58:59 2019 New Revision: 351922 URL: http://llvm.org/viewvc/llvm-project?rev=351922&view=rev Log: Revert rCTE351921 to fix documentation geneeration. Original review: https://reviews.llvm.org/D56945 Modified: clang-tools-extra/trunk/clang-tidy/objc/P

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

This revision was automatically updated to reflect the committed changes. Closed by commit rL351921: [clang-tidy] Delete obsolete objc-property-declaration options ✂️ (authored by stephanemoore, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

vsapsai created this revision. vsapsai added reviewers: ahatanak, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. Fixes the warning about incompatible pointer types on assigning to a subclass of type argument an expression of type `__kindof TypeParam`. We already have a mechanism

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai created this revision. vsapsai added reviewers: ahatanak, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. Switch to the inheritance-based visitor from the lambda-based visitor to allow both preorder and postorder customizations during type transformation. NFC intended. ht

Buildbot numbers for the last week of 01/13/2019 - 01/19/2019

Hello everyone, Below are some buildbot numbers for the last week of 01/13/2019 - 01/19/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 01/06/2019 - 01/12/2019

Hello everyone, Below are some buildbot numbers for the week of 01/06/2019 - 01/12/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

r351911 - [Sema][ObjC] Check whether a DelayedDiagnosticPool has been pushed

Author: ahatanak Date: Tue Jan 22 16:55:48 2019 New Revision: 351911 URL: http://llvm.org/viewvc/llvm-project?rev=351911&view=rev Log: [Sema][ObjC] Check whether a DelayedDiagnosticPool has been pushed before adding a delayed diagnostic to DelayedDiagnostics. This fixes an assertion failure in Se

[PATCH] D56925: Do not use frame pointer by default for MSP430

dmikushin updated this revision to Diff 182998. dmikushin added a comment. @grimar Please find the updated patch with a test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber added a comment. Thank you again @JonasToth for all your valueable input! I could almost successfully run my check on the llvm/lib subfolder. I created a compilation database from within Visual Studio using an extension called SourceTrail

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. >> This generally looks sane. What will happen on windows though? Will it >> silently fa > > AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which > uses DynamicLibrary::HandleSet::AddLibrary which works for Windows as well. > (The story is similar

[PATCH] D57072: Don't codegen an unreachable return block

bmoody created this revision. bmoody added reviewers: craig.topper, dberris, rjmccall. Herald added a subscriber: cfe-commits. This patch adds a check at the end of CodeGenFunction::FinishFunction to delete the return block if it isn't reachable. Without this patch applied the code generated for

[PATCH] D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker

george.karpenkov added a comment. > Hmmm, does this mess with options that bad? Could you please clarify? `registerChecker` gets-or-creates a checker object. A checker name (used for getting the options) is set the first time it's created. The checker which was created first "wins" and gets to n

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added a comment. If you don't mind, I'd prefer to finally get over this patch. I'll commit on the 31st, but will wait for any potential feedback 'til then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866

r351889 - [mips] Replace help-text for '-m{no}-relax-pic-calls'. NFC

Author: vstefanovic Date: Tue Jan 22 14:33:53 2019 New Revision: 351889 URL: http://llvm.org/viewvc/llvm-project?rev=351889&view=rev Log: [mips] Replace help-text for '-m{no}-relax-pic-calls'. NFC Thanks to Simon Dardis for the new text. Modified: cfe/trunk/include/clang/Driver/Options.td M

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rUNW351888: Silence warnings about unused parameters (authored by mstorsjo, committed by ). Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56984/new/ https://reviews.ll

[libunwind] r351888 - Silence warnings about unused parameters

Author: mstorsjo Date: Tue Jan 22 14:12:23 2019 New Revision: 351888 URL: http://llvm.org/viewvc/llvm-project?rev=351888&view=rev Log: Silence warnings about unused parameters Differential Revision: https://reviews.llvm.org/D56984 Modified: libunwind/trunk/src/AddressSpace.hpp libunwind/

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

vstefanovic marked an inline comment as done. vstefanovic added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:2423 + Group, + HelpText<"Try turning PIC calls (j{al}r{c} $25) into direct calls " + "(MIPS only)">, Flags<[HelpHidden]>; sd

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver added a comment. Thanks! In D56935#1366756 , @philip.pfaffe wrote: > This generally looks sane. What will happen on windows though? Will it > silently fail? AFAIK PassPlugin::Load uses sys::DynamicLibrary::getPermanentLibrary, which uses Dynam

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

melver updated this revision to Diff 182974. melver marked 2 inline comments as done. melver added a comment. - Use SmallVector in CodeGenOptions.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56935/new/ https://reviews.llvm.org/D56935 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor abandoned this revision. teemperor added a comment. So, the idea of going back to the headers and see if we can potentially remove mm_malloc from the modulemap didn't work out (mostly because a lot of headers include it indirectly). However, when going back to the original issue i not

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

smeenai added inline comments. Comment at: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake:29 -set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") Out of curiosity, how come you decided to disable assertions? https://

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

rsmith added a comment. In D56723#1366529 , @ilya-biryukov wrote: > I'll try playing around with your idea, my initial plan is to store preferred > type alongside the current token as a member of the `Parser` class and update > it when advancing to next

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 182971. dgoldman added a comment. Herald added a subscriber: jfb. - Add test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedDeclPrinte

[PATCH] D56981: [libunwind] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

This revision was automatically updated to reflect the committed changes. Closed by commit rL351875: Enable LLVM_ENABLE_WARNINGS when building standalone out of tree (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews

[PATCH] D56985: [libunwind] Remove an unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rUNW351878: Remove an unused variable (authored by mstorsjo, committed by ). Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56985/new/ https://reviews.llvm.org/D56985

[PATCH] D56982: [libunwind] Fix warnings about printf format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL351876: Fix warnings about printf format strings (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm.org/D56982?vs=1827

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

mstorsjo added a comment. In D56984#1366297 , @ldionne wrote: > LGTM, but would it make sense to have a macro like > `_LIBUNWIND_MAYBE_UNUSED(var)` instead? I guess some macro like that could be ok as well, although I think the `(void)var` is a rather

[libunwind] r351878 - Remove an unused variable

Author: mstorsjo Date: Tue Jan 22 12:50:45 2019 New Revision: 351878 URL: http://llvm.org/viewvc/llvm-project?rev=351878&view=rev Log: Remove an unused variable Differential Revision: https://reviews.llvm.org/D56985 Modified: libunwind/trunk/src/Unwind-seh.cpp Modified: libunwind/trunk/src/

[libunwind] r351877 - Add casts to avoid warnings about implicit conversions losing precision

Author: mstorsjo Date: Tue Jan 22 12:50:42 2019 New Revision: 351877 URL: http://llvm.org/viewvc/llvm-project?rev=351877&view=rev Log: Add casts to avoid warnings about implicit conversions losing precision This fixes warnings like these: DwarfInstructions.hpp:85:25: warning: implicit conversion

[libunwind] r351876 - Fix warnings about printf format strings

Author: mstorsjo Date: Tue Jan 22 12:50:39 2019 New Revision: 351876 URL: http://llvm.org/viewvc/llvm-project?rev=351876&view=rev Log: Fix warnings about printf format strings Either adjust the format string to use a more exact type, or add casts (for cases when printing pointers to structs/objec

[libunwind] r351875 - Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

Author: mstorsjo Date: Tue Jan 22 12:50:33 2019 New Revision: 351875 URL: http://llvm.org/viewvc/llvm-project?rev=351875&view=rev Log: Enable LLVM_ENABLE_WARNINGS when building standalone out of tree When built within the llvm runtimes directory, the runtimes CMakeLists.txt adds the same. Differ

[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, jkorous. Fix a bug where we would compare array sizes with incompatible element types, and look through explicit casts. rdar://44800168 Thanks for taking a look!

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

This revision was automatically updated to reflect the committed changes. Closed by commit rL351872: [docs] Add release notes for notable things I've contributed since last release (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker

Szelethus added a comment. Poor wording on my end, sorry about that. Let me clarify. In D55400#1366684 , @george.karpenkov wrote: > > Deal with the consequences of this, and just correct all plist files to now > > refer to the new base checker. > > What

[clang-tools-extra] r351867 - [doc] Replace 'class' with 'struct' for 'public' by default

Author: zinovy.nis Date: Tue Jan 22 12:27:02 2019 New Revision: 351867 URL: http://llvm.org/viewvc/llvm-project?rev=351867&view=rev Log: [doc] Replace 'class' with 'struct' for 'public' by default Make sample syntax correct. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

philip.pfaffe added a comment. This generally looks sane. What will happen on windows though? Will it silently fail? Comment at: clang/include/clang/Basic/CodeGenOptions.h:292 + /// List of dynamic shared object files to be loaded as pass plugins. + std::vector PassPlugins;

[PATCH] D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. This assertion was only enabled in Debug+Asserts, not on Relea

r351865 - [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output

Author: george.karpenkov Date: Tue Jan 22 11:51:00 2019 New Revision: 351865 URL: http://llvm.org/viewvc/llvm-project?rev=351865&view=rev Log: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output rdar://47397214 Differential Revision: https://revie

r351864 - [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker

Author: george.karpenkov Date: Tue Jan 22 11:50:47 2019 New Revision: 351864 URL: http://llvm.org/viewvc/llvm-project?rev=351864&view=rev Log: [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker Differential Revision: https://reviews.llvm.org/D56951 Modified:

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added a comment. I'll just add that we've been trying to not put things behind OpenCL guards as much as possible. Most of the remaining OpenCL checks are for OpenCL-specific logic like inferring the default address space, and yeah, we could probably make that a target option or someth

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

rsmith added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6237 +llvm::sort(SortedDecls, [](const Decl *L, const Decl *R) { + return L->getID() < R->getID(); +}); I would prefer that we use `getID` only for debug dumping purposes. Can we chan

[PATCH] D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker

george.karpenkov added a comment. > Deal with the consequences of this, and just correct all plist files to now > refer to the new base checker. What does it mean? > Each time a report is emitted from these checkers, create a ProgramPointTag, > and "manually" make sure the emitted checker name

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351862: [Documentation] Use HTTPS whenever possible. (authored by eugenezelenko, committed by ). Changed prior to commit: https://reviews.llvm.org/D56926?vs=182590&id=182947#toc Repository: rCTE Cl

[clang-tools-extra] r351862 - [Documentation] Use HTTPS whenever possible.

Author: eugenezelenko Date: Tue Jan 22 11:19:48 2019 New Revision: 351862 URL: http://llvm.org/viewvc/llvm-project?rev=351862&view=rev Log: [Documentation] Use HTTPS whenever possible. Differential revision: https://reviews.llvm.org/D56926 Modified: clang-tools-extra/trunk/docs/clang-doc.rst

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182945. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic

Re: [clang-tools-extra] r351788 - [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

This has been merged to the 8.0 branch in r351860. Please let me know if there are any follow-ups so they can be merged too. Thanks, Hans On Tue, Jan 22, 2019 at 1:10 AM Kadir Cetinkaya via cfe-commits wrote: > > Author: kadircet > Date: Tue Jan 22 01:10:20 2019 > New Revision: 351788 > > URL:

[PATCH] D55676: [Modules] Fix decl order for DeclsInPrototype

bruno added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55676/new/ https://reviews.llvm.org/D55676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems like a good change to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56946/new/ https://reviews.llvm.org/D56946 ___

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1366456 , @ilya-biryukov wrote: > > Unfortunately I can't get ninja check-clangd to build: > > Looks like `clang-tools-extra` uses an old revision. Rebasing after rL350916 > should d

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182942. dgoldman added a comment. Herald added a subscriber: jfb. - FIXME and dyn_cast - use auto - Add test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: cl

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

rnk added inline comments. Comment at: docs/ReleaseNotes.rst:190 +- For MinGW, clang now produces vtables and RTTI for dllexported classes + without key functions. + hans wrote: > mstorsjo wrote: > > This comment doesn't really say much for the casual reader, pe

[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: docs/ReleaseNotes.rst:190 +- For MinGW, clang now produces vtables and RTTI for dllexported classes + without key functions. + mstorsjo wrote: >

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rC351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

r351849 - [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

Author: teemperor Date: Tue Jan 22 09:59:45 2019 New Revision: 351849 URL: http://llvm.org/viewvc/llvm-project?rev=351849&view=rev Log: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl Summary: Shafik found out that importing a CXXConstructorDecl will create a translation unit

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On 01/22, Chandler Carruth wrote: > On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: jdoerfert > > Date: Fri Jan 18 21:36:54 2019 > > New Revision: 351629 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > >

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added a comment. @rsmith Any comments on this patch before submitting? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 ___ cfe-commits mailing list cfe-commits@lis

Re: r351629 - Emit !callback metadata and introduce the callback attribute

On 01/22, Chandler Carruth wrote: > On Sat, Jan 19, 2019 at 2:18 AM Johannes Doerfert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > Author: jdoerfert > > Date: Fri Jan 18 21:36:54 2019 > > New Revision: 351629 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev > >

[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

ilya-biryukov added a comment. Thanks for the suggestion, this should definitely work! I did struggle to figure out a way to do this without annotating every path with `enterUnknown` and failed. I'll try playing around with your idea, my initial plan is to store preferred type alongside the cur

Re: r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

Thanks, I've merged it to 8.0 in r351839. Since the release notes are for 8.0 and not trunk, I've removed the change from trunk in r351841. On Fri, Jan 18, 2019 at 12:05 PM Kelvin Li wrote: > > Hi Hans, > > I am not sure if it is the proper way to request the change committed > to the release_80

r351841 - ReleaseNotes: remove openmp notes from r351580

Author: hans Date: Tue Jan 22 09:01:39 2019 New Revision: 351841 URL: http://llvm.org/viewvc/llvm-project?rev=351841&view=rev Log: ReleaseNotes: remove openmp notes from r351580 They were for the 8.0 branch, and have been committed there in r351839. Modified: cfe/trunk/docs/ReleaseNotes.rst

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

martong accepted this revision. martong added a comment. The updated version looks good to me! Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:558 + int m; + int f(X x) { return m; } +}; steveire wrote: > Are we missing a matcher that would reach the type of X in this case? > `h

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182933. ymandel marked 3 inline comments as done. ymandel added a comment. Extended test of `hasObjectExpression`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files: clang/unittests/ASTMatchers/ASTMatc

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:3046 +if (!D->doesThisDeclarationHaveABody()) + return cast(const_cast(FoundByLookup)); +else { balazske wrote: > The `cast` should not be needed here (and is not done at

[PATCH] D57060: [NFC][Clang] Add driver tests for sb and predres

dnsampaio created this revision. dnsampaio added a reviewer: pbarrio. Herald added subscribers: cfe-commits, javed.absar. Add tests that arguments for enabling/disabling sb and predres are correctly being or not passed by the driver. Repository: rC Clang https://reviews.llvm.org/D57060 File

[PATCH] D56936: Fix handling of overriden methods during ASTImport

martong added a comment. Shafik, I have realized what's the problem with the `ctu-main` test. When we import the body and set the new body to the existing FunctionDecl then the parameters are still the old parameters so the new body does not refer to the formal parameters! This way the analyzer

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov added a comment. > Unfortunately I can't get ninja check-clangd to build: Looks like `clang-tools-extra` uses an old revision. Rebasing after rL350916 should do the trick. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https:

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 182925. ioeric added a comment. - Rebase on D56903 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files: clangd/ClangdUnit.cpp clan

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric updated this revision to Diff 182922. ioeric marked 15 inline comments as done. ioeric added a comment. - Address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56903/new/ https://reviews.llvm.org/D56903 Files: clangd/CMakeL

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

ioeric added a comment. In D56903#1365487 , @sammccall wrote: > This looks pretty good! My main concern is latency (and variability of > latency) in practice. > Particularly: > > - we should avoid paying for fuzzyfind and fetching hundreds of results when

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182921. dgoldman marked an inline comment as done. dgoldman added a comment. - use auto Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files: clangd/index/SymbolColl

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman added a comment. In D56916#1365357 , @ilya-biryukov wrote: > Good point, @aaron.ballman! @dgoldman, could you please add a test case? Unfortunately I can't get ninja check-clangd to build: /Users/davg/dev/llvm/source/llvm/tools/clang/tools/

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill updated this revision to Diff 182920. lewis-revill added a comment. Rely on default value rather than explicitly marking `TLSSupported` as true. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57055/new/ https://reviews.llvm.org/D57055 Files: lib/Ba

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182919. ymandel marked an inline comment as done. ymandel added a comment. Remove unnecessary expectation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 Files: clang/unittests/ASTMatchers/ASTMatchersTrav

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

ymandel updated this revision to Diff 182918. ymandel marked an inline comment as done. ymandel added a comment. Use backticks instead of quotes for quoted code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56849/new/ https://reviews.llvm.org/D56849 Files: clang/docs/LibASTMatchersR

[PATCH] D57057: [clangd] Log clang-tidy configuration, NFC

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This is used for debugging purpose. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57057 Files: clangd/ClangdUnit.cpp In

[PATCH] D57055: [RISCV] Mark TLS as supported

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/RISCV.h:39 HasD(false), HasC(false) { -TLSSupported = false; +TLSSupported = true; LongDoubleWidth = 128; --

[PATCH] D57055: [RISCV] Mark TLS as supported

lewis-revill created this revision. lewis-revill added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Inform Cla

[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Just realized I missed this review, sorry about that. LGTM with a nit. Comment at: clangd/index/FileIndex.cpp:51 CollectorOpts.RefFilter = RefKind::All; -

[PATCH] D56540: [clangd] Clean the cache of file statuses on vscode-clangd when clangd crashes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/clients/clangd-vscode/src/extension.ts:127 +(fileStatus) => { status.onFileUpdated(fileStatus); }); +} e

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clangd/refactor/tweaks/SwapIfBranches.cpp:34 +/// After: +/// if (foo) { continue; } else { return 10; } +class SwapIfBranches : public Tweak { sammccall wrote: > T

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks for tidying up the docs. LG with one nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5018 +/// memberExpr(hasObjectExpression(hasType(cxxRecordDecl(hasN

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182910. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Fix a typo in a comment: isValidRange -> isValidFileRange - Make action available under 'else' keywords and conditions - Move the logic of creating replacements to a

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, but would it make sense to have a macro like `_LIBUNWIND_MAYBE_UNUSED(var)` instead? Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56984/new/ ht

[PATCH] D57047: [clangd] Fix broken build after r351793.

hokein added a comment. I think it is safe to use the empty one (constructed by the default constructor) here -- since `getDefaults` is not free, and we don't need the configurations in codeComplete, fixed in rL351826 . Repository: rCTE Clang Tools Extra

[clang-tools-extra] r351826 - [clangd] Followup fix of rL351818

Author: hokein Date: Tue Jan 22 06:48:04 2019 New Revision: 351826 URL: http://llvm.org/viewvc/llvm-project?rev=351826&view=rev Log: [clangd] Followup fix of rL351818 ClangTidyOptions::getDefaults is not free, it will initialize all clang-tidy modules to get check-specific options, and we don't u

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia added a comment. In D55850#1366094 , @ebevhan wrote: > Okay, sounds good! I'm not a C++ expert, but I'd be happy to look at the > patches when they're up. Haven't done much serious testing on my end so far, > but from what I've seen the patches

[PATCH] D57047: [clangd] Fix broken build after r351793.

ioeric abandoned this revision. ioeric added a comment. nvm, Simon beat me to it ;) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57047/new/ https://reviews.llvm.org/D57047 ___ cfe-commits mailing list

[PATCH] D57047: [clangd] Fix broken build after r351793.

ioeric added a comment. In D57047#1366265 , @kadircet wrote: > LGTM, but hokein might know better whether to push the default options or the > one in ClangdServerOpts I'm going to land this now to unbreak build. Feel free to comment or do further refac

[PATCH] D57047: [clangd] Fix broken build after r351793.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llv

  1   2   >