[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185492. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address review notes, adjust docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/ https://reviews.llvm.org/D57787

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) JonasToth wrote: > There is

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added inline comments. Comment at: test/clang-tidy/modernize-avoid-c-arrays.cpp:90 + +int not_main(int argc, char *argv[]) { + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: do not declare C-style arrays, use std::array<> instead JonasToth wrote: >

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 185491. shiva0217 added a comment. 1. Remove passing path for LTO because Eli raised the concern that whether it would appropriate to assign the same limitation for all files when LTO enabled. 2. Add -msmall-data-limitation= as James pointed out it's the

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

JonasToth added inline comments. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC = Node.getDeclContext(); + const clang::FunctionDecl *FD = llvm::dyn_cast(DC); + if (!FD) There is `FunctionDecl->castToDeclContext()`

[PATCH] D57746: [clangd] Add CLI flag "-clang-tidy" to enable/disable running clang-tidy checks.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/tool/ClangdMain.cpp:214 +llvm::cl::desc("Enable clang-tidy diagnostics."), +llvm::cl::init(true)); + I thought we

[PATCH] D57464: Generalize method overloading on addr spaces to C++

rjmccall added a comment. Moving parsed attributes between lists isn't unreasonable if that's what you have to do; we already do that when processing the ObjC ARC qualifiers. The ambiguity with function attributes is pretty much inherent. Alternatively, you shouldn't feel like you can't

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185489. jyu2 added a comment. small fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h include/clang/Basic/DiagnosticASTKinds.td

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > > > Indeed, and the existing import_module attribute needs these tests as > well. I'll write some and add them in a follow-up patch. > > > > Thanks for the review! > > Any time! I

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, ); +} defaultInitNonTrivialCStructVar(Dst); rjmccall wrote: > Why don't you just initialize the payload right here, after we've drilled >

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1611 drillIntoBlockVariable(*this, Dst, ); +} defaultInitNonTrivialCStructVar(Dst); Why don't you just initialize the payload right here, after we've drilled down to it?

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits updated this revision to Diff 185487. jhibbits added a comment. Herald added a project: clang. Add feedback from @vit9696, and VAARG fix from @kthomsen. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 Files:

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353268: [CMake] Unify scripts for generating VCS headers (authored by phosek, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

r353268 - [CMake] Unify scripts for generating VCS headers

Author: phosek Date: Tue Feb 5 19:51:00 2019 New Revision: 353268 URL: http://llvm.org/viewvc/llvm-project?rev=353268=rev Log: [CMake] Unify scripts for generating VCS headers Previously, there were two different scripts for generating VCS headers: one used by LLVM and one used by Clang and

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); rsmith wrote: > This can be simplified a little: > ``` >

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185477. jyu2 marked 4 inline comments as done. jyu2 added a comment. More change from review. Add scope checking for asm-goto. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Stmt.h

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, remove the getFunctionType() function from CGCallee, since it accesses the pointee type of the value. The only use was in EmitCall, so just inline it

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak updated this revision to Diff 185466. ahatanak added a comment. Make sure that volatile trivial fields in a struct don't cause Sema to emit a diagnostic. Simplify the code in `Sema::ActOnFields` . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin added a comment. In D57798#1386470 , @sbc100 wrote: > How does this relate to the existing ` -mattr=+atomics` of llc? Will it also > result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Yes Repository: rL LLVM

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D57801 Files: clang/lib/CodeGen/CGCXX.cpp clang/lib/CodeGen/CGCXXABI.h

[PATCH] D57798: [WebAssembly] Add atomics target option

sbc100 added a comment. How does this relate to the existing ` -mattr=+atomics` of llc? Will it also result in `attributes #0 = { "target-features"="+atomics" }` in the bitcode? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/

[PATCH] D57798: [WebAssembly] Add atomics target option

This revision was automatically updated to reflect the committed changes. Closed by commit rL353260: [WebAssembly] Add atomics target option (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r353260 - [WebAssembly] Add atomics target option

Author: aheejin Date: Tue Feb 5 17:41:26 2019 New Revision: 353260 URL: http://llvm.org/viewvc/llvm-project?rev=353260=rev Log: [WebAssembly] Add atomics target option Reviewers: tlively Subscribers: dschuff, sbc100, jgravelle-google, sunfish, jfb, cfe-commits Tags: #clang Differential

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; tlively wrote: > -atomics You

[PATCH] D57798: [WebAssembly] Add atomics target option

tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:172 +} +if (Feature == "0atomics") { + HasAtomics = false; -atomics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin updated this revision to Diff 185454. aheejin added a comment. - Fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57798/new/ https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td lib/Basic/Targets/WebAssembly.cpp

[PATCH] D57798: [WebAssembly] Add atomics target option

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57798 Files: include/clang/Driver/Options.td

[PATCH] D57797: Variable auto-init: fix __block initialization

jfb created this revision. jfb added reviewers: rjmccall, pcc, kcc. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Automatic initialization [1] of __block variables was happening too late, which caused self-init usage to crash, such as here: typedef

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:457-458 + this->NumLabels = NumLabels; + assert((NumLabels != 0 && NumOutputs == 0) || + (NumOutputs != 0 && NumLabels == 0)); This can be simplified a little: ``` assert(!(NumOutputs &&

[PATCH] D57795: [RISCV] Add FreeBSD targets

jrtc27 created this revision. jrtc27 added a reviewer: asb. Herald added subscribers: cfe-commits, rkruppe, rogfer01, shiva0217, kito-cheng, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57795 Files: lib/Basic/Targets.cpp

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57767/new/ https://reviews.llvm.org/D57767

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

ahatanak planned changes to this revision. ahatanak added a comment. This patch is unnecessarily complicated and is not correct. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55659/new/ https://reviews.llvm.org/D55659

[PATCH] D57766: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Cool :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57766/new/ https://reviews.llvm.org/D57766

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

This revision was automatically updated to reflect the committed changes. Closed by commit rL353246: Fix MSVC constructor call extension after b92d290e48e9 (r353181). (authored by jyknight, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r353246 - Fix MSVC constructor call extension after b92d290e48e9 (r353181).

Author: jyknight Date: Tue Feb 5 16:06:03 2019 New Revision: 353246 URL: http://llvm.org/viewvc/llvm-project?rev=353246=rev Log: Fix MSVC constructor call extension after b92d290e48e9 (r353181). The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch of

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. Please update `docs/ClangCommandLineReference.rst`. Also, in my limited testing, GCC just seems to pass the `-msmall-data-limit=...` flag straight through to the linker through

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57794/new/ https://reviews.llvm.org/D57794 ___

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">;

r353240 - [modules] Fix handling of initializers for templated global variables.

Author: rsmith Date: Tue Feb 5 15:37:13 2019 New Revision: 353240 URL: http://llvm.org/viewvc/llvm-project?rev=353240=rev Log: [modules] Fix handling of initializers for templated global variables. For global variables with unordered initialization that are instantiated within a module, we

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. So Eli is concerned we might end up with many globals in the small data section or not picking the best candidates if we pass -G to all files in LTO. I don’t know if anyone has experimented with a heuristic to selectively pick which globals and of which size will be

[PATCH] D57794: Fix MSVC constructor call extension after b92d290e48e9 (r353181).

jyknight created this revision. jyknight added reviewers: thakis, rsmith. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. The assert added to EmitCall there was triggering in Windows Chromium builds, due to a mismatch of the return type. The MSVC constructor call

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL353232: Basic CUDA-10 support. (authored by tra, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r353232 - Basic CUDA-10 support.

Author: tra Date: Tue Feb 5 14:38:58 2019 New Revision: 353232 URL: http://llvm.org/viewvc/llvm-project?rev=353232=rev Log: Basic CUDA-10 support. Differential Revision: https://reviews.llvm.org/D57771 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic/Cuda.cpp

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353231: [Preprocessor] Add a note with framework location for file not found error. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit:

r353231 - [Preprocessor] Add a note with framework location for "file not found" error.

Author: vsapsai Date: Tue Feb 5 14:34:55 2019 New Revision: 353231 URL: http://llvm.org/viewvc/llvm-project?rev=353231=rev Log: [Preprocessor] Add a note with framework location for "file not found" error. When a framework with the same name is available at multiple framework search paths, we

r353229 - [analyzer] Document RetainCountChecker behavior and annotations

Author: george.karpenkov Date: Tue Feb 5 14:27:10 2019 New Revision: 353229 URL: http://llvm.org/viewvc/llvm-project?rev=353229=rev Log: [analyzer] Document RetainCountChecker behavior and annotations Differential Revision: https://reviews.llvm.org/D57721 Modified:

r353227 - [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

Author: george.karpenkov Date: Tue Feb 5 14:26:44 2019 New Revision: 353227 URL: http://llvm.org/viewvc/llvm-project?rev=353227=rev Log: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls Differential Revision: https://reviews.llvm.org/D57782 Modified:

[PATCH] D57782: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls

This revision was automatically updated to reflect the committed changes. george.karpenkov marked an inline comment as done. Closed by commit rC353227: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX… (authored by george.karpenkov, committed by ). Herald added a

r353228 - [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path

Author: george.karpenkov Date: Tue Feb 5 14:26:57 2019 New Revision: 353228 URL: http://llvm.org/viewvc/llvm-project?rev=353228=rev Log: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path Differential Revision: https://reviews.llvm.org/D57783

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. In D36806#1385936 , @lhames wrote: > Looks like this was LGTM'd but never applied. Stephen -- do you have commit > access? Yeah, I was waiting on someone with approval for this area of the code to comment and then lost track

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) aaron.ballman wrote: > riccibruno wrote: > > It is something that is

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. The check should ignore the main function, the program entry point. It is not possible to use

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185398. tra added a comment. Made a comment more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

jlebar accepted this revision. jlebar added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:620 + +// CUDA version requires calling __cudaRegisterFatBinaryEnd(Handle); +if

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

tra added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4621-4638 +auto CUDATarget = IdentifyCUDATarget(FD); +if (CUDATarget == CFT_HostDevice) { + A = TI.checkCallingConvention(CC); + if (A == TargetInfo::CCCR_OK && Aux) +A =

r353219 - Fix a missing word in comment

Author: adrian Date: Tue Feb 5 13:21:01 2019 New Revision: 353219 URL: http://llvm.org/viewvc/llvm-project?rev=353219=rev Log: Fix a missing word in comment Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL:

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Looks like this was LGTM'd but never applied. Stephen -- do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36806/new/ https://reviews.llvm.org/D36806

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:257 Ctx->getLangOpts()); }; @aaron.ballman, slight aside (and not in the

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire accepted this revision. steveire added a comment. Sorry, this fell off my radar :). LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing list

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185385. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/new/ https://reviews.llvm.org/D57674 Files:

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const

r353214 - [DOCS]Support for emission of the debug info for the Cuda devices, NFC.

Author: abataev Date: Tue Feb 5 12:38:36 2019 New Revision: 353214 URL: http://llvm.org/viewvc/llvm-project?rev=353214=rev Log: [DOCS]Support for emission of the debug info for the Cuda devices, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst cfe/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl updated this revision to Diff 185375. yaxunl retitled this revision from "Let AMDGPU compile MSVC headers containing vectorcall" to "[CUDA][HIP] Check calling convention based on function target". yaxunl edited the summary of this revision. yaxunl added a reviewer: tra. yaxunl added a

[PATCH] D56925: Do not use frame pointer by default for MSP430

This revision was automatically updated to reflect the committed changes. Closed by commit rL353212: Do not use frame pointer by default for MSP430 (authored by asl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D56925: Do not use frame pointer by default for MSP430

asl accepted this revision. asl added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Ok now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/ https://reviews.llvm.org/D56925

r353212 - Do not use frame pointer by default for MSP430

Author: asl Date: Tue Feb 5 12:15:03 2019 New Revision: 353212 URL: http://llvm.org/viewvc/llvm-project?rev=353212=rev Log: Do not use frame pointer by default for MSP430 This is suggested by 3.3.9 of MSP430 EABI document. We do allow user to manually enable frame pointer. GCC toolchain uses

[libunwind] r353208 - [CMake] Support compiler-rt builtins library in tests

Author: phosek Date: Tue Feb 5 11:50:47 2019 New Revision: 353208 URL: http://llvm.org/viewvc/llvm-project?rev=353208=rev Log: [CMake] Support compiler-rt builtins library in tests We're building tests with -nostdlib which means that we need to explicitly include the builtins library. When

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. Herald added a project: LLVM. Hmm. `writes_to_superobject`? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230 ___ cfe-commits mailing list

[PATCH] D57162: [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353204: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. (authored by ABataev, committed by ). Changed prior to commit: https://reviews.llvm.org/D57162?vs=183325=185364#toc

r353204 - [DEBUG_INFO][NVPTX] Generate correct data about variable address class.

Author: abataev Date: Tue Feb 5 11:45:57 2019 New Revision: 353204 URL: http://llvm.org/viewvc/llvm-project?rev=353204=rev Log: [DEBUG_INFO][NVPTX] Generate correct data about variable address class. Summary: Added ability to generate correct debug info data about the variable address class.

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:457-460 this->NumOutputs = NumOutputs; this->NumInputs = NumInputs; this->NumClobbers = NumClobbers; + this->NumLabels = NumLabels; rsmith wrote: > jyu2

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 185360. jyu2 added a comment. 1>emit better error for use of output constraints. 2> Add assert for NumLabels and NumOutputs are both larger than 0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits >> wrote: >> > >> > Author: djg >> > Date: Fri Feb 1 14:25:23 2019 >> > New Revision: 352930 >> > >> > URL:

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

What sort of outputs, specifically? Memory outputs are easy; I think the LLVM IR patch actually supports them already. Register outputs are complicated... I guess they're also possible, but we would need to come up with some frontend rule that allows sane code generation. Consider the case

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const

r353199 - [opaque pointer types] More trivial changes to pass FunctionType to CallInst.

Author: jyknight Date: Tue Feb 5 11:17:50 2019 New Revision: 353199 URL: http://llvm.org/viewvc/llvm-project?rev=353199=rev Log: [opaque pointer types] More trivial changes to pass FunctionType to CallInst. Change various functions to use FunctionCallee or Function*. Pass function type through

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:2562 +return ICE->getSubExpr(); + + else if (auto *FE = dyn_cast_or_null(E)) riccibruno wrote: > It is something that is actually possible to audit. I did look at where each > of the skipped

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

keryell accepted this revision. keryell added a comment. This revision is now accepted and ready to land. That looks good. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra updated this revision to Diff 185353. tra added a comment. Make the function object local. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57771/new/ https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp

r353197 - Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*.

Author: jyknight Date: Tue Feb 5 11:01:33 2019 New Revision: 353197 URL: http://llvm.org/viewvc/llvm-project?rev=353197=rev Log: Minor cleanup: remove CGBuild::CreateConst*ByteGEP overloads taking a Value*. Modified: cfe/trunk/lib/CodeGen/CGBuilder.h cfe/trunk/lib/CodeGen/TargetInfo.cpp

[PATCH] D57771: [CUDA] Add basic support for CUDA-10.1

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, sanjoy. https://reviews.llvm.org/D57771 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/CodeGen/CGCUDANV.cpp clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56850/new/ https://reviews.llvm.org/D56850 ___ cfe-commits mailing

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a subscriber: jyknight. craig.topper added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:2236 +llvm::CallBrInst *Result = +Builder.CreateCallBr(FTy, IA, Fallthrough, Transfer, Args); +UpdateAsmCallInst(cast(*Result), HasSideEffect,

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader created this revision. bader added reviewers: keryell, Naghasan. Herald added subscribers: cfe-commits, ebevhan. Herald added a project: clang. -fsycl-is-device enables compilation of the device part of SYCL source file. Patch by Mariya Podchishchaeva Repository: rG LLVM Github

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman added a comment. In D56924#1379342 , @arphaman wrote: > Do you know if this have an effect on the output of completion results or > other tooling-based output? > > A couple of requests: > > - This behavior should be controlled by a printing

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman updated this revision to Diff 185341. dgoldman added a comment. Herald added a project: clang. - Output class scope for ObjCPropertyDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. I emailed llvm-dev and cfe-dev on January 16th. The only responses I got back were of the don't care variety. For now it seems the constrained intrinsics will only be used by clang. @rsmith, does the direction of this patch seem reasonable for clang? Once Richard comments

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added a comment. Could you rebase please? Many things have changed since you last update. After that I'll happily commit on your behalf if you don't have a commit access just yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068

[PATCH] D57767: [opaque pointer types] Cleanup CGBuilder's Create*GEP.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added subscribers: cfe-commits, jfb, jholewinski. Herald added a project: clang. The various EltSize, Offset, DataLayout, and StructLayout arguments are all computable from the Address's element type and the DataLayout

[PATCH] D57765: [ARM] Add Cortex-M35P Support

LukeCheeseman created this revision. LukeCheeseman added a reviewer: olista01. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Add clang frontend testing for Cortex-M35P Repository: rC Clang https://reviews.llvm.org/D57765 Files:

[PATCH] D57764: [AArch64] Add Cortex-A76 and Cortex-A76AE Support

LukeCheeseman created this revision. LukeCheeseman added a reviewer: olista01. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Add clang frontend testing for cortex-a76 and cortex-a76ae Repository: rC Clang https://reviews.llvm.org/D57764

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov added a comment. In D57739#1385144 , @hokein wrote: > This seems introduce intrusive changes to the Tweak interface (Tweak will > need to know the `FormatStyle` somehow), I think this might be done in > another patch. It's totally fine,

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. The "false negatives" in the current behaviour are the result of an intentional decision to avoid false positives for unsequenced operations that cannot actually both happen as part of the

[PATCH] D57755: [clangd] Some minor fixes.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57755/new/ https://reviews.llvm.org/D57755

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. Looking at git blame, this change means that we will warn on `(b && x++) + (!b && x++)`. However we will also warn on an expression like `(x > some_constant && y++) + (x < some_constant && y++)`. This seems to be the job of a static analyser which is able to do some

[PATCH] D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs

kkwli0 closed this revision. kkwli0 added a comment. Committed: r353186 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57690/new/ https://reviews.llvm.org/D57690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r353186 - [OPENMP] issue error messages for multiple teams contructs in a target construct

Author: kli Date: Tue Feb 5 08:43:00 2019 New Revision: 353186 URL: http://llvm.org/viewvc/llvm-project?rev=353186=rev Log: [OPENMP] issue error messages for multiple teams contructs in a target construct The fix is to issue error messages if there are more than one teams construct inside a

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

riccibruno added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1260 + // this compound expression contains nothing but NullStmts, then we return + // the index of the last one. If the compound statement is empty, return + // None. Additionally I

[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353181: [opaque pointer types] Fix the CallInfo passed to EmitCall in some (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57664?vs=184975=185313#toc

  1   2   >