[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto : DeclCache) { + auto *D = SP.first; Just looking at the type declarations in CGDebugInfo.h: Why not iterate over the `SPCache`

[PATCH] D58033: Add option for emitting dbg info for call sites

aprantl added inline comments. Comment at: include/clang/Driver/Options.td:919 HelpText<"Do not use jump tables for lowering switches">; +def emit_param_entry_values : Joined<["-"], "femit-param-entry-values">, + Group, I assume that

[PATCH] D60749: [Test] Remove obsolete test.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, aaron.ballman, tyler.nowicki, TylerNowicki. Meinersbur added a project: clang. The FIXME of this test case has been addressed in r335084/r338800. Its execution still does not succeed because of multiple syntax errors. First,

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Both work, although using -### requires a few more changes to the test than just changing –c to –S because all arguments are enclosed in double quotes. I think it would be simplest to just change “-c” to “-S” , and if that is okay with you, I can make the change. Douglas Yung From: Richard

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 created this revision. wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, hjl.tools, RKSimon, rnk, andreadb. wxiao3 added a project: clang. Herald added a subscriber: cfe-commits. According to i386 System V ABI 2.1: Structures and unions assume the alignment of their most strictly

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 195291. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

> > > *Ideas on how to improve the backend situation:* > *- Let FPPassManager::runOnFunction() call* > *if (ProfileTime)* > *llvm::timeTraceProfilerBegin("RunPass", FP->getPassName());* > * for each pass so that it's visible which path the time goes into* > In my tests (which I

Re: r358355 - [c++20] Enable driver and frontend support for building and using

On Mon, 15 Apr 2019, 19:08 via cfe-commits, wrote: > Hi Richard, > > That helps a little bit! Our main problem is that the environment where > the compiler is built and tested (using lit) does not have the external > assembler installed, so all of the compiler commands which try to use "-c" >

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Hi Richard, That helps a little bit! Our main problem is that the environment where the compiler is built and tested (using lit) does not have the external assembler installed, so all of the compiler commands which try to use "-c" fail when trying to run the external assembler. I find that if

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2017 + auto LastIdx = Field != FieldEnd + ? Field->getFieldIndex() Please use an actual type rather than `auto` here and below. Comment at:

Re: r358355 - [c++20] Enable driver and frontend support for building and using

On Mon, 15 Apr 2019 at 18:14, via cfe-commits wrote: > > Hi Richard, > > The driver test you added (modules.cpp) seems to fail if the compiler > configuration uses an external assembler. Is there any way that the test can > be rewritten so that it works with both the integrated and an external

r358470 - Tweak test to pass when using a non-integrated assembler.

Author: rsmith Date: Mon Apr 15 18:44:53 2019 New Revision: 358470 URL: http://llvm.org/viewvc/llvm-project?rev=358470=rev Log: Tweak test to pass when using a non-integrated assembler. Modified: cfe/trunk/test/Driver/modules.cpp Modified: cfe/trunk/test/Driver/modules.cpp URL:

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Hi Richard, The driver test you added (modules.cpp) seems to fail if the compiler configuration uses an external assembler. Is there any way that the test can be rewritten so that it works with both the integrated and an external assembler configurations? Douglas Yung -Original

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:20 +// back from that variable. Test what happens if default bindings are used. +class

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell accepted this revision. keryell added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + let Spellings = [GNU<"sycl_device">]; + let Subjects = SubjectList<[Function, Var]>; aaron.ballman wrote: >

r358467 - PR41192: fix cases where "missing '; ' after class" error would

Author: rsmith Date: Mon Apr 15 17:47:45 2019 New Revision: 358467 URL: http://llvm.org/viewvc/llvm-project?rev=358467=rev Log: PR41192: fix cases where "missing ';' after class" error would incorrectly fire. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195280. NoQ added a comment. Whoops, copy-paste error. So, like, the reason why i added a unittest was that i wanted to test separation of concerns: that it's specifically our Store that works correctly, not only the system as a whole. CHANGES SINCE LAST

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195279. NoQ added a comment. Fix test file name in the top comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60742/new/ https://reviews.llvm.org/D60742 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/string.c

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. Herald added a project: clang. D44934

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 195278. hintonda added a comment. - Change `llvm_checker` to `llvm_check`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

void added a comment. In D56571#1467358 , @craig.topper wrote: > I think things don't work right unless you disable the integrated assembler. > I'm not sure why though. Using `-no-integrated-as` does allow it to compile, but it doesn't link (with

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:57 +/// \endcode +AST_MATCHER_P(ObjCImplementationDecl, isSubclassOf, + ast_matchers::internal::Matcher, stephanemoore wrote: > aaron.ballman

r358464 - DebugInfo: Default to standalone debug when tuning for LLDB

Author: dblaikie Date: Mon Apr 15 17:16:29 2019 New Revision: 358464 URL: http://llvm.org/viewvc/llvm-project?rev=358464=rev Log: DebugInfo: Default to standalone debug when tuning for LLDB LLDB can't currently handle Clang's default (limit/no-standalone) DWARF, so platforms that default to LLDB

[PATCH] D60739: [analyzer] NFC: Re-use reusable unittest mocks.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Put them into a dedicated header, as

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

erik.pilkington added a comment. Akira and I were just talking about an alternative approach to this: Keep a vector of pairs of BlockDecls and SourceLocations in the enclosing method's FunctionScopeInfo, and emit any unsuppressed diagnostics when popping the method. This would avoid having to

r358463 - Simplify diagnosis of misplaced attributes in module-declarations.

Author: rsmith Date: Mon Apr 15 16:55:58 2019 New Revision: 358463 URL: http://llvm.org/viewvc/llvm-project?rev=358463=rev Log: Simplify diagnosis of misplaced attributes in module-declarations. No functional change intended. Modified: cfe/trunk/lib/Parse/Parser.cpp Modified:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 195270. hintonda added a comment. - Alphabetize registration calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak added a comment. Sorry, clang was failing to diagnose `self` referenced inside a c++ lambda that was nested inside a block. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736

[PATCH] D60674: [X86] Restore the pavg intrinsics.

efriedma added a comment. Okay, thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews.llvm.org/D60674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

stephanemoore planned changes to this revision. stephanemoore added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher,

[PATCH] D40381: Parse concept definition

rsmith added a comment. Thanks! Please revert the (presumably unintended) mode changes to the `ptxas` executables. Comment at: include/clang/AST/DeclTemplate.h:3035 + SourceRange getSourceRange() const override LLVM_READONLY { +return SourceRange(getLocation(),

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

benlangmuir added a comment. LGTM, but I'd appreciate someone who has worked on this more recently taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60735/new/ https://reviews.llvm.org/D60735

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington, arphaman. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. If the block implicitly referencing `self` doesn't escape, there is no risk of creating retain cycles, so clang shouldn't

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

harlanhaskins created this revision. harlanhaskins added a reviewer: benlangmuir. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Previously, we would return true/false signifying if the cache/lookup succeeded or failed. Instead, provide clients with the

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

riccibruno added a comment. This is also very useful to test that a given warning is only emitted in c++xx. Funnily when grepping for `verify=` in `test/` most matches are from tests exercising this functionality. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think this functionality is unused because you would split the file into six to reduce the overhead/scroll and that is it. It is a cool reveal, could you provide a documentation?

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, jdenny. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Just wanted to give a bit more

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1465975 , @aaronpuchert wrote: > In D59673#1461983 , @dblaikie wrote: > > > Sure, I think the naming's a bit weird (but hard to come up with good names > > for any of this) > >

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:382 + if module == 'llvm' or module == 'clang': +namespace = module + '_checker' + else: aaron.ballman wrote: > I thought

[PATCH] D60663: Time profiler: small fixes and optimizations

This revision was automatically updated to reflect the committed changes. Closed by commit rL358448: Time profiler: small fixes and optimizations (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added a comment. In D59802#1467363 , @aaron.ballman wrote: > LGTM aside from a nit and the ultimate name for the `isa_and_nonnull<>` API. Thanks. I'll ping the list again at the end of the week, then

r358448 - Time profiler: small fixes and optimizations

Author: anton-afanasyev Date: Mon Apr 15 14:02:47 2019 New Revision: 358448 URL: http://llvm.org/viewvc/llvm-project?rev=358448=rev Log: Time profiler: small fixes and optimizations Summary: Fixes from Roman's review here: https://reviews.llvm.org/D58675#1465336 Reviewers: lebedev.ri

r358445 - [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD

Author: abataev Date: Mon Apr 15 13:38:10 2019 New Revision: 358445 URL: http://llvm.org/viewvc/llvm-project?rev=358445=rev Log: [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD mode. After the previous patch with the more correct handling of the number of threads in parallel

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358441: [clang-format] Fix -Wconversion-null warning in GCC (authored by reuk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r358441 - [clang-format] Fix -Wconversion-null warning in GCC

Author: reuk Date: Mon Apr 15 13:13:20 2019 New Revision: 358441 URL: http://llvm.org/viewvc/llvm-project?rev=358441=rev Log: [clang-format] Fix -Wconversion-null warning in GCC GCC -Wconversion-null warning appeared after 9a63380260860b657b72f07c4f0e61e382ab934a. There was a similar problem

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

aaron.ballman added a comment. No opposition from me regarding `llvm_check`, though I think `llvm_tidy` might also be a reasonable option. I'm a bit less keen on `llvm_checker` as the name, but not strongly opposed. Comment at:

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit and the ultimate name for the `isa_and_nonnull<>` API. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28

[PATCH] D60674: [X86] Restore the pavg intrinsics.

craig.topper added a comment. In D60674#1467349 , @efriedma wrote: > > Though I modified the avx512 intrinsics to not have masking built in. > > Do we need autoupgrade support from the old avx512 intrinsics to the new > avx512 intrinsics? Yes, and the

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. In D56571#1467333 , @void wrote: > This code: > > ; ModuleID = 'arch_static_branch.bc' > source_filename = "arch/x86/entry/vsyscall/vsyscall_64.c" > target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" > target

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924

[PATCH] D60674: [X86] Restore the pavg intrinsics.

efriedma added a comment. > Though I modified the avx512 intrinsics to not have masking built in. Do we need autoupgrade support from the old avx512 intrinsics to the new avx512 intrinsics? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195235. ymandel added a comment. Fix include ordering (bad clang-format config). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files:

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195234. ymandel marked 2 inline comments as done. ymandel added a comment. Deleted ASTEdit builder; added more `change` overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/

[PATCH] D60663: Time profiler: small fixes and optimizations

aras-p added a comment. > So i can't and won't claim any legal knowledge, but it maybe would be good > for him to at least comment here, that he is ok with this? Yes, absolutely fine. The only reason why some files started with the old license blurb is because I started the branch before

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

void added a comment. ; ModuleID = 'arch_static_branch.bc' source_filename = "arch/x86/entry/vsyscall/vsyscall_64.c" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target triple = "x86_64-grtev4-linux-gnu" %struct.atomic_t = type { i32 } %struct.jump_entry = type {

[PATCH] D60663: Time profiler: small fixes and optimizations

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Ok, LG, thank you! Comment at: llvm/lib/Support/TimeProfiler.cpp:30 +cl::desc( +"Minimum time granularity (in microsecons) traced by time profiler"), +

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ldionne added a comment. Reverted in r358437 because of unforeseen CI failures. The failures I was expecting are in libc++, not in compiler-rt. I'll investigate locally and re-apply. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60626/new/

r358437 - Revert "[clang] Aligned allocation is actually supported in macosx 10.13"

Author: ldionne Date: Mon Apr 15 12:08:52 2019 New Revision: 358437 URL: http://llvm.org/viewvc/llvm-project?rev=358437=rev Log: Revert "[clang] Aligned allocation is actually supported in macosx 10.13" This reverts r358409, which I think broke the bots in compiler-rt. Since I'm having trouble

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675 > > This is the first part of time tracing system, I have splitted them cause > > this

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

dendibakh added a comment. @reuk , can you please commit this patch on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60726/new/ https://reviews.llvm.org/D60726 ___ cfe-commits mailing list

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

reuk accepted this revision. reuk added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60726/new/ https://reviews.llvm.org/D60726 ___ cfe-commits

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D60455#1464324 , @Fznamznon wrote: > Applied comments from @aaron.ballman and @keryell > > - Introduced a C++11 and C2x

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. @MaskRay can you review this again now that there's just a single `crtbegin.o` and `crtend.o` version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 ___ cfe-commits

r358435 - [X86] Improve avx512-kconstraints-att_inline_asm.c to not be easily defeated by deadcode elimination. Improve CHECK lines to check IR types used. NFC

Author: ctopper Date: Mon Apr 15 11:39:36 2019 New Revision: 358435 URL: http://llvm.org/viewvc/llvm-project?rev=358435=rev Log: [X86] Improve avx512-kconstraints-att_inline_asm.c to not be easily defeated by deadcode elimination. Improve CHECK lines to check IR types used. NFC I plan to use

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, hans, rsmith. Add a test for tracking PR41027 (8.0 regression breaking assembly code relying on __builtin_constant_p() to identify compile-time constants). Mark it as expected to fail everywhere.

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

dexonsmith added a comment. In D60233#1467092 , @trixirt wrote: > A comment by whisperity in the origin WIP did not seem to be addressed. > Have you looked at IWYU > https://github.com/include-what-you-use/include-what-you-use ? > The end goals of

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

dendibakh created this revision. dendibakh added a reviewer: reuk. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC -Wconversion-null warning appeared after 9a63380260860b657b72f07c4f0e61e382ab934a. There was a similar problem already in the past:

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added a comment. A few quick responses, will take a closer look again tomorrow. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ymandel wrote: > ilya-biryukov

[PATCH] D59744: Fix i386 ABI "__m64" type bug

RKSimon added inline comments. Comment at: test/CodeGen/x86_32-m64-darwin.c:1 +// RUN: %clang_cc1 -w -fblocks -triple i386-apple-darwin9 -target-cpu yonah -target-feature +mmx -emit-llvm -O2 -o - %s | FileCheck %s + You should be able to merge all of these

[PATCH] D60674: [X86] Restore the pavg intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358427: [X86] Restore the pavg intrinsics. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D60674?vs=195090=195219#toc Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL358428: [CommandLineParser] Add DefaultOption flag (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D59746?vs=195218=195220#toc Repository: rL LLVM CHANGES

r358428 - [CommandLineParser] Add DefaultOption flag

Author: dhinton Date: Mon Apr 15 10:18:10 2019 New Revision: 358428 URL: http://llvm.org/viewvc/llvm-project?rev=358428=rev Log: [CommandLineParser] Add DefaultOption flag Summary: Add DefaultOption flag to CommandLineParser which provides a default option or alias, but allows users to override

r358427 - [X86] Restore the pavg intrinsics.

Author: ctopper Date: Mon Apr 15 10:17:35 2019 New Revision: 358427 URL: http://llvm.org/viewvc/llvm-project?rev=358427=rev Log: [X86] Restore the pavg intrinsics. The pattern we replaced these with may be too hard to match as demonstrated by PR41496 and PR41316. This patch restores the

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 195218. hintonda added a comment. - Add new test back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files: clang/lib/Tooling/CommonOptionsParser.cpp

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1466263 , @ebevhan wrote: > Well, it doesn't seem to me like there is consensus on prohibiting nested > address space conversion like this. > > I can simply redo the patch to only include the bugfix on implicit >

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 195217. hintonda added a comment. - Original patch, r358337, that was reverted. - Make sure to clear DefaultOptions on reset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:495 + virtual size_t getNumReturnValues() const override { +return isValidState() ? ReturnedValues.size() : -1; + } This should

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Clang tests should just cover the C->IR translation, and not depend on the LLVM backends. This should instead be an IR->asm test in the LLVM repository. Repository: rC

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

dnsampaio created this revision. dnsampaio added reviewers: olista01, miyuki. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added a parent revision: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv. ostannard requested

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

trixirt added a comment. A comment by whisperity in the origin WIP did not seem to be addressed. Have you looked at IWYU https://github.com/include-what-you-use/include-what-you-use ? The end goals of clang-scan-deps and iwyu seem similar so their implementation problems would also be similar.

Re: r358402 - clang-format vs plugin: Visual Studio 2019 support

Nice! Is adding compat to https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain=false#overview equally easy? On Mon, Apr 15, 2019 at 9:01 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Mon Apr 15 06:02:03 2019 > New

[PATCH] D60719: Fixing freestanding for memcpy.

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60719 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen to track fix after buildbot failure and revert -- r358414. http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190415/644037.html Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov wrote: > > > ymandel wrote: > > > >

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. > Our current approach is to add an attribute, which SYCL runtime will use to > mark code passed to `cl::sycl::handler::parallel_for` as "kernel functions". > Obviously runtime library can't mark `foo` as "device" code - this is a > compiler job: to traverse all

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/openmp_offload_registration.cpp:38 +// CHECK: define internal void @.omp_offloading.requires_reg() +// CHECK: call void @__tgt_register_requires(i64 0) +// CHECK: ret

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195201. ymandel marked 10 inline comments as done. ymandel added a comment. Clarified comments for `translateEdits` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break; gtbercea wrote: > gtbercea wrote:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195200. gtbercea added a comment. - Remove const. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195198. djtodoro retitled this revision from "Add option for emitting DW_OP_entry_values" to "Add experimental options for call site related dbg info". djtodoro edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break;

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:1438 + /// requires directives was used in the current module. + virtual llvm::Function *emitRequiresDirectiveRegFun(); + ABataev wrote: >

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195195. gtbercea added a comment. - Add break. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 195192. djtodoro added a comment. -Rebase -Use `ExprMutationAnalyzer` for parameter's modification check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195190. gtbercea added a comment. - Fix type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro updated this revision to Diff 195188. djtodoro edited the summary of this revision. djtodoro added a comment. -Rebase -Add all_call_sites flag in the case of GNU extensions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8970 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + } You can do `break;` here, no need for

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195186. gtbercea added a comment. - Remove atomic flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195185. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

  1   2   >