[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, it's nice if this mechanism comes in handy in other cases than the one it was originally made for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

BillyONeal marked an inline comment as done. BillyONeal added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int

r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Author: leonardchan Date: Mon May 6 20:20:17 2019 New Revision: 360109 URL: http://llvm.org/viewvc/llvm-project?rev=360109=rev Log: Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration" Updated with fix for read of uninitialized memory. Added:

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492781 , @rsmith wrote: > In D61165#1490417 , @erik.pilkington > wrote: > > > In D61165#1490168 , @rjmccall > > wrote: > > > > > I

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492780 , @dexonsmith wrote: > In D61165#1492724 , @rjmccall wrote: > > > In D61165#1492582 , > > @erik.pilkington wrote: > > > > >

[PATCH] D61464: [RiscV] Typo in register aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL360104: Fix typo in risc-v register aliases. (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r360104 - Fix typo in risc-v register aliases.

Author: echristo Date: Mon May 6 17:45:47 2019 New Revision: 360104 URL: http://llvm.org/viewvc/llvm-project?rev=360104=rev Log: Fix typo in risc-v register aliases. Patch by John. Differential Revision: https://reviews.llvm.org/D61464 Modified: cfe/trunk/lib/Basic/Targets/RISCV.cpp

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rsmith added a comment. In D61165#1490417 , @erik.pilkington wrote: > In D61165#1490168 , @rjmccall wrote: > > > I think the intuitive rule is that initialization is complete when the > > full-expression

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

dexonsmith added a comment. In D61165#1492724 , @rjmccall wrote: > In D61165#1492582 , @erik.pilkington > wrote: > > > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > > appears to claim

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1492582 , @erik.pilkington wrote: > Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which > appears to claim that initialization ends with the execution of the > constructor, excluding temporary

Re: r359960 - Reduce amount of work ODR hashing does.

On Mon, May 6, 2019 at 4:24 PM Richard Trieu wrote: > > There was no cycle for this crash. Oh, yeah, didn't mean to imply there were - but that a system designed to prevent cycles might also be used/help prevent redundant work like this. > What happened is that an exponential runtime is reduced

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. Discussed with the team different approaches and suggesting https://reviews.llvm.org/D61621 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44387/new/ https://reviews.llvm.org/D44387 ___ cfe-commits mailing list

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Can you update some Clang IR generation test that uses these flags to run w/ the new PM? It should fail without this and pass with this. LGTM w/ that test updated. Repository: rC

Re: r359960 - Reduce amount of work ODR hashing does.

There was no cycle for this crash. What happened is that an exponential runtime is reduced to a linear runtime. Without this revision, ODR hashing would have worked if the machine had enough memory and the user waited long enough. void foo(int a, int b) {} When computing the ODR hash for

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rC360100: [Clang][NewPM] Dont bail out if the target machine is empty (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D58374?vs=188999=198367#toc Repository: rC

r360100 - [Clang][NewPM] Don't bail out if the target machine is empty

Author: phosek Date: Mon May 6 16:24:17 2019 New Revision: 360100 URL: http://llvm.org/viewvc/llvm-project?rev=360100=rev Log: [Clang][NewPM] Don't bail out if the target machine is empty This matches the behavior of the old pass manager. There are some targets that don't have target machine at

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

chandlerc added a comment. Same comment as on other Clang patch -- let's update an IR generation test to reflect this? Should just be adding a RUN line. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61620/new/ https://reviews.llvm.org/D61620

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai created this revision. vsapsai added reviewers: craig.topper, GBuella. Herald added subscribers: dexonsmith, jkorous. vsapsai added a parent revision: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.. Currently `immintrin.h` includes `pconfigintrin.h` and

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai created this revision. vsapsai added reviewers: aaron.ballman, rsmith. Herald added subscribers: dexonsmith, jkorous, eraman. This can be used for better support of `-fno-gnu-inline-asm` builds. rdar://problem/49540880 https://reviews.llvm.org/D61619 Files:

[PATCH] D61620: [NewPassManager] Add tuning option: LoopUnrolling [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, dmgreen, jlebar. Herald added a project: clang. Use CodeGenOpts's setting for loop unrolling. [to be coupled with D61618 ] Repository: rC Clang

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk updated this revision to Diff 198359. rnk added a comment. - fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61615/new/ https://reviews.llvm.org/D61615 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D61617: [NewPassManager] Add tuning option: SLPVectorization [clang-change]

asbirlea created this revision. asbirlea added a reviewer: chandlerc. Herald added subscribers: cfe-commits, jlebar. Herald added a project: clang. NewPassManager is not using CodeGenOpts values before this patch. [to be coupled with D61616 ] Repository: rC

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt added a comment. All of the real work is the header-guard checks is done by their common base class utils/HeaderGuard. The much smaller llvm and bugprone subclasses are only concerned with the style of the fix. My understanding of the directory layout guidance in the docs is that

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

smeenai added inline comments. Comment at: libunwind/src/CMakeLists.txt:160 if (LIBUNWIND_INSTALL_LIBRARY) - install(TARGETS ${LIBUNWIND_INSTALL_TARGETS} + if(libcxxabi IN_LIST LLVM_RUNTIME_DISTRIBUTION_COMPONENTS) +set(export_to_llvmruntimes EXPORT LLVMRuntimes)

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. Duncan pointed out eel.is/c++draft/class.init#class.base.init-13, which appears to claim that initialization ends with the execution of the constructor, excluding temporary destructors. > (13) In a non-delegating constructor, initialization proceeds in the >

[PATCH] D61615: [COFF] Use COFF stubs for extern_weak functions

rnk created this revision. rnk added reviewers: smeenai, mstorsjo. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. A COFF stub indirects the reference to a symbol through memory. A .refptr.$sym global variable pointer is created to refer to $sym. Typically

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

trixirt updated this revision to Diff 198352. trixirt retitled this revision from "[clang-tidy] misc-header-guard : a simple version of llvm-header-guard" to "[clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard". trixirt added a comment. Move from misc to bugprone

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

echristo added reviewers: saugustine, cmatthews. echristo added a comment. Adding Sterling and Chris to this to take a look at the new layout :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files:

r360089 - [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice

Author: leonardchan Date: Mon May 6 15:09:12 2019 New Revision: 360089 URL: http://llvm.org/viewvc/llvm-project?rev=360089=rev Log: [Sema] Fix for P41774 where `ExpectNoDerefChunk` is assigned twice Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); dblaikie wrote: > Pointed out in

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed

r360086 - Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Author: rupprecht Date: Mon May 6 14:55:05 2019 New Revision: 360086 URL: http://llvm.org/viewvc/llvm-project?rev=360086=rev Log: Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)" This reverts r357452 (git commit

[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

NoQ updated this revision to Diff 198342. NoQ added a comment. No, this is all wrong. We shouldn't unwrap to the parent stack frame here. We should end up exactly in the location context in which the call has happened. But we should still unwrap the block invocation context, as an exception,

r360084 - PR41183: Don't emit strict-prototypes warning for an implicit function

Author: jyknight Date: Mon May 6 14:37:59 2019 New Revision: 360084 URL: http://llvm.org/viewvc/llvm-project?rev=360084=rev Log: PR41183: Don't emit strict-prototypes warning for an implicit function declaration. It should emit _only_ an implicit-function-declaration warning, not both of them.

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360084: PR41183: Dont emit strict-prototypes warning for an implicit function (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D59711?vs=191924=198341#toc

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > We also need to mark this off in the status. I can do that in D58879 > or create a separate patch. Good catch! Either is fine with me but I bet a separate patch would be more appropriate. Repository: rCXX libc++ CHANGES

r360081 - [MinGW] Use SEH by default on AArch64

Author: mstorsjo Date: Mon May 6 14:19:01 2019 New Revision: 360081 URL: http://llvm.org/viewvc/llvm-project?rev=360081=rev Log: [MinGW] Use SEH by default on AArch64 The implementation of SEH is pretty mature at this point. Differential Revision: https://reviews.llvm.org/D61591 Modified:

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL360081: [MinGW] Use SEH by default on AArch64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r360082 - [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

Author: mstorsjo Date: Mon May 6 14:19:07 2019 New Revision: 360082 URL: http://llvm.org/viewvc/llvm-project?rev=360082=rev Log: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW In MinGW, setjmp isn't expanded as a builtin in the compiler (like it is for MSVC), but manually hooked

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rC360082: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); aaron.ballman wrote: > koldaniel wrote: > > aaron.ballman wrote: > > > More

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:85-87 +if (TL.getQualifierLoc()) + if (!TraverseNestedNameSpecifierLoc(TL.getQualifierLoc())) +return false; You can combine these.

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith reopened this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:373-374 + ExplicitSpecifier ES, FunctionDecl *New) { + if (!ES.getExpr() ||

Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Thank you! On Mon, May 6, 2019 at 11:05 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 13:07:20 2019 > New Revision: 360073 > > URL: http://llvm.org/viewvc/llvm-project?rev=360073=rev > Log: > [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with >

r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Author: abataev Date: Mon May 6 13:07:20 2019 New Revision: 360073 URL: http://llvm.org/viewvc/llvm-project?rev=360073=rev Log: [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none). If the combined directive has default(none) clause and has clauses for inner directive

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

dblaikie added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); Pointed out in PR41774 there's a dead store to ExpectNoDerefChunk here. Should line

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman added a comment. In D60507#1491095 , @ztamas wrote: > Ping. > Is it good to go or is there anything else I need to include in this patch? Sorry for the delay, I was gone for WG14 meetings last week, which made reviewing more involved

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); koldaniel wrote: > aaron.ballman wrote: > > More tests that I figured out: > > ``` > > namespace { > > extern void f();

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61260/new/ https://reviews.llvm.org/D61260 ___ cfe-commits mailing

r360063 - [OpenMP][Clang] Support for target math functions

Author: gbercea Date: Mon May 6 11:19:15 2019 New Revision: 360063 URL: http://llvm.org/viewvc/llvm-project?rev=360063=rev Log: [OpenMP][Clang] Support for target math functions Summary: In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain,

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360063: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198311=198314#toc Repository: rC Clang

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198311. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#1491570 , @JonasToth wrote: > Hi trixirt and thanks for the patch! > > I would rather like to generalize the llvm check to allow different styles > and then alias the general version with different configurations.

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/ https://reviews.llvm.org/D61592 ___ cfe-commits mailing

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61591/new/ https://reviews.llvm.org/D61591 ___ cfe-commits mailing

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61601 Files:

Re: r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Thank you! On Mon, May 6, 2019 at 8:46 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 10:49:22 2019 > New Revision: 360061 > > URL: http://llvm.org/viewvc/llvm-project?rev=360061=rev > Log: > [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Author: abataev Date: Mon May 6 10:49:22 2019 New Revision: 360061 URL: http://llvm.org/viewvc/llvm-project?rev=360061=rev Log: [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses. If the `default(none)` was specified for the construct, we might miss diagnostic for the

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; gtbercea wrote: > ABataev wrote: > >

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; ABataev wrote: > I see that the same guard is used >

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. Thanks for everyone's responses so far. At this point, I'm going to follow the uncontroversial suggestions from @lebedev.ri: create a `struct PragmaIntroducer`, and split the OpenMP work into a second patch. That will hopefully make it easier for @rsmith or others to

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper updated this revision to Diff 198303. craig.topper added a comment. Get rid of clang stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 Files: llvm/lib/Target/X86/X86FixupLEAs.cpp llvm/test/CodeGen/X86/GlobalISel/add-ext.ll

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; I see that the same guard is used `lib/Headers/__clang_cuda_device_functions.h`, but for different set of functions. Is this

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198301. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:52 +struct HoverInfo { + LocatedSymbol Sym; + /// Name of the context containing the symbol. sammccall wrote: > I'm not sure about reuse of LocatedSymbol - do we want to commit to

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Hey, still motivated to land this, but definitely don't want to break any existing workflows. In particular, > but this afaict (unless I'm missing something :) will also affect the > workflow where the provided range is 0-length range I'm curious how to do this -

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:71 + // start and end the code block with more. + unsigned MaxBackticks = 0; + for (llvm::StringRef Left = Input;;) { sammccall wrote: > ``` > backticks = "```" >

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov updated this revision to Diff 198300. ilya-biryukov added a comment. - Remove hover-related bits, they will go into a separate revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58547/new/ https://reviews.llvm.org/D58547 Files:

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov updated this revision to Diff 198298. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Use isWhitespace from CharInfo. - Add a comment for merging text blocks together. - Remove assertion that inline code block does not contain newlines. - Simplify

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1490358 , @rupprecht wrote: > I didn't follow the technical details, but I don't see anything wrong with > moving forward on this patch. I think this seems like an interesting idea > worth experimenting with. > > In

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

zoecarver added a comment. Herald added subscribers: libcxx-commits, ldionne. We also need to mark this off in the status. I can do that in D58879 or create a separate patch. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. Not sure. I'll fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198295. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith Do you have the chance to review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

Re: [PATCH] D61464: [RiscV] Typo in register aliases

I'll get it. On Sat, May 4, 2019 at 3:47 AM John LLVM via Phabricator wrote: > > JohnLLVM added a comment. > > What should I do now? I do not have rights to commit. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D61464/new/ > > https://reviews.llvm.org/D61464 > > >

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { gtbercea wrote: > ABataev wrote: > > Why we have

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { ABataev

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

sammccall added a comment. As discussed, it probably makes sense to split into two patches, adding this abstraction and using it. (All together is also fine but should have the tests for the new behavior, which probably means renderForTests() too) Generally looks good. I think we'll run into

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Sorry for the delay, I'll make sure to take a close look at the change tomorrow. As mentioned in offline discussions, doing this through `clang-format` seems like the right approach. At the same the markers we put into the files to drive formatting seem fragile,

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1491979 , @jdenny wrote: > In D61509#1491898 , @ABataev wrote: > > > Again, I don't see a single point why would we need this. I don't think > > there is a big difference between

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { Why we have this guard here? It does not work for

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491898 , @ABataev wrote: > Again, I don't see a single point why would we need this. I don't think there > is a big difference between the location of pragma keyword and `omp` keyword. @lebedev.ri : You said you're

r360048 - [CodeComplete] Update python tests after r360042

Author: ibiryukov Date: Mon May 6 07:56:24 2019 New Revision: 360048 URL: http://llvm.org/viewvc/llvm-project?rev=360048=rev Log: [CodeComplete] Update python tests after r360042 Modified: cfe/trunk/bindings/python/tests/cindex/test_code_completion.py Modified:

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdServer.cpp:264 Callback> CB) { - auto Action = [Pos](Path File, std::string NewName, + auto Action =

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; gtbercea wrote: > ABataev

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. Layering and such looks good. This should compose well with D58547 Comment at: clang-tools-extra/clangd/XRefs.h:52 +struct HoverInfo { + LocatedSymbol Sym; + /// Name of the context containing the symbol.

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1491397 , @jdenny wrote: > In D61509#1491209 , @ABataev wrote: > > > In D61509#1491204 , @lebedev.ri > > wrote: > > > > > In

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61596 Files:

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491537 , @lebedev.ri wrote: > In D61509#1491397 , @jdenny wrote: > > > In D61509#1491209 , @ABataev wrote: > > > > > In D61509#1491204

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileCheck %s --match-full-lines --strict-whitespace +// CHECK: zzap

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

This revision was automatically updated to reflect the committed changes. Closed by commit rL360044: Fix compilation warnings when compiling with GCC 7.3 (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61046?vs=196655=198265#toc Repository: rL LLVM

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked an inline comment as done. aganea added a comment. In D61046#1486850 , @rnk wrote: > The only remaining change I find questionable is the R600 backend change creduce'd and reported here:

[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

This revision was automatically updated to reflect the committed changes. Closed by commit rL360042: [CodeComplete] Add a trailing semicolons to some pattern completions (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, mgrang, ssijaric. Herald added subscribers: kristina, kristof.beyls, javed.absar. Herald added a project: clang. In MinGW, setjmp isn't expanded as a builtin in the compiler (like it is for MSVC), but manually hooked up as

r360042 - [CodeComplete] Add a trailing semicolons to some pattern completions

Author: ibiryukov Date: Mon May 6 06:18:00 2019 New Revision: 360042 URL: http://llvm.org/viewvc/llvm-project?rev=360042=rev Log: [CodeComplete] Add a trailing semicolons to some pattern completions Summary: Where semicolon is required in any case. Here's a list of completions that now have a

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, mgrang, ssijaric. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. The implementation of SEH is pretty mature at this point. Repository: rC Clang https://reviews.llvm.org/D61591

[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

ilya-biryukov updated this revision to Diff 198254. ilya-biryukov added a comment. - Add tests for 'continue;' and 'break;' completions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61589/new/ https://reviews.llvm.org/D61589 Files:

  1   2   >