[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

phosek created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses the issue introduced in r361432 where we would only try effective triple but not the normalized one as we do for other runtimes. Repository: rC Clang https://reviews.llvm.org/D6

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas updated this revision to Diff 200870. cdevadas added a comment. Herald added subscribers: nhaehnle, jvesely. Moved the test to CodeGenCUDA directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62244/new/ https://reviews.llvm.org/D62244 Files: lib/CodeGen/TargetInfo.cpp

[clang-tools-extra] r361457 - Remove unnecessary const&s; NFC

Author: gbiv Date: Wed May 22 19:52:39 2019 New Revision: 361457 URL: http://llvm.org/viewvc/llvm-project?rev=361457&view=rev Log: Remove unnecessary const&s; NFC It's uncommon to rely on temporary lifetime extension when having a regular, non-`const&` value behaves identically. Since `Twine::str

[PATCH] D62282: [X86] Add ENQCMD intrinsics.

tianqing created this revision. tianqing added reviewers: craig.topper, RKSimon, LuoYuanke, spatel. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. For more details about these instructions, please refer to the latest ISE document: https://software.intel.com/en-us/d

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

george.burgess.iv added a comment. > neonfp isn't passed as a feature in the first place; there's a separate API > setFPMath which is used for that. We translate it into a target feature for > the sake of the backend. So I'm not sure what you're proposing. The idea would be for `initFeatureMap`

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

george.burgess.iv updated this revision to Diff 200862. george.burgess.iv added a comment. Address comments -- thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61750/new/ https://reviews.llvm.org/D61750 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h cla

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai updated this revision to Diff 200864. vsapsai added a comment. - Address review comments: don't introduce `HasBeenMapped` and rely on `CacheLookup.MappedName`. Changes are rebased, so diff between diffs can be noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ htt

[PATCH] D52132: [CMake] Use cannonical triples for Fuchsia runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL361456: [CMake][Fuchsia] Use cannonical triples for runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:821 CurDir = nullptr; + bool HasBeenMapped = false; arphaman wrote: > NIT: It looks like `HasBeenMapped` should be always set when > `CacheL

r361456 - [CMake][Fuchsia] Use cannonical triples for runtimes

Author: phosek Date: Wed May 22 19:35:12 2019 New Revision: 361456 URL: http://llvm.org/viewvc/llvm-project?rev=361456&view=rev Log: [CMake][Fuchsia] Use cannonical triples for runtimes This ensures that whether the user uses short or cannonical version of the triple, Clang will still find the ru

[PATCH] D62279: Use LTO capable linker

winksaville abandoned this revision. winksaville added a comment. Chris, I thought you had added libcxxabi in LLVM_ENABLE_RUNTIMES, but you hadn't so abandoning and trying again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/ https://rev

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan updated this revision to Diff 200860. leonardchan marked an inline comment as done. leonardchan edited the summary of this revision. Herald added subscribers: llvm-commits, dexonsmith, steven_wu, kbarton, hiraditya, eraman, nemanjai, mehdi_amini. Herald added a project: LLVM. Reposito

[PATCH] D62279: Use LTO capable linker

winksaville created this revision. winksaville added a reviewer: beanz. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini, mgorny. Herald added a project: clang. In DistributionExample.cmake be sure we use a LTO capable linker, the easiest to choose is lld. Repository:

[PATCH] D62094: [analyzer] List checker/plugin options in 3 categories: released, alpha, developer

Szelethus updated this revision to Diff 200856. Szelethus added a comment. Removed the beta phase as discussed on the mailing list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62094/new/ https://reviews.llvm.org/D62094 Files: include/clang/Driver/CC1Options.td include/clang/Stati

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

Szelethus updated this revision to Diff 200855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62093/new/ https://reviews.llvm.org/D62093 Files: include/clang/Driver/CC1Options.td include/clang/StaticAnalyzer/Checkers/CheckerBase.td include/clang/StaticAnalyzer/Core/AnalyzerOptions.

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

Szelethus updated this revision to Diff 200854. Szelethus added a comment. Removed the beta phase as discussed on the mailing list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62093/new/ https://reviews.llvm.org/D62093 Files: include/clang/Driver/CC1Options.td include/clang/Stati

[PATCH] D62092: [analyzer] Create the beta package that is more stable than alpha, move unix.cstring.OutOfBounds there

Szelethus abandoned this revision. Szelethus added a comment. Let's put the idea of the beta package to rest for now. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62092/new/ https://reviews.llvm.org/D62092 ___ cfe-c

[PATCH] D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags

thakis created this revision. thakis added a reviewer: rnk. Herald added a project: LLVM. OptTable treats arguments starting with / that aren't a known option as filenames. This means lld-link's and clang-cl's typo correction for unknown flags didn't do spell checking for misspelled options that s

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

winksaville added a comment. > I actually really appreciate you trying this out and reporting back with such > detailed feedback on your experience. Thank you for your patience, and I'm > sorry if I'm being a bit of a pain. Been a good learning experince for me, both LLVM and cmake, I hope you

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:527-530 +// developer checkers even in the alpha output. For example, +// alpha.cplusplus.IteratorModeling is a modeling checker, hence

[PATCH] D62093: [analyzer] List checkers in 3 categories: released, alpha, developer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:526 + for (const auto &Checker : Checkers) { +// The order of this if branches is significant,

[PATCH] D62271: [Driver] Fix -working-directory issues

Bigcheese created this revision. Bigcheese added reviewers: dexonsmith, arphaman, jkorous. Herald added a project: clang. Currently the `-working-directory` option does not actually impact the working directory for all of the clang driver, it only impacts how files are looked up to make sure they

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200828. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Types.def clang/include/clang/Fronten

[PATCH] D62167: CodeView - add static data members to global variable debug info.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU); akhuang wrote: > @dblaikie I

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

krytarowski resigned from this revision. krytarowski added a comment. Herald added a subscriber: krytarowski. It is probably fine.. but I will defer review to lit/libc++ maintainers. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.l

[PATCH] D62270: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1

rnk created this revision. rnk added a reviewer: hans. Herald added a subscriber: jdoerfert. Herald added a project: clang. New -cc1 arguments, such as -faddrsig, have started appearing after the input name. I personally find it convenient for the input to be the last argument to the compile comma

[PATCH] D62202: Work around a Visual C++ bug

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. SGTM - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62202/new/ https://reviews.llvm.org/D62202 ___

r361439 - Fix r361428 for Windows buildbots/mangling

Author: dblaikie Date: Wed May 22 14:58:17 2019 New Revision: 361439 URL: http://llvm.org/viewvc/llvm-project?rev=361439&view=rev Log: Fix r361428 for Windows buildbots/mangling Modified: cfe/trunk/test/Modules/enum-codegen.cpp Modified: cfe/trunk/test/Modules/enum-codegen.cpp URL: http://l

Re: r361428 - Modules: Code generation of enum constants for merged enum definitions

Ah, sure - thanks for the heads up! Fixed in r361439 On Wed, May 22, 2019 at 2:49 PM Galina Kistanova wrote: > Hello David, > > This commit broke the test on the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17793 > Please have a look? > . . . > Fai

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

rsmith marked 2 inline comments as done. rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4321 + isCXXDeclarationSpecifier(ITC_Never, TPResult::True) != + TPResult::True) || +(!getLangOpts().CPlusPlus && !isDeclaratio

Re: r361428 - Modules: Code generation of enum constants for merged enum definitions

Hello David, This commit broke the test on the builder: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17793 Please have a look? . . . Failing Tests (1): Clang :: Modules/enum-codegen.cpp The builder was already red and did not send any notifications. Thanks

r361438 - Fix new enum-codegen.cpp test

Author: rnk Date: Wed May 22 14:52:12 2019 New Revision: 361438 URL: http://llvm.org/viewvc/llvm-project?rev=361438&view=rev Log: Fix new enum-codegen.cpp test Modified: cfe/trunk/test/Modules/enum-codegen.cpp Modified: cfe/trunk/test/Modules/enum-codegen.cpp URL: http://llvm.org/viewvc/llv

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman updated this revision to Diff 200824. mwyman added a comment. Syncing code with HEAD CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 Files: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp clang-tools-extra/clang-tidy/goo

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

arphaman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:821 CurDir = nullptr; + bool HasBeenMapped = false; NIT: It looks like `HasBeenMapped` should be always set when `CacheLookup.MappedName` is set as well. Would it make sense to chec

r361433 - Add some notes on immutability and faithfulness to the internals manual.

Author: rsmith Date: Wed May 22 14:20:09 2019 New Revision: 361433 URL: http://llvm.org/viewvc/llvm-project?rev=361433&view=rev Log: Add some notes on immutability and faithfulness to the internals manual. Modified: cfe/trunk/docs/InternalsManual.rst Modified: cfe/trunk/docs/InternalsManual.

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 200818. gtbercea added a comment. - Include sema check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

This revision was automatically updated to reflect the committed changes. Closed by commit rC361432: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59168?vs=197241&id=200817#toc Rep

r361432 - [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

Author: phosek Date: Wed May 22 14:08:33 2019 New Revision: 361432 URL: http://llvm.org/viewvc/llvm-project?rev=361432&view=rev Log: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++ This change is a consequence of the discussion in "RFC: Place libs in Clang-dedi

[libunwind] r361432 - [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

Author: phosek Date: Wed May 22 14:08:33 2019 New Revision: 361432 URL: http://llvm.org/viewvc/llvm-project?rev=361432&view=rev Log: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++ This change is a consequence of the discussion in "RFC: Place libs in Clang-dedi

RE: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

It does not like some part of that instantiation, I am not sure which one yet. Let’s see what I can do about it. -Petr From: Yitzhak Mandelbaum [mailto:yitzh...@google.com] Sent: Wednesday, May 22, 2019 1:37 PM To: reviews+d61774+public+f458bb6144ae8...@reviews.llvm.org Cc: Ilya Biryukov ; Penzi

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! You should wait for Aaron's approval, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 _

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

beanz added a comment. D62269 should fix the missing dependency on `gtest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62215/new/ https://reviews.llvm.org/D62215 _

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

beanz added a comment. In D62215#1512543 , @winksaville wrote: > With this error I guessed that I needed to build `LLVMgold.so`, but then I > also determined > I needed to link everything with `ld.gold` to complete the build process, > which is why I >

Re: [PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

I'm confused by the error given that getStatementsRange is a function name. I don't have Visual Studio -- can you find a fix and send a patch? I wonder if taking the address explicitly is enough? Or, if you know how to trigger this error in clang or gcc, I can fix it myself. On Wed, May 22, 2019

[PATCH] D62268: Add back --sysroot support for darwin header search.

jyknight added a comment. In D62268#1512672 , @ldionne wrote: > This LGTM. > > When I did the refactor, all the code was only using `-isysroot` (and never > accessing `--sysroot`), so I thought only `-isysroot` was relevant on Darwin. > Seems like I was

[PATCH] D62268: Add back --sysroot support for darwin header search.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361429: Add back --sysroot support for darwin header search. (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D62268?vs=200813&id=200815#toc Repository: rC Cla

r361429 - Add back --sysroot support for darwin header search.

Author: jyknight Date: Wed May 22 13:39:51 2019 New Revision: 361429 URL: http://llvm.org/viewvc/llvm-project?rev=361429&view=rev Log: Add back --sysroot support for darwin header search. Before e97b5f5cf37e ([clang][Darwin] Refactor header search path logic into the driver), both --sysroot and -

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

Typz accepted this revision. Typz added a comment. This revision is now accepted and ready to land. Actually, looking at all the other options, the same is true for all other macro kind of macros (NamespaceMacros...). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D62268: Add back --sysroot support for darwin header search.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM. When I did the refactor, all the code was only using `-isysroot` (and never accessing `--sysroot`), so I thought only `-isysroot` was relevant on Darwin. Seems like I was wrong.

r361428 - Modules: Code generation of enum constants for merged enum definitions

Author: dblaikie Date: Wed May 22 13:36:06 2019 New Revision: 361428 URL: http://llvm.org/viewvc/llvm-project?rev=361428&view=rev Log: Modules: Code generation of enum constants for merged enum definitions Found in a bootstrap of LLVM with implicit modules, resulting in a deadlock of some Orc uni

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

Typz added a comment. Herald added a project: clang. Regarding variable/setting names, one issue I see is that these macros are not really type //names// IMO : the macro name is just part of the type (like a template), and its invocation is a type declaration. So maybe renaming to `Typedecl` or

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

penzn added inline comments. Comment at: cfe/trunk/lib/Tooling/Refactoring/RangeSelector.cpp:229 +RangeSelector tooling::statements(StringRef ID) { + return RelativeSelector(ID); +} Sorry for posting here, haven't gotten my bugzilla access yet (requested though

[PATCH] D62268: Add back --sysroot support for darwin header search.

jyknight created this revision. jyknight added reviewers: ldionne, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Before e97b5f5cf37e ([clang][Darwin] Refactor header search path logic i

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512601 , @Meinersbur wrote: > > I would think different people would want to review different pragmas, so > > separate patches would be better, but I'm happy to be corrected as I > > haven't explored who owns what here.

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 200808. slavapestov marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clan

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/cmake/modules/AddClang.cmake clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/CMakeLists.txt clang/lib/DirectoryWat

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 200810. jkorous marked an inline comment as done. jkorous added a comment. Remove busy waits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/cmake/modules/AddClang.cmake clang/include/clang

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 9 inline comments as done. jkorous added a comment. Thanks for taking a look Kadir! After yesterday's discussion with Dmitri I removed all those busy waits. Seems like the code is not much more complex now. I am going to update the diff and off to fixing the tests.

r361424 - Part of P1091R3: permit structured bindings to be declared 'static' and

Author: rsmith Date: Wed May 22 12:52:55 2019 New Revision: 361424 URL: http://llvm.org/viewvc/llvm-project?rev=361424&view=rev Log: Part of P1091R3: permit structured bindings to be declared 'static' and 'thread_local' in C++20. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Meinersbur added a comment. In D61509#1512330 , @jdenny wrote: > In D61509#1512321 , @Meinersbur > wrote: > > > In D61509#1512311 , @jdenny wrote: > > > > > 2. I too think i

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512570 , @aaron.ballman wrote: > These changes LGTM! Thanks, and thanks to everyone who chimed in. > I'd say give it a few days in case other reviewers would like to chime in. Sure. Maybe this weekend or so. CHANG

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D61509#1512556 , @jdenny wrote: > The overall vote seems to be that this patch is ready to push, and we/I > should work on other pragm

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 200805. plotfi added a comment. adding static/extern tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/includ

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361418: [clang-tidy] Add support for writing a check as a Transformer rewrite rule. (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D61386?vs=200802&id=200804#toc

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] r361418 - [clang-tidy] Add support for writing a check as a Transformer rewrite rule.

Author: ymandel Date: Wed May 22 11:56:18 2019 New Revision: 361418 URL: http://llvm.org/viewvc/llvm-project?rev=361418&view=rev Log: [clang-tidy] Add support for writing a check as a Transformer rewrite rule. This revision introduces an adaptor from Transformer's rewrite rules (`clang::tooling::

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512488 , @aaron.ballman wrote: > In D61509#1512090 , @jdenny wrote: > > > Now that D61643 is pushed, we're back to > > this patch. My recollect

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Anastasia wrote: > Ok, I thought the earlier request was not to add undocumented attributes with > the spelling? >

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

winksaville added a comment. In D62215#1510933 , @beanz wrote: > Adding "libcxxabi" to `LLVM_ENABLE_RUNTIMES` is fine, but the other changes > to the DistributionExample are only needed because you chose to use gold, > which is a configuration-specific d

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 200802. ymandel removed a subscriber: dexonsmith. ymandel added a comment. Replace previous diff which had the wrong base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D6138

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:143 LANGOPT(RelaxedTemplateTemplateArgs, 1, 0, "C++17 relaxed matching of template template arguments") +LANGOPT(GeneralOpsOnly, 1, 0, "Whether to diagnose the use of floating-point or vector

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

morehouse added inline comments. Comment at: compiler-rt/lib/gwp_asan/mutex.h:22 + constexpr Mutex() = default; + ~Mutex() = default; + // Lock the mutex. We should probably delete copy constructor and operator= Comment at: compiler-rt/lib/g

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

aaron.ballman added a comment. In D61509#1512090 , @jdenny wrote: > Now that D61643 is pushed, we're back to > this patch. My recollection is there are two remaining issues: > > 1. Should we store both the `#pragma` loca

[PATCH] D62160: [LibTooling] Update Stencil to use RangeSelector

This revision was automatically updated to reflect the committed changes. Closed by commit rL361413: [LibTooling] Update Stencil to use RangeSelector (authored by ymandel, committed by ). Changed prior to commit: https://reviews.llvm.org/D62160?vs=200794&id=200795#toc Repository: rL LLVM CH

[PATCH] D62160: [LibTooling] Update Stencil to use RangeSelector

ymandel updated this revision to Diff 200794. ymandel added a comment. Rebase onto HEAD, fixing previous diff which accidentally included other commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62160/new/ https://reviews.llvm.org/D62160 File

r361413 - [LibTooling] Update Stencil to use RangeSelector

Author: ymandel Date: Wed May 22 11:03:00 2019 New Revision: 361413 URL: http://llvm.org/viewvc/llvm-project?rev=361413&view=rev Log: [LibTooling] Update Stencil to use RangeSelector Add support for creating a `StencilPart` from any `RangeSelector`, which broadens the scope of `Stencil`. Corresp

r361411 - Fixed a -Wunused-variable warning when assertions are disabled

Author: gribozavr Date: Wed May 22 10:45:24 2019 New Revision: 361411 URL: http://llvm.org/viewvc/llvm-project?rev=361411&view=rev Log: Fixed a -Wunused-variable warning when assertions are disabled Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.c

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

phosek updated this revision to Diff 200784. phosek retitled this revision from "[Clang][NewPM] Disable tests that are broken under new PM" to "[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3". phosek edited the summary of this revision. Repository: rC Clang CHAN

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

kadircet added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:48 + return llvm::None; +} else { + DirectoryWatcher::Event Front = Events.front(); nit: get rid of the else Comment at: clang

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956 +// If using unified memory, no need to do the mappings. +if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport()) + return; -

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Ok, I thought the earlier request was not to add undocumented attributes with the spelling? Also did `__kerne

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 200782. gtbercea added a comment. - Fix function call. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h Inde

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Herald added a project: clang. I don't actually want to change anything, but remove this from your review queues until I have an idea how often the warning fires and how many false positives we have. Repository: rC

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a reviewer: ed. aaronpuchert added a comment. Another ping. I've tried to add the original authors as reviewers, but both warnings are several years old and you might not remember. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a comment. Ping. I'm sorry that the change turned out so big, but note that it doesn't change the behavior of any non-cc1 flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 __

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512321 , @Meinersbur wrote: > In D61509#1512311 , @jdenny wrote: > > > 2. I too think it likely makes sense to adjust them all eventually. But do > > people think it's important

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Herald added a project: clang. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Meinersbur added a comment. In D61509#1512311 , @jdenny wrote: > 2. I too think it likely makes sense to adjust them all eventually. But do > people think it's important to write patches adjusting all pragmas before > pushing the adjustment for any of t

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. The patch goal is indeed to indent the content of namespace-macro blocks like the content of any 'regular' namespace. So it should look like the content of a namespace, possibly depending on the choose style options. To sumarize, here is a detailed summary of the observabl

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512294 , @ABataev wrote: > In D61509#1512293 , @Meinersbur > wrote: > > > 1. Is there a diagnostic that would point to the `omp` token? As much as I > > like complete info (such

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 200775. ztamas added a comment. Herald added a subscriber: mgorny. Link burprone module to cert module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62192/new/ https://reviews.llvm.org/D62192 Files: clang-too

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan marked 4 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since accordi

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

ABataev added a comment. In D61509#1512293 , @Meinersbur wrote: > 1. Is there a diagnostic that would point to the `omp` token? As much as I > like complete info (such as SourceLoc of semicolons), I cannot think of a use > case for it. > 2. I would like

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Meinersbur added a comment. 1. Is there a diagnostic that would point to the `omp` token? As much as I like complete info (such as SourceLoc of semicolons), I cannot think of a use case for it. 2. I would like to see all of them all adjusted. There is an immediate improvement in that improves t

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4321 + isCXXDeclarationSpecifier(ITC_Never, TPResult::True) != + TPResult::True) || +(!getLangOpts().CPlusPlus && !isDeclarationSpecifier(ITC_Yes))) { -

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 200767. Rakete marked 11 inline comments as done. Rakete added a comment. - rebased - addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D5384

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

davezarzycki added a comment. Fixed: r361399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.llvm.org/D62174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D62214: Remove extra if case.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361400: Combine two if cases because the second one is never reached. (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r361400 - Combine two if cases because the second one is never reached.

Author: akhuang Date: Wed May 22 08:48:59 2019 New Revision: 361400 URL: http://llvm.org/viewvc/llvm-project?rev=361400&view=rev Log: Combine two if cases because the second one is never reached. Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D62214 Modif

  1   2   >