[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

This revision was automatically updated to reflect the committed changes. Closed by commit rC361709: [Driver] Update handling of c++ and runtime directories (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62442?vs=201432=201433#toc Repository: rC

r361709 - [Driver] Update handling of c++ and runtime directories

Author: phosek Date: Sat May 25 20:39:07 2019 New Revision: 361709 URL: http://llvm.org/viewvc/llvm-project?rev=361709=rev Log: [Driver] Update handling of c++ and runtime directories This is a follow up to r361432 and r361504 which addresses issues introduced by those changes. Specifically, it

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek added a comment. In D62442#1517183 , @mcgrathr wrote: > lgtm contingent on verifying intended behavior changes and adding comments. > The factoring suggestion for the triple,triple searching is preferred but at > your discretion, though I'd

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek updated this revision to Diff 201432. phosek marked 8 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62442/new/ https://reviews.llvm.org/D62442 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp

[PATCH] D62459: [clangd] Serialization support for RelationSlab

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This builds on D59407 to provide YAML and RIFF serialization support. Repository:

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

thakis added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) The library is already up here. Why do we need it twice? Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D59407: [clangd] Add RelationSlab

nridge added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.cpp:19 +llvm::iterator_range +RelationSlab::lookup(const SymbolID , + index::SymbolRole Predicate) const { kadircet wrote: > I would suggest adding another

[PATCH] D59407: [clangd] Add RelationSlab

nridge updated this revision to Diff 201427. nridge marked 19 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 Files:

[PATCH] D62457: Frontend: Create basic CompilerInstanceBuilder

dexonsmith created this revision. dexonsmith added a reviewer: rsmith. dexonsmith added a child revision: D62458: Frontend: Add CompilerInvocation and DiagnosticsEngine to the builder. This sketches out the beginning of a `CompilerInstanceBuilder`. For now it just handles PCHContainerOps and

[PATCH] D62458: Frontend: Add CompilerInvocation and DiagnosticsEngine to the builder

dexonsmith created this revision. dexonsmith added a reviewer: rsmith. Herald added subscribers: kadircet, arphaman, jkorous. dexonsmith added a parent revision: D62457: Frontend: Create basic CompilerInstanceBuilder. Add CompilerInvocation and DiagnosticsEngine to the new builder, replacing a

r361708 - Add missing newline at end of file

Author: dexonsmith Date: Sat May 25 15:38:02 2019 New Revision: 361708 URL: http://llvm.org/viewvc/llvm-project?rev=361708=rev Log: Add missing newline at end of file Modified: cfe/trunk/unittests/Tooling/Syntax/TokensTest.cpp Modified: cfe/trunk/unittests/Tooling/Syntax/TokensTest.cpp URL:

Re: r361340 - [Analysis] Link library dependencies to Analysis plugins

I've submitted a patch to fix this, https://reviews.llvm.org/D62445. Without it, non of the bots can build/test any plugins. On Fri, May 24, 2019 at 5:47 PM Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I reverted the patch in r361685 to make the bot green again. > > >

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

winksaville abandoned this revision. winksaville added a comment. Rather than creating LLVMgold.so as this change does, @beanz suggested we use a known LTO capable linker, `lld`. See D62279 .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane updated this revision to Diff 201404. erichkeane marked 2 inline comments as done. erichkeane added a comment. Reread @rsmith's comments and surrounding code and found what I believe is the correct answer to these comments :) CHANGES SINCE LAST ACTION

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

markstegeman updated this revision to Diff 201401. markstegeman added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62404/new/ https://reviews.llvm.org/D62404 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang-c/Index.h:202-204 + * The cursor has a declspec(nothrow) exception specification. + */ + CXCursor_ExceptionSpecificationKind_NoThrow, rsmith

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

kristina added a comment. In D61634#1517228 , @xbolva00 wrote: > I have a question about qsort.. If we provide own implementation of qsort and > replace calls to libc's qsort to our qsort, we could fully inline cmp > function then. Ideas? `qsort`

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

xbolva00 added a comment. I have a question about qsort.. If we provide own implementation of qsort and replace calls to libc's qsort to our qsort, we could fully inline cmp function then. Ideas? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

dextero updated this revision to Diff 201395. dextero added a comment. - [clang-format] Change "types" -> "type declarations" in Format.h Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57184/new/ https://reviews.llvm.org/D57184 Files:

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

dextero updated this revision to Diff 201393. dextero marked an inline comment as done. dextero added a comment. - [clang-format] Make documentation a bit clearer - Rebased onto recent master @Typz: thank you for the review! I don't have push access to the repository though. Could you commit

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361691: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support… (authored by ctopper, committed by ). Herald added a subscriber: qcolombet. Changed prior to commit:

[PATCH] D62445: [test] Fix plugin tests

hintonda created this revision. hintonda added reviewers: beanz, phosek, george.karpenkov, NoQ, ahatanak, rjmccall. Herald added subscribers: llvm-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. hintonda edited the summary of this revision. The following changes were required to

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm contingent on verifying intended behavior changes and adding comments. The factoring suggestion for the triple,triple searching is preferred but at your discretion, though I'd