r362358 - PR42104: Support instantiations of lambdas that implicitly capture

2019-06-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jun 2 23:02:10 2019 New Revision: 362358 URL: http://llvm.org/viewvc/llvm-project?rev=362358=rev Log: PR42104: Support instantiations of lambdas that implicitly capture packs. Two changes: * Track odr-use via FunctionParmPackExprs to properly handle dependent

[PATCH] D62471: [clangd] SymbolCollector support for relations

2019-06-02 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 202646. nridge marked 5 inline comments as done. nridge added a comment. Address remaining review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62471/new/ https://reviews.llvm.org/D62471 Files:

[PATCH] D62459: [clangd] Serialization support for RelationSlab

2019-06-02 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. nridge marked 4 inline comments as done. Closed by commit rL362353: [clangd] Serialization support for RelationSlab (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59407: [clangd] Add RelationSlab

2019-06-02 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362352: [clangd] Add RelationSlab (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

2019-06-02 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Great, thanks for the review! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62550/new/ https://reviews.llvm.org/D62550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

2019-06-02 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362348: [coroutines][PR41909] Dont build dependent coroutine statements for generic… (authored by modocache, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r362348 - [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

2019-06-02 Thread Brian Gesiak via cfe-commits
Author: modocache Date: Sun Jun 2 17:47:32 2019 New Revision: 362348 URL: http://llvm.org/viewvc/llvm-project?rev=362348=rev Log: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda Summary: https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in which

r362347 - Revert "[analyzer] exploded-graph-rewriter: An attempt to fix Windows buildbots."

2019-06-02 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sun Jun 2 17:21:00 2019 New Revision: 362347 URL: http://llvm.org/viewvc/llvm-project?rev=362347=rev Log: Revert "[analyzer] exploded-graph-rewriter: An attempt to fix Windows buildbots." This reverts commit r362343. Instead, disable tests on Windows for now.

r362343 - [analyzer] exploded-graph-rewriter: An attempt to fix Windows buildbots.

2019-06-02 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sun Jun 2 16:17:56 2019 New Revision: 362343 URL: http://llvm.org/viewvc/llvm-project?rev=362343=rev Log: [analyzer] exploded-graph-rewriter: An attempt to fix Windows buildbots. Breakage caused by r362340. Modified:

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

2019-06-02 Thread Jian Cai via Phabricator via cfe-commits
jcai19 marked 6 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:31 + Result, + "prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC", + ReplacementText); gribozavr

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

2019-06-02 Thread Jian Cai via Phabricator via cfe-commits
jcai19 updated this revision to Diff 202625. jcai19 marked an inline comment as done. jcai19 added a comment. Remove CHECK-MESSAGES-NOT and update description based on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

2019-06-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362340: [analyzer] exploded-graph-rewriter: Initial commit. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362340 - [analyzer] exploded-graph-rewriter: Initial commit.

2019-06-02 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sun Jun 2 14:40:53 2019 New Revision: 362340 URL: http://llvm.org/viewvc/llvm-project?rev=362340=rev Log: [analyzer] exploded-graph-rewriter: Initial commit. This is a utility to improve readability and generally manipulate GraphViz dumps of the analysis graph. Such

r362336 - Transform lambda expression captures when transforming an expression to

2019-06-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Jun 2 11:53:44 2019 New Revision: 362336 URL: http://llvm.org/viewvc/llvm-project?rev=362336=rev Log: Transform lambda expression captures when transforming an expression to potentially-evaluated. This ensures that every potentially-evaluated expression is built in a

r362334 - Fix bug in r362328 -- append to dependency list instead of overwrite it.

2019-06-02 Thread Don Hinton via cfe-commits
Author: dhinton Date: Sun Jun 2 10:56:26 2019 New Revision: 362334 URL: http://llvm.org/viewvc/llvm-project?rev=362334=rev Log: Fix bug in r362328 -- append to dependency list instead of overwrite it. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL:

r362331 - Add mangling test coverage for non-volatile const member pointers

2019-06-02 Thread Nico Weber via cfe-commits
Author: nico Date: Sun Jun 2 10:23:53 2019 New Revision: 362331 URL: http://llvm.org/viewvc/llvm-project?rev=362331=rev Log: Add mangling test coverage for non-volatile const member pointers Modified: cfe/trunk/test/CodeGenCXX/mangle-ms.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-ms.cpp

r362329 - Add test coverage for __pascal mangling

2019-06-02 Thread Nico Weber via cfe-commits
Author: nico Date: Sun Jun 2 09:47:07 2019 New Revision: 362329 URL: http://llvm.org/viewvc/llvm-project?rev=362329=rev Log: Add test coverage for __pascal mangling Modified: cfe/trunk/test/CodeGenCXX/mangle-windows.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-windows.cpp URL:

[PATCH] D62445: [test] Fix plugin tests

2019-06-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362328: [test] Fix plugin tests (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62445?vs=202573=202605#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

r362328 - [test] Fix plugin tests

2019-06-02 Thread Don Hinton via cfe-commits
Author: dhinton Date: Sun Jun 2 08:53:43 2019 New Revision: 362328 URL: http://llvm.org/viewvc/llvm-project?rev=362328=rev Log: [test] Fix plugin tests Recommit of r361790 that was temporarily reverted in r361793 due to bot breakage. Summary: The following changes were required to fix these

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

2019-06-02 Thread A. Skrobov via Phabricator via cfe-commits
t.yomitch added a comment. Thanks Eric! I don't have commit access; could someone please commit this for me? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62133/new/ https://reviews.llvm.org/D62133 ___ cfe-commits

[PATCH] D59744: Fix i386 ABI "__m64" type bug

2019-06-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. sysv abi is not only for UNIX but most non-Windows ones (BSDs, HAIKU, ...). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list

Re: r362316 - Add script to update OpenMP -ast-dump test expectations, and use it to

2019-06-02 Thread Roman Lebedev via cfe-commits
Thank you! On Sun, Jun 2, 2019 at 6:57 AM Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Sat Jun 1 21:00:38 2019 > New Revision: 362316 > > URL: http://llvm.org/viewvc/llvm-project?rev=362316=rev > Log: > Add script to update OpenMP -ast-dump test expectations, and use it to >