[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

2019-06-28 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63956/new/ https://reviews.llvm.org/D63956

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

2019-06-28 Thread Justin Hibbits via Phabricator via cfe-commits
jhibbits added a comment. Actually, I'm not yet ready to commit this. I want to enforce the 8548 -> e500 processor model before I call this ready. How do I do that with the mcpu? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/

Re: r363429 - PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type

2019-06-28 Thread Hubert Tong via cfe-commits
I don't see how the resolution of Core Issue 2140 changes the status of nullptr_t lvalue-to-rvalue conversion for constexpr evaluation. PR42440 has been opened concerning the change to constexpr evaluation. -- HT On Fri, Jun 14, 2019 at 1:43 PM Richard Smith via cfe-commits <

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

2019-06-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + ahatanak wrote: > rjmccall wrote: > > ahatanak wrote: > > >

[PATCH] D58164: Block+lambda: allow reference capture

2019-06-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Okay. In that case, yeah, it'd be good to get Richard's opinion about the right way to get that information here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58164/new/ https://reviews.llvm.org/D58164

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

2019-06-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Thanks, looks much better. Comment at: include/clang/Sema/Sema.h:2066 bool DeduceVariableDeclarationType(VarDecl *VDecl, bool DirectInit, - Expr *Init); + Expr *Init, bool

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

2019-06-28 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Yep, I'll add one in a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697/new/ https://reviews.llvm.org/D63697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63822: [Driver] Fix style issues of --print-supported-cpus

2019-06-28 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364704: [Driver] Fix style issues of --print-supported-cpus after D63105 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r364704 - [Driver] Fix style issues of --print-supported-cpus after D63105

2019-06-28 Thread Fangrui Song via cfe-commits
Author: maskray Date: Fri Jun 28 18:24:36 2019 New Revision: 364704 URL: http://llvm.org/viewvc/llvm-project?rev=364704=rev Log: [Driver] Fix style issues of --print-supported-cpus after D63105 Reviewed By: ziangwan Differential Revision: https://reviews.llvm.org/D63822 Modified:

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

2019-06-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. You have made a great use of that mistake by me. So that is why everything is so perfect, because it fires, just it should fire later. Thanks you! Repository: rC Clang CHANGES SINCE

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

2019-06-28 Thread Vyacheslav Zakharin via Phabricator via cfe-commits
vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63968: [analyzer] Fix target region invalidation when returning into a ctor initializer.

2019-06-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Enabling pointer escape notification

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Xinliang David Li via cfe-commits
I agree that the test coverage needs to be improved eg better check etc. David On Fri, Jun 28, 2019 at 5:21 PM Chandler Carruth via Phabricator via llvm-commits wrote: > chandlerc added a comment. > > In D63155#1563275 , @xur wrote: > > > In

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. In D63155#1563275 , @xur wrote: > In D63155#1563266 , @chandlerc wrote: > > > I just think we also need to understand why *no other test failed*, and why > > the only test we have for

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

2019-06-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This helps with more efficient use of memset for pattern initialization Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63967 Files:

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Reverted in r364692 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Rong Xu via Phabricator via cfe-commits
xur added a comment. In D63155#1563266 , @chandlerc wrote: > In D63155#1563240 , @leonardchan > wrote: > > > In D63155#1563229 , @xur wrote: > > > > > This patch does not

r364692 - Revert "[clang][NewPM] Fix broken profile test"

2019-06-28 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Jun 28 17:10:22 2019 New Revision: 364692 URL: http://llvm.org/viewvc/llvm-project?rev=364692=rev Log: Revert "[clang][NewPM] Fix broken profile test" This reverts commit ab2c0ed01edfec9a9402d03bdf8633b34b73f3a7. See https://reviews.llvm.org/D63155 Modified:

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Rong Xu via Phabricator via cfe-commits
xur added a comment. they are not doing the exacly the same thing for old pass manager and new pass manger: old pass manger is doing instrumentation, while the new pass manager with this change is NOT. the test is not check instrumentation, (it only check the variables that generates by

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. Understood. I'll revert this patch. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. In D63155#1563240 , @leonardchan wrote: > In D63155#1563229 , @xur wrote: > > > This patch does not make sense to me. > > > > The reason of failing with -fexperimental-new-pass-manager is

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

2019-06-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. Great patch, thanks you! I wanted to make my own `IdentifierInfo` array previously. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060 +public: + const static unsigned

Re: [PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Rong Xu via cfe-commits
they are not doing the exacly the same thing for old pass manager and new pass manger: old pass manger is doing instrumentation, while the new pass manager with this change is NOT. the test is not check instrumentation, (it only check the variables that generates by InstroProfiling pass). In this

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. > I mean, I'm happy for the patch to be reverted, but I still really don't > understand why this fixes the test to work *exactly* the same as w/ the old > pass manager and doesn't break any other tests if it is completely wrong? It > seems like there must be

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D63155#1563229 , @xur wrote: > This patch does not make sense to me. > > The reason of failing with -fexperimental-new-pass-manager is because we > don't do PGO instrumentation at -O0. This is due to the fact that PGO >

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. In D63155#1563229 , @xur wrote: > This patch does not make sense to me. > > The reason of failing with -fexperimental-new-pass-manager is because we > don't do PGO instrumentation at -O0. This is due to the fact that PGO >

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread Rong Xu via Phabricator via cfe-commits
xur added a comment. This patch does not make sense to me. The reason of failing with -fexperimental-new-pass-manager is because we don't do PGO instrumentation at -O0. This is due to the fact that PGO instrumentation/use passes are under PassBuilder::buildPerModuleDefaultPipeline. This patch

[PATCH] D63965: [analyzer] exploded-graph-rewriter: Add support for program point tags.

2019-06-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Good idea! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63965/new/ https://reviews.llvm.org/D63965

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

2019-06-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/return-value-guaranteed.cpp:20 +struct Foo { int Field; }; +bool error(); +bool problem(); NoQ wrote: > `core.builtin.NoReturnFunctions` reacts on this function. You can easily see > it in the

[PATCH] D63965: [analyzer] exploded-graph-rewriter: Add support for program point tags.

2019-06-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Keep it on a separate line for more visibility. F9428700: Screen

[PATCH] D63857: [clang-doc] Add a structured HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 207174. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add a variable to use as a reference to the last item in a vector instead of doing vector.back(). CHANGES SINCE LAST ACTION

[PATCH] D63793: Treat the range of representable values of floating-point types as [-inf, +inf] not as [-max, +max].

2019-06-28 Thread Sanjay Patel via Phabricator via cfe-commits
spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. I don't have much experience with the front-end and have no experience with the sanitizers, but the changes match my understanding for this type of cast/conversion, so LGTM.

[PATCH] D63962: [clang-doc] Fix segfault in comment sorting

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added a reviewer: jakehehrlich. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D63962 Files: clang-tools-extra/clang-doc/Representation.h Index: clang-tools-extra/clang-doc/Representation.h

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

2019-06-28 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 207166. ahatanak marked an inline comment as done. ahatanak added a comment. Add function `Expr::hasNonOverloadPlaceholderType`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62645/new/ https://reviews.llvm.org/D62645

[PATCH] D63155: [clang][NewPM] Fix broken profile test

2019-06-28 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. Rong, can you take a look at this patch? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63155/new/ https://reviews.llvm.org/D63155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63961: [clangd][xpc] pass the LSP value using data instead of string

2019-06-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 207164. arphaman added a comment. Added missing `xpc_release` in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63961/new/ https://reviews.llvm.org/D63961 Files: clang-tools-extra/clangd/unittests/xpc/ConversionTests.cpp

[PATCH] D63961: [clangd][xpc] pass it LSP value using data instead of string

2019-06-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added a reviewer: jkorous. Herald added subscribers: kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. Use XPC's data type instead of string to pass the LSP value from Clangd. This will make it easier to use from sourcekit-lsp

[PATCH] D63857: [clang-doc] Add a structured HTML generator

2019-06-28 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:228 + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H2, "Functions")); + Out.emplace_back(llvm::make_unique(HTMLTag::TAG_DIV)); + for (const auto : Functions) {

[PATCH] D58164: Block+lambda: allow reference capture

2019-06-28 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Currently a block captures a variable (POD or non-POD) by reference if the enclosing lambda captures it by reference and captures by copy if the enclosing lambda captures by copy. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63857: [clang-doc] Add a structured HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 207160. DiegoAstiazaran retitled this revision from "[clang-doc] Structured HTML generator" to "[clang-doc] Add a structured HTML generator". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added

r364690 - [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test

2019-06-28 Thread Jan Korous via cfe-commits
Author: jkorous Date: Fri Jun 28 15:37:31 2019 New Revision: 364690 URL: http://llvm.org/viewvc/llvm-project?rev=364690=rev Log: [clang][test][NFC] Explicitly specify clang ABI in AST Dumper test Clang <= 4 used the pre-C++11 rule about which structures can be passed in registers. Modified:

[PATCH] D63180: [clang-doc] Adds HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't

[PATCH] D63857: [clang-doc] Structured HTML generator

2019-06-28 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. Can you upload `git diff -U10 ` functions so that I can see the code without it being fragmented? It's hard to parse some of the more fragmented stuff here Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:191-194 +static

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

2019-06-28 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + rjmccall wrote: >

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

2019-06-28 Thread Mitch Phillips via Phabricator via cfe-commits
hctim abandoned this revision. hctim added a comment. Abandoned as this was merged in small chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60593/new/ https://reviews.llvm.org/D60593 ___

[PATCH] D63960: [C++20] Add consteval-specifique semantic

2019-06-28 Thread Tyker via Phabricator via cfe-commits
Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - Calls to consteval function and constructors are not evaluated as soon as they are reached. - Add diagnostic for taking address of a consteval function

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

2019-06-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Aha, nice, thanks for adding a description, it is a very good thing to do. Like, every commit should be obvious. Even though i know what's going on, nobody else does, so it's good to explain that this is for modeling certain weird LLVM-specific APIs that intentionally

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 207153. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Change an if statement for a switch statement in `emitInfo(const RecordDecl *D, ...)`, it now handles correctly unexpected info types. Fix spelling in

[PATCH] D63954: Add lifetime categories attributes

2019-06-28 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I actually think we should hard code STL (and maybe some other popular) types into the compiler. I.e.: if an STL type is unannotated and the warnings are turned on, we could look up the default annotations from a table and append them during parsing. This could be

[PATCH] D63857: [clang-doc] Structured HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 207148. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Make DoctypeDecl a constexpr. Early exit in TagNode::Render. Functions of HTMLGenerator now return HTMLNodes instead of adding children to a Node passed by

[PATCH] D63857: [clang-doc] Structured HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:91 +struct HTMLFile { + llvm::SmallString<16> DoctypeDecl{""}; + std::vector> Children; // List of child nodes jakehehrlich wrote: > Does this ever change? If not

[PATCH] D63180: [clang-doc] Adds HTML generator

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't this do the > same thing? Diego, why

[PATCH] D63954: Add lifetime categories attributes

2019-06-28 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. We can try to add the annotations to libcxx (which will still take time), but there are also other standard libraries (libstdc++, MSVC) that can be used with clang. Eventually everybody will have lifetime annotations (of course ;-) ), but in the meantime there seems to be

[PATCH] D63180: [clang-doc] Adds HTML generator

2019-06-28 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. I'm getting confused in all the different patches. I reviewed the HTML generator one like yesterday and was awaiting changes. Doesn't this do the same thing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63180/new/ https://reviews.llvm.org/D63180

[PATCH] D63954: Add lifetime categories attributes

2019-06-28 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. > We explicitly allow to add an annotation after > the definition of the class to allow adding annotations > to external source from by the user, e.g. > > #include > > namespace std { > template > class [[gsl::Owner(T)]] vector; > } Wait, does

[PATCH] D62962: Clang implementation of sizeless types

2019-06-28 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Since this is an extension, it wouldb be great to have a (on-by-default? at > least in -Wall) diagnostic for every instance of usage of this extension. We generally only add warnings for extensions which are not allowed by the standard. It's impossible to define a

[PATCH] D63956: [analyzer] NonnullGlobalConstants: Don't be confused with a _Nonnull attribute.

2019-06-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The NonnullGlobalConstants checker models the rule "it

r364683 - [OPENMP]Improve analysis of implicit captures.

2019-06-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jun 28 13:45:14 2019 New Revision: 364683 URL: http://llvm.org/viewvc/llvm-project?rev=364683=rev Log: [OPENMP]Improve analysis of implicit captures. If the variable is used in the OpenMP region implicitly, we need to check the data-sharing attributes for such variables

[PATCH] D63954: Add lifetime categories attributes

2019-06-28 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre updated this revision to Diff 207138. mgehre added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63954/new/ https://reviews.llvm.org/D63954 Files: clang/include/clang/Basic/Attr.td

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

2019-06-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 207135. Charusso added a comment. - Fix the note as the class name is optional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63915/new/ https://reviews.llvm.org/D63915 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D63954: Add lifetime categories attributes

2019-06-28 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre created this revision. mgehre added a reviewer: gribozavr. Herald added a project: clang. This is the first part of work announced in "[RFC] Adding lifetime analysis to clang" [0], i.e. the addition of the [[gsl::Owner(T)]] and [[gsl::Pointer(T)]] attributes, which will enable

[PATCH] D63915: [analyzer][WIP] ReturnValueChecker: Model the guaranteed boolean return value of function calls

2019-06-28 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 207133. Charusso edited the summary of this revision. Charusso added a comment. - Make it match the class name. (Whoops!) - Reorder the tuple (swap the return value with the call name). - Remove the Projects option. - Remove unnecessary input validation.

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

2019-06-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I don't have any other comments. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62977/new/ https://reviews.llvm.org/D62977 ___

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:366 + + if (I->Namespace[0].RefType == InfoType::IT_namespace) { +auto Parent = llvm::make_unique(); Can you make this a switch statement, doing the appropriate things

r364679 - Revert enabling frame pointer elimination on OpenBSD for now.

2019-06-28 Thread Brad Smith via cfe-commits
Author: brad Date: Fri Jun 28 12:57:51 2019 New Revision: 364679 URL: http://llvm.org/viewvc/llvm-project?rev=364679=rev Log: Revert enabling frame pointer elimination on OpenBSD for now. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/frame-pointer-elim.c

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk added a comment. Thanks for the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63666: [clang-doc] Add templates to HTML generator

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D63857 replaces this revision. Nodes that represent each HTML tag are used instead of templates, it's easier to maintain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63666/new/

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran updated this revision to Diff 207126. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Herald added subscribers: kadircet, arphaman. Add comments. Extract repeated logic into mapDecl function in SerializeTest.cpp Use EmptySID instead of specific

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

2019-06-28 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341 + Parent->USR = ParentUSR; + Parent->ChildNamespaces.emplace_back(I->USR, I->Name, InfoType::IT_namespace); + return {std::unique_ptr{std::move(I)}, juliehockett

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

2019-06-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + ahatanak wrote: > rjmccall wrote: > > It looks like you're

[PATCH] D52847: [clang-doc] Handle anonymous namespaces

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364674: [clang-doc] Handle anonymous namespaces (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r364674 - [clang-doc] Handle anonymous namespaces

2019-06-28 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Fri Jun 28 12:07:56 2019 New Revision: 364674 URL: http://llvm.org/viewvc/llvm-project?rev=364674=rev Log: [clang-doc] Handle anonymous namespaces Improves output for anonymous decls, and updates the '--public' flag to exclude everything under an anonymous namespace.

[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

2019-06-28 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Oh, sorry, I had completely forgotten about that. My contributions to Clang are primarily code review these days; I am not working on that idea. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56366/new/ https://reviews.llvm.org/D56366

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364670: [clang-doc] De-duplicate comments and locations (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r364670 - [clang-doc] De-duplicate comments and locations

2019-06-28 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Fri Jun 28 11:17:58 2019 New Revision: 364670 URL: http://llvm.org/viewvc/llvm-project?rev=364670=rev Log: [clang-doc] De-duplicate comments and locations De-duplicate comments and declaration locations in reduce function. When two files include the same header file,

[PATCH] D63943: ObjC: Squeeze in one more bit for the count of protocols in 'id' types

2019-06-28 Thread Jordan Rose via Phabricator via cfe-commits
jordan_rose created this revision. jordan_rose added reviewers: jfb, doug.gregor, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Someone actually had an Objective-C object pointer type with more than 64 protocols, probably collected through typedefs. Raise the

[PATCH] D63623: [clang-tidy] new check: bugprone-posix-return

2019-06-28 Thread Jian Cai via Phabricator via cfe-commits
jcai19 updated this revision to Diff 207102. jcai19 added a comment. Update warning messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 Files:

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

2019-06-28 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364664: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r364664 - [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

2019-06-28 Thread Volodymyr Sapsai via cfe-commits
Author: vsapsai Date: Fri Jun 28 10:42:17 2019 New Revision: 364664 URL: http://llvm.org/viewvc/llvm-project?rev=364664=rev Log: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. `Selector::getIdentifierInfoForSlot` returns NULL if a slot has no corresponding

[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

2019-06-28 Thread Arnaud Bienner via Phabricator via cfe-commits
ArnaudBienner added a subscriber: xbolva00. ArnaudBienner added a comment. Thanks @xbolva00 for adding reviewers and @rjmccall for reviewing! @rjmccall as you might remember, we had a discussion on the mailing list ("Warning when calling virtual functions from constructor/desctructor?") and

[PATCH] D63734: Update CODE_OWNERS.txt for clang-doc

2019-06-28 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364663: Update CODE_OWNERS.txt for clang-doc (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r364663 - Update CODE_OWNERS.txt for clang-doc

2019-06-28 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Fri Jun 28 10:32:26 2019 New Revision: 364663 URL: http://llvm.org/viewvc/llvm-project?rev=364663=rev Log: Update CODE_OWNERS.txt for clang-doc Differential Revision: https://reviews.llvm.org/D63734 Modified: clang-tools-extra/trunk/CODE_OWNERS.TXT Modified:

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

2019-06-28 Thread Shaurya Gupta via Phabricator via cfe-commits
SureYeaah updated this revision to Diff 207084. SureYeaah added a comment. [Clangd] Refactored code - Created new class Extract to store information about the expression being extracted. - Doesn't fix all of previous comments Looking for comments on the new class stucture Repository: rG

[PATCH] D63940: [NFC] Pass DataLayout into isBytewiseValue

2019-06-28 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. vitalybuka added a parent revision: D63854: [NFC] Convert large lambda into method. We will need to handle IntToPtr which I will submit in a separate patch as

[PATCH] D63922: [clangd] Show better message when we rename macros.

2019-06-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.cpp:661 + Preprocessor ) { + // Also handle possible macro at the searched

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 207086. tuktuk edited the summary of this revision. tuktuk added a comment. I followed Matt Morehouse's advice: mainly, I adapted the test so that it uses libFuzzer's default SanitizerCoverage options instead of `trace-pc`, and I rewrote some parts of the

[PATCH] D63822: [Driver] Fix style issues of --print-supported-cpus

2019-06-28 Thread Ziang Wan via Phabricator via cfe-commits
ziangwan accepted this revision. ziangwan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63822/new/ https://reviews.llvm.org/D63822 ___

[PATCH] D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.

2019-06-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 207082. ymandel added a comment. Responded to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63892/new/ https://reviews.llvm.org/D63892 Files: clang/include/clang/Tooling/Refactoring/Transformer.h

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

2019-06-28 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:16218 +checkNonTrivialCUnion(E->getType(), E->getExprLoc(), + Sema::NTCUC_LValueToRValueVolatile); + rjmccall wrote: > It

[PATCH] D63893: [clang-tidy] Extend TransformerClangTidyCheck to support adding includes.

2019-06-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 207085. ymandel added a comment. Added check for use of AddedIncludes before allocating/registering IncludeInserter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63893/new/ https://reviews.llvm.org/D63893

[PATCH] D63892: [LibTooling] Extend `RewriteRule` with support for adding includes.

2019-06-28 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 207083. ymandel marked 2 inline comments as done. ymandel added a comment. comments tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63892/new/ https://reviews.llvm.org/D63892 Files:

[PATCH] D63936: [ARM] Minor fixes in command line option parsing

2019-06-28 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea created this revision. labrinea added reviewers: simon_tatham, SjoerdMeijer, ostannard. Herald added subscribers: dmgreen, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. When processing the command line options `march`, `mcpu` and `mfpu`, we store the

r364655 - [OPENMP]Fix top DSA for static members.

2019-06-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jun 28 09:16:00 2019 New Revision: 364655 URL: http://llvm.org/viewvc/llvm-project?rev=364655=rev Log: [OPENMP]Fix top DSA for static members. Fixed handling of the data-sharing attributes for static members when requesting top most attribute. Previously, it might

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

2019-06-28 Thread vit9696 via Phabricator via cfe-commits
vit9696 added a comment. @ruiu, we have some hardware, which bootloader does not support PT_GNU_STACK segments, and would therefore benefit quite a bit from this option. As this does not really depend on NetBSD support, could you please merge this patch in time for 9.0? Thanks! CHANGES SINCE

r364650 - [OPENMP]Fix DSA for loop iteration variables in simd loops.

2019-06-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jun 28 08:16:37 2019 New Revision: 364650 URL: http://llvm.org/viewvc/llvm-project?rev=364650=rev Log: [OPENMP]Fix DSA for loop iteration variables in simd loops. According to the OpenMP 5.0 standard, the loop iteration variable in the associated for-loop of a simd

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

2019-06-28 Thread Gabor Marton via Phabricator via cfe-commits
martong marked 2 inline comments as done. martong added a comment. In D62131#1517634 , @a_sidorin wrote: > Hi Gabor, > Could you provide an example of an import sequence leading to this behavior? > It's hard for me to imagine such a situation. Alexei,

[PATCH] D62127: [Hexagon] driver uses out-of-date option name and binary name

2019-06-28 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364648: [Hexagon] driver uses out-of-date option name and binary name (authored by kparzysz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r364648 - [Hexagon] driver uses out-of-date option name and binary name

2019-06-28 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Fri Jun 28 08:08:03 2019 New Revision: 364648 URL: http://llvm.org/viewvc/llvm-project?rev=364648=rev Log: [Hexagon] driver uses out-of-date option name and binary name Patch by A. Skrobov (t.yomitch). Differential Revision: https://reviews.llvm.org/D62127 Modified:

r364647 - [OPENMP]Fix checks for DSA in simd constructs.

2019-06-28 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jun 28 07:59:25 2019 New Revision: 364647 URL: http://llvm.org/viewvc/llvm-project?rev=364647=rev Log: [OPENMP]Fix checks for DSA in simd constructs. The errors for incorrectly specified data-sharing attributes for simd constructs must be emitted only for the explicitly

  1   2   >