[PATCH] D64123: Add clang-llvm-rename tool.

2019-07-04 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu updated this revision to Diff 208116. ruiu added a comment. - updated a few special mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/ https://reviews.llvm.org/D64123 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

2019-07-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I guess this makes sense. The results look good. I'm slightly worried that we're fighting the symptoms rather than the root cause here: why were these values tracked that far in the first place when we already have no interest in tracking them at the end of the function?

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-07-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Accept². Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1824-1825 + // because of this, let's explain why we believe control reached this point. + // TODO: Shouldn't we track control dependencies of every

[PATCH] D63538: [CFG] Add a new function to get the proper condition of a CFGBlock

2019-07-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 ___ cfe-commits mailing list

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

2019-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, dcoughlin, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. During the

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

2019-07-04 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has remained unreviewed for two weeks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63602/new/ https://reviews.llvm.org/D63602

[PATCH] D64222: [sanitizers] Use covering ObjectFormatType switches

2019-07-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, jasonliu, daltenty. Herald added subscribers: sunfish, aheejin, hiraditya. Herald added projects: clang, LLVM. This patch removes the `default` case from some switches on

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus updated this revision to Diff 208084. Szelethus marked 6 inline comments as done. Szelethus added a comment. - Add two more test cases when a "Returning value" note is meaningful, and one where it's not - Fix inlines! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

2019-07-04 Thread Hubert Tong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365160: [NFC] Make some ObjectFormatType switches covering (authored by hubert.reinterpretcast, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

r365160 - [NFC] Make some ObjectFormatType switches covering

2019-07-04 Thread Hubert Tong via cfe-commits
Author: hubert.reinterpretcast Date: Thu Jul 4 14:40:28 2019 New Revision: 365160 URL: http://llvm.org/viewvc/llvm-project?rev=365160=rev Log: [NFC] Make some ObjectFormatType switches covering Summary: This patch removes the `default` case from some switches on

[PATCH] D63161: Devirtualize destructor of final class.

2019-07-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a subscriber: rdhindsa. xbolva00 added a comment. You, @rdhindsa, should report here why you reverted this commit. It is really weird to revert random commits without more information. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/

[PATCH] D63161: Devirtualize destructor of final class.

2019-07-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. https://reviews.llvm.org/rL364359 Why this was reverted ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 ___ cfe-commits mailing list

[PATCH] D64156: Make joined instances of JoinedOrSeparate flags point to the unaliased args, like all other arg types do

2019-07-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. ruiu: ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64156/new/ https://reviews.llvm.org/D64156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63845: [WIP] Create a clang attribute that lets users specify LLVM attributes

2019-07-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D63845#1566987 , @jdoerfert wrote: > In D63845#1561983 , @lebedev.ri > wrote: > > > In D63845#1561793 , @jdoerfert > > wrote: > > > > >

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-07-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a reviewer: ahatanak. rjmccall added a comment. Herald added a subscriber: dexonsmith. Okay. Akira, do you have any interest in looking into this as a general block optimization? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53295/new/ https://reviews.llvm.org/D53295

[PATCH] D62960: Add SVE opaque built-in types

2019-07-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2680 +break; +#include "clang/Basic/AArch64SVEACLETypes.def" } rsandifo-arm wrote: > rovka wrote: > > erik.pilkington wrote: > > > rsandifo-arm wrote: > > > > erik.pilkington wrote: > >

[PATCH] D62293: [modules] Add PP callbacks for entering and leaving a submodule.

2019-07-04 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev added a comment. Herald added subscribers: wuzish, MaskRay. r365153. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62293/new/ https://reviews.llvm.org/D62293 ___

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-07-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D53295#1561890 , @rjmccall wrote: > Great, thank you. Yaxun, are you planning to pick this back up? I know it's > been a long time. Sorry I caught up with some other work. Currently there has been another change about

r365153 - [modules] Add PP callbacks for entering and leaving a submodule.

2019-07-04 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Thu Jul 4 12:06:52 2019 New Revision: 365153 URL: http://llvm.org/viewvc/llvm-project?rev=365153=rev Log: [modules] Add PP callbacks for entering and leaving a submodule. Modified: cfe/trunk/include/clang/Lex/PPCallbacks.h cfe/trunk/lib/Lex/PPLexerChange.cpp

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

2019-07-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D64128#1569836 , @hfinkel wrote: > In D64128#1569817 , @rjmccall wrote: > > > The pointer/integer conversion is "implementation-defined", but it's not > > totally unconstrained. C

[clang-tools-extra] r365151 - [clangd] Mark a couple of unimportant flags as hidden. NFC

2019-07-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Jul 4 11:49:08 2019 New Revision: 365151 URL: http://llvm.org/viewvc/llvm-project?rev=365151=rev Log: [clangd] Mark a couple of unimportant flags as hidden. NFC Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified:

[PATCH] D43159: Modernize: Use nullptr more.

2019-07-04 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: include/__threading_support:323 bool __libcpp_thread_isnull(const __libcpp_thread_t *__t) { - return *__t == 0; + return *__t == nullptr; } mclow.lists wrote: > mclow.lists wrote: > > This one is wrong. >

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

2019-07-04 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev added a comment. F9459646: spirit-c5ceba.json F9459650: Снимок экрана от 2019-07-04 18-54-58.png I've upload json-file and printscreen of its visualization (used https://speedscope.app). This is an example

[PATCH] D64211: [ARM] Fix vector vuqadd intrinsics operands

2019-07-04 Thread Luke Cheeseman via Phabricator via cfe-commits
LukeCheeseman added a comment. Are there some changes/addition to tests attached to this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64211/new/ https://reviews.llvm.org/D64211 ___ cfe-commits mailing list

[PATCH] D64210: [ARM] Fix vector vsqadd intrinsics operands

2019-07-04 Thread Luke Cheeseman via Phabricator via cfe-commits
LukeCheeseman added a comment. Are there some changes/addition to tests attached to this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64210/new/ https://reviews.llvm.org/D64210 ___ cfe-commits mailing list

[PATCH] D64211: [ARM] Fix vector vuqadd intrinsics operands

2019-07-04 Thread Diogo N. Sampaio via Phabricator via cfe-commits
dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vuqadd vector instrinsics to have the second argument as unsigned values, not signed, accordingly to

[PATCH] D64210: [ARM] Fix vector vsqadd intrinsics operands

2019-07-04 Thread Diogo N. Sampaio via Phabricator via cfe-commits
dnsampaio created this revision. dnsampaio added a reviewer: LukeCheeseman. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Change the vsqadd vector instrinsics to have the second argument as signed values, not unsigned, accordingly to

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:38 + bool VisitNamedDecl(NamedDecl *ND) { +if (ND->getDeclName().isEmpty()) + // Don't add symbols that don't have any length. jvikstrom wrote: > sammccall

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (LG from my side) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

2019-07-04 Thread Sean Fertile via Phabricator via cfe-commits
sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63767/new/ https://reviews.llvm.org/D63767

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:38 + bool VisitNamedDecl(NamedDecl *ND) { +if (ND->getDeclName().isEmpty()) + // Don't add symbols that don't have any length. sammccall wrote: > I think you

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

2019-07-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D64128#1569836 , @hfinkel wrote: > In D64128#1569817 , @rjmccall wrote: > > > The pointer/integer conversion is "implementation-defined", but it's not > > totally unconstrained. C notes

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 208041. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Added testcae. Added another bailout from VisitNamedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

2019-07-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Thanks for the quick responses and the helpful comments. Thank you very much Hal, for summarizing the argument from previous discussions. My initial understanding indeed was that by generating ptrmask directly for C/C++ expressions, we can circumvent the issues that come

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:38 + bool VisitNamedDecl(NamedDecl *ND) { +if (ND->getDeclName().isEmpty()) + // Don't add symbols that don't have any length. I think you might want to bail

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 208030. jvikstrom added a comment. Removed debug prints from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

Re: [clang-tools-extra] r365123 - [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread Kadir Çetinkaya via cfe-commits
https://reviews.llvm.org/rL365140 should fix it, please let me know if it doesnt. On Thu, Jul 4, 2019 at 3:45 PM wrote: > Hi Kadir, > > Your change is causing a build failure on our internal linux build bot > running gcc 5.4: > > FAILED: CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache >

[clang-tools-extra] r365140 - [clangd] Fix breakage on gcc 5.4

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 06:47:51 2019 New Revision: 365140 URL: http://llvm.org/viewvc/llvm-project?rev=365140=rev Log: [clangd] Fix breakage on gcc 5.4 Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extra/trunk/clangd/index/Background.h URL:

RE: [clang-tools-extra] r365123 - [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread via cfe-commits
Hi Kadir, Your change is causing a build failure on our internal linux build bot running gcc 5.4: FAILED: CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/lib/ccache/g++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 208029. jvikstrom added a comment. Removed VisitVarDecl and VisitFuncDecl in favor of VisitNamedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom updated this revision to Diff 208028. jvikstrom added a comment. Added overload for addToken and added more code to the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64199/new/ https://reviews.llvm.org/D64199 Files:

[PATCH] D64202: [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365135: [clangd] Some tweaks on semantic highlighting lookuptable. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365135 - [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 4 05:27:21 2019 New Revision: 365135 URL: http://llvm.org/viewvc/llvm-project?rev=365135=rev Log: [clangd] Some tweaks on semantic highlighting lookuptable. Summary: - move toTextMateScope to SemanticHighlighting.h; - move the buildLookupTable to LSP layer (as LSP

[PATCH] D64202: [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 208020. hokein marked 3 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64202/new/ https://reviews.llvm.org/D64202 Files:

[clang-tools-extra] r365134 - [clangd] Fix a lifetime bug in QueryDriver

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 05:24:17 2019 New Revision: 365134 URL: http://llvm.org/viewvc/llvm-project?rev=365134=rev Log: [clangd] Fix a lifetime bug in QueryDriver Modified: clang-tools-extra/trunk/clangd/QueryDriverDatabase.cpp Modified:

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:46 + + bool VisitDeclRefExpr(DeclRefExpr *Ref) { +if (Ref->getNameInfo().getName().getNameKind() == hokein wrote: > The `DeclRefExpr` is a very general

[PATCH] D49074: [Analyzer] [WIP] Basic support for multiplication and division in the constraint manager

2019-07-04 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. I tested this on several open-source projects. Lots of false-positives disappeared. There are also some new findings, mainly new false-positives but not because of this feature but of "loops executed 0 times". CHANGES SINCE LAST ACTION

[PATCH] D64202: [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:87 +// to the LSP client. +std::vector> buildTextMateScopeLookupTable() { + std::vector> LookupTable;

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:46 + + bool VisitDeclRefExpr(DeclRefExpr *Ref) { +if (Ref->getNameInfo().getName().getNameKind() == The `DeclRefExpr` is a very general expression, which can

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:42 + // Generate Replacement for replacing selected expression with given VarName + tooling::Replacement replaceWithVar(std::string VarName) const; + // Generate

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365133: [CTU] Add support for virtual functions (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365133 - [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via cfe-commits
Author: martong Date: Thu Jul 4 04:39:00 2019 New Revision: 365133 URL: http://llvm.org/viewvc/llvm-project?rev=365133=rev Log: [CTU] Add support for virtual functions Reviewers: Szelethus, xazax.hun Subscribers: rnkovacs, dkrupp, gamesh411, cfe-commits Tags: #clang Differential Revision:

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365132: [clangd] Query driver reads stderr and passes driver as first argument (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue ) { + APValue Result; martong wrote: > Tyker wrote: > > martong wrote: > > > Looks okay, but

[PATCH] D64202: [clangd] Some tweaks on semantic highlighting lookuptable.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added reviewers: sammccall, jvikstrom. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - move toTextMateScope to SemanticHighlighting.h; - move the buildLookupTable to LSP layer (as LSP requires

[clang-tools-extra] r365132 - [clangd] Query driver reads stderr and passes driver as first argument

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 04:34:23 2019 New Revision: 365132 URL: http://llvm.org/viewvc/llvm-project?rev=365132=rev Log: [clangd] Query driver reads stderr and passes driver as first argument Summary: gcc invokes cc1 through a path deduced from argv[0] therefore it must be correctly

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 208015. Tyker added a comment. fixed the comment for good, sorry for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h

[PATCH] D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365130: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r365130 - [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jul 4 03:49:32 2019 New Revision: 365130 URL: http://llvm.org/viewvc/llvm-project?rev=365130=rev Log: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file. Reviewers: sammccall, jvikstrom Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous,

[PATCH] D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 208012. hokein marked 4 inline comments as done. hokein added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64137/new/ https://reviews.llvm.org/D64137 Files:

[PATCH] D64048: [TargetParser][ARM] Account dependencies when processing target features

2019-07-04 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea updated this revision to Diff 208010. labrinea added a comment. Added the dependency of mve on dsp and some missing tests to cover those cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64048/new/ https://reviews.llvm.org/D64048

r365126 - Fix -Wdocumentation warning.

2019-07-04 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jul 4 03:28:31 2019 New Revision: 365126 URL: http://llvm.org/viewvc/llvm-project?rev=365126=rev Log: Fix -Wdocumentation warning. Modified: cfe/trunk/include/clang/AST/ASTImporter.h Modified: cfe/trunk/include/clang/AST/ASTImporter.h URL:

[PATCH] D63936: [clang][Driver][ARM] Favor -mfpu over default CPU features

2019-07-04 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea added inline comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:412 - if (Extensions & AEK_CRC) -Features.push_back("+crc"); - else -Features.push_back("-crc"); - - if (Extensions & AEK_DSP) -Features.push_back("+dsp"); - else -

[PATCH] D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:16 + +llvm::StringRef toTextMateScope(HighlightingKind Kind) { + static const

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365124: [clangd] Turn background-index on by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920

[clang-tools-extra] r365124 - [clangd] Turn background-index on by default

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 02:56:24 2019 New Revision: 365124 URL: http://llvm.org/viewvc/llvm-project?rev=365124=rev Log: [clangd] Turn background-index on by default Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential

[PATCH] D64199: [clangd] Added highlighting for variable references (declrefs)

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Added highlighting for variable references using VisitDeclRefExpr. Repository: rG LLVM

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365123: [clangd] Make HadErrors part of background indexs internal state (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D63920: [CTU] Add support for virtual functions

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 208002. martong added a comment. - Remove ipa mode from the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63920/new/ https://reviews.llvm.org/D63920 Files: clang/lib/StaticAnalyzer/Core/CallEvent.cpp

[PATCH] D64133: [clangd] Add HadErrors field into shards

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365122: [clangd] Add HadErrors field into shards (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64018: [clangd] Store hash of command line in index shards.

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365121: [clangd] Store hash of command line in index shards. (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365120: [clangd] Also cache failures while indexing (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365121 - [clangd] Store hash of command line in index shards.

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 02:51:53 2019 New Revision: 365121 URL: http://llvm.org/viewvc/llvm-project?rev=365121=rev Log: [clangd] Store hash of command line in index shards. Summary: This is to enable cache invalidation when command line flags changes. Reviewers: sammccall

[clang-tools-extra] r365122 - [clangd] Add HadErrors field into shards

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 02:52:04 2019 New Revision: 365122 URL: http://llvm.org/viewvc/llvm-project?rev=365122=rev Log: [clangd] Add HadErrors field into shards Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential

[clang-tools-extra] r365123 - [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 02:52:12 2019 New Revision: 365123 URL: http://llvm.org/viewvc/llvm-project?rev=365123=rev Log: [clangd] Make HadErrors part of background index's internal state Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags:

[clang-tools-extra] r365120 - [clangd] Also cache failures while indexing

2019-07-04 Thread Kadir Cetinkaya via cfe-commits
Author: kadircet Date: Thu Jul 4 02:51:43 2019 New Revision: 365120 URL: http://llvm.org/viewvc/llvm-project?rev=365120=rev Log: [clangd] Also cache failures while indexing Summary: Clangd currently doesn't cache any indexing failures, which results in retrying those failed files even if their

[PATCH] D62960: Add SVE opaque built-in types

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. The ASTImporter and the test for it looks good to me, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62960/new/ https://reviews.llvm.org/D62960 ___ cfe-commits mailing list

[PATCH] D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 207996. hokein marked 3 inline comments as done. hokein added a comment. address comments: - emit textmate scope names - rescope to the selected node rather than TU decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:331 +/// +/// \return the equivalent APValue in the "from" Constext or the import +/// error. martong wrote: > typo: `Constext` -> `Context` > Also, we return with the

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

2019-07-04 Thread Marco Antognini via Phabricator via cfe-commits
mantognini added a comment. I'll commit this along with D64083 in a few days in case John has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

2019-07-04 Thread Marco Antognini via Phabricator via cfe-commits
mantognini updated this revision to Diff 207994. mantognini added a comment. Addressed missing colon in FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 Files:

[PATCH] D62960: Add SVE opaque built-in types

2019-07-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D62960#1566265 , @rovka wrote: > This looks much better, thanks! Shouldn't there be more tests, e.g. for > mangling and maybe the ASTImporter? Thanks. I've added tests for ASTImporter and mangling in the latest

[PATCH] D64019: [clangd] Turn background-index on by default

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:191 "Index project code in the background and persist index on disk. " "Experimental"), +llvm::cl::init(true));

[PATCH] D63936: [clang][Driver][ARM] Favor -mfpu over default CPU features

2019-07-04 Thread Oliver Stannard (Linaro) via Phabricator via cfe-commits
ostannard added inline comments. Comment at: llvm/lib/Support/ARMTargetParser.cpp:412 - if (Extensions & AEK_CRC) -Features.push_back("+crc"); - else -Features.push_back("-crc"); - - if (Extensions & AEK_DSP) -Features.push_back("+dsp"); - else -

[PATCH] D62960: SVE opaque type for C intrinsics demo

2019-07-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm updated this revision to Diff 207991. rsandifo-arm added a comment. Changes since last version: - Define the SVE types only for AArch64 targets - Use the vendor extension 'u' mangling, as per the spec - Report an error for @encode on the types - Fixed the licence text on the new

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 207986. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64147/new/ https://reviews.llvm.org/D64147 Files:

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. gcc invokes cc1 through a path deduced from argv[0] therefore it must be correctly set. Also it prints the search

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Logic looks great, just naming/comment nits Comment at: clang-tools-extra/clangd/index/Background.cpp:276 +const auto DigestIt =

[clang-tools-extra] r365112 - [clangd] Add missing changes for 365111

2019-07-04 Thread Johan Vikstrom via cfe-commits
Author: jvikstrom Date: Thu Jul 4 01:06:48 2019 New Revision: 365112 URL: http://llvm.org/viewvc/llvm-project?rev=365112=rev Log: [clangd] Add missing changes for 365111 Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h

[PATCH] D64137: [clangd] Add a hidden tweak to annotate all highlighting tokens of the file.

2019-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp:15 + +llvm::StringRef highlightingKindToString(HighlightingKind Kind) { + switch (Kind) { it would be nice to use the textmate class name rather

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

2019-07-04 Thread Johan Vikström via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. jvikstrom marked 2 inline comments as done. Closed by commit rL365111: [clangd] Emit publishSemanticHighlighting in LSP if enabled (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a

[clang-tools-extra] r365111 - [clangd] Emit publishSemanticHighlighting in LSP if enabled

2019-07-04 Thread Johan Vikstrom via cfe-commits
Author: jvikstrom Date: Thu Jul 4 00:53:12 2019 New Revision: 365111 URL: http://llvm.org/viewvc/llvm-project?rev=365111=rev Log: [clangd] Emit publishSemanticHighlighting in LSP if enabled Summary: Emit publishSemanticHighlighting in LSP if enabled Reviewers: hokein, kadircet Subscribers:

[PATCH] D63919: [clangd] Emit publishSemanticHighlighting in LSP if enabled

2019-07-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:59 + void onHighlightingsReady(PathRef File, + std::vector Highlightings)

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8503 +llvm::Expected ASTImporter::Import(const APValue ) { + APValue Result; martong wrote: > Looks okay, but could we have unit tests for this in ASTImporterTest.cpp? I tested importing

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-07-04 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 207977. Tyker marked 2 inline comments as done. Tyker set the repository for this revision to rC Clang. Tyker added a comment. fixed comment typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/