[PATCH] D64387: CodeGen: Do not memset if following stores will overwrite entire variable

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. In some cases llvm::getMostFrequentByte can't analyze a constant so we write zeros and then override the rest with stores. These zeros

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka updated this revision to Diff 208598. vitalybuka added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64385/new/ https://reviews.llvm.org/D64385 Files: clang/test/CodeGen/init-memset.c Index: clang/test/CodeGen/in

[PATCH] D64386: CodeGen: Use memset in initializers for non-zeros

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64386 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGen/init

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208594. vitalybuka added a comment. undo some behavior change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

jfb added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:865 +/// initializer with equal or fewer than NumStores scalar stores. +static bool canEmitStoresForInitAfterMemset(CodeGenModule &CGM, +llvm::Constant *Init, -

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka updated this revision to Diff 208593. vitalybuka added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64385/new/ https://reviews.llvm.org/D64385 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGen/init-memset.c

[PATCH] D64385: GodeGen: Add test to track emitStoresForConstant behavior

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64385 Files: clang/test/CodeGen/init-memset.c Index: clang/test/CodeGen/init-mems

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

This revision was automatically updated to reflect the committed changes. Closed by commit rL365438: [BPF] Preserve debuginfo array/union/struct type/access index (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

r365438 - [BPF] Preserve debuginfo array/union/struct type/access index

Author: yhs Date: Mon Jul 8 21:21:50 2019 New Revision: 365438 URL: http://llvm.org/viewvc/llvm-project?rev=365438&view=rev Log: [BPF] Preserve debuginfo array/union/struct type/access index For background of BPF CO-RE project, please refer to http://vger.kernel.org/bpfconf2019.html In summary

r365436 - Revert "[BPF] Preserve debuginfo array/union/struct type/access index"

Author: yhs Date: Mon Jul 8 21:15:12 2019 New Revision: 365436 URL: http://llvm.org/viewvc/llvm-project?rev=365436&view=rev Log: Revert "[BPF] Preserve debuginfo array/union/struct type/access index" This reverts commit r365435. Forgot adding the Differential Revision link. Will add to the comm

[PATCH] D64278: Rename libclang_shared to libclang-cpp

tstellar added a comment. I'm fine with this new name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

r365435 - [BPF] Preserve debuginfo array/union/struct type/access index

Author: yhs Date: Mon Jul 8 21:04:21 2019 New Revision: 365435 URL: http://llvm.org/viewvc/llvm-project?rev=365435&view=rev Log: [BPF] Preserve debuginfo array/union/struct type/access index For background of BPF CO-RE project, please refer to http://vger.kernel.org/bpfconf2019.html In summary

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208588. Charusso added a comment. - Simplify the new `getNoteTag()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/clang/St

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:61 + + return Ty.getAsString(); +} NoQ wrote: > Use after free! `QualType::getAsString()` returns a temporary `std::string`. > You're returning a `StringRef` that

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 9 inline comments as done. wwagner19 added a comment. Thanks for all the feedback, Sam! I'll try and get an updated patch up sometime tomorrow. Comment at: clang-tools-extra/clangd/PathMapping.cpp:30 + const auto &K = V.kind(); + if (K == Kind::Object) { +

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208586. Charusso marked 9 inline comments as done. Charusso added a comment. - Fix. - More tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checker

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka updated this revision to Diff 208583. vitalybuka added a comment. Reverted debug logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64382/new/ https://reviews.llvm.org/D64382 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/Co

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-co

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. In D63638#1574927 , @craig.topper wrote: > What if we just only check the output from the new pass manager. I don't > think I care about the differences between the two. +1 CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a subscriber: rnkovacs. NoQ added a comment. We should add at least some tests for the other three functions. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:278 +def CastValueChecker : Checker<"CastValue">, + HelpText<"Model casts">, + Documenta

Re: [libunwind] r364217 - Merging r360861:

On 07/08/2019 11:51 AM, Dimitry Andric wrote: > On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits > wrote: >> >> Author: tstellar >> Date: Mon Jun 24 11:40:58 2019 >> New Revision: 364217 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=364217&view=rev >> Log: >> Merging r360861: >> >> ---

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208574. Charusso added a comment. - Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/clang/StaticAnalyzer/Core/Pat

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. Thanks! My mind was really set to actually model these with `classof()`, whoops. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:25-27 + using CastCheck = + std::function; NoQ wrote: > Kinda nice, but a simple

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208573. Charusso marked 12 inline comments as done. Charusso added a comment. - Fix - New `getNoteTag()` which accepts a plain note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/cl

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a subscriber: rsmith. NoQ added a comment. Ok, so i think i more or less understand where this is going and i like it! My only concern about making sure that used-expressions don't appear in both CFGs; and, even then, it's likely that i'm wrong. +@rsmith just in case he has any immedi

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:4746-4750 + D->for_each_used_expr([this, &B](Expr *E) { +assert(E && "Expected expression."); +if (CFGBlock *R = Visit(E)) + B = R; + }); ABataev wrote: > NoQ wrote: > > Not sure, are thes

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: test/Driver/fsanitize-blacklist.c:32 // RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -resource-dir=%S/Inputs/resource_dir %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-DEFAULT-

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:27-30 static const SanitizerMask NeedsUbsanRt = SanitizerKind::Undefined | SanitizerKind::Integer | SanitizerKind::ImplicitConversion | SanitizerKind::Null

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. I changed the tests to use FileCheck variables whenever possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari updated this revision to Diff 208564. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUDA/builtins-amdgcn.cu clang/test/CodeGenOpenCL/address-spaces-conversions.cl clang/t

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208565. MaskRay added a comment. Fix getPPTransparentSanitizers (test/Modules/check-for-sanitizer-feature.cpp) & ubsan_blacklist.txt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 F

[PATCH] D64383: build: use multiple `install` rather than building up a list

compnerd created this revision. compnerd added reviewers: smeenai, beanz, EricWF. Herald added subscribers: libcxx-commits, ldionne, mgorny. Rather than building up a list to iterate over later, just create multiple `install` commands based on the configuration. This makes it easier to see what

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. What if we just only check the output from the new pass manager. I don't think I care about the differences between the two. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. In D63638#1574740 , @leonardchan wrote: > In D63638#1574373 , @craig.topper > wrote: > > > There's some inliner running because the intrinsics are implemented as > > always_inline fun

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequireDesignatedInit : InheritableAttr { + let Spellings = [GNU<"require_designated_init">]; + let Subjects = SubjectList<[Type]>; This seems like an extension? I think th

[PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

NoQ added a comment. Sorry, couldn't help it. This patch looks so useful and so lonely :) Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6782 +def warn_member_call_in_ctor_init : Warning< + "member function call %0 in ctor-initializer for base class %1 results in " +

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

This revision was automatically updated to reflect the committed changes. Closed by commit rL365414: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL365413: Let unaliased Args track which Alias they were created from, and use that in… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D64253?vs=208192&id=208553#toc

r365414 - Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

Author: nico Date: Mon Jul 8 17:36:18 2019 New Revision: 365414 URL: http://llvm.org/viewvc/llvm-project?rev=365414&view=rev Log: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source This is a better fix for the problem fixed in r334972. Also remove the rm'ing of the sym

r365413 - Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

Author: nico Date: Mon Jul 8 17:34:08 2019 New Revision: 365413 URL: http://llvm.org/viewvc/llvm-project?rev=365413&view=rev Log: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics With this, `clang-cl /source-charset:utf-16 test.cc`

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1567175 , @sylvestre.ledru wrote: > This isn't firefox per say but thirdparty apps. > If you feel confident, sure, we can land that and see what happens :) One concern that I have is that we don't have a replacement for `

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3251 + "the only well defined values for BOOL are YES and NO">, + InGroup; erik.pilk

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 208550. domdom added a comment. Thank you for catching that @aaron.ballman! I forgot to update the test after the running clang-format. I thought I ran the tests again before submitting, but I guess I didn't :P Thanks again! CHANGES SINCE LAST ACTION htt

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

This revision was automatically updated to reflect the committed changes. Closed by commit rL365412: [X86][PPC] Support -mlong-double-64 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r365412 - [X86][PPC] Support -mlong-double-64

Author: maskray Date: Mon Jul 8 17:27:43 2019 New Revision: 365412 URL: http://llvm.org/viewvc/llvm-project?rev=365412&view=rev Log: [X86][PPC] Support -mlong-double-64 -mlong-double-64 is supported on some ports of gcc (i386, x86_64, and ppc{32,64}). On many other targets, there will be an err

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Linux.cpp:868 -static std::string DetectLibcxxIncludePath(StringRef base) { +static std::string DetectLibcxxIncludePath(StringR

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka added a parent revision: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation. Previous implementatio

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

juliehockett created this revision. juliehockett added reviewers: dlj, phosek. Herald added a reviewer: EricWF. The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates it to use llvm::vfs::directory_iterator. https://reviews.llvm.org/D64381 File

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3251 + "the only well defined values for BOOL are YES and NO">, + InGroup; rjmccall wrote: > The `from` seems awkward here; `%0` is the number, not the type.

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

erik.pilkington updated this revision to Diff 208545. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63912/new/ https://reviews.llvm.org/D63912 Files: clang/include/clang/Basic/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208544. emmettneyman added a comment. Undo clang-format changes to SemaDecl.cpp and SemaDeclAttr.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL365411: clang-cl: Port cl.exe's C4659 to clang-cl (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

r365411 - clang-cl: Port cl.exe's C4659 to clang-cl

Author: nico Date: Mon Jul 8 17:02:23 2019 New Revision: 365411 URL: http://llvm.org/viewvc/llvm-project?rev=365411&view=rev Log: clang-cl: Port cl.exe's C4659 to clang-cl Differential Revision: https://reviews.llvm.org/D64349 Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/in

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64067/new/ https://reviews.llvm.org/D64067 ___ cfe-commits mailing

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365410: [analyzer] exploded-graph-rewriter: Implement a topology-only mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r365409 - [analyzer] exploded-graph-rewriter: Implement a single-path mode.

Author: dergachev Date: Mon Jul 8 16:54:11 2019 New Revision: 365409 URL: http://llvm.org/viewvc/llvm-project?rev=365409&view=rev Log: [analyzer] exploded-graph-rewriter: Implement a single-path mode. Instead of rewriting the whole graph, rewrite the leftmost path in the graph. Useful for trimme

[PATCH] D64263: [analyzer] exploded-graph-rewriter: Implement a single-path mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365409: [analyzer] exploded-graph-rewriter: Implement a single-path mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r365410 - [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

Author: dergachev Date: Mon Jul 8 16:54:14 2019 New Revision: 365410 URL: http://llvm.org/viewvc/llvm-project?rev=365410&view=rev Log: [analyzer] exploded-graph-rewriter: Implement a topology-only mode. In this mode the rewriter will only rewrite program points and omit program states. Useful fo

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

thakis added a comment. > lgtm Thanks! > 5381 361257 out/clang/browser_tests.exe.rsp Looking at that file, that looks like 10554 distinct args from the rsp file. That's ~80kB for the additional pointer, which for a link that's going to consume hundreds of MB isn't all that much overhead. (

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. In D64349#1574742 , @rnk wrote: > lgtm Thanks! > May I ask what inspired this? :) I was looking through lld/COFF/Driver.cpp for something…ah, right, because D64156 touched it, and because I loo

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

This revision was automatically updated to reflect the committed changes. Closed by commit rL365408: [ObjC] Add a -Wtautological-compare warning for BOOL (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:124 + +Out << "Cast from a null pointer results in a null pointer"; +return Out.str(); `Assuming null pointer is passed into cast` o.o Repository: rC

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

erik.pilkington added a comment. In D63856#1561160 , @rjmccall wrote: > In D63856#1561132 , @erik.pilkington > wrote: > > > In D63856#1561112 , @rjmccall > > wrote: > > > >

r365408 - [ObjC] Add a -Wtautological-compare warning for BOOL

Author: epilk Date: Mon Jul 8 16:42:52 2019 New Revision: 365408 URL: http://llvm.org/viewvc/llvm-project?rev=365408&view=rev Log: [ObjC] Add a -Wtautological-compare warning for BOOL On macOS, BOOL is a typedef for signed char, but it should never hold a value that isn't 1 or 0. Any code that e

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. The overall code looks great! It's well-structured and easy to understand, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 ___ cfe-commits mailin

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:25-27 + using CastCheck = + std::function; Kinda nice, but a simple pointer-to-member would have been sufficient and much more lightweight: ```lang=c++ using Cas

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. In D63638#1574373 , @craig.topper wrote: > There's some inliner running because the intrinsics are implemented as > always_inline functions and they are clearly being inlined in -O0. In a > previous post, Chandler said the n

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm May I ask what inspired this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 ___ cfe-commit

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. Thanks! Comment at: clang/test/Sema/pragma-section.c:57 + +// Not sure if this should warn or not. +__attribute__((section(".drectve"))) int drectve_int; rnk wrote: > I agree it probably shouldn't, I imagine mingw users will want to be a

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis updated this revision to Diff 208538. thakis marked 2 inline comments as done. thakis added a comment. Herald added a subscriber: mstorsjo. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.t

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL365407: [Attributor] Deduce the "returned" argument attribute (authored by jdoerfert, committed by ). Changed prior to commit: https://reviews.llvm.org/D59919?vs=207924&id=208536#toc Repository: rL L

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. In D64375#1574698 , @jdoerfert wrote: > In D64375#1574662 , @ABataev wrote: > > > The scheme itself looks good in general. > > > Good. Once we agreed on a scheme we can improve the actual pr

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365406: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default… (authored by dblaikie, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r365406 - [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

Author: dblaikie Date: Mon Jul 8 16:24:41 2019 New Revision: 365406 URL: http://llvm.org/viewvc/llvm-project?rev=365406&view=rev Log: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable. This is a fix for rG864949 which only disabled default constru

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D64375#1574662 , @ABataev wrote: > The scheme itself looks good in general. Good. Once we agreed on a scheme we can improve the actual process, excel sheet, generator script, etc.

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. The scheme itself looks good in general. Just as an improvement, it would be good to use coloring for the feature status. Also, what's the difference between claimed, mostly done and done? Comment at: clang/docs/OpenMPSupport.rst:153 ++

r365405 - [Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h

Author: thegameg Date: Mon Jul 8 16:02:50 2019 New Revision: 365405 URL: http://llvm.org/viewvc/llvm-project?rev=365405&view=rev Log: [Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h This fixes a modules issue: error: declaration of 'bitc' must be imported from module 'C

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. In D64356#1574625 , @ABataev wrote: > That's strange. Maybe the patch applied incorrectly? Whoops, i needed to pull rC365334 . The patch has applied cleanly "with fuzz 2", which meant "oh there's n

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert created this revision. jdoerfert added reviewers: kkwli0, ABataev, RaviNarayanaswamy, gtbercea, Hahnfeld. Herald added subscribers: jfb, guansong, bollu. Herald added a project: clang. This adds a more fine-grained list of OpenMP features with their implementation status and associated

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574540 , @NoQ wrote: > I don't know much about OpenMP, but i guess i can help with the CFG a bit. Thanks a lot! > I strongly recommend adding a few direct tests for the CFG so

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:75 +Children.emplace_back( +llvm::make_unique(Text.str(), !InlineChildren)); + } jakehehrlich wrote: > I think you can just write `Children.emplace_back(

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:175 + else*/ +Param = CE->getArg(0); + This CXXMemberCallExpr business is necessary? I am not sure as I have not see

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208527. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. Add helper function to move a vector's elements to another vector. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso created this revision. Charusso added reviewers: NoQ, ravikandhadai. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. It models the LLVM casts: - `cast<>` - `

r365402 - Fix line endings. NFC

Author: probinson Date: Mon Jul 8 15:35:30 2019 New Revision: 365402 URL: http://llvm.org/viewvc/llvm-project?rev=365402&view=rev Log: Fix line endings. NFC Modified: cfe/trunk/test/Driver/ps4-analyzer-defaults.cpp Modified: cfe/trunk/test/Driver/ps4-analyzer-defaults.cpp URL: http://llvm.

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* MaskRay wrote: > ABataev wrote: > > MaskRay wrote: > > > ABataev wrote: > > > > Ma

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. I don't know much about OpenMP, but i guess i can help with the CFG a bit. I strongly recommend adding a few direct tests for the CFG so that to check that the order of statements and the overall topology of the CFG is as you intended. Currently those tests are routed throu

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL365396: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r365396 - [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

Author: ro Date: Mon Jul 8 15:04:25 2019 New Revision: 365396 URL: http://llvm.org/viewvc/llvm-project?rev=365396&view=rev Log: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris As explained in https://reviews.llvm.org/D63601, there's no point using clang_rt.sancov_{begin,end} on So

[PATCH] D63663: [clang-doc] Add html links to references

jakehehrlich added a comment. The code looks good to me. I'll let Julie give the final architectural approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 ___ cfe-commits mailing list cfe-commits

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro added a comment. In D63602#1574337 , @vitalybuka wrote: > In D63602#1570884 , @ro wrote: > > > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > > remained unreviewed for two weeks. > >

r365395 - Add parentheses to silence warnings.

Author: void Date: Mon Jul 8 15:01:07 2019 New Revision: 365395 URL: http://llvm.org/viewvc/llvm-project?rev=365395&view=rev Log: Add parentheses to silence warnings. Modified: cfe/trunk/lib/Tooling/Syntax/BuildTree.cpp Modified: cfe/trunk/lib/Tooling/Syntax/BuildTree.cpp URL: http://llvm.

r365393 - Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

Author: rnk Date: Mon Jul 8 14:59:07 2019 New Revision: 365393 URL: http://llvm.org/viewvc/llvm-project?rev=365393&view=rev Log: Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings This reverts r365382 (git commit 8b1becf2e31d9

[PATCH] D63894: [CXX] Exercise all paths through these tests

dblaikie added a comment. I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere) Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre marked 2 inline comments as done. mgehre added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:96 +CheckFactories.registerCheck( +"readability-static-method"); CheckFactories.registerCheck(

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre updated this revision to Diff 208505. mgehre marked 11 inline comments as done. mgehre added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2283 if (Attr *ClassAttr = getDLLAttr(Class)) { - if (auto *BaseTemplate = dyn_cast_or_null( - BaseType->getAsCXXRecordDecl())) { This file seems untouched except for wh

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. There's some inliner running because the intrinsics are implemented as always_inline functions and they are clearly being inlined in -O0. In a previous post, Chandler said the new PM has a special inliner for always_inline in -O0 and the old pass manager just used

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 marked an inline comment as done. zhangxy988 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 updated this revision to Diff 208500. zhangxy988 marked 2 inline comments as done. zhangxy988 added a comment. - Remove empty line and add assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/ https://reviews.llvm.o

  1   2   3   >