[libclc] r365728 - Creating release candidate rc4 from release_801 branch

Author: tstellar Date: Wed Jul 10 19:58:32 2019 New Revision: 365728 URL: http://llvm.org/viewvc/llvm-project?rev=365728=rev Log: Creating release candidate rc4 from release_801 branch Added: libclc/tags/RELEASE_801/rc4/ - copied from r365727, libclc/branches/release_80/

[libunwind] r365728 - Creating release candidate rc4 from release_801 branch

Author: tstellar Date: Wed Jul 10 19:58:32 2019 New Revision: 365728 URL: http://llvm.org/viewvc/llvm-project?rev=365728=rev Log: Creating release candidate rc4 from release_801 branch Added: libunwind/tags/RELEASE_801/rc4/ - copied from r365727, libunwind/branches/release_80/

r365727 - Increase the number of parser diagnostics.

Author: rtrieu Date: Wed Jul 10 19:54:15 2019 New Revision: 365727 URL: http://llvm.org/viewvc/llvm-project?rev=365727=rev Log: Increase the number of parser diagnostics. The reserved range for parser diagnostics is getting close to being filled, so increase the space for them. Modified:

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. In D64482#1578376 , @ro wrote: > In D64482#1578245 , @MaskRay wrote: > > > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > > for C++ only, while clang has

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. In D64538#1579632 , @smeenai wrote: > I'm not fully understanding this. If the .sh file was generated on Windows, > it'll contain backslashes in any arguments that are paths, right? Before this > change, those backslashes would have

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay added a comment. Ping:) It'll be great to have D64277 (-mlong-double-128) D64282 (libcall) D64283 (-mabi=ieeelongdouble) before 9.0.0 is branched. Repository: rC Clang CHANGES

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 209114. MaskRay added a comment. Make -mabi=ieeelongdouble a pure CC1 option so that we can simplify the -mabi= loop Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64283/new/ https://reviews.llvm.org/D64283 Files:

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

ahatanak added a comment. I didn't know spaces are not allowed between "CHECK" and ":". CodeGen tests LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @jdoerfert Thanks for comments. I will submit another patch to add adequate tests for clang frontend as you suggested. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:579 -static bool shouldUseFramePointer(const ArgList , - const llvm::Triple ) { - if (Arg *A =

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak marked 2 inline comments as done. ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12053 +NTCUC_UninitAutoVar); } + rjmccall wrote: > Please add a comment explaining why this is specific to local

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 209112. MaskRay added a comment. Improve readability Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. The test coverage here is not acceptable: 1. The command line of the tests is far from what it should be (see other tests). 2. The check lines do little to prevent regressions in the

[PATCH] D64506: clang-cl: Remove -O0 option

This revision was automatically updated to reflect the committed changes. Closed by commit rL365724: clang-cl: Remove -O0 option (authored by nico, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D64506?vs=209092=209111#toc Repository:

r365724 - clang-cl: Remove -O0 option

Author: nico Date: Wed Jul 10 18:18:05 2019 New Revision: 365724 URL: http://llvm.org/viewvc/llvm-project?rev=365724=rev Log: clang-cl: Remove -O0 option cl.exe doesn't understand it; there's /Od instead. See also the review thread for r229575. Update lots of compiler-rt tests to use -Od

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak updated this revision to Diff 209108. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63753/new/ https://reviews.llvm.org/D63753 Files:

r365721 - Various minor tweaks to CLCompatOptions.td

Author: nico Date: Wed Jul 10 18:13:38 2019 New Revision: 365721 URL: http://llvm.org/viewvc/llvm-project?rev=365721=rev Log: Various minor tweaks to CLCompatOptions.td - Add back indentation I accidentally removed in r364901 - Wrap two lines to 80 cols - Slightly tighten up help text for

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum marked an inline comment as done. quantum added a comment. In D64537#1579626 , @sunfish wrote: > This looks nice! > > > __wasm_init_tls(calloc(__builtin_wasm_tls_size(), 1)); > > Would it make sense to change the API contract for `__wasm_init_tls`

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

JDevlieghere added a comment. The dsymutil part LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

Nathan-Huckleberry updated this revision to Diff 209105. Nathan-Huckleberry added a comment. - Fix .m and i.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64543/new/ https://reviews.llvm.org/D64543 Files: clang/docs/analyzer/checkers.rst

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1579481 , @Eugene.Zelenko wrote: > In D64454#1579466 , > @Nathan-Huckleberry wrote: > > > Docs exist for these checks on the analyzer side, they're just all on the >

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

Nathan-Huckleberry updated this revision to Diff 209104. Nathan-Huckleberry added a comment. - Fix file periods being converted to dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64543/new/ https://reviews.llvm.org/D64543 Files:

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209102. quantum added a comment. Fix linker warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

Nathan-Huckleberry updated this revision to Diff 209103. Nathan-Huckleberry added a comment. - Fixed periods in sentences being dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64543/new/ https://reviews.llvm.org/D64543 Files:

[PATCH] D64543: [Docs] Add standardized header links to analyzer doc

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, Szelethus, a.sidorin, mgrang, baloghadamsoftware. Herald added a project: clang. Header links should have some standard form so clang tidy docs can easily reference them. The form is as

[PATCH] D64506: clang-cl: Remove -O0 option

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64506/new/ https://reviews.llvm.org/D64506 ___ cfe-commits mailing list

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/CLCompatOptions.td:294 def _SLASH_GX : CLFlag<"GX">, - HelpText<"Enable exception handling">; + HelpText<"Deprecated (like /EHsc)">;

Re: r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Hi Djordje, Just a heads-up that I’ve landed r365716 to fix a crash in a stage2 build of AppleClang with -femit-debug-entry-values enabled. I went ahead and landed the fix as it seemed simple enough. Let me know if you have any concerns. Thanks, Vedant > On Jun 26, 2019, at 6:32 AM, Djordje

r365716 - [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers

Author: vedantk Date: Wed Jul 10 17:09:16 2019 New Revision: 365716 URL: http://llvm.org/viewvc/llvm-project?rev=365716=rev Log: [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers An os_log_helper FunctionDecl may not have a body. Ignore these for the purposes of debug entry

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman planned changes to this revision. emmettneyman added a comment. Working on adding more information to the documentation and adding more in-depth unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209096. DiegoAstiazaran added a comment. In tag nodes with children that are not inline, two text nodes that are adjacent won't have a new line between them. Tag nodes are still rendered in their own line. A B C D is now

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3533-3541 +def err_require_designated_init_failed : Error< + "variable declaration does not use designated initializer syntax">; +def note_declared_required_designated_init_here :

r365714 - Attempt to fix bots after r365703

Author: nico Date: Wed Jul 10 16:50:16 2019 New Revision: 365714 URL: http://llvm.org/viewvc/llvm-project?rev=365714=rev Log: Attempt to fix bots after r365703 Modified: cfe/trunk/test/Driver/as-options.s Modified: cfe/trunk/test/Driver/as-options.s URL:

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209097. emmettneyman marked 32 inline comments as done. emmettneyman added a comment. Addressed several of the comments regarding naming and style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/

[clang-tools-extra] r365713 - rL365634 adds a unique_ptr in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile stan

Author: saugustine Date: Wed Jul 10 16:38:00 2019 New Revision: 365713 URL: http://llvm.org/viewvc/llvm-project?rev=365713=rev Log: rL365634 adds a unique_ptr in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone,

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis updated this revision to Diff 209093. thakis marked 4 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64504/new/ https://reviews.llvm.org/D64504 Files: clang/include/clang/Driver/CLCompatOptions.td Index:

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis added inline comments. Comment at: clang/include/clang/Driver/CLCompatOptions.td:250 def _SLASH_Zi : CLFlag<"Zi">, Alias<_SLASH_Z7>, - HelpText<"Alias for /Z7. Does not produce PDBs.">; + HelpText<"Like /Z7">; def _SLASH_Zp : CLJoined<"Zp">, rnk

[PATCH] D64506: clang-cl: Remove -O0 option

thakis updated this revision to Diff 209092. thakis added a comment. Herald added subscribers: llvm-commits, kubamracek. Herald added a project: LLVM. update tests (not yet executed, don't have a win machine today) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64506/new/

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. In D64506#1579251 , @rnk wrote: > Does `clang-cl -O0` without a `/` still work, though? It's used: > > $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/ > ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc://

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:6097 + // non-trivial to copy or default-initialize. + checkNonTrivialCUnionInInitList(ILE); + } ahatanak wrote: > rjmccall wrote: > > Can we extract a common function that checks the

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579610 , @rnk wrote: > In D64538#1579573 , @smeenai wrote: > > > In D64538#1579561 , @rnk wrote: > > > > > An extremely convenient

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

sunfish added a comment. This looks nice! > __wasm_init_tls(calloc(__builtin_wasm_tls_size(), 1)); Would it make sense to change the API contract for `__wasm_init_tls` to guarantee that initializes all bytes (with zeros as needed)? `__wasm_init_tls` knows what bytes it's initializing, so we

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209090. quantum added a comment. Fix `fail` call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert updated this revision to Diff 209089. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Fixes according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/ https://reviews.llvm.org/D64375 Files:

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209088. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use `llvm::sys::fs::copy_file` to copy css file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files:

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. In D64538#1579573 , @smeenai wrote: > In D64538#1579561 , @rnk wrote: > > > An extremely convenient feature of the current escaping pattern is that it > > magically works for both the cmd

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:110-113 +Inherits from +F +, +G This text should be rendered inline Comment at:

[PATCH] D63940: NFC: Pass DataLayout into isBytewiseValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL365709: NFC: Pass DataLayout into isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63940?vs=207092=209086#toc Repository: rL LLVM CHANGES

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum updated this revision to Diff 209084. quantum added a comment. Add tests for `__builtin_wasm_tls_size`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files:

[PATCH] D63854: NFC: Convert large lambda into method

This revision was automatically updated to reflect the committed changes. Closed by commit rL365708: NFC: Convert large lambda into method (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:198 ++--+--+--++ +| device extension |

r365709 - NFC: Pass DataLayout into isBytewiseValue

Author: vitalybuka Date: Wed Jul 10 15:53:52 2019 New Revision: 365709 URL: http://llvm.org/viewvc/llvm-project?rev=365709=rev Log: NFC: Pass DataLayout into isBytewiseValue Summary: We will need to handle IntToPtr which I will submit in a separate patch as it's not going to be NFC. Reviewers:

r365708 - NFC: Convert large lambda into method

Author: vitalybuka Date: Wed Jul 10 15:53:50 2019 New Revision: 365708 URL: http://llvm.org/viewvc/llvm-project?rev=365708=rev Log: NFC: Convert large lambda into method Reviewers: pcc, eugenis Reviewed By: eugenis Subscribers: cfe-commits, lldb-commits Tags: #clang, #lldb Differential

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL365706: GodeGen, NFC: Add test to track emitStoresForConstant behavior (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r365706 - GodeGen, NFC: Add test to track emitStoresForConstant behavior

Author: vitalybuka Date: Wed Jul 10 15:47:07 2019 New Revision: 365706 URL: http://llvm.org/viewvc/llvm-project?rev=365706=rev Log: GodeGen, NFC: Add test to track emitStoresForConstant behavior Reviewers: eugenis, pcc Reviewed By: eugenis Subscribers: cfe-commits Tags: #clang Differential

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

vsk created this revision. vsk added reviewers: djtodoro, aprantl. Replace a `llvm::Function *` parameter with a bool, which seems harder to set to the wrong value by accident. https://reviews.llvm.org/D64540 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h Index:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:207 ++--+--+--++ +| device extension | clause:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:184 ++--+--+--++ +| task extension |

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:247 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) {

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:246-271 +auto StylesheetPathWrite = getInfoOutputFile( +OutDirectory, "", "clang-doc-default-stylesheet", ".css"); +if (!StylesheetPathWrite) { + llvm::errs()

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579561 , @rnk wrote: > An extremely convenient feature of the current escaping pattern is that it > magically works for both the cmd shell and various bash implementations. You > can simply copy paste the commands and

[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

tra accepted this revision. tra added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:4973-4992 case CudaArch::GFX600: case CudaArch::GFX601: case CudaArch::GFX700: case CudaArch::GFX701: case CudaArch::GFX702: case CudaArch::GFX703: case

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/init-memset.c:36 + int a[16] = {0, 0, 1}; + // CHECK: call void @llvm.memset.{{.*}} + // CHECK: store i32 1 eugenis wrote: > Would it be useful to

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

This revision was automatically updated to reflect the committed changes. Closed by commit rL365703: driver: Dont warn about assembler flags being unused when not assembling (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. A default css stylesheet is included for docs generated in html format. Depends on

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a subscriber: phosek. smeenai added a comment. CC @phosek, since I believe you had issues writing tests referencing the installation directory in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/

r365703 - driver: Don't warn about assembler flags being unused when not assembling

Author: nico Date: Wed Jul 10 15:29:35 2019 New Revision: 365703 URL: http://llvm.org/viewvc/llvm-project?rev=365703=rev Log: driver: Don't warn about assembler flags being unused when not assembling clang currently warns when passing flags for the assembler (e.g. -Wa,-mbig-obj) to an invocation

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579510 , @smeenai wrote: > Hmm, this only fixes `-###`. Looking into `-v` now. Ignore this – I was testing with a version without my change :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. Hmm, this only fixes `-###`. Looking into `-v` now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538 ___ cfe-commits mailing list

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai created this revision. smeenai added reviewers: compnerd, hans, mstorsjo, rnk, thakis, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escaping backslashes results in unnatural looking output, and the actual escapes are mostly unnecessary. We were also not

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum planned changes to this revision. quantum added a comment. Need to add tests for the compiler intrinsic `__builtin_wasm_tls_size`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak marked 3 inline comments as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:6097 + // non-trivial to copy or default-initialize. + checkNonTrivialCUnionInInitList(ILE); + } rjmccall wrote: > Can we extract a common

[PATCH] D64537: [WebAssembly] Implement thread-local storage for non-PIC cases

quantum created this revision. quantum added reviewers: tlively, aheejin, kripken, sbc100. Herald added subscribers: llvm-commits, cfe-commits, jfb, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. quantum planned changes to this revision. quantum added a

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added a comment. In D64454#1579466 , @Nathan-Huckleberry wrote: > Docs exist for these checks on the analyzer side, they're just all on the > same page and hyperlinking to them individually is difficult because the > links have a

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1579365 , @lebedev.ri wrote: > In D64454#1579336 , @Eugene.Zelenko > wrote: > > > May be script should generate documentation during build, so files .rst > > files

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:163 ++--+--+--++ +| memory mangagement | allocate

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

This revision was automatically updated to reflect the committed changes. Closed by commit rL365700: [clang-scan-deps] Dependency directives source minimizer: (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert updated this revision to Diff 209073. jdoerfert marked 29 inline comments as done. jdoerfert added a comment. Add colors, updates according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64375/new/

r365700 - [clang-scan-deps] Dependency directives source minimizer:

Author: arphaman Date: Wed Jul 10 15:00:59 2019 New Revision: 365700 URL: http://llvm.org/viewvc/llvm-project?rev=365700=rev Log: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix The single quote character can

[PATCH] D61749: [clang-tidy] initial version of readability-const-method

lebedev.ri resigned from this revision. lebedev.ri added a comment. Sorry, it does not appear that i'm being useful in this review. Comment at: clang-tools-extra/clang-tidy/readability/StaticMethodCheck.cpp:89-101 + isDefinition(), isUserProvided(),

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. *ping* Is it ok to proceed with only checking the new PM output for these tests? If so I could just edit my previous patch to remove the legacy PM run lines since they already include the bitcasts from the new PM. CHANGES SINCE LAST ACTION

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang marked 4 inline comments as done. czhang added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:40 +return; + Finder->addMatcher(varDecl().bind("var"), this); +} aaron.ballman wrote: > czhang

[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64364/new/ https://reviews.llvm.org/D64364 ___ cfe-commits mailing list

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang updated this revision to Diff 209071. czhang added a comment. Hoist constant initializer check and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 Files:

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp:270 +

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

vsk requested changes to this revision. vsk added a comment. This revision now requires changes to proceed. Herald added a project: clang. (Marking this to reflect my comment from 3/20/18 to clear my review queue) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

lebedev.ri added a comment. In D64454#1579336 , @Eugene.Zelenko wrote: > May be script should generate documentation during build, so files .rst files > are not needed? I'd personally weakly advise against that, to be honest; that would not be

[PATCH] D40381: Parse concept definition

saar.raz updated this revision to Diff 209068. saar.raz added a comment. Final committed diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 Files: include/clang/AST/ASTNodeTraverser.h include/clang/AST/DeclTemplate.h

[PATCH] D53578: [CodeGen] Fix clang test for gcov profiling (follow-up of D51974)

vsk resigned from this revision. vsk added a comment. Herald added a project: clang. (Clearing my review queue - I believe the parent revision D51974 has been accepted, perhaps @marco-c can take a look) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added a comment. May be script should generate documentation during build, so files .rst files are not needed? Please also insert empty line between header (===) and text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/

[PATCH] D63940: [NFC] Pass DataLayout into isBytewiseValue

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63940/new/ https://reviews.llvm.org/D63940

r365699 - [Concepts] Concept definitions (D40381)

Author: saar.raz Date: Wed Jul 10 14:25:49 2019 New Revision: 365699 URL: http://llvm.org/viewvc/llvm-project?rev=365699=rev Log: [Concepts] Concept definitions (D40381) First in a series of patches to land C++2a Concepts support. This patch adds AST and parsing support for concept-declarations.

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

NP, I forgot to follow up mentioning that I tweaked the test to fix the failure in https://reviews.llvm.org/rC365557. It would be good to eventually mangle whatever OpenCL thing is being mangled here in the MS ABI, but that can be future work. On Wed, Jul 10, 2019 at 2:45 AM Marco Antognini

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry marked an inline comment as done. Nathan-Huckleberry added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/clang-analyzer-apiModeling.StdCLibraryFunctions.rst:7 +The clang-analyzer-apiModeling.StdCLibraryFunctions check is an alias,

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

rjmccall added a comment. I agree that we really shouldn't use most of those — we shouldn't have null types or null child expressions anywhere in the AST. (Accessors might return null for *optional* children, of course, but that's different.) And yeah, a big part of that would be having an

[PATCH] D63854: [NFC] Convert large lambda into method

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM if it's really NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63854/new/ https://reviews.llvm.org/D63854

[PATCH] D64385: GodeGen, NFC: Add test to track emitStoresForConstant behavior

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/init-memset.c:36 + int a[16] = {0, 0, 1}; + // CHECK: call void @llvm.memset.{{.*}} + // CHECK: store i32 1 Would

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Windows seems to work. Good job! Linux works with static libraries, but not with `BUILD_SHARED_LIBS=ON`: $ bin/opt : CommandLine Error: Option

  1   2   3   >