r365873 - [test] Delete trailing spaces from YAML tests

2019-07-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Jul 11 22:59:28 2019 New Revision: 365873 URL: http://llvm.org/viewvc/llvm-project?rev=365873=rev Log: [test] Delete trailing spaces from YAML tests Modified: cfe/trunk/unittests/Tooling/DiagnosticsYamlTest.cpp

r365872 - test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available

2019-07-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Jul 11 22:51:36 2019 New Revision: 365872 URL: http://llvm.org/viewvc/llvm-project?rev=365872=rev Log: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available Follow-up of D64317/r365587. Modified:

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

2019-07-11 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. The `impure-warning` sounds like some alpha, not-well-defined warning, other than that I like the movement to rethink existing checkers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64614 Files:

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. This is an issue I noticed while writing the unit test for D64308 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/test/type-hierarchy.test:1 # RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64613 Files:

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. nridge marked 3 inline comments as done. Closed by commit rL365867: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

2019-07-11 Thread Nathan Ridge via cfe-commits
Author: nridge Date: Thu Jul 11 20:26:32 2019 New Revision: 365867 URL: http://llvm.org/viewvc/llvm-project?rev=365867=rev Log: [clangd] Implement typeHierarchy/resolve for subtypes Summary: This allows the client to resolve subtypes one level at a time. For supertypes, this is not necessary,

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

2019-07-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + Mordante wrote: > rjmccall wrote: > > Comment indentation. > > > > Should we do this when starting to parse a function prototype instead of > > when

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

2019-07-11 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. The followup patch for this change is at https://reviews.llvm.org/D64598. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

2019-07-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. There are some code paths that I think are common between the parser and template instantiation, like `BuildPointerType` and `BuildReferenceType`, but if you want to do context-sensitive inference that might not be good enough. CHANGES SINCE LAST ACTION

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

2019-07-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(),

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This should be rebased after D64294 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365866: [X86][PowerPC] Support -mlong-double-128 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r365866 - [X86][PowerPC] Support -mlong-double-128

2019-07-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Jul 11 19:32:15 2019 New Revision: 365866 URL: http://llvm.org/viewvc/llvm-project?rev=365866=rev Log: [X86][PowerPC] Support -mlong-double-128 This patch makes the driver option -mlong-double-128 available for X86 and PowerPC. The CC1 option -mlong-double-128 is

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 209404. MaskRay added a comment. Use A->render(Args, CmdArgs); Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. (authored by dergachev, committed by ). Herald added a

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks all! I guess i'll commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 209401. vitalybuka added a comment. undo unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp

r365863 - NFC: Unforget a colon in a few CHECK: directives.

2019-07-11 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Jul 11 19:16:56 2019 New Revision: 365863 URL: http://llvm.org/viewvc/llvm-project?rev=365863=rev Log: NFC: Unforget a colon in a few CHECK: directives. Differential Revision: https://reviews.llvm.org/D64526 Modified:

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 209400. vitalybuka added a comment. 0x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D64597#1581654 , @jfb wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When I discussed

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I did this in rC365862 with a test after my refactoring of the interface rC365860 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/

r365862 - [PowerPC] Default to -fomit-frame-pointer when optimization is enabled

2019-07-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Jul 11 19:14:08 2019 New Revision: 365862 URL: http://llvm.org/viewvc/llvm-project?rev=365862=rev Log: [PowerPC] Default to -fomit-frame-pointer when optimization is enabled NetBSD, Linux, CloudABI and Hurd already omit frame pointer for PowerPC. Make it do so for other

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

2019-07-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ closed this revision. NoQ added a comment. Whoops, forgot the phabricator link. Committed as rC365861 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611

r365861 - [analyzer] exploded-graph-rewriter: Improve source location dumps.

2019-07-11 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Jul 11 19:10:33 2019 New Revision: 365861 URL: http://llvm.org/viewvc/llvm-project?rev=365861=rev Log: [analyzer] exploded-graph-rewriter: Improve source location dumps. - Correctly display macro expansion and spelling locations. - Use the same procedure to display

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365860: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)? (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r365860 - [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

2019-07-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Jul 11 19:01:51 2019 New Revision: 365860 URL: http://llvm.org/viewvc/llvm-project?rev=365860=rev Log: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer Use a tri-state enum to represent shouldUseFramePointer() and

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 209398. MaskRay retitled this revision from "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer" to "[Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer". MaskRay

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer

2019-07-11 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 209396. MaskRay marked 2 inline comments as done. MaskRay retitled this revision from "[Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()" to "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

2019-07-11 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365858: Handle IntToPtr in isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63967?vs=207180=209394#toc Repository: rL LLVM CHANGES SINCE

r365858 - Handle IntToPtr in isBytewiseValue

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 18:42:03 2019 New Revision: 365858 URL: http://llvm.org/viewvc/llvm-project?rev=365858=rev Log: Handle IntToPtr in isBytewiseValue Summary: This helps with more efficient use of memset for pattern initialization From @pcc prototype for

r365857 - Codegen, NFC: 32bit test in auto-var-init.cpp

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 18:36:11 2019 New Revision: 365857 URL: http://llvm.org/viewvc/llvm-project?rev=365857=rev Log: Codegen, NFC: 32bit test in auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL:

Re: [PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Nick Desaulniers via cfe-commits
Yes, the current behavior is erroring for assembler flags clang does not recognize, which is irrelevant when compiling with `-no-integrated-as`, which is breaking our assembler flag feature detection in building the Linux kernel. On Thu, Jul 11, 2019, 6:09 PM Reid Kleckner via Phabricator <

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

2019-07-11 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Much better! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

2019-07-11 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum marked 28 inline comments as done. quantum added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + tlively wrote: > quantum

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

2019-07-11 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum updated this revision to Diff 209391. quantum marked 10 inline comments as done. quantum added a comment. Apply review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files:

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I think the intention of this change was to ignore assembler flags in pre-processing actions without warning about them. It implements that behavior by running the code that gathers and validates assembler flags. The validation is whats emitting the problematic errors. I

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-11 Thread Bob Haarman via Phabricator via cfe-commits
inglorion added a comment. This was suggested on D64458 . If we take this change, D64458 can be simplified to just accepting -fthinlto-index= as a CoreOption without needing any further changes to Driver.cpp. I also changed

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555 + // in -E mode either for example, even though it's not really used either. + if (!isa(JA)) { +ArgStringList DummyArgs; Should you be checking

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

2019-07-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. - Correctly display macro expansion and spelling locations. - Use the

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

2019-07-11 Thread Bob Haarman via Phabricator via cfe-commits
inglorion created this revision. inglorion added reviewers: tejohnson, rnk, pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. Previously, passing -fthinlto-index= to clang required that bitcode files be explicitly marked by -x ir. This

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. ah, maybe the addition of `-no-integrated-as` shouldn't produce this error? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. > This change breaks building the Linux kernel for arm32 (at least): Follow up discussion in https://github.com/ClangBuiltLinux/linux/issues/598. I think the kernel is wrong here. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

2019-07-11 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added reviewers: Pierre, Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64608 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

2019-07-11 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. Just to make sure we're on the same page (and sorry I didn't jump in sooner)... With the old PM, *anything* that is `always_inline` *gets* `instsimplify` run on it, even at -O0, even if you didn't want that. So using `-instsimplify` explicitly is, IMO, not any more

r365850 - Re-Revert Devirtualize destructor of final class.

2019-07-11 Thread Jordan Rupprecht via cfe-commits
Author: rupprecht Date: Thu Jul 11 17:32:08 2019 New Revision: 365850 URL: http://llvm.org/viewvc/llvm-project?rev=365850=rev Log: Re-Revert Devirtualize destructor of final class. This reverts r365509 (git commit d088720edad9c29ee0d622b5d69092e18a9ac0bd) This is a second revert[1] due to

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

2019-07-11 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry updated this revision to Diff 209381. Nathan-Huckleberry added a comment. - Ran git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 Files:

[PATCH] D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

2019-07-11 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 209379. yonghong-song added a subscriber: anakryiko. yonghong-song added a comment. change test case so we can test metadata is generated correctly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64598/new/

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

2019-07-11 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Sorry for the delay here. It'd be nice to land the LLVM patch first and with its own testing -- we should have testing for the pass builder independent of Clang (IE, in the

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

2019-07-11 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Lexer::getLocForEndOfToken is defined to return an invalid location if the given location is inside a macro. Other checks conditionally warn based off location validity.

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

2019-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365849: [clangd] Add a missing early return in getTypeHierarchy() (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365849 - [clangd] Add a missing early return in getTypeHierarchy()

2019-07-11 Thread Nathan Ridge via cfe-commits
Author: nridge Date: Thu Jul 11 17:24:45 2019 New Revision: 365849 URL: http://llvm.org/viewvc/llvm-project?rev=365849=rev Log: [clangd] Add a missing early return in getTypeHierarchy() Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

2019-07-11 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum updated this revision to Diff 209376. quantum added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

r365845 - [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

2019-07-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Jul 11 16:49:39 2019 New Revision: 365845 URL: http://llvm.org/viewvc/llvm-project?rev=365845=rev Log: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

2019-07-11 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365845: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365844 - [clangd] Fix MSVC build failure.

2019-07-11 Thread Paul Robinson via cfe-commits
Author: probinson Date: Thu Jul 11 16:48:06 2019 New Revision: 365844 URL: http://llvm.org/viewvc/llvm-project?rev=365844=rev Log: [clangd] Fix MSVC build failure. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26898 Modified:

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

2019-07-11 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64605/new/ https://reviews.llvm.org/D64605 ___

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

2019-07-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will be stripped away during

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

2019-07-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with suggestion Comment at: lib/Driver/ToolChains/Clang.cpp:4009 TC.getArch() == llvm::Triple::ppc || TC.getTriple().isPPC64()) { -

[PATCH] D64062: Remove both -dumpversion and __VERSION__

2019-07-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D64062#1581662 , @sylvestre.ledru wrote: > In D64062#1581290 , @rnk wrote: > > > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. > > > As you wish. clang --version

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

2019-07-11 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1448 +def RequireDesignatedInitDocs : Documentation { + let Category = DocCatType; aaron.ballman wrote: > The behavior should be documented as to what happens when you apply

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

2019-07-11 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. In D64448#1581771 , @gribozavr wrote: > In D64448#1581719 , @mgehre wrote: > > > In D64448#159 , @gribozavr > > wrote: > > > > > I don't know

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

2019-07-11 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre updated this revision to Diff 209370. mgehre marked 9 inline comments as done. mgehre added a comment. - Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64448/new/ https://reviews.llvm.org/D64448 Files:

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

2019-07-11 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 209369. tlively added a comment. - and other comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

2019-07-11 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 209367. tlively added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D64586: [WebAssembly] Make pthread imply bulk-memory, mutable-globals

2019-07-11 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 209365. tlively added a comment. - Add mutable-globals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64586/new/ https://reviews.llvm.org/D64586 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

2019-07-11 Thread Shaurya Gupta via Phabricator via cfe-commits
SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:410 +// Test for functions toHalfOpenFileRange and getHalfOpenFileRange +// FIXME: Need better testing support to be able to check more than just Decls. +TEST(SourceCodeTests,

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

2019-07-11 Thread Shaurya Gupta via Phabricator via cfe-commits
SureYeaah updated this revision to Diff 209363. SureYeaah marked 12 inline comments as done. SureYeaah added a comment. Added comments and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

2019-07-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This change unifies the long double format between x86_64 and aarch64 targets making it easier to write code that's

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

2019-07-11 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 209362. emmettneyman marked 2 inline comments as done. emmettneyman added a comment. Added documentation about using the attributes with unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

2019-07-11 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre updated this revision to Diff 209360. mgehre added a comment. Implement comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static

2019-07-11 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre added a comment. This should address all remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 ___ cfe-commits mailing list

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

2019-07-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:486 +TYPE_TRAIT_1(__is_gsl_owner, IsGslOwner, KEYCXX) +TYPE_TRAIT_1(__is_gsl_pointer, IsGslPointer, KEYCXX) KEYWORD(__underlying_type , KEYCXX) mgehre wrote: >

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

2019-07-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added a comment. In D64448#1581719 , @mgehre wrote: > In D64448#159 , @gribozavr wrote: > > > I don't know how various versions of libstdc++ differ. > > > The current implementation passed the

[PATCH] D62888: [NewPM] Port Sancov

2019-07-11 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365838: [NewPM] Port Sancov (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D62888?vs=207698=209358#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

r365838 - [NewPM] Port Sancov

2019-07-11 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Thu Jul 11 15:35:40 2019 New Revision: 365838 URL: http://llvm.org/viewvc/llvm-project?rev=365838=rev Log: [NewPM] Port Sancov This patch contains a port of SanitizerCoverage to the new pass manager. This one's a bit hefty. Changes: - Split SanitizerCoverageModule

[PATCH] D64458: add -fthinlto-index= option to clang-cl

2019-07-11 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. LGTM, but please wait for @pcc to make sure he is satisfied. I think it would be good to port the file type deduction to clang (possibly as a follow on), to make these consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

2019-07-11 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + quantum wrote: > quantum wrote: > > aheejin wrote: > > > Why is it

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

2019-07-11 Thread Matthias Gehre via Phabricator via cfe-commits
mgehre marked 5 inline comments as done. mgehre added a comment. In D64448#159 , @gribozavr wrote: > For example, libc++ wraps everything in std in an inline namespace. I believed that I had written a test for inline namespaces, but seems that I

[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

2019-07-11 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: clang/lib/AST/ExprVM/Compiler.cpp:85 +/* isArray */ false, +/* isGlobal */ false); + ParamDescriptors.insert({ParamOffset,

[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

2019-07-11 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman, steven_wu. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This attribute can be applied to typedefs of BOOL in Objective-C. It causes loads, stores, and casts to BOOL

r365835 - CodeGen: Suppress c++ warnings in test

2019-07-11 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Jul 11 14:59:09 2019 New Revision: 365835 URL: http://llvm.org/viewvc/llvm-project?rev=365835=rev Log: CodeGen: Suppress c++ warnings in test Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp URL:

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

2019-07-11 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 209348. Mordante added a comment. tab -> space adds an extra unit test for lambdas fixes an off by one error found while testing the lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://reviews.llvm.org/D63975 Files:

[PATCH] D64062: Remove both -dumpversion and __VERSION__

2019-07-11 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. In D64062#1581290 , @rnk wrote: > Perhaps we should just remove `__VERSION__` and keep `-dumpversion`. As you wish. clang --version seems an alternative and dumpversion never //worked// for clang. so, I don't expect

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

2019-07-11 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + rjmccall wrote: > Comment indentation. > > Should we do this when starting to parse a function prototype

r365832 - Fix a Python3 compatibility error

2019-07-11 Thread Azharuddin Mohammed via cfe-commits
Author: azhar Date: Thu Jul 11 14:45:48 2019 New Revision: 365832 URL: http://llvm.org/viewvc/llvm-project?rev=365832=rev Log: Fix a Python3 compatibility error File "clang/test/lit.cfg.py", line 186, in config.available_features.add('macos-sdk-' + macOSSDKVersion) TypeError: must be str,

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

2019-07-11 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D64597#1581605 , @pcc wrote: > The problem with `0x` on 32-bit is that it is likely to be a valid > address. > > When I discussed this with JF I proposed a pointer initialization of > `0x` which he agreed to. This

[PATCH] D64278: Rename libclang_shared to libclang-cpp

2019-07-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365831: Rename libclang_shared to libclang-cpp (authored by sylvestre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365831 - Rename libclang_shared to libclang-cpp

2019-07-11 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Thu Jul 11 14:42:55 2019 New Revision: 365831 URL: http://llvm.org/viewvc/llvm-project?rev=365831=rev Log: Rename libclang_shared to libclang-cpp Summary: Fix bug 42475 Reviewers: beanz, tstellar Reviewed By: beanz Subscribers: kimgr, mgorny, cfe-commits Tags: #clang

[PATCH] D62888: [NewPM] Port Sancov

2019-07-11 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, thanks so much for sticking through this, I know it was ... nontrivial! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/

[PATCH] D64278: Rename libclang_shared to libclang-cpp

2019-07-11 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is fine with me. I have no real attachment to the name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

2019-07-11 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64582/new/ https://reviews.llvm.org/D64582 ___ cfe-commits mailing list

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xAAAAAAAA

2019-07-11 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. The problem with `0x` on 32-bit is that it is likely to be a valid address. When I discussed this with JF I proposed a pointer initialization of `0x` which he agreed to. This value is very likely to trap when accessed (due to accesses likely wrapping to

r365827 - [analyzer] exploded-graph-rewriter: Fix filenames in program point.

2019-07-11 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Thu Jul 11 14:27:42 2019 New Revision: 365827 URL: http://llvm.org/viewvc/llvm-project?rev=365827=rev Log: [analyzer] exploded-graph-rewriter: Fix filenames in program point. Fix a typo in JSON field name. Modified:

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-11 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In D64579#1581557 , @beanz wrote: > Yea, this makes sense even if it is a bit sad. We do use the > `--whole-archive` approach for `libLLVM`, and it works. I was hoping to avoid > it here in part to free up the ability to link

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-11 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365825: [clang-shlib] Fix clang-shlib for PRIVATE dependencies (authored by smeenai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-11 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Thu Jul 11 14:20:38 2019 New Revision: 365825 URL: http://llvm.org/viewvc/llvm-project?rev=365825=rev Log: [clang-shlib] Fix clang-shlib for PRIVATE dependencies Any static library with a PRIVATE dependency ends up with a $ generator expression in its

  1   2   3   >