[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1052 +// to return that every time. +if (N->getCFG().isLinear()) + WouldEventBeMeaningless = true; This time i'd rather go for "has exactly 3

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64283/new/ https://reviews.llvm.org/D64283 ___ cfe-commits

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay added a comment. Woohoo, this is the last :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64283/new/ https://reviews.llvm.org/D64283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, looks good! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:146-149 + ///This is useful, because for non-tracked regions,

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeah, i think this is good to go :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64287/new/ https://reviews.llvm.org/D64287

[PATCH] D63954: Add lifetime categories attributes

mgehre updated this revision to Diff 209750. mgehre marked 23 inline comments as done. mgehre added a comment. - Don't crash when pretty-printing an Attribute with optional type argument - Don't crash AST dump when Owner/Pointer has no Type argument - gsl::Owner/gsl::Pointer: Make DerefType

[PATCH] D63954: Add lifetime categories attributes

mgehre added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2770 +def Owner : InheritableAttr { + let Spellings = [CXX11<"gsl", "Owner">]; + let Subjects = SubjectList<[CXXRecord]>; aaron.ballman wrote: > xazax.hun wrote: > > aaron.ballman

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/uninit-vals.c:181 void testUseHalfPoint() { - struct Point p = getHalfPoint(); // expected-note{{Calling 'getHalfPoint'}} - //

[PATCH] D64048: [TargetParser][ARM] Account dependencies when processing target features

This revision was automatically updated to reflect the committed changes. Closed by commit rL366031: [TargetParser][ARM] Account dependencies when processing target features (authored by alelab01, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

r366031 - [TargetParser][ARM] Account dependencies when processing target features

Author: alelab01 Date: Sun Jul 14 13:31:15 2019 New Revision: 366031 URL: http://llvm.org/viewvc/llvm-project?rev=366031=rev Log: [TargetParser][ARM] Account dependencies when processing target features Teaches ARM::appendArchExtFeatures to account dependencies when processing target features:

r366029 - Fix uninitialized variable analyzer warning. NFCI.

Author: rksimon Date: Sun Jul 14 12:13:09 2019 New Revision: 366029 URL: http://llvm.org/viewvc/llvm-project?rev=366029=rev Log: Fix uninitialized variable analyzer warning. NFCI. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

[PATCH] D64676: Support __seg_fs and __seg_gs on x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL366028: Support __seg_fs and __seg_gs on x86 (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63936: [clang][Driver][ARM] Favor -mfpu over default CPU features

This revision was automatically updated to reflect the committed changes. Closed by commit rL366027: [clang][Driver][ARM] Favor -mfpu over default CPU features (authored by alelab01, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

r366028 - Support __seg_fs and __seg_gs on x86

Author: jfb Date: Sun Jul 14 11:33:51 2019 New Revision: 366028 URL: http://llvm.org/viewvc/llvm-project?rev=366028=rev Log: Support __seg_fs and __seg_gs on x86 Summary: GCC supports named address spaces macros: https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html clang does as well

r366027 - [clang][Driver][ARM] Favor -mfpu over default CPU features

Author: alelab01 Date: Sun Jul 14 11:32:42 2019 New Revision: 366027 URL: http://llvm.org/viewvc/llvm-project?rev=366027=rev Log: [clang][Driver][ARM] Favor -mfpu over default CPU features When processing the command line options march, mcpu and mfpu, we store the implied target features on a

r366024 - consistency in the release notes

Author: sylvestre Date: Sun Jul 14 11:25:09 2019 New Revision: 366024 URL: http://llvm.org/viewvc/llvm-project?rev=366024=rev Log: consistency in the release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D64075: [ASTImporter] Fix structural eq of lambdas

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Gabor, This patch looks good to me. Regarding the related patch: can we use getLambdaManglingNumber() for the comparison? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Szelethus added a comment. In D64271#1576872 , @NoQ wrote: > I'd rather not abandon this patch, because it looks like a strict improvement > over the lack of condition tracking, and it might as well still be an > improvement over "zealous" condition

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan marked an inline comment as done. Manikishan added a comment. In D64695#1584706 , @MyDeveloperDay wrote: > There also seems like alot of duplication between the existing sortCppIncludes > > I think the only difference here is really just > >

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

Szelethus added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64272/new/ https://reviews.llvm.org/D64272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

Szelethus marked 2 inline comments as done. Szelethus added a comment. Would you say it's good to go? :) Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1436-1437 -} -ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE->IgnoreParenCasts(), -

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64232/new/ https://reviews.llvm.org/D64232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:120 + enum FramePointerKind { +FP_All, // Keep all frame pointers. We can probably use `enum class FramePointerKind { None, NonLeaf, All };` here.. (`enum class

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added a comment. There also seems like alot of duplication between the existing sortCppIncludes I think the only difference here is really just SmallVector Indices; SmallVector Includes_p; for (unsigned i = 0, e = Includes.size(); i != e; ++i) { unsigned pl =

[PATCH] D64278: Rename libclang_shared to libclang-cpp

sylvestre.ledru added a comment. @beanz By the way, maybe we should add this in the 9 release notes? Thanks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

Manikishan added a comment. In D64695#1584630 , @MyDeveloperDay wrote: > Do you think there is anything about this algorithm that could be > parameterized so that other projects could utilize it? I think we can take input from users the header files

[PATCH] D64695: [clang-format] Added new style rule: SortNetBSDIncludes

MyDeveloperDay added a comment. Do you think there is anything about this algorithm that could be parameterized so that other projects could utilize it? I guess its not completely clear how this differs from just using the IncludeCategories? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 209715. sylvestre.ledru added a comment. Implement the change (just update __VERSION__) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/LanguageExtensions.rst

r366013 - [Driver] Simplify AddLibgcc

Author: maskray Date: Sun Jul 14 00:16:13 2019 New Revision: 366013 URL: http://llvm.org/viewvc/llvm-project?rev=366013=rev Log: [Driver] Simplify AddLibgcc Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Modified: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp URL:

r366012 - [Driver] Simplify -lgcc & -lgcc_s

Author: maskray Date: Sat Jul 13 23:46:46 2019 New Revision: 366012 URL: http://llvm.org/viewvc/llvm-project?rev=366012=rev Log: [Driver] Simplify -lgcc & -lgcc_s gcc defaults to -shared-libgcc in C++ mode. Letting getLibGccType() return SharedLibGcc simplifies the logic. Modified: