[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void updated this revision to Diff 212079. void added a comment. Don't emit errors here. Wait until codegen. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 Files: lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmtAsm.cpp tes

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

thakis added a comment. Thanks for sharing! (And for the fix, and apologies for breaking you.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64301/new/ https://reviews.llvm.org/D64301 ___ cfe-commits mailing list cfe-

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:266 +-++--+ -| Organize Includes | No | No | +| Organize Includes

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

thakis added a comment. In D65233#1603741 , @bjope wrote: > I made another fixup (similar to https://reviews.llvm.org/rL367176) here > https://reviews.llvm.org/rL367182. > > Can someone please take a look (a post-commit review) of > https://reviews.llvm.

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65373 Files: clang-tools-extra/docs/clan

[PATCH] D64922: [clangd] Added option to enable semantic highlighting via an experimental capability

nridge added a comment. I believe this is not necessary. You can add text document capabilities in the vscode client extension like this: class SemanticHighlightingFeature implements vscodelc.StaticFeature { fillClientCapabilities(capabilities: vscodelc.ClientCapabilities): void { co

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void updated this revision to Diff 212072. void added a comment. Save checking of immediates until code generation. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 Files: lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmtAsm.cp

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

phosek added a comment. In D65233#1603741 , @bjope wrote: > I made another fixup (similar to https://reviews.llvm.org/rL367176) here > https://reviews.llvm.org/rL367182. > > Can someone please take a look (a post-commit review) of > https://reviews.llvm.

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

risa2000 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:190 +if(CMAKE_CONFIGURATION_TYPES) + string(REPLACE "${CMAKE_CFG_INTDIR}" "$" output_dir "${output_dir}") beanz wrote: > I think this will break Xcode I guess I put it in since it see

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

bjope added a comment. I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182. Can someone please take a look (a post-commit review) of https://reviews.llvm.org/rL367182 to verify that I did not misunderstand the intention with the test someh

r367182 - [Driver] Additional fixup of NOWARN test case from r367165

Author: bjope Date: Sat Jul 27 13:22:47 2019 New Revision: 367182 URL: http://llvm.org/viewvc/llvm-project?rev=367182&view=rev Log: [Driver] Additional fixup of NOWARN test case from r367165 Same kind of fix as in r367176, but for "RUN on line 76" this time. I'll ask for a post-commit review, to

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

phosek added a comment. In D65233#1603653 , @thakis wrote: > phosek: In what config / on what bot? It's our toolchain linux-x86 builder, see https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8906751725919481408, mac-x86 has been work

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

llunak created this revision. llunak added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an updated patch from https://bugs.llvm.org/show_bug.cgi?id=15614. See there for testcase etc. Repository: rC Clang https://reviews.llvm.org/D65371 F

[PATCH] D64656: Ensure placeholder instruction for cleanup is created

oydale abandoned this revision. oydale added a comment. compnerd added a triple to the test case and re-committed the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64656/new/ https://reviews.llvm.org/D64656 ___

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

joerg added a comment. I understand, but the current version just doesn't work anyway to delay it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 ___ cfe-commits mailing list

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 updated this revision to Diff 212065. boga95 marked 16 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Ping. Seems like @rsmith is busy, so I added @jfb as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a subscriber: jfb. xbolva00 added a comment. Adding @jfb as reviewer to get more opinions what should be done next.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63139/new/ https://reviews.llvm.org/D63139 ___ cfe-commits mai

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

xbolva00 added a comment. Ping again Is ‘CaseStmt´ AST C++ issue is a blocker for this patch or not? I would like to move forward - either land it or (if blocker) abandon it. If it is blocking issue, I can enable it for C only (better than nothing).. CHANGES SINCE LAST ACTION https://review

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212061. nicolas added a comment. Add a default value for `FunctionProtoType::getEllipsisLoc` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[clang-tools-extra] r367178 - [clangd] Fix NDEBUG build problem introduced by rL366698

Author: bjope Date: Sat Jul 27 10:09:15 2019 New Revision: 367178 URL: http://llvm.org/viewvc/llvm-project?rev=367178&view=rev Log: [clangd] Fix NDEBUG build problem introduced by rL366698 Sprinkled some #ifndef NDEBUG in Selection.cpp to make it possible to build with NDEBUG defined. The proble

r367177 - [Driver] Fix "unannotated fall-through between switch labels". NFC

Author: bjope Date: Sat Jul 27 10:09:08 2019 New Revision: 367177 URL: http://llvm.org/viewvc/llvm-project?rev=367177&view=rev Log: [Driver] Fix "unannotated fall-through between switch labels". NFC Just a simple fix of Werror problem after r367165. Modified: cfe/trunk/lib/Driver/ToolChains/

r367176 - Attempt to make test in r367165 more robust.

Author: nico Date: Sat Jul 27 09:57:19 2019 New Revision: 367176 URL: http://llvm.org/viewvc/llvm-project?rev=367176&view=rev Log: Attempt to make test in r367165 more robust. Some people were seeing this failure: ``` : 'RUN: at line 83'; clang -mrelax-all -fno-integrated-as /b/s/w/ir/k/llvm-

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

riccibruno added inline comments. Comment at: clang/include/clang/AST/Type.h:4048 +return *getTrailingObjects(); + } + And what if there is no ellipsis ? Shouldn't you do something like `return isVariadic() ? *getTrailingObjects() : SourceLocation();` inst

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212055. nicolas edited the summary of this revision. nicolas added a comment. - `getEllipsisSourceRange` -> `getEllipsisLoc` - Updated the doc comment - Removed `auto` where necessary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://