r367774 - Revert "[OpenMP 5.0] Codegen support for user-defined mappers."

Author: meinersbur Date: Sat Aug 3 22:16:52 2019 New Revision: 367774 URL: http://llvm.org/viewvc/llvm-project?rev=367774=rev Log: Revert "[OpenMP 5.0] Codegen support for user-defined mappers." This reverts commit r367773. The test case OpenMP/declare_mapper_codegen.cpp is failing. Modified:

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

This revision was automatically updated to reflect the committed changes. Closed by commit rL367773: [OpenMP 5.0] Codegen support for user-defined mappers. (authored by Meinersbur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r367773 - [OpenMP 5.0] Codegen support for user-defined mappers.

Author: meinersbur Date: Sat Aug 3 21:18:42 2019 New Revision: 367773 URL: http://llvm.org/viewvc/llvm-project?rev=367773=rev Log: [OpenMP 5.0] Codegen support for user-defined mappers. This patch implements the code generation for OpenMP 5.0 declare mapper (user-defined mapper) constructs. For

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213221. plotfi added a comment. Fix a linux typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D65708: [NFC][DirectoryWatchedTests] Unlocking mutexes before signaling condition variable.

plotfi created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi added reviewers: compnerd, jkorous. Herald added a subscriber: dexonsmith. This should not affect actual behavior, but should pessimize the threading less by avoiding the situation where:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi added a comment. In D65704#1613688 , @compnerd wrote: > Rather than silently ignoring tests when the DirectoryWatcher isn't created, > can you please print an error message and exit with an error code to indicate > the test failed?

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213218. plotfi added a comment. More cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

nridge added a comment. Do you plan to support text decorations other than color, e.g. bold / underline / italic? Are users going to be able to tweak the color (and other decoration options) for specific highlightings in the VSCode Settings? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

compnerd added a comment. BTW, I think that we should add a test case to ensure that we see the error in the case that the inotify fds are exhausted. We should be able to create a process and set the limit for that process to 0/1 and use that to trigger the failure. Repository: rG LLVM

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

compnerd added a comment. Rather than silently ignoring tests when the DirectoryWatcher isn't created, can you please print an error message and exit with an error code to indicate the test failed? Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:331 +

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:103-105 + // A local variable cannot be odr-used (6.2) in a default argument. + if (DRE->isNonOdrUse() != NOUR_None) +return false; Please add tests for the distinction

[PATCH] D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request

nridge added a comment. Thanks for having a look! I filed an issue so some folks who don't necessarily have an LLVM Phabricator account can weigh in, let's continue the discussion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65706: [docs] Better documentation for -Weverything

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/docs/UsersManual.rst:998 +:option:`-Werror`, and also includes the warnings from :option:`-pedantic`. Some +diagnostics contradict each other, users of :option:`-Weverything` therefore +often

[PATCH] D65706: [docs] document -Weveything more betterer

jfb updated this revision to Diff 213212. jfb added a comment. - Missing 'of' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65706/new/ https://reviews.llvm.org/D65706 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst

[PATCH] D65706: [docs] document -Weveything more betterer

lebedev.ri added inline comments. Comment at: clang/docs/UsersManual.rst:998 +:option:`-Werror`, and also includes the warnings from :option:`-pedantic`. Some +diagnostics contradict each other, users :option:`-Weverything` therefore often +disable many diagnostics such as

[PATCH] D65706: [docs] document -Weveything more betterer

jfb created this revision. jfb added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65706 Files: clang/docs/UsersManual.rst Index:

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi updated this revision to Diff 213209. plotfi added a comment. Cleanup some stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65704/new/ https://reviews.llvm.org/D65704 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:32 #include +#include This include should be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi created this revision. plotfi added reviewers: jkorous, compnerd. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. There are cases where the DirectoryWatcherTests just hang in a deadlock when there are inotify limits hit, with no error reporting. This

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny updated this revision to Diff 213197. jdenny added a comment. Note the reproducer in the implementation's FIXME. The other FIXME points there, so I figure it's best not to duplicate the note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61466/new/

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

hfinkel added a comment. Thanks for starting on this. Can you go ahead and replace the sroa calls with mem2reg calls for `O1` and then see what that does to the performance? That strikes me as a major change, but certainly one that potentially makes sense, so I'd rather we go ahead and test it

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1495-1496 // For deque-like containers invalidate all iterator positions. For // vector-like containers invalidate iterator positions after the insertion. const auto *Cont =

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

MaskRay created this revision. MaskRay added reviewers: dalias, phosek, rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. On a musl-based Linux distribution, stdalign.h stdarg.h stdbool.h stddef.h stdint.h stdnoreturn.h are expected to be provided by musl

[PATCH] D65670: Use switch instead of series of comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rL367759: Use switch instead of series of comparisons (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r367759 - Use switch instead of series of comparisons

Author: sepavloff Date: Sat Aug 3 09:32:49 2019 New Revision: 367759 URL: http://llvm.org/viewvc/llvm-project?rev=367759=rev Log: Use switch instead of series of comparisons This is style correction, no functional changes. Differential Revision: https://reviews.llvm.org/D65670 Modified:

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. This implements the current standard wording for [dcl.fct.default]p9 and [dcl.fct.default]p7. This has been changed by CWG 2082. Note: I don't have access to the paper therefore I assume

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specifique semantic

Tyker added a comment. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. The overload resolution for enums with a fixed underlaying type has changed in the C++14 standard. This patch implements the new rule. Note: I don't have access to the CWG 1601 paper, but

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

Romain-Geissler-1A added a comment. Hi, Thanks Serge. Given that I am only a very occasional contributor, I don't have any right to push this commit myself. Would you please commit it for me ? Thanks, Romain Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

Mordante created this revision. Mordante added reviewers: sepavloff, rsmith. Mordante added a project: clang. This fixes https://bugs.llvm.org/show_bug.cgi?id=28500 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65694 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D65693: [driver][riscv] Support riscv64-linux-gnu multiarch paths

aurel32 created this revision. aurel32 added reviewers: asb, jrtc27. aurel32 added projects: clang, LLVM. Herald added subscribers: cfe-commits, s.egerton, lenary, benna, psnobl, PkmX, rkruppe, rogfer01, shiva0217, kito-cheng, simoncook. This change adds support for the `riscv64-linux-gnu`

[PATCH] D65650: [Analyzer] Iterator Checkers - Fix for Crash on Iterator Differences

Szelethus accepted this revision. Szelethus added a comment. Cool! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65650/new/ https://reviews.llvm.org/D65650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org