[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

labath added inline comments. Comment at: clang/test/Driver/vfsmode.py:4 + +# UNSUPPORTED: system-windows + jfb wrote: > I'm not sure what the best way to test this on Windows would be, and without > a machine handy I can't really test this :-( Unsupported might

Re: r368348 - Fix up fd limit diagnosis code

This change broke compiling Qt. A repro case looks like this: mkdir -p fake-qtincl/5.13.1/QtCore/private touch fake-qtincl/5.13.1/QtCore/private/qglobal_p.h touch fake-qtincl/QtCore echo "#include " > qtincl.cpp bin/clang++ -c qtincl.cpp -Ifake-qtincl -Ifake-qtincl/5.13.1 Previously this igno

[PATCH] D65994: Extended FPOptions with new attributes

sepavloff created this revision. sepavloff added reviewers: anemet, kpn, aaron.ballman, hfinkel, rsmith, rjmccall. Herald added a project: clang. This change added two new attributes, rounding mode and exception behavior to the structure FPOptions. These attributes allow more flexible treatment o

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

This revision was automatically updated to reflect the committed changes. Closed by commit rL368399: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368399 - Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

Author: gribozavr Date: Thu Aug 8 23:14:54 2019 New Revision: 368399 URL: http://llvm.org/viewvc/llvm-project?rev=368399&view=rev Log: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit Summary: ASSERT_THAT_ERROR looks like the intended helper for use in tests. Reviewers: plotfi, jkoro

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for bearing with me, JF! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 ___ cfe-commi

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/lib/Driver/Driver.cpp:172 + case VFSMode::Unknown: +if (!this->VFS) { + LLVM_FALLTHROUGH; JDevlieghere wrote: > jfb wrote: > > JDevlieghere wrote: > > > Is this really ne

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214298. jfb marked an inline comment as done. jfb added a comment. - Address more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Dri

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere added inline comments. Comment at: clang/lib/Driver/Driver.cpp:172 + case VFSMode::Unknown: +if (!this->VFS) { + LLVM_FALLTHROUGH; jfb wrote: > JDevlieghere wrote: > > Is this really necessary? > the `Driver` ctor takes a `VFS` parameter w

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214296. jfb marked an inline comment as done. jfb added a comment. - Address more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Dri

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Two small suggestions for the test, but this change LGTM. Comment at: clang/test/Driver/vfsmode.py:33 +new_name_len = target_len - len(absolute) - 1 +new_

[PATCH] D65993: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

plotfi created this revision. plotfi added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes usage of FinalPhase from anywhere outside of the scope where it is used to do argument handling. It also adds argument based tri

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

This revision was automatically updated to reflect the committed changes. Closed by commit rL368393: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions. (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

r368393 - [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions.

Author: zer0 Date: Thu Aug 8 21:55:09 2019 New Revision: 368393 URL: http://llvm.org/viewvc/llvm-project?rev=368393&view=rev Log: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions. I am working to remove this concept of the "FinalPhase" in the clang driver, but it is used

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214292. jfb added a comment. - Undo whitespaces change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/Driver.h clang/include/clang/D

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb added inline comments. Comment at: clang/lib/Driver/Driver.cpp:172 + case VFSMode::Unknown: +if (!this->VFS) { + LLVM_FALLTHROUGH; JDevlieghere wrote: > Is this really necessary? the `Driver` ctor takes a `VFS` parameter which some tools set (other

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214291. jfb marked 6 inline comments as done. jfb added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/D

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

This revision was automatically updated to reflect the committed changes. Closed by commit rL368383: [analyzer] CastValueChecker: Model castAs(), getAs() (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r368383 - [analyzer] CastValueChecker: Model castAs(), getAs()

Author: charusso Date: Thu Aug 8 19:24:42 2019 New Revision: 368383 URL: http://llvm.org/viewvc/llvm-project?rev=368383&view=rev Log: [analyzer] CastValueChecker: Model castAs(), getAs() Summary: Thanks to Kristóf Umann for the great idea! Reviewed By: NoQ Differential Revision: https://review

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

This revision was automatically updated to reflect the committed changes. Closed by commit rL368382: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

r368382 - [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Author: charusso Date: Thu Aug 8 19:20:44 2019 New Revision: 368382 URL: http://llvm.org/viewvc/llvm-project?rev=368382&view=rev Log: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces Summary: A condition could be a multi-line expression where we create the highlight in separated

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung updated this revision to Diff 214278. dyung added a comment. Reverted changes in Clang.cpp and updated test to expect warning when an external assembler is requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://reviews.llvm.org/D65974

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added a comment. Thanks you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:26 class CastValueChecker : public Checker { + enum class CastKind { Checking, Sugar }; + NoQ wrote: > Charusso wrote: > > NoQ wrote: > > > Please explain "Checki

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214277. Charusso marked 6 inline comments as done. Charusso added a comment. - Better naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

Bigcheese closed this revision. Bigcheese added a comment. Fixed and committed as r368381. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65989/new/ https://reviews.llvm.org/D65989 ___ cfe-commits mailing list cfe-com

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders marked 4 inline comments as done. dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:48-51 +for (const auto *UsingDirective: Context->using_directives()) + if (UsingDirective->getNominatedNamespace(

r368381 - [clang-scan-deps] Add minimizer support for C++20 modules.

Author: mspencer Date: Thu Aug 8 19:01:10 2019 New Revision: 368381 URL: http://llvm.org/viewvc/llvm-project?rev=368381&view=rev Log: [clang-scan-deps] Add minimizer support for C++20 modules. This only adds support to the minimizer, it doesn't actually capture the dependencies yet. Modified:

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

arphaman added inline comments. Comment at: unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:577 +TEST(MinimizeSourceToDependencyDirectivesTest, CxxModules) { +SmallVector Out; +SmallVector Tokens; Looks like it's not indented according to clang-

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders updated this revision to Diff 214276. dsanders added a comment. Changed diagnostic message and merged the fixit into the original diagnostic Made the variable names more distinct in the tests Added a test to cover `using namespace llvm` in the global namespace Slight correction to the ite

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

czhang updated this revision to Diff 214275. czhang added a comment. Fix test and formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bu

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65989/new/ https://reviews.llvm.org/D65989 ___ cfe-commit

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::OPT_mrelax_all); dyung

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

Bigcheese created this revision. Bigcheese added a reviewer: arphaman. Herald added subscribers: tschuett, dexonsmith. Herald added a project: clang. This only adds support to the minimizer, it doesn't actually capture the dependencies yet. Repository: rC Clang https://reviews.llvm.org/D6598

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

arphaman added a comment. @aganea These are not just any invisible characters that you have, this is the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of the file (`Lexer::InitLexer`). The minimizer should do the same thing, so ideally you would factor out the BOM detectio

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore marked 3 inline comments as done. stephanemoore added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:820 + llvm::DenseMap> + CompatibleAliases; aaron.ballman wrote: > gribozavr wrote: > > `unordered_set`? > or `SmallPtrS

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, ok! Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:26 class CastValueChecker : public Checker { + enum class CastKind { Checking, Sugar }; +

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore updated this revision to Diff 214272. stephanemoore added a comment. Use `llvm::SmallPtrSet` to store the compatible aliases instead of `std::set`. Fix a stray unit test failure in `RegistryTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D65988: [Clang Tablegen] Fix build when std::string::end() is not assignable

orivej created this revision. orivej added a reviewer: clang. orivej added a project: clang. Herald added subscribers: cfe-commits, kadircet, arphaman. This fixes Clang error: expression is not assignable: Result.erase(--Result.end());

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Path is now stored in the references to the child while serializing, then this path is used to generate the relative path in the HTML generator.

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere added inline comments. Comment at: clang/lib/Driver/Driver.cpp:172 + case VFSMode::Unknown: +if (!this->VFS) { + LLVM_FALLTHROUGH; Is this really necessary? Comment at: clang/lib/Driver/Driver.cpp:980 + // We might tr

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

arphaman added inline comments. Comment at: clang/lib/Driver/Driver.cpp:167 +else + Diag(diag::err_drv_unsupported_option_argument) << OptionPrefix << Value; + } It might be nice to `break` here to exit early, unless you want to make Clang pick the las

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. > Can you post a reproducer? Turns out I just didn't have assertions enabled. With assertions the changed test cases should fail. > I think this is precisely what was discussed in replies to RFC - this > hardcodes these address spaces, and thus either makes them unaval

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/test/Driver/vfsmode.py:4 + +# UNSUPPORTED: system-windows + I'm not sure what the best way to test this on Windows would be, and without a machine handy I can't really test this :

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb created this revision. jfb added reviewers: JDevlieghere, bruno. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. The motivation for 'physical' mode in D58169 was pretty sensible, but it has one unfortunate side-effec

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:325 + ? "llvm.arm.gnu.eabi.mcount" : "\01mcount"; nickdesaulniers wrote: > Doesn't require c

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214263. jcai19 added a comment. Lower the new intrinsic when legalizing DAGs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > is_device_ptr with the private clauses? Yes, since it is allowed by the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ http

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders marked an inline comment as done. dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:53 + } + diag(UserVarDecl->getLocation(), "use '%0'", DiagnosticIDs::Note) + << Replacement aaron.

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

lebedev.ri added a comment. In D64931#1622038 , @akhuang wrote: > @lebedev.ri The test case datalayout strings were changed because somewhere > llvm asserts that the string in the IR matches the backend datalayout. I > don't know why I wasn't getting the

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. @lebedev.ri The test case datalayout strings were changed because somewhere llvm asserts that the string in the IR matches the backend datalayout. I don't know why I wasn't getting the assert error now, but I think they'll all have to be changed if we change the X86 dat

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1621202 , @ABataev wrote: > >> See 2.19.7 Data-Mapping Attribute Rules, Clauses, and Directives > > > > I looked again. I'm still not finding any text in that section that > > implies is_device_ptr follows the same rest

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65978/new/ https://reviews.llvm.org/D65978 ___ cf

Re: r368354 - Mark clang-scan-deps test as requiring thread support

Thanks for fixing this! I think changing clang-scan-deps to ignore -j when `LLVM_ENABLE_THREADS` is probably a better solution. I'll work on a patch that does that. On Thu, 8 Aug 2019 at 15:07, Reid Kleckner wrote: > The specific issue here is that clang-scan-deps uses threads, which seems >

Re: r368354 - Mark clang-scan-deps test as requiring thread support

The specific issue here is that clang-scan-deps uses threads, which seems to work just fine. But, it calls some code that sets up PrettyStackTrace RAII objects, which normally use TLS. And when LLVM_ENABLE_THREADS is off, LLVM_THREAD_LOCAL expands to nothing, so the TLS variables are simply global,

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::OPT_mrelax_all); We sh

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

Jacotot created this revision. Jacotot added reviewers: teemperor, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. The signature "Geode by NSC" for NSC vendor is wrong. In lib/Headers/cpuid.h, signature_NSC_edx and signature_NSC_ecx constants are inverted (cpuid sig

r368354 - Mark clang-scan-deps test as requiring thread support

Author: rnk Date: Thu Aug 8 14:45:59 2019 New Revision: 368354 URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev Log: Mark clang-scan-deps test as requiring thread support Otherwise the test calls a pure virtual method and crashes. Perhaps this could be improved. Modified: cfe/tr

r368348 - Fix up fd limit diagnosis code

Author: rnk Date: Thu Aug 8 14:35:03 2019 New Revision: 368348 URL: http://llvm.org/viewvc/llvm-project?rev=368348&view=rev Log: Fix up fd limit diagnosis code Apparently Windows returns the "invalid argument" error code when the path contains invalid characters such as '<'. The test/Preprocesso

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:26 class CastValueChecker : public Checker { + enum class CastKind { Checking, Sugar }; + NoQ wrote: > Please explain "Checking" and "Sugar". Checking what? Sugar

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214234. Charusso marked 7 inline comments as done. Charusso added a comment. - Added a test case for casting *to* a reference. - Better naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 Files: clang

[PATCH] D65912: [clang-tidy] Add new check for math constants

ZaMaZaN4iK added a comment. The main reason why I've created this differential - asking to you about usefulness of this check for clang-tidy. I understand that there are a some TODO and formatting issues - it's ok for now. As far I understand your remarks - you are not against this check so I c

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

twoh added a comment. @fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list regarding IR printing with the new pass manager, and though this might be the reason why IR printing is not supported under new PM with clang. I would appreciate if you can take a look. Repository

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

twoh created this revision. twoh added reviewers: fedor.sergeev, philip.pfaffe. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D50923 enabled the IR printing support for the new pass manager, but only for the case when `opt` tool is used as a drive

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung created this revision. dyung added reviewers: thakis, rnk. dyung added a project: clang. A previous change D65233 (r367165) attempted to fix this issue, but it missed a case where the integrated assembler is not being used. For example, consider the case w

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems like it should be equivalent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65969/new/ https://reviews.llvm.org/D65969

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun marked 4 inline comments as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6572 +return false; + return llvm::StringSwitch(Callee->getName()) + .Cases("begin", "rbegin", "cbegin", "crbegin", true) gribozavr wrot

[PATCH] D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes

xazax.hun updated this revision to Diff 214228. xazax.hun added a comment. - Fix review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65120/new/ https://reviews.llvm.org/D65120 Files: clang/lib/Sema/SemaInit.cpp clang/test/Analysis/inner-pointer.cpp clang/test/Sema/warn

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:40 + + diag(UserVarDecl->getLocation(), "var %0 is %1 but holds a register") + << UserVarDecl << *VarType; How about `variable %0 declare

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. Additional note. Seems to me, it has something to do with the partial linking. According to ld documentation, it is recommended to use `-Ur` option for partial linking of the C++ object files to resolve global constructors. -Ur For anything other than C++ programs,

[PATCH] D65912: [clang-tidy] Add new check for math constants

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MathConstantsCheck.cpp:44-58 +{{"M_E"}, {"std::math::e"}, 2.7182818284590452354}, +{{"M_LOG2E"}, {"std::math::log2e"}, 1.4426950408889634074}, +{{"M_LOG10E"}, {"

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

plotfi updated this revision to Diff 214222. plotfi added a comment. adding context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65969/new/ https://reviews.llvm.org/D65969 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp =

[PATCH] D65723: [analyzer][NFC] Add different interestingness kinds

xazax.hun added a comment. As this thing will now be part of the checker interface it would be great to have some guidelines which interestingness kind to use (or, when to use interestingness at all). I am totally fine with addressing this in a followup patch though. Repository: rG LLVM Git

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

xazax.hun added a comment. Yeah, this is important bike-shedding from the user point of view. Otherwise it looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65575/new/ https://reviews.llvm.org/D65575 __

[PATCH] D65969: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions

plotfi created this revision. plotfi added reviewers: aaron.ballman, compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. I am working to remove this concept of the "FinalPhase" in the clang driver, but it is used in a lot of different places to do argument handling fo

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/CFG.h:859 + /// Returns true if the block would eventually end with a sink (a noreturn + /// node). We scan the child CFG blocks in a depth-first manner and see if + /// all paths eventually end up in an

r368338 - [analyzer] Fix scan-build's plist output in plist-html mode.

Author: dergachev Date: Thu Aug 8 13:22:32 2019 New Revision: 368338 URL: http://llvm.org/viewvc/llvm-project?rev=368338&view=rev Log: [analyzer] Fix scan-build's plist output in plist-html mode. r366941 accidentally made it delete all plist files as soon as they're produced. Modified: cfe/

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:94 + [CastFromName, CastToName, IsNullReturn, + IsSimpleCast](BugReport &) -> std::string { SmallString<128> Msg; `IsDynamicCast`.

r368334 - [clang] add REQUIRES: linux to driver test case

Author: bcain Date: Thu Aug 8 13:12:54 2019 New Revision: 368334 URL: http://llvm.org/viewvc/llvm-project?rev=368334&view=rev Log: [clang] add REQUIRES: linux to driver test case The test case explicitly leverages linux, so should include it as a test requirement. Modified: cfe/trunk/test/D

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

dexonsmith added a comment. In D65906#1621542 , @aganea wrote: > In D65906#1620034 , @arphaman wrote: > > > Regarding the invisible characters before `#ifdef`, are you sure that's the > > right behavior? > > > Shou

r368332 - [clang] add REQUIRES to driver test case

Author: bcain Date: Thu Aug 8 13:04:39 2019 New Revision: 368332 URL: http://llvm.org/viewvc/llvm-project?rev=368332&view=rev Log: [clang] add REQUIRES to driver test case The test case explicitly leverages x86, so should include it as a test requirement. Modified: cfe/trunk/test/Driver/as-

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ added a comment. Looking good now! I still recommend eventually adding tests with casts of references. In D65889#1620128 , @Charusso wrote: > - May it is better to also check for `getAsCXXRecordDecl()` for obtaining a > class. In D65889#1621587

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp:44 +CheckFactories.registerCheck( +"google-objc-require-category-method-prefixes"); CheckFactories.registerCheck( Please keep this list in a

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. In D65019#1621670 , @efriedma wrote: > Yes, it's technically a "call", but you don't need the call lowering code. > That's dedicated to stuff like passing arguments, returning values, checking > whether the function can be tail-c

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

efriedma added a comment. Yes, it's technically a "call", but you don't need the call lowering code. That's dedicated to stuff like passing arguments, returning values, checking whether the function can be tail-called, etc. None of that applies here; the intrinsic always corresponds to exactl

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:820 + llvm::DenseMap> + CompatibleAliases; gribozavr wrote: > `unordered_set`? or `SmallPtrSet`? Repository: rG LLVM Github

r368328 - [clang] Add no-warn support for Wa

Author: bcain Date: Thu Aug 8 12:19:20 2019 New Revision: 368328 URL: http://llvm.org/viewvc/llvm-project?rev=368328&view=rev Log: [clang] Add no-warn support for Wa Added: cfe/trunk/test/Driver/as-no-warnings.c Modified: cfe/trunk/include/clang/Basic/CodeGenOptions.def cfe/trunk/inc

r368327 - [llvm-mc] Add reportWarning() to MCContext

Author: bcain Date: Thu Aug 8 12:13:23 2019 New Revision: 368327 URL: http://llvm.org/viewvc/llvm-project?rev=368327&view=rev Log: [llvm-mc] Add reportWarning() to MCContext Adding reportWarning() to MCContext, so that it can be used from the Hexagon assembler backend. Modified: cfe/trunk/t

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

dcandler updated this revision to Diff 214205. dcandler marked an inline comment as done. dcandler added a comment. Adjusted the formatting on some comment lines, and added FIXMEs for all the constraints that require additional validation to clarify what is still needed and where. CHANGES SINC

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

dcandler marked 5 inline comments as done. dcandler added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:938 +// Thumb1: An immediate integer which is a multiple of 4 between 0 and 1020. +Info.setRequiresImmediate(); return true; compn

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

lebedev.ri added a reviewer: reames. lebedev.ri added inline comments. Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:119-120 + // Address spaces for 32 bit signed, 32 bit unsigned, and 64 bit pointers. + Ret += "-p253:32:32-p254:32:32-p255:64:64"; + I

r368326 - [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to appropriate file.

Author: ymandel Date: Thu Aug 8 11:55:42 2019 New Revision: 368326 URL: http://llvm.org/viewvc/llvm-project?rev=368326&view=rev Log: [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to appropriate file. Summary: `ignoringElidableConstructorCall` is a traversal matcher, but its

[PATCH] D65963: [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to appropriate file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368326: [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang updated this revision to Diff 214202. akhuang added a comment. Remove test case changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Basi

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214186. Charusso added a comment. - The call as `getAsCXXRecordDecl()` sometimes run into an assertion failure, so we need to avoid it: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:333: ExprEngine::createTemporaryRegionIfNeeded(): Assertion `!InitValW

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. For some reason the tests were failing before without the datalayout change? I'm not sure why, but I changed them back and they're fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64

[PATCH] D65963: [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to appropriate file.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65963/new/ https://reviews.llvm.org/D65963 __

  1   2   3   >