[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. Thanks, and will fix your suggestions before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

r368970 - [Clang] Pragma vectorize_predicate implies vectorize

Author: sjoerdmeijer Date: Wed Aug 14 23:24:40 2019 New Revision: 368970 URL: http://llvm.org/viewvc/llvm-project?rev=368970&view=rev Log: [Clang] Pragma vectorize_predicate implies vectorize New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)", and it is ignored when vectoriz

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

This revision was automatically updated to reflect the committed changes. Closed by commit rL368970: [Clang] Pragma vectorize_predicate implies vectorize (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

r368969 - [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64.

Author: ctopper Date: Wed Aug 14 23:20:33 2019 New Revision: 368969 URL: http://llvm.org/viewvc/llvm-project?rev=368969&view=rev Log: [X86] Add test cases for _mm_movepi64_pi64 and _mm_movpi64_epi64. Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse2-built

Re: r368874 - Document clang-cpp in the release notes for clang

On Wed, Aug 14, 2019 at 6:48 PM Chris Bieneman via cfe-commits wrote: > > Author: cbieneman > Date: Wed Aug 14 09:49:52 2019 > New Revision: 368874 > -- ... > +- In 9.0.0 and later Clang added a new target, clang-cpp, which generates a > + shared library comprised of all the clang component libr

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj, committed by ). Hera

r368958 - [Tooling] Add a hack to work around issues with matcher binding in r368681.

Author: dlj Date: Wed Aug 14 21:10:11 2019 New Revision: 368958 URL: http://llvm.org/viewvc/llvm-project?rev=368958&view=rev Log: [Tooling] Add a hack to work around issues with matcher binding in r368681. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rul

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

dlj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rules with a single matcher. Previously, the single matcher would not need to be bound (`joinCaseMatchers` retur

r368954 - [NFC] Update doc comment to fix warning.

Author: jdevlieghere Date: Wed Aug 14 20:59:30 2019 New Revision: 368954 URL: http://llvm.org/viewvc/llvm-project?rev=368954&view=rev Log: [NFC] Update doc comment to fix warning. This fixes the warning: parameter 'EnableNullFPSuppression' not found in the function declaration [-Wdocumentation]

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added a comment. Cute!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1071 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; + Please verify that the warning is not enabled by default. CHANGES SINC

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

stephanemoore updated this revision to Diff 215311. stephanemoore added a comment. Fix example matches in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66270/new/ https://reviews.llvm.org/D66270 Files: clang-tools-extra/clang-tidy/objc/

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added a comment. In D52524#1630767 , @thakis wrote: > Wouldn't those projects just move to also disabling the warning by passing > -Wno-poison-system-directories? If there are projects that are actively > adding -I/usr/include, that means they

[PATCH] D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛

stephanemoore created this revision. stephanemoore added reviewers: aaron.ballman, gribozavr. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This migrates objc-super-self to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Note

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't y

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436 + if (const CXXRecordDecl *Base = + cast_or_null(Ty->getDecl()->getDefinition())) { +bool IsVirtual = false; juliehockett wrote: > Will `get

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215304. DiegoAstiazaran marked 11 inline comments as done. DiegoAstiazaran added a comment. Increase version number of clang-doc bitcode. Rename `documentInfo` function to `shouldSerializeInfo`. In new `parseBases` a BaseRecordInfo object is created an

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This migrates objc-forbidden-subclassing to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Notes: Ran clang tools tests. Repository: rG L

[PATCH] D66268: [clang-doc] Fix use of source-root flag

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. The value, if any, of --source-root flag was not being used. This has been fixed and

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. I think you're referring to stuff like `OpenMPCaptureLevel` in `ScopeInfo.h`. I wrote those changes for this patch first, as can be seen in phabricator history. I needed them for the other patch too, and I thought we were going to end up applying that patch first, so I

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://revie

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. Why there are the changes from the another patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 215298. jdenny added a comment. Rebase. Add more tests, as requested at D66247#1630441 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 Files: clang/include/clang

r368950 - [NFCI] Always initialize BugReport const fields

Author: xiaobai Date: Wed Aug 14 17:58:51 2019 New Revision: 368950 URL: http://llvm.org/viewvc/llvm-project?rev=368950&view=rev Log: [NFCI] Always initialize BugReport const fields Summary: Some compilers require that const fields of an object must be explicitly initialized by the constructor. I

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL368950: [NFCI] Always initialize BugReport const fields (authored by xiaobai, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D66265?vs=215292&id=215299#t

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D65889: [analyzer] CastValueCh

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng created this revision. Herald added subscribers: cfe-commits, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar,

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66265/new/ https://reviews.llvm.org/D66265

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

xiaobai created this revision. xiaobai added reviewers: compnerd, Szelethus, NoQ. Herald added a project: clang. Some compilers require that const fields of an object must be explicitly initialized by the constructor. I ran into this issue building with clang 3.8 on Ubuntu 16.04. Repository: r

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added a comment. In D60281#1630646 , @NoQ wrote: > Thanks! > > One more quick question: Who is Husi??? Well thats me. Long story short, the reason why my name is Szelethus is that my first ever character to hit max level in World of Warcraft w

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, i appreciate! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66261/new/ https://reviews.llvm.org/D66261

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! One more quick question: Who is Husi??? Comment at: clang/docs/analyzer/checkers.rst:261 + + void consume(const char *); + This declaration doesn't add mu

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215288. Szelethus marked 2 inline comments as done. Szelethus added a comment. Fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 Files: clang/docs/analyzer/checkers.rst Index: clang/docs/analyzer/

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, dcoughlin, dkrupp. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. This is more of a

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: clang/docs/analyzer/checkers.rst:263 + + void _deref_after_equals() { + std::string s = "llvm"; I suggest `deref_after_assignment`. Comment at: clang/docs/analyzer/checkers.rst:271 + const char *return_t

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus updated this revision to Diff 215281. Szelethus changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. Szelethus added a comment. Revised the documentation according to @NoQ's comments. By literally copy pasting it. Like any good programmer should do :^) R

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

Bigcheese added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:130 + + const DirectoryEntry *getDir() const { return Entry.getDir(); } + Isn't this incorrect in the case of symlinks? Comment at: clang/include/clang/Basic/

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeWriter.h:33 // BitCodeConstants, though they can be added without breaking it. static const unsigned VersionNumber = 2; I definitely haven't been particularly good about bumpin

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added a comment. In D52524#1621468 , @thakis wrote: > Couldn't cross build users just pass -nostdsysteminc to tell clang to not > look in system header locations? My understanding is "-nostdsysteminc " does not block users from passing inclu

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus accepted this revision. Szelethus added a comment. In D65182#1630540 , @NoQ wrote: > In D65182#1629192 , @Szelethus wrote: > > > Hmm, why the need for checker options? Why not have them by default? If > >

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added a comment. In D65182#1629192 , @Szelethus wrote: > Hmm, why the need for checker options? Why not have them by default? If > fixits are an experimental feature, maybe we should have a global > `enable-fixits` config. But I don't insist :) I d

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:200 CXXRecordDecl *Canonical = Record->getCanonicalDecl(); if (Canonical->hasAttr() || Canonical->hasAttr()) return; mgehre wrote: > gribozavr wrote: > > Should this code no

r368941 - [www] Update DR status page to match latest version of CWG issues list.

Author: rsmith Date: Wed Aug 14 15:57:51 2019 New Revision: 368941 URL: http://llvm.org/viewvc/llvm-project?rev=368941&view=rev Log: [www] Update DR status page to match latest version of CWG issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html U

r368940 - Fix handling of class member access into a vector type.

Author: rsmith Date: Wed Aug 14 15:57:50 2019 New Revision: 368940 URL: http://llvm.org/viewvc/llvm-project?rev=368940&view=rev Log: Fix handling of class member access into a vector type. When handling a member access into a non-class, non-ObjC-object type, we would perform a lookup into the sur

[PATCH] D62445: [test] Fix plugin tests

NoQ added a comment. I didn't make much progress so far, but i marked the test as `// UNSUPPORTED: darwin` in rC368765 , so the buildbot is now green starting with http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6519/. Repository: rL LLVM CHA

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

rnkovacs added a comment. In D60281#1630337 , @Szelethus wrote: > I'll gladly add the finishing touches :) So sorry for leaving this hanging! Thanks Husi, you da best :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6028

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL368939: Remove LVALUE / RVALUE workarounds (authored by jfb, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D66240?vs=215202&id=215275#toc Reposi

r368939 - Remove LVALUE / RVALUE workarounds

Author: jfb Date: Wed Aug 14 15:48:12 2019 New Revision: 368939 URL: http://llvm.org/viewvc/llvm-project?rev=368939&view=rev Log: Remove LVALUE / RVALUE workarounds Summary: LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be needed anymore because the minimum compiler versions

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 215274. NoQ marked 3 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c clang

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; dschuff wrote: > This should maybe be called "test_empty_struct" since its size is actually 1 > and not zero. Done

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum updated this revision to Diff 215272. quantum marked 6 inline comments as done. quantum added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66255/new/ https://reviews.llvm.org/D66255 Files: clang/lib/C

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215271. denik added a comment. Fixed clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1630491 , @NoQ wrote: > the only reason it's not enabled by default yet is because we forgot to do > that :( Damn, thats a bummer. It wouldn't be too much trouble to run an analysis and check out whether everythin

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

NoQ added a comment. A quick archaeological dig suggests that i had no concerns with turning on unrolling by default back in 2017: http://lists.llvm.org/pipermail/cfe-dev/2017-August/055221.html - and i don't think i had any new concerns since then. I guess it'll be beneficial to make one more

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 updated this revision to Diff 215268. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index: test/Analysi

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre marked 6 inline comments as done. mgehre added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:102 + dyn_cast_or_null(Record->getDescribedTemplate())) { +if (auto *Def = Record->getDefinition()) + addGslOwnerPointerAttributeIfNotExisting(Context

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

jfb added a comment. BTW, if this breaks stuff maybe it's better to do it one project at a time, and remove the helper at the very end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240 ___

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630398 , @jdenny wrote: > In D66247#1630352 , @ABataev wrote: > > > Yes, just realized that, defaultmap does not affect explicit firstprivates. > > Then just check `map(a) firstp

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240 ___

[PATCH] D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467)

aaron.ballman added a comment. There was a request in the linked bug for some code archaeology to see why this behavior exists in the first place. What were the results of that? I'm not opposed to the patch, but I would like to understand why it behaves the way it does. I could imagine "confus

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215260. denik added a comment. Herald added a subscriber: ormris. Updated the code (removed Diag propagation). Added test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Bas

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. In D65019#1630354 , @nickdesaulniers wrote: > Great! LGTM and thank you for this patch. Please give 24hrs for > @eli.friedman or @kristof.beyls to leave comments before merging. Sounds good! Thanks for all the comments. Repos

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630352 , @ABataev wrote: > Yes, just realized that, defaultmap does not affect explicit firstprivates. > Then just check `map(a) firstprivate(a)` for `int128` type. Check that it > still has `tofrom` mapping. If so, the

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

This revision was automatically updated to reflect the committed changes. Closed by commit rL368929: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r368929 - [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

Author: mgehre Date: Wed Aug 14 14:55:57 2019 New Revision: 368929 URL: http://llvm.org/viewvc/llvm-project?rev=368929&view=rev Log: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() Summary: Diagnose dangling pointers that come from std::stack::top() and std::optional::val

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1606063 , @baloghadamsoftware wrote: > For me it is all the same whether to continue this patch or taking over > Péter's. Well, there are plenty of comments I'm not sure ever got addressed. We could take an invento

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers accepted this revision. nickdesaulniers added a subscriber: eli.friedman. nickdesaulniers added a comment. This revision is now accepted and ready to land. Great! LGTM and thank you for this patch. Please give 24hrs for @eli.friedman or @kristof.beyls to leave comments before mer

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630333 , @jdenny wrote: > In D66247#1630321 , @ABataev wrote: > > > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > > for example. The variable must

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

RaviNarayanaswamy added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 | ++-

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus commandeered this revision. Szelethus edited reviewers, added: rnkovacs; removed: Szelethus. Szelethus added a comment. This revision now requires review to proceed. I'll gladly add the finishing touches :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630321 , @ABataev wrote: > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > for example. The variable must be mapped as `tofrom` in this case but, most > probably, will be mapped as `to`.

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630287 , @jdenny wrote: > In D66247#1630262 , @ABataev wrote: > > > In D66247#1630245 , @jdenny wrote: > > > > > In D66247#1630196

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

dschuff added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; This should maybe be called "test_empty_struct" since its size is actually 1 and not zero. Comm

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630283 , @puremourning wrote: > In D66254#1630277 , @lebedev.ri > wrote: > > > Tests? > > > Per my comment: I haven't added new tests to HeaderSearchTest.cc because the >

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Szelethus added a comment. I really like the high level idea proposed by this patch, and the test files make me believe that its correct as well! I'm really not familiar around this part of the code, so if its okay, I'll take my time to do the usual find references, inserting unreachables/asser

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630262 , @ABataev wrote: > In D66247#1630245 , @jdenny wrote: > > > In D66247#1630196 , @ABataev wrote: > > > > > Do we really need to map

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630277 , @lebedev.ri wrote: > Tests? Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this

[PATCH] D66254: Correct include suggestion when search path includes symlink

lebedev.ri added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66254/new/ https://reviews.llvm.org/D66254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum created this revision. quantum added reviewers: dschuff, tlively, sbc100. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google. Herald added a project: clang. D66168 passes size 0 structs indirectly, while the wasm backend expects it

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel added a comment. Okay, I see the issue now. I originally developed this patch on a fork with a whole lot of extra changes, and that fork included some extra modifications to the callgraph that I had missed: https://github.com/intel/llvm/commit/971fecdc316930c0c1c79283d1094ee4c4ca

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h:879 + ArrayRef getFixits() const { return Fixits; } + NoQ wrote: > Szelethus wrote: > > Hmm, will this return an immutable container? If not, can

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630245 , @jdenny wrote: > In D66247#1630196 , @ABataev wrote: > > > Do we really need to map such variables? According to standard, "The map > > clause specifies how an original

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630196 , @ABataev wrote: > Do we really need to map such variables? According to standard, "The map > clause specifies how an original list item is mapped from the current task’s > data environment to a corresponding li

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 215236. NoQ added a comment. Add a "not implemented yet" assertion for kinds of fixits that are not supported as of that patch (but will definitely need to be supported in the future). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://r

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alte

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(State->getLValue(VD, LCtx)); > Al

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new te

r368917 - [AMDGPU] Do not assume a default GCN target

Author: rampitec Date: Wed Aug 14 13:55:15 2019 New Revision: 368917 URL: http://llvm.org/viewvc/llvm-project?rev=368917&view=rev Log: [AMDGPU] Do not assume a default GCN target Differential Revision: https://reviews.llvm.org/D66246 Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/t

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added inline comments. Comment at: clang/lib/Analysis/CallGraph.cpp:93 void VisitCXXConstructExpr(CXXConstructExpr *E) { CXXConstructorDecl *Ctor = E->getConstructor(); Yes, there it is. Where does it come from? I don't have it in master. Reposito

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. Do we really need to map such variables? According to standard, "The map clause specifies how an original list item is mapped from the current task’s data environment to a corresponding list item in the device data environment of the device identified by the construct."

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + std::string ClangLoopStr = (Twine("clang loop ")

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. For me `ddd()` doesn't call `c::c()`. I can fix it by adding the following code: void VisitCXXConstructExpr(CXXConstructExpr *CE) { addCalledDecl(CE->getConstructor()); VisitChildren(CE); } I don't see why it would work without that code, as `CXXConstructExpr` is

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215225. mibintc added a comment. I added documentation for the new floating point options into clang/docs Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManua

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ marked 3 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h:879 + ArrayRef getFixits() const { return Fixits; } + Szelethus wrote: > Hmm, will this return an immutable conta

[PATCH] D66124: [clang-doc] Add missing check in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL368912: [clang-doc] Add missing check in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

  1   2   3   >