[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

tschuett added a comment. How does it relate to the -MJ option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66555/new/ https://reviews.llvm.org/D66555 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Eugene.Zelenko added a comment. Please mention new module and check in Release Notes. Comment at: clang-tidy/fpga/FPGATidyModule.cpp:5 +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. Licens

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

thakis added a comment. > I don't understand how you draw that conclusion, but the reason behind why we > went with that as a way to silence the diagnostic is because using the prefix > acts as a signal that the developer wants to do bit manipulation more than > just a decimal literal does. It'

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

NoQ added a comment. In D66572#1640518 , @Szelethus wrote: > Super high level question: `CheckerManager` knows whether a checker, and I > suspect a checker callback is path sensitive or not, do you think we can > automate this decision (whether the bug r

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

This revision was automatically updated to reflect the committed changes. jdenny marked 2 inline comments as done. Closed by commit rL369619: [OpenMP] Permit map with DSA on combined directive (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commit

r369619 - [OpenMP] Permit map with DSA on combined directive

Author: jdenny Date: Wed Aug 21 20:34:30 2019 New Revision: 369619 URL: http://llvm.org/viewvc/llvm-project?rev=369619&view=rev Log: [OpenMP] Permit map with DSA on combined directive For `map`, the following restriction changed in OpenMP 5.0: * OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex updated this revision to Diff 216545. comex marked 9 inline comments as done. comex added a comment. Changes since last version: - Rebased. - Added `ExternallyDestructed` parameter to `VisitExprWithCleanups` and `CFGBuilder::Visit`; removed `VisitExternallyDestructed`. - Changed CFG printi

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex abandoned this revision. comex marked 18 inline comments as done. comex added inline comments. Comment at: lib/Analysis/CFG.cpp:2102 case Stmt::CompoundStmtClass: - return VisitCompoundStmt(cast(S)); + return VisitCompoundStmt(cast(S), /*ExternallyDestructed

[PATCH] D66381: [analyzer] Enable control dependency condition tracking by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9e530c0f4d: [analyzer] Enable control dependency condition tracking by default (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66381

Re: [PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

No worries. If it takes a while to analyze, please revert while you you investigate, to keep trunk green. On Wed, Aug 21, 2019 at 10:29 PM Csaba Dabis via Phabricator via cfe-commits wrote: > Charusso added a comment. > > return C.getNoteTag( > - [=] { > + [=]() -> std::string

r369616 - [analyzer] Enable control dependency condition tracking by default

Author: szelethus Date: Wed Aug 21 20:08:48 2019 New Revision: 369616 URL: http://llvm.org/viewvc/llvm-project?rev=369616&view=rev Log: [analyzer] Enable control dependency condition tracking by default This patch concludes my GSoC'19 project by enabling track-conditions by default. Differential

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

This revision was automatically updated to reflect the committed changes. Closed by commit rL369615: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull() (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso added a comment. Thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66423/new/ https://reviews.llvm.org/D66423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

r369615 - [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Author: charusso Date: Wed Aug 21 19:57:59 2019 New Revision: 369615 URL: http://llvm.org/viewvc/llvm-project?rev=369615&view=rev Log: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull() Summary: - Reviewed By: NoQ Differential Revision: https://reviews.llvm.org/D66423 Modified: cf

[PATCH] D66423: [analyzer] CastValueChecker: Model isa(), isa_and_nonnull()

Charusso updated this revision to Diff 216541. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66423/new/ https://reviews.llvm.org/D66423 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp clang/test/Analysis/Inputs/llvm.h clang/test/Anal

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

Szelethus added a comment. Super high level question: `CheckerManager` knows whether a checker, and I suspect a checker callback is path sensitive or not, do you think we can automate this decision (whether the bug report is path sensitive of syntactic)? For the purposes of clang-tidy, can we s

[PATCH] D66131: [analyzer] Don't track the condition of foreach loops

This revision was automatically updated to reflect the committed changes. Closed by commit rL369613: [analyzer] Don't track the condition of foreach loops (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

r369613 - [analyzer] Don't track the condition of foreach loops

Author: szelethus Date: Wed Aug 21 19:44:19 2019 New Revision: 369613 URL: http://llvm.org/viewvc/llvm-project?rev=369613&view=rev Log: [analyzer] Don't track the condition of foreach loops As discussed on the mailing list, notes originating from the tracking of foreach loop conditions are always

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added a comment. return C.getNoteTag( - [=] { + [=]() -> std::string { SmallString<128> Msg; That was the fix by rL369609 . Somehow it converted to a temporary object therefore that was an issue: [175/176] Running the C

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added a comment. In D66325#1640483 , @thakis wrote: > Thanks! Looks like it builds fine now, but the tests are failing: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19297/steps/test-check-all/logs/stdio > Fai

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

thakis added a comment. And, unrelatedly, for libc++, shouldn't we just add the attribute to the libc++ source instead of trying to infer it in the compiler? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66179/new/ https://reviews.llvm.org/D66179 _

[PATCH] D66573: [clang][ifs] Dropping older experimental interface stub formats.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. Working on a new tool, llvm-ifs, for merging interface stub files generated by clang and I've iterated on my derivative format of TBE to a newer format. This fo

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

thakis added a comment. Thanks! Looks like it builds fine now, but the tests are failing: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19297/steps/test-check-all/logs/stdio FAIL: Clang :: Analysis/cast-value-state-dump.cpp (4352 of 48515) **

r369609 - [analyzer] CastValueChecker: Try to fix the buildbots

Author: charusso Date: Wed Aug 21 18:41:06 2019 New Revision: 369609 URL: http://llvm.org/viewvc/llvm-project?rev=369609&view=rev Log: [analyzer] CastValueChecker: Try to fix the buildbots Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp Modified: cfe/trunk/lib/StaticAnal

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

NoQ marked 6 inline comments as done. NoQ added a comment. Most of the patch is boring but here are a few places that i wanted attract attention to. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:225 + +protected: + /// The ExplodedGraph node a

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso added a comment. In D66325#1640426 , @thakis wrote: > It looks like this renamed DynamicTypeMap.h but didn't update all users, see > all the files in Checkers at > http://llvm-cs.pcc.me.uk/?q=include.*dynamictypemap.h for example. > > Which targ

r369607 - [analyzer] CastValueChecker: Rewrite dead header hotfix

Author: charusso Date: Wed Aug 21 17:36:42 2019 New Revision: 369607 URL: http://llvm.org/viewvc/llvm-project?rev=369607&view=rev Log: [analyzer] CastValueChecker: Rewrite dead header hotfix Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/DeleteWithNonVirtualDtorChecker.cpp cfe/trunk/lib/

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

thakis added a comment. See e.g. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-gn/builds/4344/steps/ninja%20/logs/stdio for errors; I'm guessing most other bots on http://lab.llvm.org:8011/console will turn red in a bit too. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

thakis added a comment. It looks like this renamed DynamicTypeMap.h but didn't update all users, see all the files in Checkers at http://llvm-cs.pcc.me.uk/?q=include.*dynamictypemap.h for example. Which targets did you try to build locally? Repository: rL LLVM CHANGES SINCE LAST ACTION h

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

This revision was automatically updated to reflect the committed changes. Charusso marked an inline comment as done. Closed by commit rL369605: [analyzer] CastValueChecker: Store the dynamic types and casts (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscri

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso marked 6 inline comments as done. Charusso added a comment. Thanks for the review! The build-bots will fire with that `QualType` fix (1028 TU on its own). I will look into the exploded-graph-rewriter.py after GSoC to fix every stuff like that patch and also invoke my HTML simplification

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

chris.laplante added a comment. I encountered this issue when trying to integrate scan-build with CMake in a cross-compiling environment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66569/new/ https://reviews.llvm.org/D66569

r369605 - [analyzer] CastValueChecker: Store the dynamic types and casts

Author: charusso Date: Wed Aug 21 17:20:36 2019 New Revision: 369605 URL: http://llvm.org/viewvc/llvm-project?rev=369605&view=rev Log: [analyzer] CastValueChecker: Store the dynamic types and casts Summary: This patch introduces `DynamicCastInfo` similar to `DynamicTypeInfo` which is stored in `C

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

This revision was automatically updated to reflect the committed changes. Closed by commit rL369604: [analyzer] TrackConstraintBRVisitor: Do not track unknown values (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

chris.laplante created this revision. chris.laplante added a reviewer: krememek. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, dexonsmith, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Current code assumes flags

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso added a comment. Thanks for the reviews! I hope that mentioned error will be visible by the `BugReporter` revisions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/ https://reviews.llvm.org/D66267 ___ cfe-commits mailing

[PATCH] D66565: [analyzer] pr43036: Fix support for operator `sizeof...'.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66565/new/ https://reviews.llvm.org/D66565 ___ cfe-commi

r369604 - [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Author: charusso Date: Wed Aug 21 17:06:58 2019 New Revision: 369604 URL: http://llvm.org/viewvc/llvm-project?rev=369604&view=rev Log: [analyzer] TrackConstraintBRVisitor: Do not track unknown values Summary: - Reviewers: NoQ, Szelethus Reviewed By: NoQ, Szelethus Differential Revision: https:

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

DiegoAstiazaran accepted this revision. DiegoAstiazaran added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66502/new/ https://reviews.llvm.org/D66502 ___ cfe-commits mailing

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

NoQ added a comment. Let's land this then!~~ Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:83-93 +static QualType getRecordType(QualType Ty) { + Ty = Ty.getCanonicalType(); + + if (Ty->isPointerType()) +return getRecordType(Ty->getPointeeType()); +

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 216520. rsmith marked 5 inline comments as done. rsmith added a comment. - Address review comments from Aaron. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/ https://reviews.llvm.org/D66361 Files: include/clang/Ba

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:14 let Component = "Sema" in { -let CategoryName = "Semantic Issue" in { +def warn_stack_exhausted : Warning< + "stack nearly exhausted; compilation time may suffer, and " aaro

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

thakis added inline comments. Comment at: cfe/trunk/unittests/Sema/GslOwnerPointerInference.cpp:9 + +#include "../ASTMatchers/ASTMatchersTest.h" +#include "clang/ASTMatchers/ASTMatchers.h" mgehre wrote: > thakis wrote: > > This weird relative include path is a hi

[PATCH] D66564: [clang-tidy] FPGA struct pack align lint check

ffrankies updated this revision to Diff 216516. ffrankies added a comment. Noticed that some of the lint checks were missing from docs/clang-tidy/checks/list.rst Added the fpga-struct-pack-align lint check to the update checks list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/n

[PATCH] D66565: [analyzer] pr43036: Fix support for operator `sizeof...'.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. A tiny fix for https://bugs.llvm.org/s

[PATCH] D66564: [clang-tidy] FPGA struct pack align lint check

ffrankies created this revision. ffrankies added a reviewer: alexfh. ffrankies created this object with visibility "All Users". ffrankies added a project: clang-tools-extra. Herald added subscribers: arphaman, xazax.hun, Anastasia, mgorny, srhines. Herald added a reviewer: jdoerfert. Herald added a

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:83-93 +static QualType getRecordType(QualType Ty) { + Ty = Ty.getCanonicalType(); + + if (Ty->isPointerType()) +return getRecordType

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre marked an inline comment as done. mgehre added inline comments. Comment at: cfe/trunk/unittests/Sema/GslOwnerPointerInference.cpp:9 + +#include "../ASTMatchers/ASTMatchersTest.h" +#include "clang/ASTMatchers/ASTMatchers.h" thakis wrote: > This weird relati

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216513. Charusso added a comment. - Fix printing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files: clang/include/clang/AST/Type.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerConte

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:126 +} else { + Out << "the object"; +} "The" should be capitalized if there's no "Assuming" before it. CHANGES SINCE LAST ACTION https://re

[PATCH] D66325: [analyzer] CastValueChecker: Store the dynamic types and casts

Charusso updated this revision to Diff 216509. Charusso marked 4 inline comments as done and an inline comment as not done. Charusso added a comment. - Fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66325/new/ https://reviews.llvm.org/D66325 Files: clang/include/clang/AST/Type.h

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny marked 4 inline comments as done. jdenny added a comment. Thanks. Comment at: clang/lib/Sema/SemaExpr.cpp:17748 ObjCAvailabilityCheckExpr(Version, AtLoc, RParen, Context.BoolTy); -} \ No newline at end of file +} ABataev wrote: > jdenny wrote: > >

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/Sema/SemaExpr.cpp:17749 } \ No newline at end of file Still marked as changed code, better to restore it completely. CHANGES S

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

thakis added a comment. Similar to Comment at: cfe/trunk/unittests/Sema/CMakeLists.txt:14 clangAST + clangASTMatchers clangBasic Is it necessary to use ASTMachers to test this? It'd be good if SemaTests wouldn't have to depend on ASTMatchers (for linkin

[PATCH] D65725: [analyzer] Mention whether an event is about a condition in a bug report part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL369596: [analyzer] Mention whether an event is about a condition in a bug report part 2 (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r369596 - [analyzer] Mention whether an event is about a condition in a bug report part 2

Author: szelethus Date: Wed Aug 21 15:38:00 2019 New Revision: 369596 URL: http://llvm.org/viewvc/llvm-project?rev=369596&view=rev Log: [analyzer] Mention whether an event is about a condition in a bug report part 2 In D65724, I do a pretty thorough explanation about how I'm solving this problem,

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17748 ObjCAvailabilityCheckExpr(Version, AtLoc, RParen, Context.BoolTy); -} \ No newline at end of file +} jdenny wrote: > ABataev wrote: > > Restore original code here > OK, I did. Wh

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17748 ObjCAvailabilityCheckExpr(Version, AtLoc, RParen, Context.BoolTy); -} \ No newline at end of file +} ABataev wrote: > Restore original code here OK, I did. What's the reason for n

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 216502. jdenny marked 8 inline comments as done. jdenny added a comment. Make suggested changes to default arguments, comments on literals, and parameter names. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

mgehre added a comment. In the false-positive example, after the `DerivedToBase`, we see a constructor call which I think is the copy constructor. 1. We should consider `MutableArrayRef` to be a gsl::Pointer according to the paper, because it publicly derives from one. 2. Also in the paper, the

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

This revision was automatically updated to reflect the committed changes. mgehre marked an inline comment as done. Closed by commit rL369591: [LifetimeAnalysis] Support more STL idioms (template forward declaration and… (authored by mgehre, committed by ). Herald added a project: LLVM. Herald adde

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

This revision was automatically updated to reflect the committed changes. Closed by commit rL369589: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

mgehre marked 3 inline comments as done. mgehre added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4596 +for (Decl *Redecl : D->redecls()) { + Redecl->addAttr(::new (S.Context) + OwnerAttr(AL.getRange(), S.Context, DerefTypeLoc, -

r369591 - [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

Author: mgehre Date: Wed Aug 21 15:08:59 2019 New Revision: 369591 URL: http://llvm.org/viewvc/llvm-project?rev=369591&view=rev Log: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType) Summary: This fixes inference of gsl::Pointer on std::set::iterator

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

lebedev.ri added a comment. Or more specifically, why `!=` is now silently accepted in 4.0 mode? https://godbolt.org/z/M6iL4H Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 __

r369589 - [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

Author: szelethus Date: Wed Aug 21 14:59:22 2019 New Revision: 369589 URL: http://llvm.org/viewvc/llvm-project?rev=369589&view=rev Log: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field Exactly what it says on the tin! Note that we're talking abo

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

lebedev.ri added a comment. Shouldn't this be OpenMP-version-dependent? `!=` is only allowed in 4.5+ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-com

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. The previous patch (https://reviews.llvm.org/D54441) support the relational-op != very well for openmp canonical loop form, however, it didn't update the

[PATCH] D65481: NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369585: NFCI: Simplify SourceManager::translateFile by removing code path that should… (authored by arphaman, committed by

r369585 - NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken

Author: arphaman Date: Wed Aug 21 14:37:09 2019 New Revision: 369585 URL: http://llvm.org/viewvc/llvm-project?rev=369585&view=rev Log: NFCI: Simplify SourceManager::translateFile by removing code path that should never be taken I noticed that SourceManager::translateFile has code that doesn't re

[PATCH] D65723: [analyzer][NFC] Add different interestingness kinds

This revision was automatically updated to reflect the committed changes. Closed by commit rL369583: [analyzer][NFC] Add different interestingness kinds (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1419 + RecordDecl *RD, CapturedRegionKind K, + unsigned CaptureLevel); Better to use `OpenMPCaptureLevel` since this param is

r369583 - [analyzer][NFC] Add different interestingness kinds

Author: szelethus Date: Wed Aug 21 14:33:25 2019 New Revision: 369583 URL: http://llvm.org/viewvc/llvm-project?rev=369583&view=rev Log: [analyzer][NFC] Add different interestingness kinds We defined (on the mailing list and here on phabricator) 2 different cases where retrieving information about

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

jkorous added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1044 + if (const Arg *A = Args.getLastArg(options::OPT_gen_cdb_fragment_path)) +PathToCDBFragmentDir = A->getValue(); // FIXME: TargetTriple is used by the target-prefixed calls to as/ld --

r369581 - Use C++14 heteregenous lookup for a couple of std::map

Author: d0k Date: Wed Aug 21 14:17:34 2019 New Revision: 369581 URL: http://llvm.org/viewvc/llvm-project?rev=369581&view=rev Log: Use C++14 heteregenous lookup for a couple of std::map These call find with a StringRef, heterogenous lookup saves a temporary std::string there. Modified: cfe/tr

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. I think everybody should be fine with this now :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. Implemented @Quuxplusone's idea to improve silence note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216478. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xor-as-pow.cpp Index: test/SemaCXX/warn-xor-as-pow.cpp

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea abandoned this revision. aganea added a comment. Please see the other reviews I've sent. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65906/new/ https://reviews.llvm.org/D65906 ___ cfe-commits mailing list cf

[clang-tools-extra] r369578 - Fix documentation build after rL369568

Author: yuanfang Date: Wed Aug 21 13:59:16 2019 New Revision: 369578 URL: http://llvm.org/viewvc/llvm-project?rev=369578&view=rev Log: Fix documentation build after rL369568 Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dynamic-static-initializers.rst Modified: clang-to

[PATCH] D66381: [analyzer] Enable control dependency condition tracking by default

Szelethus added a comment. In D66381#1639679 , @NoQ wrote: > The code looks good and there seems to be a lot of test coverage :] Thank you! It would not have been possible on my own! And actually, there are a couple minor nits, such as caching the retri

[PATCH] D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66550/new/ https://reviews.llvm.org/D66550 ___ cfe-com

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 216474. aganea added a comment. Use proper test file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp test/Lexer/minimize_sou

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. Previously, an `#error` directive with quoted, multi-line content, along with CR+LF line endings wasn't handled correctly. Repository: rC

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 216469. jdenny marked 7 inline comments as done. jdenny set the repository for this revision to rG LLVM Github Monorepo. jdenny added a comment. Make suggested changes for passing around the capture level. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

arphaman created this revision. arphaman added reviewers: Bigcheese, jkorous, dexonsmith. Herald added a project: clang. This patch adds a new option called `-gen-cdb-fragment-path` to the driver, which can be used to specify a directory path to which clang can emit a fragment of a CDB for each

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

This revision was automatically updated to reflect the committed changes. Closed by commit rL369574: [analyzer] Mention whether an event is about a condition in a bug report part 1 (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r369574 - [analyzer] Mention whether an event is about a condition in a bug report part 1

Author: szelethus Date: Wed Aug 21 13:43:27 2019 New Revision: 369574 URL: http://llvm.org/viewvc/llvm-project?rev=369574&view=rev Log: [analyzer] Mention whether an event is about a condition in a bug report part 1 Can't add much more to the title! This is part 1, the case where the collapse poi

[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

efriedma added a comment. Added a few more minor comments. It looks like the consensus on std-discussion is actually that your testcase has undefined behavior? That seems like an awful conclusion, and the standard text doesn't really seem to support it. (I mean, I guess you could argue that "

[PATCH] D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. aganea retitled this revision from "[clang-scan-deps] Correctly skip over double slashes in angle bracket #include" to "[clang-scan-deps] Minim

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 updated this revision to Diff 216458. xbolva00 edited the summary of this revision. xbolva00 added a comment. Detect digit separators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66397/new/ https://reviews.llvm.org/D66397 Files: lib/Sema/SemaExpr.cpp test/SemaCXX/warn-xo

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2108 void Sema::PushCapturedRegionScope(Scope *S, CapturedDecl *CD, RecordDecl *RD, CapturedRegionKind K) { + CapturedRegionScopeInfo *CSI = new CapturedRegionScopeInfo( -

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

Quuxplusone added a comment. In D66397#1639840 , @xbolva00 wrote: > Swap trick is cool, we can suggest it always(vs. ‘xor’) Well, you should avoid suggesting that the user rewrite `2 ^ 10` as `10 ^ 2`. Anyway, I think some of the observers here might be

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2108 void Sema::PushCapturedRegionScope(Scope *S, CapturedDecl *CD, RecordDecl *RD, CapturedRegionKind K) { + CapturedRegionScopeInfo *

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2108 void Sema::PushCapturedRegionScope(Scope *S, CapturedDecl *CD, RecordDecl *RD, CapturedRegionKind K) { + CapturedRegionScopeInfo *CSI = new CapturedRegionScopeInfo( -

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2108 void Sema::PushCapturedRegionScope(Scope *S, CapturedDecl *CD, RecordDecl *RD, CapturedRegionKind K) { + CapturedRegionScopeInfo *CSI = new CapturedRegionScopeInfo( -

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2108 void Sema::PushCapturedRegionScope(Scope *S, CapturedDecl *CD, RecordDecl *RD, CapturedRegionKind K) { + CapturedRegionScopeInfo *

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369568: [clang-tidy] Check for dynamically initialized statics in headers. (authored by yuanfang, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D62829?v

[clang-tools-extra] r369568 - [clang-tidy] Check for dynamically initialized statics in headers.

Author: yuanfang Date: Wed Aug 21 13:00:01 2019 New Revision: 369568 URL: http://llvm.org/viewvc/llvm-project?rev=369568&view=rev Log: [clang-tidy] Check for dynamically initialized statics in headers. Finds instances where variables with static storage are initialized dynamically in header file

  1   2   >