r372368 - Finish building the full-expression for a static_assert expression

Author: rsmith Date: Thu Sep 19 20:29:19 2019 New Revision: 372368 URL: http://llvm.org/viewvc/llvm-project?rev=372368=rev Log: Finish building the full-expression for a static_assert expression before evaluating it rather than afterwards. This is groundwork for C++20's P0784R7, where

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits created this revision. jhibbits added reviewers: nemanjai, hfinkel, joerg, kthomsen. Herald added subscribers: cfe-commits, jsji, MaskRay, kbarton. Herald added a project: clang. 8548 CPU is GCC's name for the e500v2, so accept this in clang. The e500v2 doesn't support lwsync, so define

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. Herald added a subscriber: wuzish. I made 8548 an alias in clang to e500, because e500 is recognized in llvm as a CPU, so gets us the feature list and, more importantly, the instruction scheduler. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

rsmith added a comment. Under http://eel.is/c++draft/cpp#cond-7.sentence-2, the identifier `__has_include` can't appear anywhere other than in the context of an `#if`, `#elif`, `#iifdef`, or `#ifndef`. That's what we should be checking for and diagnosing here (and we should produce an

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore marked 3 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:56 + const auto *ID = Result.Nodes.getNodeAs("impl"); + diag(ID->getLocation(), "%0 implements -isEqual: without implementing

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked 5 inline comments as done. zoecarver added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1612 break; + case DeclSpec::TST_addLValueReferenceType: + case DeclSpec::TST_addRValueReferenceType: EricWF wrote: > This should be

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex updated this revision to Diff 220926. comex added a comment. In D67647#1674795 , @dblaikie wrote: > Right - I was suggesting that could be changed. Would it be OK to you to > change arguments() to return ArrayRef? Or would you rather avoid that to

[PATCH] D67778: [Consumed] Narrow Subject for some attributes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67778/new/ https://reviews.llvm.org/D67778

r372363 - [NFCI] Always initialize const members of AttributeCommonInfo

Author: xiaobai Date: Thu Sep 19 17:16:32 2019 New Revision: 372363 URL: http://llvm.org/viewvc/llvm-project?rev=372363=rev Log: [NFCI] Always initialize const members of AttributeCommonInfo Some compilers require that const fields of an object must be explicitly initialized by the constructor.

[PATCH] D67778: [Consumed] Narrow Subject for some attributes

comex created this revision. comex added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the former second part of https://reviews.llvm.org/D67740 that was split out (and rewritten). Error out when the `callable_when`, `set_typestate` and

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex updated this revision to Diff 220918. comex marked 2 inline comments as done. comex edited the summary of this revision. comex added a comment. Addressed feedback. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex marked 4 inline comments as done. comex added a comment. In D67740#1675564 , @dblaikie wrote: > Looks like this might benefit from being split into independent changes - the > work related to templates (I haven't looked closely, but I assume that's

[PATCH] D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372361: [Consumed] Treat by-value class arguments as consuming by default, like rvalue… (authored by comex, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r372361 - [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

Author: comex Date: Thu Sep 19 16:00:31 2019 New Revision: 372361 URL: http://llvm.org/viewvc/llvm-project?rev=372361=rev Log: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs. Differential Revision: https://reviews.llvm.org/D67743 Modified:

[PATCH] D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

comex added a comment. In D67743#1675533 , @dblaikie wrote: > "Also, fix the order of if statements so that an explicit return_typestate > annotation takes precedence over the default behavior for rvalue refs." > > I'd probably have split that out into a

[PATCH] D67635: Fix for stringized function-macro args continued across lines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372360: Fix for stringized function-macro args continued across lines (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r372360 - Fix for stringized function-macro args continued across lines

Author: arphaman Date: Thu Sep 19 15:39:24 2019 New Revision: 372360 URL: http://llvm.org/viewvc/llvm-project?rev=372360=rev Log: Fix for stringized function-macro args continued across lines In case of certain #define'd macros, there's a space just before line continuation that the

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action,

[PATCH] D67052: Add reference type transformation builtins

EricWF added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1099 + +void Parser::ParseAddReferenceTypeSpecifier(DeclSpec ) { + DeclSpec::TST ReferenceTransformTST = ReferenceTransformTokToDeclSpec(); I think this should be generalized and merged

r372359 - Model converted constant expressions as full-expressions.

Author: rsmith Date: Thu Sep 19 15:00:16 2019 New Revision: 372359 URL: http://llvm.org/viewvc/llvm-project?rev=372359=rev Log: Model converted constant expressions as full-expressions. This is groundwork for C++20's P0784R7, where non-trivial destructors can be constexpr, so we need

[PATCH] D67052: Add reference type transformation builtins

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2606 + DeclSpec::TST ReferenceTransformTokToDeclSpec(); + void ParseAddReferenceTypeSpecifier(DeclSpec ); void ParseAtomicSpecifier(DeclSpec );

[PATCH] D67052: Add reference type transformation builtins

EricWF added inline comments. Comment at: clang/include/clang/AST/Type.h:4353 +RemoveReferenceType, +AddRValueType, +AddLValueType This should say ref in the name. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1094 +return

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra accepted this revision. tra added a comment. LGTM. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67509/new/ https://reviews.llvm.org/D67509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67635: Fix for stringized function-macro args continued across lines

arphaman added a comment. In D67635#1675606 , @kousikk wrote: > Thanks! I will need you to merge this one too! Sure, I will commit it today. I think you should obtain commit access for your future patches/commits. You can follow the instructions here:

r372356 - [CUDA][HIP] Re-apply part of r372318.

Author: hliao Date: Thu Sep 19 14:26:18 2019 New Revision: 372356 URL: http://llvm.org/viewvc/llvm-project?rev=372356=rev Log: [CUDA][HIP] Re-apply part of r372318. - r372318 causes violation of `use-of-uninitialized-value` detected by MemorySanitizer. Once `Viable` field is set to false,

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl updated this revision to Diff 220912. yaxunl added a comment. revise by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67509/new/ https://reviews.llvm.org/D67509 Files: lib/Sema/SemaCUDA.cpp test/SemaCUDA/default-ctor.cu Index:

r372353 - Revert "[CUDA][HIP] Fix typo in `BestViableFunction`"

Author: hctim Date: Thu Sep 19 14:11:28 2019 New Revision: 372353 URL: http://llvm.org/viewvc/llvm-project?rev=372353=rev Log: Revert "[CUDA][HIP] Fix typo in `BestViableFunction`" Broke the msan buildbots (see comments on rL372318 for more details). This reverts commit

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:386-387 + bool NeedsH = true, NeedsD = true; + bool HasH = MemberDecl->hasAttr(); + bool HasD = MemberDecl->hasAttr(); + Nice. Now these can be moved above `HasExpAttr` and then used in its

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl updated this revision to Diff 220907. yaxunl added a comment. simplify logic by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67509/new/ https://reviews.llvm.org/D67509 Files: lib/Sema/SemaCUDA.cpp test/SemaCUDA/default-ctor.cu Index:

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus added a comment. In retrospect, I would have made this patch a little more fragmented (its almost a year old, does it beat the revival of the symbolreaper patch?), but it would be a painful chore to separate at this point, if you dont mind. I have a couple more cooking in the

[PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wonder what's the motivation for making this a setting in the ExternalASTSource? Opposed to e.g. storing a bit in AsmLabelAttr, which we could squeeze in by maybe stealing a

[PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

rjmccall added inline comments. Comment at: clang/lib/AST/Mangle.cpp:137 +(!Source || Source->UseGlobalPrefixInAsmLabelMangle())) Out << '\01'; // LLVM IR Marker for __asm("foo") This is one of those bugs where looking at the code really reveals

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus marked an inline comment as done. Szelethus added a comment. In D54823#1675604 , @NoQ wrote: > Is it just me or phabricator somehow refuses to display the changes since the > last diff here? That's probably the commit diff is involved somehow.

[PATCH] D67635: Fix for stringized function-macro args continued across lines

kousikk added a comment. Thanks! I will need you to merge this one too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 ___ cfe-commits mailing list

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

NoQ added a comment. Is it just me or phabricator somehow refuses to display the changes since the last diff here? That's probably the commit diff is involved somehow. So i'm confused what exactly has changed >.< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

erik.pilkington created this revision. erik.pilkington added a reviewer: aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, and don't belong in

[PATCH] D67632: [libTooling] Introduce new library of source-code builders.

ymandel updated this revision to Diff 220901. ymandel added a comment. Added parens operator; cleaned comments and api a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67632/new/ https://reviews.llvm.org/D67632 Files:

[PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

vsk created this revision. vsk added reviewers: teemperor, jasonmolenda, rjmccall. LLDB may synthesize decls using asm labels. These decls cannot have a mangle different than the one specified in the label name. I.e., the mangle-suppression prefix should not be added. Fixes an expression

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

dblaikie added a comment. Looks like this might benefit from being split into independent changes - the work related to templates (I haven't looked closely, but I assume that's fairly indivisible) and the work related to other diagnostics seems fairly separable - and maybe there's other pieces

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. This is to address a request made in https://bugs.llvm.org/show_bug.cgi?id=43144 Add the ability to not have a space before and

[PATCH] D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. "Also, fix the order of if statements so that an explicit return_typestate annotation takes precedence over the default behavior for rvalue refs." I'd probably have split that out into a

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:387 + // each inference gets same result and not to add duplicate attributes. + auto addBothAttr = [=]() { +assert(MemberDecl->hasAttr() == `addHDAttrIfNeeded` ? We may not even need it. See

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl updated this revision to Diff 220892. yaxunl edited the summary of this revision. yaxunl added a comment. Skip inferring for explicit host/device attrs only. Adds checks for implicit device and host attrs and avoid duplicates. CHANGES SINCE LAST ACTION

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus added a comment. In D54823#1675352 , @Szelethus wrote: > Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting > in favor checking whether putting `CallDescriptionMap` in would be too > invasive, but really, can't be

[PATCH] D67635: Fix for stringized function-macro args continued across lines

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

kmclaughlin updated this revision to Diff 220886. kmclaughlin added a comment. - Some minor changes, including removing an unnecessary break - Simplified checks of D.Kind in Function.cpp to determine if it is a Subdivide2Argument or Subdivide4Argument CHANGES SINCE LAST ACTION

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaCUDA.cpp:273-274 + MemberDecl->hasAttr(); + if (!InClass || hasAttr) +return false; + yaxunl wrote: > tra wrote:

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:273-274 + MemberDecl->hasAttr(); + if (!InClass || hasAttr) +return false; + tra wrote: > A comment here would be helpful. > > I think

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill marked an inline comment as done. lewis-revill added a comment. In D62686#1675347 , @lenary wrote: > We discussed this in the RISC-V meeting on 19 Sept 2019. @apazos says there > are some SPEC failures in both 2006 and 2017, which would be

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:273-274 + MemberDecl->hasAttr(); + if (!InClass || hasAttr) +return false; + A comment here would be helpful. I think the intent here is to look for implicit special members with

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:72 +def FeatureSaveRestore : SubtargetFeature<"save-restore", "EnableSaveRestore", + "true", "Enable save/restore.">; lewis-revill wrote: > lenary

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill marked 2 inline comments as done. lewis-revill added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:72 +def FeatureSaveRestore : SubtargetFeature<"save-restore", "EnableSaveRestore", + "true", "Enable

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook updated this revision to Diff 220876. simoncook added a comment. Update to reflect comments about the fact registers are explicitly reserved. In addition to @lenary 's suggested change, I renamed `isReservedReg` to note the check that we are checking if its a user provided

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus updated this revision to Diff 220873. Szelethus added a comment. Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting in favor checking whether putting `CallDescriptionMap` in would be too invasive, but really, can't be worse then it already is. CHANGES

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lenary added a comment. Two nits, that I wanted to submit before the meeting, but didn't get around to. Comment at: llvm/lib/Target/RISCV/RISCV.td:72 +def FeatureSaveRestore : SubtargetFeature<"save-restore", "EnableSaveRestore", +

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lenary added a comment. We discussed this in the RISC-V meeting on 19 Sept 2019. @apazos says there are some SPEC failures in both 2006 and 2017, which would be good to triage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/

r372334 - Revert r372325 - Reverting r372323 because it broke color tests on Linux.

Author: aaronballman Date: Thu Sep 19 08:10:51 2019 New Revision: 372334 URL: http://llvm.org/viewvc/llvm-project?rev=372334=rev Log: Revert r372325 - Reverting r372323 because it broke color tests on Linux. This corrects the testing issues. Modified:

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Herald added a subscriber: Charusso. Herald added a project: LLVM. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:3090 return checkPointerEscapeAux(State, Escaped, Call, Kind, -

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:56 + const auto *ID = Result.Nodes.getNodeAs("impl"); + diag(ID->getLocation(), "%0 implements -isEqual: without implementing -hash") + << ID; Do you

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:512 } - void setVector(const APValue *E, unsigned N) { + void ReserveVector(unsigned N) { assert(isVector() && "Invalid accessor"); `reserveVector` per naming

r372325 - Reverting r372323 because it broke color tests on Linux.

Author: aaronballman Date: Thu Sep 19 06:59:53 2019 New Revision: 372325 URL: http://llvm.org/viewvc/llvm-project?rev=372325=rev Log: Reverting r372323 because it broke color tests on Linux. http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/17919 Modified:

r372323 - Remove an unsafe member variable that wasn't needed; NFC.

Author: aaronballman Date: Thu Sep 19 06:51:50 2019 New Revision: 372323 URL: http://llvm.org/viewvc/llvm-project?rev=372323=rev Log: Remove an unsafe member variable that wasn't needed; NFC. People use the AST dumping interface while debugging, so it's not safe to assume that a declaration

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

sdesmalen added a comment. Thanks for the changes @kmclaughlin! Just a few more nits from me, but looks good otherwise. Comment at: include/llvm/IR/DerivedTypes.h:493 +llvm_unreachable("Cannot create narrower fp vector element type"); +break; + }

r372321 - [OpenCL] Add version handling and add vector ld/st builtins

Author: svenvh Date: Thu Sep 19 06:41:51 2019 New Revision: 372321 URL: http://llvm.org/viewvc/llvm-project?rev=372321=rev Log: [OpenCL] Add version handling and add vector ld/st builtins Allow setting a MinVersion, stating from which OpenCL version a builtin function is available, and a

r372319 - Clean out unused diagnostics. NFC.

Author: d0k Date: Thu Sep 19 06:35:27 2019 New Revision: 372319 URL: http://llvm.org/viewvc/llvm-project?rev=372319=rev Log: Clean out unused diagnostics. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td cfe/trunk/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm added inline comments. Comment at: clang/include/clang/Driver/Driver.h:69 +CLMode, +FlangMode, } Mode; kiranchandramohan wrote: > Is the comma by choice? It was not. Fixed. Comment at:

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 220856. peterwaller-arm marked 14 inline comments as done. peterwaller-arm edited the summary of this revision. peterwaller-arm added a comment. Thanks everyone for your comments. Changes since last patch: - Reintroduce handling of (no phase arg

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

This revision was automatically updated to reflect the committed changes. Closed by commit rL372318: [CUDA][HIP] Fix typo in `BestViableFunction` (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67730: [CUDA][HIP] Fix typo in `BestViableFunction`

hliao marked 3 inline comments as done. hliao added a comment. r372318 with test case revised following suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67730/new/ https://reviews.llvm.org/D67730

[PATCH] D67744: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372317: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r372318 - [CUDA][HIP] Fix typo in `BestViableFunction`

Author: hliao Date: Thu Sep 19 06:14:03 2019 New Revision: 372318 URL: http://llvm.org/viewvc/llvm-project?rev=372318=rev Log: [CUDA][HIP] Fix typo in `BestViableFunction` Summary: - Should consider viable ones only when checking SameSide candidates. - Replace erasing with clearing viable flag

[clang-tools-extra] r372317 - [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors.

Author: ymandel Date: Thu Sep 19 06:12:05 2019 New Revision: 372317 URL: http://llvm.org/viewvc/llvm-project?rev=372317=rev Log: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors. Summary: After revision 370919, this check incorrectly flags certain cases

[libclc] r372316 - Creating release candidate final from release_900 branch

Author: hans Date: Thu Sep 19 06:10:55 2019 New Revision: 372316 URL: http://llvm.org/viewvc/llvm-project?rev=372316=rev Log: Creating release candidate final from release_900 branch Added: libclc/tags/RELEASE_900/final/ - copied from r372315, libclc/branches/release_90/

[libunwind] r372316 - Creating release candidate final from release_900 branch

Author: hans Date: Thu Sep 19 06:10:55 2019 New Revision: 372316 URL: http://llvm.org/viewvc/llvm-project?rev=372316=rev Log: Creating release candidate final from release_900 branch Added: libunwind/tags/RELEASE_900/final/ - copied from r372315, libunwind/branches/release_90/

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

kmclaughlin added a comment. Thanks for reviewing this patch, @rovka and @sdesmalen! Comment at: include/llvm/IR/Intrinsics.h:130 + Kind == PtrToElt || Kind == VecElementArgument || + Kind == Subdivide2Argument || Kind == Subdivide4Argument);

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

kmclaughlin updated this revision to Diff 220845. kmclaughlin marked 5 inline comments as done. kmclaughlin added a reviewer: rovka. kmclaughlin added a comment. - Moved getNarrowerFpElementVectorType logic into getTruncatedElementVectorType - Shared code which handles Subdivide2Argument and

[PATCH] D67744: [clang-tidy] Fix bugprone-argument-comment-check to correctly ignore implicit constructors.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67744/new/ https://reviews.llvm.org/D67744

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl updated this revision to Diff 220838. yaxunl retitled this revision from "[CUDA][HIP] Diagnose defaulted constructor only if it is used" to "[CUDA][HIP] Fix hostness of defaulted constructor". yaxunl edited the summary of this revision. yaxunl added a comment. Posts a new fix for this

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. Any comment on whether we should split this into two patches? One that adds `MCTargetOptions` to `MCAsmInfo` and another one that just fixes prefixes for Mips. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220830. mbrkusanin added a comment. - `MipsMCAsmInfo()` now always reads ABI from `MipsABIInfo` instead of `Triple`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

r372307 - [TestCommit] Trivial change to test commit access.

Author: markrvmurray Date: Thu Sep 19 02:24:42 2019 New Revision: 372307 URL: http://llvm.org/viewvc/llvm-project?rev=372307=rev Log: [TestCommit] Trivial change to test commit access. Modified: cfe/trunk/bindings/python/README.txt Modified: cfe/trunk/bindings/python/README.txt URL:

r372306 - [TestCommit] Trivial change to test commit access.

Author: markrvmurray Date: Thu Sep 19 02:02:12 2019 New Revision: 372306 URL: http://llvm.org/viewvc/llvm-project?rev=372306=rev Log: [TestCommit] Trivial change to test commit access. Modified: cfe/trunk/bindings/python/README.txt Modified: cfe/trunk/bindings/python/README.txt URL:

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

furdyna created this revision. furdyna added reviewers: rsmith, ioeric. Herald added a project: clang. furdyna edited the summary of this revision. By additional regex match, grouping of main include can be enabled in files that are not normally considered as a C/C++ source code. For example,

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:158 + // i.e: a::Bar> instead of a::Bar> + printTemplateArgumentList(OS, TSTL.getTypePtr()->template_arguments(), +

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} positions provided to SelectionRange. Supports exactly one " hokein wrote: > maybe

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. I think we're missing the client/server capability implementation in this patch, we should include them. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0}

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MissingHashCheck.cpp:40 +void MissingHashCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + objcMethodDecl(

[PATCH] D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4)

sdesmalen added inline comments. Comment at: include/llvm/IR/DerivedTypes.h:500 +default: + assert(0 && "Cannot create narrower fp vector element type"); + break; nit: Use `llvm_unreachable("message")` instead of `assert(0 && "message")`

[PATCH] D67737: [clang-tidy] Add check for classes missing -hash ⚠️

stephanemoore updated this revision to Diff 220823. stephanemoore added a comment. Restrict ojbc-missing-hash to Objective-C language variants and fix sorting of release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67737/new/

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 220821. kadircet marked 17 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files:

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:78 +// function decl. Skips local symbols. +llvm::DenseSet getNonLocalDeclRefs(const FunctionDecl *FD, + ParsedAST ) {

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. To be used by define-inline code action to determine whether the function/method body will still be valid

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674902 , @SouraVX wrote: > In D67613#1674597 , @aprantl wrote: > > > Please be sure the watch the lldb (and other debugger) bots after > > committing this.. > > > Thanks a lot!

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

aheejin added a comment. +1 on erroring out on the backend side. And how about "wasm64 is not supported"? wasm64... is still a registered target in the frontend, so... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/